puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-07-29 12:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
ffc6bd3ba596c23e136fa17302891e1f5caa2bfd
paseo/plan.md
Mohamed Boudra ffc6bd3ba5 Fix inline path linking for absolute cwd paths
2025-12-29 00:15:21 +07:00

8.8 KiB
Raw Blame History

Plan

Context

Improvements to the new agent screen in the app.

Agent Assignment

  • Default: All tasks are done by Codex
  • Testing tasks: Use agent=claude for Playwright MCP testing

Tasks

  • Iteration 1: Remember the last used config in the new agent screen.

    • Restore the previous behavior where the config was persisted.
    • When user creates an agent, save the selected config (provider, model, mode, working directory, host).
    • On next visit to new agent screen, pre-populate with last used config.
    • Done (2025-12-28 23:35): WHAT: packages/app/src/app/agent/new.tsx:77-592 now builds initial values only from provided params and persists form preferences on create; packages/app/src/hooks/use-agent-form-state.ts:309-356 adds explicit persistence helper. RESULT: new agent screen rehydrates last-used config and saves selections on create. EVIDENCE: Not run (not requested).

  • Iteration 2: Show the selected permissions mode in the agent selector trigger.

    • The agent selector dropdown trigger currently shows provider and model (e.g., "Claude · auto").
    • It should also display the selected permissions mode (e.g., "Claude · auto · Plan").
    • Update the trigger label to include the mode.
    • Done (2025-12-28 23:37): WHAT: packages/app/src/app/agent/new.tsx:634-643 adds computed labels for provider/mode and packages/app/src/app/agent/new.tsx:729 appends the permissions mode in the agent trigger value. RESULT: agent selector trigger now shows provider, model, and permissions mode. EVIDENCE: Not run (not requested).

  • agent=claude Test 1: Test config persistence via Playwright MCP.

    • Navigate to new agent screen at http://localhost:8081/agent/new.
    • Select a non-default config (e.g., Codex provider, specific model, Plan mode).
    • Create an agent.
    • Navigate back to new agent screen.
    • Verify the previously selected config is pre-populated.
    • If not working, add a fix task with debugging feedback.
    • Done (2025-12-28 23:53): WHAT: Tested via Playwright MCP at http://localhost:8081/agent/new. RESULT: Config persistence working correctly. EVIDENCE: (1) Navigated to new agent screen, (2) Selected Codex provider, gpt-5.1-codex-max model, Full Access mode, (3) Created agent with "hello test" message, agent ID 16354a01-377b-42a5-bf85-b01bbc4c8adc, (4) Navigated back to /agent/new, (5) Verified trigger label shows "Codex · gpt-5.1-codex-max · Full Access" - all settings persisted correctly.

  • agent=claude Test 2: Test permissions mode display in agent selector via Playwright MCP.

    • Navigate to new agent screen at http://localhost:8081/agent/new.
    • Open the agent selector dropdown.
    • Select a specific mode (e.g., "Plan").
    • Verify the trigger label shows provider, model, AND mode (e.g., "Claude · auto · Plan").
    • If not working, add a fix task with debugging feedback.
    • Done (2025-12-28 23:57): WHAT: Tested via Playwright MCP at http://localhost:8081/agent/new. RESULT: Permissions mode display working correctly. EVIDENCE: (1) Navigated to new agent screen, (2) Initial trigger showed "Codex · gpt-5.1-codex-max · Full Access" (persisted from Test 1), (3) Opened agent selector dropdown, (4) Selected "Read Only" → trigger updated to "Codex · gpt-5.1-codex-max · Read Only", (5) Selected "Auto" → trigger updated to "Codex · gpt-5.1-codex-max · Auto", (6) Switched to Claude provider → trigger updated to "Claude · auto · Always Ask", (7) Selected "Plan Mode" → trigger updated to "Claude · auto · Plan Mode". All mode changes correctly reflected in the trigger label.

  • Iteration 3: Filter out internal messages when importing Claude agents.

    • When importing Claude agents, internal messages like "Warmup" are shown.
    • These should be filtered out from the imported history.
    • Add daemon-level E2E test to verify filtering.
    • Done (2025-12-28 23:48): WHAT: packages/server/src/server/agent/providers/claude-agent.ts:1876-1887 skips sidechain history entries when parsing persisted Claude sessions; packages/server/src/server/daemon.e2e.test.ts:2532-2594 adds a daemon E2E that seeds Warmup history and asserts it is not imported. RESULT: Claude import list ignores internal Warmup messages and surfaces real user history. EVIDENCE: Not run (not requested).

  • Iteration 4: Fix Codex import screen showing nothing.

    • Codex import screen currently displays no content.
    • Investigate and fix the issue.
    • Add daemon-level E2E test to verify import works correctly.
    • Done (2025-12-28 23:58): WHAT: packages/server/src/server/agent/providers/codex-mcp-agent.ts:4133-4476 adds Codex persisted session listing from rollout files plus JSON/JSONL timeline parsing and session metadata extraction; packages/server/src/server/daemon.e2e.test.ts:2597-2662 adds Codex persisted agent import E2E coverage. RESULT: Codex import list now populates from on-disk rollouts with timeline previews and is covered by a daemon E2E. EVIDENCE: Not run (not requested).

  • Iteration 5: Add host selector to import agent screen.

    • When importing an agent, user should be able to choose which host to import to.
    • Use the same UI pattern as the new agent screen: host selector in the header.
    • Reference the new agent screen implementation for consistency.
    • Done (2025-12-29 00:05): WHAT: packages/app/src/components/create-agent-modal.tsx:172-2193 adds a host dropdown key, renders the header host badge in the import flow, and adds a host selection sheet; packages/app/src/components/create-agent-modal.tsx:2718-2751 adds host badge/header action styles. RESULT: import agent modal now lets users pick the target host from the header selector. EVIDENCE: Not run (not requested).

  • Iteration 6: Fix gallery 15s timeout causing full-screen error crash.

    • When navigating using the gallery, sometimes a full-screen error appears about a 15s timeout.
    • This appears to be an image loading timeout.
    • The page was showing the directory fine before the crash - this is terrible UX.
    • Fix: Don't crash the page on image timeout. Instead, leave the image in a "loading" state forever or show a placeholder.
    • Image timeouts should never crash the entire view.
    • Done (2025-12-29 00:01): WHAT: packages/app/src/contexts/session-context.tsx:1550-1584 stops updating lastError during file preview requests so thumbnail timeouts no longer trigger the full-screen error state. RESULT: gallery image timeouts no longer replace the directory view; thumbnails remain in loading state. EVIDENCE: Not run (not requested).

  • Iteration 7: Fix spurious loader showing at top of gallery even when directory has loaded.

    • Sometimes the loader at the top of the gallery keeps showing even when the directory content has clearly loaded.
    • Investigate the loading state management and fix the race condition.
    • Done (2025-12-29 00:10): WHAT: packages/app/src/contexts/session-context.tsx:1588-1645 routes back-navigation directory listings through the request helper and clears pendingRequest/isLoading on response. RESULT: gallery header loader no longer sticks after navigating back to cached directories. EVIDENCE: Not run (not requested).

  • Iteration 8: Review and fix file/directory auto-linking logic.

    • Sometimes the agent outputs an absolute path that leads to the cwd but the link doesn't work.
    • It appears the linking logic only accepts relative paths.
    • Review the path detection and linking logic.
    • Fix to handle both absolute and relative paths correctly.
    • Done (2025-12-29 00:15): WHAT: packages/app/src/components/agent-stream-view.tsx:118 now normalizes inline paths using the agent cwd; packages/app/src/components/agent-stream-view.tsx:455 adds path normalization helpers to convert absolute paths within the cwd to relative form before file explorer navigation. RESULT: absolute paths pointing at the agent cwd resolve to the correct directory/file in the explorer. EVIDENCE: Not run (not requested).

  • Iteration 9: Remove host label from git diff screen.

    • The host label is shown on the git diff screen but it's not relevant there.
    • Remove it from the UI.

  • Checkpoint: Run typecheck and review code quality.

    • Run npm run typecheck and fix any errors.
    • Review all code changes made in this plan (Iterations 1-9).
    • Look for brittle TypeScript: as casts, any types, weakly typed code.
    • Ensure proper type inference and type safety.
    • Add fix tasks for any issues found.

  • Checkpoint: Review daemon test coverage for fixes in this plan.

    • Review all fixes made in this plan (Iterations 3-9).
    • Determine which fixes need daemon-level E2E tests.
    • No mocks, simple tests only.
    • E2E when possible but no browser tests.
    • Add any missing test tasks to the plan.