mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-30 05:02:58 +00:00
nllptrxandMohamed Boudra
4a5716360b
* feat(protocol): add forge check presentation metadata Expose optional rawStatus, isManual, and requiresAction fields while keeping older check payloads backward-compatible. * fix(gitea): model Actions jobs as tasks Gitea's /actions/tasks endpoint returns individual jobs rather than workflow runs. Preserve sibling tasks from the latest execution, avoid collapsing same-name jobs, and enrich blocked tasks with run-level approval metadata. * feat(app): distinguish forge check presentation states * fix(gitlab): preserve pipeline job semantics * refactor(app): centralize forge check presentation policy Use one canonical category order, count shape, visual policy, and translated copy mapping across sidebar, hover-card, PR-pane, and GitLab pipeline surfaces. * refactor: consolidate forge check handling * feat(forge): auto-attach pasted forge references * docs(compat): correct forge rollout metadata * refactor(forge): model check nuances as traits * fix(forge): harden checks from branch review Structural Gitea Actions shadow dedup by run id (verified upstream), rerun grouping without workflow_id, shared trait/status constants and Gitea state mapping in the protocol package, all cloud host aliases in pasted-link matching, logged glab job-detail failures, concurrent approvals/pipeline fetch, checks aggregate from the same pipeline as the job list, and removal of the unread check-level rawStatus. The released pipeline-level rawStatus is staged for removal under COMPAT(pipelineRawStatus). * fix(gitea): detect fork-PR Actions approval hold as action_required gitea.com represents a fork PR awaiting Actions approval as a run in status "waiting" with no tasks and pending shadow commit statuses; it does not expose need_approval. The previous mapping only set action_required from a task with blocked+need_approval, so the gate never surfaced (0 tasks -> early return; need_approval absent). Detect the hold from /actions/runs: a waiting/blocked run whose PR is cross-repo (head.repo.id != base.repo.id), or one that does expose need_approval (self-hosted). Tag the run's pending shadow statuses action_required. Runs are only fetched when a pending shadow has no covering task, keeping the common path at two requests. Verified live against gitea.com fork PR (run 715170, waiting, cross-repo). * fix(gitea): resolve cross-fork PRs by head sha The current-PR matcher gated candidates on the checkout owner (giteaHeadOwner === expectedHeadOwner), which excludes every fork PR: its head carries the fork owner while the checkout is the base repo, so a fork PR - the only shape that can be approval-held on Gitea - never resolved and its checks never showed in-app. GitLab has no such gate (it resolves fork MRs from the target project by source branch). Accept a recent PR whose head sha equals the workspace head sha regardless of owner; the sha is an unambiguous identity, so the anti-collision owner gate still applies when no sha match is available. Verified live against gitea.com fork PR #6 (resolves + renders action_required). * fix: resolve forge rebase drift * fix: type forge auto-attach boundary * fix(i18n): add Korean check status copy --------- Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
56 lines
2.1 KiB
TypeScript
56 lines
2.1 KiB
TypeScript
import type { TFunction } from "i18next";
|
|
import {
|
|
COUNTED_CHECK_PRESENTATIONS,
|
|
classifyCheck,
|
|
type CheckPresentationCounts,
|
|
type CountedCheckPresentation,
|
|
type PresentableCheck,
|
|
} from "./check-presentation";
|
|
|
|
const CHECK_PRESENTATION_COUNT_KEYS = {
|
|
success: "sidebar.workspace.checks.passed",
|
|
failure: "sidebar.workspace.checks.failed",
|
|
warning: "sidebar.workspace.checks.warning",
|
|
actionRequired: "sidebar.workspace.checks.actionRequired",
|
|
manual: "sidebar.workspace.checks.manual",
|
|
pending: "sidebar.workspace.checks.pending",
|
|
} as const satisfies Record<CountedCheckPresentation, string>;
|
|
|
|
const CHECK_PRESENTATION_STATUS_KEYS = {
|
|
success: "workspace.git.pr.accessibility.checkStatus.passed",
|
|
failure: "workspace.git.pr.accessibility.checkStatus.failed",
|
|
warning: "workspace.git.pr.accessibility.checkStatus.warning",
|
|
actionRequired: "workspace.git.pr.accessibility.checkStatus.actionRequired",
|
|
manual: "workspace.git.pr.accessibility.checkStatus.manual",
|
|
pending: "workspace.git.pr.accessibility.checkStatus.pending",
|
|
} as const satisfies Record<CountedCheckPresentation, string>;
|
|
|
|
export function getCheckPresentationCountLabel(
|
|
presentation: CountedCheckPresentation,
|
|
count: number,
|
|
t: TFunction,
|
|
): string {
|
|
return t(CHECK_PRESENTATION_COUNT_KEYS[presentation], { count });
|
|
}
|
|
|
|
export function formatCheckPresentationCountsLabel(
|
|
counts: CheckPresentationCounts,
|
|
heading: string,
|
|
t: TFunction,
|
|
): string {
|
|
const labels = COUNTED_CHECK_PRESENTATIONS.flatMap((presentation) => {
|
|
const count = counts[presentation];
|
|
return count > 0 ? [getCheckPresentationCountLabel(presentation, count, t)] : [];
|
|
});
|
|
return [heading, ...labels].join(", ");
|
|
}
|
|
|
|
export function getCheckPresentationStatusLabel(check: PresentableCheck, t: TFunction): string {
|
|
const presentation = classifyCheck(check);
|
|
if (presentation !== "ignored") return t(CHECK_PRESENTATION_STATUS_KEYS[presentation]);
|
|
if (check.status === "cancelled") {
|
|
return t("workspace.git.pr.accessibility.checkStatus.cancelled");
|
|
}
|
|
return t("workspace.git.pr.accessibility.checkStatus.skipped");
|
|
}
|