mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-23 01:32:40 +00:00
paseo-bot[bot]
6d37f7fd9f
* Close agents before stopping the plugins that serve them A clean daemon shutdown stopped every plugin before it closed any agent. Stopping a plugin withdraws its provider registrations, which pushes an empty registration set through the agent provider registry, shuts the plugin provider client down, and closes each still-open session with `connectionClosed()`. That is reported as `session.runtime_failed` and translated to `turn_failed`, so an agent whose last turn had completed successfully was persisted with `lastError: "Provider connection closed"` and came back after a restart carrying a failure it never had. Stop tracking plugin provider registrations first so plugin teardown can no longer withdraw a provider from under an open agent, and stop the plugins themselves after `closeAllAgents()` and the provider runtime shutdown have already made every session terminal. Closing the sessions while their plugin is still running also means `session.close` now reaches the provider. Fixes #4877 * Bound each agent close so a silent provider cannot stall shutdown Closing an agent asks its provider to close the session and waits for the answer, and that request is only rejected when the provider runtime shuts down. With agents now closing before the runtime does, a provider that never answers `session.close` would leave `closeAllAgents()` waiting with nothing left to unblock it. Give each close a deadline. Whatever outlives it is abandoned and logged, and the provider runtime shutdown that runs next rejects the request that was still pending. Also type the test fixture's `send` input as `ProviderInput`. * Move the shutdown tests into the plugin lifecycle suite Both tests exercise plugin lifecycle against a real daemon, which lifecycle.e2e.test.ts already covers, so they go there rather than into a suite of their own. Drop the wall-clock assertion on how long stop() took. What the test establishes is that stop() returns at all, and the suite timeout is what enforces that; measuring elapsed time only added a second bound that a loaded machine could trip. --------- Co-authored-by: paseo-bot[bot] <266920839+paseo-bot[bot]@users.noreply.github.com>