Compare commits

..
Author SHA1 Message Date
Mohamed Boudra bce306238b fix(server): keep a gotgenes foreground answer on replay
A foreground @gotgenes/pi-subagents child finds its session file only
through the live runtime marker, which history does not keep. Without a
file, emit the spawn result text as the child's assistant message.
2026-10-30 12:01:23 +01:00
Mohamed Boudra c1bcfd930b fix(server): settle child compactions and keep sub-agent cards stable
- Codex: a child compaction shown as loading now completes on the
  child's thread/compacted or turn end, once.
- Claude: a streamed child tool call's empty start input is a
  placeholder, so the assistant message's input reaches its card.
- OMP: the task card follows only its first child, so later children
  no longer re-send an unchanged card.
2026-10-30 11:47:33 +01:00
Mohamed Boudra 6953ba6506 fix(server): put a tintinweb foreground answer in the child timeline
A foreground @tintinweb/pi-subagents child has no session file, so its
answer only exists in the Agent tool result. Emit that text as the
child's assistant message when the child finishes. Tag every sub_agent
producer's `log: ""` with COMPAT(subagent-log) so the shim removal
finds them.
2026-10-30 09:49:51 +01:00
Mohamed Boudra a68a0c2c5f fix: make sub-agent cards launch markers
Sub-agent tool calls no longer accumulate the child's activity into
`log`. Claude, Codex, OpenCode, OMP and Pi emit the card when the child
starts and when its label or status changes; the child's messages and
tool calls stay in the sub-agent's own timeline. The app no longer
renders a sub-agent log.

The wire schema makes `log` optional. Daemons still send `log: ""` so
apps that require the field keep parsing the card.
2026-10-30 08:35:04 +01:00
114 changed files with 867 additions and 3022 deletions
-10
View File
@@ -493,16 +493,6 @@ The supervisor alone publishes its ready worker's endpoint in `paseo.pid`, clear
Worker restart retains supervisor arguments/environment and rereads the configuration file. Updating a package and observing its new worker version do not refresh the running supervisor code; the launcher owns full-process replacement. See [CLI lifecycle contracts](../public-docs/cli.md#daemon-management). Worker restart retains supervisor arguments/environment and rereads the configuration file. Updating a package and observing its new worker version do not refresh the running supervisor code; the launcher owns full-process replacement. See [CLI lifecycle contracts](../public-docs/cli.md#daemon-management).
## Outbound networking
The daemon and its plugin processes honor `HTTPS_PROXY`, `HTTP_PROXY`, and `NO_PROXY`
(including lowercase forms, which take precedence). Fetch and relay, Hub, and connected-host WebSockets
share this policy. Loopback (`localhost`, `127.0.0.1`, `::1`) always goes direct.
A proxy without a scheme uses HTTP. Invalid values and unsupported proxy schemes
are treated as unset, with one warning naming the variable in `daemon.log`.
Agent and terminal environments are unchanged. System proxy settings and SOCKS-only
`ALL_PROXY` configurations are not supported.
## Deployment models ## Deployment models
1. **Local daemon** (default): `paseo daemon start` on `127.0.0.1:6767` 1. **Local daemon** (default): `paseo daemon start` on `127.0.0.1:6767`
-1
View File
@@ -38,7 +38,6 @@ Authoritative terminology. UI label wins. Don't invent synonyms; use what's here
- **Usage source** — Plugin registration that discovers accounts and fetches plan usage. Code: `UsageSourceRegistration` (`packages/plugin/src/server/usage.ts`). - **Usage source** — Plugin registration that discovers accounts and fetches plan usage. Code: `UsageSourceRegistration` (`packages/plugin/src/server/usage.ts`).
- **Report ID** — Stable daemon-composed identity for one source account: `<sourceId>:<accountKey>`. The source owns the account key; clients treat the whole ID as opaque. Code: `UsageReportEntry.id` (`packages/protocol/src/messages.ts`). - **Report ID** — Stable daemon-composed identity for one source account: `<sourceId>:<accountKey>`. The source owns the account key; clients treat the whole ID as opaque. Code: `UsageReportEntry.id` (`packages/protocol/src/messages.ts`).
- **Usage report** — A source's normalized usage for one account, including status and optional windows, balances, and details. Its entry carries the Report ID, account label, and fetch time. Each report renders as one card in the Usage modal, in host Settings, and in an agent's context window details (a hover card on desktop web, a tooltip on native wide screens, a sheet on compact ones), which show only the account that agent runs under, without pins. The hover card and the sheet have Refresh; the native tooltip takes no presses. Code: `UsageReport` (`packages/plugin/src/server/usage.ts`), `UsageCard` (`packages/app/src/usage/card.tsx`), `AgentUsage` (`packages/app/src/usage/agent-usage.tsx`). - **Usage report** — A source's normalized usage for one account, including status and optional windows, balances, and details. Its entry carries the Report ID, account label, and fetch time. Each report renders as one card in the Usage modal, in host Settings, and in an agent's context window details (a hover card on desktop web, a tooltip on native wide screens, a sheet on compact ones), which show only the account that agent runs under, without pins. The hover card and the sheet have Refresh; the native tooltip takes no presses. Code: `UsageReport` (`packages/plugin/src/server/usage.ts`), `UsageCard` (`packages/app/src/usage/card.tsx`), `AgentUsage` (`packages/app/src/usage/agent-usage.tsx`).
- **Check usage** — Host-wide switch in Usage Settings, on by default. Turning it off stops login discovery and vendor requests on that host for every device. Usage shows an off state with **Turn on**; the sidebar summary and agent usage sections disappear.
- **Usage (sidebar item)** — The sidebar footer item showing each pinned window's source icon and percent, hidden while no pinned window has data (the footer's Usage icon remains available); both entry points open the Usage modal over the current screen: a dialog on wide layouts, a bottom sheet on compact ones. Usage has no route of its own. Off until the user turns on **Summary in sidebar** (Usage Settings) or the Usage row in Settings > Sidebar; window rows pin only while it is on, and saved pins come back when it is turned on again. A pin is `{ sourceId, windowId }` and shows once per account of that source. Pins and the used/remaining choice are one per-device preference (`AppSettings.usage`) that every usage surface follows. It reads the active workspace's host, else the first connected host with usage sources. Code: `packages/app/src/usage/sidebar-item.tsx`, `usage/usage-modal.tsx`, `usage/pinned.ts`, `usage/preferences.ts`. - **Usage (sidebar item)** — The sidebar footer item showing each pinned window's source icon and percent, hidden while no pinned window has data (the footer's Usage icon remains available); both entry points open the Usage modal over the current screen: a dialog on wide layouts, a bottom sheet on compact ones. Usage has no route of its own. Off until the user turns on **Summary in sidebar** (Usage Settings) or the Usage row in Settings > Sidebar; window rows pin only while it is on, and saved pins come back when it is turned on again. A pin is `{ sourceId, windowId }` and shows once per account of that source. Pins and the used/remaining choice are one per-device preference (`AppSettings.usage`) that every usage surface follows. It reads the active workspace's host, else the first connected host with usage sources. Code: `packages/app/src/usage/sidebar-item.tsx`, `usage/usage-modal.tsx`, `usage/pinned.ts`, `usage/preferences.ts`.
- **Model** — A specific LLM offered by a provider. UI: "Model" / "Select model". Code: `AgentModelDefinition` (`packages/protocol/src/messages.ts:187`). - **Model** — A specific LLM offered by a provider. UI: "Model" / "Select model". Code: `AgentModelDefinition` (`packages/protocol/src/messages.ts:187`).
- **Tab** — UI surface representing one session inside a workspace. Not a conceptual unit; use **Agent session** when talking about the model. Code: `WorkspaceTabDescriptor` (`packages/app/src/screens/workspace/workspace-tabs-types.ts`). - **Tab** — UI surface representing one session inside a workspace. Not a conceptual unit; use **Agent session** when talking about the model. Code: `WorkspaceTabDescriptor` (`packages/app/src/screens/workspace/workspace-tabs-types.ts`).
-14
View File
@@ -35,20 +35,6 @@ PASEO_MOBILE_E2E_METRO_PORT=62093 npm run test:e2e:mobile
[native-terminal-basic.ios.ad](../packages/app/e2e/mobile/agent-device/native-terminal-basic.ios.ad) and [native-terminal-basic.android.ad](../packages/app/e2e/mobile/agent-device/native-terminal-basic.android.ad) are the smallest examples. Each opens a fresh terminal, types a command at zero delay, submits it, and asserts its distinct output. The app must be connected to a daemon with an active workspace. [native-terminal-basic.ios.ad](../packages/app/e2e/mobile/agent-device/native-terminal-basic.ios.ad) and [native-terminal-basic.android.ad](../packages/app/e2e/mobile/agent-device/native-terminal-basic.android.ad) are the smallest examples. Each opens a fresh terminal, types a command at zero delay, submits it, and asserts its distinct output. The app must be connected to a daemon with an active workspace.
For Android background fold recovery, install the release APK on a foldable AVD, open a
connected workspace, close the keyboard, and run:
```bash
ANDROID_SERIAL=emulator-5574 node packages/app/e2e/mobile/fold/android.mjs
```
The AVD must expose `CLOSED` and `OPENED` device states. The test backgrounds the app,
changes posture, resumes immediately, and asserts compact/wide workspace controls without
restarting the process. It writes snapshots and native failure state under
`.dev/agent-device-artifacts/android-fold`. Set `PASEO_MOBILE_APP_ID=sh.paseo` for a
production package. This needs a native rebuild when the Unistyles patch changes; a Metro
reload cannot update it.
For Android keyboard continuity, run the current checkout in the app, open an idle terminal For Android keyboard continuity, run the current checkout in the app, open an idle terminal
with an empty prompt, hide its keyboard, and run: with an empty prompt, hide its keyboard, and run:
+1 -1
View File
@@ -550,7 +550,7 @@ string is never inline SVG or a URL.
Register a usage source from `index.server.ts` with `server.registerUsageSource()`. Import `UsageSourceRegistration` and normalization helpers from `@getpaseo/plugin/server/usage`. The plugin owns account discovery, harness labels, and credential-store reads; the daemon owns account grouping and the fetch cache. Agent popovers use only the agent's own login. The host-wide Usage modal falls back across an account's logins; any success shows usage only, and all failures show every login's labeled error and remedy. Follow the [usage source discovery contract](../public-docs/plugins/reference.md#usage-sources). The resolved launch environment crosses into the trusted, unsandboxed plugin subprocess for session discovery. Usage queries never run lifecycle hooks. Inputs are validated in the plugin process and remain daemon-side. `icon` uses the same SVG file rules as provider icons. Register a usage source from `index.server.ts` with `server.registerUsageSource()`. Import `UsageSourceRegistration` and normalization helpers from `@getpaseo/plugin/server/usage`. The plugin owns account discovery, harness labels, and credential-store reads; the daemon owns account grouping and the fetch cache. Agent popovers use only the agent's own login. The host-wide Usage modal falls back across an account's logins; any success shows usage only, and all failures show every login's labeled error and remedy. Follow the [usage source discovery contract](../public-docs/plugins/reference.md#usage-sources). The resolved launch environment crosses into the trusted, unsandboxed plugin subprocess for session discovery. Usage queries never run lifecycle hooks. Inputs are validated in the plugin process and remain daemon-side. `icon` uses the same SVG file rules as provider icons.
When the host’s **Check usage** switch is off, the daemon rejects usage requests before discovery, without reading logins or calling vendors. Otherwise, the daemon calls discovery for `usage.list_reports`; the client gates this RPC on `server_info.features.usageSources`. The old `provider.usage.list` RPC maps discovered reports for older clients. The daemon calls discovery for `usage.list_reports`; the client gates this RPC on `server_info.features.usageSources`. The old `provider.usage.list` RPC maps discovered reports for older clients.
## Contribute sidebar items ## Contribute sidebar items
+1 -1
View File
@@ -1 +1 @@
sha256-8NOrrCAxraQ74lP3Vy59MRhloBfzStTc4rW+ltc42Fg= sha256-6C4Rjh0mRVrC9akBVGK0NZaCaLJhwKObT7HrgPmcvyw=
-24
View File
@@ -40690,7 +40690,6 @@
"esbuild": "^0.25.12", "esbuild": "^0.25.12",
"express": "^4.18.2", "express": "^4.18.2",
"fast-deep-equal": "^3.1.3", "fast-deep-equal": "^3.1.3",
"https-proxy-agent": "^7.0.6",
"lru-cache": "^11.5.1", "lru-cache": "^11.5.1",
"markdown-it": "^10.0.0", "markdown-it": "^10.0.0",
"mnemonic-id": "^3.2.7", "mnemonic-id": "^3.2.7",
@@ -40708,7 +40707,6 @@
"strip-ansi": "^7.1.2", "strip-ansi": "^7.1.2",
"tree-kill": "^1.2.2", "tree-kill": "^1.2.2",
"typescript": "^5.9.3", "typescript": "^5.9.3",
"undici": "^7.24.8",
"uuid": "^9.0.1", "uuid": "^9.0.1",
"which": "^5.0.0", "which": "^5.0.0",
"ws": "^8.14.2", "ws": "^8.14.2",
@@ -41282,15 +41280,6 @@
"url": "https://opencollective.com/vitest" "url": "https://opencollective.com/vitest"
} }
}, },
"packages/server/node_modules/agent-base": {
"version": "7.1.4",
"resolved": "https://registry.npmjs.org/agent-base/-/agent-base-7.1.4.tgz",
"integrity": "sha512-MnA+YT8fwfJPgBx3m60MNqakm30XOkyIoH1y6huTQvC0PwZG7ki8NacLBcrPbNoo8vEZy7Jpuk7+jMO+CUovTQ==",
"license": "MIT",
"engines": {
"node": ">= 14"
}
},
"packages/server/node_modules/ajv": { "packages/server/node_modules/ajv": {
"version": "8.20.0", "version": "8.20.0",
"resolved": "https://registry.npmjs.org/ajv/-/ajv-8.20.0.tgz", "resolved": "https://registry.npmjs.org/ajv/-/ajv-8.20.0.tgz",
@@ -41360,19 +41349,6 @@
"@esbuild/win32-x64": "0.25.12" "@esbuild/win32-x64": "0.25.12"
} }
}, },
"packages/server/node_modules/https-proxy-agent": {
"version": "7.0.6",
"resolved": "https://registry.npmjs.org/https-proxy-agent/-/https-proxy-agent-7.0.6.tgz",
"integrity": "sha512-vK9P5/iUfdl95AI+JVyUuIcVtd4ofvtrOr3HNtM2yxC9bnMbEdp3x01OhQNnjb8IJYi38VlTE3mBXwcfvywuSw==",
"license": "MIT",
"dependencies": {
"agent-base": "^7.1.2",
"debug": "4"
},
"engines": {
"node": ">= 14"
}
},
"packages/server/node_modules/isexe": { "packages/server/node_modules/isexe": {
"version": "3.1.5", "version": "3.1.5",
"resolved": "https://registry.npmjs.org/isexe/-/isexe-3.1.5.tgz", "resolved": "https://registry.npmjs.org/isexe/-/isexe-3.1.5.tgz",
@@ -1,69 +0,0 @@
import { expect, test } from "../support/fixtures";
import { gotoAppShell } from "../support/helpers/app";
import { seedSidebarFooterPreferences } from "../support/helpers/sidebar-nav-settings";
import { installUsageReportsFixture } from "../support/helpers/usage-reports";
import {
claudeAndCodexReports,
openUsageFromIcon,
openUsageOptions,
closeUsageOptions,
closeUsage,
expectNoUsageItem,
expectPinnedUsage,
} from "../support/helpers/usage-sidebar-item";
test("Check usage applies to the host and Turn on restores cards", async ({
page,
e2eWorkerClient,
}) => {
test.setTimeout(180_000);
const previous = (await e2eWorkerClient.getDaemonConfig()).config.usage ?? { enabled: true };
try {
const usage = await installUsageReportsFixture(page, {
lists: [() => claudeAndCodexReports()],
});
await page.setViewportSize({ width: 1440, height: 1000 });
await seedSidebarFooterPreferences(page, [{ key: "usage", visible: true }]);
await gotoAppShell(page);
await expectPinnedUsage(page, ["31% 5h", "54% wk", "7% 5h", "12% wk"]);
await openUsageFromIcon(page);
await usage.waitForListRequests(1);
await openUsageOptions(page);
await page.getByRole("switch", { name: "Check usage", exact: true }).click();
await closeUsageOptions(page);
await expect(page.getByRole("button", { name: "Turn on", exact: true })).toBeVisible();
await expect(page.getByRole("button", { name: "Refresh all", exact: true })).toHaveCount(0);
expect((await e2eWorkerClient.getDaemonConfig()).config.usage).toEqual({ enabled: false });
await expectNoUsageItem(page);
const before = usage.listRequests().length;
await closeUsage(page);
await page.reload();
await openUsageFromIcon(page);
await expect(page.getByRole("button", { name: "Turn on", exact: true })).toBeVisible();
expect(usage.listRequests()).toHaveLength(before);
await page.getByRole("button", { name: "Turn on", exact: true }).click();
await expect(page.getByText("Claude", { exact: true })).toBeVisible();
expect((await e2eWorkerClient.getDaemonConfig()).config.usage).toEqual({ enabled: true });
// A separate client changes the policy, as another device would.
await e2eWorkerClient.patchDaemonConfig({ usage: { enabled: false } });
await expect(page.getByRole("button", { name: "Turn on", exact: true })).toBeVisible();
await e2eWorkerClient.patchDaemonConfig({ usage: { enabled: true } });
await expect(page.getByText("Claude", { exact: true })).toBeVisible();
} finally {
await e2eWorkerClient.patchDaemonConfig({ usage: previous });
}
});
test("older hosts keep usage without a Check usage switch", async ({ page }) => {
test.setTimeout(180_000);
await installUsageReportsFixture(page, {
usageSettingSupported: false,
lists: [() => claudeAndCodexReports()],
});
await page.setViewportSize({ width: 1440, height: 1000 });
await gotoAppShell(page);
await openUsageFromIcon(page);
await expect(page.getByText("Claude", { exact: true })).toBeVisible();
await openUsageOptions(page);
await expect(page.getByRole("switch", { name: "Check usage", exact: true })).toHaveCount(0);
});
@@ -441,31 +441,3 @@ test("released hosts supply source logos through the client conversion", async (
).toHaveAttribute("d", codexPath); ).toHaveAttribute("d", codexPath);
await qaScreenshot(page, "released-host-usage-modal"); await qaScreenshot(page, "released-host-usage-modal");
}); });
test("hidden usage sends no requests until opened", async ({ page }) => {
test.setTimeout(180_000);
const usage = await installUsageReportsFixture(page, { lists: [() => claudeAndCodexReports()] });
await page.setViewportSize(WIDE);
await gotoAppShell(page);
await expectNoUsageItem(page);
await expect(page.getByRole("button", { name: "Usage", exact: true })).toBeVisible({
timeout: 90_000,
});
await openSidebarNavSettings(page);
await expectFooterItemSetting(page, "usage", false);
await leaveSettings(page);
expect(usage.listRequests()).toHaveLength(0);
await openUsageFromIcon(page);
await usage.waitForListRequests(1);
expect(usage.listRequests()).toHaveLength(1);
});
test("visible usage summary requests reports on load", async ({ page }) => {
test.setTimeout(180_000);
const usage = await installUsageReportsFixture(page, { lists: [() => claudeAndCodexReports()] });
await seedSidebarFooterPreferences(page, [{ key: "usage", visible: true }]);
await page.setViewportSize(WIDE);
await gotoAppShell(page);
await expectPinnedUsage(page, ["31% 5h", "54% wk", "7% 5h", "12% wk"]);
expect(usage.listRequests()).toHaveLength(1);
});
-104
View File
@@ -1,104 +0,0 @@
// Run a release build with a connected workspace open and the keyboard hidden.
// ANDROID_SERIAL=emulator-5574 node packages/app/e2e/mobile/fold/android.mjs
import assert from "node:assert/strict";
import { execFileSync } from "node:child_process";
import { mkdirSync, writeFileSync } from "node:fs";
import { resolve } from "node:path";
import { setTimeout as delay } from "node:timers/promises";
const serial = process.env.ANDROID_SERIAL;
assert(serial, "Set ANDROID_SERIAL to a booted Android foldable emulator");
const appId = process.env.PASEO_MOBILE_APP_ID ?? "sh.paseo.debug";
const session = "android-fold";
const artifacts = resolve(".dev/agent-device-artifacts/android-fold");
const env = {
...process.env,
AGENT_DEVICE_STATE_DIR: resolve(".dev/agent-device-android-fold"),
};
mkdirSync(artifacts, { recursive: true });
function run(binary, args) {
return execFileSync(binary, args, { env, encoding: "utf8", timeout: 60_000 });
}
function adb(...args) {
return run("adb", ["-s", serial, ...args]);
}
function ad(...args) {
return run("agent-device", [...args, "--session", session]);
}
function pid() {
return adb("shell", "pidof", appId).trim();
}
function open() {
ad("open", appId, "--platform", "android", "--serial", serial, "--no-test-ime");
}
function stateId(name) {
const states = adb("shell", "cmd", "device_state", "print-states");
const match = states.match(new RegExp(`identifier=(\\d+), name='${name}'`));
assert(match, `Emulator must expose the ${name} posture: ${states}`);
return match[1];
}
async function expectLayout(posture) {
const compact = posture === "CLOSED";
const expectedId = compact ? "workspace-tab-switcher-trigger" : "workspace-tabs-scroll";
const unexpectedId = compact ? "workspace-tabs-scroll" : "workspace-tab-switcher-trigger";
const deadline = Date.now() + 15_000;
let nodes = [];
do {
let data;
try {
({ data } = JSON.parse(ad("snapshot", "-i", "--json")));
} catch (error) {
// During display handoff Android briefly has no capturable app window.
if (!error.stdout?.includes("insufficient foreground app content")) throw error;
await delay(200);
continue;
}
assert.equal(data.appBundleId, appId, "Snapshot must belong to Paseo");
nodes = data.nodes;
if (
nodes.some((node) => node.identifier === expectedId) &&
!nodes.some((node) => node.identifier === unexpectedId)
) {
writeFileSync(resolve(artifacts, `${posture}.json`), JSON.stringify(data, null, 2));
console.log(`PASS: ${posture} uses ${compact ? "compact" : "wide"} workspace controls`);
return;
}
await delay(200);
} while (Date.now() < deadline);
writeFileSync(resolve(artifacts, `${posture}-failure.json`), JSON.stringify(nodes, null, 2));
writeFileSync(
resolve(artifacts, "native-failure.txt"),
adb("shell", "dumpsys", "activity", "top"),
);
assert.fail(`${posture}: expected ${expectedId}, without ${unexpectedId}`);
}
const closed = stateId("CLOSED");
const opened = stateId("OPENED");
const initialState = adb("shell", "cmd", "device_state", "state").match(
/Committed state: DeviceState\{identifier=(\d+)/,
)?.[1];
assert(initialState, "Could not read the initial fold state");
try {
adb("shell", "cmd", "device_state", "state", opened);
open();
await expectLayout("OPENED");
const initialPid = pid();
for (const [posture, id] of [
["CLOSED", closed],
["OPENED", opened],
]) {
adb("shell", "input", "keyevent", "KEYCODE_HOME");
adb("shell", "cmd", "device_state", "state", id);
// Resume immediately: waiting for configuration delivery hides the regression.
open();
await expectLayout(posture);
assert.equal(pid(), initialPid, "Fold/resume must preserve the app process");
}
} finally {
adb("shell", "cmd", "device_state", "state", initialState);
ad("close");
}
@@ -28,10 +28,6 @@ interface SeedProjectDescriptor {
* prefer those wrappers over reaching for this client directly. * prefer those wrappers over reaching for this client directly.
*/ */
export interface SeedDaemonClient { export interface SeedDaemonClient {
patchDaemonConfig(
config: import("@getpaseo/protocol/messages").MutableDaemonConfigPatch,
): Promise<{ config: import("@getpaseo/protocol/messages").MutableDaemonConfig }>;
getDaemonConfig(): Promise<{ config: import("@getpaseo/protocol/messages").MutableDaemonConfig }>;
connect(): Promise<void>; connect(): Promise<void>;
close(): Promise<void>; close(): Promise<void>;
addProject(cwd: string): Promise<{ addProject(cwd: string): Promise<{
@@ -25,7 +25,6 @@ interface UsageReportsFixtureOptions {
* app connects, so a reload can switch it. * app connects, so a reload can switch it.
*/ */
usageSupported?: boolean | (() => boolean); usageSupported?: boolean | (() => boolean);
usageSettingSupported?: boolean;
/** Released hosts expose provider.usage.list with no source icons. */ /** Released hosts expose provider.usage.list with no source icons. */
providerUsageListOnly?: boolean; providerUsageListOnly?: boolean;
/** The host daemon's port; defaults to the E2E daemon. */ /** The host daemon's port; defaults to the E2E daemon. */
@@ -64,7 +63,6 @@ function withUsageSupportFeature(
message: WebSocketMessage, message: WebSocketMessage,
enabled: boolean, enabled: boolean,
providerUsageListOnly: boolean, providerUsageListOnly: boolean,
usageSettingSupported: boolean,
): string | null { ): string | null {
const envelope = parseJson(message) as { const envelope = parseJson(message) as {
type?: unknown; type?: unknown;
@@ -88,7 +86,6 @@ function withUsageSupportFeature(
...payload, ...payload,
features: { features: {
...features, ...features,
usageSetting: usageSettingSupported ? true : undefined,
usageSources: enabled && !providerUsageListOnly, usageSources: enabled && !providerUsageListOnly,
providerUsageList: enabled, providerUsageList: enabled,
}, },
@@ -232,12 +229,7 @@ export async function installUsageReportsFixture(
server.onMessage((message) => { server.onMessage((message) => {
const serverInfo = const serverInfo =
typeof message === "string" typeof message === "string"
? withUsageSupportFeature( ? withUsageSupportFeature(message, isUsageSupported(), providerUsageListOnly)
message,
isUsageSupported(),
providerUsageListOnly,
options.usageSettingSupported ?? true,
)
: null; : null;
ws.send(serverInfo ?? message); ws.send(serverInfo ?? message);
}); });
+9 -4
View File
@@ -64,7 +64,12 @@ import { useCloseAgentListGesture } from "@/mobile-panels/gestures";
import { MobilePanelOverlay } from "@/mobile-panels/presentation"; import { MobilePanelOverlay } from "@/mobile-panels/presentation";
import { buildSettingsAddHostRoute, buildSettingsRoute } from "@/utils/host-routes"; import { buildSettingsAddHostRoute, buildSettingsRoute } from "@/utils/host-routes";
import { openHostOverview } from "@/navigation/settings-navigation"; import { openHostOverview } from "@/navigation/settings-navigation";
import { UsageSidebarItem, UsageSidebarRoot, useUsageSummary, useOpenSidebarUsage } from "@/usage"; import {
UsageSidebarItem,
UsageSidebarRoot,
useHasUsageSummary,
useOpenSidebarUsage,
} from "@/usage";
import { SidebarAgentListSkeleton } from "./sidebar-agent-list-skeleton"; import { SidebarAgentListSkeleton } from "./sidebar-agent-list-skeleton";
import { SidebarCalloutSlot } from "./sidebar-callout-slot"; import { SidebarCalloutSlot } from "./sidebar-callout-slot";
import { SidebarWorkspaceList } from "./sidebar-workspace-list"; import { SidebarWorkspaceList } from "./sidebar-workspace-list";
@@ -475,10 +480,10 @@ function SidebarUsageIcon({ label }: { label: string }) {
*/ */
function SidebarFooterRows({ onBeforeNavigate }: { onBeforeNavigate?: () => void }) { function SidebarFooterRows({ onBeforeNavigate }: { onBeforeNavigate?: () => void }) {
const { items } = useSidebarNavItems("footer"); const { items } = useSidebarNavItems("footer");
const usageSummary = useUsageSummary(); const hasUsageSummary = useHasUsageSummary();
const rowsRef = useRef<View | null>(null); const rowsRef = useRef<View | null>(null);
const visibleItems = items.filter( const visibleItems = items.filter(
(item) => item.visible && (item.kind === "plugin" || usageSummary.length > 0), (item) => item.visible && (item.kind === "plugin" || hasUsageSummary),
); );
if (visibleItems.length === 0) return null; if (visibleItems.length === 0) return null;
return ( return (
@@ -494,7 +499,7 @@ function SidebarFooterRows({ onBeforeNavigate }: { onBeforeNavigate?: () => void
onBeforeNavigate={onBeforeNavigate} onBeforeNavigate={onBeforeNavigate}
/> />
) : ( ) : (
<UsageSidebarItem key={item.key} sources={usageSummary} /> <UsageSidebarItem key={item.key} />
), ),
)} )}
</View> </View>
@@ -64,7 +64,7 @@ function resolveShouldFill(
): boolean { ): boolean {
if (!fillAvailableHeight) return false; if (!fillAvailableHeight) return false;
const t = detail?.type; const t = detail?.type;
return t === "shell" || t === "edit" || t === "write" || t === "read" || t === "sub_agent"; return t === "shell" || t === "edit" || t === "write" || t === "read";
} }
function useDetailStyles( function useDetailStyles(
@@ -186,184 +186,6 @@ function ShellDetailSection({ command, output, ds }: ShellDetailProps) {
); );
} }
function resolveSubAgentFallbackHeader(
subAgentType: string | null | undefined,
description: string | null | undefined,
fallbackText: string,
): string {
if (subAgentType && description) {
return `${subAgentType}: ${description}`;
}
return subAgentType ?? description ?? fallbackText;
}
interface SubAgentDetailProps {
log: string;
childSessionId: string | null | undefined;
subAgentType: string | null | undefined;
description: string | null | undefined;
ds: DetailStyles;
}
interface SubAgentActivityRow {
index: number;
toolName: string;
summary?: string;
}
interface ParsedSubAgentLog {
actions: SubAgentActivityRow[];
remainingLog: string;
}
function parseBracketedSubAgentLine(line: string, index: number): SubAgentActivityRow | null {
const match = line.match(/^\[([^\]]+)\](?:\s+(.*))?$/);
if (!match) {
return null;
}
const toolName = match[1]?.trim();
if (!toolName) {
return null;
}
const summary = match[2]?.trim();
return {
index,
toolName,
...(summary ? { summary } : {}),
};
}
function parseSubAgentLog(log: string): ParsedSubAgentLog {
const actions: SubAgentActivityRow[] = [];
const remainingLines: string[] = [];
for (const line of log.replace(/^\n+/, "").split("\n")) {
const normalizedLine = line.trim();
if (!normalizedLine) {
continue;
}
const parsedAction = parseBracketedSubAgentLine(normalizedLine, actions.length + 1);
if (parsedAction) {
actions.push(parsedAction);
} else {
remainingLines.push(line);
}
}
return {
actions,
remainingLog: remainingLines.join("\n").replace(/^\n+/, ""),
};
}
function SubAgentActionRow({ action }: { action: SubAgentActivityRow }) {
return (
<View style={styles.subAgentActionRow}>
<Text selectable style={styles.subAgentActionTool}>
{formatSubAgentToolName(action.toolName)}
</Text>
{action.summary ? (
<Text selectable style={styles.subAgentActionSummary}>
{action.summary}
</Text>
) : null}
</View>
);
}
function formatSubAgentToolName(toolName: string): string {
const trimmed = toolName.trim();
if (!trimmed) {
return toolName;
}
return trimmed
.replace(/[._-]+/g, " ")
.split(" ")
.filter((segment) => segment.length > 0)
.map((segment) => `${segment[0]?.toUpperCase() ?? ""}${segment.slice(1)}`)
.join(" ");
}
function SubAgentLogText({
activityLog,
fallbackHeader,
hasActions,
}: {
activityLog: string;
fallbackHeader: string;
hasActions: boolean;
}) {
if (activityLog.length > 0) {
return (
<Text selectable style={styles.scrollText}>
{activityLog}
</Text>
);
}
if (!hasActions) {
return (
<Text selectable style={styles.scrollText}>
{fallbackHeader}
</Text>
);
}
return null;
}
function SubAgentDetailSection({
log,
childSessionId,
subAgentType,
description,
ds,
}: SubAgentDetailProps) {
const { t } = useTranslation();
const { actions, remainingLog } = useMemo(() => parseSubAgentLog(log), [log]);
const fallbackHeader = resolveSubAgentFallbackHeader(
subAgentType,
description,
t("toolCallDetails.subAgentActivity"),
);
const hasActions = actions.length > 0;
return (
<View style={ds.sectionFillStyle}>
<View style={ds.codeBlockFillStyle}>
<ScrollView
style={ds.codeVerticalScrollStyle}
contentContainerStyle={styles.codeVerticalContent}
nestedScrollEnabled
showsVerticalScrollIndicator
>
<ScrollView
horizontal
nestedScrollEnabled
showsHorizontalScrollIndicator
contentContainerStyle={styles.codeHorizontalContent}
>
<View style={styles.codeLine} dataSet={CODE_SURFACE_DATASET}>
{childSessionId ? (
<Text selectable style={styles.subAgentSessionText}>
session {childSessionId}
</Text>
) : null}
{hasActions ? (
<View style={styles.subAgentActions}>
{actions.map((action) => (
<SubAgentActionRow key={action.index} action={action} />
))}
</View>
) : null}
<SubAgentLogText
activityLog={remainingLog}
fallbackHeader={fallbackHeader}
hasActions={hasActions}
/>
</View>
</ScrollView>
</ScrollView>
</View>
</View>
);
}
interface EditDetailProps { interface EditDetailProps {
diffLines: DiffLine[] | undefined; diffLines: DiffLine[] | undefined;
ds: DetailStyles; ds: DetailStyles;
@@ -636,19 +458,7 @@ function buildDetailSections(
<ShellDetailSection key="shell" command={detail.command} output={detail.output} ds={ds} />, <ShellDetailSection key="shell" command={detail.command} output={detail.output} ds={ds} />,
]; ];
} }
if (detail.type === "worktree_setup") return []; if (detail.type === "worktree_setup" || detail.type === "sub_agent") return [];
if (detail.type === "sub_agent") {
return [
<SubAgentDetailSection
key="sub-agent"
log={detail.log}
childSessionId={detail.childSessionId}
subAgentType={detail.subAgentType}
description={detail.description}
ds={ds}
/>,
];
}
if (detail.type === "edit") { if (detail.type === "edit") {
return [<EditDetailSection key="edit" diffLines={diffLines} ds={ds} />]; return [<EditDetailSection key="edit" diffLines={diffLines} ds={ds} />];
} }
@@ -900,34 +710,6 @@ const styles = StyleSheet.create((theme) => {
shellPrompt: { shellPrompt: {
color: theme.colors.foregroundMuted, color: theme.colors.foregroundMuted,
}, },
subAgentSessionText: {
fontFamily: theme.fontFamily.mono,
fontSize: theme.fontSize.code,
color: theme.colors.foregroundMuted,
lineHeight: 18,
marginBottom: theme.spacing[2],
},
subAgentActions: {
gap: theme.spacing[1],
marginBottom: theme.spacing[2],
},
subAgentActionRow: {
flexDirection: "row",
alignItems: "center",
gap: theme.spacing[2],
},
subAgentActionTool: {
fontFamily: theme.fontFamily.mono,
fontSize: theme.fontSize.code,
color: theme.colors.foregroundMuted,
lineHeight: 18,
},
subAgentActionSummary: {
fontFamily: theme.fontFamily.mono,
fontSize: theme.fontSize.code,
color: theme.colors.foreground,
lineHeight: 18,
},
jsonScroll: { jsonScroll: {
borderWidth: theme.borderWidth[1], borderWidth: theme.borderWidth[1],
borderColor: theme.colors.border, borderColor: theme.colors.border,
@@ -455,6 +455,10 @@ function SessionProviderInternal({ children, serverId, client }: SessionProvider
reportError: (error) => { reportError: (error) => {
console.warn("[Session] viewed timeline synchronization failed", { serverId, error }); console.warn("[Session] viewed timeline synchronization failed", { serverId, error });
}, },
schedule: (task, delayMs) => {
const timeout = setTimeout(task, delayMs);
return () => clearTimeout(timeout);
},
}); });
viewedTimelineSyncRef.current = sync; viewedTimelineSyncRef.current = sync;
setViewedTimelineSync(serverId, sync); setViewedTimelineSync(serverId, sync);
@@ -292,10 +292,7 @@ const CATALOG_DATA = [
version: "0.6.13", version: "0.6.13",
iconId: "minimax-code", iconId: "minimax-code",
installLink: "https://agent.minimax.io", installLink: "https://agent.minimax.io",
// `-p <pkg>` names the package and `mcode` names its binary. Without the command: ["npx", "-y", "@minimax-ai/code@0.6.13", "acp"],
// explicit binary, npx resolves the executable from the unscoped package
// name (`code`), which this package does not publish.
command: ["npx", "-y", "-p", "@minimax-ai/code@0.6.13", "mcode", "acp"],
}, },
{ {
id: "minion-code", id: "minion-code",
@@ -62,9 +62,7 @@ describe("ACP provider catalog", () => {
expect(findProvider("minimax-code")).toMatchObject({ expect(findProvider("minimax-code")).toMatchObject({
title: "MiniMax Code", title: "MiniMax Code",
version: "0.6.13", version: "0.6.13",
// The package publishes `mcode`, not `code`, so npx needs the package and command: ["npx", "-y", "@minimax-ai/code@0.6.13", "acp"],
// the binary named separately.
command: ["npx", "-y", "-p", "@minimax-ai/code@0.6.13", "mcode", "acp"],
}); });
expect(findProvider("minimax-code").iconSvg).toContain("<svg"); expect(findProvider("minimax-code").iconSvg).toContain("<svg");
}); });
@@ -422,23 +422,6 @@ describe("deriveAgentScreenViewState", () => {
expect(result.memory.lastReadyAgent).toBeNull(); expect(result.memory.lastReadyAgent).toBeNull();
}); });
it.each(["error", "retrying"] as const)("shows archived history sync %s", (status) => {
const result = deriveAgentScreenViewState({
input: {
...createBaseInput(),
agent: createAgent("agent-1"),
isArchived: true,
hasHydratedHistoryBefore: true,
visibilityCatchUpStatus: status,
},
memory: createBaseMemory(),
});
expect(expectReadyState(result.state).sync).toEqual({
status: "sync_error",
isRetrying: status === "retrying",
});
});
it("renders an archived agent before provider history is initialized", () => { it("renders an archived agent before provider history is initialized", () => {
const result = deriveAgentScreenViewState({ const result = deriveAgentScreenViewState({
input: { input: {
@@ -175,14 +175,10 @@ function resolveAgentScreenSync(args: {
hadInitialSyncFailure: boolean; hadInitialSyncFailure: boolean;
}): AgentScreenReadySyncState { }): AgentScreenReadySyncState {
const { input, hadInitialSyncFailure } = args; const { input, hadInitialSyncFailure } = args;
if ( if (input.isArchived) {
input.isArchived &&
input.visibilityCatchUpStatus !== "error" &&
input.visibilityCatchUpStatus !== "retrying"
) {
return { status: "idle" }; return { status: "idle" };
} }
if (!input.isConnected && !input.isArchived) { if (!input.isConnected) {
return { status: "reconnecting" }; return { status: "reconnecting" };
} }
if (input.missingAgentState.kind === "error") { if (input.missingAgentState.kind === "error") {
-1
View File
@@ -832,7 +832,6 @@ describe("translation resources", () => {
expect(en.common.placeholders.search).toBe("Search..."); expect(en.common.placeholders.search).toBe("Search...");
expect(en.common.empty.noResults).toBe("No results found"); expect(en.common.empty.noResults).toBe("No results found");
expect(en.common.empty.noOptionsMatchSearch).toBe("No options match your search."); expect(en.common.empty.noOptionsMatchSearch).toBe("No options match your search.");
expect(en.toolCallDetails.subAgentActivity).toBe("Sub-agent activity");
expect(en.panels.file.failedToLoadPreview).toBe("Failed to load file preview"); expect(en.panels.file.failedToLoadPreview).toBe("Failed to load file preview");
}); });
-6
View File
@@ -2013,7 +2013,6 @@ export const ar: TranslationResources = {
toolCallDetails: { toolCallDetails: {
error: "خطأ", error: "خطأ",
empty: "لا توجد تفاصيل إضافية متاحة", empty: "لا توجد تفاصيل إضافية متاحة",
subAgentActivity: "نشاط الوكيل الفرعي",
input: "مدخل", input: "مدخل",
output: "الإخراج", output: "الإخراج",
}, },
@@ -2092,11 +2091,6 @@ export const ar: TranslationResources = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "التحقق من الاستخدام",
checkUsageHint: "ينطبق على {{host}} على جميع الأجهزة",
off: "التحقق من الاستخدام متوقف على {{host}}.",
turnOn: "تشغيل",
options: "الإعدادات", options: "الإعدادات",
refreshFailed: "تعذّر تحديث الاستخدام", refreshFailed: "تعذّر تحديث الاستخدام",
noHosts: "لا توجد مضيفات متصلة", noHosts: "لا توجد مضيفات متصلة",
-6
View File
@@ -2038,7 +2038,6 @@ export const en = {
toolCallDetails: { toolCallDetails: {
error: "Error", error: "Error",
empty: "No additional details available", empty: "No additional details available",
subAgentActivity: "Sub-agent activity",
input: "Input", input: "Input",
output: "Output", output: "Output",
}, },
@@ -2117,11 +2116,6 @@ export const en = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "Check usage",
checkUsageHint: "Applies to {{host}} on every device",
off: "Usage is off on {{host}}.",
turnOn: "Turn on",
options: "Settings", options: "Settings",
refreshFailed: "Unable to refresh usage", refreshFailed: "Unable to refresh usage",
noHosts: "No connected hosts", noHosts: "No connected hosts",
-6
View File
@@ -2061,7 +2061,6 @@ export const es: TranslationResources = {
toolCallDetails: { toolCallDetails: {
error: "Error", error: "Error",
empty: "No hay detalles adicionales disponibles", empty: "No hay detalles adicionales disponibles",
subAgentActivity: "Actividad de subagente",
input: "Aporte", input: "Aporte",
output: "Producción", output: "Producción",
}, },
@@ -2140,11 +2139,6 @@ export const es: TranslationResources = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "Consultar uso",
checkUsageHint: "Se aplica a {{host}} en todos los dispositivos",
off: "El uso está desactivado en {{host}}.",
turnOn: "Activar",
options: "Configuración", options: "Configuración",
refreshFailed: "No se pudo actualizar el uso", refreshFailed: "No se pudo actualizar el uso",
noHosts: "No hay hosts conectados", noHosts: "No hay hosts conectados",
-6
View File
@@ -2060,7 +2060,6 @@ export const fr: TranslationResources = {
toolCallDetails: { toolCallDetails: {
error: "Erreur", error: "Erreur",
empty: "Aucun détail supplémentaire disponible", empty: "Aucun détail supplémentaire disponible",
subAgentActivity: "Activité du sous-agent",
input: "Entrée", input: "Entrée",
output: "Sortie", output: "Sortie",
}, },
@@ -2140,11 +2139,6 @@ export const fr: TranslationResources = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "Vérifier l’utilisation",
checkUsageHint: "S’applique à {{host}} sur tous les appareils",
off: "L’utilisation est désactivée sur {{host}}.",
turnOn: "Activer",
options: "Paramètres", options: "Paramètres",
refreshFailed: "Impossible d’actualiser l’utilisation", refreshFailed: "Impossible d’actualiser l’utilisation",
noHosts: "Aucun hôte connecté", noHosts: "Aucun hôte connecté",
-6
View File
@@ -2033,7 +2033,6 @@ export const ja: TranslationResources = {
toolCallDetails: { toolCallDetails: {
error: "エラー", error: "エラー",
empty: "追加の詳細はありません", empty: "追加の詳細はありません",
subAgentActivity: "サブエージェントアクティビティ",
input: "入力", input: "入力",
output: "出力", output: "出力",
}, },
@@ -2113,11 +2112,6 @@ export const ja: TranslationResources = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "使用状況を確認",
checkUsageHint: "すべてのデバイスで {{host}} に適用",
off: "{{host}} の使用状況確認はオフです。",
turnOn: "オンにする",
options: "設定", options: "設定",
refreshFailed: "使用状況を更新できません", refreshFailed: "使用状況を更新できません",
noHosts: "接続中のホストがありません", noHosts: "接続中のホストがありません",
-6
View File
@@ -2023,7 +2023,6 @@ export const ko: TranslationResources = {
toolCallDetails: { toolCallDetails: {
error: "오류", error: "오류",
empty: "추가 세부 정보가 없습니다", empty: "추가 세부 정보가 없습니다",
subAgentActivity: "서브에이전트 활동",
input: "입력", input: "입력",
output: "출력", output: "출력",
}, },
@@ -2102,11 +2101,6 @@ export const ko: TranslationResources = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "사용량 확인",
checkUsageHint: "모든 기기에서 {{host}}에 적용",
off: "{{host}}의 사용량 확인이 꺼져 있습니다.",
turnOn: "켜기",
options: "설정", options: "설정",
refreshFailed: "사용량을 새로 고칠 수 없습니다", refreshFailed: "사용량을 새로 고칠 수 없습니다",
noHosts: "연결된 호스트가 없습니다", noHosts: "연결된 호스트가 없습니다",
-6
View File
@@ -2046,7 +2046,6 @@ export const ptBR: TranslationResources = {
toolCallDetails: { toolCallDetails: {
error: "Erro", error: "Erro",
empty: "Nenhum detalhe adicional disponível", empty: "Nenhum detalhe adicional disponível",
subAgentActivity: "Atividade do subagente",
input: "Entrada", input: "Entrada",
output: "Saída", output: "Saída",
}, },
@@ -2125,11 +2124,6 @@ export const ptBR: TranslationResources = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "Consultar uso",
checkUsageHint: "Aplica-se a {{host}} em todos os dispositivos",
off: "O uso está desativado em {{host}}.",
turnOn: "Ativar",
options: "Configurações", options: "Configurações",
refreshFailed: "Não foi possível atualizar o uso", refreshFailed: "Não foi possível atualizar o uso",
noHosts: "Nenhum host conectado", noHosts: "Nenhum host conectado",
-6
View File
@@ -2046,7 +2046,6 @@ export const ru: TranslationResources = {
toolCallDetails: { toolCallDetails: {
error: "Ошибка", error: "Ошибка",
empty: "Дополнительные сведения отсутствуют", empty: "Дополнительные сведения отсутствуют",
subAgentActivity: "Активность субагента",
input: "Входные данные", input: "Входные данные",
output: "Выходные данные", output: "Выходные данные",
}, },
@@ -2125,11 +2124,6 @@ export const ru: TranslationResources = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "Проверять использование",
checkUsageHint: "Применяется к {{host}} на всех устройствах",
off: "Проверка использования отключена на {{host}}.",
turnOn: "Включить",
options: "Настройки", options: "Настройки",
refreshFailed: "Не удалось обновить использование", refreshFailed: "Не удалось обновить использование",
noHosts: "Нет подключённых хостов", noHosts: "Нет подключённых хостов",
-6
View File
@@ -1991,7 +1991,6 @@ export const zhCN: TranslationResources = {
toolCallDetails: { toolCallDetails: {
error: "错误", error: "错误",
empty: "没有可用的更多详情", empty: "没有可用的更多详情",
subAgentActivity: "Sub-agent 活动",
input: "输入", input: "输入",
output: "输出", output: "输出",
}, },
@@ -2070,11 +2069,6 @@ export const zhCN: TranslationResources = {
}, },
}, },
providerUsage: { providerUsage: {
checkUsage: "检查用量",
checkUsageHint: "在所有设备上应用于 {{host}}",
off: "{{host}} 的用量检查已关闭。",
turnOn: "开启",
options: "设置", options: "设置",
refreshFailed: "无法刷新用量", refreshFailed: "无法刷新用量",
noHosts: "没有已连接的主机", noHosts: "没有已连接的主机",
@@ -174,6 +174,7 @@ it("feeds restored layout to timeline sync as a release signal, not a subscripti
fetchLatestTail: async () => ({ hasNewer: false, endCursor: null }), fetchLatestTail: async () => ({ hasNewer: false, endCursor: null }),
onCatchUpEnded: () => undefined, onCatchUpEnded: () => undefined,
reportError: () => undefined, reportError: () => undefined,
schedule: () => () => undefined,
}); });
// The edge session-context.tsx owns. Pointing it at subscription instead would resume every // The edge session-context.tsx owns. Pointing it at subscription instead would resume every
// agent behind a restored tab on the daemon. // agent behind a restored tab on the daemon.
@@ -57,6 +57,7 @@ function createOwner(storage: TimelineReplicaStorage): ViewedTimelineOwner {
fetchPage: async () => ({ hasNewer: false, endCursor: null }), fetchPage: async () => ({ hasNewer: false, endCursor: null }),
fetchLatestTail: async () => ({ hasNewer: false, endCursor: null }), fetchLatestTail: async () => ({ hasNewer: false, endCursor: null }),
reportError: () => undefined, reportError: () => undefined,
schedule: () => () => undefined,
}, },
}); });
} }
@@ -616,6 +617,7 @@ describe("create handoff lifetime", () => {
}, },
fetchLatestTail: async () => ({ hasNewer: false, endCursor: null }), fetchLatestTail: async () => ({ hasNewer: false, endCursor: null }),
reportError: () => undefined, reportError: () => undefined,
schedule: () => () => undefined,
}, },
}); });
@@ -90,7 +90,7 @@ test("visible catch-up settles before hidden open chats start fetching", async (
world.sync.dispose(); world.sync.dispose();
}); });
test("a failed visible catch-up releases hidden chats without bypassing its error", async () => { test("a failed visible catch-up releases hidden chats without bypassing its retry delay", async () => {
const world = new TimelineWorld(); const world = new TimelineWorld();
world.openedEarlier(["a-hidden"]); world.openedEarlier(["a-hidden"]);
world.sync.replaceVisibleAgentIds("pane", ["z-visible"]); world.sync.replaceVisibleAgentIds("pane", ["z-visible"]);
@@ -103,7 +103,7 @@ test("a failed visible catch-up releases hidden chats without bypassing its erro
hidden.respond({ hasNewer: false }); hidden.respond({ hasNewer: false });
await world.nextError(); await world.nextError();
world.expectNoPendingFetch(); world.expectNoPendingFetch();
world.sync.retryVisibleAgentTimeline("z-visible"); (await world.nextRetry())();
(await world.nextFetch("z-visible")).respond({ hasNewer: false }); (await world.nextFetch("z-visible")).respond({ hasNewer: false });
world.sync.dispose(); world.sync.dispose();
}); });
@@ -200,6 +200,20 @@ class TimelineWorld {
const waiter = this.errorWaiters.shift(); const waiter = this.errorWaiters.shift();
if (waiter) waiter(this.errors.at(-1) ?? ""); if (waiter) waiter(this.errors.at(-1) ?? "");
}, },
schedule: (task, delayMs) => {
const scheduled = { task, delayMs };
this.scheduled.push(scheduled);
const waiterIndex = this.retryWaiters.findIndex((waiter) => waiter.delayMs === delayMs);
if (waiterIndex >= 0) {
const [waiter] = this.retryWaiters.splice(waiterIndex, 1);
this.scheduled.splice(this.scheduled.indexOf(scheduled), 1);
waiter.resolve(task);
}
return () => {
const index = this.scheduled.indexOf(scheduled);
if (index >= 0) this.scheduled.splice(index, 1);
};
},
}); });
show(sourceId: string, agentIds: string[]): void { show(sourceId: string, agentIds: string[]): void {
@@ -221,6 +235,12 @@ class TimelineWorld {
}> = []; }> = [];
private readonly errorWaiters: Array<(message: string) => void> = []; private readonly errorWaiters: Array<(message: string) => void> = [];
private readonly cacheRequestWaiters: Array<(agentId: string) => void> = []; private readonly cacheRequestWaiters: Array<(agentId: string) => void> = [];
private readonly scheduled: Array<{ task: () => void; delayMs: number }> = [];
private readonly retryWaiters: Array<{
delayMs: number;
resolve(retry: () => void): void;
}> = [];
get pendingFetchCount(): number { get pendingFetchCount(): number {
return this.fetches.length; return this.fetches.length;
} }
@@ -280,6 +300,22 @@ class TimelineWorld {
return new Promise((resolve) => this.errorWaiters.push(resolve)); return new Promise((resolve) => this.errorWaiters.push(resolve));
} }
nextRetry(delayMs = 1_000): Promise<() => void> {
const index = this.scheduled.findIndex((entry) => entry.delayMs === delayMs);
if (index >= 0) return Promise.resolve(this.scheduled.splice(index, 1)[0].task);
return new Promise((resolve) => this.retryWaiters.push({ delayMs, resolve }));
}
elapse(elapsedMs: number): void {
const due = this.scheduled.filter((entry) => entry.delayMs <= elapsedMs);
this.scheduled.splice(
0,
this.scheduled.length,
...this.scheduled.filter((entry) => entry.delayMs > elapsedMs),
);
for (const entry of due) entry.task();
}
private releaseMembershipWaiter(): void { private releaseMembershipWaiter(): void {
const waiter = this.membershipWaiters.shift(); const waiter = this.membershipWaiters.shift();
if (!waiter) return; if (!waiter) return;
@@ -447,28 +483,6 @@ test("reports a chat current only once its parked follow-up page completes", asy
world.sync.dispose(); world.sync.dispose();
}); });
test("a gap during manual retry is recovered before reporting ready", async () => {
const world = new TimelineWorld();
world.sync.setConnected(true);
world.show("workspace", ["agent-a"]);
(await world.nextMembership()).succeed();
(await world.nextFetch("agent-a")).fail("unavailable");
await world.nextError();
world.sync.retryVisibleAgentTimeline("agent-a");
const retry = await world.nextFetch("agent-a");
world.sync.recoverGap("agent-a", { epoch: "epoch-agent-a", endSeq: 9 });
retry.respond({ hasNewer: false });
await vi.waitFor(() => expect(world.pendingFetchCount).toBe(1));
const recovery = await world.nextFetch("agent-a");
expect(recovery.request).toMatchObject({
direction: "after",
cursor: { epoch: "epoch-agent-a", seq: 9 },
});
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("retrying");
recovery.respond({ hasNewer: false });
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready"));
});
test("reports a chat current once the latest-tail fallback replaces an overflowing catch-up", async () => { test("reports a chat current once the latest-tail fallback replaces an overflowing catch-up", async () => {
const world = new TimelineWorld(); const world = new TimelineWorld();
world.cursors.set("agent-a", { epoch: "epoch-agent-a", endSeq: 42 }); world.cursors.set("agent-a", { epoch: "epoch-agent-a", endSeq: 42 });
@@ -766,21 +780,6 @@ test("overlapping sources deduplicate membership and retain open hidden chats",
world.expectNoPendingFetch(); world.expectNoPendingFetch();
}); });
test("failed timeline fetch does not schedule a retry", async () => {
vi.useFakeTimers();
const world = new TimelineWorld();
world.sync.setConnected(true);
world.show("workspace", ["agent-a"]);
(await world.nextMembership()).succeed();
(await world.nextFetch("agent-a")).fail("unavailable");
await world.nextError();
expect(vi.getTimerCount()).toBe(0);
await vi.advanceTimersByTimeAsync(120_000);
world.expectNoPendingFetch();
world.expectNoPendingMembership();
vi.useRealTimers();
});
test("a failed catch-up reports once and retries through the explicit retry policy", async () => { test("a failed catch-up reports once and retries through the explicit retry policy", async () => {
const world = new TimelineWorld(); const world = new TimelineWorld();
world.sync.setConnected(true); world.sync.setConnected(true);
@@ -789,12 +788,12 @@ test("a failed catch-up reports once and retries through the explicit retry poli
membership.succeed(); membership.succeed();
const failed = await world.nextFetch("agent-a"); const failed = await world.nextFetch("agent-a");
failed.fail("timeline unavailable"); failed.fail("timeline unavailable");
const error = await world.nextError(); const [error, retryCatchUp] = await Promise.all([world.nextError(), world.nextRetry()]);
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error"); expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error");
world.sync.retryVisibleAgentTimeline("agent-a"); retryCatchUp();
const retry = await world.nextFetch("agent-a"); const retry = await world.nextFetch("agent-a");
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("retrying"); expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error");
retry.respond({ hasNewer: false }); retry.respond({ hasNewer: false });
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready")); await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready"));
@@ -805,6 +804,35 @@ test("a failed catch-up reports once and retries through the explicit retry poli
world.expectNoPendingMembership(); world.expectNoPendingMembership();
}); });
test("a failed catch-up retries with exponential backoff", async () => {
const world = new TimelineWorld();
world.sync.setConnected(true);
world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]);
const membership = await world.nextMembership();
membership.succeed();
const first = await world.nextFetch("agent-a");
first.fail("timeline unavailable");
const [firstError, retryAfterFirstFailure] = await Promise.all([
world.nextError(),
world.nextRetry(),
]);
expect(firstError).toBe("timeline unavailable");
retryAfterFirstFailure();
const second = await world.nextFetch("agent-a");
second.fail("timeline unavailable");
await world.nextError();
const retryAfterSecondFailure = await world.nextRetry(2_000);
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error");
retryAfterSecondFailure();
const third = await world.nextFetch("agent-a");
third.respond({ hasNewer: false });
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready"));
});
test("manual retries can immediately re-attempt a failed catch-up", async () => { test("manual retries can immediately re-attempt a failed catch-up", async () => {
const world = new TimelineWorld(); const world = new TimelineWorld();
world.sync.setConnected(true); world.sync.setConnected(true);
@@ -814,7 +842,7 @@ test("manual retries can immediately re-attempt a failed catch-up", async () =>
const failed = await world.nextFetch("agent-a"); const failed = await world.nextFetch("agent-a");
failed.fail("timeline unavailable"); failed.fail("timeline unavailable");
await world.nextError(); await world.nextRetry();
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error"); expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error");
world.sync.retryVisibleAgentTimeline("agent-a"); world.sync.retryVisibleAgentTimeline("agent-a");
@@ -825,7 +853,7 @@ test("manual retries can immediately re-attempt a failed catch-up", async () =>
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready")); await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready"));
}); });
test("redeclaring unchanged visibility does not bypass catch-up error", async () => { test("redeclaring unchanged visibility does not bypass catch-up backoff", async () => {
const world = new TimelineWorld(); const world = new TimelineWorld();
world.sync.setConnected(true); world.sync.setConnected(true);
world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]); world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]);
@@ -834,11 +862,9 @@ test("redeclaring unchanged visibility does not bypass catch-up error", async ()
const failed = await world.nextFetch("agent-a"); const failed = await world.nextFetch("agent-a");
failed.fail("timeline unavailable"); failed.fail("timeline unavailable");
await world.nextError(); await world.nextRetry();
world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]); world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]);
world.sync.setActive(false);
world.sync.setActive(true);
world.expectNoPendingMembership(); world.expectNoPendingMembership();
world.expectNoPendingFetch(); world.expectNoPendingFetch();
@@ -854,7 +880,7 @@ test("a manual retry that fails returns to the error state", async () => {
const failed = await world.nextFetch("agent-a"); const failed = await world.nextFetch("agent-a");
failed.fail("timeline unavailable"); failed.fail("timeline unavailable");
await world.nextError(); await world.nextRetry();
world.sync.retryVisibleAgentTimeline("agent-a"); world.sync.retryVisibleAgentTimeline("agent-a");
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("retrying"); expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("retrying");
@@ -917,34 +943,20 @@ test("repeated recovery for the same running gap reuses the in-flight fetch", as
gapPage.respond({ hasNewer: false }); gapPage.respond({ hasNewer: false });
}); });
test("failed membership does not schedule a retry", async () => { test("membership failure autonomously retries without another visibility declaration", async () => {
vi.useFakeTimers();
const world = new TimelineWorld();
world.sync.setConnected(true);
world.show("workspace", ["agent-a"]);
(await world.nextMembership()).fail("unavailable");
await world.nextError();
expect(vi.getTimerCount()).toBe(0);
await vi.advanceTimersByTimeAsync(120_000);
world.expectNoPendingFetch();
world.expectNoPendingMembership();
vi.useRealTimers();
});
test("membership failure waits for manual retry", async () => {
const world = new TimelineWorld(); const world = new TimelineWorld();
world.sync.setConnected(true); world.sync.setConnected(true);
world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]); world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]);
const failed = await world.nextMembership(); const failed = await world.nextMembership();
failed.fail("subscription unavailable"); failed.fail("subscription unavailable");
const error = await world.nextError(); const [error, retryMembership] = await Promise.all([world.nextError(), world.nextRetry()]);
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error"); expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error");
world.sync.retryVisibleAgentTimeline("agent-a"); retryMembership();
const retry = await world.nextMembership(); const retry = await world.nextMembership();
retry.succeed(); retry.succeed();
const catchUp = await world.nextFetch("agent-a"); const catchUp = await world.nextFetch("agent-a");
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("retrying"); expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error");
catchUp.respond({ hasNewer: false }); catchUp.respond({ hasNewer: false });
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready")); await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready"));
@@ -955,68 +967,44 @@ test("membership failure waits for manual retry", async () => {
}); });
}); });
test("retrying membership restores a previously loaded chat", async () => { test("membership failures retry with exponential backoff", async () => {
const world = new TimelineWorld(); const world = new TimelineWorld();
world.sync.setConnected(true); world.sync.setConnected(true);
world.show("workspace", ["agent-a"]); world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]);
(await world.nextMembership()).succeed();
(await world.nextFetch("agent-a")).respond({ hasNewer: false });
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready"));
world.cursors.set("agent-a", { epoch: "epoch-agent-a", endSeq: 10 });
world.show("workspace", ["agent-b"]);
(await world.nextMembership()).fail("subscription unavailable");
await world.nextError();
world.sync.retryVisibleAgentTimeline("agent-a");
(await world.nextMembership()).succeed();
(await world.nextFetch("agent-b")).respond({ hasNewer: false });
const resumed = await world.nextFetch("agent-a");
expect(resumed.request).toMatchObject({
direction: "after",
cursor: { epoch: "epoch-agent-a", seq: 10 },
});
resumed.respond({ hasNewer: false });
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready"));
});
test("a fetch that finishes after membership failure cannot clear the error", async () => { const first = await world.nextMembership();
const world = new TimelineWorld(); first.fail("subscription unavailable");
world.sync.setConnected(true); const [firstError, retryAfterFirstFailure] = await Promise.all([
world.show("workspace", ["agent-a"]); world.nextError(),
(await world.nextMembership()).succeed(); world.nextRetry(),
const inFlight = await world.nextFetch("agent-a"); ]);
world.show("workspace", ["agent-b"]); expect(firstError).toBe("subscription unavailable");
(await world.nextMembership()).fail("subscription unavailable");
await world.nextError(); retryAfterFirstFailure();
inFlight.respond({ hasNewer: false }); const second = await world.nextMembership();
await Promise.resolve(); second.fail("subscription unavailable again");
await Promise.resolve();
const retryAfterSecondFailure = await world.nextRetry(2_000);
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error"); expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error");
retryAfterSecondFailure();
const retry = await world.nextMembership();
retry.succeed();
const catchUp = await world.nextFetch("agent-a");
catchUp.respond({ hasNewer: false });
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("ready"));
}); });
test("a failed membership retry returns to error", async () => { test("redeclaring unchanged visibility does not bypass membership backoff", async () => {
const world = new TimelineWorld();
world.sync.setConnected(true);
world.show("workspace", ["agent-a"]);
(await world.nextMembership()).fail("unavailable");
await world.nextError();
world.sync.retryVisibleAgentTimeline("agent-a");
expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("retrying");
(await world.nextMembership()).fail("still unavailable");
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-a")).toBe("error"));
});
test("redeclaring unchanged visibility does not bypass membership error", async () => {
const world = new TimelineWorld(); const world = new TimelineWorld();
world.sync.setConnected(true); world.sync.setConnected(true);
world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]); world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]);
const failed = await world.nextMembership(); const failed = await world.nextMembership();
failed.fail("subscription unavailable"); failed.fail("subscription unavailable");
await world.nextError(); await world.nextRetry();
world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]); world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]);
world.sync.setActive(false);
world.sync.setActive(true);
world.expectNoPendingMembership(); world.expectNoPendingMembership();
world.expectNoPendingFetch(); world.expectNoPendingFetch();
@@ -1062,6 +1050,7 @@ test("backgrounding preserves subscriptions and returning verifies the visible c
world.sync.setActive(false); world.sync.setActive(false);
world.expectNoPendingMembership(); world.expectNoPendingMembership();
world.elapse(60_000);
world.sync.setActive(true); world.sync.setActive(true);
world.expectNoPendingMembership(); world.expectNoPendingMembership();
@@ -1078,10 +1067,11 @@ test("stale membership retry cannot overwrite a newer effective set", async () =
world.show("workspace", ["agent-a"]); world.show("workspace", ["agent-a"]);
const failed = await world.nextMembership(); const failed = await world.nextMembership();
failed.fail("subscription unavailable"); failed.fail("subscription unavailable");
await world.nextError(); const staleRetry = await world.nextRetry();
world.show("workspace", ["agent-b"]); world.show("workspace", ["agent-b"]);
const current = await world.nextMembership(); const current = await world.nextMembership();
staleRetry();
current.succeed(); current.succeed();
const agentB = await world.nextFetch("agent-b"); const agentB = await world.nextFetch("agent-b");
agentB.respond({ hasNewer: false }); agentB.respond({ hasNewer: false });
@@ -1098,9 +1088,10 @@ test("membership retry cannot run while disconnected", async () => {
world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]); world.sync.replaceVisibleAgentIds("workspace", ["agent-a"]);
const failed = await world.nextMembership(); const failed = await world.nextMembership();
failed.fail("subscription unavailable"); failed.fail("subscription unavailable");
await world.nextError(); const disconnectedRetry = await world.nextRetry();
world.sync.setConnected(false); world.sync.setConnected(false);
disconnectedRetry();
world.expectNoPendingMembership(); world.expectNoPendingMembership();
world.sync.setConnected(true); world.sync.setConnected(true);
const restored = await world.nextMembership(); const restored = await world.nextMembership();
@@ -1127,6 +1118,7 @@ test("returning to an open hidden agent stays live after inactivity", async () =
agentBCatchUp.respond({ hasNewer: false }); agentBCatchUp.respond({ hasNewer: false });
await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-b")).toBe("ready")); await vi.waitFor(() => expect(world.sync.getAgentTimelineStatus("agent-b")).toBe("ready"));
world.elapse(60_000);
world.show("workspace", ["agent-a"]); world.show("workspace", ["agent-a"]);
world.expectNoPendingMembership(); world.expectNoPendingMembership();
@@ -329,6 +329,7 @@ export interface ViewedTimelineSyncPorts {
*/ */
onCatchUpEnded(agentId: string): void; onCatchUpEnded(agentId: string): void;
reportError(error: unknown): void; reportError(error: unknown): void;
schedule(task: () => void, delayMs: number): () => void;
} }
export type ViewedTimelineStatus = "ready" | "pending" | "error" | "retrying"; export type ViewedTimelineStatus = "ready" | "pending" | "error" | "retrying";
@@ -422,14 +423,26 @@ export function createViewedTimelineOwner(input: {
}; };
} }
const RETRY_DELAY_MS = 1_000;
const MAX_RETRY_DELAY_MS = 30_000;
type CatchUpStatus = "running" | "complete" | "error"; type CatchUpStatus = "running" | "complete" | "error";
interface CatchUpState { interface CatchUpState {
generation: number; generation: number;
status: CatchUpStatus; status: CatchUpStatus;
request?: ProjectedTimelineForwardFetchPlan; request?: ProjectedTimelineForwardFetchPlan;
cancelRetry?: () => void;
retryDelayMs?: number;
} }
const getNextRetryDelayMs = (previousDelayMs: number | undefined): number => {
if (previousDelayMs == null) {
return RETRY_DELAY_MS;
}
return Math.min(previousDelayMs * 2, MAX_RETRY_DELAY_MS);
};
function isSameCatchUpRequest( function isSameCatchUpRequest(
left: ProjectedTimelineForwardFetchPlan | undefined, left: ProjectedTimelineForwardFetchPlan | undefined,
right: ProjectedTimelineForwardFetchPlan | undefined, right: ProjectedTimelineForwardFetchPlan | undefined,
@@ -459,7 +472,9 @@ function decideCatchUp(input: {
} }
return "replace"; return "replace";
} }
return "keep"; return input.current.status === "running" || input.current.status === "complete"
? "keep"
: "replace";
} }
function normalizeAgentIds(agentIds: string[]): string[] { function normalizeAgentIds(agentIds: string[]): string[] {
@@ -479,7 +494,8 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
const pendingCatchUps = new Map<string, ProjectedTimelineForwardFetchPlan>(); const pendingCatchUps = new Map<string, ProjectedTimelineForwardFetchPlan>();
const visibilityCatchUpPending = new Set<string>(); const visibilityCatchUpPending = new Set<string>();
const visibilityCatchUpErrors = new Map<string, string>(); const visibilityCatchUpErrors = new Map<string, string>();
// A user-initiated retry owes a pending state until it settles. // User-initiated retries only. Background retries stay silent; a retry the user asked for
// owes them a pending state until it settles.
const manualRetries = new Set<string>(); const manualRetries = new Set<string>();
const loadedCache = new Set<string>(); const loadedCache = new Set<string>();
const cacheLoads = new Map<string, Promise<void>>(); const cacheLoads = new Map<string, Promise<void>>();
@@ -495,6 +511,8 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
let acknowledged: string[] = []; let acknowledged: string[] = [];
let membershipGeneration = 0; let membershipGeneration = 0;
let membershipNeedsRetry = false; let membershipNeedsRetry = false;
let membershipRetryDelayMs: number | undefined;
let cancelMembershipRetry: (() => void) | null = null;
// Chats this session has opened. Visibility is the only way in, so an agent is never // Chats this session has opened. Visibility is the only way in, so an agent is never
// subscribed — and never resumed on the daemon — until the user actually opens it. // subscribed — and never resumed on the daemon — until the user actually opens it.
// Membership then survives hiding, workspace switches, backgrounding and reconnect; // Membership then survives hiding, workspace switches, backgrounding and reconnect;
@@ -545,6 +563,7 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
const cancelCatchUp = (agentId: string) => { const cancelCatchUp = (agentId: string) => {
catchUpGenerations.set(agentId, (catchUpGenerations.get(agentId) ?? 0) + 1); catchUpGenerations.set(agentId, (catchUpGenerations.get(agentId) ?? 0) + 1);
catchUps.get(agentId)?.cancelRetry?.();
catchUps.delete(agentId); catchUps.delete(agentId);
pendingCatchUps.delete(agentId); pendingCatchUps.delete(agentId);
}; };
@@ -588,7 +607,19 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
setVisibilityCatchUpReady(agentId); setVisibilityCatchUpReady(agentId);
} catch (error) { } catch (error) {
if (catchUps.get(agentId)?.generation === generation) { if (catchUps.get(agentId)?.generation === generation) {
catchUps.set(agentId, { generation, status: "error", request }); const nextRetryDelayMs = getNextRetryDelayMs(catchUps.get(agentId)?.retryDelayMs);
const cancelRetry = ports.schedule(() => {
const current = catchUps.get(agentId);
if (current?.generation !== generation || current.status !== "error") return;
startCatchUp(agentId);
}, nextRetryDelayMs);
catchUps.set(agentId, {
generation,
status: "error",
request,
cancelRetry,
retryDelayMs: nextRetryDelayMs,
});
setVisibilityCatchUpError([agentId], error); setVisibilityCatchUpError([agentId], error);
ports.reportError(error); ports.reportError(error);
} }
@@ -655,9 +686,17 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
if (decision === "keep") { if (decision === "keep") {
return; return;
} }
current?.cancelRetry?.();
const generation = (catchUpGenerations.get(agentId) ?? 0) + 1; const generation = (catchUpGenerations.get(agentId) ?? 0) + 1;
catchUpGenerations.set(agentId, generation); catchUpGenerations.set(agentId, generation);
catchUps.set(agentId, { generation, status: "running", request: nextRequest }); const retryDelayMs =
supersede || current?.status !== "error" ? undefined : current.retryDelayMs;
catchUps.set(agentId, {
generation,
status: "running",
request: nextRequest,
retryDelayMs,
});
pendingCatchUps.delete(agentId); pendingCatchUps.delete(agentId);
void fetchUntilCurrent( void fetchUntilCurrent(
agentId, agentId,
@@ -676,7 +715,7 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
for (const agentId of ordered) { for (const agentId of ordered) {
const pendingCatchUp = pendingCatchUps.get(agentId); const pendingCatchUp = pendingCatchUps.get(agentId);
const current = catchUps.get(agentId); const current = catchUps.get(agentId);
// Completion of a different chat must not bypass a failed chat's error or // Completion of a different chat must not bypass a failed chat's backoff or
// supersede an in-flight tail that owns its parked gap recovery. // supersede an in-flight tail that owns its parked gap recovery.
if (current && !(current.status === "complete" && pendingCatchUp)) continue; if (current && !(current.status === "complete" && pendingCatchUp)) continue;
startCatchUp(agentId, { startCatchUp(agentId, {
@@ -702,31 +741,42 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
} catch (error) { } catch (error) {
if (disposed || !connected || generation !== membershipGeneration) return; if (disposed || !connected || generation !== membershipGeneration) return;
membershipNeedsRetry = true; membershipNeedsRetry = true;
acknowledged = [];
for (const agentId of requested) cancelCatchUp(agentId);
setVisibilityCatchUpError(requested, error); setVisibilityCatchUpError(requested, error);
cancelMembershipRetry?.();
const nextRetryDelayMs = getNextRetryDelayMs(membershipRetryDelayMs);
cancelMembershipRetry = ports.schedule(() => {
cancelMembershipRetry = null;
if (disposed || !connected || membershipGeneration !== generation) return;
void reconcileMembership();
}, nextRetryDelayMs);
membershipRetryDelayMs = nextRetryDelayMs;
ports.reportError(error); ports.reportError(error);
return; return;
} }
if (disposed || !connected || generation !== membershipGeneration) return; if (disposed || !connected || generation !== membershipGeneration) return;
cancelMembershipRetry?.();
cancelMembershipRetry = null;
membershipRetryDelayMs = undefined;
acknowledged = requested; acknowledged = requested;
startAcknowledgedCatchUps(); startAcknowledgedCatchUps();
}; };
const retryVisibleAgentTimeline = (agentId: string) => { const retryVisibleAgentTimeline = (agentId: string) => {
if (!connected || !isDesired(agentId) || manualRetries.has(agentId)) return; if (!isDesired(agentId) || manualRetries.has(agentId)) return;
const catchUp = catchUps.get(agentId); const catchUp = catchUps.get(agentId);
const membershipRetryable = membershipNeedsRetry && connected; const membershipRetryable = membershipNeedsRetry && connected;
if (catchUp?.status !== "error" && !membershipRetryable) return; if (catchUp?.status !== "error" && !membershipRetryable) return;
manualRetries.add(agentId); manualRetries.add(agentId);
notifyListeners(); notifyListeners();
if (membershipRetryable) { if (catchUp?.status === "error") {
void reconcileMembership(); catchUp.cancelRetry?.();
startCatchUp(agentId, { request: catchUp.request, supersede: true });
return; return;
} }
if (catchUp?.status === "error") { cancelMembershipRetry?.();
startCatchUp(agentId, { request: catchUp.request, supersede: true }); cancelMembershipRetry = null;
} membershipRetryDelayMs = undefined;
void reconcileMembership();
}; };
const commitDesiredMembership = ( const commitDesiredMembership = (
@@ -767,6 +817,8 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
ensureCacheLoaded(agentId); ensureCacheLoaded(agentId);
} }
} }
cancelMembershipRetry?.();
cancelMembershipRetry = null;
desired = nextDesired; desired = nextDesired;
ports.replaceDemandedAgentIds(desired); ports.replaceDemandedAgentIds(desired);
membershipGeneration += 1; membershipGeneration += 1;
@@ -817,7 +869,6 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
return; return;
} }
for (const agentId of visibleAgentIds()) { for (const agentId of visibleAgentIds()) {
if (visibilityCatchUpErrors.has(agentId)) continue;
visibilityCatchUpPending.add(agentId); visibilityCatchUpPending.add(agentId);
visibilityCatchUpErrors.delete(agentId); visibilityCatchUpErrors.delete(agentId);
startCatchUp(agentId, { supersede: true }); startCatchUp(agentId, { supersede: true });
@@ -829,6 +880,9 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
connected = nextConnected; connected = nextConnected;
if (!connected) { if (!connected) {
commitDesiredMembership(desired, { resetCatchUpStatus: true }); commitDesiredMembership(desired, { resetCatchUpStatus: true });
cancelMembershipRetry?.();
cancelMembershipRetry = null;
membershipRetryDelayMs = undefined;
void observation?.handle.release().catch(ports.reportError); void observation?.handle.release().catch(ports.reportError);
observation = null; observation = null;
acknowledged = []; acknowledged = [];
@@ -840,7 +894,7 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
void reconcileMembership(); void reconcileMembership();
}, },
recoverGap(agentId, cursor) { recoverGap(agentId, cursor) {
if (!isDesired(agentId) || catchUps.get(agentId)?.status === "error") return; if (!isDesired(agentId)) return;
startCatchUp(agentId, { startCatchUp(agentId, {
request: planTimelineCatchUpAfter({ epoch: cursor.epoch, seq: cursor.endSeq }), request: planTimelineCatchUpAfter({ epoch: cursor.epoch, seq: cursor.endSeq }),
supersede: true, supersede: true,
@@ -850,7 +904,10 @@ export function createViewedTimelineSync(ports: ViewedTimelineSyncPorts): Viewed
disposed = true; disposed = true;
void observation?.handle.release().catch(ports.reportError); void observation?.handle.release().catch(ports.reportError);
observation = null; observation = null;
cancelMembershipRetry?.();
cancelMembershipRetry = null;
membershipNeedsRetry = false; membershipNeedsRetry = false;
membershipRetryDelayMs = undefined;
sources.clear(); sources.clear();
membershipGeneration += 1; membershipGeneration += 1;
for (const agentId of desired) cancelCatchUp(agentId); for (const agentId of desired) cancelCatchUp(agentId);
+3 -10
View File
@@ -21,12 +21,10 @@ export interface UsageHostSelection {
*/ */
export function UsageControls({ export function UsageControls({
view, view,
serverId,
onRefresh, onRefresh,
hostSelection, hostSelection,
}: { }: {
view: UsageView; view: UsageView;
serverId: string;
onRefresh: () => void; onRefresh: () => void;
hostSelection?: UsageHostSelection; hostSelection?: UsageHostSelection;
}) { }) {
@@ -45,8 +43,8 @@ export function UsageControls({
) : null} ) : null}
{view.kind === "unavailable" ? null : ( {view.kind === "unavailable" ? null : (
<> <>
{view.kind === "off" ? null : <UsageRefreshButton busy={busy} onRefresh={onRefresh} />} <UsageRefreshButton busy={busy} onRefresh={onRefresh} />
<UsageOptions serverId={serverId} /> <UsageOptions />
</> </>
)} )}
</View> </View>
@@ -86,12 +84,7 @@ export function useHostUsageWithControls(hostSelection: UsageHostSelection): {
const controls = useMemo( const controls = useMemo(
() => () =>
hasControls ? ( hasControls ? (
<UsageControls <UsageControls view={view} onRefresh={refresh} hostSelection={hostSelection} />
serverId={hostSelection.serverId}
view={view}
onRefresh={refresh}
hostSelection={hostSelection}
/>
) : null, ) : null,
[hasControls, hostSelection, refresh, view], [hasControls, hostSelection, refresh, view],
); );
+8
View File
@@ -1,5 +1,7 @@
import { useCallback, useMemo } from "react"; import { useCallback, useMemo } from "react";
import { useAppSettings } from "@/hooks/use-settings"; import { useAppSettings } from "@/hooks/use-settings";
import { useUsageHostId } from "./hosts";
import { useUsageHostReports } from "./queries";
import { import {
isUsagePinned, isUsagePinned,
setUsageDisplayAs, setUsageDisplayAs,
@@ -23,6 +25,12 @@ interface UsagePreferencesState {
display: UsageDisplay; display: UsageDisplay;
} }
/** The device's usage preferences, with pins resolved against a host's reports. */
export function useUsagePreferences(serverId?: string): UsagePreferencesState {
const defaultServerId = useUsageHostId();
return useUsageDisplay(useUsageHostReports(serverId ?? defaultServerId));
}
/** The device's usage preferences, with pins resolved against the given reports. */ /** The device's usage preferences, with pins resolved against the given reports. */
export function useUsageDisplay(reports: readonly UsageReportEntry[]): UsagePreferencesState { export function useUsageDisplay(reports: readonly UsageReportEntry[]): UsagePreferencesState {
const { settings, updateSettings } = useAppSettings(); const { settings, updateSettings } = useAppSettings();
@@ -1,5 +1,5 @@
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { useUsageDisplay } from "./display"; import { useUsagePreferences } from "./display";
import { useHostUsage } from "./queries"; import { useHostUsage } from "./queries";
import { UsageSection } from "./usage-section"; import { UsageSection } from "./usage-section";
@@ -7,7 +7,7 @@ import { UsageSection } from "./usage-section";
export function HostUsageSection({ serverId }: { serverId: string }) { export function HostUsageSection({ serverId }: { serverId: string }) {
const { t } = useTranslation(); const { t } = useTranslation();
const { view, refresh } = useHostUsage(serverId); const { view, refresh } = useHostUsage(serverId);
const { display } = useUsageDisplay(view.kind === "ready" ? view.reports : []); const { display } = useUsagePreferences(serverId);
return ( return (
<UsageSection <UsageSection
serverId={serverId} serverId={serverId}
+1 -1
View File
@@ -4,6 +4,6 @@ export { useHostReportsUsage } from "./queries";
export { export {
UsageSidebarItem, UsageSidebarItem,
UsageSidebarRoot, UsageSidebarRoot,
useUsageSummary, useHasUsageSummary,
useOpenSidebarUsage, useOpenSidebarUsage,
} from "./sidebar-item"; } from "./sidebar-item";
-12
View File
@@ -405,15 +405,3 @@ it("available and retained usage show the same successful completion time", () =
); );
expect(upsertReport([failure], success)).toEqual([failure]); expect(upsertReport([failure], success)).toEqual([failure]);
}); });
it("disabled host shows off even with cached reports", () => {
expect(
resolveUsageView({
hostLabel: "Laptop",
isConnected: true,
supportsUsage: true,
enabled: false,
query: { data: [], error: null, isFetching: false },
}),
).toMatchObject({ kind: "off" });
});
-3
View File
@@ -106,7 +106,6 @@ export interface UsageQueryState {
export function resolveUsageView( export function resolveUsageView(
input: { input: {
enabled?: boolean;
hostLabel: string; hostLabel: string;
isConnected: boolean; isConnected: boolean;
supportsUsage: boolean; supportsUsage: boolean;
@@ -126,8 +125,6 @@ export function resolveUsageView(
message: t("providerUsage.hostUpgradeRequired", { host: hostLabel }), message: t("providerUsage.hostUpgradeRequired", { host: hostLabel }),
}; };
} }
if (input.enabled === false)
return { kind: "off", message: t("providerUsage.off", { host: hostLabel }) };
if (query?.data) { if (query?.data) {
return { kind: "ready", reports: query.data, isRefreshing: query.isFetching }; return { kind: "ready", reports: query.data, isRefreshing: query.isFetching };
} }
+10 -27
View File
@@ -8,20 +8,15 @@ import { ToolbarButton, paneContentToolbarIconSize } from "@/components/ui/pane-
import { useIsCompactFormFactor } from "@/constants/layout"; import { useIsCompactFormFactor } from "@/constants/layout";
import { SettingsRow, SettingsSwitch } from "@/components/settings"; import { SettingsRow, SettingsSwitch } from "@/components/settings";
import { SegmentedControl, type SegmentedControlOption } from "@/components/ui/segmented-control"; import { SegmentedControl, type SegmentedControlOption } from "@/components/ui/segmented-control";
import { Alert } from "@/components/ui/alert";
import { useHosts } from "@/runtime/host-runtime";
import { settingsStyles } from "@/styles/settings"; import { settingsStyles } from "@/styles/settings";
import { useUsageSetting } from "./setting"; import { useUsagePreferences } from "./display";
import { useUsageDisplay } from "./display";
import { useUsageInSidebar } from "./in-sidebar"; import { useUsageInSidebar } from "./in-sidebar";
import type { UsageDisplayAs } from "./preferences"; import type { UsageDisplayAs } from "./preferences";
const ThemedSettings = withUnistyles(Settings); const ThemedSettings = withUnistyles(Settings);
/** The shared usage preferences, opened from a cog as a popover or compact sheet. */ /** The shared usage preferences, opened from a cog as a popover or compact sheet. */
export function UsageOptions({ serverId }: { serverId: string | null }) { export function UsageOptions() {
const setting = useUsageSetting(serverId);
const hostLabel = useHosts().find((host) => host.serverId === serverId)?.label ?? serverId;
const { t } = useTranslation(); const { t } = useTranslation();
const displayAsOptions: SegmentedControlOption<UsageDisplayAs>[] = [ const displayAsOptions: SegmentedControlOption<UsageDisplayAs>[] = [
{ value: "used", label: t("providerUsage.displayUsed"), testID: "usage-display-used" }, { value: "used", label: t("providerUsage.displayUsed"), testID: "usage-display-used" },
@@ -32,7 +27,7 @@ export function UsageOptions({ serverId }: { serverId: string | null }) {
}, },
]; ];
const compact = useIsCompactFormFactor(); const compact = useIsCompactFormFactor();
const { display } = useUsageDisplay([]); const { display } = useUsagePreferences();
const { inSidebar, setInSidebar } = useUsageInSidebar(); const { inSidebar, setInSidebar } = useUsageInSidebar();
return ( return (
<DropdownMenu compactMode="sheet"> <DropdownMenu compactMode="sheet">
@@ -54,25 +49,13 @@ export function UsageOptions({ serverId }: { serverId: string | null }) {
testID="usage-options-surface" testID="usage-options-surface"
> >
<View testID="usage-options-fields"> <View testID="usage-options-fields">
{setting.error ? <Alert variant="error" description={setting.error.message} /> : null} <SettingsSwitch
{setting.supported ? ( label={t("providerUsage.showInSidebar")}
<SettingsSwitch hint={t("providerUsage.showInSidebarHint")}
label={t("providerUsage.checkUsage")} value={inSidebar}
hint={t("providerUsage.checkUsageHint", { host: hostLabel })} onValueChange={setInSidebar}
disabled={!setting.ready} testID="usage-show-in-sidebar"
value={setting.enabled} />
onValueChange={setting.setEnabled}
/>
) : null}
<View style={setting.supported ? settingsStyles.rowBorder : undefined}>
<SettingsSwitch
label={t("providerUsage.showInSidebar")}
hint={t("providerUsage.showInSidebarHint")}
value={inSidebar}
onValueChange={setInSidebar}
testID="usage-show-in-sidebar"
/>
</View>
<View style={settingsStyles.rowBorder}> <View style={settingsStyles.rowBorder}>
<SettingsRow label={t("providerUsage.displayAs")}> <SettingsRow label={t("providerUsage.displayAs")}>
<SegmentedControl <SegmentedControl
+3 -9
View File
@@ -17,7 +17,6 @@ import {
useHosts, useHosts,
} from "@/runtime/host-runtime"; } from "@/runtime/host-runtime";
import { useSessionStore, type SessionState } from "@/stores/session-store"; import { useSessionStore, type SessionState } from "@/stores/session-store";
import { useUsageSetting } from "./setting";
import { usageCopy } from "./copy"; import { usageCopy } from "./copy";
import { import {
replaceReport, replaceReport,
@@ -133,14 +132,13 @@ function toQueryState(query: {
/** Usage reports for one host, as shown on its settings page. */ /** Usage reports for one host, as shown on its settings page. */
export function useHostUsage(serverId: string): { view: UsageView; refresh: () => void } { export function useHostUsage(serverId: string): { view: UsageView; refresh: () => void } {
const setting = useUsageSetting(serverId);
const queryClient = useQueryClient(); const queryClient = useQueryClient();
const isConnected = useHostRuntimeIsConnected(serverId); const isConnected = useHostRuntimeIsConnected(serverId);
const isSupported = useSessionStore((state) => supportsUsage(state.sessions[serverId])); const isSupported = useSessionStore((state) => supportsUsage(state.sessions[serverId]));
const query = useFetchQuery({ const query = useFetchQuery({
queryKey: usageReportsQueryKey(serverId), queryKey: usageReportsQueryKey(serverId),
queryFn: () => listReports(queryClient, serverId), queryFn: () => listReports(queryClient, serverId),
enabled: isConnected && isSupported && setting.enabled, enabled: isConnected && isSupported,
dataShape: "list", dataShape: "list",
staleTimeMs: REPORTS_STALE_TIME_MS, staleTimeMs: REPORTS_STALE_TIME_MS,
}); });
@@ -152,7 +150,6 @@ export function useHostUsage(serverId: string): { view: UsageView; refresh: () =
const view = resolveUsageView( const view = resolveUsageView(
{ {
hostLabel, hostLabel,
enabled: setting.ready ? setting.enabled : undefined,
isConnected, isConnected,
supportsUsage: isSupported, supportsUsage: isSupported,
query: toQueryState(query), query: toQueryState(query),
@@ -169,16 +166,14 @@ const NO_REPORTS: UsageReportEntry[] = [];
* load, or without a host. * load, or without a host.
*/ */
export function useUsageHostReports(serverId: string | null): UsageReportEntry[] { export function useUsageHostReports(serverId: string | null): UsageReportEntry[] {
const setting = useUsageSetting(serverId);
const queryClient = useQueryClient(); const queryClient = useQueryClient();
const query = useFetchQuery({ const query = useFetchQuery({
enabled: setting.enabled,
queryKey: usageReportsQueryKey(serverId ?? ""), queryKey: usageReportsQueryKey(serverId ?? ""),
queryFn: serverId ? () => listReports(queryClient, serverId) : skipToken, queryFn: serverId ? () => listReports(queryClient, serverId) : skipToken,
dataShape: "list", dataShape: "list",
staleTimeMs: REPORTS_STALE_TIME_MS, staleTimeMs: REPORTS_STALE_TIME_MS,
}); });
return setting.enabled ? (query.data ?? NO_REPORTS) : NO_REPORTS; return query.data ?? NO_REPORTS;
} }
/** /**
@@ -214,8 +209,7 @@ export function useAgentUsage(serverId: string, agentId: string): AgentUsageView
export function useHostReportsUsage(serverId: string): boolean { export function useHostReportsUsage(serverId: string): boolean {
const isConnected = useHostRuntimeIsConnected(serverId); const isConnected = useHostRuntimeIsConnected(serverId);
const isSupported = useSessionStore((state) => supportsUsage(state.sessions[serverId])); const isSupported = useSessionStore((state) => supportsUsage(state.sessions[serverId]));
const setting = useUsageSetting(serverId); return isConnected && isSupported;
return isConnected && isSupported && setting.enabled;
} }
/** Every host with whether it is connected and reports usage, in host order. */ /** Every host with whether it is connected and reports usage, in host order. */
-26
View File
@@ -1,26 +0,0 @@
import { useMutation } from "@tanstack/react-query";
import { useCallback } from "react";
import { useDaemonConfig } from "@/hooks/use-daemon-config";
import { useSessionStore } from "@/stores/session-store";
/** Host policy comes from the live daemon config replica. */
export function useUsageSetting(serverId: string | null) {
const supported = useSessionStore((state) =>
Boolean(serverId && state.sessions[serverId]?.serverInfo?.features?.usageSetting),
);
const { config, patchConfig } = useDaemonConfig(supported ? serverId : null);
const mutation = useMutation({
mutationFn: (enabled: boolean) => patchConfig({ usage: { enabled } }),
});
const setEnabled = mutation.mutate;
const turnOn = useCallback(() => setEnabled(true), [setEnabled]);
return {
supported,
error: mutation.error,
// COMPAT(usageSetting): added in v0.14, remove after 2027-05-01.
enabled: !supported || (config !== null && config.usage?.enabled !== false),
ready: !supported || config !== null,
setEnabled,
turnOn,
};
}
+11 -8
View File
@@ -17,8 +17,7 @@ import {
} from "react-native"; } from "react-native";
import { StyleSheet } from "react-native-unistyles"; import { StyleSheet } from "react-native-unistyles";
import { builtinSidebarNavLabelKey } from "@/sidebar-nav/model"; import { builtinSidebarNavLabelKey } from "@/sidebar-nav/model";
import { useUsageDisplay } from "./display"; import { useUsagePreferences } from "./display";
import { useUsageInSidebar } from "./in-sidebar";
import { useUsageHostId } from "./hosts"; import { useUsageHostId } from "./hosts";
import { useUsageHostReports } from "./queries"; import { useUsageHostReports } from "./queries";
import { UsageSourceIcon } from "./source-icon"; import { UsageSourceIcon } from "./source-icon";
@@ -34,24 +33,28 @@ import {
import { UsageModal } from "./usage-modal"; import { UsageModal } from "./usage-modal";
/** Each summary window with data on the usage host, under its source; empty while none has. */ /** Each summary window with data on the usage host, under its source; empty while none has. */
export function useUsageSummary(): readonly PinnedUsageSource[] { function useUsageSummary(): readonly PinnedUsageSource[] {
const { t } = useTranslation(); const { t } = useTranslation();
const { inSidebar } = useUsageInSidebar(); const { preferences } = useUsagePreferences();
const serverId = useUsageHostId(); const reports = useUsageHostReports(useUsageHostId());
const reports = useUsageHostReports(inSidebar ? serverId : null);
const { preferences } = useUsageDisplay(reports);
return useMemo(() => resolvePinnedUsage(reports, preferences, t), [preferences, reports, t]); return useMemo(() => resolvePinnedUsage(reports, preferences, t), [preferences, reports, t]);
} }
/** Whether the sidebar Usage item has anything to show. */
export function useHasUsageSummary(): boolean {
return useUsageSummary().length > 0;
}
/** /**
* The sidebar footer's usage entry: each summary window's source icon and percent, and nothing * The sidebar footer's usage entry: each summary window's source icon and percent, and nothing
* while no summary window has data, since the footer's Usage icon already opens Usage. * while no summary window has data, since the footer's Usage icon already opens Usage.
* Pressing it opens the Usage modal. * Pressing it opens the Usage modal.
*/ */
export function UsageSidebarItem({ sources }: { sources: readonly PinnedUsageSource[] }) { export function UsageSidebarItem() {
const { t } = useTranslation(); const { t } = useTranslation();
const label = t(builtinSidebarNavLabelKey("usage")); const label = t(builtinSidebarNavLabelKey("usage"));
const openUsage = useOpenSidebarUsage(); const openUsage = useOpenSidebarUsage();
const sources = useUsageSummary();
if (sources.length === 0) return null; if (sources.length === 0) return null;
return <PinnedUsageTrigger label={label} sources={sources} onPress={openUsage} />; return <PinnedUsageTrigger label={label} sources={sources} onPress={openUsage} />;
} }
-1
View File
@@ -10,7 +10,6 @@ export type UsageBalanceUnit = UsageBalance["unit"];
/** What a host's usage surface shows. `unavailable` is a host state, not a failed request. */ /** What a host's usage surface shows. `unavailable` is a host state, not a failed request. */
export type UsageView = export type UsageView =
| { kind: "off"; message: string }
| { kind: "unavailable"; message: string } | { kind: "unavailable"; message: string }
| { kind: "loading" } | { kind: "loading" }
| { kind: "error"; message: string } | { kind: "error"; message: string }
+2 -2
View File
@@ -4,7 +4,7 @@ import { View } from "react-native";
import { AdaptiveModalSheet } from "@/components/adaptive-modal-sheet"; import { AdaptiveModalSheet } from "@/components/adaptive-modal-sheet";
import { builtinSidebarNavLabelKey } from "@/sidebar-nav/model"; import { builtinSidebarNavLabelKey } from "@/sidebar-nav/model";
import { useHostUsageWithControls } from "./controls"; import { useHostUsageWithControls } from "./controls";
import { useUsageDisplay } from "./display"; import { useUsagePreferences } from "./display";
import { useUsageHostSelection } from "./hosts"; import { useUsageHostSelection } from "./hosts";
import type { UsageHost } from "./model"; import type { UsageHost } from "./model";
import { UsageBody, UsageMessage } from "./usage-section"; import { UsageBody, UsageMessage } from "./usage-section";
@@ -52,12 +52,12 @@ function HostUsageModal({
hosts: UsageHost[]; hosts: UsageHost[];
onSelectHost: (serverId: string) => void; onSelectHost: (serverId: string) => void;
}) { }) {
const { display } = useUsagePreferences();
const hostSelection = useMemo( const hostSelection = useMemo(
() => ({ hosts, serverId, onSelect: onSelectHost }), () => ({ hosts, serverId, onSelect: onSelectHost }),
[hosts, onSelectHost, serverId], [hosts, onSelectHost, serverId],
); );
const { view, refresh, controls } = useHostUsageWithControls(hostSelection); const { view, refresh, controls } = useHostUsageWithControls(hostSelection);
const { display } = useUsageDisplay(view.kind === "ready" ? view.reports : []);
return ( return (
<UsageModalFrame {...props} actions={controls}> <UsageModalFrame {...props} actions={controls}>
<View testID={`usage-host-${serverId}`}> <View testID={`usage-host-${serverId}`}>
+2 -12
View File
@@ -7,7 +7,6 @@ import { Button } from "@/components/ui/button";
import { settingsStyles } from "@/styles/settings"; import { settingsStyles } from "@/styles/settings";
import { SettingsSection } from "@/components/settings/headings/settings-section"; import { SettingsSection } from "@/components/settings/headings/settings-section";
import type { UsageDisplay } from "./display"; import type { UsageDisplay } from "./display";
import { useUsageSetting } from "./setting";
import { UsageControls } from "./controls"; import { UsageControls } from "./controls";
import { UsageList } from "./list"; import { UsageList } from "./list";
import type { UsageView } from "./types"; import type { UsageView } from "./types";
@@ -28,8 +27,8 @@ export function UsageSection({
testID?: string; testID?: string;
}) { }) {
const trailing = useMemo( const trailing = useMemo(
() => <UsageControls serverId={serverId} view={view} onRefresh={onRefresh} />, () => <UsageControls view={view} onRefresh={onRefresh} />,
[onRefresh, view, serverId], [onRefresh, view],
); );
return ( return (
@@ -52,15 +51,6 @@ export function UsageBody({
onRefresh: () => void; onRefresh: () => void;
}) { }) {
const { t } = useTranslation(); const { t } = useTranslation();
const setting = useUsageSetting(serverId);
if (view.kind === "off")
return (
<View>
<UsageMessage text={view.message} />
{setting.error ? <Alert variant="error" description={setting.error.message} /> : null}
<Button onPress={setting.turnOn}>{t("providerUsage.turnOn")}</Button>
</View>
);
if (view.kind === "unavailable") { if (view.kind === "unavailable") {
return <UsageMessage text={view.message} />; return <UsageMessage text={view.message} />;
} }
@@ -40,12 +40,6 @@ function hasMeaningfulFetchDetail(detail: Extract<ToolCallDetail, { type: "fetch
return Boolean(detail.url || detail.result || detail.codeText); return Boolean(detail.url || detail.result || detail.codeText);
} }
function hasMeaningfulSubAgentDetail(
detail: Extract<ToolCallDetail, { type: "sub_agent" }>,
): boolean {
return Boolean(detail.subAgentType || detail.description || detail.log);
}
function hasMeaningfulPlainTextDetail( function hasMeaningfulPlainTextDetail(
detail: Extract<ToolCallDetail, { type: "plain_text" }>, detail: Extract<ToolCallDetail, { type: "plain_text" }>,
): boolean { ): boolean {
@@ -75,9 +69,9 @@ export function hasMeaningfulToolCallDetail(detail: ToolCallDetail | undefined):
case "fetch": case "fetch":
return hasMeaningfulFetchDetail(detail); return hasMeaningfulFetchDetail(detail);
case "worktree_setup": case "worktree_setup":
return false; // A sub-agent card is a launch marker; the child's activity lives in the sub-agent panel.
case "sub_agent": case "sub_agent":
return hasMeaningfulSubAgentDetail(detail); return false;
case "plain_text": case "plain_text":
return hasMeaningfulPlainTextDetail(detail); return hasMeaningfulPlainTextDetail(detail);
case "plan": case "plan":
@@ -92,7 +86,7 @@ export function isPendingToolCallDetail(params: {
status: "executing" | "running" | "completed" | "failed" | "canceled"; status: "executing" | "running" | "completed" | "failed" | "canceled";
error: unknown; error: unknown;
}): boolean { }): boolean {
if (params.detail?.type === "worktree_setup") return false; if (params.detail?.type === "worktree_setup" || params.detail?.type === "sub_agent") return false;
const isRunning = params.status === "running" || params.status === "executing"; const isRunning = params.status === "running" || params.status === "executing";
return isRunning && params.error == null && !hasMeaningfulToolCallDetail(params.detail); return isRunning && params.error == null && !hasMeaningfulToolCallDetail(params.detail);
} }
+6 -14
View File
@@ -2,7 +2,6 @@ export { createHostChannelTransport } from "../hosts/index.js";
import { HostTransportBudget } from "./buffering.js"; import { HostTransportBudget } from "./buffering.js";
export { HostTransportBudget } from "./buffering.js"; export { HostTransportBudget } from "./buffering.js";
import { homedir } from "node:os"; import { homedir } from "node:os";
import type { Agent } from "node:http";
import { WebSocket } from "ws"; import { WebSocket } from "ws";
import { parseHostTarget, type HostTarget } from "@getpaseo/protocol/host-target"; import { parseHostTarget, type HostTarget } from "@getpaseo/protocol/host-target";
import { createSshTunnel, type SshTunnel } from "./ssh-tunnel.js"; import { createSshTunnel, type SshTunnel } from "./ssh-tunnel.js";
@@ -20,15 +19,10 @@ export { parseHostTarget };
export type { SshTunnel } from "./ssh-tunnel.js"; export type { SshTunnel } from "./ssh-tunnel.js";
export { createSshTunnel, resolveSshFailureDetail } from "./ssh-tunnel.js"; export { createSshTunnel, resolveSshFailureDetail } from "./ssh-tunnel.js";
export interface HostTransportOptions {
webSocketAgent?: (url: string) => Agent | undefined;
}
/** A factory owns one attempt, including a fresh SSH process and its teardown. */ /** A factory owns one attempt, including a fresh SSH process and its teardown. */
export function createHostTransportFactory( export function createHostTransportFactory(
connection: string, connection: string,
budget = new HostTransportBudget(), budget = new HostTransportBudget(),
options: HostTransportOptions = {},
): DaemonTransportFactory { ): DaemonTransportFactory {
const target = parseHostTarget(connection); const target = parseHostTarget(connection);
// Rises to "protected" once the daemon negotiates it, so a later attempt // Rises to "protected" once the daemon negotiates it, so a later attempt
@@ -74,13 +68,12 @@ export function createHostTransportFactory(
return; return;
} }
const socketPath = socketTarget.socketPath?.replace(/^~(?=\/)/, homedir()); const socketPath = socketTarget.socketPath?.replace(/^~(?=\/)/, homedir());
let factory = createWebSocketTransportFactory((url, socketOptions) => { let factory = createWebSocketTransportFactory((url, options) => {
const socket = new WebSocket( const socket = new WebSocket(
socketPath && url.startsWith("ws+unix:") ? `ws+unix://${socketPath}:/ws` : url, socketPath && url.startsWith("ws+unix:") ? `ws+unix://${socketPath}:/ws` : url,
socketOptions?.protocols, options?.protocols,
{ {
headers: socketOptions?.headers, headers: options?.headers,
agent: socketPath ? undefined : options.webSocketAgent?.(url),
...(socketPath ? { socketPath } : {}), ...(socketPath ? { socketPath } : {}),
maxPayload: 100 * 1024 * 1024, maxPayload: 100 * 1024 * 1024,
}, },
@@ -198,15 +191,14 @@ export function createHostTransportFactory(
} }
export function createHostClient( export function createHostClient(
connection: string, connection: string,
config: Omit<DaemonClientConfig, "url" | "transportFactory"> & HostTransportOptions, config: Omit<DaemonClientConfig, "url" | "transportFactory">,
budget?: HostTransportBudget, budget?: HostTransportBudget,
): DaemonClient { ): DaemonClient {
const target = parseHostTarget(connection); const target = parseHostTarget(connection);
const { webSocketAgent, ...clientConfig } = config;
return new DaemonClient({ return new DaemonClient({
...clientConfig, ...config,
url: "ws://host-connector/ws", url: "ws://host-connector/ws",
...(target.password ? { password: target.password } : {}), ...(target.password ? { password: target.password } : {}),
transportFactory: createHostTransportFactory(connection, budget, { webSocketAgent }), transportFactory: createHostTransportFactory(connection, budget),
}); });
} }
+1 -1
View File
@@ -288,7 +288,7 @@ export type ToolCallDetail =
subAgentType?: string; subAgentType?: string;
description?: string; description?: string;
childSessionId?: string; childSessionId?: string;
log: string; log?: string;
actions?: Array<{ actions?: Array<{
index: number; index: number;
toolName: string; toolName: string;
+3 -6
View File
@@ -229,8 +229,6 @@ export const MutableDaemonConfigSchema = z
.optional(), .optional(),
app: z.object({ baseUrl: z.string() }).optional(), app: z.object({ baseUrl: z.string() }).optional(),
catalogRefreshTimeoutMs: z.number().int().positive().optional(), catalogRefreshTimeoutMs: z.number().int().positive().optional(),
// COMPAT(usageSetting): added in v0.14, remove after 2027-05-01.
usage: z.object({ enabled: z.boolean() }).optional(),
browserTools: MutableBrowserToolsConfigSchema.default({ enabled: false }), browserTools: MutableBrowserToolsConfigSchema.default({ enabled: false }),
providers: z.record(z.string(), MutableDaemonProviderConfigSchema).default({}), providers: z.record(z.string(), MutableDaemonProviderConfigSchema).default({}),
metadataGeneration: MutableMetadataGenerationConfigSchema.default({ providers: [] }), metadataGeneration: MutableMetadataGenerationConfigSchema.default({ providers: [] }),
@@ -258,7 +256,6 @@ export const MutableDaemonConfigPatchSchema = z
.object({ .object({
relay: MutableRelayConfigSchema.partial().optional(), relay: MutableRelayConfigSchema.partial().optional(),
mcp: z.object({ injectIntoAgents: z.boolean().optional() }).passthrough().optional(), mcp: z.object({ injectIntoAgents: z.boolean().optional() }).passthrough().optional(),
usage: z.object({ enabled: z.boolean() }).optional(),
browserTools: MutableBrowserToolsConfigSchema.partial().optional(), browserTools: MutableBrowserToolsConfigSchema.partial().optional(),
providers: z providers: z
.record(z.string(), MutableDaemonProviderConfigSchema.partial().passthrough()) .record(z.string(), MutableDaemonProviderConfigSchema.partial().passthrough())
@@ -641,7 +638,9 @@ const ToolCallDetailPayloadSchema: z.ZodType<ToolCallDetail, unknown> = z.discri
subAgentType: z.string().optional(), subAgentType: z.string().optional(),
description: z.string().optional(), description: z.string().optional(),
childSessionId: z.string().optional(), childSessionId: z.string().optional(),
log: z.string(), // COMPAT(subagent-log): added in v0.14.1, remove after 2027-04-30. A sub-agent card is a
// launch marker; apps before v0.14.1 required `log`, so daemons still send it empty.
log: z.string().optional(),
// Compat cruft for clients <= 0.1.65-beta.3 that required this field. Producers still // Compat cruft for clients <= 0.1.65-beta.3 that required this field. Producers still
// emit `[]`; nothing reads it. Drop the field (and the `[]` emissions) once those // emit `[]`; nothing reads it. Drop the field (and the `[]` emissions) once those
// clients are no longer in the field. // clients are no longer in the field.
@@ -3676,8 +3675,6 @@ export const ServerInfoStatusPayloadSchema = z
providersSnapshot: z.boolean().optional(), providersSnapshot: z.boolean().optional(),
connectedHosts: z.boolean().optional(), connectedHosts: z.boolean().optional(),
hostMultiplexing: z.boolean().optional(), hostMultiplexing: z.boolean().optional(),
// COMPAT(usageSetting): added in v0.14, remove after 2027-05-01.
usageSetting: z.boolean().optional(),
usageSources: z.boolean().optional(), usageSources: z.boolean().optional(),
// COMPAT(providersSnapshotCwd): added in v0.3.2, remove gate after 2027-02-10. // COMPAT(providersSnapshotCwd): added in v0.3.2, remove gate after 2027-02-10.
providersSnapshotCwd: z.boolean().optional(), providersSnapshotCwd: z.boolean().optional(),
@@ -200,8 +200,8 @@ describe("wire schema compatibility", () => {
}); });
}); });
test("sub_agent tool-call payload still parses against the v0.1.65-beta.3 schema", () => { test("a sub-agent launch marker still parses against the v0.1.65-beta.3 schema", () => {
const parsed = LegacySubAgentToolCallSchema.parse({ const card = {
type: "tool_call", type: "tool_call",
callId: "call-sub-agent-1", callId: "call-sub-agent-1",
name: "Task", name: "Task",
@@ -212,12 +212,26 @@ describe("wire schema compatibility", () => {
subAgentType: "Explore", subAgentType: "Explore",
description: "Inspect repository structure", description: "Inspect repository structure",
childSessionId: "child-session-1", childSessionId: "child-session-1",
log: "[Read] README.md", log: "",
actions: [], actions: [],
}, },
}); } as const;
expect(parsed.detail.actions).toEqual([]); const parsed = LegacySubAgentToolCallSchema.parse(JSON.parse(JSON.stringify(card)));
expect(parsed.detail).toMatchObject({ log: "", actions: [] });
const { log: _log, ...withoutLog } = card.detail;
expect(LegacySubAgentToolCallSchema.safeParse({ ...card, detail: withoutLog }).success).toBe(
false,
);
expect(AgentTimelineItemPayloadSchema.parse({ ...card, detail: withoutLog })).toMatchObject({
detail: { type: "sub_agent", description: "Inspect repository structure" },
});
expect(
AgentTimelineItemPayloadSchema.parse({
...card,
detail: { ...card.detail, log: "[Read] README.md" },
}),
).toMatchObject({ detail: { log: "[Read] README.md" } });
}); });
test("old clients parse agent snapshots with rewind capabilities", () => { test("old clients parse agent snapshots with rewind capabilities", () => {
+1 -3
View File
@@ -89,7 +89,7 @@
"speech:transcribe:local": "tsx scripts/transcribe-local-wav.ts", "speech:transcribe:local": "tsx scripts/transcribe-local-wav.ts",
"test": "npm run test:unit && npm run test:integration", "test": "npm run test:unit && npm run test:integration",
"test:unit": "vitest run --fileParallelism --exclude \"**/*.e2e.test.ts\"", "test:unit": "vitest run --fileParallelism --exclude \"**/*.e2e.test.ts\"",
"test:integration": "vitest run --maxWorkers=1 src/server/git-filename-diffs.e2e.test.ts src/server/daemon-e2e/checkout-diff-content.e2e.test.ts src/server/daemon-e2e/filesystem.e2e.test.ts src/server/daemon-e2e/file-download.e2e.test.ts src/server/daemon-e2e/cli-logs-follow.e2e.test.ts src/server/creation/creation.e2e.test.ts src/server/daemon-e2e/terminal-workspace-sdk.e2e.test.ts src/server/daemon-e2e/terminal-worker-lifecycle.e2e.test.ts src/server/workspace-create-worktree-source.e2e.test.ts src/server/daemon-e2e/models.e2e.test.ts src/server/daemon-e2e/live-preferences.e2e.test.ts src/server/daemon-e2e/oversized-message.e2e.test.ts src/server/agent/model-catalog.e2e.test.ts src/server/plugins/plugin-paseo-api.e2e.test.ts src/server/plugins/usage-sources.e2e.test.ts src/server/plugins/lifecycle.e2e.test.ts src/server/connected-hosts/hosts.e2e.test.ts src/server/owned-subscriptions.e2e.test.ts && vitest run --maxWorkers=1 src/server/agent/providers/omp/history.e2e.test.ts src/server/daemon-e2e/git-operations.e2e.test.ts src/server/session.create-agent-worktree-autoarchive.e2e.test.ts src/server/agent/providers/opencode-bridge.local.e2e.test.ts src/server/daemon-e2e/relay-transport.e2e.test.ts -t \"merges into|creates a worktree and auto-archives both|versioned runtime|oversized attachments|connected hosts|password-protected daemon refuses|replays selected OMP history\"", "test:integration": "vitest run --maxWorkers=1 src/server/git-filename-diffs.e2e.test.ts src/server/daemon-e2e/checkout-diff-content.e2e.test.ts src/server/daemon-e2e/filesystem.e2e.test.ts src/server/daemon-e2e/file-download.e2e.test.ts src/server/daemon-e2e/cli-logs-follow.e2e.test.ts src/server/creation/creation.e2e.test.ts src/server/daemon-e2e/terminal-workspace-sdk.e2e.test.ts src/server/daemon-e2e/terminal-worker-lifecycle.e2e.test.ts src/server/workspace-create-worktree-source.e2e.test.ts src/server/daemon-e2e/models.e2e.test.ts src/server/daemon-e2e/live-preferences.e2e.test.ts src/server/daemon-e2e/oversized-message.e2e.test.ts src/server/agent/model-catalog.e2e.test.ts src/server/plugins/plugin-paseo-api.e2e.test.ts src/server/plugins/lifecycle.e2e.test.ts src/server/connected-hosts/hosts.e2e.test.ts src/server/owned-subscriptions.e2e.test.ts && vitest run --maxWorkers=1 src/server/agent/providers/omp/history.e2e.test.ts src/server/daemon-e2e/git-operations.e2e.test.ts src/server/session.create-agent-worktree-autoarchive.e2e.test.ts src/server/agent/providers/opencode-bridge.local.e2e.test.ts src/server/daemon-e2e/relay-transport.e2e.test.ts -t \"merges into|creates a worktree and auto-archives both|versioned runtime|oversized attachments|connected hosts|password-protected daemon refuses|replays selected OMP history\"",
"test:hub-cli-contract": "vitest run --maxWorkers=1 src/server/hub/hub-cli-contract.test.ts", "test:hub-cli-contract": "vitest run --maxWorkers=1 src/server/hub/hub-cli-contract.test.ts",
"test:integration:all": "npm run test:e2e", "test:integration:all": "npm run test:e2e",
"test:integration:real": "vitest run real.e2e.test.ts", "test:integration:real": "vitest run real.e2e.test.ts",
@@ -124,7 +124,6 @@
"esbuild": "^0.25.12", "esbuild": "^0.25.12",
"express": "^4.18.2", "express": "^4.18.2",
"fast-deep-equal": "^3.1.3", "fast-deep-equal": "^3.1.3",
"https-proxy-agent": "^7.0.6",
"lru-cache": "^11.5.1", "lru-cache": "^11.5.1",
"markdown-it": "^10.0.0", "markdown-it": "^10.0.0",
"mnemonic-id": "^3.2.7", "mnemonic-id": "^3.2.7",
@@ -142,7 +141,6 @@
"strip-ansi": "^7.1.2", "strip-ansi": "^7.1.2",
"tree-kill": "^1.2.2", "tree-kill": "^1.2.2",
"typescript": "^5.9.3", "typescript": "^5.9.3",
"undici": "^7.24.8",
"uuid": "^9.0.1", "uuid": "^9.0.1",
"which": "^5.0.0", "which": "^5.0.0",
"ws": "^8.14.2", "ws": "^8.14.2",
@@ -247,7 +247,7 @@ second line'`,
]); ]);
}); });
it("keeps nested sub-agent logs beside the sub-agent that produced them", () => { it("lists each sub-agent as its launch marker", () => {
const timeline: AgentTimelineItem[] = [ const timeline: AgentTimelineItem[] = [
{ type: "assistant_message", text: "Before first child." }, { type: "assistant_message", text: "Before first child." },
toolCallItem({ toolCallItem({
@@ -257,7 +257,7 @@ second line'`,
type: "sub_agent", type: "sub_agent",
subAgentType: "Child one", subAgentType: "Child one",
description: "First investigation", description: "First investigation",
log: "[Assistant] First child result.", log: "",
}, },
}), }),
{ type: "assistant_message", text: "Between children." }, { type: "assistant_message", text: "Between children." },
@@ -268,7 +268,7 @@ second line'`,
type: "sub_agent", type: "sub_agent",
subAgentType: "Child two", subAgentType: "Child two",
description: "Second investigation", description: "Second investigation",
log: "[Assistant] Second child result.", log: "",
}, },
}), }),
{ type: "assistant_message", text: "After second child." }, { type: "assistant_message", text: "After second child." },
@@ -279,10 +279,8 @@ second line'`,
expect(result.split("\n")).toEqual([ expect(result.split("\n")).toEqual([
"[Assistant] Before first child.", "[Assistant] Before first child.",
"[Child one] First investigation", "[Child one] First investigation",
"[Assistant] First child result.",
"[Assistant] Between children.", "[Assistant] Between children.",
"[Child two] Second investigation", "[Child two] Second investigation",
"[Assistant] Second child result.",
"[Assistant] After second child.", "[Assistant] After second child.",
]); ]);
}); });
@@ -164,9 +164,6 @@ function curateProjectedActivityEntries(
break; break;
} }
entries.push(formatToolCallEntry(item, options)); entries.push(formatToolCallEntry(item, options));
if (item.detail.type === "sub_agent" && item.detail.log.trim()) {
entries.push(activityEntry(item.detail.log.trim()));
}
break; break;
} }
case "todo": case "todo":
@@ -313,7 +313,10 @@ export type ToolCallDetail =
subAgentType?: string; subAgentType?: string;
description?: string; description?: string;
childSessionId?: string; childSessionId?: string;
log: string; // COMPAT(subagent-log): added in v0.14.1, remove after 2027-04-30. Apps before v0.14.1
// require `log`; every producer sends it empty and carries the same tag. Optional here because
// protocol timeline items, where `log` is optional, flow into this type.
log?: string;
actions?: Array<{ actions?: Array<{
index: number; index: number;
toolName: string; toolName: string;
@@ -466,13 +466,13 @@ describe("background Claude subagents", () => {
type: "sub_agent", type: "sub_agent",
subAgentType: "general-purpose", subAgentType: "general-purpose",
description: "Count files here", description: "Count files here",
log: "[Bash] ls -1", log: "",
}, },
}); });
}); });
test.each(["before", "after"])( test.each(["before", "after"])(
"keeps one logged Task card when child tools start %s the parent finishes", "keeps one Task card when child tools start %s the parent finishes",
async (timing) => { async (timing) => {
// A child can stream across the main session's turn boundary. Claude opens the next // A child can stream across the main session's turn boundary. Claude opens the next
// main-session turn with system/init; bare child frames do not open a turn. // main-session turn with system/init; bare child frames do not open a turn.
@@ -605,7 +605,7 @@ describe("background Claude subagents", () => {
type: "sub_agent", type: "sub_agent",
subAgentType: "general-purpose", subAgentType: "general-purpose",
description: "Count files here", description: "Count files here",
log: "[Bash] ls -1", log: "",
}, },
}); });
}, },
@@ -273,7 +273,7 @@ describe("ClaudeAgentSession sub-agent sidechain updates", () => {
queryFactory.mockReset(); queryFactory.mockReset();
}); });
test("accumulates lightweight sub_agent detail and preserves callId lifecycle collapse", async () => { test("labels the Task card from its input and preserves callId lifecycle collapse", async () => {
const session = await new ClaudeAgentClient({ const session = await new ClaudeAgentClient({
logger, logger,
queryFactory, queryFactory,
@@ -307,9 +307,7 @@ describe("ClaudeAgentSession sub-agent sidechain updates", () => {
expect(latest.detail.subAgentType).toBe("Explore"); expect(latest.detail.subAgentType).toBe("Explore");
expect(latest.detail.description).toBe("Inspect repository structure"); expect(latest.detail.description).toBe("Inspect repository structure");
expect(latest.detail.log).toContain("[Read] README.md"); expect(latest.detail.log).toBe("");
expect(latest.detail.log).toContain("[Edit] src/index.ts");
expect(latest.detail.log).not.toContain("VERY_LARGE_OLD_STRING");
const rows: AgentTimelineRow[] = timelineToolCalls.map((item, index) => ({ const rows: AgentTimelineRow[] = timelineToolCalls.map((item, index) => ({
seq: index + 1, seq: index + 1,
@@ -396,10 +394,7 @@ describe("ClaudeAgentSession sub-agent sidechain updates", () => {
.map((event) => event.item) .map((event) => event.item)
.at(-1); .at(-1);
expect(latestSubAgentUpdate?.detail).toMatchObject({ expect(latestSubAgentUpdate?.detail).toMatchObject({ type: "sub_agent", log: "" });
type: "sub_agent",
log: expect.stringContaining("[Read] README.md"),
});
}); });
test("routes a resumed SendMessage sidechain to the original child without a second Task card", async () => { test("routes a resumed SendMessage sidechain to the original child without a second Task card", async () => {
@@ -553,7 +548,7 @@ describe("ClaudeAgentSession sub-agent sidechain updates", () => {
).toMatchObject({ type: "upsert", id: "task-tail-1", status: "failed" }); ).toMatchObject({ type: "upsert", id: "task-tail-1", status: "failed" });
}); });
test("tails sub-agent actions instead of dropping latest entries at cap", async () => { test("keeps the Task card the same size while the child runs", async () => {
queryFactory.mockImplementation(() => buildQueryMock(buildTailScenarioEvents(205))); queryFactory.mockImplementation(() => buildQueryMock(buildTailScenarioEvents(205)));
const session = await new ClaudeAgentClient({ const session = await new ClaudeAgentClient({
@@ -568,24 +563,27 @@ describe("ClaudeAgentSession sub-agent sidechain updates", () => {
const events = await collectUntilTerminal(streamSession(session, "delegate work")); const events = await collectUntilTerminal(streamSession(session, "delegate work"));
await session.close(); await session.close();
const timelineToolCalls = events const runningCards = events
.filter( .flatMap((event) =>
(event): event is Extract<AgentStreamEvent, { type: "timeline" }> => event.type === "timeline" &&
event.type === "timeline" && event.item.type === "tool_call", event.item.type === "tool_call" &&
event.item.callId === "task-tail-1" &&
event.item.status === "running" &&
event.item.detail.type === "sub_agent"
? [event.item]
: [],
) )
.map((event) => event.item) .map((item) => JSON.stringify(item));
.filter((item) => item.callId === "task-tail-1"); expect(runningCards).toHaveLength(1);
const subAgentUpdates = timelineToolCalls.filter((item) => item.detail.type === "sub_agent");
const latest = subAgentUpdates[subAgentUpdates.length - 1];
expect(latest).toBeDefined();
if (!latest || latest.detail.type !== "sub_agent") {
throw new Error("expected sub_agent detail");
}
expect(latest.detail.log).not.toContain("[Read] file-1.md"); const childToolCalls = events.filter(
expect(latest.detail.log).not.toContain("[Read] file-5.md"); (event) =>
expect(latest.detail.log).toContain("[Read] file-6.md"); event.type === "provider_subagent" &&
expect(latest.detail.log).toContain("[Read] file-205.md"); event.event.type === "timeline" &&
event.event.id === "task-tail-1" &&
event.event.item.type === "tool_call",
);
expect(childToolCalls).toHaveLength(205);
}); });
test("keeps a long main-thread tool call out of the subagents track", async () => { test("keeps a long main-thread tool call out of the subagents track", async () => {
@@ -4667,7 +4667,7 @@ class ClaudeAgentSession implements AgentSession {
/** /**
* The Task card in the parent transcript, built from the declaration. * The Task card in the parent transcript, built from the declaration.
* *
* The sidechain tracker also emits this card, enriched with the child's action log, and the two * The sidechain tracker also emits this card when it first sees the child, and the two
* collapse on the shared tool-call id. Emitting it at declaration matters because a * collapse on the shared tool-call id. Emitting it at declaration matters because a
* backgrounded subagent produces no sidechain frames at all — verified on the wire — so the * backgrounded subagent produces no sidechain frames at all — verified on the wire — so the
* tracker never runs for one and its card would otherwise stay an unlabeled "Task". * tracker never runs for one and its card would otherwise stay an unlabeled "Task".
@@ -6276,6 +6276,7 @@ function buildClaudeSubagentCardDetail(
type: "sub_agent", type: "sub_agent",
...(facts.title ? { subAgentType: facts.title } : {}), ...(facts.title ? { subAgentType: facts.title } : {}),
...(facts.description ? { description: facts.description } : {}), ...(facts.description ? { description: facts.description } : {}),
// COMPAT(subagent-log): remove after 2027-04-30.
log: "", log: "",
actions: [], actions: [],
}; };
@@ -4,7 +4,7 @@ import type { SDKMessage } from "@anthropic-ai/claude-agent-sdk";
import { ClaudeSidechainTracker } from "./sidechain-tracker.js"; import { ClaudeSidechainTracker } from "./sidechain-tracker.js";
describe("ClaudeSidechainTracker", () => { describe("ClaudeSidechainTracker", () => {
it("retains a background child's actions across the parent finishing", () => { it("keeps a background child's card across the parent finishing", () => {
const tracker = new ClaudeSidechainTracker({ const tracker = new ClaudeSidechainTracker({
getToolInput: () => ({ subagent_type: "general-purpose", description: "List files" }), getToolInput: () => ({ subagent_type: "general-purpose", description: "List files" }),
isDescriptorOwnedElsewhere: () => true, isDescriptorOwnedElsewhere: () => true,
@@ -15,27 +15,67 @@ describe("ClaudeSidechainTracker", () => {
parent_tool_use_id: "task-1", parent_tool_use_id: "task-1",
message: { content: [{ type: "tool_use", id, name: "Bash", input: { command } }] }, message: { content: [{ type: "tool_use", id, name: "Bash", input: { command } }] },
}) as unknown as SDKMessage; }) as unknown as SDKMessage;
tracker.handleMessage(action("ls", "ls -1"), "task-1"); const parentCards = (events: ReturnType<typeof tracker.handleMessage>) =>
events.filter((event) => event.type === "timeline");
const childCallIds = (events: ReturnType<typeof tracker.handleMessage>) =>
events.flatMap((event) =>
event.type === "provider_subagent" &&
event.event.type === "timeline" &&
event.event.item.type === "tool_call"
? [event.event.item.callId]
: [],
);
expect(parentCards(tracker.handleMessage(action("ls", "ls -1"), "task-1"))).toHaveLength(1);
expect(tracker.finishAll("completed")).toEqual([]); expect(tracker.finishAll("completed")).toEqual([]);
const events = tracker.handleMessage(action("pwd", "pwd"), "task-1"); const afterFinish = tracker.handleMessage(action("pwd", "pwd"), "task-1");
expect(events).toContainEqual( expect(parentCards(afterFinish)).toEqual([]);
expect.objectContaining({ expect(childCallIds(afterFinish)).toEqual(["pwd"]);
type: "timeline",
item: expect.objectContaining({
detail: expect.objectContaining({ log: "[Bash] ls -1\n[Bash] pwd" }),
}),
}),
);
tracker.delete("task-1"); tracker.delete("task-1");
const next = tracker.handleMessage(action("next", "ls"), "task-1"); const next = tracker.handleMessage(action("next", "ls"), "task-1");
expect(next).toContainEqual( expect(parentCards(next)).toHaveLength(1);
expect.objectContaining({ expect(childCallIds(next)).toEqual(["next"]);
type: "timeline", });
item: expect.objectContaining({
detail: expect.objectContaining({ log: "[Bash] ls" }), it("shows a streamed child tool call's input once the assistant message brings it", () => {
}), const tracker = new ClaudeSidechainTracker({ getToolInput: () => null });
}), const frames = [
); {
type: "stream_event",
parent_tool_use_id: "task-1",
event: {
type: "content_block_start",
index: 0,
content_block: { type: "tool_use", id: "bash-1", name: "Bash", input: {} },
},
},
{
type: "assistant",
parent_tool_use_id: "task-1",
message: {
content: [
{ type: "tool_use", id: "bash-1", name: "Bash", input: { command: "echo child" } },
],
},
},
] as unknown as SDKMessage[];
const childCards = frames
.flatMap((frame) => tracker.handleMessage(frame, "task-1"))
.flatMap((event) =>
event.type === "provider_subagent" &&
event.event.type === "timeline" &&
event.event.item.type === "tool_call"
? [event.event.item]
: [],
);
expect(childCards.at(-1)).toMatchObject({
callId: "bash-1",
status: "running",
detail: { type: "shell", command: "echo child" },
});
}); });
it("uses Claude's native agent name for the provider subagent title", () => { it("uses Claude's native agent name for the provider subagent title", () => {
@@ -5,7 +5,6 @@ import {
mapClaudeFailedToolCall, mapClaudeFailedToolCall,
mapClaudeRunningToolCall, mapClaudeRunningToolCall,
} from "./tool-call-mapper.js"; } from "./tool-call-mapper.js";
import { buildToolCallDisplayModel } from "@getpaseo/protocol/tool-call-display";
import { import {
isClaudeSubagentHandbackToolName, isClaudeSubagentHandbackToolName,
readClaudeSubagentHandback, readClaudeSubagentHandback,
@@ -20,21 +19,17 @@ interface ClaudeContentChunk {
type ClaudeToolCallItem = Extract<AgentTimelineItem, { type: "tool_call" }>; type ClaudeToolCallItem = Extract<AgentTimelineItem, { type: "tool_call" }>;
interface SubAgentActionEntry { interface SubAgentChildCall {
index: number;
toolName: string; toolName: string;
input: unknown; input: unknown;
summary?: string;
} }
interface SubAgentActivityState { interface SubAgentActivityState {
name?: string; name?: string;
subAgentType?: string; subAgentType?: string;
description?: string; description?: string;
actions: SubAgentActionEntry[]; /** The child's tool calls awaiting results, which carry no input of their own. */
actionKeys: string[]; runningCalls: Map<string, SubAgentChildCall>;
nextActionIndex: number;
actionIndexByKey: Map<string, number>;
completedActionKeys: Set<string>; completedActionKeys: Set<string>;
} }
@@ -44,7 +39,6 @@ interface SubAgentActionCandidate {
input: unknown; input: unknown;
} }
const MAX_SUB_AGENT_LOG_ENTRIES = 200;
const MAX_SUB_AGENT_SUMMARY_CHARS = 160; const MAX_SUB_AGENT_SUMMARY_CHARS = 160;
function readTrimmedString(value: unknown): string | undefined { function readTrimmedString(value: unknown): string | undefined {
@@ -79,8 +73,7 @@ export class ClaudeSidechainTracker {
needsSyntheticParentToolCard?: (toolUseId: string) => boolean; needsSyntheticParentToolCard?: (toolUseId: string) => boolean;
/** /**
* The parent's tool call once Claude has answered it. A background child streams its frames * The parent's tool call once Claude has answered it. A background child streams its frames
* after that answer, so its card keeps the settled status and output and gains the child's * after that answer, so its card keeps the settled status and output.
* action log.
*/ */
getSettledParentToolCall?: (toolUseId: string) => ClaudeToolCallItem | undefined; getSettledParentToolCall?: (toolUseId: string) => ClaudeToolCallItem | undefined;
}) { }) {
@@ -91,28 +84,27 @@ export class ClaudeSidechainTracker {
} }
handleMessage(message: SDKMessage, parentToolUseId: string): AgentStreamEvent[] { handleMessage(message: SDKMessage, parentToolUseId: string): AgentStreamEvent[] {
const existingState = this.activeSidechains.get(parentToolUseId);
const state = const state =
this.activeSidechains.get(parentToolUseId) ?? existingState ??
({ ({
actions: [], runningCalls: new Map<string, SubAgentChildCall>(),
actionKeys: [],
nextActionIndex: 1,
actionIndexByKey: new Map<string, number>(),
completedActionKeys: new Set<string>(), completedActionKeys: new Set<string>(),
} satisfies SubAgentActivityState); } satisfies SubAgentActivityState);
this.activeSidechains.set(parentToolUseId, state); this.activeSidechains.set(parentToolUseId, state);
const contextUpdated = this.updateSubAgentContextFromTaskInput(state, parentToolUseId); // The parent card is a launch marker: it changes only when the child is first seen or the
// task input names it differently, never with the child's activity.
const cardUpdated =
this.updateSubAgentContextFromTaskInput(state, parentToolUseId) || !existingState;
const actionCandidates = this.extractSubAgentActionCandidates(message); const actionCandidates = this.extractSubAgentActionCandidates(message);
const childTimelineItems = [ const childTimelineItems = [
...this.extractSubAgentTimelineItems(message, state), ...this.extractSubAgentTimelineItems(message, state),
...this.extractSubAgentToolResults(message, state), ...this.extractSubAgentToolResults(message, state),
]; ];
let actionUpdated = false;
for (const action of actionCandidates) { for (const action of actionCandidates) {
if (state.completedActionKeys.has(action.key)) continue; if (state.completedActionKeys.has(action.key)) continue;
if (this.appendSubAgentAction(state, action)) { if (this.trackChildCall(state, action)) {
actionUpdated = true;
const toolCall = mapClaudeRunningToolCall({ const toolCall = mapClaudeRunningToolCall({
name: action.toolName, name: action.toolName,
callId: action.key, callId: action.key,
@@ -125,7 +117,7 @@ export class ClaudeSidechainTracker {
} }
} }
if (!contextUpdated && !actionUpdated && childTimelineItems.length === 0) { if (!cardUpdated && childTimelineItems.length === 0) {
return []; return [];
} }
@@ -145,11 +137,8 @@ export class ClaudeSidechainTracker {
type: "sub_agent", type: "sub_agent",
...(state.subAgentType ? { subAgentType: state.subAgentType } : {}), ...(state.subAgentType ? { subAgentType: state.subAgentType } : {}),
...(state.description ? { description: state.description } : {}), ...(state.description ? { description: state.description } : {}),
log: state.actions // COMPAT(subagent-log): remove after 2027-04-30.
.map((action) => log: "",
action.summary ? `[${action.toolName}] ${action.summary}` : `[${action.toolName}]`,
)
.join("\n"),
actions: [], actions: [],
}; };
@@ -170,18 +159,19 @@ export class ClaudeSidechainTracker {
}, },
]; ];
const parentCard: AgentStreamEvent[] = this.needsSyntheticParentToolCard(parentToolUseId) const parentCard: AgentStreamEvent[] =
? [ cardUpdated && this.needsSyntheticParentToolCard(parentToolUseId)
{ ? [
type: "timeline", {
item: { type: "timeline",
...toolCall, item: {
detail, ...toolCall,
detail,
},
provider: "claude",
}, },
provider: "claude", ]
}, : [];
]
: [];
return [ return [
...descriptorEvents, ...descriptorEvents,
@@ -303,8 +293,7 @@ export class ClaudeSidechainTracker {
if (!isClaudeContentChunk(block) || !block.type.endsWith("tool_result")) continue; if (!isClaudeContentChunk(block) || !block.type.endsWith("tool_result")) continue;
const callId = readTrimmedString(block.tool_use_id); const callId = readTrimmedString(block.tool_use_id);
if (!callId || state.completedActionKeys.has(callId)) continue; if (!callId || state.completedActionKeys.has(callId)) continue;
const actionIndex = state.actionIndexByKey.get(callId); const action = state.runningCalls.get(callId);
const action = actionIndex === undefined ? undefined : state.actions[actionIndex];
const toolName = action?.toolName ?? readTrimmedString(block.tool_name); const toolName = action?.toolName ?? readTrimmedString(block.tool_name);
if (!toolName) continue; if (!toolName) continue;
const params = { const params = {
@@ -317,6 +306,7 @@ export class ClaudeSidechainTracker {
? mapClaudeFailedToolCall({ ...params, error: block }) ? mapClaudeFailedToolCall({ ...params, error: block })
: mapClaudeCompletedToolCall(params); : mapClaudeCompletedToolCall(params);
if (toolCall) { if (toolCall) {
state.runningCalls.delete(callId);
state.completedActionKeys.add(callId); state.completedActionKeys.add(callId);
items.push(toolCall); items.push(toolCall);
} }
@@ -412,13 +402,12 @@ export class ClaudeSidechainTracker {
const key = const key =
readTrimmedString(block.id) ?? readTrimmedString(block.id) ??
`stream:${block.name}:${typeof event.index === "number" ? event.index : 0}`; `stream:${block.name}:${typeof event.index === "number" ? event.index : 0}`;
return [ // A streamed call starts with `{}` until its input arrives, so an empty input is not final.
{ const input =
key, block.input && typeof block.input === "object" && Object.keys(block.input).length > 0
toolName: block.name, ? block.input
input: block.input ?? null, : null;
}, return [{ key, toolName: block.name, input }];
];
} }
private extractSubAgentActionCandidates(message: SDKMessage): SubAgentActionCandidate[] { private extractSubAgentActionCandidates(message: SDKMessage): SubAgentActionCandidate[] {
@@ -448,84 +437,20 @@ export class ClaudeSidechainTracker {
return []; return [];
} }
private appendSubAgentAction( /** Returns whether the call is new or has gained its input, so its running card changes. */
private trackChildCall(
state: SubAgentActivityState, state: SubAgentActivityState,
candidate: SubAgentActionCandidate, candidate: SubAgentActionCandidate,
): boolean { ): boolean {
const normalizedToolName = readTrimmedString(candidate.toolName); const toolName = readTrimmedString(candidate.toolName);
if (!normalizedToolName) { if (!toolName) {
return false; return false;
} }
const existing = state.runningCalls.get(candidate.key);
const summary = this.deriveSubAgentActionSummary(normalizedToolName, candidate.input); if (existing && (existing.input !== null || candidate.input === null)) {
const existingIndex = state.actionIndexByKey.get(candidate.key); return false;
if (existingIndex !== undefined) {
const existing = state.actions[existingIndex];
if (!existing) {
return false;
}
const nextSummary = existing.summary ?? summary;
if (existing.toolName === normalizedToolName && existing.summary === nextSummary) {
return false;
}
state.actions[existingIndex] = {
...existing,
toolName: normalizedToolName,
input: existing.input ?? candidate.input,
...(nextSummary ? { summary: nextSummary } : {}),
};
return true;
} }
state.runningCalls.set(candidate.key, { toolName, input: candidate.input });
state.actions.push({
index: state.nextActionIndex,
toolName: normalizedToolName,
input: candidate.input,
...(summary ? { summary } : {}),
});
state.nextActionIndex += 1;
state.actionKeys.push(candidate.key);
this.trimSubAgentTail(state);
this.rebuildSubAgentActionIndex(state);
return true; return true;
} }
private trimSubAgentTail(state: SubAgentActivityState): void {
while (state.actions.length > MAX_SUB_AGENT_LOG_ENTRIES) {
state.actions.shift();
const removedKey = state.actionKeys.shift();
if (removedKey) state.completedActionKeys.delete(removedKey);
}
}
private rebuildSubAgentActionIndex(state: SubAgentActivityState): void {
state.actionIndexByKey.clear();
for (let index = 0; index < state.actionKeys.length; index += 1) {
const key = state.actionKeys[index];
if (key) {
state.actionIndexByKey.set(key, index);
}
}
}
private deriveSubAgentActionSummary(toolName: string, input: unknown): string | undefined {
const runningToolCall = mapClaudeRunningToolCall({
name: toolName,
callId: `sub-agent-summary-${toolName}`,
input,
output: null,
});
if (!runningToolCall) {
return undefined;
}
const display = buildToolCallDisplayModel({
name: runningToolCall.name,
status: runningToolCall.status,
error: runningToolCall.error,
detail: runningToolCall.detail,
metadata: runningToolCall.metadata,
});
return this.normalizeSubAgentText(display.summary);
}
} }
@@ -77,12 +77,19 @@ CHILD_SENTINEL in your own response.
const completedChildIndex = events.findIndex( const completedChildIndex = events.findIndex(
(event) => (event) =>
event.type === "timeline" && event.type === "provider_subagent" &&
event.item.type === "tool_call" && event.event.type === "upsert" &&
event.item.status === "completed" && event.event.status === "completed",
event.item.detail.type === "sub_agent" &&
event.item.detail.log.includes("CHILD_SENTINEL"),
); );
const childAssistantText = events
.flatMap((event) =>
event.type === "provider_subagent" &&
event.event.type === "timeline" &&
event.event.item.type === "assistant_message"
? [event.event.item.text]
: [],
)
.join("");
const rootMessageIndexes = events.flatMap((event, index) => const rootMessageIndexes = events.flatMap((event, index) =>
event.type === "timeline" && event.item.type === "assistant_message" ? [index] : [], event.type === "timeline" && event.item.type === "assistant_message" ? [index] : [],
); );
@@ -105,6 +112,7 @@ CHILD_SENTINEL in your own response.
.map((item) => item.text) .map((item) => item.text)
.join(""); .join("");
expect(topLevelAssistantText).not.toContain("CHILD_SENTINEL"); expect(topLevelAssistantText).not.toContain("CHILD_SENTINEL");
expect(childAssistantText).toContain("CHILD_SENTINEL");
expect(completedChildIndex).toBeGreaterThanOrEqual(0); expect(completedChildIndex).toBeGreaterThanOrEqual(0);
expect(rootMessageIndexes[0]).toBeGreaterThan(completedChildIndex); expect(rootMessageIndexes[0]).toBeGreaterThan(completedChildIndex);
expect(terminalIndexes).toHaveLength(1); expect(terminalIndexes).toHaveLength(1);
@@ -3524,7 +3524,7 @@ describe("Codex app-server provider", () => {
]); ]);
}); });
test("folds child-thread Codex activity into the parent sub-agent tool call", async () => { test("keeps child-thread Codex activity out of the parent sub-agent card", async () => {
const session = createSession(); const session = createSession();
const events: AgentStreamEvent[] = []; const events: AgentStreamEvent[] = [];
session.subscribe((event) => events.push(event)); session.subscribe((event) => events.push(event));
@@ -3562,7 +3562,6 @@ describe("Codex app-server provider", () => {
}); });
const timelineEvents = events.filter((event) => event.type === "timeline"); const timelineEvents = events.filter((event) => event.type === "timeline");
expect(timelineEvents).toHaveLength(4);
expect(timelineEvents.every((event) => event.item.type === "tool_call")).toBe(true); expect(timelineEvents.every((event) => event.item.type === "tool_call")).toBe(true);
const finalItem = timelineEvents.at(-1)?.item; const finalItem = timelineEvents.at(-1)?.item;
expect(finalItem).toMatchObject({ expect(finalItem).toMatchObject({
@@ -3574,7 +3573,7 @@ describe("Codex app-server provider", () => {
type: "sub_agent", type: "sub_agent",
subAgentType: "Sub-agent", subAgentType: "Sub-agent",
description: "Report findings.", description: "Report findings.",
log: "[Assistant] Found the path.", log: "",
actions: [], actions: [],
}, },
}); });
@@ -3651,13 +3650,9 @@ describe("Codex app-server provider", () => {
id: "settled-child-thread", id: "settled-child-thread",
status: "completed", status: "completed",
}); });
expect(events.at(-1)).toMatchObject({ expect(events.findLast((event) => event.type === "timeline")).toMatchObject({
type: "timeline", type: "timeline",
item: { item: { callId: "call-settled-child", status: "completed" },
callId: "call-settled-child",
status: "completed",
detail: { type: "sub_agent", log: "[Assistant] Late trailing output." },
},
}); });
appServer.completesSubAgentActivity({ appServer.completesSubAgentActivity({
@@ -3962,6 +3957,8 @@ describe("Codex app-server provider", () => {
createTestLogger(), createTestLogger(),
async () => appServer.child, async () => appServer.child,
); );
const events: AgentStreamEvent[] = [];
session.subscribe((event) => events.push(event));
try { try {
const resultPromise = session.run("Delegate the investigation, then report the result."); const resultPromise = session.run("Delegate the investigation, then report the result.");
@@ -4005,11 +4002,18 @@ describe("Codex app-server provider", () => {
type: "tool_call", type: "tool_call",
callId: "spawn-child-early", callId: "spawn-child-early",
status: "completed", status: "completed",
detail: { detail: { type: "sub_agent", log: "" },
type: "sub_agent",
log: "[Assistant] Early child findings.",
},
}); });
expect(events).toContainEqual(
expect.objectContaining({
type: "provider_subagent",
event: expect.objectContaining({
type: "timeline",
id: "child-thread-early",
item: expect.objectContaining({ type: "assistant_message" }),
}),
}),
);
appServer.assertNoErrors(); appServer.assertNoErrors();
} finally { } finally {
await session.close(); await session.close();
@@ -4080,10 +4084,7 @@ describe("Codex app-server provider", () => {
expect(toolCalls.at(-1)).toMatchObject({ expect(toolCalls.at(-1)).toMatchObject({
callId: "spawn-child-stable", callId: "spawn-child-stable",
status: "canceled", status: "canceled",
detail: { detail: { type: "sub_agent", log: "" },
type: "sub_agent",
log: "[Assistant] Still on the same card.",
},
}); });
appServer.assertNoErrors(); appServer.assertNoErrors();
} finally { } finally {
@@ -4163,11 +4164,10 @@ describe("Codex app-server provider", () => {
const result = await resultPromise; const result = await resultPromise;
const toolCalls = result.timeline.filter((item) => item.type === "tool_call"); const toolCalls = result.timeline.filter((item) => item.type === "tool_call");
expect(toolCalls.map((item) => item.status)).toEqual(["running", "completed", "completed"]); expect(toolCalls.map((item) => item.status)).toEqual(["running", "completed"]);
expect(toolCalls.at(-1)).toMatchObject({ expect(toolCalls.at(-1)).toMatchObject({
callId: "spawn-child-late-compaction", callId: "spawn-child-late-compaction",
status: "completed", status: "completed",
detail: { type: "sub_agent", log: "[Compacted]" },
}); });
appServer.assertNoErrors(); appServer.assertNoErrors();
} finally { } finally {
@@ -4175,7 +4175,7 @@ describe("Codex app-server provider", () => {
} }
}); });
test("projects legacy child tools into one stable sub-agent log", async () => { test("routes legacy child tools to the child timeline", async () => {
const appServer = createFakeCodexAppServer(); const appServer = createFakeCodexAppServer();
const session = new CodexAppServerAgentSession( const session = new CodexAppServerAgentSession(
createConfig({ cwd: "/workspace/project" }), createConfig({ cwd: "/workspace/project" }),
@@ -4183,6 +4183,8 @@ describe("Codex app-server provider", () => {
createTestLogger(), createTestLogger(),
async () => appServer.child, async () => appServer.child,
); );
const events: AgentStreamEvent[] = [];
session.subscribe((event) => events.push(event));
try { try {
const resultPromise = session.run("Delegate the implementation."); const resultPromise = session.run("Delegate the implementation.");
@@ -4225,19 +4227,26 @@ describe("Codex app-server provider", () => {
expect(finalToolCall).toMatchObject({ expect(finalToolCall).toMatchObject({
callId: "spawn-legacy-tool-child", callId: "spawn-legacy-tool-child",
status: "completed", status: "completed",
detail: { type: "sub_agent" }, detail: { type: "sub_agent", log: "" },
}); });
if (finalToolCall?.detail.type === "sub_agent") { const childToolCalls = events.flatMap((event) =>
expect(finalToolCall.detail.log.match(/\[Shell\]/g)).toHaveLength(1); event.type === "provider_subagent" &&
expect(finalToolCall.detail.log).toContain("[Edit]"); event.event.type === "timeline" &&
} event.event.id === "legacy-tool-child" &&
event.event.item.type === "tool_call"
? [event.event.item]
: [],
);
expect(new Set(childToolCalls.map((item) => item.detail.type))).toEqual(
new Set(["shell", "edit"]),
);
appServer.assertNoErrors(); appServer.assertNoErrors();
} finally { } finally {
await session.close(); await session.close();
} }
}); });
test("keeps nested MultiAgentV2 output inside the root sub-agent card", async () => { test("keeps nested MultiAgentV2 output out of the root sub-agent card", async () => {
const session = createSession(); const session = createSession();
const events: AgentStreamEvent[] = []; const events: AgentStreamEvent[] = [];
session.subscribe((event) => events.push(event)); session.subscribe((event) => events.push(event));
@@ -4297,8 +4306,22 @@ describe("Codex app-server provider", () => {
expect(beforeParentCompletes.at(-1)).toMatchObject({ expect(beforeParentCompletes.at(-1)).toMatchObject({
callId: "spawn-child-root", callId: "spawn-child-root",
status: "running", status: "running",
detail: { type: "sub_agent", log: expect.stringContaining("Grandchild findings.") }, detail: { type: "sub_agent", log: "" },
}); });
expect(events).toContainEqual(
expect.objectContaining({
type: "provider_subagent",
event: {
type: "timeline",
id: "grandchild-thread",
item: {
type: "assistant_message",
messageId: "grandchild-message",
text: "Grandchild findings.",
},
},
}),
);
await asInternals(session).handleNotification("turn/completed", { await asInternals(session).handleNotification("turn/completed", {
threadId: "child-thread-root", threadId: "child-thread-root",
@@ -4365,13 +4388,20 @@ describe("Codex app-server provider", () => {
"child-thread-root", "child-thread-root",
"child-thread-root", "child-thread-root",
]); ]);
expect(events.at(-1)).toMatchObject({ expect(events).toContainEqual(
type: "timeline", expect.objectContaining({
item: { type: "provider_subagent",
callId: "spawn-child-root", event: {
detail: { type: "sub_agent", log: expect.stringContaining("Still nested.") }, type: "timeline",
}, id: "grandchild-thread",
}); item: {
type: "assistant_message",
messageId: "grandchild-after-wait",
text: "Still nested.",
},
},
}),
);
}); });
test("never treats an unmapped foreign terminal as the root terminal", async () => { test("never treats an unmapped foreign terminal as the root terminal", async () => {
@@ -4791,7 +4821,7 @@ describe("Codex app-server provider", () => {
expect(events).toHaveLength(eventCountAfterSpawn); expect(events).toHaveLength(eventCountAfterSpawn);
}); });
test("keeps child context compaction inside the child card", async () => { test("keeps child context compaction on the child timeline", async () => {
const session = createSession(); const session = createSession();
const events: AgentStreamEvent[] = []; const events: AgentStreamEvent[] = [];
session.subscribe((event) => events.push(event)); session.subscribe((event) => events.push(event));
@@ -4824,10 +4854,70 @@ describe("Codex app-server provider", () => {
(item) => item.type === "tool_call" && item.callId === "spawn-child-compaction", (item) => item.type === "tool_call" && item.callId === "spawn-child-compaction",
), ),
).toBe(true); ).toBe(true);
expect(timelineItems.at(-1)).toMatchObject({ expect(
type: "tool_call", events.flatMap((event) =>
detail: { type: "sub_agent", log: "[Compacted]" }, event.type === "provider_subagent" && event.event.type === "timeline" ? [event.event] : [],
),
).toEqual([
{
type: "timeline",
id: "child-thread-compaction",
item: { type: "compaction", status: "loading" },
},
{
type: "timeline",
id: "child-thread-compaction",
item: { type: "compaction", status: "completed" },
},
]);
});
test("settles a child compaction once when the item completion is missing or duplicated", async () => {
const session = createSession();
const events: AgentStreamEvent[] = [];
session.subscribe((event) => events.push(event));
for (const child of ["compacted-child", "turn-ended-child"]) {
await asInternals(session).handleNotification("item/completed", {
threadId: "test-thread",
item: {
type: "subAgentActivity",
id: `spawn-${child}`,
kind: "started",
agentThreadId: child,
agentPath: `/root/${child}`,
},
});
await asInternals(session).handleNotification("item/started", {
threadId: child,
item: { type: "contextCompaction", id: `${child}-compaction` },
});
}
await asInternals(session).handleNotification("thread/compacted", {
threadId: "compacted-child",
}); });
await asInternals(session).handleNotification("item/completed", {
threadId: "compacted-child",
item: { type: "contextCompaction", id: "compacted-child-compaction" },
});
await asInternals(session).handleNotification("turn/completed", {
threadId: "turn-ended-child",
turn: { status: "completed" },
});
const compactions = events.flatMap((event) =>
event.type === "provider_subagent" && event.event.type === "timeline"
? [
`${event.event.id} ${event.event.item.type === "compaction" ? event.event.item.status : ""}`,
]
: [],
);
expect(compactions).toEqual([
"compacted-child loading",
"turn-ended-child loading",
"compacted-child completed",
"turn-ended-child completed",
]);
}); });
test("keeps the parent sub-agent running when a child command fails during the child turn", async () => { test("keeps the parent sub-agent running when a child command fails during the child turn", async () => {
@@ -4862,7 +4952,7 @@ describe("Codex app-server provider", () => {
}, },
}); });
expect(events.at(-1)?.item).toMatchObject({ expect(events.findLast((event) => event.type === "timeline")?.item).toMatchObject({
type: "tool_call", type: "tool_call",
callId: "call-sub-agent-child-command-failure", callId: "call-sub-agent-child-command-failure",
name: "Sub-agent", name: "Sub-agent",
@@ -5157,7 +5247,7 @@ describe("Codex app-server provider", () => {
); );
expect(liveToolCalls.at(-1)).toMatchObject({ expect(liveToolCalls.at(-1)).toMatchObject({
status: "running", status: "running",
detail: { type: "sub_agent", log: "[Assistant] More findings after resume." }, detail: { type: "sub_agent", log: "" },
}); });
liveEvents.length = 0; liveEvents.length = 0;
@@ -5170,12 +5260,12 @@ describe("Codex app-server provider", () => {
itemId: "legacy-child-message-after-resume", itemId: "legacy-child-message-after-resume",
delta: "Legacy findings after resume.", delta: "Legacy findings after resume.",
}); });
expect(liveEvents.at(-1)).toMatchObject({ expect(liveEvents.findLast((event) => event.type === "timeline")).toMatchObject({
type: "timeline", type: "timeline",
item: { item: {
callId: "legacy-spawn-history", callId: "legacy-spawn-history",
status: "running", status: "running",
detail: { type: "sub_agent", log: "[Assistant] Legacy findings after resume." }, detail: { type: "sub_agent", log: "" },
}, },
}); });
}); });
@@ -49,10 +49,10 @@ import { Dirent } from "node:fs";
import fs from "node:fs/promises"; import fs from "node:fs/promises";
import os from "node:os"; import os from "node:os";
import path from "node:path"; import path from "node:path";
import { isDeepStrictEqual } from "node:util";
import { z } from "zod"; import { z } from "zod";
import { renderPromptAttachmentAsText } from "../prompt-attachments.js"; import { renderPromptAttachmentAsText } from "../prompt-attachments.js";
import { composeSystemPromptParts } from "../system-prompt.js"; import { composeSystemPromptParts } from "../system-prompt.js";
import { curateAgentActivity } from "../activity-curator.js";
import { CodexAsyncQuestions, codexAsyncQuestionToTimeline } from "./codex/async-questions.js"; import { CodexAsyncQuestions, codexAsyncQuestionToTimeline } from "./codex/async-questions.js";
import { import {
mapCodexToolCallEnvelope, mapCodexToolCallEnvelope,
@@ -3384,8 +3384,6 @@ interface CodexSubAgentCallState {
activityItemIds: Set<string>; activityItemIds: Set<string>;
pendingCommandOutputDeltas: Map<string, string[]>; pendingCommandOutputDeltas: Map<string, string[]>;
pendingFileChangeOutputDeltas: Map<string, string[]>; pendingFileChangeOutputDeltas: Map<string, string[]>;
childItemOrder: string[];
childItems: Map<string, AgentTimelineItem>;
childThreadIds: Set<string>; childThreadIds: Set<string>;
} }
@@ -3487,6 +3485,9 @@ export class CodexAppServerAgentSession implements AgentSession {
private compactionTriggerByItemId = new Map<string, "auto" | "manual">(); private compactionTriggerByItemId = new Map<string, "auto" | "manual">();
private pendingRootCompactionItemIds = new Set<string>(); private pendingRootCompactionItemIds = new Set<string>();
private pendingAnonymousRootCompactions = 0; private pendingAnonymousRootCompactions = 0;
// Child threads with a compaction shown as loading. Some Codex builds settle it only through
// `thread/compacted` or the end of the child's turn.
private pendingChildCompactionThreadIds = new Set<string>();
// Codex can report one completed compaction through both channels: // Codex can report one completed compaction through both channels:
// `thread/compacted` and a completed `contextCompaction` item. // `thread/compacted` and a completed `contextCompaction` item.
private unpairedCompactionNotificationCompletions = 0; private unpairedCompactionNotificationCompletions = 0;
@@ -5516,6 +5517,9 @@ export class CodexAppServerAgentSession implements AgentSession {
case "patch_apply_completed": case "patch_apply_completed":
this.handlePatchApplyCompletedNotification(parsed, callId); this.handlePatchApplyCompletedNotification(parsed, callId);
return; return;
case "context_compacted":
this.settleChildCompaction(parsed.threadId);
return;
default: default:
// Aggregate child telemetry is redundant and must not leak into the // Aggregate child telemetry is redundant and must not leak into the
// root timeline. Concrete legacy tools are projected above for Codex // root timeline. Concrete legacy tools are projected above for Codex
@@ -5692,20 +5696,10 @@ export class CodexAppServerAgentSession implements AgentSession {
activityItemIds: new Set<string>(), activityItemIds: new Set<string>(),
pendingCommandOutputDeltas: new Map<string, string[]>(), pendingCommandOutputDeltas: new Map<string, string[]>(),
pendingFileChangeOutputDeltas: new Map<string, string[]>(), pendingFileChangeOutputDeltas: new Map<string, string[]>(),
childItemOrder: [],
childItems: new Map<string, AgentTimelineItem>(),
childThreadIds: new Set<string>(), childThreadIds: new Set<string>(),
} satisfies CodexSubAgentCallState); } satisfies CodexSubAgentCallState);
state.toolCall = { state.toolCall = timelineItem;
...timelineItem,
detail: {
...timelineItem.detail,
log:
timelineItem.detail.log ||
(state.toolCall.detail.type === "sub_agent" ? state.toolCall.detail.log : ""),
},
};
state.parentCallId ??= parentCallId; state.parentCallId ??= parentCallId;
state.parentSubagentId ??= parentSubagentId; state.parentSubagentId ??= parentSubagentId;
const activity = readCodexSubAgentActivity(rawItem); const activity = readCodexSubAgentActivity(rawItem);
@@ -5758,25 +5752,17 @@ export class CodexAppServerAgentSession implements AgentSession {
const activityToolCall = mapCodexToolCallFromThreadItem(rawItem, { const activityToolCall = mapCodexToolCallFromThreadItem(rawItem, {
cwd: this.config.cwd ?? null, cwd: this.config.cwd ?? null,
}); });
if ( const subAgentType =
activityToolCall?.detail.type === "sub_agent" && activityToolCall?.detail.type === "sub_agent"
state.toolCall.detail.type === "sub_agent" ? activityToolCall.detail.subAgentType
) { : undefined;
state.toolCall = {
...state.toolCall,
detail: {
...state.toolCall.detail,
subAgentType: activityToolCall.detail.subAgentType,
},
};
}
let nextStatus: ToolCallTimelineItem["status"] | undefined = "running"; let nextStatus: ToolCallTimelineItem["status"] | undefined = "running";
if (activity.kind === "interrupted") { if (activity.kind === "interrupted") {
nextStatus = "canceled"; nextStatus = "canceled";
} else if (isTerminalSubAgentStatus(state.toolCall.status)) { } else if (isTerminalSubAgentStatus(state.toolCall.status)) {
nextStatus = undefined; nextStatus = undefined;
} }
this.emitSubAgentActivityUpdate(callId, nextStatus); this.emitSubAgentActivityUpdate(callId, nextStatus, { subAgentType });
return true; return true;
} }
@@ -5817,7 +5803,13 @@ export class CodexAppServerAgentSession implements AgentSession {
): boolean { ): boolean {
if ( if (
childSubAgentCallId && childSubAgentCallId &&
this.handleSubAgentContextCompactionItem(childSubAgentCallId, parsed.item, "completed") parsed.threadId &&
this.handleSubAgentContextCompactionItem(
childSubAgentCallId,
parsed.threadId,
parsed.item,
"completed",
)
) { ) {
return true; return true;
} }
@@ -5827,17 +5819,6 @@ export class CodexAppServerAgentSession implements AgentSession {
); );
} }
private upsertSubAgentChildItem(callId: string, itemId: string, item: AgentTimelineItem): void {
const state = this.subAgentCallsByCallId.get(callId);
if (!state) {
return;
}
if (!state.childItems.has(itemId)) {
state.childItemOrder.push(itemId);
}
state.childItems.set(itemId, item);
}
private emitCodexToolTimelineItem( private emitCodexToolTimelineItem(
timelineItem: ToolCallTimelineItem, timelineItem: ToolCallTimelineItem,
subAgentCallId: string | null, subAgentCallId: string | null,
@@ -5847,7 +5828,6 @@ export class CodexAppServerAgentSession implements AgentSession {
this.emitEvent({ type: "timeline", provider: CODEX_PROVIDER, item: timelineItem }); this.emitEvent({ type: "timeline", provider: CODEX_PROVIDER, item: timelineItem });
return; return;
} }
this.upsertSubAgentChildItem(subAgentCallId, timelineItem.callId, timelineItem);
const state = this.subAgentCallsByCallId.get(subAgentCallId); const state = this.subAgentCallsByCallId.get(subAgentCallId);
if (state) { if (state) {
const targetThreadIds = childThreadId ? [childThreadId] : state.childThreadIds; const targetThreadIds = childThreadId ? [childThreadId] : state.childThreadIds;
@@ -5861,26 +5841,15 @@ export class CodexAppServerAgentSession implements AgentSession {
); );
} }
private getSubAgentChildTimeline(state: CodexSubAgentCallState): AgentTimelineItem[] {
return state.childItemOrder
.map((itemId) => state.childItems.get(itemId))
.filter((item): item is AgentTimelineItem => Boolean(item));
}
private emitSubAgentActivityUpdate( private emitSubAgentActivityUpdate(
callId: string, callId: string,
status?: ToolCallTimelineItem["status"], status?: ToolCallTimelineItem["status"],
options?: { reopen?: boolean }, options?: { reopen?: boolean; subAgentType?: string },
): void { ): void {
const state = this.subAgentCallsByCallId.get(callId); const state = this.subAgentCallsByCallId.get(callId);
if (!state || state.toolCall.detail.type !== "sub_agent") { if (!state || state.toolCall.detail.type !== "sub_agent") {
return; return;
} }
const childTimeline = this.getSubAgentChildTimeline(state);
const log =
childTimeline.length > 0
? curateAgentActivity(childTimeline, { labelAssistantMessages: true })
: "";
let resolvedStatus = status ?? state.toolCall.status; let resolvedStatus = status ?? state.toolCall.status;
if ( if (
status === "running" && status === "running" &&
@@ -5889,16 +5858,12 @@ export class CodexAppServerAgentSession implements AgentSession {
) { ) {
resolvedStatus = state.toolCall.status; resolvedStatus = state.toolCall.status;
} }
for (const childThreadId of state.childThreadIds) { const baseToolCall = options?.subAgentType
this.emitProviderSubagentUpsert(childThreadId, state, resolvedStatus); ? {
} ...state.toolCall,
const baseToolCall = { detail: { ...state.toolCall.detail, subAgentType: options.subAgentType },
...state.toolCall, }
detail: { : state.toolCall;
...state.toolCall.detail,
log,
},
};
const nextToolCall: ToolCallTimelineItem = const nextToolCall: ToolCallTimelineItem =
resolvedStatus === "failed" resolvedStatus === "failed"
? { ? {
@@ -5911,10 +5876,14 @@ export class CodexAppServerAgentSession implements AgentSession {
status: resolvedStatus, status: resolvedStatus,
error: null, error: null,
}; };
// The card is a launch marker: the child's activity streams to its own timeline, so the card
// is re-sent only when its status or label changes.
const cardChanged = !isDeepStrictEqual(nextToolCall, state.toolCall);
state.toolCall = nextToolCall; state.toolCall = nextToolCall;
if (state.parentCallId && state.parentCallId !== callId) { for (const childThreadId of state.childThreadIds) {
this.upsertSubAgentChildItem(state.parentCallId, state.callId, nextToolCall); this.emitProviderSubagentUpsert(childThreadId, state, resolvedStatus);
this.emitSubAgentActivityUpdate(state.parentCallId); }
if (!cardChanged || (state.parentCallId && state.parentCallId !== callId)) {
return; return;
} }
this.emitEvent({ type: "timeline", provider: CODEX_PROVIDER, item: nextToolCall }); this.emitEvent({ type: "timeline", provider: CODEX_PROVIDER, item: nextToolCall });
@@ -6022,7 +5991,6 @@ export class CodexAppServerAgentSession implements AgentSession {
): void { ): void {
this.applyBufferedDeltaTextToTimelineItem(timelineItem, itemId); this.applyBufferedDeltaTextToTimelineItem(timelineItem, itemId);
if (itemId) { if (itemId) {
this.upsertSubAgentChildItem(callId, itemId, timelineItem);
this.pendingAgentMessages.delete(itemId); this.pendingAgentMessages.delete(itemId);
this.pendingReasoning.delete(itemId); this.pendingReasoning.delete(itemId);
this.pendingCommandOutputDeltas.delete(itemId); this.pendingCommandOutputDeltas.delete(itemId);
@@ -6033,19 +6001,29 @@ export class CodexAppServerAgentSession implements AgentSession {
private handleSubAgentContextCompactionItem( private handleSubAgentContextCompactionItem(
callId: string, callId: string,
childThreadId: string,
item: { id?: string; type?: string; [key: string]: unknown }, item: { id?: string; type?: string; [key: string]: unknown },
status: "loading" | "completed", status: "loading" | "completed",
): boolean { ): boolean {
if (!this.isContextCompactionItem(item)) { if (!this.isContextCompactionItem(item)) {
return false; return false;
} }
if (item.id) { if (status === "loading") {
this.upsertSubAgentChildItem(callId, item.id, { type: "compaction", status }); this.pendingChildCompactionThreadIds.add(childThreadId);
this.emitProviderSubagentTimeline(childThreadId, { type: "compaction", status });
} else {
this.settleChildCompaction(childThreadId);
} }
this.emitSubAgentActivityUpdate(callId); this.emitSubAgentActivityUpdate(callId);
return true; return true;
} }
private settleChildCompaction(childThreadId: string): void {
if (this.pendingChildCompactionThreadIds.delete(childThreadId)) {
this.emitProviderSubagentTimeline(childThreadId, { type: "compaction", status: "completed" });
}
}
private shouldSkipCompletedThreadItem( private shouldSkipCompletedThreadItem(
timelineItem: AgentTimelineItem, timelineItem: AgentTimelineItem,
normalizedItemType: string | undefined, normalizedItemType: string | undefined,
@@ -6076,11 +6054,6 @@ export class CodexAppServerAgentSession implements AgentSession {
text: parsed.delta, text: parsed.delta,
}); });
} }
this.upsertSubAgentChildItem(subAgentCallId, parsed.itemId, {
type: "assistant_message",
messageId: parsed.itemId,
text,
});
this.emitSubAgentActivityUpdate(subAgentCallId, "running"); this.emitSubAgentActivityUpdate(subAgentCallId, "running");
return; return;
} }
@@ -6114,10 +6087,6 @@ export class CodexAppServerAgentSession implements AgentSession {
text: parsed.delta, text: parsed.delta,
}); });
} }
this.upsertSubAgentChildItem(subAgentCallId, parsed.itemId, {
type: "reasoning",
text: prev.join(""),
});
this.emitSubAgentActivityUpdate(subAgentCallId, "running"); this.emitSubAgentActivityUpdate(subAgentCallId, "running");
return; return;
} }
@@ -6185,6 +6154,7 @@ export class CodexAppServerAgentSession implements AgentSession {
): void { ): void {
const subAgentCallId = this.getSubAgentCallIdForThread(parsed.threadId); const subAgentCallId = this.getSubAgentCallIdForThread(parsed.threadId);
if (subAgentCallId) { if (subAgentCallId) {
if (parsed.threadId) this.settleChildCompaction(parsed.threadId);
let status: ToolCallTimelineItem["status"] = "completed"; let status: ToolCallTimelineItem["status"] = "completed";
if (parsed.status === "failed") { if (parsed.status === "failed") {
status = "failed"; status = "failed";
@@ -6771,7 +6741,13 @@ export class CodexAppServerAgentSession implements AgentSession {
const childSubAgentCallId = this.getSubAgentCallIdForThread(parsed.threadId); const childSubAgentCallId = this.getSubAgentCallIdForThread(parsed.threadId);
if ( if (
childSubAgentCallId && childSubAgentCallId &&
this.handleSubAgentContextCompactionItem(childSubAgentCallId, parsed.item, "loading") parsed.threadId &&
this.handleSubAgentContextCompactionItem(
childSubAgentCallId,
parsed.threadId,
parsed.item,
"loading",
)
) { ) {
return; return;
} }
@@ -6802,9 +6778,6 @@ export class CodexAppServerAgentSession implements AgentSession {
}); });
if (childSubAgentCallId) { if (childSubAgentCallId) {
this.emitStartedProviderSubagentItem(parsed.threadId, timelineItem); this.emitStartedProviderSubagentItem(parsed.threadId, timelineItem);
if (parsed.item.id) {
this.upsertSubAgentChildItem(childSubAgentCallId, parsed.item.id, timelineItem);
}
this.emitSubAgentActivityUpdate(childSubAgentCallId, "running"); this.emitSubAgentActivityUpdate(childSubAgentCallId, "running");
await this.replayPendingSubAgentNotifications(registeredChildThreadIds); await this.replayPendingSubAgentNotifications(registeredChildThreadIds);
return; return;
@@ -6858,9 +6831,6 @@ export class CodexAppServerAgentSession implements AgentSession {
if (parsed.threadId) { if (parsed.threadId) {
this.emitProviderSubagentTimeline(parsed.threadId, timelineItem); this.emitProviderSubagentTimeline(parsed.threadId, timelineItem);
} }
if (itemId) {
this.upsertSubAgentChildItem(childSubAgentCallId, itemId, timelineItem);
}
this.emitSubAgentActivityUpdate(childSubAgentCallId, "running"); this.emitSubAgentActivityUpdate(childSubAgentCallId, "running");
return; return;
} }
@@ -950,6 +950,7 @@ function mapCollabAgentToolCallItem(
type: "sub_agent", type: "sub_agent",
subAgentType: "Sub-agent", subAgentType: "Sub-agent",
...(item.prompt ? { description: item.prompt } : {}), ...(item.prompt ? { description: item.prompt } : {}),
// COMPAT(subagent-log): remove after 2027-04-30.
log: "", log: "",
actions: [], actions: [],
}; };
@@ -1006,6 +1007,7 @@ function mapSubAgentActivityItem(
type: "sub_agent", type: "sub_agent",
subAgentType: nativeName, subAgentType: nativeName,
description, description,
// COMPAT(subagent-log): remove after 2027-04-30.
log: "", log: "",
actions: [], actions: [],
}, },
@@ -69,7 +69,7 @@ import {
type OmpRuntimeOptions, type OmpRuntimeOptions,
} from "./provider-config.js"; } from "./provider-config.js";
export { formatOmpVersionSupport, resolveOmpDiagnosticPaths } from "./provider-config.js"; export { formatOmpVersionSupport, resolveOmpDiagnosticPaths } from "./provider-config.js";
import { OmpSubagentCardTracker, type OmpSubagentCardScheduler } from "./subagent-card-tracker.js"; import { OmpSubagentCardTracker } from "./subagent-card-tracker.js";
import { ompSkillPromptUserText, shouldDisplayOmpCustomMessage } from "./custom-message.js"; import { ompSkillPromptUserText, shouldDisplayOmpCustomMessage } from "./custom-message.js";
import { getUserMessageText } from "./message-history.js"; import { getUserMessageText } from "./message-history.js";
import { mapOmpSystemNoticeToNotification } from "./system-notice.js"; import { mapOmpSystemNoticeToNotification } from "./system-notice.js";
@@ -130,7 +130,6 @@ export interface OmpAgentClientOptions {
logger: Logger; logger: Logger;
runtimeSettings?: ProviderRuntimeSettings; runtimeSettings?: ProviderRuntimeSettings;
runtime?: OmpRuntime; runtime?: OmpRuntime;
subagentCardScheduler?: OmpSubagentCardScheduler;
providerIdleScheduler?: OmpProviderIdleScheduler; providerIdleScheduler?: OmpProviderIdleScheduler;
noTurnScheduler?: OmpNoTurnScheduler; noTurnScheduler?: OmpNoTurnScheduler;
usagePollScheduler?: OmpUsagePollScheduler; usagePollScheduler?: OmpUsagePollScheduler;
@@ -205,7 +204,6 @@ interface OmpAgentSessionOptions {
initialState: OmpSessionState; initialState: OmpSessionState;
currentModeId?: string | null; currentModeId?: string | null;
logger: Logger; logger: Logger;
subagentCardScheduler?: OmpSubagentCardScheduler;
providerIdleScheduler?: OmpProviderIdleScheduler; providerIdleScheduler?: OmpProviderIdleScheduler;
noTurnScheduler?: OmpNoTurnScheduler; noTurnScheduler?: OmpNoTurnScheduler;
usagePollScheduler?: OmpUsagePollScheduler; usagePollScheduler?: OmpUsagePollScheduler;
@@ -773,9 +771,7 @@ export class OmpAgentSession implements AgentSession {
this.logger.debug({ err: error }, "OMP context usage poll failed"); this.logger.debug({ err: error }, "OMP context usage poll failed");
}, },
}); });
this.subagentCardTracker = new OmpSubagentCardTracker({ this.subagentCardTracker = new OmpSubagentCardTracker();
scheduler: options.subagentCardScheduler,
});
this.lastKnownThinkingOptionId = this.lastKnownThinkingOptionId =
normalizeOmpThinkingOption(options.config.thinkingOptionId) ?? normalizeOmpThinkingOption(options.config.thinkingOptionId) ??
this.state.thinkingLevel ?? this.state.thinkingLevel ??
@@ -2155,8 +2151,7 @@ export class OmpAgentSession implements AgentSession {
return mapOmpToolDetail(toolCall, result, { return mapOmpToolDetail(toolCall, result, {
toolCallId, toolCallId,
bridgedTool: this.hostTools?.bridge?.tool(toolCall.toolName), bridgedTool: this.hostTools?.bridge?.tool(toolCall.toolName),
mapSubagentDetail: (detail) => mapSubagentDetail: (detail) => this.subagentCardTracker.detailFor(toolCallId, detail),
this.subagentCardTracker.detailFor(toolCallId, detail) ?? detail,
}); });
} }
@@ -2246,7 +2241,6 @@ export class OmpAgentClient implements AgentClient {
private readonly logger: Logger; private readonly logger: Logger;
private readonly runtimeSettings?: ProviderRuntimeSettings; private readonly runtimeSettings?: ProviderRuntimeSettings;
private readonly subagentCardScheduler?: OmpSubagentCardScheduler;
private readonly providerIdleScheduler?: OmpProviderIdleScheduler; private readonly providerIdleScheduler?: OmpProviderIdleScheduler;
private readonly noTurnScheduler?: OmpNoTurnScheduler; private readonly noTurnScheduler?: OmpNoTurnScheduler;
private readonly usagePollScheduler?: OmpUsagePollScheduler; private readonly usagePollScheduler?: OmpUsagePollScheduler;
@@ -2265,7 +2259,6 @@ export class OmpAgentClient implements AgentClient {
); );
this.logger = options.logger; this.logger = options.logger;
this.runtimeSettings = runtimeSettings; this.runtimeSettings = runtimeSettings;
this.subagentCardScheduler = options.subagentCardScheduler;
this.providerIdleScheduler = options.providerIdleScheduler; this.providerIdleScheduler = options.providerIdleScheduler;
this.noTurnScheduler = options.noTurnScheduler; this.noTurnScheduler = options.noTurnScheduler;
this.usagePollScheduler = options.usagePollScheduler; this.usagePollScheduler = options.usagePollScheduler;
@@ -2349,7 +2342,6 @@ export class OmpAgentClient implements AgentClient {
initialState, initialState,
currentModeId: launchMode.modeId, currentModeId: launchMode.modeId,
logger: this.logger, logger: this.logger,
subagentCardScheduler: this.subagentCardScheduler,
providerIdleScheduler: this.providerIdleScheduler, providerIdleScheduler: this.providerIdleScheduler,
noTurnScheduler: this.noTurnScheduler, noTurnScheduler: this.noTurnScheduler,
usagePollScheduler: this.usagePollScheduler, usagePollScheduler: this.usagePollScheduler,
@@ -2421,7 +2413,6 @@ export class OmpAgentClient implements AgentClient {
initialState, initialState,
currentModeId: launchMode.modeId, currentModeId: launchMode.modeId,
logger: this.logger, logger: this.logger,
subagentCardScheduler: this.subagentCardScheduler,
providerIdleScheduler: this.providerIdleScheduler, providerIdleScheduler: this.providerIdleScheduler,
noTurnScheduler: this.noTurnScheduler, noTurnScheduler: this.noTurnScheduler,
usagePollScheduler: this.usagePollScheduler, usagePollScheduler: this.usagePollScheduler,
@@ -637,7 +637,7 @@ describe("OMP history mapper", () => {
subAgentType: "explore", subAgentType: "explore",
description: "Inspect files", description: "Inspect files",
childSessionId: "/tmp/omp-task/Explore.jsonl", childSessionId: "/tmp/omp-task/Explore.jsonl",
log: "done\ntranscript: /tmp/omp-task/Explore.jsonl", log: "",
}, },
error: null, error: null,
}, },
@@ -1,6 +1,6 @@
import { describe, expect, test } from "vitest"; import { describe, expect, test } from "vitest";
import { OmpSubagentCardTracker, type OmpSubagentCardScheduler } from "./subagent-card-tracker.js"; import { OmpSubagentCardTracker } from "./subagent-card-tracker.js";
import type { OmpSubagentLifecyclePayload, OmpSubagentProgressPayload } from "./rpc-types.js"; import type { OmpSubagentLifecyclePayload, OmpSubagentProgressPayload } from "./rpc-types.js";
const PARENT_TOOL_CALL_ID = "task-1"; const PARENT_TOOL_CALL_ID = "task-1";
@@ -59,184 +59,84 @@ const PROGRESS: OmpSubagentProgressPayload[] = [
}, },
]; ];
class ManualScheduler implements OmpSubagentCardScheduler {
private currentMs = 0;
private nextId = 1;
private readonly timers = new Map<number, { dueMs: number; callback: () => void }>();
now(): number {
return this.currentMs;
}
setTimeout(callback: () => void, delayMs: number) {
const id = this.nextId;
this.nextId += 1;
this.timers.set(id, { dueMs: this.currentMs + delayMs, callback });
return { token: id };
}
clearTimeout(timer: { token: unknown }): void {
if (typeof timer.token === "number") {
this.timers.delete(timer.token);
}
}
advance(ms: number): void {
this.currentMs += ms;
const dueTimers = [...this.timers.entries()]
.filter(([, timer]) => timer.dueMs <= this.currentMs)
.sort((left, right) => left[1].dueMs - right[1].dueMs);
for (const [id, timer] of dueTimers) {
if (this.timers.delete(id)) {
timer.callback();
}
}
}
}
describe("OmpSubagentCardTracker", () => { describe("OmpSubagentCardTracker", () => {
test("folds lifecycle and progress into one throttled sub-agent detail", () => { test("keeps the card a launch marker while the child runs", () => {
const scheduler = new ManualScheduler();
const emitted: string[] = []; const emitted: string[] = [];
const tracker = new OmpSubagentCardTracker({ const emit = (toolCallId: string) => {
scheduler, emitted.push(toolCallId);
emitToolCall: (toolCallId) => { return true;
emitted.push(toolCallId); };
return true; const tracker = new OmpSubagentCardTracker();
}, tracker.handleLifecycle(LIFECYCLE, emit);
});
tracker.handleLifecycle(LIFECYCLE);
for (const payload of PROGRESS) { for (const payload of PROGRESS) {
tracker.handleProgress(payload); tracker.handleProgress(payload, emit);
} }
expect(emitted).toEqual([PARENT_TOOL_CALL_ID]); expect(emitted).toEqual([PARENT_TOOL_CALL_ID]);
const detailBeforeTrailing = tracker.detailFor(PARENT_TOOL_CALL_ID, {
type: "sub_agent",
subAgentType: "task",
description: "Task arg description wins",
log: "",
});
expect(detailBeforeTrailing).toEqual({
type: "sub_agent",
subAgentType: "task",
description: "Task arg description wins",
childSessionId: SESSION_FILE,
log: [
"EchoSubagent started",
"[bash] echo subagent-hi",
"[yield]",
"EchoSubagent completed",
].join("\n"),
});
scheduler.advance(500);
expect(emitted).toEqual([PARENT_TOOL_CALL_ID, PARENT_TOOL_CALL_ID]);
});
test("aggregates batch progress streams into one index-prefixed log", () => {
const scheduler = new ManualScheduler();
const emitted: string[] = [];
const tracker = new OmpSubagentCardTracker({
scheduler,
emitToolCall: (toolCallId) => {
emitted.push(toolCallId);
return true;
},
});
tracker.handleLifecycle({
id: "Explore",
agent: "task",
description: "Inspect files",
status: "started",
sessionFile: "/tmp/one.jsonl",
parentToolCallId: "task.batch-1",
index: 0,
});
scheduler.advance(600);
tracker.handleProgress({
index: 5,
agent: "task",
task: "Run tests",
parentToolCallId: "task.batch-1",
progress: {
id: "Test",
status: "running",
description: "Run tests",
recentTools: [{ tool: "bash", args: "npm test", endMs: 10 }],
},
sessionFile: "/tmp/two.jsonl",
});
expect(emitted).toEqual(["task.batch-1", "task.batch-1"]);
expect( expect(
tracker.detailFor("task.batch-1", { tracker.detailFor(PARENT_TOOL_CALL_ID, {
type: "sub_agent", type: "sub_agent",
subAgentType: "batch", subAgentType: "task",
actions: [], description: "Task arg description wins",
log: "", log: "",
}), }),
).toEqual({ ).toEqual({
type: "sub_agent", type: "sub_agent",
subAgentType: "batch", subAgentType: "task",
description: "Inspect files", description: "Task arg description wins",
childSessionId: "/tmp/one.jsonl", childSessionId: SESSION_FILE,
log: "[1/6] Explore started\n[6/6] [bash] npm test", log: "",
actions: [],
}); });
}); });
test("keeps dirty trailing state available for final detail and cancels it on cleanup", () => { test("re-emits the card when a later event names the child", () => {
const scheduler = new ManualScheduler();
const emitted: string[] = []; const emitted: string[] = [];
const tracker = new OmpSubagentCardTracker({ const emit = (toolCallId: string) => {
scheduler, emitted.push(toolCallId);
emitToolCall: (toolCallId) => { return true;
emitted.push(toolCallId); };
return true; const tracker = new OmpSubagentCardTracker();
tracker.handleLifecycle({ ...LIFECYCLE, description: undefined, sessionFile: undefined }, emit);
tracker.handleProgress(PROGRESS[0], emit);
expect(emitted).toEqual([PARENT_TOOL_CALL_ID, PARENT_TOOL_CALL_ID]);
expect(tracker.detailFor(PARENT_TOOL_CALL_ID, { type: "sub_agent", log: "" })).toEqual({
type: "sub_agent",
childSessionId: SESSION_FILE,
log: "",
});
tracker.delete(PARENT_TOOL_CALL_ID);
expect(tracker.detailFor(PARENT_TOOL_CALL_ID, { type: "sub_agent", log: "" })).toEqual({
type: "sub_agent",
log: "",
});
});
test("leaves the card alone when a later child of the same task starts", () => {
const emitted: string[] = [];
const emit = (toolCallId: string) => {
emitted.push(toolCallId);
return true;
};
const tracker = new OmpSubagentCardTracker();
tracker.handleLifecycle(LIFECYCLE, emit);
tracker.handleLifecycle(
{
...LIFECYCLE,
id: "Second",
index: 1,
description: "Second child",
sessionFile: "/s.jsonl",
}, },
emit,
);
expect(emitted).toEqual([PARENT_TOOL_CALL_ID]);
expect(tracker.detailFor(PARENT_TOOL_CALL_ID, { type: "sub_agent", log: "" })).toEqual({
type: "sub_agent",
description: "Run echo in subagent",
childSessionId: SESSION_FILE,
log: "",
}); });
tracker.handleLifecycle({
id: "Explore",
agent: "task",
description: "Inspect files",
status: "started",
parentToolCallId: "task-1",
index: 0,
});
scheduler.advance(100);
tracker.handleProgress({
index: 0,
agent: "task",
task: "Inspect files",
parentToolCallId: "task-1",
progress: {
id: "Explore",
status: "running",
recentOutput: ["found target file"],
},
});
expect(emitted).toEqual(["task-1"]);
expect(
tracker.detailFor("task-1", {
type: "sub_agent",
log: "",
}).log,
).toBe("Explore started\nfound target file");
tracker.delete("task-1");
scheduler.advance(500);
expect(emitted).toEqual(["task-1"]);
expect(
tracker.detailFor("task-1", {
type: "sub_agent",
log: "static",
}).log,
).toBe("static");
}); });
}); });
@@ -1,361 +1,106 @@
import type { ToolCallDetail } from "../../agent-sdk-types.js"; import type { ToolCallDetail } from "../../agent-sdk-types.js";
import type { OmpSubagentLifecyclePayload, OmpSubagentProgressPayload } from "./rpc-types.js"; import type { OmpSubagentLifecyclePayload, OmpSubagentProgressPayload } from "./rpc-types.js";
export interface OmpSubagentCardTimer { interface OmpSubagentCardChild {
readonly token: unknown;
}
export interface OmpSubagentCardScheduler {
now(): number;
setTimeout(callback: () => void, delayMs: number): OmpSubagentCardTimer;
clearTimeout(timer: OmpSubagentCardTimer): void;
}
export interface OmpSubagentCardTrackerOptions {
scheduler?: OmpSubagentCardScheduler;
emitToolCall?: (toolCallId: string) => boolean;
}
interface OmpSubagentLogLine {
key: string;
text: string;
}
interface OmpSubagentCardItem {
index: number; index: number;
description?: string; description?: string;
agent?: string;
status?: "pending" | "running" | "completed" | "failed" | "aborted";
childSessionId?: string; childSessionId?: string;
lines: OmpSubagentLogLine[];
lineKeys: Set<string>;
}
interface OmpSubagentCardState {
items: Map<number, OmpSubagentCardItem>;
emitToolCall: (toolCallId: string) => boolean;
lastEmitMs: number | null;
trailingTimer: OmpSubagentCardTimer | null;
dirty: boolean;
}
const MAX_LOG_LINES_PER_ITEM = 200;
const MAX_LOG_LINE_CHARS = 240;
const THROTTLE_INTERVAL_MS = 500;
export function createOmpSubagentCardScheduler(): OmpSubagentCardScheduler {
return {
now: () => Date.now(),
setTimeout: (callback, delayMs) => ({ token: setTimeout(callback, delayMs) }),
clearTimeout: (timer) => {
clearTimeout(timer.token as ReturnType<typeof setTimeout>);
},
};
} }
/**
* Fills a task card's description and child session from OMP's sub-agent events. The card is a
* launch marker that names the task's first child; the children's activity belongs to their own
* timelines.
*/
export class OmpSubagentCardTracker { export class OmpSubagentCardTracker {
private readonly scheduler: OmpSubagentCardScheduler; private readonly firstChildren = new Map<string, OmpSubagentCardChild>();
private readonly emitToolCall: (toolCallId: string) => boolean;
private readonly states = new Map<string, OmpSubagentCardState>();
constructor(options: OmpSubagentCardTrackerOptions) {
this.scheduler = options.scheduler ?? createOmpSubagentCardScheduler();
this.emitToolCall = options.emitToolCall ?? (() => false);
}
handleLifecycle( handleLifecycle(
payload: OmpSubagentLifecyclePayload, payload: OmpSubagentLifecyclePayload,
emitToolCall: (toolCallId: string) => boolean = this.emitToolCall, emitToolCall: (toolCallId: string) => boolean,
): void { ): void {
const parentToolCallId = readTrimmedString(payload.parentToolCallId); this.update(
if (!parentToolCallId) { payload.parentToolCallId,
return; {
} index: payload.index,
this.stateFor(parentToolCallId).emitToolCall = emitToolCall; description: payload.description,
const item = this.upsertItem(parentToolCallId, { childSessionId: payload.sessionFile,
index: payload.index, },
agent: payload.agent, emitToolCall,
description: payload.description,
status: payload.status === "started" ? "running" : payload.status,
childSessionId: payload.sessionFile,
});
this.appendLine(
item,
`lifecycle:${payload.status}:${payload.id}`,
`${payload.id} ${payload.status}`,
); );
this.requestEmit(parentToolCallId);
} }
handleProgress( handleProgress(
payload: OmpSubagentProgressPayload, payload: OmpSubagentProgressPayload,
emitToolCall: (toolCallId: string) => boolean = this.emitToolCall, emitToolCall: (toolCallId: string) => boolean,
): void { ): void {
const parentToolCallId = readTrimmedString(payload.parentToolCallId); this.update(
if (!parentToolCallId) { payload.parentToolCallId,
return; {
} index: payload.index,
this.stateFor(parentToolCallId).emitToolCall = emitToolCall; description: payload.progress.description,
const item = this.upsertItem(parentToolCallId, { childSessionId: payload.sessionFile,
index: payload.index, },
agent: payload.agent, emitToolCall,
description: payload.progress.description, );
status: payload.progress.status,
childSessionId: payload.sessionFile,
});
const currentToolLine = summarizeTool(readRecord(payload.progress.currentTool));
if (currentToolLine) {
this.appendLine(item, `current:${currentToolLine.key}`, currentToolLine.text);
}
for (const tool of readRecordArray(payload.progress.recentTools)) {
const line = summarizeTool(tool);
if (line) {
this.appendLine(item, `tool:${line.key}`, line.text);
}
}
for (const output of readOutputLines(payload.progress.recentOutput)) {
this.appendLine(item, `output:${output}`, output);
}
if (payload.progress.status !== "running") {
this.appendLine(
item,
`status:${payload.progress.status}:${payload.progress.id}`,
`${payload.progress.id} ${payload.progress.status}`,
);
}
this.requestEmit(parentToolCallId);
} }
detailFor(toolCallId: string, baseDetail: ToolCallDetail): ToolCallDetail { detailFor(toolCallId: string, baseDetail: ToolCallDetail): ToolCallDetail {
if (baseDetail.type !== "sub_agent") { if (baseDetail.type !== "sub_agent") {
return baseDetail; return baseDetail;
} }
const state = this.states.get(toolCallId); const first = this.firstChildren.get(toolCallId);
if (!state) { if (!first) {
return baseDetail; return baseDetail;
} }
const items = [...state.items.values()].sort((left, right) => left.index - right.index); const description = baseDetail.description ?? first.description;
const firstItem = items[0]; const childSessionId = first.childSessionId ?? baseDetail.childSessionId;
if (!firstItem) { return {
return baseDetail; ...baseDetail,
} ...(description ? { description } : {}),
...(childSessionId ? { childSessionId } : {}),
const detail: ToolCallDetail = {
type: "sub_agent",
...(baseDetail.subAgentType ? { subAgentType: baseDetail.subAgentType } : {}),
...((baseDetail.description ?? firstItem.description)
? { description: baseDetail.description ?? firstItem.description }
: {}),
...((firstItem.childSessionId ?? baseDetail.childSessionId)
? { childSessionId: firstItem.childSessionId ?? baseDetail.childSessionId }
: {}),
log: buildLog(items, baseDetail.log),
}; };
return baseDetail.actions ? { ...detail, actions: baseDetail.actions } : detail;
}
flush(toolCallId: string): void {
const state = this.states.get(toolCallId);
if (!state || !state.dirty) {
return;
}
this.emitNow(toolCallId, state);
} }
delete(toolCallId: string): void { delete(toolCallId: string): void {
const state = this.states.get(toolCallId); this.firstChildren.delete(toolCallId);
if (state?.trailingTimer) {
this.scheduler.clearTimeout(state.trailingTimer);
}
this.states.delete(toolCallId);
} }
clear(): void { clear(): void {
for (const toolCallId of this.states.keys()) { this.firstChildren.clear();
this.delete(toolCallId);
}
} }
private upsertItem( private update(
parentToolCallId: string, parentToolCallId: string | undefined,
input: { input: { index: number; description?: string; childSessionId?: string },
index: number; emitToolCall: (toolCallId: string) => boolean,
agent?: string; ): void {
status?: "pending" | "running" | "completed" | "failed" | "aborted"; const toolCallId = readTrimmedString(parentToolCallId);
description?: string; if (!toolCallId) {
childSessionId?: string; return;
},
): OmpSubagentCardItem {
const state = this.stateFor(parentToolCallId);
const existing = state.items.get(input.index);
if (existing) {
existing.agent = readTrimmedString(input.agent) ?? existing.agent;
existing.status = input.status ?? existing.status;
existing.description = readTrimmedString(input.description) ?? existing.description;
existing.childSessionId = readTrimmedString(input.childSessionId) ?? existing.childSessionId;
return existing;
} }
const first = this.firstChildren.get(toolCallId);
const item: OmpSubagentCardItem = { if (first && input.index > first.index) {
return;
}
const existing = first?.index === input.index ? first : undefined;
const next: OmpSubagentCardChild = {
index: input.index, index: input.index,
lines: [], description: readTrimmedString(input.description) ?? existing?.description,
lineKeys: new Set<string>(), childSessionId: readTrimmedString(input.childSessionId) ?? existing?.childSessionId,
...(readTrimmedString(input.agent) ? { agent: readTrimmedString(input.agent) } : {}),
...(input.status ? { status: input.status } : {}),
...(readTrimmedString(input.description)
? { description: readTrimmedString(input.description) }
: {}),
...(readTrimmedString(input.childSessionId)
? { childSessionId: readTrimmedString(input.childSessionId) }
: {}),
}; };
state.items.set(input.index, item); if (
return item; existing &&
} existing.description === next.description &&
existing.childSessionId === next.childSessionId
private stateFor(parentToolCallId: string): OmpSubagentCardState { ) {
const existing = this.states.get(parentToolCallId);
if (existing) {
return existing;
}
const state: OmpSubagentCardState = {
items: new Map(),
emitToolCall: this.emitToolCall,
lastEmitMs: null,
trailingTimer: null,
dirty: false,
};
this.states.set(parentToolCallId, state);
return state;
}
private appendLine(item: OmpSubagentCardItem, key: string, text: string): void {
const normalizedText = normalizeLine(text);
if (!normalizedText || item.lineKeys.has(key)) {
return; return;
} }
item.lines.push({ key, text: normalizedText }); this.firstChildren.set(toolCallId, next);
item.lineKeys.add(key); emitToolCall(toolCallId);
while (item.lines.length > MAX_LOG_LINES_PER_ITEM) {
const removed = item.lines.shift();
if (removed) {
item.lineKeys.delete(removed.key);
}
}
} }
private requestEmit(toolCallId: string): void {
const state = this.stateFor(toolCallId);
const now = this.scheduler.now();
const elapsedMs = state.lastEmitMs === null ? THROTTLE_INTERVAL_MS : now - state.lastEmitMs;
if (elapsedMs >= THROTTLE_INTERVAL_MS) {
this.emitNow(toolCallId, state);
return;
}
state.dirty = true;
if (state.trailingTimer) {
return;
}
state.trailingTimer = this.scheduler.setTimeout(() => {
state.trailingTimer = null;
if (state.dirty) {
this.emitNow(toolCallId, state);
}
}, THROTTLE_INTERVAL_MS - elapsedMs);
}
private emitNow(toolCallId: string, state: OmpSubagentCardState): void {
if (state.trailingTimer) {
this.scheduler.clearTimeout(state.trailingTimer);
state.trailingTimer = null;
}
state.dirty = false;
state.lastEmitMs = this.scheduler.now();
state.emitToolCall(toolCallId);
}
}
function buildLog(items: OmpSubagentCardItem[], fallback: string): string {
const itemCount = Math.max(...items.map((item) => item.index)) + 1;
const lines = items.flatMap((item) => {
const prefix = itemCount > 1 ? `[${item.index + 1}/${itemCount}] ` : "";
return item.lines.map((line) => `${prefix}${line.text}`);
});
return lines.length > 0 ? lines.join("\n") : fallback;
}
function summarizeTool(tool: Record<string, unknown> | null): OmpSubagentLogLine | null {
if (!tool) {
return null;
}
const toolName = readTrimmedString(tool.tool) ?? readTrimmedString(tool.name);
if (!toolName) {
return null;
}
const args = readTrimmedString(tool.args) ?? summarizeUnknown(tool.input);
const endMs = typeof tool.endMs === "number" ? `:${tool.endMs}` : "";
return {
key: `${toolName}:${args ?? ""}${endMs}`,
text: args ? `[${toolName}] ${args}` : `[${toolName}]`,
};
}
function readOutputLines(value: unknown): string[] {
if (!Array.isArray(value)) {
return [];
}
return value.flatMap((item) => {
const text =
readTrimmedString(item) ??
(isRecord(item)
? (readTrimmedString(item.text) ??
readTrimmedString(item.output) ??
readTrimmedString(item.content))
: undefined);
return text ? [text] : [];
});
}
function readRecord(value: unknown): Record<string, unknown> | null {
return isRecord(value) ? value : null;
}
function readRecordArray(value: unknown): Record<string, unknown>[] {
return Array.isArray(value) ? value.filter(isRecord) : [];
}
function summarizeUnknown(value: unknown): string | undefined {
if (value === undefined || value === null) {
return undefined;
}
if (typeof value === "string") {
return readTrimmedString(value);
}
const json = JSON.stringify(value);
return typeof json === "string" ? normalizeLine(json) : undefined;
}
function normalizeLine(value: string): string | undefined {
const normalized = value.trim().replace(/\s+/g, " ");
if (!normalized) {
return undefined;
}
if (normalized.length <= MAX_LOG_LINE_CHARS) {
return normalized;
}
return `${normalized.slice(0, MAX_LOG_LINE_CHARS)}...`;
} }
function readTrimmedString(value: unknown): string | undefined { function readTrimmedString(value: unknown): string | undefined {
return typeof value === "string" && value.trim().length > 0 ? value.trim() : undefined; return typeof value === "string" && value.trim().length > 0 ? value.trim() : undefined;
} }
function isRecord(value: unknown): value is Record<string, unknown> {
return typeof value === "object" && value !== null && !Array.isArray(value);
}
@@ -85,7 +85,7 @@ describe("OMP tool call mapper", () => {
expect(mapOmpToolDetail(parseToolArgs("todo", { op: "view" }), null)).toBeNull(); expect(mapOmpToolDetail(parseToolArgs("todo", { op: "view" }), null)).toBeNull();
}); });
test("uses task result text and transcript path as the best static replay detail", () => { test("takes the child session from the task transcript path", () => {
expect( expect(
mapOmpToolDetail( mapOmpToolDetail(
parseToolArgs("task", { parseToolArgs("task", {
@@ -106,7 +106,7 @@ describe("OMP tool call mapper", () => {
subAgentType: "explore", subAgentType: "explore",
description: "Inspect the target files", description: "Inspect the target files",
childSessionId: "/tmp/omp-task-static/Explore.jsonl", childSessionId: "/tmp/omp-task-static/Explore.jsonl",
log: "done\ntranscript: /tmp/omp-task-static/Explore.jsonl", log: "",
}); });
}); });
@@ -179,7 +179,6 @@ const OPAQUE_TEXT_TOOLS = new Set([
function mapOmpTaskDetail(args: unknown, result: OmpToolResult): ToolCallDetail { function mapOmpTaskDetail(args: unknown, result: OmpToolResult): ToolCallDetail {
const argRecord = isRecord(args) ? args : {}; const argRecord = isRecord(args) ? args : {};
const firstTask = Array.isArray(argRecord.tasks) ? argRecord.tasks.find(isRecord) : undefined; const firstTask = Array.isArray(argRecord.tasks) ? argRecord.tasks.find(isRecord) : undefined;
const resultText = extractTextFromToolResult(result);
const childSessionId = readChildSessionId(result); const childSessionId = readChildSessionId(result);
return { return {
type: "sub_agent", type: "sub_agent",
@@ -200,7 +199,8 @@ function mapOmpTaskDetail(args: unknown, result: OmpToolResult): ToolCallDetail
argRecord.assignment, argRecord.assignment,
), ),
...(childSessionId ? { childSessionId } : {}), ...(childSessionId ? { childSessionId } : {}),
log: resultText?.trim() ?? "", // COMPAT(subagent-log): remove after 2027-04-30.
log: "",
}; };
} }
@@ -4846,15 +4846,6 @@ class OpenCodeAgentSession implements AgentSession {
...item, ...item,
status: "failed", status: "failed",
error, error,
detail:
item.detail.type === "sub_agent"
? {
...item.detail,
log: [item.detail.log, error.message]
.filter((entry) => entry.trim().length > 0)
.join("\n"),
}
: item.detail,
}, },
}, },
turnId, turnId,
@@ -153,21 +153,6 @@ const OpencodeGrepOutputSchema = z
]) ])
.nullable(); .nullable();
function formatLogEntry(value: unknown): string | undefined {
const outputText = readOutputText(value);
if (outputText) {
return outputText;
}
if (value === null || value === undefined) {
return undefined;
}
try {
return JSON.stringify(value, null, 2);
} catch {
return String(value);
}
}
function extractOpenCodeTaskSessionId(value: unknown): string | undefined { function extractOpenCodeTaskSessionId(value: unknown): string | undefined {
const text = readOutputText(value); const text = readOutputText(value);
if (text) { if (text) {
@@ -195,7 +180,6 @@ function extractOpenCodeTaskSessionId(value: unknown): string | undefined {
function deriveOpencodeTaskDetail( function deriveOpencodeTaskDetail(
input: unknown, input: unknown,
output: unknown, output: unknown,
error: unknown,
metadata: Record<string, unknown> | undefined, metadata: Record<string, unknown> | undefined,
): ToolCallDetail | null { ): ToolCallDetail | null {
if (!isRecord(input)) { if (!isRecord(input)) {
@@ -208,7 +192,6 @@ function deriveOpencodeTaskDetail(
return null; return null;
} }
const log = [formatLogEntry(output), formatLogEntry(error)].filter((entry) => entry).join("\n");
const childSessionId = const childSessionId =
normalizeSubAgentText(metadata?.sessionId) ?? extractOpenCodeTaskSessionId(output); normalizeSubAgentText(metadata?.sessionId) ?? extractOpenCodeTaskSessionId(output);
return { return {
@@ -216,7 +199,8 @@ function deriveOpencodeTaskDetail(
...(subAgentType ? { subAgentType } : {}), ...(subAgentType ? { subAgentType } : {}),
...(description ? { description } : {}), ...(description ? { description } : {}),
...(childSessionId ? { childSessionId } : {}), ...(childSessionId ? { childSessionId } : {}),
log, // COMPAT(subagent-log): remove after 2027-04-30.
log: "",
actions: [], actions: [],
}; };
} }
@@ -373,11 +357,10 @@ export function deriveOpencodeToolDetail(
toolName: string, toolName: string,
input: unknown, input: unknown,
output: unknown, output: unknown,
error: unknown = null,
metadata?: Record<string, unknown>, metadata?: Record<string, unknown>,
): ToolCallDetail { ): ToolCallDetail {
if (toolName.trim().toLowerCase() === "task") { if (toolName.trim().toLowerCase() === "task") {
const taskDetail = deriveOpencodeTaskDetail(input, output, error, metadata); const taskDetail = deriveOpencodeTaskDetail(input, output, metadata);
if (taskDetail) { if (taskDetail) {
return taskDetail; return taskDetail;
} }
@@ -460,7 +460,7 @@ describe("opencode tool-call mapper", () => {
}); });
}); });
it("maps completed task calls with final output log to sub_agent detail", () => { it("maps completed task calls to sub_agent detail", () => {
const item = expectMapped( const item = expectMapped(
mapOpencodeToolCall({ mapOpencodeToolCall({
toolName: "task", toolName: "task",
@@ -480,7 +480,7 @@ describe("opencode tool-call mapper", () => {
type: "sub_agent", type: "sub_agent",
subAgentType: "explore", subAgentType: "explore",
description: "Explore agent-tools codebase", description: "Explore agent-tools codebase",
log: "Found the CLI entrypoint and provider registry.", log: "",
actions: [], actions: [],
}); });
}); });
@@ -505,12 +505,12 @@ describe("opencode tool-call mapper", () => {
subAgentType: "explore", subAgentType: "explore",
description: "Explore current directory", description: "Explore current directory",
childSessionId: "ses_2268db431ffe299vL1bbot8R7Z", childSessionId: "ses_2268db431ffe299vL1bbot8R7Z",
log: '<task id="ses_2268db431ffe299vL1bbot8R7Z">done</task>', log: "",
actions: [], actions: [],
}); });
}); });
it("maps aborted task calls with preserved error log to sub_agent detail", () => { it("maps aborted task calls to sub_agent detail", () => {
const item = expectMapped( const item = expectMapped(
mapOpencodeToolCall({ mapOpencodeToolCall({
toolName: "task", toolName: "task",
@@ -531,7 +531,7 @@ describe("opencode tool-call mapper", () => {
type: "sub_agent", type: "sub_agent",
subAgentType: "explore", subAgentType: "explore",
description: "Explore agent-tools codebase", description: "Explore agent-tools codebase",
log: "Tool execution aborted", log: "",
actions: [], actions: [],
}); });
}); });
@@ -43,7 +43,7 @@ export function mapOpencodeToolCall(params: OpencodeToolCallParams): ToolCallTim
const error = raw.error ?? null; const error = raw.error ?? null;
const rawStatus = typeof raw.status === "string" ? raw.status : undefined; const rawStatus = typeof raw.status === "string" ? raw.status : undefined;
const status = normalizeToolCallStatus(rawStatus, error, output); const status = normalizeToolCallStatus(rawStatus, error, output);
const detail = deriveOpencodeToolDetail(name, input, output, error, raw.metadata); const detail = deriveOpencodeToolDetail(name, input, output, raw.metadata);
if (status === "failed") { if (status === "failed") {
return { return {
@@ -3643,114 +3643,3 @@ test("closing Pi during image conversion rejects its pending start", async () =>
await session.close(); await session.close();
await rejected; await rejected;
}); });
describe("Pi tool-result images", () => {
test.each([false, true])(
"tool-result images precede the reply and completion (isError=%s)",
async (isError) => {
const { pi, session, events } = await createSession();
onTestFinished(() => session.close());
const fakeSession = pi.latestSession();
await session.startTurn("run");
fakeSession.emit({
type: "tool_execution_start",
toolCallId: "shot-1",
toolName: "screenshot",
args: {},
});
fakeSession.emit({
type: "tool_execution_end",
toolCallId: "shot-1",
toolName: "screenshot",
result: {
content: [
{ type: "text", text: "captured" },
{ type: "image", data: Buffer.from("hello").toString("base64"), mimeType: "image/png" },
],
structuredContent: {
type: "image",
data: Buffer.from("hello").toString("base64"),
mimeType: "image/png",
note: "captured",
},
},
isError,
});
fakeSession.emit({
type: "message_update",
assistantMessageEvent: { type: "text_delta", delta: "Image read complete." },
});
fakeSession.finishTurn();
await events.nextTurnCompletion();
const items = events.timelineItems();
const toolIndex = items.findIndex(
(item) =>
item.type === "tool_call" &&
item.callId === "shot-1" &&
item.status === (isError ? "failed" : "completed"),
);
expect(toolIndex).toBeGreaterThanOrEqual(0);
// Base64 must never reach the tool output stringifier.
expect(JSON.stringify(items[toolIndex])).not.toContain(
Buffer.from("hello").toString("base64"),
);
expect(items.slice(toolIndex + 1)).toEqual([
expect.objectContaining({
type: "assistant_message",
text: expect.stringContaining("![Image]("),
}),
expect.objectContaining({ type: "assistant_message", text: "Image read complete." }),
]);
expect(events.timelineAndCompletionEvents().at(-1)).toEqual({ type: "turn_completed" });
},
);
});
test("Pi image rendering preserves turn ownership across an interrupt and follow-up", async () => {
const { pi, session, events } = await createSession();
onTestFinished(() => session.close());
const emitted: AgentStreamEvent[] = [];
session.subscribe((event) => emitted.push(event));
const native = pi.latestSession();
const first = await session.startTurn("read image");
native.emit({
type: "tool_execution_end",
toolCallId: "large-image",
toolName: "screenshot",
result: {
content: [
{
type: "image",
data: Buffer.alloc(8 * 1024 * 1024, 73).toString("base64"),
mimeType: "image/png",
},
],
},
isError: false,
});
native.finishTurn();
await session.interrupt();
const followup = await session.startTurn("follow-up after image");
await waitForImmediate();
await waitForImmediate();
await expect
.poll(() =>
events
.timelineItems()
.some((item) => item.type === "assistant_message" && item.text.includes("![Image](")),
)
.toBe(true);
expect(events.turnCompletedEvents().some((event) => event.turnId === followup.turnId)).toBe(
false,
);
const imageEvent = emitted.find(
(event) =>
event.type === "timeline" &&
event.item.type === "assistant_message" &&
event.item.text.includes("![Image]("),
);
expect(imageEvent).toMatchObject({ turnId: first.turnId });
native.finishTurn();
await events.nextTurnCompletion();
});
@@ -64,11 +64,7 @@ import {
streamPiHistory, streamPiHistory,
type PiCapturedUserMessageEntry, type PiCapturedUserMessageEntry,
} from "./history-mapper.js"; } from "./history-mapper.js";
import { import { materializeProviderImage } from "../provider-image-output.js";
materializeProviderImage,
renderProviderImageOutputAsAssistantMarkdown,
type ProviderImageOutput,
} from "../provider-image-output.js";
import { PiCliRuntime } from "./cli-runtime.js"; import { PiCliRuntime } from "./cli-runtime.js";
import { import {
createPiExtensionHost, createPiExtensionHost,
@@ -93,7 +89,6 @@ import {
mapToolDetail, mapToolDetail,
parseToolArgs, parseToolArgs,
parseToolResult, parseToolResult,
splitPiToolResultImages,
type PiToolResult, type PiToolResult,
type PiTrackedToolCall, type PiTrackedToolCall,
} from "./tool-call-mapper.js"; } from "./tool-call-mapper.js";
@@ -1206,7 +1201,6 @@ export class PiRpcAgentSession implements AgentSession {
private closed = false; private closed = false;
private readonly closeController = new AbortController(); private readonly closeController = new AbortController();
private readonly pendingExtensionHydrations = new Set<Promise<void>>(); private readonly pendingExtensionHydrations = new Set<Promise<void>>();
private pendingOutput: Promise<void> | null = null;
// Pi publishes the terminal before acknowledging abort. Autonomous runs have no // Pi publishes the terminal before acknowledging abort. Autonomous runs have no
// turn ID; retain their errors too until the cancellation request settles. // turn ID; retain their errors too until the cancellation request settles.
private interruptingTurn: { turnId: string | undefined; error: string | null } | null = null; private interruptingTurn: { turnId: string | undefined; error: string | null } | null = null;
@@ -1608,7 +1602,6 @@ export class PiRpcAgentSession implements AgentSession {
this.pendingExtensionUiRequests.size || this.pendingExtensionUiRequests.size ||
this.pendingExtensionResults.size || this.pendingExtensionResults.size ||
this.pendingExtensionHydrations.size || this.pendingExtensionHydrations.size ||
this.pendingOutput ||
this.pendingSteerSubmissions.length || this.pendingSteerSubmissions.length ||
this.pendingNoTurnOutputs.length || this.pendingNoTurnOutputs.length ||
this.interruptingTurn this.interruptingTurn
@@ -1629,7 +1622,7 @@ export class PiRpcAgentSession implements AgentSession {
try { try {
await this.runtimeSession.close(); await this.runtimeSession.close();
} finally { } finally {
await Promise.all([this.pendingOutput, ...this.pendingExtensionHydrations]); await Promise.all(this.pendingExtensionHydrations);
this.rejectAllExtensionResults(new Error("Pi session closed")); this.rejectAllExtensionResults(new Error("Pi session closed"));
this.cleanup?.(); this.cleanup?.();
} }
@@ -1693,31 +1686,9 @@ export class PiRpcAgentSession implements AgentSession {
} }
private emit(event: AgentStreamEvent): void { private emit(event: AgentStreamEvent): void {
if (this.pendingOutput) { for (const subscriber of this.subscribers) {
this.emitAsync(() => Promise.resolve([event])); subscriber(event);
return;
} }
this.publish(event);
}
private publish(event: AgentStreamEvent): void {
for (const subscriber of this.subscribers) subscriber(event);
}
// Keep timeline order while images are materialized, without delaying provider state changes.
private emitAsync(render: () => Promise<AgentStreamEvent[]>): void {
const pending = (this.pendingOutput ?? Promise.resolve())
.then(render)
.then((events) => {
if (!this.closed) for (const event of events) this.publish(event);
return undefined;
})
.catch((error) => this.logger.error({ err: error }, "Pi output rendering failed"));
this.pendingOutput = pending;
void pending.then(() => {
if (this.pendingOutput === pending) this.pendingOutput = null;
return undefined;
});
} }
private emitExtensionOutput(output: PiExtensionEventOutput | undefined, turnId?: string): void { private emitExtensionOutput(output: PiExtensionEventOutput | undefined, turnId?: string): void {
@@ -2344,11 +2315,8 @@ export class PiRpcAgentSession implements AgentSession {
this.activeToolCalls.get(event.toolCallId) ?? parseToolArgs(event.toolName, null); this.activeToolCalls.get(event.toolCallId) ?? parseToolArgs(event.toolName, null);
this.activeToolCalls.delete(event.toolCallId); this.activeToolCalls.delete(event.toolCallId);
// Pull image blocks out of the result so base64 never reaches the tool output, then render const result = parseToolResult(event.result);
// each one as an assistant_message markdown image after the tool_call (mirroring the Claude const error = event.isError ? event.result : null;
// provider, upstream #1717).
const { images, result } = splitPiToolResultImages(parseToolResult(event.result));
const error = event.isError ? result : null;
const status = event.isError ? "failed" : "completed"; const status = event.isError ? "failed" : "completed";
this.extensionHost.onToolEnd({ this.extensionHost.onToolEnd({
callId: event.toolCallId, callId: event.toolCallId,
@@ -2358,30 +2326,6 @@ export class PiRpcAgentSession implements AgentSession {
result, result,
}); });
this.emitToolCallEvent(event.toolCallId, toolCall, status, result, error); this.emitToolCallEvent(event.toolCallId, toolCall, status, result, error);
if (images.length === 0) return;
const turnId = this.currentTurnIdForEvent();
this.emitAsync(() => this.renderToolResultImages(images, turnId));
}
private async renderToolResultImages(
images: ProviderImageOutput[],
turnId: string | undefined,
): Promise<AgentStreamEvent[]> {
const events: AgentStreamEvent[] = [];
for (const image of images) {
const imageItem = await renderProviderImageOutputAsAssistantMarkdown(image, {
materialize: materializeProviderImage,
});
if (imageItem && !this.closed) {
events.push({
type: "timeline",
provider: this.provider,
turnId,
item: imageItem,
});
}
}
return events;
} }
private emitCompactionTimeline(input: { private emitCompactionTimeline(input: {
@@ -21,11 +21,11 @@ export function mapPiChildSession(
return new PiChildSessionFollower(id, file, maxBytes).readNew(); return new PiChildSessionFollower(id, file, maxBytes).readNew();
} }
async function mapChildLine( function mapChildLine(
mapper: PiHistoryMapper, mapper: PiHistoryMapper,
id: string, id: string,
line: string, line: string,
): Promise<ProviderSubagentInputEvent[]> { ): ProviderSubagentInputEvent[] {
let entry: { message?: PiAgentMessage; timestamp?: string }; let entry: { message?: PiAgentMessage; timestamp?: string };
try { try {
entry = JSON.parse(line); entry = JSON.parse(line);
@@ -33,7 +33,7 @@ async function mapChildLine(
return []; return [];
} }
if (!entry.message || typeof entry.message !== "object" || !("role" in entry.message)) return []; if (!entry.message || typeof entry.message !== "object" || !("role" in entry.message)) return [];
return (await mapper.mapMessages([entry.message])).flatMap((mapped) => return mapper.mapMessages([entry.message]).flatMap((mapped) =>
mapped.type === "timeline" mapped.type === "timeline"
? [ ? [
{ {
@@ -83,10 +83,7 @@ export class PiChildSessionFollower {
const events: ProviderSubagentInputEvent[] = []; const events: ProviderSubagentInputEvent[] = [];
for (const line of data.subarray(0, lastNewline).toString("utf8").split("\n")) { for (const line of data.subarray(0, lastNewline).toString("utf8").split("\n")) {
if (this.items >= MAX_ITEMS) break; if (this.items >= MAX_ITEMS) break;
const mapped = (await mapChildLine(this.mapper, this.id, line)).slice( const mapped = mapChildLine(this.mapper, this.id, line).slice(0, MAX_ITEMS - this.items);
0,
MAX_ITEMS - this.items,
);
this.items += mapped.length; this.items += mapped.length;
events.push(...mapped); events.push(...mapped);
} }
@@ -1,5 +1,4 @@
import { z } from "zod"; import { z } from "zod";
import { extractTextFromToolResult } from "../../tool-call-mapper.js";
import type { PiChildSessionFile, PiExtension } from "../contract.js"; import type { PiChildSessionFile, PiExtension } from "../contract.js";
import type { ProviderSubagentInputEvent } from "../../../../provider-subagents/store.js"; import type { ProviderSubagentInputEvent } from "../../../../provider-subagents/store.js";
@@ -99,7 +98,8 @@ export const edxethPiSubagents: PiExtension = {
detail: { detail: {
type: "sub_agent", type: "sub_agent",
description, description,
log: extractTextFromToolResult(call.result)?.trim() ?? "", // COMPAT(subagent-log): remove after 2027-04-30.
log: "",
}, },
subagents, subagents,
childSessions, childSessions,
@@ -130,6 +130,18 @@ describe("@gotgenes/pi-subagents adapter", () => {
.filter((event) => event.event.type === "upsert") .filter((event) => event.event.type === "upsert")
.map((event) => (event.event.type === "upsert" ? event.event.status : null)), .map((event) => (event.event.type === "upsert" ? event.event.status : null)),
).toEqual(["running", "completed"]); ).toEqual(["running", "completed"]);
expect(
events.flatMap((event) => (event.event.type === "timeline" ? [event.event] : [])),
).toEqual([
{
type: "timeline",
id: "call_502323",
item: {
type: "assistant_message",
text: "Agent completed in 4.7s (1 tool uses, 9.0k token).\nAgent ID: 848583f5-6749-4a1\n\nThe workspace is empty.",
},
},
]);
}); });
test("correlates a background notification and result collection", async () => { test("correlates a background notification and result collection", async () => {
const source = readSubagentFixture(new URL("./fixtures/background.json", import.meta.url)); const source = readSubagentFixture(new URL("./fixtures/background.json", import.meta.url));
@@ -64,7 +64,8 @@ export const gotgenesPiSubagents: PiExtension = {
type: "sub_agent" as const, type: "sub_agent" as const,
subAgentType: title, subAgentType: title,
description, description,
log: extractTextFromToolResult(call.result)?.trim() ?? "", // COMPAT(subagent-log): remove after 2027-04-30.
log: "",
}; };
if (call.status === "running") if (call.status === "running")
return { return {
@@ -92,6 +93,10 @@ export const gotgenesPiSubagents: PiExtension = {
outputFileFromToolResult(call.result) ?? pendingFilesByAgent.get(details.data.agentId); outputFileFromToolResult(call.result) ?? pendingFilesByAgent.get(details.data.agentId);
pendingFilesByAgent.delete(details.data.agentId); pendingFilesByAgent.delete(details.data.agentId);
const childSessions = childSession(call.callId, file); const childSessions = childSession(call.callId, file);
const childStatus = status(details.data.status);
// Without a session file, as on replay, the child's answer is the tool result.
const answer =
!file && childStatus !== "running" ? extractTextFromToolResult(call.result)?.trim() : "";
return { return {
detail, detail,
subagents: [ subagents: [
@@ -101,8 +106,17 @@ export const gotgenesPiSubagents: PiExtension = {
title, title,
description, description,
toolCallId: call.callId, toolCallId: call.callId,
status: status(details.data.status), status: childStatus,
}, },
...(answer
? [
{
type: "timeline" as const,
id: call.callId,
item: { type: "assistant_message" as const, text: answer },
},
]
: []),
], ],
childSessions, childSessions,
}; };
@@ -118,7 +132,8 @@ export const gotgenesPiSubagents: PiExtension = {
const detail = { const detail = {
type: "sub_agent" as const, type: "sub_agent" as const,
description: details.success ? details.data.description : undefined, description: details.success ? details.data.description : undefined,
log: extractTextFromToolResult(call.result)?.trim() ?? "", // COMPAT(subagent-log): remove after 2027-04-30.
log: "",
}; };
if (call.status === "running" || !details.success) return { detail }; if (call.status === "running" || !details.success) return { detail };
const file = details.data.transcriptPath; const file = details.data.transcriptPath;
@@ -83,7 +83,7 @@ describe("Pi extension host", () => {
test("declines a throwing adapter and preserves generic history", async () => { test("declines a throwing adapter and preserves generic history", async () => {
const host = createPiExtensionHost(undefined, [throwingAdapter]); const host = createPiExtensionHost(undefined, [throwingAdapter]);
const mapper = new PiHistoryMapper("pi", [], {}, host); const mapper = new PiHistoryMapper("pi", [], {}, host);
const events = await mapper.mapMessages([ const events = mapper.mapMessages([
{ {
role: "assistant", role: "assistant",
content: [{ type: "toolCall", id: "call-1", name: "other", arguments: {} }], content: [{ type: "toolCall", id: "call-1", name: "other", arguments: {} }],
@@ -193,7 +193,7 @@ describe("Pi extension host", () => {
await output?.hydration; await output?.hydration;
expect(reads).toHaveLength(8); expect(reads).toHaveLength(8);
}); });
test("claims a tool, declines an unrelated one, and maps history like live events", async () => { test("claims a tool, declines an unrelated one, and maps history like live events", () => {
const host = createPiExtensionHost(); const host = createPiExtensionHost();
const args = { agent: "scout", task: "Inspect files" }; const args = { agent: "scout", task: "Inspect files" };
const result = parseToolResult({ content: [{ type: "text", text: "Found two files" }] }); const result = parseToolResult({ content: [{ type: "text", text: "Found two files" }] });
@@ -210,7 +210,7 @@ describe("Pi extension host", () => {
type: "sub_agent", type: "sub_agent",
subAgentType: "scout", subAgentType: "scout",
description: "Inspect files", description: "Inspect files",
log: "Found two files", log: "",
}, },
}), }),
); );
@@ -225,7 +225,7 @@ describe("Pi extension host", () => {
).toBeUndefined(); ).toBeUndefined();
const mapper = new PiHistoryMapper("pi"); const mapper = new PiHistoryMapper("pi");
const events = await mapper.mapMessages([ const events = mapper.mapMessages([
{ {
role: "assistant", role: "assistant",
content: [{ type: "toolCall", id: "call-1", name: "subagent", arguments: args }], content: [{ type: "toolCall", id: "call-1", name: "subagent", arguments: args }],
@@ -137,7 +137,7 @@ describe("pi-subagents adapter", () => {
type: "sub_agent", type: "sub_agent",
subAgentType: "reviewer", subAgentType: "reviewer",
description: "Review the Pi mapper change", description: "Review the Pi mapper change",
log: "The mapper change preserves provider status.", log: "",
}); });
}); });
@@ -131,7 +131,8 @@ export const piSubagents: PiExtension = {
type: "sub_agent" as const, type: "sub_agent" as const,
subAgentType: args.data.agent, subAgentType: args.data.agent,
description: args.data.task, description: args.data.task,
log: extractTextFromToolResult(call.result)?.trim() ?? "", // COMPAT(subagent-log): remove after 2027-04-30.
log: "",
}; };
const base = { const base = {
type: "upsert" as const, type: "upsert" as const,
@@ -79,7 +79,7 @@ test("cancellation declines each remaining real RPC dialog", () => {
} }
}); });
test("captured result renders in live and history tool rows, while foreign shapes decline", async () => { test("captured result renders in live and history tool rows, while foreign shapes decline", () => {
const call = { const call = {
callId: end.toolCallId, callId: end.toolCallId,
toolName: end.toolName, toolName: end.toolName,
@@ -93,7 +93,7 @@ test("captured result renders in live and history tool rows, while foreign shape
label: "Questions", label: "Questions",
text: "Which snack?: Cookie\nWhich colors?: Red, Blue\nWhat project name?: Nebula", text: "Which snack?: Cookie\nWhich colors?: Red, Blue\nWhat project name?: Nebula",
}); });
const history = await new PiHistoryMapper("pi").mapMessages([ const history = new PiHistoryMapper("pi").mapMessages([
{ {
role: "assistant", role: "assistant",
content: [ content: [
@@ -54,8 +54,6 @@ export async function verifySubagentFixture(
try { try {
await session.startTurn("Delegate work"); await session.startTurn("Delegate work");
for (const event of fixture.events) pi.latestSession().emit(event); for (const event of fixture.events) pi.latestSession().emit(event);
const immediate = live.filter((event) => event.type === "provider_subagent");
expect(immediate.some((event) => event.event.type === "timeline")).toBe(false);
pi.latestSession().finishTurn(); pi.latestSession().finishTurn();
const replay: AgentStreamEvent[] = []; const replay: AgentStreamEvent[] = [];
for await (const event of streamPiHistory("pi", fixture.messages)) replay.push(event); for await (const event of streamPiHistory("pi", fixture.messages)) replay.push(event);
@@ -89,7 +89,7 @@ export async function verifyTaskFixture(path: URL, expectedStatuses: string[]):
for (const event of fixture.events) pi.latestSession().emit(event); for (const event of fixture.events) pi.latestSession().emit(event);
pi.latestSession().finishTurn(); pi.latestSession().finishTurn();
expect(todos(live)).toEqual(mapped); expect(todos(live)).toEqual(mapped);
const replay = await new PiHistoryMapper("pi").mapMessages(fixture.messages); const replay = new PiHistoryMapper("pi").mapMessages(fixture.messages);
expect(todos(replay)).toEqual(mapped); expect(todos(replay)).toEqual(mapped);
expect( expect(
replay.filter( replay.filter(
@@ -36,12 +36,17 @@ describe("@tintinweb/pi-subagents adapter", () => {
}); });
expect(mapping?.subagents).toEqual([ expect(mapping?.subagents).toEqual([
expect.objectContaining({ id: "call-1", status: "completed" }), expect.objectContaining({ id: "call-1", status: "completed" }),
{
type: "timeline",
id: "call-1",
item: { type: "assistant_message", text: "Wrapped up (turn limit)" },
},
]); ]);
expect(mapping?.detail).toEqual({ expect(mapping?.detail).toEqual({
type: "sub_agent", type: "sub_agent",
subAgentType: "Explore", subAgentType: "Explore",
description: "Inspect", description: "Inspect",
log: "Wrapped up (turn limit)", log: "",
}); });
}); });
test("maps captured foreground lifecycle live and on replay", async () => { test("maps captured foreground lifecycle live and on replay", async () => {
@@ -53,6 +58,18 @@ describe("@tintinweb/pi-subagents adapter", () => {
.filter((event) => event.event.type === "upsert") .filter((event) => event.event.type === "upsert")
.map((event) => (event.event.type === "upsert" ? event.event.status : null)), .map((event) => (event.event.type === "upsert" ? event.event.status : null)),
).toEqual(["running", "completed"]); ).toEqual(["running", "completed"]);
expect(
events.flatMap((event) => (event.event.type === "timeline" ? [event.event] : [])),
).toEqual([
{
type: "timeline",
id: "call_458926",
item: {
type: "assistant_message",
text: "Agent completed in 6.6s (1 tool uses, 18.8k token).\n\nThe workspace directory `/tmp/paseo-pi-extension-phase3/workspace` is empty (no files or hidden dotfiles).",
},
},
]);
}); });
test("uses a structured notification to complete a background child", async () => { test("uses a structured notification to complete a background child", async () => {
const source = readSubagentFixture(new URL("./fixtures/background.json", import.meta.url)); const source = readSubagentFixture(new URL("./fixtures/background.json", import.meta.url));
@@ -147,7 +164,7 @@ describe("@tintinweb/pi-subagents adapter", () => {
expect(mapping?.detail).toEqual({ expect(mapping?.detail).toEqual({
type: "sub_agent", type: "sub_agent",
description: undefined, description: undefined,
log: "Wrapped up (turn limit)", log: "",
}); });
}, },
); );
@@ -57,7 +57,8 @@ export const tintinwebPiSubagents: PiExtension = {
type: "sub_agent" as const, type: "sub_agent" as const,
subAgentType: title, subAgentType: title,
description, description,
log: extractTextFromToolResult(call.result)?.trim() ?? "", // COMPAT(subagent-log): remove after 2027-04-30.
log: "",
}; };
if (call.status === "running") if (call.status === "running")
return { return {
@@ -84,6 +85,10 @@ export const tintinwebPiSubagents: PiExtension = {
const file = outputFileFromToolResult(call.result); const file = outputFileFromToolResult(call.result);
const childSessions = file && !readSessions.has(file) ? [{ id: call.callId, file }] : []; const childSessions = file && !readSessions.has(file) ? [{ id: call.callId, file }] : [];
if (file) readSessions.add(file); if (file) readSessions.add(file);
const childStatus = status(details.data.status);
// A foreground child has no session file; its answer is the tool result.
const answer =
!file && childStatus !== "running" ? extractTextFromToolResult(call.result)?.trim() : "";
return { return {
detail, detail,
subagents: [ subagents: [
@@ -93,8 +98,17 @@ export const tintinwebPiSubagents: PiExtension = {
title, title,
description, description,
toolCallId: call.callId, toolCallId: call.callId,
status: status(details.data.status), status: childStatus,
}, },
...(answer
? [
{
type: "timeline" as const,
id: call.callId,
item: { type: "assistant_message" as const, text: answer },
},
]
: []),
], ],
childSessions, childSessions,
}; };
@@ -110,7 +124,8 @@ export const tintinwebPiSubagents: PiExtension = {
const detail = { const detail = {
type: "sub_agent" as const, type: "sub_agent" as const,
description: details.success ? details.data.description : undefined, description: details.success ? details.data.description : undefined,
log: extractTextFromToolResult(call.result)?.trim() ?? "", // COMPAT(subagent-log): remove after 2027-04-30.
log: "",
}; };
if (call.status === "running" || !details.success) return { detail }; if (call.status === "running" || !details.success) return { detail };
return { return {
@@ -221,75 +221,3 @@ describe("Pi history mapper", () => {
]); ]);
}); });
}); });
describe("Pi tool-result image replay", () => {
test("recreates an image from native tool-result history without its source file", async () => {
const events = await collectHistory([
{
role: "assistant",
content: [
{
type: "toolCall",
id: "image-read",
name: "read",
arguments: { path: "missing-preview.png" },
},
],
},
{
role: "toolResult",
toolCallId: "image-read",
toolName: "read",
content: [
{ type: "text", text: "Read image file [image/png]" },
{ type: "image", data: "aGVsbG8=", mimeType: "image/png" },
],
},
]);
expect(events.map((event) => event.item?.type)).toEqual([
"tool_call",
"tool_call",
"assistant_message",
]);
const image = events.find(
(event) => event.type === "timeline" && event.item.type === "assistant_message",
);
expect(image).toMatchObject({
type: "timeline",
item: { type: "assistant_message", text: expect.stringContaining("![Image](file://") },
});
if (image?.type !== "timeline" || image.item.type !== "assistant_message")
throw new Error("Missing image");
const url = image.item.text.match(/\((file:[^)]+)\)/)![1];
const { readFile, unlink } = await import("node:fs/promises");
expect(await readFile(new URL(url))).toEqual(Buffer.from("hello"));
await unlink(new URL(url));
const replay = await collectHistory([
{
role: "toolResult",
toolCallId: "image-read",
toolName: "read",
content: [{ type: "image", data: "aGVsbG8=", mimeType: "image/png" }],
},
]);
expect(replay).toContainEqual(image);
expect(await readFile(new URL(url))).toEqual(Buffer.from("hello"));
});
});
test("replayed Pi images keep their position before the following reply", async () => {
const events = await collectHistory([
{
role: "toolResult",
toolCallId: "image-position",
toolName: "read",
content: [{ type: "image", data: "aGVsbG8=", mimeType: "image/png" }],
},
{ role: "assistant", content: [{ type: "text", text: "Image read complete." }] },
]);
expect(
events.map((event) =>
event.item?.type === "assistant_message" ? event.item.text : event.item?.type,
),
).toEqual(["tool_call", expect.stringContaining("![Image]("), "Image read complete."]);
});
@@ -1,9 +1,5 @@
import { mapCustomMessageToToolCall } from "../custom-message.js"; import { mapCustomMessageToToolCall } from "../custom-message.js";
import type { AgentStreamEvent, AgentTimelineItem, ToolCallDetail } from "../../agent-sdk-types.js"; import type { AgentStreamEvent, AgentTimelineItem, ToolCallDetail } from "../../agent-sdk-types.js";
import {
materializeProviderImage,
renderProviderImageOutputAsAssistantMarkdown,
} from "../provider-image-output.js";
import { import {
createPiExtensionHost, createPiExtensionHost,
type PiExtensionEventOutput, type PiExtensionEventOutput,
@@ -15,7 +11,6 @@ import {
mapToolDetail, mapToolDetail,
parseToolArgs, parseToolArgs,
parseToolResult, parseToolResult,
splitPiToolResultImages,
type PiToolResult, type PiToolResult,
type PiTrackedToolCall, type PiTrackedToolCall,
} from "./tool-call-mapper.js"; } from "./tool-call-mapper.js";
@@ -76,7 +71,7 @@ export class PiHistoryMapper {
private readonly extensionHost: PiExtensionHost = createPiExtensionHost(), private readonly extensionHost: PiExtensionHost = createPiExtensionHost(),
) {} ) {}
async mapMessages(messages: readonly PiAgentMessage[]): Promise<AgentStreamEvent[]> { mapMessages(messages: readonly PiAgentMessage[]): AgentStreamEvent[] {
const events: AgentStreamEvent[] = []; const events: AgentStreamEvent[] = [];
for (const message of messages) { for (const message of messages) {
@@ -91,7 +86,7 @@ export class PiHistoryMapper {
events.push(...this.mapAssistantMessage(message)); events.push(...this.mapAssistantMessage(message));
break; break;
case "toolResult": { case "toolResult": {
events.push(...(await this.mapToolResultMessage(message))); events.push(...this.mapToolResultMessage(message));
break; break;
} }
case "bashExecution": case "bashExecution":
@@ -212,35 +207,24 @@ export class PiHistoryMapper {
return events; return events;
} }
private async mapToolResultMessage( private mapToolResultMessage(
message: Extract<PiAgentMessage, { role: "toolResult" }>, message: Extract<PiAgentMessage, { role: "toolResult" }>,
): Promise<AgentStreamEvent[]> { ): AgentStreamEvent[] {
const tracked = const tracked =
this.pendingToolCalls.get(message.toolCallId) ?? parseToolArgs(message.toolName, null); this.pendingToolCalls.get(message.toolCallId) ?? parseToolArgs(message.toolName, null);
this.pendingToolCalls.delete(message.toolCallId); this.pendingToolCalls.delete(message.toolCallId);
const result = parseToolResult({ content: message.content, details: message.details }); const result = parseToolResult({ content: message.content, details: message.details });
// Pull image blocks out of the result so base64 never reaches the tool output, then render
// each one as an assistant_message markdown image after the tool_call (mirroring the live
// path and the Claude provider, upstream #1717).
const { images, result: splitResult } = splitPiToolResultImages(result);
const mapping = this.extensionHost.mapToolCall({ const mapping = this.extensionHost.mapToolCall({
callId: message.toolCallId, callId: message.toolCallId,
toolName: tracked.toolName, toolName: tracked.toolName,
args: tracked.args, args: tracked.args,
status: message.isError ? "failed" : "completed", status: message.isError ? "failed" : "completed",
result: splitResult, result,
}); });
const detail = this.mapToolDetail(message.toolCallId, tracked, splitResult, mapping?.detail); const detail = this.mapToolDetail(message.toolCallId, tracked, result, mapping?.detail);
if (!detail) { if (!detail) {
return []; return [];
} }
const imageEvents: AgentStreamEvent[] = [];
for (const image of images) {
const item = await renderProviderImageOutputAsAssistantMarkdown(image, {
materialize: materializeProviderImage,
});
if (item) imageEvents.push({ type: "timeline", provider: this.provider, item });
}
return [ return [
{ {
type: "timeline", type: "timeline",
@@ -250,10 +234,9 @@ export class PiHistoryMapper {
name: mapping?.name ?? tracked.toolName, name: mapping?.name ?? tracked.toolName,
isError: Boolean(message.isError), isError: Boolean(message.isError),
detail, detail,
errorText: extractTextFromToolResult(splitResult) ?? "Tool call failed", errorText: extractTextFromToolResult(result) ?? "Tool call failed",
}), }),
}, },
...imageEvents,
...this.extensionEvents(mapping), ...this.extensionEvents(mapping),
]; ];
} }
@@ -314,10 +297,9 @@ export async function* streamPiHistory(
signal?: AbortSignal, signal?: AbortSignal,
): AsyncGenerator<AgentStreamEvent> { ): AsyncGenerator<AgentStreamEvent> {
const mapper = new PiHistoryMapper(provider, userEntries, hooks, extensionHost); const mapper = new PiHistoryMapper(provider, userEntries, hooks, extensionHost);
for (const message of messages) { for (const event of mapper.mapMessages(messages)) {
if (signal?.aborted) return; if (signal?.aborted) return;
for (const event of await mapper.mapMessages([message])) { if (event) {
if (signal?.aborted) return;
yield event; yield event;
} }
} }
@@ -1,12 +1,6 @@
import { describe, expect, test } from "vitest"; import { describe, expect, test } from "vitest";
import { import { mapToolDetail, parseToolArgs, parseToolResult } from "./tool-call-mapper.js";
extractTextFromToolResult,
mapToolDetail,
parseToolArgs,
parseToolResult,
splitPiToolResultImages,
} from "./tool-call-mapper.js";
describe("Pi tool call mapper", () => { describe("Pi tool call mapper", () => {
test("maps bash args and result to shell detail", () => { test("maps bash args and result to shell detail", () => {
@@ -62,77 +56,3 @@ describe("Pi tool call mapper", () => {
}); });
}); });
}); });
describe("splitPiToolResultImages", () => {
test("extracts image blocks and replaces them with [image] placeholders", () => {
const parsed = parseToolResult({
content: [
{ type: "text", text: "shot taken" },
{ type: "image", data: "aGVsbG8=", mimeType: "image/png" },
],
});
const { images, result } = splitPiToolResultImages(parsed);
expect(images).toEqual([{ data: "aGVsbG8=", mimeType: "image/png" }]);
expect(result).toEqual({
content: [
{ type: "text", text: "shot taken" },
{ type: "text", text: "[image]" },
],
});
});
test("replaces image-only results with a non-empty placeholder", () => {
const parsed = parseToolResult({
content: [{ type: "image", data: "aGVsbG8=", mimeType: "image/jpeg" }],
});
const { images, result } = splitPiToolResultImages(parsed);
expect(images).toHaveLength(1);
expect(extractTextFromToolResult(result)).toBe("[image]");
});
test("passes through string results and results without images", () => {
expect(splitPiToolResultImages("plain output")).toEqual({
images: [],
result: "plain output",
});
const textOnly = parseToolResult({ content: [{ type: "text", text: "no images" }] });
expect(splitPiToolResultImages(textOnly)).toEqual({ images: [], result: textOnly });
expect(splitPiToolResultImages(null)).toEqual({ images: [], result: null });
});
test("keeps other fields on the result object", () => {
const parsed = parseToolResult({
exitCode: 0,
content: [{ type: "image", data: "aGVsbG8=" }],
});
const { result } = splitPiToolResultImages(parsed);
expect(result).toMatchObject({ exitCode: 0 });
});
});
test("tool-result images remove nested structured image data while preserving metadata", () => {
const data = Buffer.from("nested screenshot bytes").toString("base64");
const result = parseToolResult({
content: [{ type: "image", data, mimeType: "image/png" }],
structuredContent: {
content: [{ type: "image", data, mimeType: "image/png", width: 64 }],
captureId: "capture-1",
read: { type: "image", data, mimeType: "image/png", note: "Read image file" },
extra: { data: "keep ordinary data" },
},
});
const split = splitPiToolResultImages(result);
const detail = mapToolDetail(parseToolArgs("screenshot", {}), split.result);
expect(JSON.stringify(detail)).not.toContain(data);
expect(split.images).toEqual([{ data, mimeType: "image/png" }]);
expect(split.result).toMatchObject({
structuredContent: {
content: [{ type: "image", data: "[image]", mimeType: "image/png", width: 64 }],
captureId: "capture-1",
read: { type: "image", data: "[image]", mimeType: "image/png", note: "Read image file" },
extra: { data: "keep ordinary data" },
},
});
});
@@ -1,7 +1,6 @@
import { z } from "zod"; import { z } from "zod";
import type { ToolCallDetail } from "../../agent-sdk-types.js"; import type { ToolCallDetail } from "../../agent-sdk-types.js";
import type { ProviderImageOutput } from "../provider-image-output.js";
interface BashToolInput { interface BashToolInput {
command: string; command: string;
@@ -53,7 +52,6 @@ interface PiToolResultObject {
stdout?: string; stdout?: string;
text?: string; text?: string;
content?: PiToolResultContent[]; content?: PiToolResultContent[];
structuredContent?: unknown;
exitCode?: number; exitCode?: number;
code?: number; code?: number;
details?: PiToolResultDetails; details?: PiToolResultDetails;
@@ -69,12 +67,6 @@ interface PiToolResultTextContent {
text: string; text: string;
} }
const PiToolResultImageContentSchema = z.object({
type: z.literal("image"),
data: z.string().min(1),
mimeType: z.string().optional(),
});
interface PiToolResultUnknownContent { interface PiToolResultUnknownContent {
type: string; type: string;
} }
@@ -244,61 +236,6 @@ export function parseToolResult(rawResult: unknown): PiToolResult {
return null; return null;
} }
// Pi returns images inside tool-result content as base64 blocks. Left in place they reach the
// tool-output stringifier, which dumps base64 into the tool output. We pull those blocks out to
// render them as image markdown and leave a "[image]" placeholder so image-only results still
// produce non-empty output (mirroring splitClaudeToolResultImages).
export function splitPiToolResultImages(result: PiToolResult): {
images: ProviderImageOutput[];
result: PiToolResult;
} {
if (!result || typeof result === "string" || !result.content) {
return { images: [], result };
}
const images: ProviderImageOutput[] = [];
let replaced = false;
const content = result.content.map((block) => {
const image = toPiImageOutput(block);
if (image) {
images.push(image);
replaced = true;
return { type: "text", text: "[image]" } satisfies PiToolResultTextContent;
}
return block;
});
if (!replaced) {
return { images: [], result };
}
return {
images,
result: {
...result,
content,
...(result.structuredContent === undefined
? {}
: { structuredContent: withoutImageData(result.structuredContent) }),
},
};
}
function withoutImageData(value: unknown): unknown {
if (Array.isArray(value)) return value.map(withoutImageData);
if (value === null || typeof value !== "object") return value;
const image = toPiImageOutput(value);
return Object.fromEntries(
Object.entries(value).map(([key, child]) => [
key,
image && key === "data" ? "[image]" : withoutImageData(child),
]),
);
}
function toPiImageOutput(block: unknown): ProviderImageOutput | null {
const parsed = PiToolResultImageContentSchema.safeParse(block);
if (!parsed.success) return null;
return { data: parsed.data.data, mimeType: parsed.data.mimeType ?? null };
}
export function extractTextFromToolResult(result: PiToolResult): string | undefined { export function extractTextFromToolResult(result: PiToolResult): string | undefined {
if (typeof result === "string") { if (typeof result === "string") {
return result; return result;
-2
View File
@@ -420,7 +420,6 @@ export interface PaseoDaemonConfig {
trustedProxies?: true | string[]; trustedProxies?: true | string[];
mcpEnabled?: boolean; mcpEnabled?: boolean;
mcpInjectIntoAgents?: boolean; mcpInjectIntoAgents?: boolean;
usageEnabled?: boolean;
browserToolsEnabled?: boolean; browserToolsEnabled?: boolean;
git?: { git?: {
maxProcessesPerSecond: number; maxProcessesPerSecond: number;
@@ -591,7 +590,6 @@ function createInitialMutableDaemonConfig(config: ResolvedDaemonSettings): Mutab
...(config.providerCatalogRefreshTimeoutMs !== undefined ...(config.providerCatalogRefreshTimeoutMs !== undefined
? { catalogRefreshTimeoutMs: config.providerCatalogRefreshTimeoutMs } ? { catalogRefreshTimeoutMs: config.providerCatalogRefreshTimeoutMs }
: {}), : {}),
usage: { enabled: config.usageEnabled !== false },
browserTools: { enabled: config.browserToolsEnabled ?? false }, browserTools: { enabled: config.browserToolsEnabled ?? false },
providers, providers,
metadataGeneration: { metadataGeneration: {
-6
View File
@@ -523,10 +523,6 @@ function resolveAppendSystemPrompt(persisted: ReturnType<typeof loadPersistedCon
return persisted.daemon?.appendSystemPrompt ?? ""; return persisted.daemon?.appendSystemPrompt ?? "";
} }
function resolveUsageEnabled(persisted: ReturnType<typeof loadPersistedConfig>): boolean {
return persisted.daemon?.usage?.enabled !== false;
}
function resolveBrowserToolsEnabled(persisted: ReturnType<typeof loadPersistedConfig>): boolean { function resolveBrowserToolsEnabled(persisted: ReturnType<typeof loadPersistedConfig>): boolean {
return persisted.daemon?.browserTools?.enabled ?? false; return persisted.daemon?.browserTools?.enabled ?? false;
} }
@@ -552,7 +548,6 @@ function resolveStaticLoadConfigSettings(
mcpEnabled: cli?.mcpEnabled ?? persisted.daemon?.mcp?.enabled ?? true, mcpEnabled: cli?.mcpEnabled ?? persisted.daemon?.mcp?.enabled ?? true,
mcpInjectIntoAgents: mcpInjectIntoAgents:
cli?.mcpInjectIntoAgents ?? persisted.daemon?.mcp?.injectIntoAgents ?? false, cli?.mcpInjectIntoAgents ?? persisted.daemon?.mcp?.injectIntoAgents ?? false,
usageEnabled: resolveUsageEnabled(persisted),
browserToolsEnabled: resolveBrowserToolsEnabled(persisted), browserToolsEnabled: resolveBrowserToolsEnabled(persisted),
autoArchiveAfterMerge: persisted.daemon?.autoArchiveAfterMerge ?? false, autoArchiveAfterMerge: persisted.daemon?.autoArchiveAfterMerge ?? false,
appendSystemPrompt: resolveAppendSystemPrompt(persisted), appendSystemPrompt: resolveAppendSystemPrompt(persisted),
@@ -581,7 +576,6 @@ export type ResolvedDaemonSettings = Pick<
| "trustedProxies" | "trustedProxies"
| "mcpEnabled" | "mcpEnabled"
| "mcpInjectIntoAgents" | "mcpInjectIntoAgents"
| "usageEnabled"
| "browserToolsEnabled" | "browserToolsEnabled"
| "git" | "git"
| "autoArchiveAfterMerge" | "autoArchiveAfterMerge"
@@ -21,7 +21,6 @@ import {
type HostUpdate, type HostUpdate,
} from "@getpaseo/protocol/hosts"; } from "@getpaseo/protocol/hosts";
import type { DaemonPermission, WSHelloMessage } from "@getpaseo/protocol/messages"; import type { DaemonPermission, WSHelloMessage } from "@getpaseo/protocol/messages";
import { webSocketProxyAgent } from "../network/index.js";
export class HostError extends Error { export class HostError extends Error {
constructor( constructor(
@@ -243,7 +242,6 @@ export class ConnectedHosts {
{ {
clientId: `host-link-${this.self.serverId}-${row.registrationId}`, clientId: `host-link-${this.self.serverId}-${row.registrationId}`,
connectTimeoutMs: 10000, connectTimeoutMs: 10000,
webSocketAgent: webSocketProxyAgent,
}, },
this.budget, this.budget,
); );
@@ -10,10 +10,6 @@ import { readSpeechSettings } from "./speech/speech-settings.js";
import type { PersistedConfig } from "./persisted-config.js"; import type { PersistedConfig } from "./persisted-config.js";
import type { MutableDaemonConfig } from "@getpaseo/protocol/messages"; import type { MutableDaemonConfig } from "@getpaseo/protocol/messages";
function usageEnabled(persisted: PersistedConfig): boolean {
return persisted.daemon?.usage?.enabled !== false;
}
function reloadableConfig( function reloadableConfig(
persisted: PersistedConfig, persisted: PersistedConfig,
options: { relayEnabledFallback?: boolean } = {}, options: { relayEnabledFallback?: boolean } = {},
@@ -27,7 +23,6 @@ function reloadableConfig(
enabled: relay.enabled ?? options.relayEnabledFallback ?? true, enabled: relay.enabled ?? options.relayEnabledFallback ?? true,
}, },
mcp: { enabled: true, injectIntoAgents: false }, mcp: { enabled: true, injectIntoAgents: false },
usage: { enabled: usageEnabled(persisted) },
browserTools: { enabled: daemon.browserTools?.enabled ?? false }, browserTools: { enabled: daemon.browserTools?.enabled ?? false },
providers: (agents.providers ?? {}) as MutableDaemonConfig["providers"], providers: (agents.providers ?? {}) as MutableDaemonConfig["providers"],
metadataGeneration: { providers: agents.metadataGeneration?.providers ?? [] }, metadataGeneration: { providers: agents.metadataGeneration?.providers ?? [] },
@@ -1577,31 +1572,3 @@ describe("DaemonConfigStore speech settings", () => {
expect(JSON.stringify(other.get())).not.toContain("secret"); expect(JSON.stringify(other.get())).not.toContain("secret");
}); });
}); });
test("usage policy persists across restart and live reload", async () => {
const paseoHome = mkdtempSync(path.join(tmpdir(), "usage-policy-"));
try {
const initial = reloadableConfig({});
const store = new DaemonConfigStore(paseoHome, initial, undefined, {
reloadSource: {
resolve: (persisted) => ({
mutable: reloadableConfig(persisted),
overrideControlledPaths: [],
}),
},
});
await store.patch({ usage: { enabled: false } });
expect(loadConfig(paseoHome, { env: {} }).usageEnabled).toBe(false);
const persisted = loadPersistedConfig(paseoHome);
const restarted = new DaemonConfigStore(paseoHome, reloadableConfig(persisted));
expect(restarted.get().usage).toEqual({ enabled: false });
writeFileSync(
path.join(paseoHome, "config.json"),
JSON.stringify({ daemon: { usage: { enabled: true } } }),
);
await store.reload();
expect(store.get().usage).toEqual({ enabled: true });
} finally {
rmSync(paseoHome, { recursive: true, force: true });
}
});
@@ -22,7 +22,6 @@ type ProviderOverride = import("./agent/provider-launch-config.js").ProviderOver
interface SupportedMutableConfigPatch { interface SupportedMutableConfigPatch {
relay?: { enabled?: boolean; requireProtectedSecurity?: boolean }; relay?: { enabled?: boolean; requireProtectedSecurity?: boolean };
mcp?: { injectIntoAgents?: boolean }; mcp?: { injectIntoAgents?: boolean };
usage?: { enabled: boolean };
browserTools?: { enabled?: boolean }; browserTools?: { enabled?: boolean };
providers?: MutableDaemonConfig["providers"]; providers?: MutableDaemonConfig["providers"];
removeProviders?: string[]; removeProviders?: string[];
@@ -183,7 +182,6 @@ const RELOADABLE_PATHS = [
"daemon.relay.requireProtectedSecurity", "daemon.relay.requireProtectedSecurity",
"daemon.mcp.enabled", "daemon.mcp.enabled",
"daemon.mcp.injectIntoAgents", "daemon.mcp.injectIntoAgents",
"daemon.usage.enabled",
"daemon.browserTools.enabled", "daemon.browserTools.enabled",
"daemon.hostnames", "daemon.hostnames",
"daemon.cors.allowedOrigins", "daemon.cors.allowedOrigins",
@@ -211,7 +209,6 @@ const PERSISTED_TO_MUTABLE_PATH = new Map<string, string>([
["daemon.relay.requireProtectedSecurity", "relay.requireProtectedSecurity"], ["daemon.relay.requireProtectedSecurity", "relay.requireProtectedSecurity"],
["daemon.mcp.enabled", "mcp.enabled"], ["daemon.mcp.enabled", "mcp.enabled"],
["daemon.mcp.injectIntoAgents", "mcp.injectIntoAgents"], ["daemon.mcp.injectIntoAgents", "mcp.injectIntoAgents"],
["daemon.usage.enabled", "usage.enabled"],
["daemon.browserTools.enabled", "browserTools.enabled"], ["daemon.browserTools.enabled", "browserTools.enabled"],
["daemon.hostnames", "hostnames"], ["daemon.hostnames", "hostnames"],
["daemon.cors.allowedOrigins", "cors.allowedOrigins"], ["daemon.cors.allowedOrigins", "cors.allowedOrigins"],
@@ -284,7 +281,6 @@ function pickRelayPatch(
function pickSupportedPatchFields(patch: MutableDaemonConfigPatch): SupportedMutableConfigPatch { function pickSupportedPatchFields(patch: MutableDaemonConfigPatch): SupportedMutableConfigPatch {
return { return {
...pickRelayPatch(patch.relay), ...pickRelayPatch(patch.relay),
usage: patch.usage,
...(patch.mcp?.injectIntoAgents !== undefined ...(patch.mcp?.injectIntoAgents !== undefined
? { mcp: { injectIntoAgents: patch.mcp.injectIntoAgents } } ? { mcp: { injectIntoAgents: patch.mcp.injectIntoAgents } }
: {}), : {}),
@@ -771,7 +767,6 @@ function mergeMutableDaemonPatch(
if (patch.mcp?.injectIntoAgents !== undefined) { if (patch.mcp?.injectIntoAgents !== undefined) {
next.mcp = { ...next.mcp, injectIntoAgents: patch.mcp.injectIntoAgents }; next.mcp = { ...next.mcp, injectIntoAgents: patch.mcp.injectIntoAgents };
} }
if (patch.usage) next.usage = patch.usage;
if (patch.browserTools?.enabled !== undefined) { if (patch.browserTools?.enabled !== undefined) {
next.browserTools = { ...next.browserTools, enabled: patch.browserTools.enabled }; next.browserTools = { ...next.browserTools, enabled: patch.browserTools.enabled };
} }
@@ -1,6 +1,3 @@
import { execFile } from "node:child_process";
import { promisify } from "node:util";
import { fileURLToPath } from "node:url";
import { mkdtempSync, rmSync } from "node:fs"; import { mkdtempSync, rmSync } from "node:fs";
import { tmpdir } from "node:os"; import { tmpdir } from "node:os";
import path from "node:path"; import path from "node:path";
@@ -10,7 +7,7 @@ import { ClaudeAgentClient } from "../agent/providers/claude/agent.js";
import { createTestPaseoDaemon } from "../test-utils/paseo-daemon.js"; import { createTestPaseoDaemon } from "../test-utils/paseo-daemon.js";
import { DaemonClient } from "../test-utils/daemon-client.js"; import { DaemonClient } from "../test-utils/daemon-client.js";
test("background cards retain child actions after the parent finishes (#6253)", async () => { test("background children keep their actions after the parent finishes (#6253)", async () => {
const cwd = mkdtempSync(path.join(tmpdir(), "paseo-background-card-")); const cwd = mkdtempSync(path.join(tmpdir(), "paseo-background-card-"));
const logger = pino({ level: "silent" }); const logger = pino({ level: "silent" });
const daemon = await createTestPaseoDaemon({ const daemon = await createTestPaseoDaemon({
@@ -62,22 +59,6 @@ test("background cards retain child actions after the parent finishes (#6253)",
limit: 0, limit: 0,
projection: "projected", projection: "projected",
}); });
const { stdout } = await promisify(execFile)(
process.execPath,
[
"--conditions=source",
"--import",
"tsx",
fileURLToPath(new URL("../../../../cli/src/index.ts", import.meta.url)),
"--host",
`127.0.0.1:${daemon.port}`,
"logs",
agent.id,
],
{ env: { ...process.env, PASEO_HOME: daemon.paseoHome }, timeout: 30_000 },
);
expect(stdout).toContain("[Bash] ls -1");
expect(stdout).toContain("[Bash] pwd");
expect( expect(
atFinish.entries.filter( atFinish.entries.filter(
(row) => row.item.type === "tool_call" && row.item.detail?.type === "sub_agent", (row) => row.item.type === "tool_call" && row.item.detail?.type === "sub_agent",
@@ -94,9 +75,6 @@ test("background cards retain child actions after the parent finishes (#6253)",
), ),
).toBe(true); ).toBe(true);
} }
for (const card of cards) {
expect(card.detail?.type === "sub_agent" ? card.detail.log : "").toContain("[Bash]");
}
} finally { } finally {
await client.close(); await client.close();
await daemon.close(); await daemon.close();
@@ -1,6 +1,5 @@
import { appendFileSync, mkdirSync } from "node:fs"; import { appendFileSync, mkdirSync } from "node:fs";
import path from "node:path"; import path from "node:path";
import { initializeEnvironmentProxy } from "./network/index.js";
import { createPaseoDaemon, formatListenTarget } from "./bootstrap.js"; import { createPaseoDaemon, formatListenTarget } from "./bootstrap.js";
import { loadConfig } from "./config.js"; import { loadConfig } from "./config.js";
import { resolvePaseoHome } from "./paseo-home.js"; import { resolvePaseoHome } from "./paseo-home.js";
@@ -133,11 +132,6 @@ function applyCliFlagOverrides(config: ReturnType<typeof loadConfig>): void {
async function main() { async function main() {
const { paseoHome, logger, config } = bootstrapFromEnvironment(); const { paseoHome, logger, config } = bootstrapFromEnvironment();
for (const variable of initializeEnvironmentProxy()) {
writeWorkerLifecycleLog(paseoHome, "Ignoring invalid or unsupported HTTP proxy variable", {
variable,
});
}
let daemon: Awaited<ReturnType<typeof createPaseoDaemon>> | null = null; let daemon: Awaited<ReturnType<typeof createPaseoDaemon>> | null = null;
let shutdownPromise: Promise<number> | null = null; let shutdownPromise: Promise<number> | null = null;
let exitHookInstalled = false; let exitHookInstalled = false;
@@ -1,6 +1,5 @@
import { WebSocket } from "ws"; import { WebSocket } from "ws";
import { z } from "zod"; import { z } from "zod";
import { webSocketProxyAgent } from "../network/index.js";
import type { WebSocketLike } from "../websocket-server.js"; import type { WebSocketLike } from "../websocket-server.js";
const SOCKET_PING_INTERVAL_MS = 10_000; const SOCKET_PING_INTERVAL_MS = 10_000;
@@ -167,7 +166,6 @@ export class DirectHubRelationshipRemote implements HubRelationshipRemote {
openSocket(input: HubSocketCredentials, events: HubSocketEvents): HubSocketConnection { openSocket(input: HubSocketCredentials, events: HubSocketEvents): HubSocketConnection {
let sessionProtocol: "legacy" | "session-v1" = "legacy"; let sessionProtocol: "legacy" | "session-v1" = "legacy";
const socket = new WebSocket(input.webSocketUrl, { const socket = new WebSocket(input.webSocketUrl, {
agent: webSocketProxyAgent(input.webSocketUrl),
handshakeTimeout: this.requestTimeoutMs, handshakeTimeout: this.requestTimeoutMs,
headers: { headers: {
authorization: `Bearer ${input.credential}`, authorization: `Bearer ${input.credential}`,
-116
View File
@@ -1,116 +0,0 @@
import type { Agent } from "node:http";
import { EnvHttpProxyAgent, Pool, setGlobalDispatcher } from "undici";
import { HttpsProxyAgent } from "https-proxy-agent";
interface ProxyEnvironment {
httpProxy: string;
httpsProxy: string;
noProxy: string;
}
let environment = readEnvironment(process.env, process.platform).environment;
function readEnvironment(
env: NodeJS.ProcessEnv,
platform: NodeJS.Platform,
): {
environment: ProxyEnvironment;
ignored: string[];
} {
// process.env lookups are case-insensitive on Windows. Read each actual entry once.
const values = new Map(
Object.entries(env).map(([name, value]) => [
platform === "win32" ? name.toLowerCase() : name,
value,
]),
);
const ignored: string[] = [];
function proxy(variable: string): string | undefined {
const value = values.get(variable);
if (value === undefined) return undefined;
if (!value.trim()) return undefined;
try {
const url = new URL(value.includes("://") ? value : `http://${value}`);
if (url.protocol !== "http:" && url.protocol !== "https:")
throw new Error("Unsupported proxy protocol");
decodeURIComponent(url.username);
decodeURIComponent(url.password);
return url.href;
} catch {
ignored.push(variable);
return undefined;
}
}
const httpProxy = proxy("http_proxy") ?? proxy("HTTP_PROXY") ?? "";
return {
environment: {
httpProxy,
httpsProxy: proxy("https_proxy") ?? proxy("HTTPS_PROXY") ?? httpProxy,
noProxy: values.get("no_proxy") ?? values.get("NO_PROXY") ?? "",
},
ignored,
};
}
function bypassList(noProxy: string): string {
return noProxy.split(/[,\s]+/).includes("*") ? "*" : `${noProxy},localhost,127.0.0.1,[::1],::1`;
}
function proxyClient(origin: URL, options: object) {
const pool = new Pool(origin, options);
if (!origin.username && !origin.password) return pool;
const credentials = `${decodeURIComponent(origin.username)}:${decodeURIComponent(origin.password)}`;
const authorization = `Basic ${Buffer.from(credentials).toString("base64")}`;
// This pool only sends CONNECT requests to this proxy, never requests to the origin.
// undici's URL auth requires both fields; HTTP Basic also permits either field to be empty.
return pool.compose(
(dispatch) => (request, handler) =>
dispatch(
{
...request,
headers: { ...request.headers, "proxy-authorization": authorization },
},
handler,
),
);
}
/** Install once at startup; return ignored variable names for logging without exposing credentials. */
export function initializeEnvironmentProxy(
env: NodeJS.ProcessEnv = process.env,
platform: NodeJS.Platform = process.platform,
): string[] {
const resolved = readEnvironment(env, platform);
environment = resolved.environment;
setGlobalDispatcher(
new EnvHttpProxyAgent({
httpProxy: environment.httpProxy,
httpsProxy: environment.httpsProxy,
noProxy: bypassList(environment.noProxy),
clientFactory: proxyClient,
}),
);
return resolved.ignored;
}
/** ws uses Node HTTP agents rather than the fetch dispatcher. */
export function webSocketProxyAgent(address: string): Agent | undefined {
const url = new URL(address);
const hostname = url.hostname.toLowerCase();
const port = url.port || (url.protocol === "wss:" ? "443" : "80");
const entries = bypassList(environment.noProxy)
.toLowerCase()
.split(/[,\s]+/);
if (
entries.some((entry) => {
if (entry === "*") return true;
const match = entry.match(/^(.+):(\d+)$/);
if (match && Number(match[2]) !== Number(port)) return false;
const host = (match ? match[1]! : entry).replace(/^\*?\./, "");
return host !== "" && (hostname === host || hostname.endsWith(`.${host}`));
})
)
return undefined;
const proxy = url.protocol === "wss:" ? environment.httpsProxy : environment.httpProxy;
return proxy ? new HttpsProxyAgent(proxy) : undefined;
}

Some files were not shown because too many files have changed in this diff Show More