Compare commits

..
Author SHA1 Message Date
Mohamed Boudra 4e60c2880b chore(release): cut 0.7.0-beta.2 2026-08-28 18:35:49 +02:00
Mohamed Boudra 510074f555 docs: add v0.7.0-beta.2 changelog 2026-08-28 18:28:12 +02:00
304 changed files with 3318 additions and 14877 deletions
+25 -35
View File
@@ -1,64 +1,54 @@
# Changelog
## 0.7.0 - 2026-08-31
## 0.7.0-beta.2 - 2026-08-28
### Added
- Added SSH connections to existing remote daemons from Desktop and CLI ([#3989](https://github.com/getpaseo/paseo/pull/3989) by [@reidlevesque](https://github.com/reidlevesque))
- Added workspace management and layout actions to the Command Center ([#3013](https://github.com/getpaseo/paseo/pull/3013) by [@cleiter](https://github.com/cleiter))
- Added contextual composer-pill contributions for plugins ([#3956](https://github.com/getpaseo/paseo/pull/3956))
- Added host UI primitives for client plugins ([#3967](https://github.com/getpaseo/paseo/pull/3967))
- Added PR and MR number search to the Command Center ([#3008](https://github.com/getpaseo/paseo/pull/3008) by [@cleiter](https://github.com/cleiter))
- Added session commands to agent SDK handles ([#3719](https://github.com/getpaseo/paseo/pull/3719) by [@gpambrozio](https://github.com/gpambrozio), [@marvin-ambrozio](https://github.com/marvin-ambrozio))
### Improved
- Batched GitHub pull request polling within the reserved API budget ([#3825](https://github.com/getpaseo/paseo/pull/3825) by [@dezchai](https://github.com/dezchai))
### Fixed
- Fixed daemon reconnects stalling while Git processes were queued ([#3945](https://github.com/getpaseo/paseo/pull/3945))
- Fixed restored workspace tabs entering reconciliation loops ([#3987](https://github.com/getpaseo/paseo/pull/3987))
- Fixed immediate dictation submissions omitting the newest speech segment ([#3968](https://github.com/getpaseo/paseo/pull/3968))
- Fixed archived workspaces returning from durable cache ([#3975](https://github.com/getpaseo/paseo/pull/3975))
- Fixed commits and squash merges bypassing configured Git signing ([#3976](https://github.com/getpaseo/paseo/pull/3976))
- Fixed Markdown literal characters being replaced by typographic symbols ([#3253](https://github.com/getpaseo/paseo/pull/3253) by [@cleiter](https://github.com/cleiter))
## 0.7.0-beta.1 - 2026-08-27
### Changed
- Changed the project license to Apache-2.0 ([#3944](https://github.com/getpaseo/paseo/pull/3944))
- Changed Cmd/Ctrl+E to toggle Explorer visibility without selecting a view ([#3896](https://github.com/getpaseo/paseo/pull/3896))
- Changed the default mobile content text size from 15px to 16px ([#4111](https://github.com/getpaseo/paseo/pull/4111))
### Added
- Added plugin installation and updates directly from Git repositories ([#3920](https://github.com/getpaseo/paseo/pull/3920))
- Added plugin-defined timeline transformations and rendering ([#3940](https://github.com/getpaseo/paseo/pull/3940))
- Added SSH connections to existing remote daemons from Desktop and CLI ([#3989](https://github.com/getpaseo/paseo/pull/3989) by [@reidlevesque](https://github.com/reidlevesque))
- Added workspace management and layout actions to the Command Center ([#3013](https://github.com/getpaseo/paseo/pull/3013) by [@cleiter](https://github.com/cleiter))
- Added contextual composer-pill contributions for plugins ([#3956](https://github.com/getpaseo/paseo/pull/3956))
- Added host UI primitives for client plugins ([#3967](https://github.com/getpaseo/paseo/pull/3967))
- Added readable prompts, details, and results for Paseo tool calls ([#4066](https://github.com/getpaseo/paseo/pull/4066))
- Added zoom and pan to workspace images and assistant timeline previews ([#4032](https://github.com/getpaseo/paseo/pull/4032), [#4049](https://github.com/getpaseo/paseo/pull/4049), [#4064](https://github.com/getpaseo/paseo/pull/4064))
- Added opening child folders directly in the preferred desktop editor ([#3615](https://github.com/getpaseo/paseo/pull/3615) by [@caikovsky](https://github.com/caikovsky))
- Added host navigation from plugin surfaces to agents and workspaces ([#3901](https://github.com/getpaseo/paseo/pull/3901) by [@omercnet](https://github.com/omercnet))
- Added host-rendered icons to plugin client surfaces ([#3903](https://github.com/getpaseo/paseo/pull/3903) by [@omercnet](https://github.com/omercnet))
- Added semantic surface, border, success, and warning colors to plugin themes ([#3898](https://github.com/getpaseo/paseo/pull/3898) by [@omercnet](https://github.com/omercnet))
- Added registered project listing to the public plugin SDK ([#3899](https://github.com/getpaseo/paseo/pull/3899) by [@omercnet](https://github.com/omercnet))
- Added PR and MR number search to the Command Center ([#3008](https://github.com/getpaseo/paseo/pull/3008) by [@cleiter](https://github.com/cleiter))
- Added session commands to agent SDK handles ([#3719](https://github.com/getpaseo/paseo/pull/3719) by [@gpambrozio](https://github.com/gpambrozio), [@marvin-ambrozio](https://github.com/marvin-ambrozio))
- Added F-Droid release metadata and stable changelog generation ([#2501](https://github.com/getpaseo/paseo/pull/2501) by [@antonok-edm](https://github.com/antonok-edm))
- Added Astro syntax highlighting to files, the editor, and diffs ([#3997](https://github.com/getpaseo/paseo/pull/3997))
### Improved
- Streamed assistant text at a steady visual rate instead of in arrival lumps ([#3612](https://github.com/getpaseo/paseo/pull/3612) by [@Tommypop2](https://github.com/Tommypop2))
- Painted cached conversations before unrelated cache restoration and network loading ([#3907](https://github.com/getpaseo/paseo/pull/3907))
- Reused one OpenCode helper across ordinary agent sessions instead of spawning one per agent ([#4009](https://github.com/getpaseo/paseo/pull/4009))
- Batched GitHub pull request polling within the reserved API budget ([#3825](https://github.com/getpaseo/paseo/pull/3825) by [@dezchai](https://github.com/dezchai))
- Added manual, action-required, and warning states to GitLab and Gitea checks ([#2337](https://github.com/getpaseo/paseo/pull/2337) by [@nllptrx](https://github.com/nllptrx))
- Kept cold-start pull request status checks on the shared GitHub batch path ([#4025](https://github.com/getpaseo/paseo/pull/4025))
### Fixed
- Fixed the daemon crashing when a Claude or OMP JSONL process closes during a write ([#4048](https://github.com/getpaseo/paseo/pull/4048))
- Fixed Android first-message submissions crashing when the keyboard restarted during composer teardown ([#4044](https://github.com/getpaseo/paseo/pull/4044))
- Fixed long mobile drafts hiding composer controls behind the keyboard ([#4051](https://github.com/getpaseo/paseo/pull/4051))
- Fixed Android timelines shifting when tapping selectable text ([#4090](https://github.com/getpaseo/paseo/pull/4090))
- Fixed web and Electron composers losing focus after submission ([#4067](https://github.com/getpaseo/paseo/pull/4067))
- Fixed Android dictation leaving Bluetooth audio in call-quality routing after capture stopped ([#4069](https://github.com/getpaseo/paseo/pull/4069))
- Fixed dictation retries timing out after an abandoned partial transcript ([#4065](https://github.com/getpaseo/paseo/pull/4065))
- Fixed immediate dictation submissions omitting the newest speech segment ([#3968](https://github.com/getpaseo/paseo/pull/3968))
- Fixed the model selector crashing in iPad desktop layouts ([#3992](https://github.com/getpaseo/paseo/pull/3992) by [@yzim](https://github.com/yzim))
- Fixed OpenCode child-session prompts missing from provider subagent timelines ([#4055](https://github.com/getpaseo/paseo/pull/4055) by [@mcowger](https://github.com/mcowger))
- Fixed archived agents disappearing when opened from History ([#4033](https://github.com/getpaseo/paseo/pull/4033))
- Fixed restored workspace tabs entering reconciliation loops ([#3987](https://github.com/getpaseo/paseo/pull/3987))
- Fixed archived workspaces returning from durable cache ([#3975](https://github.com/getpaseo/paseo/pull/3975))
- Fixed Grok unified-billing accounts showing zero credits instead of weekly usage ([#4029](https://github.com/getpaseo/paseo/pull/4029) by [@Lite-G](https://github.com/Lite-G), [@claude](https://github.com/claude))
- Fixed daemon reconnects stalling while Git processes were queued ([#3945](https://github.com/getpaseo/paseo/pull/3945))
- Fixed slow Pi and OMP startup requests timing out after 30 seconds ([#4008](https://github.com/getpaseo/paseo/pull/4008))
- Fixed commits and squash merges bypassing configured Git signing ([#3976](https://github.com/getpaseo/paseo/pull/3976))
- Fixed Android system navigation covering the Commits controls ([#4005](https://github.com/getpaseo/paseo/pull/4005))
- Fixed new agent work appearing as reopened tasks ([#4068](https://github.com/getpaseo/paseo/pull/4068))
- Fixed Markdown literal characters being replaced by typographic symbols ([#3253](https://github.com/getpaseo/paseo/pull/3253) by [@cleiter](https://github.com/cleiter))
- Fixed rewinding long conversations replaying the complete rebuilt timeline ([#3642](https://github.com/getpaseo/paseo/pull/3642))
- Fixed rewound prompts remaining blank in the mounted iOS composer ([#3946](https://github.com/getpaseo/paseo/pull/3946))
- Fixed native plugin setup and async client callbacks failing on iOS ([#3942](https://github.com/getpaseo/paseo/pull/3942))
-1
View File
@@ -46,7 +46,6 @@ At the start of non-trivial work, list `docs/` and skim anything relevant to the
| [docs/rpc-namespacing.md](docs/rpc-namespacing.md) | WebSocket RPC naming convention — dotted namespaces and `.request`/`.response` pairs |
| [docs/protocol-compatibility.md](docs/protocol-compatibility.md) | Why app/daemon versions drift, protocol vs feature contract, capability gating, COMPAT tagging |
| [docs/protocol-validation.md](docs/protocol-validation.md) | zod-aot generated inbound WebSocket validation, patched compiler regressions, schema-purity rules |
| [docs/permissions.md](docs/permissions.md) | Semantic daemon permissions, principals, credentials, pairing invitations, and Hub authority |
| [docs/terminal-performance.md](docs/terminal-performance.md) | Terminal latency pipeline, coalescing/backpressure invariants, benchmark + perf spec usage |
| [docs/agent-stream-performance.md](docs/agent-stream-performance.md) | Assistant text pipeline — coalescing window, paced reveal, why arrival lumps are smoothed at render |
| [docs/file-observation.md](docs/file-observation.md) | Recursive watcher ownership, Linux constraints, teardown invariants, and Parcel comparison |
+3 -5
View File
@@ -393,7 +393,6 @@ Custom OMP profiles should extend `omp`. They inherit the OMP adapter's `rpc-ui`
},
"params": {
"sessionDir": "~/.local/state/omp-work/omp/agent/sessions",
"rpcTimeoutMs": 60000,
"smolModel": "openai/gpt-5-mini",
"slowModel": "anthropic/claude-opus-4-1",
"planModel": "openai/o3"
@@ -404,7 +403,7 @@ Custom OMP profiles should extend `omp`. They inherit the OMP adapter's `rpc-ui`
}
```
`params.sessionDir` is used only for importing sessions that were started outside Paseo. If `command` or XDG env vars move OMP's state directory, set `params.sessionDir` to the resulting OMP JSONL session directory; launching and resuming still go through the configured command. OMP waits 20 seconds for its initial `ready` frame and 60 seconds for later control-plane RPCs by default. `params.rpcTimeoutMs` overrides both deadlines.
`params.sessionDir` is used only for importing sessions that were started outside Paseo. If `command` or XDG env vars move OMP's state directory, set `params.sessionDir` to the resulting OMP JSONL session directory; launching and resuming still go through the configured command.
For other providers that keep Pi's `--mode rpc` API but write sessions somewhere else, extend `pi`, replace the command, and provide the JSONL session directory:
@@ -417,8 +416,7 @@ For other providers that keep Pi's `--mode rpc` API but write sessions somewhere
"label": "My Pi Fork",
"command": ["my-pi-fork"],
"params": {
"sessionDir": "~/.my-pi-fork/sessions",
"rpcTimeoutMs": 60000
"sessionDir": "~/.my-pi-fork/sessions"
}
}
}
@@ -426,7 +424,7 @@ For other providers that keep Pi's `--mode rpc` API but write sessions somewhere
}
```
This session directory is also import-only. Launching and resuming still go through the configured command, so this example resumes with `my-pi-fork --mode rpc --session <session-file>`. `params.rpcTimeoutMs` overrides the 60-second Pi control-plane RPC deadline.
This session directory is also import-only. Launching and resuming still go through the configured command, so this example resumes with `my-pi-fork --mode rpc --session <session-file>`.
---
+1 -1
View File
@@ -30,7 +30,7 @@ Before adding a new component, read `components/ui/`. The primitive usually exis
Hierarchy is conveyed through weight and color, not size. Most interface text is `fontSize.base`; compact metadata and hints use `fontSize.sm`. The distinction between a row's primary line and its secondary line is `foreground` versus `foregroundMuted`.
The authored interface ramp uses a 14px base. New native installs default to 15px; web and desktop default to 14px. The Appearance **Interface size** setting is the rendered `fontSize.base` value and scales the rest of the UI ramp proportionally. Primary readable content has its own `fontSize.content`, which defaults to 16px on native and 15px on web and desktop. It owns message bodies, composer input, Markdown, and PR prose. Controls, navigation, metadata, tool chrome, code, diffs, editors, and terminals stay on their interface or code tokens. **Code size** remains independent.
The authored interface ramp uses a 14px base. New native installs default to 15px; web and desktop default to 14px. The Appearance **Interface size** setting is the rendered `fontSize.base` value and scales the rest of the UI ramp proportionally. Primary readable content has its own `fontSize.content`, which defaults to 15px on every platform. It owns message bodies, composer input, Markdown, and PR prose. Controls, navigation, metadata, tool chrome, code, diffs, editors, and terminals stay on their interface or code tokens. **Code size** remains independent.
Weight has three tiers, applied by role:
+21 -12
View File
@@ -132,21 +132,30 @@ quietly relying on:
The fix for transforms is Gotcha 3. The fix for context is Gotcha 7.
## Gotcha 3 — Keyboard layout and portal anchors
## Gotcha 3 — Reanimated transforms vs `measureInWindow`
Move the chat surface with worklet-driven bottom padding from
`KeyboardShiftProvider`. Padding keeps the stream, composer, visual position,
and native hit testing in the same layout. Do not translate the stream and
composer independently.
`measureInWindow` returns the view's _current_ screen position. In theory that
includes Reanimated-applied transforms (Reanimated updates native view
properties, and Android's `getLocationInWindow` reads transformed coords). In
practice it's racy — the measurement may snapshot mid-animation, and on Android
with Reanimated worklets the result is not always stable.
Do not use the controller's raw keyboard progress for the padding. It can retain
a nonzero value after the keyboard closes. The shared provider normalizes that
state and reconciles native animation-end events.
If the panel cannot stay inside the transformed ancestor, do not try to track
the keyboard by re-measuring on every frame. Instead,
**slave the popover's transform to the same `KeyboardShiftProvider` SharedValue
the composer uses**:
`measureInWindow` already includes the dock's current padding layout. When a
portal opens, snapshot the current shift and apply only the subsequent shift
delta to its animated `bottom`. Adding the full shift moves the portal twice and
can place it over the composer controls.
1. Snapshot `openShift = shift.value` at the moment you measure the anchor.
2. Apply `useAnimatedStyle(() => ({ transform: [{ translateY: openShift.value - shift.value }] }))`
to the popover wrapper.
When `shift` equals `openShift`, the translate is 0 and the popover sits at
the measured position. When the keyboard moves afterward, the delta translates
the popover by exactly the amount the composer translates. They move in
lockstep, no re-measurement needed. Do not call
`useReanimatedKeyboardAnimation()` directly for app UI offset policy; Android
can briefly report a stale nonzero height with closed progress, and the shared
provider is where that is normalized.
The provider also reconciles iOS from the controller's native `onEnd` event.
The controller's stock iOS shared values update at move start and during an
+8 -12
View File
@@ -4,7 +4,7 @@ Paseo Hub is an explicit opt-in connection from one Paseo daemon to one Hub. Run
not register it with a Hub. The relationship begins only when a user runs
`paseo hub connect [url]` from the daemon machine with an explicit API key or matching stored CLI login.
The human CLI login and daemon relationship are separate identities. `paseo hub login [url]` stores a durable organization-scoped CLI credential keyed by normalized Hub origin under `PASEO_HOME`. Interactive login optionally connects the local daemon, then points to the Hub UI for trigger configuration; it does not scaffold or deploy configuration. `paseo hub init` remains the explicit triggers-as-code scaffold. `paseo hub export [directory]` writes the active organization's current triggers as one self-contained YAML file per trigger, using the active login unless another Hub or API key is selected. Origin resolution uses explicit command input, `PASEO_HUB_URL`, active login, then `https://hub.paseo.sh`. Connect uses exact-origin authority to request a one-time enrollment token, then passes only that token to the daemon. The daemon generates and persists its own relationship credential.
The human CLI login and daemon relationship are separate identities. `paseo hub login [url]` stores a durable organization-scoped CLI credential keyed by normalized Hub origin under `PASEO_HOME`. Origin resolution uses explicit command input, `PASEO_HUB_URL`, active login, then `https://hub.paseo.sh`. Connect uses exact-origin authority to request a one-time enrollment token, then passes only that token to the daemon. The daemon generates and persists its own relationship credential.
## Connection and authority
@@ -17,21 +17,17 @@ The daemon persists a relationship ID and private connection credential before e
relationship is independent of its current transport, so a future transport can replace the direct
WebSocket without pairing again. The current foundation supports one Hub relationship per daemon.
Normal authenticated daemon sessions may manage the daemon's Hub relationship and permissions.
Hub connections have no daemon permissions by default. Connecting gives Hub machine identity and
presence but no execution authority. The `hub.execute` permission lets workflows triggered from
GitHub, Slack, Discord, Linear, and other integrations create workspaces and run agents. Grant it
during interactive login or later with `paseo hub permissions grant hub.execute`. Relationships
created before this split migrate their legacy execution scope to `hub.execute`. Hub sessions cannot
manage their own relationship or permissions.
Normal authenticated daemon sessions may run the `hub.management.daemon.connect`,
`hub.management.daemon.get_status`, and `hub.management.daemon.disconnect` RPCs. Hub connections
receive only `hub.execution.*` authority, so execution credentials cannot manage the relationship.
## Session grants and execution ownership
Trusted clients and the Hub use the same `Session` implementation. The connection boundary supplies
semantic permissions: trusted clients receive the owner permission set, while an enrolled Hub
connection receives its persisted permissions. Legacy relationship files carrying
`hub.execution.*` migrate once to `hub.execute` at the persistence boundary. A denied request returns
the ordinary `rpc_error` shape. See [permissions.md](permissions.md).
grants: trusted clients receive `*`, while an enrolled Hub connection receives its persisted
`hub.execution.*` grant. One matcher handles exact RPC names and trailing namespace wildcards for
both inbound requests and outbound messages. A denied request returns the ordinary `rpc_error`
shape.
The Hub connection still has a narrow lifecycle boundary: it has no trusted-client hello/resume,
browser, binary, retained-session, or broadcast state. Its outbound execution events include only
+6 -8
View File
@@ -30,10 +30,8 @@ The UI worklet owns transient motion:
- the active gesture's starting revision
- the last settled target
React publishes the active panel only after its motion reaches the final anchor. Retained content
never observes gesture previews, progress, or an unsettled target. The gesture hosts stay mounted;
worklets reveal their retained overlays through native styles while React owns pointer events and
accessibility.
React also owns presentation lifecycle: whether an overlay is mounted/displayed and whether it may
receive pointer events. Worklets never own `display` or `pointerEvents`.
## Why one position
@@ -87,8 +85,8 @@ definition, no longer eligible to begin.
- Animated panel nodes use React Native static styles plus inline theme values. Do not attach
Unistyles-generated styles to those nodes; Unistyles and Reanimated patching the same Fabric node
has caused native crashes.
- Gesture start and progress must not update React state. The retained overlay is already mounted and
offscreen; only the shared position and its derived native styles move during a drag.
- The plain React wrapper owns `display: none` after settlement. This prevents a stale Fabric animated
prop commit from resurrecting a closed overlay.
- Hidden tabs and workspaces use `RetainedPanel`. It owns a non-collapsible native root, visibility,
pointer events, and the active signal consumed by `useRetainedPanelActive`.
- Panels whose gesture wrapper already owns visibility use `RetainedPanelActivity` to provide the
@@ -100,8 +98,8 @@ definition, no longer eligible to begin.
- Retention order and render order are separate concerns. LRU metadata may change on every switch;
keyed retained roots must keep a stable sibling order. Moving large retained roots triggered Fabric
Differ failures (`addViewAt` / `removeViewAt` view reuse) on Android.
- `useIsMobilePanelActive` follows the settled target, not the requested target. Activation work may
begin only after the finishing animation completes; cancellation publishes nothing.
- The newly active panel must be included in the same render that changes selection. Adding it from an
effect creates a committed frame where every retained panel is hidden, which is a real blank screen.
- Do not suspend retained native subtrees with `Suspense`/`react-freeze`. Suspension changes native
ownership and can detach descendants. Keep the tree mounted, stabilize its subscriptions/selectors,
and use the retained-panel active signal to stop timers, polling, and other genuine background work.
+4 -6
View File
@@ -259,9 +259,7 @@ background music stays paused. On iOS this is not just a "while recording" probl
`.playAndRecord`/`.voiceChat` category is non-mixing and survives backgrounding, and iOS re-asserts
it every time the app returns to the foreground — so one dictation turn kills music for the life of
the process, on every open, until the app is force-quit. Android holds
`AUDIOFOCUS_GAIN_TRANSIENT_EXCLUSIVE` with the same effect. It must also reset
`MODE_IN_COMMUNICATION` and clear the selected communication device; abandoning focus alone can
leave Bluetooth earbuds on their narrow-band call route without an active microphone indicator.
`AUDIOFOCUS_GAIN_TRANSIENT_EXCLUSIVE` with the same effect.
`createAudioEngine` (`packages/app/src/voice/audio-engine.native.ts`) calls
`releaseAudioSession()` whenever capture stops and the playback queue drains, and the iOS module
@@ -269,9 +267,9 @@ also releases on `OnAppEntersBackground`. The native side re-guards on `isRecord
`speechPlayer.isPlaying`, because the native engine is a singleton shared by multiple JS engine
wrappers (voice provider + dictation) and only it knows the true state.
This cannot be validated by a JS test — verify on a device: play music through Bluetooth earbuds,
open Paseo, use dictation once, stop, and confirm the music resumes at full quality; then
background/foreground the app and confirm it keeps playing at full quality.
This cannot be validated by a JS test — verify on a device: play music, open Paseo, use dictation
once, stop, and confirm the music resumes; then background/foreground the app and confirm it keeps
playing.
## Unistyles + Reanimated
-59
View File
@@ -1,59 +0,0 @@
# Daemon permissions
The daemon authorizes principals with semantic permissions. RPC names and protocol namespaces are not authority.
## Model
```text
principal -> grants
|
+-- authenticated by a device or service credential
`-- opens a session with equal or narrower authority
```
A principal is the durable identity the daemon authorizes. A credential proves that a device or service represents it. Keep them separate so you can rotate credentials, attach more than one device, and revoke a Hub user without inventing daemon user accounts.
A pairing invitation is neither. It is an expiring, single-use exchange that creates a principal and credential with the permissions selected by its issuer.
## Permissions
| Permission | Authority |
| ------------------- | -------------------------------------------------------------------------- |
| `daemon.read` | Daemon status, diagnostics, configuration, and provider information |
| `daemon.manage` | Restart, update, configuration changes, providers, skills, and plugins |
| `tunnel.manage` | Relay, Hub, service tunnel, and public endpoint relationships |
| `access.manage` | Pairing invitations, principals, credentials, grants, and revocation |
| `workspace.read` | Projects, workspaces, agents, timelines, files, diffs, and terminal output |
| `workspace.write` | Prompts, agent control, files, terminals, git operations, and scripts |
| `workspace.manage` | Create, rename, archive, and remove projects and workspaces |
| `automation.manage` | Schedules, heartbeats, and loops |
| `hub.execute` | The Hub-owned execution lifecycle |
Agents and terminals use workspace authority. Both can execute code and mutate the workspace, so separate write permissions would claim an isolation boundary the daemon cannot enforce.
Owner, operator, and viewer are UI presets expanded into explicit permissions. Do not persist them as roles. Adding a permission must not silently widen an existing principal.
Permissions are additive allows. Missing authority denies the operation. Do not add deny precedence.
## Resources
Permissions are daemon-wide today. Future grants may select workspaces or agents, but operation classification remains inside the authorization module:
```ts
type Grant = {
permission: Permission;
resource: { kind: "daemon" } | { kind: "workspace"; ids: string[] };
};
```
A delegating principal can grant only authority it already possesses. A session may attenuate its principal's grants but cannot widen them.
Workspace-scoped grants require every resource-bearing operation and outbound observation to enforce the same workspace boundary. File preview currently accepts any daemon-readable regular file, so it must gain resource enforcement before workspace-specific access ships.
## Hub
The Hub authenticates as a service principal. Its locally selected grants decide whether it may execute agents, manage the daemon, manage tunnels, or manage access.
Hub user and role identifiers remain opaque external subjects. The Hub may create and revoke linked daemon principals when granted `access.manage`; the daemon does not interpret accounts, organizations, or roles.
Hub enrollment and permission updates exchange these semantic permissions directly. Legacy persisted Hub relationships that contain `hub.execution.*` migrate once to `hub.execute` when the daemon loads them; new relationships never persist or emit transport scopes as authority.
+18 -42
View File
@@ -2,9 +2,8 @@
Local plugins contribute daemon RPCs, native app surfaces, workspace panels, Command Center items,
composer pills, app themes, and composer attachment sources from one `index.ts`. Paseo executes the server contribution in a
subprocess and evaluates the client contribution in the app runtime.
> **Trust every plugin you add.** `paseo plugin add` and `paseo plugin install` mean “I trust this codebase.” Plugins are unsandboxed: server code and Git preparation commands run with the daemon user's access on the daemon host, and client contributions run inside Paseo. The repository's dependencies and future updates are part of that trust decision. With `--host`, preparation runs on that remote daemon host.
subprocess and evaluates the client contribution in the app runtime. Plugin code is trusted code;
Paseo does not sandbox it.
## Install a directory source
@@ -48,13 +47,15 @@ my-plugin/
paseo-plugin.json
index.ts
main.client.tsx
paseo-plugin.d.ts
package.json
tsconfig.json
```
The generated `package.json` installs `@getpaseo/plugin` and the other host modules as development
dependencies for local typechecking and tests. Paseo compiles TypeScript and TSX and supplies the
runtime modules, so consumers do not install these packages when adding the plugin.
Paseo compiles TypeScript and TSX when loading the plugin, so these packages are development dependencies only.
The generated declaration file supplies `@getpaseo/plugin` and `@getpaseo/plugin/server` types until the
SDK is distributed as a public package. Regenerate new plugins with the matching Paseo CLI when the
SDK contract changes.
```json
{
@@ -83,52 +84,28 @@ directory always wins over shorthand resolution.
```bash
paseo plugin add owner/repository
paseo plugin add https://gitlab.com/group/repository.git
paseo plugin add https://git.example.com/owner/repository.git
paseo plugin add owner/monorepo:plugins/review
paseo plugin add owner/monorepo --path plugins/review
paseo plugin add owner/repository --ref main
paseo plugin status
paseo plugin update review
paseo plugin update --all
```
Append `:relative/path` to the source when the plugin lives below the repository root.
Omitting `--ref` tracks the remote's default branch. A branch passed with `--ref` also tracks;
tags and commits stay pinned. `status` fetches tracked refs and reports the installed and available
commits. Removing a Git source deletes Paseo's managed checkout.
commits. `update` checks out a new version, validates its manifest, compiles both bundles, and starts
it before changing the configured path. A compilation or startup failure restores the running
version. Removing a Git source deletes Paseo's managed checkout.
### Declare Git preparation
Most plugins should omit `build`. Use it only when the staged checkout must install a dependency
that Paseo does not provide, generate source or assets, or perform another required preparation
step:
```json
{
"id": "review",
"build": [
["npm", "ci"],
["npm", "run", "build"]
]
}
```
`build` is an optional list of argv arrays. Each array must contain at least one non-empty string;
shell command strings are rejected. Paseo starts the executable directly, without a shell, from the
plugin directory in the staged checkout. It never detects lockfiles or chooses a package manager.
On install and every update, Paseo resolves the exact Git revision and manifest, runs the declared
commands, then validates, compiles, and activates the candidate. It logs each argv command and its
output in the daemon log. If a command fails, the error includes its output, Paseo discards the
candidate, and the existing installed and running version stays untouched. On a remote daemon, all
of this happens on the remote daemon host.
Git installation does not run a package manager or install script. A distributable source plugin
uses Paseo's host-provided modules or commits any other bundled source it needs. Native React Native
dependencies work only when the Paseo app already ships the native module.
Server contributions can write to stdout and stderr with normal Node logging. Paseo adds `[paseo]`
entries for loading, ready, stopping, and stopped transitions. Compilation and load failures are
recorded as stderr entries before a subprocess exists. Inspect the recent in-memory
tail from the host plugin settings or with `paseo plugin logs <id>`. Git preparation commands are
recorded in `$PASEO_HOME/daemon.log` before a plugin exists, rather than the plugin log tail. Reload, disable, and process
tail from the host plugin settings or with `paseo plugin logs <id>`. Reload, disable, and process
failure retain the tail; removing the plugin clears it. Daemon restarts do not retain the tail, but
structured copies remain in `$PASEO_HOME/daemon.log`. Plugin output can contain secrets, so do not
log credentials or tokens.
@@ -224,10 +201,9 @@ when moved between hosts. Explorer configuration can create workspace-context pa
existing agent-context instances, but it cannot create an agent panel without an agent-aware command.
Command Center callbacks use the selected host's existing `PaseoApi` for normal Paseo operations.
They use typed plugin RPC only for plugin-specific backend work. Surface and panel props expose
optional client-owned agent and workspace navigation; its absence is the compatibility gate for
older clients. Other navigation remains limited to registered global surfaces and workspace panels.
Plugins do not receive Expo Router or workspace-layout store access.
They use typed plugin RPC only for plugin-specific backend work. Navigation is limited to the
plugin's registered global surfaces and workspace panels; plugins do not receive Expo Router or
workspace-layout store access.
## Contribute composer pills
+3 -7
View File
@@ -67,8 +67,6 @@ Pi model records expose input capabilities through `model.input`. Only send raw
Pi MCP support depends on the open-source `pi-mcp-adapter` extension being loaded for the agent cwd. Probe with Pi RPC `get_commands`; the adapter registers an extension command named `mcp` (often with `sourceInfo.source` containing `pi-mcp-adapter`). When Paseo injects MCP servers into Pi, write a per-agent MCP config and pass it with `--mcp-config` instead of modifying user or project MCP files. Because that flag replaces the Pi global config layer, preserve the existing `<Pi agent dir>/mcp.json` in the generated file before overlaying injected servers. For local HTTP servers such as Paseo's own `/mcp/agents` endpoint, explicitly disable adapter OAuth (`auth: false`, `oauth: false`) in the generated config.
Pi control-plane RPCs wait 60 seconds by default. Override `params.rpcTimeoutMs` when extension or MCP startup on a slow host needs more time. Timeout errors name the pending RPC phase and report both elapsed time and the configured deadline. This setting does not govern long-running Pi compaction or Pi extension UI results. See [OMP profiles and Pi-compatible forks](custom-providers.md#omp-profiles-and-pi-compatible-forks) for OMP startup and RPC deadlines.
Pi import discovery reads Pi's persisted JSONL session files because Pi RPC does not expose a recent-session listing command. Resume and full history hydration still go through `pi --mode rpc` using the session file as `nativeHandle`.
OMP is a first-class built-in provider, disabled by default. Its launch contract, typed runtime, agent/session behavior, history, permissions, imports, and test fake live under `providers/omp/`; only the provider-neutral JSONL child-process transport is shared with Pi. It launches `omp --mode rpc-ui`, uses OMP's `get_available_commands` RPC for slash-command discovery, bridges OMP `rpc-ui` approval dialogs into Paseo permissions, and imports terminal-started sessions from `~/.omp/agent/sessions` when enabled.
@@ -77,17 +75,15 @@ OMP supports native Paseo host tools. The adapter registers the full caller-scop
Pi RPC extension UI dialog requests (`select`, `input`, `editor`, `confirm`) are bridged into Paseo question permissions and answered with `extension_ui_response`. Pi extensions such as `ask_user` may chain dialogs: for example, a `select` can be followed by an optional-comment `input`. When an `ask_user` tool call declares `allowComment: true`, Paseo presents the selection and optional comment as one question permission, answers Pi's initial `select` immediately, then auto-answers the follow-up optional `input` with the comment the user already supplied (or an empty string). Preserve placeholders and optional/skip semantics for standalone optional inputs so the app can still distinguish "skip this optional input" from "cancel the whole dialog." Fire-and-forget extension UI requests such as notifications are intentionally ignored by the provider adapter unless Paseo grows first-class UI for them.
OpenCode 1 keeps MCP and process environment outside the session boundary. Paseo shares one OpenCode server for ordinary agents and installs a daemon-owned plugin through `OPENCODE_CONFIG_CONTENT`. The plugin reads the exact agent environment and caller-scoped Paseo tool catalog from the daemon's private loopback bridge for each OpenCode session. Bridge context lives only in daemon memory and is removed when the Paseo session closes. The content-addressed plugin artifact contains no session data or secrets.
An agent with custom environment variables or user-configured MCP servers gets a dedicated OpenCode server. Keep that isolation until OpenCode exposes those values as session-owned configuration. Configure custom MCP with `mcp.add`; do not follow it with `mcp.connect`, which only toggles config-backed servers.
OpenCode MCP injection is dynamic and session-scoped. Call OpenCode's `mcp.add` endpoint with the MCP server config and do not follow it with `mcp.connect`; `connect` only toggles MCP servers already present in OpenCode's own config. New OpenCode versions return `McpServerNotFoundError`/404 for `connect` after a dynamic add because the server is not config-backed, while older versions silently swallowed the same missing-config path.
OpenCode owns user message IDs. Do not pass Paseo-generated IDs to OpenCode prompt APIs; let OpenCode create `msg*` IDs and record the user timeline item from the `message.updated` event.
`AgentManager` owns the one canonical timeline row for a foreground prompt carrying a Paseo `clientMessageId`. It records that row when `startTurn` accepts, with the wire `messageId` set to the same value. Provider adapters still emit their native user-message echo with the same `clientMessageId` when available; the manager records its provider identity on the internal row without changing or redispatching the wire item. If an adapter emits the echo before `startTurn` resolves, the manager records the provider identity with the row at acceptance. Provider adapters continue to own externally initiated user rows that have no Paseo client identity. Do not perform global transcript text dedupe.
Active-turn steering is an optional `AgentSession.steerActiveTurn` operation. The manager owns admission against its exact foreground turn, canonical user-message creation, echo reconciliation, and falls back to the normal interrupt-and-replace path only when the adapter reports `unavailable`. An adapter error leaves the steer's fate ambiguous and must surface without an interrupt or retry. Codex calls `turn/steer` with the native expected turn and Paseo client user-message ID. Claude pushes an admitted steer into the exact active SDK query input; isolated control commands remain unavailable. OpenCode calls `session/prompt_async` with an OpenCode-generated message ID; the server queues the prompt while busy and the next LLM call in the same Paseo turn includes it. Pi sends its native `steer` RPC, which queues the message for delivery after the in-flight assistant turn's tool calls. Slash-command inputs report `unavailable` because pi rejects extension commands on the steer path, and echo identity is correlated by message text because pi's steer RPC takes no message ID. A missing session reports `unavailable` and uses the normal interrupt fallback.
Active-turn steering is an optional `AgentSession.steerActiveTurn` operation. The manager owns admission against its exact foreground turn, canonical user-message creation, echo reconciliation, and falls back to the normal interrupt-and-replace path only when the adapter reports `unavailable`. An adapter error leaves the steer's fate ambiguous and must surface without an interrupt or retry. Codex calls `turn/steer` with the native expected turn and Paseo client user-message ID. Claude pushes an admitted steer into the exact active SDK query input; isolated control commands remain unavailable. OpenCode calls `session/prompt_async` with an OpenCode-generated message ID; the server queues the prompt while busy and the next LLM call in the same Paseo turn includes it. A missing session reports `unavailable` and uses the normal interrupt fallback.
A steering adapter also owes its interrupt: stopping a turn must discard the steers the provider has not read yet, or one of them resumes the turn the user just stopped. Codex clears pending input when it aborts a turn; Claude does not, so its adapter cancels the SDK messages it queued before calling `query.interrupt()`. Pi requires `clear_queue` before `abort`; older binaries without that RPC retain their native queue behavior until the pi compatibility floor reaches 0.84.4.
A steering adapter also owes its interrupt: stopping a turn must discard the steers the provider has not read yet, or one of them resumes the turn the user just stopped. Codex clears pending input when it aborts a turn; Claude does not, so its adapter cancels the SDK messages it queued before calling `query.interrupt()`.
`SteerActiveTurnOptions.clearPendingPermissions` makes permission release part of the provider contract. A provider that accepts such a steer queues it first, denies permissions blocking its delivery, and stops once the steer is read. Steers without the flag leave permissions open. A denied plan remains in the timeline because the pending card was the only other copy of its text.
@@ -1,11 +0,0 @@
Changed
- Changed the project license to Apache-2.0
- Changed Cmd/Ctrl+E to toggle Explorer visibility without selecting a view
- Changed the default mobile content text size from 15px to 16px
Added
- Added plugin installation and updates directly from Git repositories
- Added plugin-defined timeline transformations and rendering
- Added SSH connections to existing remote daemons from Desktop and CLI
Full notes: https://paseo.sh/changelog
@@ -1,11 +0,0 @@
Changed
- Changed the project license to Apache-2.0
- Changed Cmd/Ctrl+E to toggle Explorer visibility without selecting a view
- Changed the default mobile content text size from 15px to 16px
Added
- Added plugin installation and updates directly from Git repositories
- Added plugin-defined timeline transformations and rendering
- Added SSH connections to existing remote daemons from Desktop and CLI
Full notes: https://paseo.sh/changelog
@@ -1,11 +0,0 @@
Changed
- Changed the project license to Apache-2.0
- Changed Cmd/Ctrl+E to toggle Explorer visibility without selecting a view
- Changed the default mobile content text size from 15px to 16px
Added
- Added plugin installation and updates directly from Git repositories
- Added plugin-defined timeline transformations and rendering
- Added SSH connections to existing remote daemons from Desktop and CLI
Full notes: https://paseo.sh/changelog
@@ -1,11 +0,0 @@
Changed
- Changed the project license to Apache-2.0
- Changed Cmd/Ctrl+E to toggle Explorer visibility without selecting a view
- Changed the default mobile content text size from 15px to 16px
Added
- Added plugin installation and updates directly from Git repositories
- Added plugin-defined timeline transformations and rendering
- Added SSH connections to existing remote daemons from Desktop and CLI
Full notes: https://paseo.sh/changelog
+1 -1
View File
@@ -1 +1 @@
sha256-HFYBrCP62r6ZofazBIGSOnMhk8IIEmv+TFJMpqTIJQ8=
sha256-zn0UJm7RPR5mlCvKTddcq0bIugrp6VcRBPdwJX8kJIg=
+27 -27
View File
@@ -1,12 +1,12 @@
{
"name": "paseo",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "paseo",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"hasInstallScript": true,
"license": "Apache-2.0",
"workspaces": [
@@ -36298,7 +36298,7 @@
},
"packages/app": {
"name": "@getpaseo/app",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"@codemirror/commands": "6.10.4",
"@codemirror/language": "6.12.4",
@@ -37363,12 +37363,12 @@
},
"packages/cli": {
"name": "@getpaseo/cli",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"@clack/prompts": "^1.0.0",
"@getpaseo/client": "0.7.0",
"@getpaseo/protocol": "0.7.0",
"@getpaseo/server": "0.7.0",
"@getpaseo/client": "0.7.0-beta.2",
"@getpaseo/protocol": "0.7.0-beta.2",
"@getpaseo/server": "0.7.0-beta.2",
"chalk": "^5.3.0",
"commander": "^12.0.0",
"mime-types": "^2.1.35",
@@ -37615,10 +37615,10 @@
},
"packages/client": {
"name": "@getpaseo/client",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"@getpaseo/protocol": "0.7.0",
"@getpaseo/relay": "0.7.0",
"@getpaseo/protocol": "0.7.0-beta.2",
"@getpaseo/relay": "0.7.0-beta.2",
"zod": "^4.4.3"
},
"devDependencies": {
@@ -37629,7 +37629,7 @@
},
"packages/desktop": {
"name": "@getpaseo/desktop",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"license": "Apache-2.0",
"dependencies": {
"@getpaseo/cli": "*",
@@ -37872,7 +37872,7 @@
},
"packages/expo-two-way-audio": {
"name": "@getpaseo/expo-two-way-audio",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"license": "MIT",
"devDependencies": {
"@types/jest": "^29.5.14",
@@ -38768,7 +38768,7 @@
},
"packages/highlight": {
"name": "@getpaseo/highlight",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"@codemirror/language": "6.12.4",
"@codemirror/legacy-modes": "^6.5.3",
@@ -38797,13 +38797,13 @@
},
"packages/plugin": {
"name": "@getpaseo/plugin",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"use-sync-external-store": "^1.6.0"
},
"devDependencies": {
"@getpaseo/client": "0.7.0",
"@getpaseo/protocol": "0.7.0",
"@getpaseo/client": "0.7.0-beta.2",
"@getpaseo/protocol": "0.7.0-beta.2",
"@types/node": "^20.9.0",
"@types/react": "~19.2.0",
"react": "19.1.0",
@@ -38812,15 +38812,15 @@
"zod": "^4.4.3"
},
"peerDependencies": {
"@getpaseo/client": "0.7.0",
"@getpaseo/protocol": "0.7.0",
"@getpaseo/client": "0.7.0-beta.2",
"@getpaseo/protocol": "0.7.0-beta.2",
"react": "19.1.0",
"zod": "^4.4.3"
}
},
"packages/protocol": {
"name": "@getpaseo/protocol",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"zod": "^4.4.3"
},
@@ -38833,7 +38833,7 @@
},
"packages/relay": {
"name": "@getpaseo/relay",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"base64-js": "^1.5.1",
"tweetnacl": "^1.0.3",
@@ -39051,17 +39051,17 @@
},
"packages/server": {
"name": "@getpaseo/server",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"@agentclientprotocol/sdk": "^0.17.1",
"@anthropic-ai/claude-agent-sdk": "0.3.246",
"@anthropic-ai/sdk": "^0.104.2",
"@babel/parser": "^7.29.8",
"@getpaseo/client": "0.7.0",
"@getpaseo/highlight": "0.7.0",
"@getpaseo/plugin": "0.7.0",
"@getpaseo/protocol": "0.7.0",
"@getpaseo/relay": "0.7.0",
"@getpaseo/client": "0.7.0-beta.2",
"@getpaseo/highlight": "0.7.0-beta.2",
"@getpaseo/plugin": "0.7.0-beta.2",
"@getpaseo/protocol": "0.7.0-beta.2",
"@getpaseo/relay": "0.7.0-beta.2",
"@isaacs/ttlcache": "^2.1.4",
"@modelcontextprotocol/sdk": "1.29.0",
"@opencode-ai/sdk": "1.14.46",
@@ -39985,7 +39985,7 @@
},
"packages/website": {
"name": "@getpaseo/website",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"dependencies": {
"@cloudflare/vite-plugin": "^1.29.1",
"@cloudflare/workers-types": "^4.20260317.1",
+1 -2
View File
@@ -1,6 +1,6 @@
{
"name": "paseo",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"private": true,
"description": "Paseo: voice-controlled development environment for local AI coding agents",
"keywords": [
@@ -41,7 +41,6 @@
"dev:server:raw": "npm run dev --workspace=@getpaseo/server",
"dev:app": "cross-env PASEO_LISTEN=127.0.0.1:6768 EXPO_PORT=8081 ./scripts/dev-app.sh",
"test:e2e:mobile": "./scripts/test-mobile-agent-device.sh",
"test:e2e:composer-keyboard:android": "./packages/app/e2e/mobile/composer-keyboard/android.sh",
"dev:website": "npm run dev --workspace=@getpaseo/website",
"postinstall": "node scripts/postinstall-patches.mjs",
"prepare": "lefthook install --force",
@@ -23,7 +23,7 @@ async function completeSubmittedTurn(
const finish = await agent.client.waitForFinish(agent.agentId, 30_000);
expect(finish.status).toBe("idle");
await expect(page.getByText("(end of synthetic stream)", { exact: true }).last()).toBeVisible();
await expect(page.getByText("(end of synthetic stream)", { exact: true })).toBeVisible();
await expect(userMessage).toHaveAttribute("aria-busy", "false");
return userMessage;
}
@@ -40,7 +40,7 @@ async function expectTurnCompletesNormally(
): Promise<void> {
const finish = await agent.client.waitForFinish(agent.agentId, 30_000);
expect(finish.status).toBe("idle");
await expect(page.getByText("(end of synthetic stream)", { exact: true }).last()).toBeVisible();
await expect(page.getByText("(end of synthetic stream)", { exact: true })).toBeVisible();
await expectAgentIdle(page);
}
@@ -39,10 +39,7 @@ import {
expectResumeOverflowFallsBackToOneTail,
rememberTimelineRequestCounts,
} from "../support/helpers/timeline-resume";
import {
waitForWorkspaceInSidebar,
workspaceDeckEntryLocator,
} from "../support/helpers/workspace-ui";
import { workspaceDeckEntryLocator } from "../support/helpers/workspace-ui";
import { expectInFlightForkAvailable } from "../support/helpers/assistant-fork";
import {
scrollTimelineToNewestLoadedEdge,
@@ -471,10 +468,6 @@ async function expectHiddenStreamingSubmissionOrderAfterWorkspaceEviction(
await target.client.waitForFinish(target.agentId, 30_000);
const requestsBeforeReturn = rememberTimelineRequestCounts(gate);
await waitForWorkspaceInSidebar(page, {
serverId: getServerId(),
workspaceId: target.workspaceId,
});
await openAgentRoute(page, target);
await expectComposerVisible(page);
await subscriptions.waitForSubscribedAgents([target.agentId]);
@@ -14,7 +14,6 @@ import {
switchAwayAndBackWithoutImageInstability,
userPagesUntilAssistantImageRenders,
} from "../support/helpers/assistant-images";
import { expectAgentReadyToInterrupt } from "../support/helpers/agent-stream";
import { seedWorkspace, type SeededWorkspace } from "../support/helpers/seed-client";
const test = base.extend<{ imageWorkspace: SeededWorkspace }>({
@@ -46,56 +45,6 @@ test("switching between settled agent tabs keeps a real assistant PNG rendered",
await switchAwayAndBackWithoutImageInstability(page, { image, imageAgent, otherAgent });
});
test("opens a timeline image in a zoomable lightbox", async ({
imageWorkspace: workspace,
page,
}) => {
test.setTimeout(120_000);
const image = await createSmallAssistantPng(workspace, {
alt: "Zoomable timeline image",
fileName: "zoomable-timeline-image.png",
});
const imageAgent = await createSettledMockAgent(workspace, "Zoomable image timeline");
await emitSettledAssistantImage(workspace.client, imageAgent, image);
await openAssistantImageTimeline(page, imageAgent);
await expectAssistantImageRendered(page, image);
await page.getByRole("button", { name: "Open image attachment" }).click();
const lightboxImage = page.getByTestId("attachment-lightbox-image");
const canvas = page.getByTestId("attachment-lightbox-canvas");
await expect(lightboxImage).toBeVisible();
await canvas.hover();
const transformedContent = canvas.locator(":scope > div").first();
const initialBox = await transformedContent.boundingBox();
const canvasBox = await canvas.boundingBox();
expect(initialBox).not.toBeNull();
expect(canvasBox).not.toBeNull();
expect(initialBox!.width).toBeLessThan(canvasBox!.width);
const zoomIn = page.getByRole("button", { name: "Zoom in", exact: true });
await zoomIn.click();
await zoomIn.click();
await zoomIn.click();
await zoomIn.click();
await expect
.poll(async () => (await transformedContent.boundingBox())?.width ?? 0)
.toBeGreaterThan(canvasBox!.width);
await canvas.dblclick({ position: { x: canvasBox!.width / 2, y: canvasBox!.height / 2 } });
await expect
.poll(async () => Math.round((await transformedContent.boundingBox())?.width ?? 0))
.toBe(Math.round(initialBox!.width));
await workspace.client.sendAgentMessage(
imageAgent.id,
"Stay running while the assistant image lightbox is closed.",
);
await expectAgentReadyToInterrupt(page);
await page.keyboard.press("Escape");
await expect(lightboxImage).toHaveCount(0);
await expectAgentReadyToInterrupt(page);
});
test("reloading a timeline anchors near-tail assistant image growth", async ({
imageWorkspace: workspace,
page,
@@ -10,7 +10,6 @@ import {
archiveAgentFromSessions,
clickSessionRow,
createIdleAgent,
expectArchivedAgentFocused,
expectSessionRowArchived,
expectSessionRowVisible,
expectWorkspaceArchiveOutcome,
@@ -22,7 +21,6 @@ import {
resetSeededPageState,
reloadWorkspace,
} from "../support/helpers/archive-tab";
import { expectAgentTabActive } from "../support/helpers/launcher";
test.describe("Archive tab reconciliation", () => {
let client: Awaited<ReturnType<typeof connectSeedClient>>;
@@ -146,8 +144,6 @@ test.describe("Archive tab reconciliation", () => {
await clickSessionRow(page, archived.title);
await expectArchivedAgentFocused(page, archived.id);
await expectAgentTabActive(page, archived.id);
expect(await fetchAgentArchivedAt(client, archived.id)).toBe(archivedAt);
await expect(page).toHaveURL(buildHostWorkspaceRoute(getServerId(), archived.workspaceId), {
@@ -1,32 +0,0 @@
import { expect, test } from "../support/fixtures";
import { getUtf8ByteLength } from "../../src/components/assistant-message-render-limit";
import { openAgentRoute, seedMockAgentWorkspace } from "../support/helpers/mock-agent";
test("caps a newline-heavy assistant message before rendering markdown", async ({ page }) => {
const hiddenTail = "HIDDEN_OVERSIZED_MESSAGE_TAIL";
const response = `${"x\n".repeat(16_000)}${hiddenTail}`;
const agent = await seedMockAgentWorkspace({
repoPrefix: "assistant-message-render-limit-",
title: "Assistant message render limit",
initialPrompt: "Render the configured oversized response.",
featureValues: { mockAssistantResponse: response },
});
try {
await agent.client.waitForFinish(agent.agentId, 30_000);
await openAgentRoute(page, agent);
const assistantMessage = page.getByTestId("assistant-message").last();
await expect(assistantMessage).toBeVisible({ timeout: 30_000 });
await expect(assistantMessage).not.toContainText(hiddenTail);
const notice = assistantMessage.getByTestId("assistant-message-capped-notice");
await expect(notice).toBeVisible();
await expect(notice).toHaveText(
`This message was capped (${getUtf8ByteLength(response)} bytes).`,
);
await expect(notice).toHaveCSS("font-style", "italic");
} finally {
await agent.cleanup();
}
});
@@ -1,29 +0,0 @@
import { test } from "../support/fixtures";
import {
expectComposerDraft,
expectComposerFocused,
expectComposerVisible,
submitMessage,
typeIntoFocusedComposer,
} from "../support/helpers/composer";
import { openAgentRoute, seedMockAgentWorkspace } from "../support/helpers/mock-agent";
test("submitting a message leaves the composer ready for the next message", async ({ page }) => {
const agent = await seedMockAgentWorkspace({
repoPrefix: "composer-focus-",
title: "Composer focus",
});
try {
await openAgentRoute(page, agent);
await expectComposerVisible(page);
await submitMessage(page, "First message");
await expectComposerFocused(page);
await typeIntoFocusedComposer(page, "Second message");
await expectComposerDraft(page, "Second message");
} finally {
await agent.cleanup();
}
});
@@ -538,16 +538,6 @@ test.describe("CodeMirror workspace file editing", () => {
await openWorkspaceFile(page, "pixel.png");
const image = visibleFilePane.locator("img");
await expect(image).toBeVisible();
const imageCanvas = page.getByTestId("image-file-preview-canvas");
await expect(imageCanvas).toBeVisible();
await imageCanvas.hover();
const transformedContent = imageCanvas.locator(":scope > div").first();
const fittedImageBox = await transformedContent.boundingBox();
expect(fittedImageBox).not.toBeNull();
await page.getByRole("button", { name: "Zoom in", exact: true }).click();
await expect
.poll(async () => (await transformedContent.boundingBox())?.width ?? 0)
.toBeGreaterThan(fittedImageBox!.width * 1.2);
const initialSource = await image.getAttribute("src");
await writeFile(imagePath, BLUE_PIXEL);
await expect.poll(() => image.getAttribute("src")).not.toBe(initialSource);
@@ -1,124 +0,0 @@
import { mkdirSync, mkdtempSync, realpathSync } from "node:fs";
import { tmpdir } from "node:os";
import path from "node:path";
import type { Locator, Page, TestInfo } from "@playwright/test";
import { expect, test } from "../support/fixtures";
import {
cleanupRewindFlow,
launchAgent,
sendMessage,
type AgentHandle,
} from "../support/helpers/rewind-flow";
const GREETING = "Say hello back.";
test.use({ e2eInjectPaseoTools: true });
function verificationPrompt(workspacePath: string): string {
return [
"Use Paseo tools to perform this exact UI verification.",
"Do not edit files or run shell commands. Every prompt below is intentionally non-actionable.",
`1. Create a local workspace at ${workspacePath} titled "Presentation QA workspace".`,
`2. In that workspace, create a codex/gpt-5.4-mini agent titled "Greeting child" with the initial prompt "${GREETING}".`,
`3. Create a schedule named "Greeting schedule" with prompt "${GREETING}", cron "0 0 1 1 *", timezone "Europe/Berlin", provider "codex/gpt-5.4-mini", cwd ${workspacePath}, maxRuns 1, and expiresIn "1h". Delete that schedule using its returned id.`,
`4. Create a heartbeat named "Greeting heartbeat" with prompt "${GREETING}", cron "0 0 1 1 *", timezone "Europe/Berlin", maxRuns 1, and expiresIn "1h". Delete that heartbeat using its returned id.`,
`5. After the child agent finishes, send it the follow-up prompt "${GREETING}" synchronously.`,
"6. Archive the workspace from step 1.",
"7. Reply with exactly TOOL_CALL_QA_DONE.",
"Use each named Paseo tool exactly once except for the matching schedule and heartbeat deletion tools.",
].join(" ");
}
async function expandedToolCall(page: Page, label: string): Promise<Locator> {
const badge = page.getByTestId("tool-call-badge").filter({ hasText: label }).last();
await expect(badge).toBeVisible({ timeout: 30_000 });
await badge.scrollIntoViewIfNeeded();
await badge.click();
return badge;
}
async function captureToolCall(
page: Page,
testInfo: TestInfo,
input: { label: string; artifact: string; expectedText: Array<string | RegExp> },
): Promise<void> {
const badge = await expandedToolCall(page, input.label);
for (const text of input.expectedText) {
await expect(badge).toContainText(text);
}
const screenshot = testInfo.outputPath(`${input.artifact}.png`);
await badge.screenshot({ path: screenshot });
await testInfo.attach(input.artifact, { path: screenshot, contentType: "image/png" });
await badge.click();
}
async function runPresentationJourney(handle: AgentHandle, workspacePath: string): Promise<void> {
await sendMessage(handle, verificationPrompt(workspacePath));
await expect(
handle.page.getByTestId("assistant-message").filter({ hasText: "TOOL_CALL_QA_DONE" }).last(),
).toBeVisible({ timeout: 30_000 });
}
test.describe("real Codex Paseo tool-call presentation", () => {
test.setTimeout(600_000);
test("renders owned tool inputs and results as readable text", async ({ page }, testInfo) => {
const cwd = realpathSync(mkdtempSync(path.join(tmpdir(), "paseo-tool-call-presentation-")));
const childWorkspacePath = path.join(cwd, "presentation-workspace");
mkdirSync(childWorkspacePath);
let handle: AgentHandle | undefined;
try {
handle = await launchAgent({ page, provider: "codex", cwd, mode: "full-access" });
await runPresentationJourney(handle, childWorkspacePath);
await page.setViewportSize({ width: 1280, height: 1600 });
await captureToolCall(page, testInfo, {
label: "Create workspace",
artifact: "create-workspace-presentation",
expectedText: ["Details", "Presentation QA workspace", childWorkspacePath, "local"],
});
await captureToolCall(page, testInfo, {
label: "Create agent",
artifact: "create-agent-prompt-presentation",
expectedText: ["Prompt", GREETING, "Greeting child", "codex/gpt-5.4-mini", "Result"],
});
await captureToolCall(page, testInfo, {
label: "Send agent prompt",
artifact: "send-prompt-presentation",
expectedText: ["Prompt", GREETING, "Agent", "Result"],
});
await captureToolCall(page, testInfo, {
label: "Create schedule",
artifact: "schedule-presentation",
expectedText: [
"Prompt",
GREETING,
"0 0 1 1 *",
"Europe/Berlin",
"Greeting schedule",
"Result",
],
});
await captureToolCall(page, testInfo, {
label: "Create heartbeat",
artifact: "heartbeat-presentation",
expectedText: [
"Prompt",
GREETING,
"0 0 1 1 *",
"Europe/Berlin",
"Greeting heartbeat",
"Result",
],
});
await captureToolCall(page, testInfo, {
label: "Archive workspace",
artifact: "archive-workspace-presentation",
expectedText: ["Details", "Workspace", "Result", "Removed directory"],
});
} finally {
await cleanupRewindFlow({ handle, cwd });
}
});
});
@@ -29,9 +29,9 @@ function isSettledWorkspaceUrl(url: URL): boolean {
return url.pathname.includes("/workspace/") && !url.searchParams.has("open");
}
function pluginSource(input: { workspaceId: string; agentId: string }): string {
function pluginSource(): string {
return `import React, { useRef } from "react";
import { Pressable, Text, View } from "react-native";
import { Text, View } from "react-native";
import { Icon, useAgent, useWorkspace } from "@getpaseo/plugin";
import { defineRpc } from "@getpaseo/plugin/server";
import { z } from "zod";
@@ -55,14 +55,8 @@ function AgentPanel({ workspaceId, agentId, host, layout }) {
return <View><Text>Agent bridge {agent?.id}</Text><Text>Workspace {workspace?.id}</Text><Text>Host {host.id}</Text><Text>Layout {layout.compact ? "compact" : "wide"}</Text></View>;
}
function DirectCollisionSurface({ navigation }) {
return <View>
<Text>Direct collision surface</Text>
{navigation ? <>
<Pressable accessibilityRole="button" onPress={() => navigation.openWorkspace({ workspaceId: ${JSON.stringify(input.workspaceId)} })}><Text>Open workspace from plugin</Text></Pressable>
<Pressable accessibilityRole="button" onPress={() => navigation.openAgent({ agentId: ${JSON.stringify(input.agentId)} })}><Text>Open agent from plugin</Text></Pressable>
</> : null}
</View>;
function DirectCollisionSurface() {
return <View><Text>Direct collision surface</Text></View>;
}
function SidebarCollisionSurface() {
@@ -184,10 +178,7 @@ test.describe("plugin workspace panels and Command Center", () => {
port: secondaryDaemon.port,
});
await writeFile(path.join(directory, "paseo-plugin.json"), JSON.stringify({ id: PLUGIN_ID }));
await writeFile(
path.join(directory, "index.tsx"),
pluginSource({ workspaceId: primary.workspaceId, agentId: "missing-agent" }),
);
await writeFile(path.join(directory, "index.tsx"), pluginSource());
try {
await primaryClient.patchDaemonConfig({ pluginsEnabled: true });
@@ -248,38 +239,6 @@ test.describe("plugin workspace panels and Command Center", () => {
await page.getByTestId("plugin-surface-close").click();
});
await test.step("surface navigation opens host-owned workspace and agent routes", async () => {
await runCommand(page, "Open direct collision surface");
await page.getByRole("button", { name: "Open workspace from plugin", exact: true }).click();
await page.waitForURL(isSettledWorkspaceUrl);
await expect(page.getByTestId("workspace-header-title")).toBeVisible();
const agent = await primary.client.createAgent({
provider: "mock",
cwd: primary.repoPath,
workspaceId: primary.workspaceId,
title: "Plugin navigation agent",
model: "ten-second-stream",
modeId: "load-test",
});
const navigationAgentId = agent.id;
await writeFile(
path.join(directory, "index.tsx"),
pluginSource({ workspaceId: primary.workspaceId, agentId: navigationAgentId }),
);
await primaryClient.reloadPlugin(PLUGIN_ID);
await runCommand(page, "Open direct collision surface");
await page.getByRole("button", { name: "Open agent from plugin", exact: true }).click();
await page.waitForURL(isSettledWorkspaceUrl);
await expect(
page
.getByTestId(`workspace-tab-agent_${navigationAgentId}`)
.filter({ visible: true })
.first(),
).toBeVisible();
});
await test.step("switching hosts removes commands from an uninstalled host", async () => {
await switchWorkspaceViaSidebar({
page,
+15 -10
View File
@@ -3,8 +3,8 @@ import {
openPrPane,
expectPrPaneTitle,
expectPrPaneState,
expectPrPaneChecks,
expectPrPaneActivity,
expectPrPaneCheckSummary,
expectPrPaneActivityCount,
} from "../support/helpers/pr-pane";
import { gotoWorkspace } from "../support/helpers/launcher";
import {
@@ -50,6 +50,7 @@ test.describe("PR pane", () => {
],
},
{ title: "PR with reviews", state: "open", commentCount: 3 },
{ title: "PR with no checks", state: "open" },
],
});
@@ -101,21 +102,25 @@ test.describe("PR pane", () => {
await expectPrPaneTitle(page, "Work in progress");
});
test("renders seeded checks in their success, failure, and pending groups", async ({ page }) => {
test("renders check pills with correct success/failure/pending counts", async ({ page }) => {
await gotoWorkspace(page, workspaceByTitle.get("PR with mixed checks")!);
await openPrPane(page);
await expectPrPaneChecks(page, {
success: ["build-1", "build-2"],
failure: ["deploy"],
pending: ["security"],
});
await expectPrPaneCheckSummary(page, { success: 2, failure: 1, pending: 1 });
});
test("renders every seeded activity comment", async ({ page }) => {
test("renders activity rows with correct count", async ({ page }) => {
await gotoWorkspace(page, workspaceByTitle.get("PR with reviews")!);
await openPrPane(page);
await expectPrPaneActivity(page, ["Test comment 1", "Test comment 2", "Test comment 3"]);
await expectPrPaneActivityCount(page, 3);
});
test("renders gracefully with zero checks", async ({ page }) => {
await gotoWorkspace(page, workspaceByTitle.get("PR with no checks")!);
await openPrPane(page);
await expectPrPaneCheckSummary(page, { success: 0, failure: 0, pending: 0 });
await expectPrPaneTitle(page, "PR with no checks");
});
});
@@ -43,6 +43,7 @@ const cases: ProviderSubagentCase[] = [
sentinel: "OPENCODE_CHILD_SENTINEL",
expectedName: "Verify OpenCode descriptor",
expectedSubtitle: /explore · gpt-5\.4(?: · [^\n·]+)? · \d+(?:\.\d+)?k? tokens/i,
expectsUserMessage: false,
providerConfig: { model: "openai/gpt-5.4" },
prompt:
'Use the task tool exactly once with description "Verify OpenCode descriptor" and the explore subagent. Ask it to reply with exactly OPENCODE_CHILD_SENTINEL and do nothing else. Wait for it, then reply ROOT_DONE.',
@@ -13,6 +13,7 @@ import {
expectTurnCopyButton,
} from "../support/helpers/agent-stream";
import {
expectReconnectingToastDebounced,
expectReconnectingToastGone,
expectReconnectingToastVisible,
} from "../support/helpers/workspace-ui";
@@ -180,17 +181,13 @@ test.describe("Viewed agent timelines", () => {
"true",
);
await gate.drop();
await gate.waitForBlockedConnection();
await expectReconnectingToastDebounced(page);
await expectReconnectingToastVisible(page);
await commitMessage(scenario, scenario.firstAgentId, "Committed while the chat reconnects.");
await expect(
page.getByText("Committed while the chat reconnects.", { exact: true }),
).toHaveCount(0);
// Hold the first authoritative catch-up response so the assertion observes
// the reconnect boundary instead of racing a socket that has not reopened yet.
gate.holdNextServerMessage("fetch_agent_timeline_response");
gate.restore();
await gate.waitForHeldServerMessage("fetch_agent_timeline_response");
gate.releaseHeldServerMessage("fetch_agent_timeline_response");
await expectReconnectingToastGone(page);
const recoveredMessage = page.getByText("Committed while the chat reconnects.", {
exact: true,
@@ -212,7 +209,6 @@ test.describe("Viewed agent timelines", () => {
await expect(page.getByRole("textbox", { name: "Message agent..." })).toBeVisible();
await selectAgent(page, "First viewed chat");
await gate.drop();
await gate.waitForBlockedConnection();
await expectReconnectingToastVisible(page);
await selectAgent(page, "Second viewed chat");
@@ -6,7 +6,7 @@ import {
import { expect, test, type Page } from "../support/fixtures";
import { gotoAppShell, openSettings } from "../support/helpers/app";
import {
createMockIdleAgent,
createIdleAgent,
expectWorkspaceTabHidden,
expectWorkspaceTabVisible,
openWorkspaceWithAgents,
@@ -159,7 +159,7 @@ test.describe("Workspace navigation regression", () => {
const workspace = await seedWorkspace({ repoPrefix: "workspace-reconnect-" });
try {
const agent = await createMockIdleAgent(workspace.client, {
const agent = await createIdleAgent(workspace.client, {
cwd: workspace.repoPath,
workspaceId: workspace.workspaceId,
title: `workspace-reconnect-${Date.now()}`,
@@ -180,7 +180,6 @@ test.describe("Workspace navigation regression", () => {
await expectWorkspaceTabVisible(page, agent.id);
await daemonGate.drop();
await daemonGate.waitForBlockedConnection();
await expectReconnectingToastVisible(page);
await expectWorkspaceHeader(page, {
title: workspace.workspaceName,
@@ -218,12 +217,12 @@ test.describe("Workspace navigation regression", () => {
try {
await Promise.all([
createMockIdleAgent(primaryWorkspace.client, {
createIdleAgent(primaryWorkspace.client, {
cwd: primaryWorkspace.repoPath,
workspaceId: primaryWorkspace.workspaceId,
title: "Active host agent",
}),
createMockIdleAgent(secondaryWorkspace.client, {
createIdleAgent(secondaryWorkspace.client, {
cwd: secondaryWorkspace.repoPath,
workspaceId: secondaryWorkspace.workspaceId,
title: "Inactive host agent",
@@ -320,12 +319,12 @@ test.describe("Workspace navigation regression", () => {
const secondWorkspace = await seedWorkspace({ repoPrefix: "workspace-nav-reg-b-" });
try {
const firstAgent = await createMockIdleAgent(firstWorkspace.client, {
const firstAgent = await createIdleAgent(firstWorkspace.client, {
cwd: firstWorkspace.repoPath,
workspaceId: firstWorkspace.workspaceId,
title: `workspace-nav-a-${Date.now()}`,
});
const secondAgent = await createMockIdleAgent(secondWorkspace.client, {
const secondAgent = await createIdleAgent(secondWorkspace.client, {
cwd: secondWorkspace.repoPath,
workspaceId: secondWorkspace.workspaceId,
title: `workspace-nav-b-${Date.now()}`,
@@ -1,340 +0,0 @@
#!/usr/bin/env bash
set -euo pipefail
REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../../../../.." && pwd)"
STATE_DIR="${PASEO_COMPOSER_KEYBOARD_STATE_DIR:-${REPO_ROOT}/.dev/agent-device-composer-keyboard}"
ARTIFACTS_DIR="${REPO_ROOT}/.dev/agent-device-artifacts/composer-keyboard-android"
SESSION="${PASEO_COMPOSER_KEYBOARD_SESSION:-composer-keyboard-android}"
APP_ID="${PASEO_COMPOSER_KEYBOARD_APP_ID:-sh.paseo.debug}"
DEVICE="${PASEO_COMPOSER_KEYBOARD_DEVICE:-paseo-api35}"
HELPER_IME="com.callstack.agentdevice.imehelper/.TestInputMethodService"
GBOARD_IME="com.google.android.inputmethod.latin/com.android.inputmethod.latin.LatinIME"
ASSERT="${REPO_ROOT}/packages/app/e2e/mobile/composer-keyboard/assert-composer-keyboard.mjs"
STALL_HERMES="${REPO_ROOT}/packages/app/e2e/mobile/composer-keyboard/stall-hermes.mjs"
METRO_PORT="${PASEO_MOBILE_E2E_METRO_PORT:-8082}"
DAEMON_HOST="${PASEO_COMPOSER_KEYBOARD_DAEMON_HOST:-127.0.0.1:6770}"
DAEMON_HOME="${PASEO_COMPOSER_KEYBOARD_DAEMON_HOME:-${REPO_ROOT}/.dev/composer-e2e-home}"
SERVER_ID="${PASEO_COMPOSER_KEYBOARD_SERVER_ID:-}"
MESSAGE=$'keyboard invariant line one\nline two\nline three\nline four'
LONG_MESSAGE="$(node -e 'process.stdout.write(Array.from({ length: 180 }, (_, index) => `line${index + 1}`).join(" "))')"
AGENT_TITLE="Keyboard dismiss QA $(date +%s)"
if [[ -z "${SERVER_ID}" ]]; then
if [[ ! -f "${DAEMON_HOME}/server-id" ]]; then
echo "Missing ${DAEMON_HOME}/server-id; set PASEO_COMPOSER_KEYBOARD_SERVER_ID" >&2
exit 1
fi
SERVER_ID="$(<"${DAEMON_HOME}/server-id")"
fi
ad() {
AGENT_DEVICE_STATE_DIR="${STATE_DIR}" agent-device "$@" --session "${SESSION}"
}
capture_screen() {
local output_path="$1"
ad screenshot "${output_path}" >/dev/null
}
snapshot_json() {
local output_path="$1"
ad snapshot -i --json >"${output_path}"
}
capture_ui_xml() {
local output_path="$1"
local device_path="/sdcard/paseo-composer-keyboard-window.xml"
# Android exposes one UI Automation connection at a time. Release the
# persistent agent-device snapshot helper before asking uiautomator for the
# app and IME windows; agent-device reconnects it on the next interaction.
adb shell am force-stop com.callstack.agentdevice.snapshothelper
sleep 0.2
adb shell uiautomator dump "${device_path}" >/dev/null
adb pull "${device_path}" "${output_path}" >/dev/null
}
clear_input() {
ad fill 'editable=true' "x" --settle
adb shell input keycombination 113 29
adb shell input keyevent 67
}
clear_focused_input_with_adb() {
adb shell input keycombination 113 29
adb shell input keyevent 67
}
wait_for_ime() {
local expected="$1"
local previous_top=""
local stable_count=0
for _ in $(seq 1 30); do
local window_state
window_state="$(adb shell dumpsys window)"
if [[ "${expected}" == "true" ]]; then
local ime_top
ime_top="$(printf '%s' "${window_state}" | sed -n 's/.*type=ime frame=\[0,\([0-9][0-9]*\)\].*visible=true.*/\1/p' | head -1)"
if [[ -n "${ime_top}" && "${ime_top}" -gt 0 ]]; then
if [[ "${ime_top}" == "${previous_top}" ]]; then
stable_count="$((stable_count + 1))"
else
stable_count=0
previous_top="${ime_top}"
fi
if [[ "${stable_count}" -ge 2 ]]; then
return
fi
fi
elif ! printf '%s' "${window_state}" | rg -q "type=ime .*visible=true"; then
return
fi
sleep 0.1
done
echo "IME did not become visible=${expected}" >&2
exit 1
}
ime_is_visible() {
adb shell dumpsys window | rg -q "type=ime .*visible=true"
}
open_gboard() {
local x="$1"
local y="$2"
adb shell ime set "${GBOARD_IME}" >/dev/null
if ime_is_visible; then
adb shell input keyevent BACK
wait_for_ime false
fi
adb shell input tap "${x}" "${y}"
wait_for_ime true
local keyboard_shift
keyboard_shift="$(read_keyboard_shift)"
adb shell input tap "${x}" "$((y - keyboard_shift))"
}
read_keyboard_shift() {
local ime_top
local navigation_top
ime_top="$(adb shell dumpsys window | sed -n 's/.*type=ime frame=\[0,\([0-9][0-9]*\)\].*visible=true.*/\1/p' | head -1)"
navigation_top="$(adb shell dumpsys window | sed -n 's/.*type=navigationBars frame=\[0,\([0-9][0-9]*\)\].*/\1/p' | head -1)"
printf '%s\n' "$((navigation_top - ime_top))"
}
read_ime_top() {
adb shell dumpsys window | sed -n \
's/.*type=ime frame=\[0,\([0-9][0-9]*\)\].*visible=true.*/\1/p' | head -1
}
cleanup() {
adb shell ime set "${HELPER_IME}" >/dev/null 2>&1 || true
AGENT_DEVICE_STATE_DIR="${STATE_DIR}" agent-device daemon stop --clean >/dev/null 2>&1 || true
}
trap cleanup EXIT INT TERM
cleanup
mkdir -p "${STATE_DIR}" "${ARTIFACTS_DIR}"
workspaces_json="$(env -u PASEO_CALLER_AGENT_ID -u PASEO_AGENT_ID -u PASEO_WORKSPACE_ID \
npm run --silent cli -- workspace ls --json --host "${DAEMON_HOST}")"
workspace_id="$(node -e '
const workspaces = JSON.parse(require("node:fs").readFileSync(0, "utf8"));
const cwd = process.argv[1];
const workspace = workspaces.find((candidate) => candidate.cwd === cwd);
if (!workspace) process.exit(1);
process.stdout.write(workspace.workspaceId);
' "${REPO_ROOT}" <<<"${workspaces_json}")"
AGENT_DEVICE_STATE_DIR="${STATE_DIR}" agent-device open "${APP_ID}" \
--platform android \
--device "${DEVICE}" \
--session "${SESSION}"
adb shell am force-stop "${APP_ID}"
adb shell am start \
-a android.intent.action.VIEW \
-d "exp+voice-mobile://expo-development-client/?url=http%3A%2F%2F10.0.2.2%3A${METRO_PORT}" \
"${APP_ID}" >/dev/null
sleep 3
# Create the fixture while the client is connected so its directory replica observes the insert.
run_json="$(env -u PASEO_CALLER_AGENT_ID -u PASEO_AGENT_ID -u PASEO_WORKSPACE_ID \
npm run --silent cli -- run "Exercise the composer keyboard invariant flow" \
--background \
--title "${AGENT_TITLE}" \
--provider mock \
--model e2e-fast-stream \
--workspace "${workspace_id}" \
--cwd "${REPO_ROOT}" \
--host "${DAEMON_HOST}" \
--json)"
agent_id="$(node -e '
const result = JSON.parse(require("node:fs").readFileSync(0, "utf8"));
process.stdout.write(result.agentId);
' <<<"${run_json}")"
sleep 3
adb shell am start \
-a android.intent.action.VIEW \
-d "paseo://h/${SERVER_ID}/agent/${agent_id}" \
"${APP_ID}" >/dev/null
sleep 5
# The development-client bootstrap can consume the first link while Expo Router is mounting.
# Deliver the target again after the root navigator is live.
adb shell am start \
-a android.intent.action.VIEW \
-d "paseo://h/${SERVER_ID}/agent/${agent_id}" \
"${APP_ID}" >/dev/null
ad wait "text=\"${AGENT_TITLE}\"" 45000
ad wait 'editable=true' 10000
clear_input
ad keyboard dismiss || true
ad wait 'label="Message, @files, /commands"' 10000
snapshot_json "${ARTIFACTS_DIR}/baseline.json"
capture_screen "${ARTIFACTS_DIR}/baseline.png"
read -r input_x input_y baseline_input_height < <(
node "${ASSERT}" rect "${ARTIFACTS_DIR}/baseline.json" "Message, @files, /commands"
)
read -r model_x model_y _ < <(
node "${ASSERT}" rect "${ARTIFACTS_DIR}/baseline.json" "combined-model-selector"
)
read -r attach_x attach_y _ < <(
node "${ASSERT}" rect "${ARTIFACTS_DIR}/baseline.json" "message-input-attach-button"
)
read -r _ header_y _ < <(
node "${ASSERT}" rect "${ARTIFACTS_DIR}/baseline.json" "workspace-tab-switcher-trigger"
)
adb shell input keyevent HOME
adb shell am start -n "${APP_ID}/.MainActivity" >/dev/null
sleep 1
open_gboard "${input_x}" "${input_y}"
clear_focused_input_with_adb
keyboard_shift="$(read_keyboard_shift)"
adb shell input keyevent 76
sleep 1
capture_screen "${ARTIFACTS_DIR}/command-popover.png"
ad wait 'id="composer-autocomplete-popover"' 10000
ad wait 'text="/exit"' 10000
model_open_y="$((model_y - keyboard_shift))"
adb shell input tap "${model_x}" "${model_open_y}"
sleep 1
capture_screen "${ARTIFACTS_DIR}/model-selector-open.png"
adb shell ime set "${HELPER_IME}" >/dev/null
ad wait 'id="compact-provider-list"' 10000
ad press 'label="Close"' --settle
adb shell input tap "${input_x}" "${input_y}"
clear_focused_input_with_adb
ad wait 'editable=true' 10000
adb shell input keyevent HOME
adb shell am start -n "${APP_ID}/.MainActivity" >/dev/null
sleep 1
open_gboard "${input_x}" "${input_y}"
clear_focused_input_with_adb
adb shell input keyevent 76
sleep 1
adb shell ime set "${HELPER_IME}" >/dev/null
ad wait 'id="composer-autocomplete-popover"' 10000
ad wait 'text="/exit"' 10000
snapshot_json "${ARTIFACTS_DIR}/command-popover.json"
node "${ASSERT}" above-y \
"${ARTIFACTS_DIR}/command-popover.json" \
"/exit, Archive the current agent" \
"$((input_y - baseline_input_height / 2))"
adb shell input keyevent 67
ad wait 'label="Message, @files, /commands"' 10000
ad fill 'label="Message, @files, /commands"' "${MESSAGE}" --settle
snapshot_json "${ARTIFACTS_DIR}/multiline-first.json"
ad fill 'editable=true focused=true' "${MESSAGE}" --settle
snapshot_json "${ARTIFACTS_DIR}/multiline-second.json"
node "${ASSERT}" same-input-height \
"${ARTIFACTS_DIR}/multiline-first.json" \
"${ARTIFACTS_DIR}/multiline-second.json"
adb shell input keyevent HOME
adb shell am start -n "${APP_ID}/.MainActivity" >/dev/null
sleep 1
open_gboard "${input_x}" "${input_y}"
keyboard_shift="$(read_keyboard_shift)"
capture_screen "${ARTIFACTS_DIR}/keyboard-open.png"
node "${ASSERT}" same-header \
"${ARTIFACTS_DIR}/baseline.png" \
"${ARTIFACTS_DIR}/keyboard-open.png" \
"$((header_y + 48))"
adb shell ime set "${HELPER_IME}" >/dev/null
ad fill 'editable=true focused=true' "${LONG_MESSAGE}" --settle
open_gboard "${input_x}" "${input_y}"
capture_ui_xml "${ARTIFACTS_DIR}/long-draft-keyboard-open.xml"
capture_screen "${ARTIFACTS_DIR}/long-draft-keyboard-open.png"
node "${ASSERT}" xml-above-y \
"${ARTIFACTS_DIR}/long-draft-keyboard-open.xml" \
"Add attachment" \
"$(read_ime_top)"
adb shell ime set "${HELPER_IME}" >/dev/null
ad fill 'editable=true' "${MESSAGE}" --settle
open_gboard "${input_x}" "${input_y}"
keyboard_shift="$(read_keyboard_shift)"
read -r changes_x changes_y _ < <(
node "${ASSERT}" rect "${ARTIFACTS_DIR}/multiline-second.json" "Open Changes tab"
)
adb shell input tap "${changes_x}" "$((changes_y - keyboard_shift))"
ad wait 'id="changes-header"' 10000
capture_screen "${ARTIFACTS_DIR}/changes-control-open.png"
ad press 'label="Close Explorer sidebar"' --settle
ad wait "text=\"${AGENT_TITLE}\"" 10000
ad wait 'editable=true' 10000
open_gboard "${input_x}" "${input_y}"
keyboard_shift="$(read_keyboard_shift)"
adb shell input tap "${attach_x}" "$((attach_y - keyboard_shift))"
sleep 1
adb shell ime set "${HELPER_IME}" >/dev/null
ad wait 'id="message-input-attachment-menu-content"' 10000
ad press 540 600 --settle
open_gboard "${input_x}" "${input_y}"
keyboard_shift="$(read_keyboard_shift)"
adb shell input tap 983 "$((attach_y - keyboard_shift))"
wait_for_ime false
adb shell ime set "${HELPER_IME}" >/dev/null
ad wait text "keyboard invariant line one" 10000
snapshot_json "${ARTIFACTS_DIR}/after-submit.json"
node "${ASSERT}" has-exact-text "${ARTIFACTS_DIR}/after-submit.json" "${MESSAGE}"
node "${ASSERT}" same-input-height \
"${ARTIFACTS_DIR}/baseline.json" \
"${ARTIFACTS_DIR}/after-submit.json"
open_gboard "${input_x}" "${input_y}"
adb shell input keyevent BACK
wait_for_ime false
sleep 0.5
capture_screen "${ARTIFACTS_DIR}/hidden-focused-baseline.png"
open_gboard "${input_x}" "${input_y}"
node "${STALL_HERMES}" "${METRO_PORT}" 3000 "${APP_ID}" &
stall_pid="$!"
sleep 0.25
adb shell input keyevent BACK
wait_for_ime false
sleep 0.5
capture_screen "${ARTIFACTS_DIR}/hidden-during-js-stall.png"
wait "${stall_pid}"
capture_screen "${ARTIFACTS_DIR}/hidden-after-js-stall.png"
node "${ASSERT}" same-region \
"${ARTIFACTS_DIR}/hidden-focused-baseline.png" \
"${ARTIFACTS_DIR}/hidden-during-js-stall.png" \
1400 \
430
node "${ASSERT}" same-region \
"${ARTIFACTS_DIR}/hidden-focused-baseline.png" \
"${ARTIFACTS_DIR}/hidden-after-js-stall.png" \
1400 \
430
echo "Composer keyboard invariants passed"
@@ -1,106 +0,0 @@
import fs from "node:fs/promises";
import process from "node:process";
import sharp from "sharp";
const [, , command, ...args] = process.argv;
if (command === "rect") {
const [snapshotPath, identifier] = args;
const snapshot = JSON.parse(await fs.readFile(snapshotPath, "utf8"));
const node = snapshot.data.nodes.find(
(candidate) => candidate.identifier === identifier || candidate.label === identifier,
);
if (!node) throw new Error(`Missing node: ${identifier}`);
const { x, y, width, height } = node.rect;
process.stdout.write(`${Math.round(x + width / 2)} ${Math.round(y + height / 2)} ${height}\n`);
} else if (command === "above-y") {
const [snapshotPath, upperIdentifier, lowerYArgument] = args;
const snapshot = JSON.parse(await fs.readFile(snapshotPath, "utf8"));
const upper = snapshot.data.nodes.find(
(candidate) => candidate.identifier === upperIdentifier || candidate.label === upperIdentifier,
);
if (!upper) throw new Error(`Missing node: ${upperIdentifier}`);
const upperBottom = upper.rect.y + upper.rect.height;
const lowerY = Number(lowerYArgument);
if (upperBottom > lowerY) {
throw new Error(
`${upperIdentifier} extends below the composer top: ${upperBottom} > ${lowerY}`,
);
}
} else if (command === "xml-above-y") {
const [snapshotPath, contentDescription, lowerYArgument] = args;
const snapshot = await fs.readFile(snapshotPath, "utf8");
const escapedDescription = contentDescription.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
const match = snapshot.match(
new RegExp(
`<node[^>]*content-desc="${escapedDescription}"[^>]*bounds="\\[(\\d+),(\\d+)\\]\\[(\\d+),(\\d+)\\]"`,
),
);
if (!match) throw new Error(`Missing node: ${contentDescription}`);
const upperBottom = Number(match[4]);
const lowerY = Number(lowerYArgument);
if (upperBottom > lowerY) {
throw new Error(`${contentDescription} extends below the keyboard: ${upperBottom} > ${lowerY}`);
}
} else if (command === "same-header") {
const [baselinePath, keyboardPath, headerBottomArgument] = args;
const headerBottom = Number(headerBottomArgument);
const crop = { left: 0, top: 64, width: 1080, height: headerBottom - 64 };
const [baseline, keyboard] = await Promise.all([
sharp(baselinePath).extract(crop).removeAlpha().raw().toBuffer(),
sharp(keyboardPath).extract(crop).removeAlpha().raw().toBuffer(),
]);
let changed = 0;
for (let index = 0; index < baseline.length; index += 1) {
if (Math.abs(baseline[index] - keyboard[index]) > 8) changed += 1;
}
const changedRatio = changed / baseline.length;
if (changedRatio > 0.01) {
throw new Error(`Header changed while the keyboard opened (${changedRatio.toFixed(3)})`);
}
} else if (command === "same-input-height") {
const [firstPath, secondPath] = args;
const readInputHeight = async (snapshotPath) => {
const snapshot = JSON.parse(await fs.readFile(snapshotPath, "utf8"));
const input = snapshot.data.nodes.find((candidate) => candidate.type.endsWith("EditText"));
if (!input) throw new Error(`Missing composer input in ${snapshotPath}`);
return input.rect.height;
};
const [firstHeight, secondHeight] = await Promise.all([
readInputHeight(firstPath),
readInputHeight(secondPath),
]);
if (firstHeight !== secondHeight) {
throw new Error(`Composer height drifted from ${firstHeight} to ${secondHeight}`);
}
} else if (command === "has-exact-text") {
const [snapshotPath, expected] = args;
const snapshot = JSON.parse(await fs.readFile(snapshotPath, "utf8"));
if (!snapshot.data.nodes.some((candidate) => candidate.label === expected)) {
throw new Error(`Missing exact text in ${snapshotPath}: ${expected}`);
}
} else if (command === "same-region") {
const [firstPath, secondPath, topArgument, heightArgument, failureMessage] = args;
const crop = {
left: 0,
top: Number(topArgument),
width: 1080,
height: Number(heightArgument),
};
const [first, second] = await Promise.all([
sharp(firstPath).extract(crop).removeAlpha().raw().toBuffer(),
sharp(secondPath).extract(crop).removeAlpha().raw().toBuffer(),
]);
let changed = 0;
for (let index = 0; index < first.length; index += 1) {
if (Math.abs(first[index] - second[index]) > 8) changed += 1;
}
const changedRatio = changed / first.length;
if (changedRatio > 0.02) {
throw new Error(
`${failureMessage ?? "Composer region changed during the JS stall"} (${changedRatio.toFixed(3)})`,
);
}
} else {
throw new Error(`Unknown command: ${command}`);
}
@@ -1,35 +0,0 @@
import process from "node:process";
import { WebSocket } from "ws";
const [, , metroPortArgument, durationArgument, appId] = process.argv;
const metroPort = Number(metroPortArgument);
const duration = Number(durationArgument);
const targets = await fetch(`http://127.0.0.1:${metroPort}/json/list`).then((response) =>
response.json(),
);
const target = targets.find((candidate) => candidate.appId === appId);
if (!target) throw new Error(`Missing Hermes target for ${appId}`);
await new Promise((resolve, reject) => {
const socket = new WebSocket(target.webSocketDebuggerUrl);
const timeout = setTimeout(() => reject(new Error("Hermes stall timed out")), duration + 5000);
socket.on("open", () => {
socket.send(
JSON.stringify({
id: 1,
method: "Runtime.evaluate",
params: {
expression: `(() => { const deadline = Date.now() + ${duration}; while (Date.now() < deadline) {} })()`,
},
}),
);
});
socket.on("message", (message) => {
const response = JSON.parse(message.toString());
if (response.id !== 1) return;
clearTimeout(timeout);
socket.close();
resolve();
});
socket.on("error", reject);
});
+2 -9
View File
@@ -34,20 +34,13 @@ const metroTest = base.extend({
const daemonTest = metroTest.extend<
{ projectOwnership: void },
{
e2eForkProviders: string[];
e2eInjectPaseoTools: boolean;
e2eWorker: void;
e2eWorkerClient: SeedDaemonClient;
}
{ e2eForkProviders: string[]; e2eWorker: void; e2eWorkerClient: SeedDaemonClient }
>({
e2eForkProviders: [[], { scope: "worker", option: true }],
e2eInjectPaseoTools: [false, { scope: "worker", option: true }],
e2eWorker: [
async ({ e2eForkProviders, e2eInjectPaseoTools }, provide, workerInfo) => {
async ({ e2eForkProviders }, provide, workerInfo) => {
const worker = await startE2EWorker(workerInfo.workerIndex, {
forkProviders: e2eForkProviders,
injectPaseoTools: e2eInjectPaseoTools,
});
try {
await provide();
@@ -1,4 +1,4 @@
import { expect, type Locator, type Page } from "@playwright/test";
import { expect, type Page } from "@playwright/test";
const NEAR_BOTTOM_THRESHOLD_PX = 72;
const DEFAULT_SCROLL_TOLERANCE_PX = 24;
@@ -14,31 +14,6 @@ function getVisibleChatScroll(page: Page) {
return page.locator('[data-testid="agent-chat-scroll"]:visible').first();
}
interface PositionedToolCall {
locator: Locator;
bounds: { x: number; y: number; width: number; height: number };
}
async function readRenderedToolCalls(toolCalls: Locator): Promise<PositionedToolCall[]> {
const entries = await Promise.all(
Array.from({ length: await toolCalls.count() }, async (_, index) => ({
locator: toolCalls.nth(index),
bounds: await toolCalls.nth(index).boundingBox(),
})),
);
return entries.filter(
(entry): entry is PositionedToolCall => entry.bounds !== null && entry.bounds.width > 0,
);
}
function closestToolCallToY(toolCalls: PositionedToolCall[], targetY: number) {
return toolCalls.toSorted(
(left, right) =>
Math.abs(left.bounds.y + left.bounds.height / 2 - targetY) -
Math.abs(right.bounds.y + right.bounds.height / 2 - targetY),
)[0];
}
export async function readScrollMetrics(page: Page): Promise<ScrollMetrics> {
return getVisibleChatScroll(page).evaluate((root: Element) => {
const candidates = [root, ...Array.from(root.querySelectorAll("*"))]
@@ -205,53 +180,58 @@ export async function clickToolCallBesideScrollToBottomButton(page: Page): Promi
const visibleButtonBounds = buttonBounds!;
const toolCalls = page.locator('[data-testid="tool-call-badge"] [role="button"]');
const toolCallBounds = await Promise.all(
Array.from({ length: await toolCalls.count() }, async (_, index) => ({
index,
bounds: await toolCalls.nth(index).boundingBox(),
})),
);
const buttonCenterY = visibleButtonBounds.y + visibleButtonBounds.height / 2;
const initialToolCalls = await readRenderedToolCalls(toolCalls);
const initialCandidate = closestToolCallToY(initialToolCalls, buttonCenterY);
const candidate = toolCallBounds
.filter(
(entry): entry is { index: number; bounds: NonNullable<typeof entry.bounds> } =>
entry.bounds !== null && entry.bounds.width > 0,
)
.sort(
(left, right) =>
Math.abs(left.bounds.y + left.bounds.height / 2 - buttonCenterY) -
Math.abs(right.bounds.y + right.bounds.height / 2 - buttonCenterY),
)[0];
expect(
initialCandidate,
candidate,
`Expected at least one rendered tool-call badge: ${JSON.stringify({
buttonBounds,
scrollMetrics: await readScrollMetrics(page),
toolCallBounds: initialToolCalls.map(({ bounds }) => bounds),
toolCallBounds,
})}`,
).toBeDefined();
const visibleToolCall = candidate!;
const initialToolCallCenterY = visibleToolCall.bounds.y + visibleToolCall.bounds.height / 2;
await getVisibleChatScroll(page).evaluate((scroll, deltaY) => {
(scroll as HTMLElement).scrollTop += deltaY;
}, initialToolCallCenterY - buttonCenterY);
const alignedToolCall = toolCalls.nth(visibleToolCall.index);
await expect
.poll(async () => {
const currentButtonBounds = await scrollToBottomButton.boundingBox();
if (!currentButtonBounds) return false;
const currentButtonCenterY = currentButtonBounds.y + currentButtonBounds.height / 2;
const closest = closestToolCallToY(
await readRenderedToolCalls(toolCalls),
currentButtonCenterY,
);
if (!closest) return false;
const toolCallCenterY = closest.bounds.y + closest.bounds.height / 2;
if (
const [currentButtonBounds, currentToolCallBounds] = await Promise.all([
scrollToBottomButton.boundingBox(),
alignedToolCall.boundingBox(),
]);
if (!currentButtonBounds || !currentToolCallBounds) {
return false;
}
const toolCallCenterY = currentToolCallBounds.y + currentToolCallBounds.height / 2;
return (
toolCallCenterY >= currentButtonBounds.y &&
toolCallCenterY <= currentButtonBounds.y + currentButtonBounds.height
) {
return true;
}
const deltaY = Math.max(-200, Math.min(200, toolCallCenterY - currentButtonCenterY));
await getVisibleChatScroll(page).evaluate((scroll, delta) => {
(scroll as HTMLElement).scrollTop += delta;
}, deltaY);
return false;
);
})
.toBe(true);
const currentButtonBounds = await scrollToBottomButton.boundingBox();
expect(currentButtonBounds, "Expected scroll-to-bottom button to remain visible").not.toBeNull();
const currentButtonCenterY = currentButtonBounds!.y + currentButtonBounds!.height / 2;
const alignedToolCall = closestToolCallToY(
await readRenderedToolCalls(toolCalls),
currentButtonCenterY,
)?.locator;
expect(alignedToolCall, "Expected an aligned tool-call badge").toBeDefined();
const [alignedButtonBounds, visibleToolCallBounds] = await Promise.all([
scrollToBottomButton.boundingBox(),
alignedToolCall!.boundingBox(),
alignedToolCall.boundingBox(),
]);
expect(alignedButtonBounds, "Expected scroll-to-bottom button to remain visible").not.toBeNull();
expect(
@@ -265,7 +245,7 @@ export async function clickToolCallBesideScrollToBottomButton(page: Page): Promi
x: finalToolCallBounds.x + 24,
y: finalToolCallBounds.y + finalToolCallBounds.height / 2,
};
const toolCallReceivesPointer = await alignedToolCall!.evaluate((toolCall, point) => {
const toolCallReceivesPointer = await alignedToolCall.evaluate((toolCall, point) => {
const hit = document.elementFromPoint(point.x, point.y);
return hit !== null && toolCall.contains(hit);
}, clickPoint);
@@ -52,18 +52,18 @@ export interface IdleAgentSeedClient {
): Promise<{ status: string }>;
}
async function seedIdleAgent(
export async function createIdleAgent(
client: IdleAgentSeedClient,
input: { cwd: string; workspaceId: string; title: string },
provider: {
provider: string;
model: string;
modeId: string;
featureValues?: Record<string, unknown>;
},
): Promise<ArchiveTabAgent> {
const created = await client.createAgent({
...provider,
provider: "opencode",
model: "opencode/gpt-5-nano",
// OpenCode has no "bypassPermissions" mode (that's Claude's). Use build with
// auto_accept for unattended full access — mode validation now rejects modes
// the provider doesn't define.
modeId: "build",
featureValues: { auto_accept: true },
cwd: input.cwd,
workspaceId: input.workspaceId,
title: input.title,
@@ -84,32 +84,6 @@ async function seedIdleAgent(
};
}
export async function createIdleAgent(
client: IdleAgentSeedClient,
input: { cwd: string; workspaceId: string; title: string },
): Promise<ArchiveTabAgent> {
return seedIdleAgent(client, input, {
provider: "opencode",
model: "opencode/gpt-5-nano",
// OpenCode has no "bypassPermissions" mode (that's Claude's). Use build with
// auto_accept for unattended full access — mode validation now rejects modes
// the provider doesn't define.
modeId: "build",
featureValues: { auto_accept: true },
});
}
export async function createMockIdleAgent(
client: IdleAgentSeedClient,
input: { cwd: string; workspaceId: string; title: string },
): Promise<ArchiveTabAgent> {
return seedIdleAgent(client, input, {
provider: "mock",
model: "e2e-fast-stream",
modeId: "load-test",
});
}
export async function archiveAgentFromDaemon(
client: { archiveAgent(agentId: string): Promise<{ archivedAt: string }> },
agentId: string,
@@ -38,10 +38,6 @@ export async function expectComposerEditable(page: Page): Promise<void> {
await expect(composerInput(page)).toBeEditable({ timeout: 15_000 });
}
export async function expectComposerFocused(page: Page): Promise<void> {
await expect(composerInput(page)).toBeFocused();
}
export async function submitMessage(page: Page, text: string): Promise<void> {
const input = composerInput(page);
await expect(input).toBeEditable({ timeout: 30_000 });
@@ -53,10 +49,6 @@ export async function fillComposerDraft(page: Page, text: string): Promise<void>
await composerInput(page).fill(text);
}
export async function typeIntoFocusedComposer(page: Page, text: string): Promise<void> {
await page.keyboard.type(text);
}
export async function sendDraftToQueue(page: Page): Promise<void> {
await composerInput(page).press("Control+Enter");
}
@@ -315,9 +315,6 @@ export async function installDaemonWebSocketGate(page: Page) {
const suppressedAgentStreamEventTypes = new Set<string>();
const suppressedAgentStreamItemTypes = new Set<string>();
const activeSockets = new Set<WebSocketRoute>();
let blockedConnectionCount = 0;
let blockedConnectionCountAtDrop = 0;
const blockedConnectionWaiters = new Set<() => void>();
let latestServer: WebSocketRoute | null = null;
const directoryStarts: DirectoryRequestStartCounts = {
subscribed: { agents: 0, workspaces: 0 },
@@ -446,9 +443,6 @@ export async function installDaemonWebSocketGate(page: Page) {
await page.routeWebSocket(daemonWsRoutePattern(), (ws) => {
if (!acceptingConnections) {
blockedConnectionCount += 1;
for (const resolve of blockedConnectionWaiters) resolve();
blockedConnectionWaiters.clear();
void ws.close({ code: 1008, reason: "Blocked by reconnect test." });
return;
}
@@ -589,7 +583,6 @@ export async function installDaemonWebSocketGate(page: Page) {
forward?.();
},
async drop(): Promise<void> {
blockedConnectionCountAtDrop = blockedConnectionCount;
acceptingConnections = false;
const sockets = Array.from(activeSockets);
activeSockets.clear();
@@ -599,10 +592,6 @@ export async function installDaemonWebSocketGate(page: Page) {
),
);
},
async waitForBlockedConnection(): Promise<void> {
if (blockedConnectionCount > blockedConnectionCountAtDrop) return;
await new Promise<void>((resolve) => blockedConnectionWaiters.add(resolve));
},
restore(): void {
acceptingConnections = true;
},
+1 -30
View File
@@ -1,5 +1,4 @@
import { execFileSync } from "node:child_process";
import { existsSync } from "node:fs";
import { chmod, mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
@@ -156,7 +155,7 @@ async function applyMetadataFork(targetHome: string, providerIds: string[]): Pro
export async function startE2EWorker(
workerIndex: number,
options: { forkProviders?: string[]; injectPaseoTools?: boolean } = {},
options: { forkProviders?: string[] } = {},
): Promise<E2EWorker> {
const requestedRoot = resolveOptionalHome(process.env.E2E_PASEO_HOME);
const paseoHome = requestedRoot
@@ -169,9 +168,6 @@ export async function startE2EWorker(
try {
await applyMetadataFork(paseoHome, options.forkProviders ?? []);
if (options.injectPaseoTools) {
await enablePaseoTools(paseoHome);
}
const daemon = await startIsolatedHostDaemon(serverId, {
paseoHome,
preserveHome,
@@ -205,28 +201,3 @@ export async function startE2EWorker(
throw error;
}
}
async function enablePaseoTools(paseoHome: string): Promise<void> {
const configPath = path.join(paseoHome, "config.json");
const existing = existsSync(configPath)
? JSON.parse(await readFile(configPath, "utf8"))
: { version: 1 };
await writeFile(
configPath,
`${JSON.stringify(
{
...existing,
daemon: {
...existing.daemon,
mcp: {
...existing.daemon?.mcp,
enabled: true,
injectIntoAgents: true,
},
},
},
null,
2,
)}\n`,
);
}
+16 -23
View File
@@ -1,4 +1,5 @@
import { expect, type Page } from "@playwright/test";
import type { CheckPresentationCounts } from "@/git/check-presentation";
import { getStateLabel } from "@/git/pull-request-panel/data";
import { openPullRequestPanel } from "./workspace-tabs";
@@ -19,31 +20,23 @@ export async function expectPrPaneState(
});
}
export async function expectPrPaneChecks(
async function assertCheckPill(page: Page, testId: string, count: number): Promise<void> {
const locator = page.getByTestId(testId);
await expect(locator).toHaveCount(count > 0 ? 1 : 0, { timeout: 15_000 });
if (count > 0) {
await expect(locator).toContainText(String(count));
}
}
export async function expectPrPaneCheckSummary(
page: Page,
checks: { success: string[]; failure: string[]; pending: string[] },
counts: Pick<CheckPresentationCounts, "success" | "failure" | "pending">,
): Promise<void> {
const section = page.getByTestId("pr-pane-checks");
const groups = [
{ status: "failure", label: /failing checks?$/, names: checks.failure },
{ status: "pending", label: /in progress checks?$/, names: checks.pending },
{ status: "success", label: /successful checks?$/, names: checks.success },
];
for (const group of groups) {
const groupSection = section.getByTestId(`pr-pane-check-group-${group.status}`);
await expect(groupSection.getByRole("button", { name: group.label })).toBeVisible({
timeout: 15_000,
});
for (const name of group.names) {
await expect(groupSection.getByText(name, { exact: true })).toHaveCount(1);
}
}
await assertCheckPill(page, "pr-pane-check-success", counts.success);
await assertCheckPill(page, "pr-pane-check-failure", counts.failure);
await assertCheckPill(page, "pr-pane-check-pending", counts.pending);
}
export async function expectPrPaneActivity(page: Page, bodies: string[]): Promise<void> {
const activity = page.getByTestId("pr-pane-activity-row");
for (const body of bodies) {
await expect(activity.getByText(body, { exact: true })).toBeVisible({ timeout: 15_000 });
}
export async function expectPrPaneActivityCount(page: Page, count: number): Promise<void> {
await expect(page.getByTestId("pr-pane-activity-row")).toHaveCount(count, { timeout: 15_000 });
}
@@ -112,6 +112,14 @@ export async function expectReconnectingToastGone(
});
}
export async function expectReconnectingToastDebounced(
page: Page,
options?: { durationMs?: number },
): Promise<void> {
await page.waitForTimeout(options?.durationMs ?? 750);
await expect(page.getByTestId("agent-reconnecting-toast")).toHaveCount(0, { timeout: 100 });
}
export async function expectHostConnectingOrOffline(
page: Page,
options?: { timeout?: number },
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@getpaseo/app",
"version": "0.7.0",
"version": "0.7.0-beta.2",
"private": true,
"main": "index.ts",
"scripts": {
+6 -5
View File
@@ -95,7 +95,7 @@ import { useOpenProject } from "@/hooks/use-open-project";
import { useAppSettings } from "@/hooks/use-settings";
import { useStableEvent } from "@/hooks/use-stable-event";
import { useOpenAgentListGesture } from "@/mobile-panels/gestures";
import { MobilePanelsProvider, useIsMobilePanelActive } from "@/mobile-panels/provider";
import { MobilePanelsProvider } from "@/mobile-panels/provider";
import { I18nProvider } from "@/i18n/provider";
import {
KeyboardActionDispatcherProvider,
@@ -114,7 +114,7 @@ import {
useHosts,
} from "@/runtime/host-runtime";
import { getDaemonStartService } from "@/runtime/daemon-start-service";
import { usePanelStore } from "@/stores/panel-store";
import { selectIsAgentListOpen, usePanelStore } from "@/stores/panel-store";
import { flushDraftPersistStorage } from "@/stores/draft-store";
import { getNextThemePreference } from "@/styles/theme";
import { useSessionStore } from "@/stores/session-store";
@@ -627,9 +627,10 @@ function SidebarChrome({
keyboardShortcutsEnabled: boolean;
}) {
const isCompactLayout = useIsCompactFormFactor();
const isMobileActive = useIsMobilePanelActive("agent-list");
const isDesktopOpen = usePanelStore((state) => state.desktop.agentListOpen);
const active = visible && (isCompactLayout ? isMobileActive : isDesktopOpen);
const isOpen = usePanelStore((state) =>
selectIsAgentListOpen(state, { isCompact: isCompactLayout }),
);
const active = visible && isOpen;
return (
<SidebarModelProvider active={active}>
{mounted ? <LeftSidebar active={active} /> : null}
@@ -1,54 +0,0 @@
import { afterEach, describe, expect, it, vi } from "vitest";
import {
ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT,
capAssistantMessageForRender,
getUtf8ByteLength,
} from "./assistant-message-render-limit";
describe("assistant message render limit", () => {
afterEach(() => {
vi.unstubAllGlobals();
vi.resetModules();
});
it("leaves messages at the limit unchanged", () => {
const message = "a".repeat(ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT);
expect(capAssistantMessageForRender(message)).toEqual({ text: message, capped: false });
});
it("caps oversized messages before markdown rendering", () => {
const message = "a".repeat(ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT + 1);
expect(capAssistantMessageForRender(message)).toEqual({
text: "a".repeat(ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT),
capped: true,
});
});
it("does not split a grapheme cluster at the boundary", () => {
const prefix = "a".repeat(ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT - 1);
expect(capAssistantMessageForRender(`${prefix}étail`)).toEqual({
text: prefix,
capped: true,
});
});
it("counts the complete message size in UTF-8 bytes", () => {
expect(getUtf8ByteLength("aé😀")).toBe(7);
});
it("keeps a bounded prefix when grapheme segmentation is unavailable", async () => {
vi.resetModules();
vi.stubGlobal("Intl", { ...Intl, Segmenter: undefined });
const { capAssistantMessageForRender: capWithoutSegmenter } =
await import("./assistant-message-render-limit");
const message = "a".repeat(ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT + 1);
expect(capWithoutSegmenter(message)).toEqual({
text: "a".repeat(ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT),
capped: true,
});
});
});
@@ -1,52 +0,0 @@
import { clampToSafeRevealBoundary, isTextRevealPacingSupported } from "@/agent-stream/text-reveal";
export const ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT = 32_000;
export interface CappedAssistantMessage {
text: string;
capped: boolean;
}
export function getUtf8ByteLength(message: string): number {
let bytes = 0;
for (let index = 0; index < message.length; index += 1) {
const codeUnit = message.charCodeAt(index);
if (codeUnit < 0x80) {
bytes += 1;
} else if (codeUnit < 0x800) {
bytes += 2;
} else if (
codeUnit >= 0xd800 &&
codeUnit <= 0xdbff &&
index + 1 < message.length &&
message.charCodeAt(index + 1) >= 0xdc00 &&
message.charCodeAt(index + 1) <= 0xdfff
) {
bytes += 4;
index += 1;
} else {
bytes += 3;
}
}
return bytes;
}
export function capAssistantMessageForRender(message: string): CappedAssistantMessage {
if (message.length <= ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT) {
return { text: message, capped: false };
}
let end = ASSISTANT_MESSAGE_RENDER_CHARACTER_LIMIT;
if (isTextRevealPacingSupported()) {
end = clampToSafeRevealBoundary(message, end);
} else {
const finalCodeUnit = message.charCodeAt(end - 1);
if (finalCodeUnit >= 0xd800 && finalCodeUnit <= 0xdbff) {
end -= 1;
}
}
return { text: message.slice(0, end), capped: true };
}
@@ -4,7 +4,7 @@ import { createRoot, type Root } from "react-dom/client";
import { JSDOM } from "jsdom";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { AttachmentMetadata } from "@/attachments/types";
import { AttachmentLightbox, type ImageLightboxSource } from "./attachment-lightbox";
import { AttachmentLightbox } from "./attachment-lightbox";
const { theme, imageMetadata, useAttachmentPreviewUrlMock } = vi.hoisted(() => {
const hoistedTheme = {
@@ -42,11 +42,6 @@ const { theme, imageMetadata, useAttachmentPreviewUrlMock } = vi.hoisted(() => {
),
};
});
const attachmentSource: ImageLightboxSource = { type: "attachment", metadata: imageMetadata };
const assistantImageSource: ImageLightboxSource = {
type: "uri",
uri: "blob:assistant-image",
};
vi.mock("react-native-unistyles", () => ({
StyleSheet: {
@@ -75,11 +70,6 @@ vi.mock("react-native-safe-area-context", () => ({
useSafeAreaInsets: () => ({ top: 0, right: 0, bottom: 0, left: 0 }),
}));
vi.mock("react-native-gesture-handler", () => ({
GestureHandlerRootView: ({ children }: { children?: React.ReactNode }) =>
React.createElement("div", { "data-testid": "gesture-handler-root" }, children),
}));
vi.mock("lucide-react-native", () => {
const createIcon = (name: string) => (props: Record<string, unknown>) =>
React.createElement("span", { ...props, "data-icon": name });
@@ -88,34 +78,16 @@ vi.mock("lucide-react-native", () => {
};
});
vi.mock("@/components/zoomable-viewport/image", () => ({
ZoomableImage: (props: Record<string, unknown>) => {
const actions = props.actions as Array<{
label: string;
onPress: () => void;
testID?: string;
}>;
return React.createElement(
"div",
{
"data-testid": `${String(props.testID)}-image`,
"data-source": props.uri,
role: "img",
},
actions.map((action) =>
React.createElement(
"button",
{
"aria-label": action.label,
"data-testid": action.testID,
key: action.label,
onClick: action.onPress,
type: "button",
},
action.label,
),
),
);
vi.mock("expo-image", () => ({
Image: (props: Record<string, unknown>) => {
const source = props.source as { uri?: string } | string | undefined;
const uri = typeof source === "string" ? source : source?.uri;
return React.createElement("div", {
"data-testid": props.testID,
"data-source": uri,
"data-style": JSON.stringify(props.style ?? null),
role: "img",
});
},
}));
@@ -136,8 +108,6 @@ let container: HTMLElement | null = null;
beforeEach(() => {
const dom = new JSDOM("<!doctype html><html><body></body></html>");
dom.window.requestAnimationFrame = vi.fn(() => 1);
dom.window.cancelAnimationFrame = vi.fn();
vi.stubGlobal("React", React);
vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", true);
vi.stubGlobal("window", dom.window);
@@ -180,32 +150,42 @@ function queryByTestId(testID: string): HTMLElement | null {
}
describe("AttachmentLightbox", () => {
it("renders nothing when the source is null", () => {
render(<AttachmentLightbox source={null} onClose={vi.fn()} />);
it("renders nothing when metadata is null", () => {
render(<AttachmentLightbox metadata={null} onClose={vi.fn()} />);
expect(queryByTestId("attachment-lightbox-backdrop")).toBeNull();
expect(queryByTestId("attachment-lightbox-image")).toBeNull();
});
it("renders the image when metadata is provided", () => {
render(<AttachmentLightbox source={attachmentSource} onClose={vi.fn()} />);
render(<AttachmentLightbox metadata={imageMetadata} onClose={vi.fn()} />);
const image = queryByTestId("attachment-lightbox-image");
expect(image).not.toBeNull();
expect(image?.getAttribute("data-source")).toBe("blob:preview");
});
it("renders a direct timeline image without resolving attachment storage", () => {
render(<AttachmentLightbox source={assistantImageSource} onClose={vi.fn()} />);
it("fills its parent via absolute positioning so expo-image does not collapse to 0px", () => {
render(<AttachmentLightbox metadata={imageMetadata} onClose={vi.fn()} />);
const image = queryByTestId("attachment-lightbox-image");
expect(image?.getAttribute("data-source")).toBe("blob:assistant-image");
expect(useAttachmentPreviewUrlMock).toHaveBeenLastCalledWith(null);
const style = JSON.parse(image?.getAttribute("data-style") ?? "null") as {
position?: string;
top?: number;
left?: number;
right?: number;
bottom?: number;
} | null;
expect(style?.position).toBe("absolute");
expect(style?.top).toBe(0);
expect(style?.left).toBe(0);
expect(style?.right).toBe(0);
expect(style?.bottom).toBe(0);
});
it("calls onClose when the backdrop is pressed", () => {
const onClose = vi.fn();
render(<AttachmentLightbox source={attachmentSource} onClose={onClose} />);
render(<AttachmentLightbox metadata={imageMetadata} onClose={onClose} />);
const backdrop = queryByTestId("attachment-lightbox-backdrop");
expect(backdrop).not.toBeNull();
@@ -216,7 +196,7 @@ describe("AttachmentLightbox", () => {
it("calls onClose when the close button is pressed", () => {
const onClose = vi.fn();
render(<AttachmentLightbox source={attachmentSource} onClose={onClose} />);
render(<AttachmentLightbox metadata={imageMetadata} onClose={onClose} />);
const closeButton = document.querySelector(
'[aria-label="Close image"][data-testid="attachment-lightbox-close"]',
@@ -229,7 +209,7 @@ describe("AttachmentLightbox", () => {
it("shows error text when the preview URL resolves to null", () => {
useAttachmentPreviewUrlMock.mockReturnValue(null);
render(<AttachmentLightbox source={attachmentSource} onClose={vi.fn()} />);
render(<AttachmentLightbox metadata={imageMetadata} onClose={vi.fn()} />);
expect(queryByTestId("attachment-lightbox-image")).toBeNull();
expect(document.body.textContent ?? "").toContain("Couldn't load image");
@@ -237,7 +217,7 @@ describe("AttachmentLightbox", () => {
it("closes on Escape key on web", () => {
const onClose = vi.fn();
render(<AttachmentLightbox source={attachmentSource} onClose={onClose} />);
render(<AttachmentLightbox metadata={imageMetadata} onClose={onClose} />);
act(() => {
window.dispatchEvent(new window.KeyboardEvent("keydown", { key: "Escape" }));
@@ -1,88 +1,63 @@
import { useCallback, useEffect, useMemo, useState } from "react";
import { Modal, Pressable, Text, View } from "react-native";
import { GestureHandlerRootView } from "react-native-gesture-handler";
import { StyleSheet } from "react-native-unistyles";
import { StyleSheet, useUnistyles } from "react-native-unistyles";
import { useSafeAreaInsets } from "react-native-safe-area-context";
import { Image as ExpoImage } from "expo-image";
import { X } from "lucide-react-native";
import { useTranslation } from "react-i18next";
import type { AttachmentMetadata } from "@/attachments/types";
import { useAttachmentPreviewUrl } from "@/attachments/use-attachment-preview-url";
import { isNative, isWeb } from "@/constants/platform";
import { SPACING } from "@/styles/theme";
import { WindowChromeRootRegion } from "@/utils/desktop-window";
import { ZoomableImage } from "@/components/zoomable-viewport/image";
import type { ViewportSize } from "@/components/zoomable-viewport/geometry";
import { useGlobalWebOverlayLayer, useWebOverlayRegistration } from "@/lib/overlay-root";
export type ImageLightboxSource =
| { type: "attachment"; metadata: AttachmentMetadata }
| { type: "uri"; uri: string; contentSize?: ViewportSize };
import { isWeb } from "@/constants/platform";
import { WindowChromeRootRegion, WindowChromeSafeArea } from "@/utils/desktop-window";
interface AttachmentLightboxProps {
source: ImageLightboxSource | null;
metadata: AttachmentMetadata | null;
onClose: () => void;
}
const ModalRoot = isNative ? GestureHandlerRootView : View;
const LIGHTBOX_FIT = { padding: SPACING[4], maxWidth: 960, maxHeight: 640 };
export function AttachmentLightbox({ source, onClose }: AttachmentLightboxProps) {
export function AttachmentLightbox({ metadata, onClose }: AttachmentLightboxProps) {
const { theme } = useUnistyles();
const { t } = useTranslation();
const insets = useSafeAreaInsets();
const metadata = source?.type === "attachment" ? source.metadata : null;
const attachmentUrl = useAttachmentPreviewUrl(metadata);
const url = source?.type === "uri" ? source.uri : attachmentUrl;
const contentSize = source?.type === "uri" ? source.contentSize : undefined;
const url = useAttachmentPreviewUrl(metadata);
const [errored, setErrored] = useState(false);
const modalLayer = useGlobalWebOverlayLayer("modal", isWeb && source !== null);
useEffect(() => {
setErrored(false);
}, [metadata?.id, url]);
}, [metadata?.id]);
const handleWebOverlayKeyDown = useCallback(
(event: KeyboardEvent) => {
if (event.key !== "Escape") return false;
event.preventDefault();
event.stopPropagation();
onClose();
return true;
},
[onClose],
);
const setWebOverlayScope = useWebOverlayRegistration({
active: isWeb && source !== null,
layer: modalLayer,
onKeyDown: handleWebOverlayKeyDown,
});
useEffect(() => {
if (!isWeb || !metadata) return;
function handleKeydown(event: KeyboardEvent) {
if (event.key === "Escape") {
onClose();
}
}
window.addEventListener("keydown", handleKeydown);
return () => {
window.removeEventListener("keydown", handleKeydown);
};
}, [metadata, onClose]);
const contentLayerStyle = useMemo(
const closeButtonRowStyle = useMemo(
() => [
styles.contentLayer,
styles.closeButtonRow,
{
paddingTop: insets.top,
paddingRight: insets.right,
paddingBottom: insets.bottom,
paddingLeft: insets.left,
top: insets.top + theme.spacing[3],
},
],
[insets.bottom, insets.left, insets.right, insets.top],
[insets.top, theme.spacing],
);
const actions = useMemo(
() => [
{
icon: X,
label: t("message.attachments.closeImage"),
onPress: onClose,
testID: "attachment-lightbox-close",
},
],
[onClose, t],
const closeButtonStyle = useMemo(
() => [styles.closeButton, { marginRight: insets.right + theme.spacing[3] }],
[insets.right, theme.spacing],
);
const handleImageError = useCallback(() => setErrored(true), []);
const noopPress = useCallback(() => {}, []);
const imageSource = useMemo(() => ({ uri: url ?? "" }), [url]);
if (!source) {
if (!metadata) {
return null;
}
@@ -90,47 +65,61 @@ export function AttachmentLightbox({ source, onClose }: AttachmentLightboxProps)
return (
<Modal transparent animationType="fade" statusBarTranslucent visible onRequestClose={onClose}>
<ModalRoot style={styles.root}>
<WindowChromeRootRegion corners="both">
<View ref={setWebOverlayScope} style={styles.root}>
<Pressable
testID="attachment-lightbox-backdrop"
accessibilityRole="button"
accessibilityLabel={t("message.attachments.dismissImage")}
onPress={onClose}
style={styles.backdrop}
/>
<View pointerEvents="box-none" style={contentLayerStyle}>
<View pointerEvents="box-none" style={styles.imageArea}>
{hasError ? (
<Text style={styles.errorText}>{t("message.attachments.imageLoadFailed")}</Text>
) : (
<ZoomableImage
accessibilityLabel={t("composer.attachments.openImage")}
actions={actions}
contentSize={contentSize}
fit={LIGHTBOX_FIT}
<WindowChromeRootRegion corners="both">
<View style={styles.root}>
<Pressable
testID="attachment-lightbox-backdrop"
accessibilityRole="button"
accessibilityLabel={t("message.attachments.dismissImage")}
onPress={onClose}
style={styles.backdrop}
/>
<View style={styles.contentLayer}>
<View style={styles.imageArea}>
{hasError ? (
<Text style={styles.errorText}>{t("message.attachments.imageLoadFailed")}</Text>
) : (
<Pressable onPress={noopPress} style={styles.imagePressable}>
<ExpoImage
testID="attachment-lightbox-image"
source={imageSource}
contentFit="contain"
onError={handleImageError}
onPressOutsideContent={onClose}
style={styles.imageViewport}
testID="attachment-lightbox"
uri={url}
style={imageFillStyle}
/>
)}
</View>
</Pressable>
)}
</View>
<WindowChromeSafeArea placement="inline" style={closeButtonRowStyle}>
<Pressable
testID="attachment-lightbox-close"
accessibilityRole="button"
accessibilityLabel={t("message.attachments.closeImage")}
hitSlop={8}
onPress={onClose}
style={closeButtonStyle}
>
<X size={16} color={theme.colors.foregroundMuted} />
</Pressable>
</WindowChromeSafeArea>
</View>
</WindowChromeRootRegion>
</ModalRoot>
</View>
</WindowChromeRootRegion>
</Modal>
);
}
const imageFillStyle = {
position: "absolute",
top: 0,
left: 0,
right: 0,
bottom: 0,
} as const;
const styles = StyleSheet.create((theme) => ({
root: {
flex: 1,
minHeight: 0,
minWidth: 0,
},
backdrop: {
position: "absolute",
@@ -146,19 +135,42 @@ const styles = StyleSheet.create((theme) => ({
left: 0,
right: 0,
bottom: 0,
pointerEvents: "box-none",
},
closeButtonRow: {
position: "absolute",
left: 0,
right: 0,
alignItems: "flex-end",
pointerEvents: "box-none",
},
imageArea: {
flex: 1,
alignItems: "center",
justifyContent: "center",
padding: theme.spacing[4],
pointerEvents: "box-none",
},
imageViewport: {
imagePressable: {
flex: 1,
width: "100%",
alignSelf: "center",
maxWidth: 960,
maxHeight: 640,
},
errorText: {
color: theme.colors.foregroundMuted,
fontSize: theme.fontSize.base,
},
closeButton: {
width: 32,
height: 32,
borderRadius: 16,
backgroundColor: theme.colors.surface2,
borderWidth: theme.borderWidth[1],
borderColor: theme.colors.border,
alignItems: "center",
justifyContent: "center",
zIndex: 1,
},
}));
@@ -8,8 +8,6 @@ import { ComboboxTrigger } from "@/components/ui/combobox-trigger";
import { LoadingSpinner } from "@/components/ui/loading-spinner";
import { Combobox, type ComboboxOption, type ComboboxProps } from "@/components/ui/combobox";
import { ModelBrowser, ModelProviderGlyph, useModelBrowser } from "@/components/model-browser";
import { resolveModelBrowserScrolling } from "@/components/model-browser-view";
import { useIsCompactFormFactor } from "@/constants/layout";
import { isNative, isWeb } from "@/constants/platform";
import type { ProviderSelectorProvider } from "@/provider-selection/provider-selection";
import { ICON_SIZE, type Theme } from "@/styles/theme";
@@ -89,8 +87,6 @@ export function CombinedModelSelector({
toolbar,
}: CombinedModelSelectorProps) {
const { t } = useTranslation();
const isCompact = useIsCompactFormFactor();
const modelBrowserScrolling = resolveModelBrowserScrolling({ isNative, isCompact });
const anchorRef = useRef<View>(null);
const [isOpen, setIsOpen] = useState(false);
const [isContentReady, setIsContentReady] = useState(isWeb);
@@ -202,7 +198,7 @@ export function CombinedModelSelector({
onEditProfile={onEditProfile ? handleEditProfile : undefined}
onRetryProvider={onRetryProvider}
isRetryingProvider={isRetryingProvider}
scrolling={modelBrowserScrolling}
scrolling={isWeb ? "independent" : "sheet"}
/>
) : (
<View style={styles.sheetLoadingState}>
@@ -8,9 +8,8 @@ import {
NativeExplorerSidebarDock,
} from "@/components/compact-explorer-sidebar";
import { useOpenFileExplorerGesture } from "@/mobile-panels/gestures";
import { useIsMobilePanelActive } from "@/mobile-panels/provider";
import { useHostRuntimeClient, useHostRuntimeIsConnected } from "@/runtime/host-runtime";
import { usePanelStore } from "@/stores/panel-store";
import { selectIsCompactFileExplorerOpen, usePanelStore } from "@/stores/panel-store";
import { useWorkspaceLayoutStore } from "@/stores/workspace-layout-store";
import type { WorkspaceTabTarget } from "@/workspace-tabs/model";
import { useWorkspaceCheckoutStatus } from "@/screens/workspace/use-workspace-checkout-status";
@@ -52,7 +51,7 @@ function useActiveCompactExplorerSidebarModel(
): CompactExplorerSidebarHostModel | null {
const selection = useActiveWorkspaceSelection();
const workspace = useWorkspace(selection?.serverId ?? null, selection?.workspaceId ?? null);
const isExplorerActive = useIsMobilePanelActive("file-explorer");
const isExplorerOpen = usePanelStore(selectIsCompactFileExplorerOpen);
const showMobileAgent = usePanelStore((state) => state.showMobileAgent);
const client = useHostRuntimeClient(selection?.serverId ?? "");
const isConnected = useHostRuntimeIsConnected(selection?.serverId ?? "");
@@ -68,32 +67,32 @@ function useActiveCompactExplorerSidebarModel(
const resolvedModel = useMemo(
() =>
resolveCompactExplorerSidebarHostModel({
previous: isExplorerActive ? retainedModelRef.current : null,
previous: isExplorerOpen ? retainedModelRef.current : null,
selection,
workspace,
isGit: checkoutQuery.data?.isGit ?? false,
}),
[checkoutQuery.data?.isGit, isExplorerActive, selection, workspace],
[checkoutQuery.data?.isGit, isExplorerOpen, selection, workspace],
);
useEffect(() => {
if (!selection) {
retainedModelRef.current = null;
if (enabled && isExplorerActive) {
if (enabled && isExplorerOpen) {
showMobileAgent();
}
return;
}
if (!isExplorerActive) {
if (!isExplorerOpen) {
retainedModelRef.current = null;
return;
}
if (resolvedModel) {
retainedModelRef.current = resolvedModel;
}
}, [enabled, isExplorerActive, resolvedModel, selection, showMobileAgent]);
}, [enabled, isExplorerOpen, resolvedModel, selection, showMobileAgent]);
return selection ? (resolvedModel ?? (isExplorerActive ? retainedModelRef.current : null)) : null;
return selection ? (resolvedModel ?? (isExplorerOpen ? retainedModelRef.current : null)) : null;
}
interface CompactExplorerSidebarHostProps {
@@ -14,7 +14,6 @@ import {
type ExplorerTab,
} from "@/stores/panel-store";
import { useCloseFileExplorerGesture } from "@/mobile-panels/gestures";
import { useIsMobilePanelActive } from "@/mobile-panels/provider";
import { MobilePanelOverlay } from "@/mobile-panels/presentation";
import {
HEADER_INNER_HEIGHT,
@@ -82,7 +81,7 @@ export function CompactExplorerSidebar({
}: ExplorerSidebarProps) {
const { theme } = useUnistyles();
const insets = useSafeAreaInsets();
const isActive = useIsMobilePanelActive("file-explorer");
const isOpen = usePanelStore(selectIsCompactFileExplorerOpen);
const showMobileAgent = usePanelStore((state) => state.showMobileAgent);
const { explorerTab, handleTabPress } = useExplorerSidebarSharedState({
serverId,
@@ -100,11 +99,11 @@ export function CompactExplorerSidebar({
(reason: string) => {
logExplorerSidebar("handleClose", {
reason,
isOpen: isActive,
isOpen,
});
showMobileAgent();
},
[isActive, showMobileAgent],
[isOpen, showMobileAgent],
);
const handleHeaderClose = useCallback(() => handleClose("header-close-button"), [handleClose]);
@@ -128,7 +127,7 @@ export function CompactExplorerSidebar({
);
return (
<RetainedPanelActivity active={isActive}>
<RetainedPanelActivity active={isOpen}>
<MobilePanelOverlay
panel="file-explorer"
closeGesture={closeGesture}
@@ -142,7 +141,7 @@ export function CompactExplorerSidebar({
workspaceId={workspaceId}
workspaceRoot={workspaceRoot}
isGit={isGit}
isOpen={isActive}
isOpen={isOpen}
onOpenFile={onOpenFile}
/>
</MobilePanelOverlay>
-1
View File
@@ -1 +0,0 @@
export * from "./keyboard-dock.native";
@@ -1,21 +0,0 @@
import type { ReactNode } from "react";
import type { ViewProps } from "react-native";
import Animated, { useAnimatedStyle } from "react-native-reanimated";
import { useKeyboardShift } from "@/hooks/keyboard-shift-context";
interface KeyboardDockProps extends ViewProps {
children: ReactNode;
}
export function KeyboardDock({ children, style, ...props }: KeyboardDockProps) {
const { shift } = useKeyboardShift();
const keyboardPaddingStyle = useAnimatedStyle(() => ({
paddingBottom: shift.value,
}));
return (
<Animated.View style={[style, keyboardPaddingStyle]} {...props}>
{children}
</Animated.View>
);
}
@@ -1,10 +0,0 @@
import type { ReactNode } from "react";
import { View, type ViewProps } from "react-native";
interface KeyboardDockProps extends ViewProps {
children: ReactNode;
}
export function KeyboardDock(props: KeyboardDockProps) {
return <View {...props} />;
}
+3 -4
View File
@@ -62,6 +62,7 @@ import { usePanelStore } from "@/stores/panel-store";
import { useOwnsWindowChromeCorner, WindowChromeSafeArea } from "@/utils/desktop-window";
import { useCloseAgentListGesture } from "@/mobile-panels/gestures";
import { MobilePanelOverlay } from "@/mobile-panels/presentation";
import { useIsMobilePanelPresented } from "@/mobile-panels/provider";
import {
buildOpenProjectRoute,
buildNewWorkspaceRoute,
@@ -120,7 +121,6 @@ interface SidebarLabels {
}
interface MobileSidebarProps extends SidebarSharedProps {
active: boolean;
insetsTop: number;
insetsBottom: number;
closeSidebar: () => void;
@@ -273,7 +273,6 @@ export const LeftSidebar = memo(function LeftSidebar({ active }: { active: boole
<RetainedPanelActivity active={active}>
<MobileSidebar
{...sharedProps}
active={active}
insetsTop={insets.top}
insetsBottom={insets.bottom}
closeSidebar={showMobileAgent}
@@ -605,7 +604,6 @@ function SidebarFooter({
}
function MobileSidebar({
active,
theme,
workspaceGroups,
projectIconTargets,
@@ -640,6 +638,7 @@ function MobileSidebar({
const isSessionsActive = pathname.includes("/sessions");
const isSchedulesActive = pathname.includes("/schedules");
const { gesture: closeGesture, gestureRef: closeGestureRef } = useCloseAgentListGesture();
const dragGestureHostPresented = useIsMobilePanelPresented("agent-list");
const handleViewMore = useCallback(() => {
closeSidebar();
@@ -738,7 +737,7 @@ function MobileSidebar({
onWorkspacePress={handleWorkspacePress}
onAddProject={handleOpenProject}
parentGestureRef={closeGestureRef}
dragGestureHostActive={active}
dragGestureHostPresented={dragGestureHostPresented}
listHeaderComponent={workspacesSectionHeaderElement}
/>
)}
@@ -1,10 +1,17 @@
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { Pressable, View, type TextStyle, type ViewStyle } from "react-native";
import { Code, Workflow } from "lucide-react-native";
import React, {
useCallback,
useEffect,
useMemo,
useRef,
useState,
type ComponentType,
} from "react";
import { Pressable, View, type StyleProp, type TextStyle, type ViewStyle } from "react-native";
import { useTranslation } from "react-i18next";
import { Code, Scan, Workflow, ZoomIn, ZoomOut } from "lucide-react-native";
import { StyleSheet, withUnistyles } from "react-native-unistyles";
import { HighlightedCodeBlock } from "@/components/highlighted-code-block";
import { ZoomableViewport } from "@/components/zoomable-viewport";
import { useIsCompactFormFactor } from "@/constants/layout";
import type { Theme } from "@/styles/theme";
import type { MarkdownFenceRendererProps } from "../types";
import type { MermaidRenderRequest } from "./render-model";
@@ -14,9 +21,13 @@ import { MermaidRuntimeRequestDriver } from "./runtime/request-driver";
import { useMermaidRenderModel } from "./use-render-model";
import { getDiagramBoxStyle } from "./presentation";
interface MermaidFenceHostImplProps extends MarkdownFenceRendererProps {
colorScheme?: "light" | "dark";
}
interface MermaidIframeRuntimeProps {
request: MermaidRenderRequest | null;
height: React.CSSProperties["height"];
height: number;
onRendered: (message: {
revision: number;
source: string;
@@ -50,7 +61,9 @@ function MermaidIframeRuntime({
const sendRequest = useCallback((current: MermaidRenderRequest | null) => {
const target = iframeRef.current?.contentWindow;
if (!current || !target) return;
if (!current || !target) {
return;
}
const message: MermaidRuntimeRenderMessage = {
type: "render",
revision: current.revision,
@@ -67,9 +80,13 @@ function MermaidIframeRuntime({
useEffect(() => {
function receiveMessage(event: MessageEvent): void {
if (event.source !== iframeRef.current?.contentWindow) return;
if (event.source !== iframeRef.current?.contentWindow) {
return;
}
const message = parseMermaidRuntimeMessage(event.data);
if (!message) return;
if (!message) {
return;
}
if (message.type === "bridgeReady") {
sendRequest(driverRef.current?.ready() ?? null);
return;
@@ -99,9 +116,8 @@ function MermaidIframeRuntime({
);
}
interface MermaidFenceHostImplProps extends MarkdownFenceRendererProps {
colorScheme?: "light" | "dark";
}
const MIN_SCALE = 0.25;
const MAX_SCALE = 8;
function MermaidFenceHostImpl({
code,
@@ -117,9 +133,6 @@ function MermaidFenceHostImpl({
colorScheme,
});
const [hasRuntimeContent, setHasRuntimeContent] = useState(false);
const [showSource, setShowSource] = useState(false);
const showSourcePress = useCallback(() => setShowSource(true), []);
const showDiagramPress = useCallback(() => setShowSource(false), []);
const handleRendered = useCallback(
(message: {
revision: number;
@@ -140,18 +153,152 @@ function MermaidFenceHostImpl({
);
const visible = state.visible;
const canShowDiagram = visible !== null && hasRuntimeContent;
const diagramVisible = canShowDiagram && !showSource;
const runtimeHeight = Math.max(visible?.height ?? 240, 1);
const actions = useMemo(
() => [
{
icon: Code,
label: t("message.diagram.viewSource"),
onPress: showSourcePress,
},
],
[showSourcePress, t],
const viewportRef = useRef<HTMLDivElement | null>(null);
const contentRef = useRef<HTMLDivElement | null>(null);
const controlsRegionRef = useRef<HTMLDivElement | null>(null);
const transformRef = useRef({ x: 0, y: 0, scale: 1 });
const dragRef = useRef<{
pointerId: number;
startX: number;
startY: number;
originX: number;
originY: number;
} | null>(null);
const applyTransformToElement = useCallback(
(element: HTMLDivElement, transform: { x: number; y: number; scale: number }) => {
const { x, y, scale } = transform;
element.style.transform = `translate(${x}px, ${y}px) scale(${scale})`;
},
[],
);
const applyTransform = useCallback(() => {
if (contentRef.current) {
applyTransformToElement(contentRef.current, transformRef.current);
}
}, [applyTransformToElement]);
const setContentRef = useCallback(
(node: HTMLDivElement | null) => {
contentRef.current = node;
if (node) {
applyTransformToElement(node, transformRef.current);
}
},
[applyTransformToElement],
);
const setControlsRegionRef = useCallback((node: unknown) => {
controlsRegionRef.current = node instanceof HTMLDivElement ? node : null;
}, []);
const hasFocusedControls = useCallback(() => {
const region = controlsRegionRef.current;
const active = document.activeElement;
return Boolean(region && active instanceof Node && region.contains(active));
}, []);
const [isFocusWithin, setIsFocusWithin] = useState(false);
const handleFocusWithin = useCallback(() => setIsFocusWithin(true), []);
const handleBlurWithin = useCallback(() => {
window.requestAnimationFrame(() => setIsFocusWithin(hasFocusedControls()));
}, [hasFocusedControls]);
useEffect(() => {
const viewport = viewportRef.current;
if (!viewport || !visible) {
return;
}
const activeViewport = viewport;
function zoomWithWheel(event: WheelEvent): void {
if (!event.ctrlKey && !event.metaKey) {
return;
}
event.preventDefault();
const transform = transformRef.current;
const factor = Math.min(1.25, Math.max(0.8, Math.exp(-event.deltaY * 0.01)));
const scale = Math.min(MAX_SCALE, Math.max(MIN_SCALE, transform.scale * factor));
const rect = activeViewport.getBoundingClientRect();
const x = event.clientX - rect.left;
const y = event.clientY - rect.top;
transform.x = x - ((x - transform.x) / transform.scale) * scale;
transform.y = y - ((y - transform.y) / transform.scale) * scale;
transform.scale = scale;
applyTransform();
}
viewport.addEventListener("wheel", zoomWithWheel, { passive: false });
return () => viewport.removeEventListener("wheel", zoomWithWheel);
}, [applyTransform, visible]);
const onPointerDown = useCallback((event: React.PointerEvent<HTMLDivElement>) => {
if (event.button !== 0 || event.pointerType !== "mouse") {
return;
}
const transform = transformRef.current;
dragRef.current = {
pointerId: event.pointerId,
startX: event.clientX,
startY: event.clientY,
originX: transform.x,
originY: transform.y,
};
event.currentTarget.setPointerCapture(event.pointerId);
}, []);
const onPointerMove = useCallback(
(event: React.PointerEvent<HTMLDivElement>) => {
const drag = dragRef.current;
if (!drag || event.pointerId !== drag.pointerId) {
return;
}
transformRef.current.x = drag.originX + event.clientX - drag.startX;
transformRef.current.y = drag.originY + event.clientY - drag.startY;
applyTransform();
},
[applyTransform],
);
const onPointerUp = useCallback((event: React.PointerEvent<HTMLDivElement>) => {
if (dragRef.current?.pointerId === event.pointerId) {
dragRef.current = null;
}
}, []);
const resetTransform = useCallback(() => {
transformRef.current = { x: 0, y: 0, scale: 1 };
applyTransform();
}, [applyTransform]);
const zoomBy = useCallback(
(factor: number) => {
const viewport = viewportRef.current;
if (!viewport) {
return;
}
const rect = viewport.getBoundingClientRect();
const x = rect.width / 2;
const y = rect.height / 2;
const transform = transformRef.current;
const scale = Math.min(MAX_SCALE, Math.max(MIN_SCALE, transform.scale * factor));
transform.x = x - ((x - transform.x) / transform.scale) * scale;
transform.y = y - ((y - transform.y) / transform.scale) * scale;
transform.scale = scale;
applyTransform();
},
[applyTransform],
);
const zoomInPress = useCallback(() => zoomBy(1.25), [zoomBy]);
const zoomOutPress = useCallback(() => zoomBy(0.8), [zoomBy]);
const [showSource, setShowSource] = useState(false);
const showSourcePress = useCallback(() => setShowSource(true), []);
const showDiagramPress = useCallback(() => setShowSource(false), []);
const [isHovered, setIsHovered] = useState(false);
const handlePointerEnter = useCallback(() => setIsHovered(true), []);
const handlePointerLeave = useCallback(() => setIsHovered(false), []);
const isCompact = useIsCompactFormFactor();
const controlsVisible = isHovered || isCompact || isFocusWithin;
useEffect(() => {
if (!showSource && contentRef.current) {
applyTransformToElement(contentRef.current, transformRef.current);
}
}, [applyTransformToElement, showSource]);
const sourceView = useMemo(() => {
const { marginTop, marginBottom, marginVertical, ...sourceTextStyle } = textStyle;
const margins: ViewStyle = {
@@ -159,90 +306,182 @@ function MermaidFenceHostImpl({
marginBottom: marginBottom ?? marginVertical,
};
const text: TextStyle = sourceTextStyle;
return { container: [margins, sourceContainerStyle], text };
return {
container: [margins, sourceContainerStyle],
text,
};
}, [textStyle]);
const diagramStyle = useMemo(
() => [getDiagramBoxStyle(textStyle), containerStyle, { height: runtimeHeight }],
[runtimeHeight, textStyle],
);
const diagramSize = useMemo(
() => (visible ? { width: visible.width, height: visible.height } : MEASURING_SIZE),
[visible],
);
const sourceVisible = !diagramVisible;
const sourceContainer = showSource ? sourceView.container : sourceContainerStyle;
const sourceTextStyle = showSource ? sourceView.text : textStyle;
const viewportStyle = diagramVisible ? diagramStyle : measuringStyle;
const diagramBoxStyle = getDiagramBoxStyle(textStyle);
const diagramVisible = canShowDiagram && !showSource;
const sourceVisible = !canShowDiagram || showSource;
let rootStyle: StyleProp<ViewStyle> = sourceContainerStyle;
if (diagramVisible) {
rootStyle = [diagramBoxStyle, containerStyle];
} else if (showSource) {
rootStyle = sourceView.container;
}
const sourceTextStyle = showSource ? sourceView.text : textStyle;
const runtime = (
<MermaidIframeRuntime
request={request}
height={runtimeHeight}
onRendered={handleRendered}
onRenderFailed={renderFailed}
/>
);
return (
<>
<View
ref={setControlsRegionRef}
style={rootStyle}
onPointerEnter={handlePointerEnter}
onPointerLeave={handlePointerLeave}
onFocus={handleFocusWithin}
onBlur={handleBlurWithin}
>
{sourceVisible ? (
<View style={sourceContainer}>
<HighlightedCodeBlock
code={code}
language="mermaid"
inheritedStyles={inheritedStyles}
textStyle={sourceTextStyle}
<HighlightedCodeBlock
code={code}
language="mermaid"
inheritedStyles={inheritedStyles}
textStyle={sourceTextStyle}
/>
) : null}
<div
ref={viewportRef}
role={diagramVisible ? "img" : undefined}
aria-label={diagramVisible ? t("message.diagram.diagram") : undefined}
aria-hidden={!diagramVisible}
style={diagramVisible ? viewportDomStyle : measuringRuntimeStyle}
onPointerDown={onPointerDown}
onPointerMove={onPointerMove}
onPointerUp={onPointerUp}
onPointerCancel={onPointerUp}
onDoubleClick={resetTransform}
>
<div ref={setContentRef} style={contentDomStyle}>
{runtime}
</div>
</div>
{diagramVisible ? (
<View style={controlStyles.cluster}>
<DiagramControlButton
icon={ZoomIn}
label={t("message.diagram.zoomIn")}
onPress={zoomInPress}
visible={controlsVisible}
/>
<DiagramControlButton
icon={ZoomOut}
label={t("message.diagram.zoomOut")}
onPress={zoomOutPress}
visible={controlsVisible}
/>
<DiagramControlButton
icon={Scan}
label={t("message.diagram.resetZoom")}
onPress={resetTransform}
visible={controlsVisible}
/>
<DiagramControlButton
icon={Code}
label={t("message.diagram.viewSource")}
onPress={showSourcePress}
visible={controlsVisible}
/>
{showSource && canShowDiagram ? (
<Pressable
accessibilityLabel={t("message.diagram.viewDiagram")}
accessibilityRole="button"
hitSlop={4}
onPress={showDiagramPress}
style={controlStyles.sourceButton}
>
{({ hovered }) => (
<Workflow
size={14}
color={hovered ? controlStyles.iconHovered.color : controlStyles.icon.color}
/>
)}
</Pressable>
) : null}
</View>
) : null}
<ZoomableViewport
accessibilityLabel={t("message.diagram.diagram")}
actions={actions}
contentSize={diagramSize}
style={viewportStyle}
testID="mermaid-viewport"
wheelActivation="modifier"
>
<MermaidIframeRuntime
request={request}
height="100%"
onRendered={handleRendered}
onRenderFailed={renderFailed}
/>
</ZoomableViewport>
</>
{showSource && canShowDiagram ? (
<View style={[controlStyles.cluster, controlStyles.clusterSourceOffset]}>
<DiagramControlButton
icon={Workflow}
label={t("message.diagram.viewDiagram")}
onPress={showDiagramPress}
visible={controlsVisible}
plain
/>
</View>
) : null}
</View>
);
}
const MEASURING_SIZE = { width: 240, height: 240 };
const sourceContainerStyle: ViewStyle = { position: "relative" };
const containerStyle: ViewStyle = { overflow: "hidden", position: "relative" };
const measuringStyle: ViewStyle = {
position: "absolute",
left: 0,
right: 0,
top: 0,
height: 240,
opacity: 0,
pointerEvents: "none",
};
interface DiagramControlButtonProps {
icon: ComponentType<{ size?: number; color?: string }>;
label: string;
onPress: () => void;
visible: boolean;
plain?: boolean;
}
const DiagramControlButton = React.memo(function DiagramControlButton({
icon: Icon,
label,
onPress,
visible,
plain = false,
}: DiagramControlButtonProps) {
const pillStyle = visible ? controlStyles.button : controlStyles.buttonHidden;
const plainStyle = visible ? controlStyles.plainButton : controlStyles.plainButtonHidden;
return (
<Pressable
onPress={onPress}
style={plain ? plainStyle : pillStyle}
accessibilityRole="button"
accessibilityLabel={label}
hitSlop={4}
>
{({ hovered }) => (
<Icon
size={14}
color={hovered ? controlStyles.iconHovered.color : controlStyles.icon.color}
/>
)}
</Pressable>
);
});
const controlStyles = StyleSheet.create((theme) => ({
sourceButton: {
cluster: {
position: "absolute",
top: theme.spacing[2],
right: theme.spacing[2],
padding: theme.spacing[1],
flexDirection: "row",
gap: theme.spacing[1],
},
clusterSourceOffset: { right: 40 },
button: {
padding: theme.spacing[1],
borderRadius: theme.borderRadius.md,
backgroundColor: theme.colors.surface2,
opacity: 1,
pointerEvents: "auto",
},
buttonHidden: {
padding: theme.spacing[1],
borderRadius: theme.borderRadius.md,
backgroundColor: theme.colors.surface2,
opacity: 0,
pointerEvents: "none",
},
plainButton: { padding: theme.spacing[1], opacity: 1, pointerEvents: "auto" },
plainButtonHidden: { padding: theme.spacing[1], opacity: 0, pointerEvents: "none" },
icon: { color: theme.colors.foregroundMuted },
iconHovered: { color: theme.colors.foreground },
}));
const sourceContainerStyle: ViewStyle = { position: "relative" };
const containerStyle: ViewStyle = { overflow: "hidden", position: "relative" };
const viewportDomStyle: React.CSSProperties = { cursor: "grab", userSelect: "none" };
const contentDomStyle: React.CSSProperties = { transformOrigin: "0 0" };
const measuringRuntimeStyle: React.CSSProperties = {
position: "absolute",
inset: 0,
opacity: 0,
pointerEvents: "none",
overflow: "hidden",
};
const mapColorScheme = (theme: Theme) => ({ colorScheme: theme.colorScheme });
const ThemedMermaidFenceHost = withUnistyles(MermaidFenceHostImpl);
+20 -72
View File
@@ -42,6 +42,7 @@ import {
CircleDot,
Copy,
Plus,
RotateCcw,
TriangleAlertIcon,
Scissors,
MicVocal,
@@ -102,7 +103,7 @@ import {
AttachmentLabel,
AttachmentThumbnail,
} from "@/components/attachment-pill";
import { AttachmentLightbox, type ImageLightboxSource } from "@/components/attachment-lightbox";
import { AttachmentLightbox } from "@/components/attachment-lightbox";
import type { DaemonClient } from "@getpaseo/client/internal/daemon-client";
import { isWeb, isNative } from "@/constants/platform";
import type { AgentCapabilityFlags } from "@getpaseo/protocol/agent-types";
@@ -116,7 +117,6 @@ import {
markdownCopyTableCellDataSet,
type MarkdownCopyInlineTag,
} from "@/assistant-selection-copy/markup";
import { capAssistantMessageForRender, getUtf8ByteLength } from "./assistant-message-render-limit";
export type { InlinePathTarget } from "@/assistant-file-links";
export type { AssistantForkTarget };
@@ -441,10 +441,6 @@ export const UserMessage = memo(function UserMessage({
const [isHovered, setIsHovered] = useState(false);
const [lightboxMetadata, setLightboxMetadata] = useState<UserMessageImageAttachment | null>(null);
const handleLightboxClose = useCallback(() => setLightboxMetadata(null), []);
const lightboxSource = useMemo<ImageLightboxSource | null>(
() => (lightboxMetadata ? { type: "attachment", metadata: lightboxMetadata } : null),
[lightboxMetadata],
);
const resolvedDisableOuterSpacing = useDisableOuterSpacing(disableOuterSpacing);
const hasText = message.trim().length > 0;
const hasImages = images.length > 0;
@@ -570,7 +566,7 @@ export const UserMessage = memo(function UserMessage({
</View>
) : null}
</View>
<AttachmentLightbox source={lightboxSource} onClose={handleLightboxClose} />
<AttachmentLightbox metadata={lightboxMetadata} onClose={handleLightboxClose} />
</View>
);
});
@@ -764,13 +760,6 @@ export const assistantMessageStylesheet = StyleSheet.create((theme) => ({
containerCompactBottom: {
paddingBottom: 0,
},
cappedNotice: {
marginTop: theme.spacing[3],
fontFamily: theme.fontFamily.ui,
fontSize: theme.fontSize.base,
fontStyle: "italic",
color: theme.colors.foregroundMuted,
},
imageFrame: {
width: "100%",
minHeight: 160,
@@ -827,10 +816,6 @@ function AssistantMarkdownImage({
workspaceRoot?: string;
serverId?: string;
}) {
const { t } = useTranslation();
const [viewerOpen, setViewerOpen] = useState(false);
const openViewer = useCallback(() => setViewerOpen(true), []);
const closeViewer = useCallback(() => setViewerOpen(false), []);
const containerStyle = useMemo<StyleProp<ViewStyle>>(
() => ({
marginTop: hasLeadingContent ? 16 : 0,
@@ -863,14 +848,6 @@ function AssistantMarkdownImage({
() => [assistantMessageStylesheet.imageSurface, imageSizeStyle],
[imageSizeStyle],
);
const lightboxSource = useMemo<ImageLightboxSource | null>(() => {
if (!viewerOpen || !imageUri) return null;
return {
type: "uri",
uri: imageUri,
contentSize: aspectRatio ? { width: aspectRatio, height: 1 } : undefined,
};
}, [aspectRatio, imageUri, viewerOpen]);
const stateFrameStyle = useMemo<StyleProp<ViewStyle>>(
() => [
@@ -900,34 +877,21 @@ function AssistantMarkdownImage({
return (
<View style={frameStyle}>
<Pressable
accessibilityLabel={t("composer.attachments.openImage")}
accessibilityRole="button"
disabled={image.status !== "loaded"}
onPress={openViewer}
style={surfaceStyle}
>
<View
<View style={surfaceStyle} accessibilityRole="image" accessibilityLabel={alt}>
<Image
ref={binding.onRef}
source={imageSource}
style={assistantMessageStylesheet.image}
accessibilityRole="image"
accessibilityLabel={alt}
>
<Image
ref={binding.onRef}
source={imageSource}
style={assistantMessageStylesheet.image}
resizeMode="contain"
onLoad={binding.onLoad}
onError={binding.onError}
/>
{image.status === "loading" ? (
<View pointerEvents="none" style={assistantMessageStylesheet.imageLoadingOverlay}>
<ThemedLoadingSpinner size="small" uniProps={foregroundMutedColorMapping} />
</View>
) : null}
</View>
</Pressable>
<AttachmentLightbox source={lightboxSource} onClose={closeViewer} />
resizeMode="contain"
onLoad={binding.onLoad}
onError={binding.onError}
/>
{image.status === "loading" ? (
<View pointerEvents="none" style={assistantMessageStylesheet.imageLoadingOverlay}>
<ThemedLoadingSpinner size="small" uniProps={foregroundMutedColorMapping} />
</View>
) : null}
</View>
</View>
);
}
@@ -1496,16 +1460,10 @@ export const AssistantMessage = memo(function AssistantMessage({
spacing = "default",
phase,
}: AssistantMessageProps) {
const { t } = useTranslation();
const markdownParser = useMemo(createAssistantMarkdownParser, []);
const renderedMessage = useMemo(() => capAssistantMessageForRender(message), [message]);
// Paint a paced prefix while the turn is streaming so text arrives at a steady
// rate instead of in whatever lumps the daemon's coalescing window produced.
const revealedMessage = useRevealedText(renderedMessage.text, phase);
const fullMessageByteLength = useMemo(
() => (renderedMessage.capped && phase === "complete" ? getUtf8ByteLength(message) : null),
[message, phase, renderedMessage.capped],
);
const revealedMessage = useRevealedText(message, phase);
const fileLinkActions = useAssistantFileLinkActions();
const handleMarkdownLinkPress = useStableEvent((url: string) => {
@@ -1984,14 +1942,6 @@ export const AssistantMessage = memo(function AssistantMessage({
/>
</AssistantMessageBlockContainer>
))}
{fullMessageByteLength !== null ? (
<Text
testID="assistant-message-capped-notice"
style={assistantMessageStylesheet.cappedNotice}
>
{t("agentStream.messageCapped", { bytes: fullMessageByteLength })}
</Text>
) : null}
</View>
);
});
@@ -2311,6 +2261,8 @@ function taskActivityIcon(activity: TaskActivity) {
return CircleDot;
case "completed":
return Check;
case "reopened":
return RotateCcw;
default:
return CheckSquare;
}
@@ -3168,7 +3120,6 @@ export const ToolCall = memo(function ToolCall({
const handleToggle = useCallback(() => {
if (!shouldRenderInline) {
openToolCall({
toolName,
displayName: presentation.displayName,
summary: presentation.summary,
detail: effectiveDetail,
@@ -3182,7 +3133,6 @@ export const ToolCall = memo(function ToolCall({
}, [
shouldRenderInline,
openToolCall,
toolName,
presentation.displayName,
presentation.summary,
presentation.errorText,
@@ -3223,7 +3173,6 @@ export const ToolCall = memo(function ToolCall({
if (!shouldRenderInline) return null;
return (
<ToolCallDetailsContent
toolName={toolName}
detail={effectiveDetail}
errorText={presentation.errorText}
maxHeight={maxDetailHeight}
@@ -3232,7 +3181,6 @@ export const ToolCall = memo(function ToolCall({
);
}, [
shouldRenderInline,
toolName,
effectiveDetail,
presentation.errorText,
presentation.isLoadingDetails,
@@ -7,7 +7,6 @@ import {
resolveInitialModelBrowserView,
resolveModelBrowserAllView,
groupProfilesByProviderModel,
resolveModelBrowserScrolling,
} from "./model-browser-view";
function provider(
@@ -38,20 +37,6 @@ function modelRow(
};
}
describe("model browser scrolling", () => {
it("participates in native compact bottom-sheet scrolling", () => {
expect(resolveModelBrowserScrolling({ isNative: true, isCompact: true })).toBe("sheet");
});
it.each([
{ platform: "native wide", isNative: true, isCompact: false },
{ platform: "compact web", isNative: false, isCompact: true },
{ platform: "wide web", isNative: false, isCompact: false },
])("owns scrolling on $platform surfaces", ({ isNative, isCompact }) => {
expect(resolveModelBrowserScrolling({ isNative, isCompact })).toBe("independent");
});
});
describe("model browser initial view", () => {
const codex = provider("codex", "Codex");
const pi = provider("pi", "Pi");
@@ -9,16 +9,6 @@ export type ModelBrowserView =
| { kind: "all" }
| { kind: "provider"; providerId: string; providerLabel: string };
export function resolveModelBrowserScrolling({
isNative,
isCompact,
}: {
isNative: boolean;
isCompact: boolean;
}): "sheet" | "independent" {
return isNative && isCompact ? "sheet" : "independent";
}
/** A profile's model reference; used to match profiles back to model rows. */
export interface ModelProfileRef {
provider: string;
@@ -234,7 +234,7 @@ interface SidebarWorkspaceListProps {
listHeaderComponent?: ReactElement | null;
/** Gesture ref for coordinating with parent gestures (e.g., sidebar close) */
parentGestureRef?: MutableRefObject<GestureType | undefined>;
dragGestureHostActive?: boolean;
dragGestureHostPresented?: boolean;
}
interface ProjectHeaderRowProps {
@@ -1540,7 +1540,7 @@ function ProjectBlock({
isDragging,
dragHandleProps,
useNestable,
dragGestureHostActive,
dragGestureHostPresented,
creatingWorkspaceIds,
activeWorkspaceSelection,
hostBadgeByServerId,
@@ -1565,7 +1565,7 @@ function ProjectBlock({
isDragging: boolean;
dragHandleProps?: DraggableListDragHandleProps;
useNestable: boolean;
dragGestureHostActive?: boolean;
dragGestureHostPresented?: boolean;
creatingWorkspaceIds: ReadonlySet<string>;
activeWorkspaceSelection: ActiveWorkspaceSelection | null;
hostBadgeByServerId: ReadonlyMap<string, HostBadgeModel>;
@@ -1745,7 +1745,7 @@ function ProjectBlock({
useDragHandle
nestable={useNestable}
simultaneousGestureRef={parentGestureRef}
gestureHostPresented={dragGestureHostActive}
gestureHostPresented={dragGestureHostPresented}
containerStyle={styles.workspaceListContainer}
/>
{canToggleWorkspaces ? (
@@ -1829,7 +1829,7 @@ function areProjectBlockPropsEqual(previous: ProjectBlockProps, next: ProjectBlo
previous.isDragging === next.isDragging &&
previous.dragHandleProps === next.dragHandleProps &&
previous.useNestable === next.useNestable &&
previous.dragGestureHostActive === next.dragGestureHostActive &&
previous.dragGestureHostPresented === next.dragGestureHostPresented &&
previous.creatingWorkspaceIds === next.creatingWorkspaceIds &&
areProjectBlockSelectionsEqual(previous, next)
);
@@ -1882,7 +1882,7 @@ export function SidebarWorkspaceList({
listFooterComponent,
listHeaderComponent,
parentGestureRef,
dragGestureHostActive,
dragGestureHostPresented,
}: SidebarWorkspaceListProps) {
const pathname = usePathname();
const hosts = useHosts();
@@ -1959,7 +1959,7 @@ export function SidebarWorkspaceList({
listHeaderComponent={listHeaderComponent}
sidebarFilterEmpty={sidebarFilterEmpty}
parentGestureRef={parentGestureRef}
dragGestureHostActive={dragGestureHostActive}
dragGestureHostPresented={dragGestureHostPresented}
/>
) : (
<ProjectModeList
@@ -1977,7 +1977,7 @@ export function SidebarWorkspaceList({
sidebarFilterEmpty={sidebarFilterEmpty}
hasActiveProjectFilter={hasActiveProjectFilter}
parentGestureRef={parentGestureRef}
dragGestureHostActive={dragGestureHostActive}
dragGestureHostPresented={dragGestureHostPresented}
pathname={pathname}
hostBadgeByServerId={hostBadgeByServerId}
supportsMultiplicityByServerId={supportsMultiplicityByServerId}
@@ -2010,7 +2010,7 @@ function SidebarGroupedModeList({
listHeaderComponent,
sidebarFilterEmpty,
parentGestureRef,
dragGestureHostActive,
dragGestureHostPresented,
}: {
workspaceGroups: SidebarWorkspaceGroup[];
pinnedGroups: PinnedSidebarGroups;
@@ -2025,7 +2025,7 @@ function SidebarGroupedModeList({
listHeaderComponent?: ReactElement | null;
sidebarFilterEmpty: boolean;
parentGestureRef?: MutableRefObject<GestureType | undefined>;
dragGestureHostActive?: boolean;
dragGestureHostPresented?: boolean;
}) {
const showShortcutBadges = useShowShortcutBadges();
const pinnedWorkspaces = useMemo(
@@ -2052,7 +2052,7 @@ function SidebarGroupedModeList({
listHeaderComponent={listHeaderComponent}
sidebarFilterEmpty={sidebarFilterEmpty}
parentGestureRef={parentGestureRef}
dragGestureHostActive={dragGestureHostActive}
dragGestureHostPresented={dragGestureHostPresented}
/>
);
}
@@ -2072,7 +2072,7 @@ function ProjectModeList({
sidebarFilterEmpty,
hasActiveProjectFilter,
parentGestureRef,
dragGestureHostActive,
dragGestureHostPresented,
pathname,
hostBadgeByServerId,
supportsMultiplicityByServerId,
@@ -2289,7 +2289,7 @@ function ProjectModeList({
isDragging={dragState.isDragging}
dragHandleProps={dragState.dragHandleProps}
useNestable={platformIsNative}
dragGestureHostActive={dragGestureHostActive}
dragGestureHostPresented={dragGestureHostPresented}
creatingWorkspaceIds={creatingWorkspaceIds}
activeWorkspaceSelection={activeWorkspaceSelection}
hostBadgeByServerId={hostBadgeByServerId}
@@ -2311,7 +2311,7 @@ function ProjectModeList({
onWorkspacePress,
onToggleProjectCollapsed,
parentGestureRef,
dragGestureHostActive,
dragGestureHostPresented,
projectIconByProjectViewKey,
selectionEnabled,
shortcutIndexByWorkspaceKey,
@@ -2388,7 +2388,7 @@ function ProjectModeList({
useDragHandle
nestable={platformIsNative}
simultaneousGestureRef={parentGestureRef}
gestureHostPresented={dragGestureHostActive}
gestureHostPresented={dragGestureHostPresented}
containerStyle={styles.projectListContainer}
/>
);
@@ -2411,7 +2411,7 @@ function ProjectModeList({
useDragHandle
nestable={platformIsNative}
simultaneousGestureRef={parentGestureRef}
gestureHostPresented={dragGestureHostActive}
gestureHostPresented={dragGestureHostPresented}
containerStyle={styles.workspaceListContainer}
/>
{canTogglePinnedChats ? (
@@ -126,7 +126,7 @@ interface StatusWorkspaceListProps {
/** Swaps the group list for the label filter's empty state. Never the header above it. */
sidebarFilterEmpty?: boolean;
parentGestureRef?: MutableRefObject<GestureType | undefined>;
dragGestureHostActive?: boolean;
dragGestureHostPresented?: boolean;
}
export function SidebarStatusWorkspaceList({
@@ -143,7 +143,7 @@ export function SidebarStatusWorkspaceList({
listHeaderComponent,
sidebarFilterEmpty = false,
parentGestureRef,
dragGestureHostActive,
dragGestureHostPresented,
}: StatusWorkspaceListProps) {
const collapsedWorkspaceGroupKeys = useSidebarCollapsedSectionsStore(
(state) => state.collapsedWorkspaceGroupKeys,
@@ -214,7 +214,7 @@ export function SidebarStatusWorkspaceList({
useDragHandle
nestable={platformIsNative}
simultaneousGestureRef={parentGestureRef}
gestureHostPresented={dragGestureHostActive}
gestureHostPresented={dragGestureHostPresented}
/>
{canTogglePinnedWorkspaces ? (
<SidebarGroupToggleRow
@@ -11,10 +11,6 @@ import { StyleSheet } from "react-native-unistyles";
import type { TFunction } from "i18next";
import { useTranslation } from "react-i18next";
import type { ToolCallDetail } from "@getpaseo/protocol/agent-types";
import {
buildPaseoToolDetailSections,
type PaseoToolDetailSection,
} from "@getpaseo/protocol/paseo-tool-call-detail";
import { buildLineDiff, parseUnifiedDiff, type DiffLine } from "@/utils/tool-call-parsers";
import { highlightDiffLines } from "@/utils/diff-highlight";
import { hasMeaningfulToolCallDetail } from "@/utils/tool-call-detail-state";
@@ -31,7 +27,6 @@ const ScrollView = isWeb ? RNScrollView : GHScrollView;
// ---- Content Component ----
interface ToolCallDetailsContentProps {
toolName?: string;
detail?: ToolCallDetail;
errorText?: string;
maxHeight?: number;
@@ -631,42 +626,7 @@ function buildUnknownSections(detail: UnknownDetail, ds: DetailStyles, t: TFunct
return out;
}
function PaseoDetailSection({ section }: { section: PaseoToolDetailSection }) {
return (
<View style={styles.paseoSection}>
<Text style={styles.paseoSectionTitle}>{section.title}</Text>
{section.kind === "prose" ? (
<Text selectable style={styles.paseoProse}>
{section.text}
</Text>
) : (
<View style={styles.paseoFields}>
{section.fields.map((field) => (
<View key={field.label} style={styles.paseoFieldRow}>
<Text style={styles.paseoFieldLabel}>{field.label}</Text>
<Text selectable style={styles.paseoFieldValue}>
{field.value}
</Text>
</View>
))}
</View>
)}
</View>
);
}
function buildPaseoUnknownSections(
toolName: string | undefined,
detail: UnknownDetail,
): ReactNode[] | null {
if (!toolName) return null;
const sections = buildPaseoToolDetailSections(toolName, detail.input, detail.output);
if (!sections) return null;
return sections.map((section) => <PaseoDetailSection key={section.title} section={section} />);
}
function buildDetailSections(
toolName: string | undefined,
detail: ToolCallDetail | undefined,
diffLines: DiffLine[] | undefined,
ds: DetailStyles,
@@ -741,7 +701,7 @@ function buildDetailSections(
return [<ScrollablePlainTextSection key="plain-text" text={detail.text} ds={ds} />];
}
if (detail.type === "unknown") {
return buildPaseoUnknownSections(toolName, detail) ?? buildUnknownSections(detail, ds, t);
return buildUnknownSections(detail, ds, t);
}
return [];
}
@@ -781,7 +741,6 @@ function LoadingSkeleton({ containerStyle }: { containerStyle: StyleProp<ViewSty
}
export function ToolCallDetailsContent({
toolName,
detail,
errorText,
maxHeight,
@@ -793,7 +752,7 @@ export function ToolCallDetailsContent({
const ds = useDetailStyles(detail, resolvedMaxHeight, fillAvailableHeight);
const diffLines = useDiffLines(detail);
const sections: ReactNode[] = buildDetailSections(toolName, detail, diffLines, ds, t);
const sections: ReactNode[] = buildDetailSections(detail, diffLines, ds, t);
if (errorText) {
sections.push(<ErrorSection key="error" errorText={errorText} ds={ds} />);
@@ -837,46 +796,6 @@ const styles = StyleSheet.create((theme) => {
fontSize: theme.fontSize.base,
fontWeight: theme.fontWeight.normal,
},
paseoSection: {
gap: theme.spacing[3],
paddingHorizontal: theme.spacing[4],
paddingVertical: theme.spacing[4],
borderBottomWidth: theme.borderWidth[1],
borderBottomColor: theme.colors.border,
},
paseoSectionTitle: {
color: theme.colors.foreground,
fontSize: theme.fontSize.base,
fontWeight: theme.fontWeight.medium,
},
paseoProse: {
color: theme.colors.foreground,
fontSize: theme.fontSize.content,
lineHeight: Math.round(theme.fontSize.content * 1.5),
overflowWrap: "anywhere",
},
paseoFields: {
gap: theme.spacing[3],
},
paseoFieldRow: {
flexDirection: "row",
alignItems: "flex-start",
gap: theme.spacing[4],
},
paseoFieldLabel: {
width: 120,
color: theme.colors.foregroundMuted,
fontSize: theme.fontSize.sm,
lineHeight: Math.round(theme.fontSize.base * 1.5),
},
paseoFieldValue: {
flex: 1,
minWidth: 0,
color: theme.colors.foreground,
fontSize: theme.fontSize.base,
lineHeight: Math.round(theme.fontSize.base * 1.5),
overflowWrap: "anywhere",
},
section: {
gap: theme.spacing[2],
},
@@ -17,7 +17,6 @@ import { ToolCallDetailsContent } from "./tool-call-details";
// ----- Types -----
export interface ToolCallSheetData {
toolName: string;
displayName: string;
summary?: string;
detail?: ToolCallDetail;
@@ -156,14 +155,7 @@ interface ToolCallSheetContentProps {
function ToolCallSheetContent({ data, onClose }: ToolCallSheetContentProps) {
const { t } = useTranslation();
const {
toolName,
displayName,
detail,
errorText,
icon: IconComponent,
showLoadingSkeleton,
} = data;
const { displayName, detail, errorText, icon: IconComponent, showLoadingSkeleton } = data;
return (
<View style={styles.container}>
@@ -189,7 +181,6 @@ function ToolCallSheetContent({ data, onClose }: ToolCallSheetContentProps) {
{/* Content */}
<BottomSheetScrollView style={styles.content} contentContainerStyle={styles.contentContainer}>
<ToolCallDetailsContent
toolName={toolName}
detail={detail}
errorText={errorText}
fillAvailableHeight
@@ -2,7 +2,6 @@ import { useEffect, useMemo, useState, type ReactElement, type RefObject } from
import { Keyboard, View, useWindowDimensions } from "react-native";
import { Portal } from "@gorhom/portal";
import Animated, { useAnimatedStyle, useSharedValue } from "react-native-reanimated";
import { useSafeAreaInsets } from "react-native-safe-area-context";
import { StyleSheet } from "react-native-unistyles";
import { Autocomplete, type AutocompleteOption } from "@/components/ui/autocomplete";
import {
@@ -64,10 +63,9 @@ export function AutocompletePopover({
// React Compiler memoizes effect captures by reading SharedValue.value during render.
const [relativeAnchorRect, setRelativeAnchorRect] = useState<RelativeAnchorRect | null>(null);
const windowDimensions = useWindowDimensions();
const safeAreaInsets = useSafeAreaInsets();
const portalHostName = useFloatingPanelPortalHostName();
const { shift } = useKeyboardShift();
const measuredShift = useSharedValue(0);
const openShift = useSharedValue(0);
useEffect(() => {
if (!visible || (options.length > 0 && selectedIndex < 0)) {
@@ -90,7 +88,7 @@ export function AutocompletePopover({
width: anchorRect.width,
hostHeight: hostRect.height,
});
measuredShift.value = shift.value;
openShift.value = shift.value;
return undefined;
});
};
@@ -112,7 +110,7 @@ export function AutocompletePopover({
selectedIndex,
anchorRef,
portalHostName,
measuredShift,
openShift,
shift,
windowDimensions.width,
windowDimensions.height,
@@ -122,22 +120,20 @@ export function AutocompletePopover({
if (!relativeAnchorRect) return null;
return inlineUnistylesStyle({
position: "absolute" as const,
bottom: relativeAnchorRect.hostHeight - relativeAnchorRect.y + OFFSET_FROM_ANCHOR,
left: relativeAnchorRect.x,
width: relativeAnchorRect.width,
});
}, [relativeAnchorRect]);
const anchorY = relativeAnchorRect?.y ?? 0;
const baseBottom = relativeAnchorRect
? relativeAnchorRect.hostHeight - relativeAnchorRect.y + OFFSET_FROM_ANCHOR
: 0;
const keyboardLayoutStyle = useAnimatedStyle(() => {
const shiftDelta = shift.value - measuredShift.value;
return {
bottom: baseBottom + shiftDelta,
maxHeight: Math.max(0, anchorY - shiftDelta - safeAreaInsets.top - OFFSET_FROM_ANCHOR * 2),
};
}, [anchorY, baseBottom, safeAreaInsets.top]);
const animatedTransformStyle = useAnimatedStyle(() => ({
transform: [{ translateY: openShift.value - shift.value }],
}));
const composedStyle = useMemo(
() => [baseStyle, animatedTransformStyle],
[baseStyle, animatedTransformStyle],
);
if (!visible || !relativeAnchorRect || !baseStyle) return null;
if (options.length > 0 && selectedIndex < 0) return null;
@@ -145,10 +141,7 @@ export function AutocompletePopover({
return (
<Portal hostName={portalHostName}>
<View style={styles.overlay} pointerEvents="box-none">
<Animated.View
testID="composer-autocomplete-popover"
style={[baseStyle, keyboardLayoutStyle]}
>
<Animated.View testID="composer-autocomplete-popover" style={composedStyle}>
<Autocomplete
options={options}
selectedIndex={selectedIndex}
@@ -288,8 +288,6 @@ export function Autocomplete({
const styles = StyleSheet.create((theme: Theme) => ({
outerWrapper: {
flexShrink: 1,
minHeight: 0,
gap: theme.spacing[1],
},
detailCard: {
@@ -317,8 +315,6 @@ const styles = StyleSheet.create((theme: Theme) => ({
marginTop: theme.spacing[1],
},
container: {
flexShrink: 1,
minHeight: 0,
backgroundColor: theme.colors.surface1,
borderWidth: theme.borderWidth[1],
borderColor: theme.colors.borderAccent,
@@ -92,45 +92,6 @@ describe("EditingTextInputNative", () => {
expect(handleRef.current?.getText()).toBe("");
});
it("replaces the native input when clearing text", () => {
const handleRef = createRef<EditingTextInputHandle>();
act(() => {
root?.render(
<EditingTextInput
ref={handleRef}
initialValue="line one\nline two\nline three"
onChangeText={noop}
/>,
);
});
const grownInput = container?.querySelector("input");
act(() => {
handleRef.current?.replaceText("");
});
expect(container?.querySelector("input")).not.toBe(grownInput);
});
it("restores focus after replacing a cleared native input", () => {
const handleRef = createRef<EditingTextInputHandle>();
act(() => {
root?.render(<EditingTextInput ref={handleRef} initialValue="message" />);
});
const originalInput = container?.querySelector("input");
if (!originalInput) throw new Error("Expected native input");
Object.assign(originalInput, { isFocused: () => true });
originalInput.focus();
act(() => {
handleRef.current?.replaceText("");
});
expect(document.activeElement).toBe(container?.querySelector("input"));
});
it("updates textRef and text when replaceText receives non-empty text", () => {
const handleRef = createRef<EditingTextInputHandle>();
@@ -1,4 +1,4 @@
import React, { forwardRef, useCallback, useImperativeHandle, useRef, useState } from "react";
import React, { forwardRef, useCallback, useImperativeHandle, useRef } from "react";
import { TextInput } from "react-native";
import { BottomSheetTextInput } from "@gorhom/bottom-sheet";
import PasteInput, {
@@ -11,7 +11,7 @@ import type { EditingTextInputHandle, EditingTextInputProps } from "./types";
type NativeInput = (TextInput | PasteTextInputInstance) & {
blur(): void;
focus(): void;
isFocused?(): boolean;
isFocused(): boolean;
clear?(): void;
replaceText?(text: string, selection?: { start: number; end: number }): void;
setNativeProps?(props: { text?: string; selection?: { start: number; end: number } }): void;
@@ -35,41 +35,26 @@ export const EditingTextInput = forwardRef<EditingTextInputHandle, EditingTextIn
const inputRef = useRef<NativeInput | null>(null);
const initialTextRef = useRef(initialValue);
const textRef = useRef(initialTextRef.current);
const restoreFocusAfterResetRef = useRef(false);
const [nativeInputRevision, setNativeInputRevision] = useState(0);
const assignInputRef = useCallback((input: NativeInput | null) => {
inputRef.current = input;
if (!input || !restoreFocusAfterResetRef.current) return;
restoreFocusAfterResetRef.current = false;
input.focus();
}, []);
useImperativeHandle(ref, () => ({
focus: () => inputRef.current?.focus(),
blur: () => inputRef.current?.blur(),
isFocused: () => inputRef.current?.isFocused?.() ?? false,
isFocused: () => inputRef.current?.isFocused() ?? false,
getText: () => textRef.current,
replaceText: (nextText, selection) => {
textRef.current = nextText;
if (nextText === "") {
restoreFocusAfterResetRef.current = inputRef.current?.isFocused?.() ?? false;
if (inputRef.current?.replaceText) {
inputRef.current.replaceText(nextText, selection);
} else {
inputRef.current?.clear?.();
}
setNativeInputRevision((revision) => revision + 1);
return;
}
if (inputRef.current?.replaceText) {
inputRef.current.replaceText(nextText, selection);
return;
}
inputRef.current?.setNativeProps?.({
text: nextText,
...(selection ? { selection } : {}),
});
if (nextText === "") {
inputRef.current?.clear?.();
} else {
inputRef.current?.setNativeProps?.({
text: nextText,
...(selection ? { selection } : {}),
});
}
if (selection) inputRef.current?.setSelection?.(selection.start, selection.end);
},
getNativeRef: () => inputRef.current?.getNativeRef?.() ?? inputRef.current,
@@ -97,9 +82,8 @@ export const EditingTextInput = forwardRef<EditingTextInputHandle, EditingTextIn
return (
<PasteInput
{...props}
key={nativeInputRevision}
ref={assignInputRef as React.Ref<PasteTextInputInstance>}
defaultValue={textRef.current}
ref={inputRef as React.Ref<PasteTextInputInstance>}
defaultValue={initialTextRef.current}
onChangeText={handleChangeText}
onPaste={handlePaste}
/>
@@ -109,9 +93,8 @@ export const EditingTextInput = forwardRef<EditingTextInputHandle, EditingTextIn
return (
<BottomSheetTextInput
{...props}
key={nativeInputRevision}
ref={assignInputRef as unknown as React.Ref<never>}
defaultValue={textRef.current}
ref={inputRef as unknown as React.Ref<never>}
defaultValue={initialTextRef.current}
onChangeText={handleChangeText}
/>
);
@@ -119,9 +102,8 @@ export const EditingTextInput = forwardRef<EditingTextInputHandle, EditingTextIn
return (
<TextInput
{...props}
key={nativeInputRevision}
ref={assignInputRef as React.Ref<TextInput>}
defaultValue={textRef.current}
ref={inputRef as React.Ref<TextInput>}
defaultValue={initialTextRef.current}
onChangeText={handleChangeText}
/>
);
@@ -1,108 +0,0 @@
import { describe, expect, it } from "vitest";
import {
FIT_TRANSFORM,
clampTransform,
fitContentSize,
isActivePinchUpdate,
isPointInsideTransformedContent,
panContent,
zoomContentAtPoint,
} from "./geometry";
const viewport = { width: 800, height: 600 };
const fittedContent = { width: 800, height: 400 };
describe("zoomable viewport geometry", () => {
it("rejects Android's terminal pinch update after a touch has lifted", () => {
expect(isActivePinchUpdate(1, 2)).toBe(false);
expect(isActivePinchUpdate(2, 2)).toBe(true);
});
it("fits content inside the viewport without changing its aspect ratio", () => {
expect(fitContentSize({ width: 1600, height: 800 }, viewport)).toEqual(fittedContent);
expect(fitContentSize({ width: 400, height: 800 }, viewport)).toEqual({
width: 300,
height: 600,
});
});
it("fits within presentation padding and caps without shrinking the zoom viewport", () => {
expect(
fitContentSize({ width: 1600, height: 800 }, viewport, {
padding: 20,
maxWidth: 600,
maxHeight: 500,
}),
).toEqual({ width: 600, height: 300 });
});
it("distinguishes backdrop taps from taps on transformed content", () => {
expect(
isPointInsideTransformedContent({
point: { x: 400, y: 300 },
transform: FIT_TRANSFORM,
fittedContent,
viewport,
}),
).toBe(true);
expect(
isPointInsideTransformedContent({
point: { x: 400, y: 50 },
transform: FIT_TRANSFORM,
fittedContent,
viewport,
}),
).toBe(false);
expect(
isPointInsideTransformedContent({
point: { x: 10, y: 10 },
transform: { scale: 2, x: 0, y: 0 },
fittedContent,
viewport,
}),
).toBe(true);
});
it("returns to the centered fit transform at the minimum scale", () => {
expect(
clampTransform({ scale: 0.5, x: 200, y: -200 }, fittedContent, viewport, {
minScale: 1,
maxScale: 8,
}),
).toEqual(FIT_TRANSFORM);
});
it("keeps the focal content point under the cursor while zooming", () => {
expect(
zoomContentAtPoint({
transform: FIT_TRANSFORM,
scale: 2,
focalPoint: { x: 600, y: 300 },
fittedContent,
viewport,
limits: { minScale: 1, maxScale: 8 },
}),
).toEqual({ scale: 2, x: -200, y: 0 });
});
it("clamps panning to the scaled content edges", () => {
expect(
panContent({
transform: { scale: 2, x: 0, y: 0 },
delta: { x: 900, y: -900 },
fittedContent,
viewport,
limits: { minScale: 1, maxScale: 8 },
}),
).toEqual({ scale: 2, x: 400, y: -100 });
});
it("allows Mermaid consumers to zoom below fit without inventing translation", () => {
expect(
clampTransform({ scale: 0.25, x: 100, y: 100 }, fittedContent, viewport, {
minScale: 0.25,
maxScale: 8,
}),
).toEqual({ scale: 0.25, x: 0, y: 0 });
});
});
@@ -1,148 +0,0 @@
export interface ViewportSize {
width: number;
height: number;
}
export interface ViewportPoint {
x: number;
y: number;
}
export interface ViewportTransform {
scale: number;
x: number;
y: number;
}
export interface ViewportScaleLimits {
minScale: number;
maxScale: number;
}
export interface ViewportFitOptions {
padding?: number;
maxWidth?: number;
maxHeight?: number;
}
export const FIT_TRANSFORM: ViewportTransform = { scale: 1, x: 0, y: 0 };
export function isActivePinchUpdate(activeTouches: number, reportedPointers: number): boolean {
"worklet";
return activeTouches >= 2 && reportedPointers >= 2;
}
export function isPointInsideTransformedContent(input: {
point: ViewportPoint;
transform: ViewportTransform;
fittedContent: ViewportSize;
viewport: ViewportSize;
}): boolean {
"worklet";
const centerX = input.viewport.width / 2 + input.transform.x;
const centerY = input.viewport.height / 2 + input.transform.y;
const halfWidth = (input.fittedContent.width * input.transform.scale) / 2;
const halfHeight = (input.fittedContent.height * input.transform.scale) / 2;
return (
input.point.x >= centerX - halfWidth &&
input.point.x <= centerX + halfWidth &&
input.point.y >= centerY - halfHeight &&
input.point.y <= centerY + halfHeight
);
}
export function fitContentSize(
content: ViewportSize,
viewport: ViewportSize,
options: ViewportFitOptions = {},
): ViewportSize {
const padding = options.padding ?? 0;
const availableWidth = Math.max(
0,
Math.min(viewport.width - padding * 2, options.maxWidth ?? Number.POSITIVE_INFINITY),
);
const availableHeight = Math.max(
0,
Math.min(viewport.height - padding * 2, options.maxHeight ?? Number.POSITIVE_INFINITY),
);
const fitScale = Math.min(availableWidth / content.width, availableHeight / content.height);
return {
width: content.width * fitScale,
height: content.height * fitScale,
};
}
function clampScale(scale: number, limits: ViewportScaleLimits): number {
return Math.min(limits.maxScale, Math.max(limits.minScale, scale));
}
function clampOffset(offset: number, maximum: number): number {
if (maximum === 0) {
return 0;
}
return Math.min(maximum, Math.max(-maximum, offset));
}
export function clampTransform(
transform: ViewportTransform,
fittedContent: ViewportSize,
viewport: ViewportSize,
limits: ViewportScaleLimits,
): ViewportTransform {
const scale = clampScale(transform.scale, limits);
const maxX = Math.max(0, (fittedContent.width * scale - viewport.width) / 2);
const maxY = Math.max(0, (fittedContent.height * scale - viewport.height) / 2);
return {
scale,
x: clampOffset(transform.x, maxX),
y: clampOffset(transform.y, maxY),
};
}
export function zoomContentAtPoint(input: {
transform: ViewportTransform;
scale: number;
focalPoint: ViewportPoint;
fittedContent: ViewportSize;
viewport: ViewportSize;
limits: ViewportScaleLimits;
}): ViewportTransform {
const scale = clampScale(input.scale, input.limits);
const viewportCenter = {
x: input.viewport.width / 2,
y: input.viewport.height / 2,
};
const contentPoint = {
x: (input.focalPoint.x - viewportCenter.x - input.transform.x) / input.transform.scale,
y: (input.focalPoint.y - viewportCenter.y - input.transform.y) / input.transform.scale,
};
return clampTransform(
{
scale,
x: input.focalPoint.x - viewportCenter.x - contentPoint.x * scale,
y: input.focalPoint.y - viewportCenter.y - contentPoint.y * scale,
},
input.fittedContent,
input.viewport,
input.limits,
);
}
export function panContent(input: {
transform: ViewportTransform;
delta: ViewportPoint;
fittedContent: ViewportSize;
viewport: ViewportSize;
limits: ViewportScaleLimits;
}): ViewportTransform {
return clampTransform(
{
...input.transform,
x: input.transform.x + input.delta.x,
y: input.transform.y + input.delta.y,
},
input.fittedContent,
input.viewport,
input.limits,
);
}
@@ -1,102 +0,0 @@
import { useEffect, useMemo, useState } from "react";
import { Image, View, type StyleProp, type ViewStyle } from "react-native";
import { StyleSheet } from "react-native-unistyles";
import type { ViewportFitOptions, ViewportSize } from "./geometry";
import { ZoomableViewport } from "./index";
import type { ZoomableViewportAction } from "./types";
interface ZoomableImageProps {
uri: string;
accessibilityLabel?: string;
actions?: ZoomableViewportAction[];
contentSize?: ViewportSize;
fit?: ViewportFitOptions;
maxScale?: number;
minScale?: number;
onError?: () => void;
onPressOutsideContent?: () => void;
style?: StyleProp<ViewStyle>;
testID?: string;
wheelActivation?: "always" | "modifier";
}
export function ZoomableImage({
uri,
accessibilityLabel,
actions,
contentSize,
fit,
maxScale,
minScale = 1,
onError,
onPressOutsideContent,
style,
testID = "zoomable-image",
wheelActivation = "always",
}: ZoomableImageProps) {
const [loadedSize, setLoadedSize] = useState<ViewportSize | null>(null);
const resolvedSize = contentSize ?? loadedSize;
const source = useMemo(() => ({ uri }), [uri]);
useEffect(() => {
if (contentSize) return;
let active = true;
setLoadedSize(null);
Image.getSize(
uri,
(width, height) => {
if (active && width > 0 && height > 0) setLoadedSize({ width, height });
},
() => {
if (active) onError?.();
},
);
return () => {
active = false;
};
}, [contentSize, onError, uri]);
if (!resolvedSize) {
return (
<View style={[styles.root, style]} testID={testID}>
<Image
accessibilityLabel={accessibilityLabel}
accessibilityRole="image"
onError={onError}
resizeMode="contain"
source={source}
style={styles.image}
testID={`${testID}-image`}
/>
</View>
);
}
return (
<ZoomableViewport
accessibilityLabel={accessibilityLabel}
actions={actions}
contentSize={resolvedSize}
fit={fit}
maxScale={maxScale}
minScale={minScale}
onPressOutsideContent={onPressOutsideContent}
style={style}
testID={testID}
wheelActivation={wheelActivation}
>
<Image
onError={onError}
resizeMode="contain"
source={source}
style={styles.image}
testID={`${testID}-image`}
/>
</ZoomableViewport>
);
}
const styles = StyleSheet.create(() => ({
root: { flex: 1, minHeight: 0 },
image: { width: "100%", height: "100%" },
}));
@@ -1,252 +0,0 @@
import { useCallback, useEffect, useMemo, useState } from "react";
import { View, type LayoutChangeEvent } from "react-native";
import { Gesture, GestureDetector } from "react-native-gesture-handler";
import Animated, { runOnJS, useAnimatedStyle, useSharedValue } from "react-native-reanimated";
import { StyleSheet } from "react-native-unistyles";
import {
FIT_TRANSFORM,
fitContentSize,
isActivePinchUpdate,
isPointInsideTransformedContent,
zoomContentAtPoint,
type ViewportSize,
} from "./geometry";
import { ViewportToolbar } from "./toolbar";
import type { ZoomableViewportProps } from "./types";
const DEFAULT_MAX_SCALE = 8;
const DEFAULT_MIN_SCALE = 0.25;
export function ZoomableViewport({
contentSize,
children,
actions = [],
accessibilityLabel,
fit,
maxScale = DEFAULT_MAX_SCALE,
minScale = DEFAULT_MIN_SCALE,
onPressOutsideContent,
style,
testID,
}: ZoomableViewportProps) {
const [viewport, setViewport] = useState<ViewportSize | null>(null);
const [toolbarScale, setToolbarScale] = useState(1);
const scale = useSharedValue(1);
const translateX = useSharedValue(0);
const translateY = useSharedValue(0);
const startScale = useSharedValue(1);
const startX = useSharedValue(0);
const startY = useSharedValue(0);
const pinchFocalX = useSharedValue(0);
const pinchFocalY = useSharedValue(0);
const pinchReady = useSharedValue(false);
const pinchTouchCount = useSharedValue(0);
const fittedContent = useMemo(
() => (viewport ? fitContentSize(contentSize, viewport, fit) : null),
[contentSize, fit, viewport],
);
const reset = useCallback(() => {
scale.value = FIT_TRANSFORM.scale;
translateX.value = FIT_TRANSFORM.x;
translateY.value = FIT_TRANSFORM.y;
setToolbarScale(FIT_TRANSFORM.scale);
}, [scale, translateX, translateY]);
useEffect(() => reset(), [contentSize.height, contentSize.width, reset, viewport]);
const panGesture = useMemo(
() =>
Gesture.Pan()
.maxPointers(1)
.onBegin(() => {
startX.value = translateX.value;
startY.value = translateY.value;
})
.onUpdate((event) => {
if (!fittedContent || !viewport || scale.value <= minScale) return;
const maxX = Math.max(0, (fittedContent.width * scale.value - viewport.width) / 2);
const maxY = Math.max(0, (fittedContent.height * scale.value - viewport.height) / 2);
translateX.value = Math.min(maxX, Math.max(-maxX, startX.value + event.translationX));
translateY.value = Math.min(maxY, Math.max(-maxY, startY.value + event.translationY));
}),
[fittedContent, minScale, scale, startX, startY, translateX, translateY, viewport],
);
const pinchGesture = useMemo(
() =>
Gesture.Pinch()
.onTouchesDown((event) => {
pinchTouchCount.value = event.numberOfTouches;
})
.onTouchesUp((event) => {
pinchTouchCount.value = event.numberOfTouches;
})
.onBegin((event) => {
pinchTouchCount.value = event.numberOfPointers;
startScale.value = scale.value;
startX.value = translateX.value;
startY.value = translateY.value;
pinchReady.value = false;
})
.onUpdate((event) => {
if (!fittedContent || !viewport) return;
// Android emits one final pinch update after a finger lifts. Its focal point belongs to
// the remaining pointer, so applying it makes the content jump as the gesture ends.
if (!isActivePinchUpdate(pinchTouchCount.value, event.numberOfPointers)) return;
if (!pinchReady.value) {
pinchFocalX.value = event.focalX;
pinchFocalY.value = event.focalY;
pinchReady.value = true;
}
const nextScale = Math.min(maxScale, Math.max(minScale, startScale.value * event.scale));
const centerX = viewport.width / 2;
const centerY = viewport.height / 2;
const contentPointX = (pinchFocalX.value - centerX - startX.value) / startScale.value;
const contentPointY = (pinchFocalY.value - centerY - startY.value) / startScale.value;
const nextX = event.focalX - centerX - contentPointX * nextScale;
const nextY = event.focalY - centerY - contentPointY * nextScale;
const maxX = Math.max(0, (fittedContent.width * nextScale - viewport.width) / 2);
const maxY = Math.max(0, (fittedContent.height * nextScale - viewport.height) / 2);
scale.value = nextScale;
translateX.value = Math.min(maxX, Math.max(-maxX, nextX));
translateY.value = Math.min(maxY, Math.max(-maxY, nextY));
})
.onFinalize(() => {
pinchTouchCount.value = 0;
runOnJS(setToolbarScale)(scale.value);
}),
[
fittedContent,
maxScale,
minScale,
pinchFocalX,
pinchFocalY,
pinchReady,
pinchTouchCount,
scale,
startScale,
startX,
startY,
translateX,
translateY,
viewport,
],
);
const doubleTapGesture = useMemo(
() =>
Gesture.Tap()
.numberOfTaps(2)
.onEnd((_event, success) => {
if (success) runOnJS(reset)();
}),
[reset],
);
const backdropTapGesture = useMemo(
() =>
Gesture.Tap()
.numberOfTaps(1)
.onEnd((event, success) => {
if (!success || !fittedContent || !viewport || !onPressOutsideContent) return;
const isInside = isPointInsideTransformedContent({
point: { x: event.x, y: event.y },
transform: { scale: scale.value, x: translateX.value, y: translateY.value },
fittedContent,
viewport,
});
if (!isInside) runOnJS(onPressOutsideContent)();
}),
[fittedContent, onPressOutsideContent, scale, translateX, translateY, viewport],
);
const tapGesture = useMemo(
() => Gesture.Exclusive(doubleTapGesture, backdropTapGesture),
[backdropTapGesture, doubleTapGesture],
);
const transformGesture = useMemo(
() => Gesture.Simultaneous(panGesture, pinchGesture),
[panGesture, pinchGesture],
);
const gesture = useMemo(
() => Gesture.Exclusive(transformGesture, tapGesture),
[tapGesture, transformGesture],
);
const zoomFromCenter = useCallback(
(factor: number) => {
if (!fittedContent || !viewport) return;
const next = zoomContentAtPoint({
transform: { scale: scale.value, x: translateX.value, y: translateY.value },
scale: scale.value * factor,
focalPoint: { x: viewport.width / 2, y: viewport.height / 2 },
fittedContent,
viewport,
limits: { minScale, maxScale },
});
scale.value = next.scale;
translateX.value = next.x;
translateY.value = next.y;
setToolbarScale(next.scale);
},
[fittedContent, maxScale, minScale, scale, translateX, translateY, viewport],
);
const zoomIn = useCallback(() => zoomFromCenter(1.25), [zoomFromCenter]);
const zoomOut = useCallback(() => zoomFromCenter(0.8), [zoomFromCenter]);
const handleLayout = useCallback((event: LayoutChangeEvent) => {
const { width, height } = event.nativeEvent.layout;
if (width > 0 && height > 0) setViewport({ width, height });
}, []);
const translationStyle = useAnimatedStyle(() => ({
transform: [{ translateX: translateX.value }, { translateY: translateY.value }],
}));
const scaleStyle = useAnimatedStyle(() => ({ transform: [{ scale: scale.value }] }));
const frameStyle = useMemo(
() => [
styles.contentFrame,
{ width: fittedContent?.width ?? 0, height: fittedContent?.height ?? 0 },
translationStyle,
],
[fittedContent, translationStyle],
);
return (
<View onLayout={handleLayout} style={[styles.root, style]} testID={testID}>
<GestureDetector gesture={gesture}>
<View
accessibilityLabel={accessibilityLabel}
accessibilityRole={accessibilityLabel ? "image" : undefined}
style={styles.canvas}
testID={testID ? `${testID}-canvas` : undefined}
>
{fittedContent ? (
<Animated.View style={frameStyle}>
<Animated.View style={[styles.content, scaleStyle]}>{children}</Animated.View>
</Animated.View>
) : null}
</View>
</GestureDetector>
<ViewportToolbar
actions={actions}
maxScale={maxScale}
minScale={minScale}
onReset={reset}
onZoomIn={zoomIn}
onZoomOut={zoomOut}
scale={toolbarScale}
visible
/>
</View>
);
}
const styles = StyleSheet.create(() => ({
root: { flex: 1, minHeight: 0, overflow: "hidden", position: "relative" },
canvas: {
flex: 1,
alignItems: "center",
justifyContent: "center",
overflow: "hidden",
},
contentFrame: { flexShrink: 0 },
content: { width: "100%", height: "100%" },
}));
@@ -1,350 +0,0 @@
import { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { View } from "react-native";
import { StyleSheet } from "react-native-unistyles";
import {
FIT_TRANSFORM,
fitContentSize,
isPointInsideTransformedContent,
panContent,
zoomContentAtPoint,
type ViewportPoint,
type ViewportSize,
type ViewportTransform,
} from "./geometry";
import { ViewportToolbar } from "./toolbar";
import type { ZoomableViewportProps } from "./types";
const DEFAULT_MAX_SCALE = 8;
const DEFAULT_MIN_SCALE = 0.25;
interface DragGesture {
type: "drag";
pointerId: number;
startPoint: ViewportPoint;
startTransform: ViewportTransform;
}
interface PinchGesture {
type: "pinch";
distance: number;
midpoint: ViewportPoint;
}
type ActiveGesture = DragGesture | PinchGesture;
function midpoint(points: ViewportPoint[]): ViewportPoint {
return {
x: (points[0].x + points[1].x) / 2,
y: (points[0].y + points[1].y) / 2,
};
}
function distance(points: ViewportPoint[]): number {
return Math.hypot(points[0].x - points[1].x, points[0].y - points[1].y);
}
export function ZoomableViewport({
contentSize,
children,
actions = [],
accessibilityLabel,
fit,
maxScale = DEFAULT_MAX_SCALE,
minScale = DEFAULT_MIN_SCALE,
onPressOutsideContent,
style,
testID,
wheelActivation = "modifier",
}: ZoomableViewportProps) {
const canvasRef = useRef<HTMLDivElement | null>(null);
const pointersRef = useRef(new Map<number, ViewportPoint>());
const gestureRef = useRef<ActiveGesture | null>(null);
const suppressClickRef = useRef(false);
const transformRef = useRef<ViewportTransform>(FIT_TRANSFORM);
const [viewport, setViewport] = useState<ViewportSize | null>(null);
const [transform, setTransform] = useState<ViewportTransform>(FIT_TRANSFORM);
const [isDragging, setIsDragging] = useState(false);
const [isHovered, setIsHovered] = useState(false);
const [isFocusWithin, setIsFocusWithin] = useState(false);
const [hasTouchInput, setHasTouchInput] = useState(false);
const fittedContent = useMemo(
() => (viewport ? fitContentSize(contentSize, viewport, fit) : null),
[contentSize, fit, viewport],
);
const limits = useMemo(() => ({ minScale, maxScale }), [maxScale, minScale]);
const commitTransform = useCallback((next: ViewportTransform) => {
transformRef.current = next;
setTransform(next);
}, []);
const reset = useCallback(() => commitTransform(FIT_TRANSFORM), [commitTransform]);
useEffect(() => {
const canvas = canvasRef.current;
if (!canvas) return;
const observer = new ResizeObserver(([entry]) => {
if (!entry || entry.contentRect.width <= 0 || entry.contentRect.height <= 0) return;
setViewport({ width: entry.contentRect.width, height: entry.contentRect.height });
});
observer.observe(canvas);
return () => observer.disconnect();
}, []);
useEffect(() => reset(), [contentSize.height, contentSize.width, reset, viewport]);
const zoomAt = useCallback(
(scale: number, focalPoint: ViewportPoint) => {
if (!fittedContent || !viewport) return;
commitTransform(
zoomContentAtPoint({
transform: transformRef.current,
scale,
focalPoint,
fittedContent,
viewport,
limits,
}),
);
},
[commitTransform, fittedContent, limits, viewport],
);
const zoomFromCenter = useCallback(
(factor: number) => {
if (!viewport) return;
zoomAt(transformRef.current.scale * factor, {
x: viewport.width / 2,
y: viewport.height / 2,
});
},
[viewport, zoomAt],
);
const zoomIn = useCallback(() => zoomFromCenter(1.25), [zoomFromCenter]);
const zoomOut = useCallback(() => zoomFromCenter(0.8), [zoomFromCenter]);
useEffect(() => {
const canvas = canvasRef.current;
if (!canvas) return;
const activeCanvas = canvas;
function zoomWithWheel(event: WheelEvent) {
const hasModifier = event.ctrlKey || event.metaKey;
if (wheelActivation === "modifier" && !hasModifier) return;
event.preventDefault();
const bounds = activeCanvas.getBoundingClientRect();
const factor = Math.min(1.25, Math.max(0.8, Math.exp(-event.deltaY * 0.01)));
zoomAt(transformRef.current.scale * factor, {
x: event.clientX - bounds.left,
y: event.clientY - bounds.top,
});
}
activeCanvas.addEventListener("wheel", zoomWithWheel, { passive: false });
return () => activeCanvas.removeEventListener("wheel", zoomWithWheel);
}, [wheelActivation, zoomAt]);
const beginPointer = useCallback((event: React.PointerEvent<HTMLDivElement>) => {
if (event.pointerType === "mouse" && event.button !== 0) return;
if (event.pointerType !== "mouse") setHasTouchInput(true);
if (pointersRef.current.size === 0) suppressClickRef.current = false;
event.currentTarget.setPointerCapture(event.pointerId);
pointersRef.current.set(event.pointerId, { x: event.clientX, y: event.clientY });
const points = Array.from(pointersRef.current.values());
if (points.length >= 2) {
gestureRef.current = {
type: "pinch",
distance: distance(points),
midpoint: midpoint(points),
};
setIsDragging(true);
return;
}
gestureRef.current = {
type: "drag",
pointerId: event.pointerId,
startPoint: points[0],
startTransform: transformRef.current,
};
setIsDragging(transformRef.current.scale > 1);
}, []);
const movePointer = useCallback(
(event: React.PointerEvent<HTMLDivElement>) => {
if (!pointersRef.current.has(event.pointerId) || !fittedContent || !viewport) return;
pointersRef.current.set(event.pointerId, { x: event.clientX, y: event.clientY });
const gesture = gestureRef.current;
const points = Array.from(pointersRef.current.values());
if (gesture?.type === "pinch" && points.length >= 2) {
suppressClickRef.current = true;
const nextMidpoint = midpoint(points);
const nextDistance = distance(points);
const panned = panContent({
transform: transformRef.current,
delta: {
x: nextMidpoint.x - gesture.midpoint.x,
y: nextMidpoint.y - gesture.midpoint.y,
},
fittedContent,
viewport,
limits,
});
const next = zoomContentAtPoint({
transform: panned,
scale: panned.scale * (nextDistance / gesture.distance),
focalPoint: nextMidpoint,
fittedContent,
viewport,
limits,
});
gestureRef.current = { type: "pinch", distance: nextDistance, midpoint: nextMidpoint };
commitTransform(next);
return;
}
if (gesture?.type !== "drag" || gesture.pointerId !== event.pointerId) return;
if (
Math.hypot(event.clientX - gesture.startPoint.x, event.clientY - gesture.startPoint.y) > 3
) {
suppressClickRef.current = true;
}
commitTransform(
panContent({
transform: gesture.startTransform,
delta: {
x: event.clientX - gesture.startPoint.x,
y: event.clientY - gesture.startPoint.y,
},
fittedContent,
viewport,
limits,
}),
);
},
[commitTransform, fittedContent, limits, viewport],
);
const endPointer = useCallback((event: React.PointerEvent<HTMLDivElement>) => {
pointersRef.current.delete(event.pointerId);
if (event.currentTarget.hasPointerCapture(event.pointerId)) {
event.currentTarget.releasePointerCapture(event.pointerId);
}
const remaining = Array.from(pointersRef.current.entries());
if (remaining.length === 1) {
const [pointerId, point] = remaining[0];
gestureRef.current = {
type: "drag",
pointerId,
startPoint: point,
startTransform: transformRef.current,
};
setIsDragging(transformRef.current.scale > 1);
return;
}
gestureRef.current = null;
setIsDragging(false);
}, []);
const handleCanvasClick = useCallback(
(event: React.MouseEvent<HTMLDivElement>) => {
if (suppressClickRef.current) {
suppressClickRef.current = false;
return;
}
if (!fittedContent || !viewport || !onPressOutsideContent) return;
const bounds = event.currentTarget.getBoundingClientRect();
const isInside = isPointInsideTransformedContent({
point: { x: event.clientX - bounds.left, y: event.clientY - bounds.top },
transform: transformRef.current,
fittedContent,
viewport,
});
if (!isInside) onPressOutsideContent();
},
[fittedContent, onPressOutsideContent, viewport],
);
const renderedCanvasStyle = useMemo<React.CSSProperties>(() => {
let cursor: React.CSSProperties["cursor"] = "default";
if (transform.scale > 1) cursor = isDragging ? "grabbing" : "grab";
return { ...canvasDomStyle, cursor };
}, [isDragging, transform.scale]);
const renderedContentStyle = useMemo<React.CSSProperties>(
() => ({
...contentDomStyle,
width: fittedContent?.width ?? 0,
height: fittedContent?.height ?? 0,
transform: `translate3d(${transform.x}px, ${transform.y}px, 0) scale(${transform.scale})`,
}),
[fittedContent, transform],
);
const controlsVisible = isHovered || isFocusWithin || hasTouchInput;
const handleFocus = useCallback(() => setIsFocusWithin(true), []);
const handleBlur = useCallback(() => setIsFocusWithin(false), []);
const handleMouseEnter = useCallback(() => setIsHovered(true), []);
const handleMouseLeave = useCallback(() => setIsHovered(false), []);
return (
<View style={[styles.root, style]} testID={testID}>
<div
aria-label={accessibilityLabel}
data-testid={testID ? `${testID}-canvas` : undefined}
onClick={handleCanvasClick}
onDoubleClick={reset}
onFocusCapture={handleFocus}
onBlurCapture={handleBlur}
onMouseEnter={handleMouseEnter}
onMouseLeave={handleMouseLeave}
onPointerCancel={endPointer}
onPointerDown={beginPointer}
onPointerMove={movePointer}
onPointerUp={endPointer}
ref={canvasRef}
role={accessibilityLabel ? "img" : undefined}
style={renderedCanvasStyle}
>
<div style={renderedContentStyle}>{children}</div>
</div>
<div
onBlurCapture={handleBlur}
onFocusCapture={handleFocus}
onMouseEnter={handleMouseEnter}
onMouseLeave={handleMouseLeave}
style={toolbarDomStyle}
>
<ViewportToolbar
actions={actions}
maxScale={maxScale}
minScale={minScale}
onReset={reset}
onZoomIn={zoomIn}
onZoomOut={zoomOut}
scale={transform.scale}
visible={controlsVisible}
/>
</div>
</View>
);
}
const styles = StyleSheet.create(() => ({
root: { flex: 1, minHeight: 0, overflow: "hidden", position: "relative" },
}));
const canvasDomStyle: React.CSSProperties = {
position: "absolute",
inset: 0,
display: "flex",
alignItems: "center",
justifyContent: "center",
overflow: "hidden",
touchAction: "none",
userSelect: "none",
};
const contentDomStyle: React.CSSProperties = {
flexShrink: 0,
transformOrigin: "center center",
};
const toolbarDomStyle: React.CSSProperties = {
position: "absolute",
top: 0,
right: 0,
width: 200,
height: 48,
zIndex: 1,
};
@@ -1,137 +0,0 @@
import React from "react";
import { Pressable, View } from "react-native";
import { Scan, ZoomIn, ZoomOut } from "lucide-react-native";
import { useTranslation } from "react-i18next";
import { StyleSheet } from "react-native-unistyles";
import { useIsCompactFormFactor } from "@/constants/layout";
import {
iconButtonChromeGlyphSize,
iconButtonChromeStyle,
} from "@/components/ui/icon-button-chrome";
import type { ZoomableViewportAction } from "./types";
interface ViewportToolbarProps {
actions: ZoomableViewportAction[];
maxScale: number;
minScale: number;
onReset: () => void;
onZoomIn: () => void;
onZoomOut: () => void;
scale: number;
visible: boolean;
}
interface ResolvedViewportAction extends ZoomableViewportAction {
disabled: boolean;
}
export const ViewportToolbar = React.memo(function ViewportToolbar({
actions,
maxScale,
minScale,
onReset,
onZoomIn,
onZoomOut,
scale,
visible,
}: ViewportToolbarProps) {
const { t } = useTranslation();
const viewportActions: ResolvedViewportAction[] = [
{
icon: ZoomIn,
label: t("message.diagram.zoomIn"),
onPress: onZoomIn,
disabled: scale >= maxScale,
},
{
icon: ZoomOut,
label: t("message.diagram.zoomOut"),
onPress: onZoomOut,
disabled: scale <= minScale,
},
{
icon: Scan,
label: t("message.diagram.resetZoom"),
onPress: onReset,
disabled: scale === 1,
},
...actions.map((action) => ({ ...action, disabled: false })),
];
return (
<View style={styles.cluster} testID="zoomable-viewport-toolbar">
{viewportActions.map((action) => (
<ViewportToolbarButton
key={action.label}
action={action}
disabled={action.disabled}
visible={visible}
/>
))}
</View>
);
});
function ViewportToolbarButton({
action,
disabled,
visible,
}: {
action: ZoomableViewportAction;
disabled: boolean;
visible: boolean;
}) {
const Icon = action.icon;
const isCompact = useIsCompactFormFactor();
const iconSize = iconButtonChromeGlyphSize("small", isCompact);
const buttonStyle = React.useCallback(
({ hovered, pressed }: { hovered?: boolean; pressed: boolean }) =>
iconButtonChromeStyle({
size: "small",
compact: isCompact,
state: { hovered, pressed },
disabled,
style: visible ? styles.button : styles.buttonHidden,
}),
[disabled, isCompact, visible],
);
return (
<Pressable
accessibilityLabel={action.label}
accessibilityRole="button"
disabled={disabled}
hitSlop={isCompact ? 6 : 4}
onPress={action.onPress}
style={buttonStyle}
testID={action.testID}
>
{({ hovered }) => (
<Icon size={iconSize} color={hovered ? styles.iconHovered.color : styles.icon.color} />
)}
</Pressable>
);
}
const styles = StyleSheet.create((theme) => ({
cluster: {
position: "absolute",
top: theme.spacing[2],
right: theme.spacing[2],
zIndex: 1,
flexDirection: "row",
gap: theme.spacing[1],
pointerEvents: "box-none",
},
button: {
backgroundColor: theme.colors.surface2,
opacity: 1,
pointerEvents: "auto",
},
buttonHidden: {
backgroundColor: theme.colors.surface2,
opacity: 0,
pointerEvents: "none",
},
icon: { color: theme.colors.foregroundMuted },
iconHovered: { color: theme.colors.foreground },
}));
@@ -1,24 +0,0 @@
import type { ComponentType, ReactNode } from "react";
import type { StyleProp, ViewStyle } from "react-native";
import type { ViewportFitOptions, ViewportSize } from "./geometry";
export interface ZoomableViewportAction {
icon: ComponentType<{ size?: number; color?: string }>;
label: string;
onPress: () => void;
testID?: string;
}
export interface ZoomableViewportProps {
contentSize: ViewportSize;
children: ReactNode;
actions?: ZoomableViewportAction[];
accessibilityLabel?: string;
fit?: ViewportFitOptions;
maxScale?: number;
minScale?: number;
onPressOutsideContent?: () => void;
style?: StyleProp<ViewStyle>;
testID?: string;
wheelActivation?: "always" | "modifier";
}
@@ -1,6 +1,6 @@
import { describe, expect, it } from "vitest";
import type { ProviderSelectorProvider } from "@/provider-selection/provider-selection";
import { resolveModelSheetOpening } from "./model-sheet-flow";
import { resolveModelBrowserScrolling, resolveModelSheetOpening } from "./model-sheet-flow";
function provider(id: string, label: string): ProviderSelectorProvider {
return { id, label, modelSelection: { kind: "models", rows: [] } };
@@ -40,3 +40,13 @@ describe("model sheet opening", () => {
).toEqual({ kind: "provider", providerId: "codex", providerLabel: "Codex" });
});
});
describe("model sheet gesture ownership", () => {
it("uses the sheet-aware model browser inside compact bottom sheets", () => {
expect(resolveModelBrowserScrolling(true)).toBe("sheet");
});
it("keeps independent scrolling in the desktop split viewport", () => {
expect(resolveModelBrowserScrolling(false)).toBe("independent");
});
});
@@ -1,6 +1,10 @@
import type { ModelBrowserView } from "@/components/model-browser-view";
import type { ProviderSelectorProvider } from "@/provider-selection/provider-selection";
export function resolveModelBrowserScrolling(usesBottomSheet: boolean): "sheet" | "independent" {
return usesBottomSheet ? "sheet" : "independent";
}
export function resolveModelSheetOpening({
canSwitchProvider,
providers,
@@ -9,13 +9,15 @@ import { AdaptiveModalSheet } from "@/components/adaptive-modal-sheet";
import { ComboboxTrigger } from "@/components/ui/combobox-trigger";
import { getProviderIcon } from "@/components/provider-icons";
import { ModelBrowser, useModelBrowser } from "@/components/model-browser";
import { resolveModelBrowserScrolling } from "@/components/model-browser-view";
import { AgentControlTrigger } from "@/composer/agent-controls/control";
import { ComposerToolbarGlyph } from "@/composer/agent-controls/glyph";
import { resolveModelSheetOpening } from "@/composer/agent-controls/model-sheet-flow";
import {
resolveModelBrowserScrolling,
resolveModelSheetOpening,
} from "@/composer/agent-controls/model-sheet-flow";
import type { ProviderSelectorProvider } from "@/provider-selection/provider-selection";
import { useIsCompactFormFactor } from "@/constants/layout";
import { isNative, isWeb } from "@/constants/platform";
import { isWeb } from "@/constants/platform";
const SNAP_POINTS = ["80%", "90%"];
const MODEL_LIST_TOP_INSET = 4;
@@ -100,10 +102,7 @@ export function CompactModelSheet({
}: CompactModelSheetProps) {
const { t } = useTranslation();
const usesBottomSheet = useIsCompactFormFactor();
const modelBrowserScrolling = resolveModelBrowserScrolling({
isNative,
isCompact: usesBottomSheet,
});
const modelBrowserScrolling = resolveModelBrowserScrolling(usesBottomSheet);
const [isOpen, setIsOpen] = useState(false);
const [isModelBrowserOpen, setIsModelBrowserOpen] = useState(false);
const availableProviders = useMemo(() => {
+2 -12
View File
@@ -124,7 +124,7 @@ import { droppedItemsToPickedFiles } from "@/composer/attachments/drop";
import { getFileTypeLabel } from "@/attachments/file-types";
import { Combobox, ComboboxItem, type ComboboxOption } from "@/components/ui/combobox";
import { AttachmentLabel, AttachmentPill, AttachmentThumbnail } from "@/components/attachment-pill";
import { AttachmentLightbox, type ImageLightboxSource } from "@/components/attachment-lightbox";
import { AttachmentLightbox } from "@/components/attachment-lightbox";
import { openExternalUrl } from "@/utils/open-external-url";
import { useIsDictationReady } from "@/hooks/use-is-dictation-ready";
import { useForgeSearchQuery } from "@/git/use-forge-search-query";
@@ -2141,10 +2141,6 @@ function ComposerContentImpl({
const handleLightboxClose = useCallback(() => {
setLightboxMetadata(null);
}, []);
const lightboxSource = useMemo<ImageLightboxSource | null>(
() => (lightboxMetadata ? { type: "attachment", metadata: lightboxMetadata } : null),
[lightboxMetadata],
);
const handleGithubPickerOpenChange = useCallback(
(open: boolean) => {
@@ -2267,7 +2263,7 @@ function ComposerContentImpl({
isMessageInputFocused={isMessageInputFocused}
/>
<Animated.View style={composerContainerStyle}>
<AttachmentLightbox source={lightboxSource} onClose={handleLightboxClose} />
<AttachmentLightbox metadata={lightboxMetadata} onClose={handleLightboxClose} />
{/* Input area */}
<View style={inputAreaContainerStyle}>
<View style={styles.inputAreaContent}>
@@ -2368,9 +2364,6 @@ function ComposerContentImpl({
const animatedStaticStyles = RNStyleSheet.create({
container: {
flexDirection: "column",
// KeyboardDock reduces the available column height with bottom padding.
// Keep the composer's constraint chain shrinkable down to its scrolling input.
flexShrink: 1,
position: "relative",
},
});
@@ -2381,7 +2374,6 @@ const styles = StyleSheet.create((theme: Theme) => ({
backgroundColor: theme.colors.border,
},
inputAreaContainer: {
flexShrink: 1,
position: "relative",
minHeight: FOOTER_HEIGHT,
marginHorizontal: "auto",
@@ -2395,13 +2387,11 @@ const styles = StyleSheet.create((theme: Theme) => ({
opacity: 0.6,
},
inputAreaContent: {
flexShrink: 1,
width: "100%",
maxWidth: MAX_CONTENT_WIDTH,
gap: theme.spacing[3],
},
messageInputContainer: {
flexShrink: 1,
position: "relative",
width: "100%",
gap: theme.spacing[3],
@@ -1901,11 +1901,9 @@ export const MessageInput = forwardRef<MessageInputRef, MessageInputProps>(
const styles = StyleSheet.create((theme: Theme) => ({
container: {
flexShrink: 1,
position: "relative",
},
inputWrapper: {
flexShrink: 1,
flexDirection: "column",
gap: theme.spacing[3],
backgroundColor: theme.colors.surface1,
@@ -1934,7 +1932,6 @@ const styles = StyleSheet.create((theme: Theme) => ({
borderStyle: "dotted",
},
textInputScrollWrapper: {
flexShrink: 1,
position: "relative",
},
focusHintText: {
@@ -1946,8 +1943,6 @@ const styles = StyleSheet.create((theme: Theme) => ({
opacity: 0.5,
},
textInput: {
// Preserve the controls when an ancestor constrains an overlong draft.
flexShrink: 1,
width: "100%",
color: theme.colors.foreground,
fontSize: theme.fontSize.content,
@@ -1969,7 +1964,6 @@ const styles = StyleSheet.create((theme: Theme) => ({
color: theme.colors.foregroundMuted,
},
buttonRow: {
flexShrink: 0,
flexDirection: "row",
alignItems: "flex-end",
justifyContent: "space-between",
+32 -3
View File
@@ -9,7 +9,7 @@ import React, {
useSyncExternalStore,
} from "react";
import type { DaemonClient } from "@getpaseo/client/internal/daemon-client";
import { ScrollView as RNScrollView, Text, View } from "react-native";
import { Image as RNImage, ScrollView as RNScrollView, Text, View } from "react-native";
import { StyleSheet, UnistylesRuntime, withUnistyles } from "react-native-unistyles";
import { useTranslation } from "react-i18next";
import { useIsCompactFormFactor } from "@/constants/layout";
@@ -39,7 +39,6 @@ import type { LiveFileModel } from "./live-file/model";
import { confirmDialog } from "@/utils/confirm-dialog";
import { usePublishPanelInstanceAttributes } from "@/panels/panel-instance-attributes";
import type { Theme } from "@/styles/theme";
import { ZoomableImage } from "@/components/zoomable-viewport/image";
const ThemedLoadingSpinner = withUnistyles(LoadingSpinner);
const foregroundMutedColorMapping = (theme: Theme) => ({
@@ -147,6 +146,11 @@ function FilePreviewBody({
const previewScrollRef = useRef<RNScrollView>(null);
const imageSource = useMemo(
() => (imagePreviewUri ? { uri: imagePreviewUri } : null),
[imagePreviewUri],
);
if (isLoading && !preview) {
return (
<View style={styles.centerState} testID="file-preview-loading">
@@ -208,7 +212,22 @@ function FilePreviewBody({
);
}
return <ZoomableImage uri={imagePreviewUri} testID="image-file-preview" />;
return (
<View style={styles.previewScrollContainer}>
<RNScrollView
ref={previewScrollRef}
style={styles.previewContent}
contentContainerStyle={styles.previewImageScrollContent}
showsVerticalScrollIndicator
>
<RNImage
source={imageSource ?? undefined}
style={styles.previewImage}
resizeMode="contain"
/>
</RNScrollView>
</View>
);
}
return (
@@ -692,4 +711,14 @@ const styles = StyleSheet.create((theme) => ({
previewCodeScrollContent: {
padding: theme.spacing[4],
},
previewImageScrollContent: {
flexGrow: 1,
padding: theme.spacing[4],
alignItems: "center",
justifyContent: "center",
},
previewImage: {
width: "100%",
height: 420,
},
}));
@@ -1,83 +0,0 @@
import React, { act } from "react";
import { createRoot, type Root } from "react-dom/client";
import { JSDOM } from "jsdom";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { CommitsSection } from "./commits-section";
vi.mock("react-native-unistyles", () => ({
StyleSheet: {
create: (factory: unknown) =>
typeof factory === "function"
? factory({
borderRadius: { full: 9999, sm: 4 },
borderWidth: { 1: 1 },
colors: {
border: "#333",
foreground: "#fff",
foregroundMuted: "#aaa",
statusDanger: "#c33",
surface2: "#222",
},
fontSize: { base: 15, sm: 13 },
spacing: [0, 4, 8, 12],
})
: factory,
},
}));
vi.mock("react-native-safe-area-context", () => ({
useSafeAreaInsets: () => ({ top: 0, right: 0, bottom: 34, left: 0 }),
}));
vi.mock("react-i18next", () => ({
useTranslation: () => ({ t: (key: string) => key }),
}));
vi.mock("@/git/use-commits-query", () => ({
useCheckoutCommitsQuery: () => ({ status: "idle" }),
}));
vi.mock("@/git/themed-chevron", () => ({
ThemedChevron: () => null,
chevronColorMapping: () => ({}),
}));
vi.mock("./commit-row", () => ({
CommitRow: () => null,
}));
let root: Root | null = null;
beforeEach(() => {
const dom = new JSDOM("<!doctype html><html><body></body></html>");
vi.stubGlobal("React", React);
vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", true);
vi.stubGlobal("window", dom.window);
vi.stubGlobal("document", dom.window.document);
vi.stubGlobal("HTMLElement", dom.window.HTMLElement);
vi.stubGlobal("Node", dom.window.Node);
vi.stubGlobal("navigator", dom.window.navigator);
const container = document.createElement("div");
document.body.appendChild(container);
root = createRoot(container);
});
afterEach(() => {
act(() => root?.unmount());
root = null;
vi.unstubAllGlobals();
});
describe("CommitsSection", () => {
it("keeps its bottom edge above the device safe area", () => {
act(() => {
root?.render(
<CommitsSection serverId="server" cwd="/repo" onCommitPress={vi.fn()} collapsed />,
);
});
const header = document.querySelector('[data-testid="commits-section-header"]');
expect(header?.parentElement?.getAttribute("style")).toContain("padding-bottom: 34px");
});
});
@@ -1,7 +1,6 @@
import { useCallback, useEffect, useMemo, useState } from "react";
import { Pressable, Text, View } from "react-native";
import { StyleSheet } from "react-native-unistyles";
import { useSafeAreaInsets } from "react-native-safe-area-context";
import { useTranslation } from "react-i18next";
import { useRetainedPanelActive } from "@/components/retained-panel";
import { useCheckoutCommitsQuery, type CheckoutCommitsQueryResult } from "@/git/use-commits-query";
@@ -92,7 +91,6 @@ export function CommitsSection({
onCollapsedChange,
}: CommitsSectionProps) {
const { t } = useTranslation();
const insets = useSafeAreaInsets();
const isPanelActive = useRetainedPanelActive();
const [now, setNow] = useState(() => new Date());
const displayNow = useMemo(() => (isPanelActive ? new Date() : now), [isPanelActive, now]);
@@ -121,10 +119,6 @@ export function CommitsSection({
() => [styles.headerChevron, !collapsed && styles.headerChevronExpanded],
[collapsed],
);
const containerStyle = useMemo(
() => [styles.container, { paddingBottom: insets.bottom }],
[insets.bottom],
);
if (query.status === "unsupported") {
return null;
@@ -135,7 +129,7 @@ export function CommitsSection({
: null;
return (
<View style={containerStyle}>
<View style={styles.container}>
<Pressable
accessibilityRole="button"
testID="commits-section-header"
@@ -171,7 +171,6 @@ export function DiffSurface(props: DiffSurfaceProps) {
const resized = canvas.width !== pixelWidth || canvas.height !== pixelHeight;
if (canvas.width !== pixelWidth) canvas.width = pixelWidth;
if (canvas.height !== pixelHeight) canvas.height = pixelHeight;
canvas.style.width = `${currentModel.viewportWidth}px`;
canvas.style.top = `${canvasTop}px`;
canvas.style.height = `${canvasHeight}px`;
const context = canvas.getContext("2d");
@@ -536,10 +535,11 @@ export function DiffSurface(props: DiffSurfaceProps) {
const canvasStyle = useMemo<React.CSSProperties>(
() => ({
...CANVAS_STYLE,
width: model.viewportWidth,
fontFamily: (loadedTypography ?? desiredTypography).family,
fontSize: (loadedTypography ?? desiredTypography).size,
}),
[desiredTypography, loadedTypography],
[desiredTypography, loadedTypography, model.viewportWidth],
);
return (
@@ -148,7 +148,7 @@ function CheckGroup({
}) {
const handlePress = useCallback(() => onToggle(group.status), [group.status, onToggle]);
return (
<View testID={`pr-pane-check-group-${group.status}`}>
<View>
<Pressable onPress={handlePress} style={styles.groupHeader} accessibilityRole="button">
<Text style={styles.groupLabel}>{group.label}</Text>
{collapsed ? (
@@ -20,11 +20,6 @@ function storedSendBehavior(storage: Storage): SendBehavior | undefined {
return raw === undefined ? undefined : JSON.parse(raw).sendBehavior;
}
function storedContentFontSize(storage: Storage): number | undefined {
const raw = storage.entries.get(APP_SETTINGS_KEY);
return raw === undefined ? undefined : JSON.parse(raw).contentFontSize;
}
/** An in-memory storage whose write to `failingKey` always throws, as a full disk would. */
function createFailingWriteStorage(failingKey: string): Storage {
const storage = createInMemoryKeyValueStorage();
@@ -86,47 +81,6 @@ describe("migrateAppSettings", () => {
expect(appliedIds(storage)).toEqual(["some-later-migration", "steer-default"]);
});
it("migrates every mobile 15px content preference to 16px", async () => {
const storage = createInMemoryKeyValueStorage();
const settings = { ...settingsWith("steer"), contentFontSize: 15 };
const result = await migrateAppSettings(settings, storage, undefined, { native: true });
expect(result.contentFontSize).toBe(16);
expect(storedContentFontSize(storage)).toBe(16);
expect(appliedIds(storage)).toEqual(["steer-default", "mobile-content-16"]);
});
it("leaves a 15px web content preference unchanged", async () => {
const storage = createInMemoryKeyValueStorage();
const settings = { ...settingsWith("steer"), contentFontSize: 15 };
const result = await migrateAppSettings(settings, storage, undefined, { native: false });
expect(result.contentFontSize).toBe(15);
expect(storedContentFontSize(storage)).toBeUndefined();
expect(appliedIds(storage)).toEqual(["steer-default"]);
});
it("lets a mobile user choose 15px after the default migration ran", async () => {
const storage = createInMemoryKeyValueStorage();
await migrateAppSettings(
{ ...settingsWith("steer"), contentFontSize: 15 },
storage,
undefined,
{ native: true },
);
const result = await migrateAppSettings(
{ ...settingsWith("steer"), contentFontSize: 15 },
storage,
undefined,
{ native: true },
);
expect(result.contentFontSize).toBe(15);
});
it("stays unmarked when the settings write fails, so a later launch retries", async () => {
const storage = createFailingWriteStorage(APP_SETTINGS_KEY);
@@ -13,9 +13,6 @@ const AppliedMigrationsSchema = z.strictObject({ applied: z.array(z.string()) })
*/
const STEER_DEFAULT_MIGRATION = "steer-default";
/** Existing mobile installs materialized the old 15px content default in storage. */
const MOBILE_CONTENT_16_MIGRATION = "mobile-content-16";
/**
* Brings stored settings up to date, returning what the caller should use. Owns both writes so
* the marker can only ever be written after the settings it describes: a failed marker write
@@ -26,7 +23,6 @@ export async function migrateAppSettings(
settings: AppSettings,
storage: KeyValueStorage,
stored?: PersistedAppSettings,
options: { native?: boolean } = {},
): Promise<AppSettings> {
const migrationMarker = await readValidatedJson(
storage,
@@ -34,26 +30,12 @@ export async function migrateAppSettings(
AppliedMigrationsSchema,
);
const applied = new Set(migrationMarker?.applied ?? []);
let addedMigration = false;
let migrated = settings;
if (!applied.has(STEER_DEFAULT_MIGRATION)) {
migrated =
migrated.sendBehavior === "interrupt" ? { ...migrated, sendBehavior: "steer" } : migrated;
applied.add(STEER_DEFAULT_MIGRATION);
addedMigration = true;
}
if (options.native && !applied.has(MOBILE_CONTENT_16_MIGRATION)) {
migrated = migrated.contentFontSize === 15 ? { ...migrated, contentFontSize: 16 } : migrated;
applied.add(MOBILE_CONTENT_16_MIGRATION);
addedMigration = true;
}
if (!addedMigration) {
if (applied.has(STEER_DEFAULT_MIGRATION)) {
return settings;
}
const migrated: AppSettings =
settings.sendBehavior === "interrupt" ? { ...settings, sendBehavior: "steer" } : settings;
if (migrated !== settings) {
const storedSidebarRowItems = stored?.sidebarRowItems ?? {};
await storage.setItem(
@@ -66,6 +48,7 @@ export async function migrateAppSettings(
);
}
applied.add(STEER_DEFAULT_MIGRATION);
await storage.setItem(SETTINGS_MIGRATIONS_KEY, JSON.stringify({ applied: [...applied] }));
return migrated;
}
@@ -659,8 +659,8 @@ describe("appearance settings", () => {
expect(defaultUiBaseFontSize(false)).toBe(14);
});
it("uses a 16px content default on mobile and a 15px default on web", () => {
expect(defaultContentFontSize(true)).toBe(16);
it("uses a 15px content default on mobile and web", () => {
expect(defaultContentFontSize(true)).toBe(15);
expect(defaultContentFontSize(false)).toBe(15);
expect(DEFAULT_CONTENT_FONT_SIZE).toBe(defaultContentFontSize(false));
});
@@ -52,7 +52,7 @@ export const DEFAULT_UI_BASE_FONT_SIZE = defaultUiBaseFontSize(isNative);
export const MIN_UI_BASE_FONT_SIZE = 10;
export const MAX_UI_BASE_FONT_SIZE = 21;
export function defaultContentFontSize(native: boolean): number {
return native ? 16 : FONT_SIZE.content;
return native ? 15 : FONT_SIZE.content;
}
export const DEFAULT_CONTENT_FONT_SIZE = defaultContentFontSize(isNative);
@@ -75,7 +75,7 @@ export interface AppSettings {
uiFontFamily: string; // "" = platform default UI stack
monoFontFamily: string; // "" = platform default mono stack
uiBaseFontSize: number; // clamped px, platform default 14 or 15
contentFontSize: number; // clamped px, platform default 15 or 16
contentFontSize: number; // clamped px, default 15
codeFontSize: number; // clamped px, default 12
syntaxTheme: SyntaxThemeId; // default "one"
workspaceTitleSource: WorkspaceTitleSource;
@@ -343,7 +343,7 @@ export async function loadAppSettingsFromStorage(deps: SettingsDeps): Promise<Ap
await writeAppSettings(deps.storage, read.stored, read.settings);
}
const { needsWrite: _needsWrite, ...stored } = read.stored;
return await migrateAppSettings(read.settings, deps.storage, stored, { native: isNative });
return await migrateAppSettings(read.settings, deps.storage, stored);
} catch (error) {
console.error("[AppSettings] Failed to load settings:", error);
throw error;
+1
View File
@@ -422,6 +422,7 @@ describe("translation resources", () => {
added: "Added",
started: "Started",
completed: "Completed",
reopened: "Reopened",
});
});
+1 -1
View File
@@ -203,7 +203,6 @@ export const ar: TranslationResources = {
empty: "ابدأ الدردشة مع هذا الوكيل...",
scrollToBottom: "قم بالتمرير إلى الأسفل",
historyLoadFailed: "تعذر تحميل سجل الوكيل",
messageCapped: "تم اقتطاع هذه الرسالة ({{bytes}} بايت).",
permission: {
plan: "يخطط",
required: "الإذن مطلوب",
@@ -346,6 +345,7 @@ export const ar: TranslationResources = {
added: "أُضيفت",
started: "بدأت",
completed: "اكتملت",
reopened: "أُعيد فتحها",
},
},
compaction: {
+1 -1
View File
@@ -200,7 +200,6 @@ export const en = {
empty: "Start chatting with this agent...",
scrollToBottom: "Scroll to bottom",
historyLoadFailed: "Couldn't load agent history",
messageCapped: "This message was capped ({{bytes}} bytes).",
permission: {
plan: "Plan",
required: "Permission Required",
@@ -344,6 +343,7 @@ export const en = {
added: "Added",
started: "Started",
completed: "Completed",
reopened: "Reopened",
},
},
compaction: {
+1 -1
View File
@@ -203,7 +203,6 @@ export const es: TranslationResources = {
empty: "Comience a chatear con este agente...",
scrollToBottom: "Desplazarse hacia abajo",
historyLoadFailed: "No se pudo cargar el historial del agente",
messageCapped: "Este mensaje fue truncado ({{bytes}} bytes).",
permission: {
plan: "Plan",
required: "Permiso requerido",
@@ -349,6 +348,7 @@ export const es: TranslationResources = {
added: "Añadida",
started: "Iniciada",
completed: "Completada",
reopened: "Reabierta",
},
},
compaction: {
+1 -1
View File
@@ -205,7 +205,6 @@ export const fr: TranslationResources = {
empty: "Commencez à discuter avec cet agent...",
scrollToBottom: "Faire défiler vers le bas",
historyLoadFailed: "Impossible de charger l’historique de l’agent",
messageCapped: "Ce message a été tronqué ({{bytes}} octets).",
permission: {
plan: "Plan",
required: "Autorisation requise",
@@ -350,6 +349,7 @@ export const fr: TranslationResources = {
added: "Ajoutée",
started: "Commencée",
completed: "Terminée",
reopened: "Rouverte",
},
},
compaction: {
+1 -1
View File
@@ -203,7 +203,6 @@ export const ja: TranslationResources = {
empty: "このエージェントとチャットを始めましょう...",
scrollToBottom: "下にスクロール",
historyLoadFailed: "エージェントの履歴を読み込めませんでした",
messageCapped: "このメッセージは上限で切り詰められました({{bytes}}バイト)。",
permission: {
plan: "プラン",
required: "権限が必要です",
@@ -349,6 +348,7 @@ export const ja: TranslationResources = {
added: "追加",
started: "開始",
completed: "完了",
reopened: "再開",
},
},
compaction: {
+1 -1
View File
@@ -203,7 +203,6 @@ export const ko: TranslationResources = {
empty: "이 에이전트와 대화를 시작하세요...",
scrollToBottom: "맨 아래로 스크롤",
historyLoadFailed: "에이전트 기록을 로드할 수 없습니다.",
messageCapped: "이 메시지는 길이 제한으로 잘렸습니다({{bytes}}바이트).",
permission: {
plan: "계획",
required: "권한 필요",
@@ -347,6 +346,7 @@ export const ko: TranslationResources = {
added: "추가됨",
started: "시작됨",
completed: "완료됨",
reopened: "다시 열림",
},
},
compaction: {
+1 -1
View File
@@ -203,7 +203,6 @@ export const ptBR: TranslationResources = {
empty: "Comece a conversar com este agente...",
scrollToBottom: "Rolar para o fim",
historyLoadFailed: "Não foi possível carregar o histórico do agente",
messageCapped: "Esta mensagem foi truncada ({{bytes}} bytes).",
permission: {
plan: "Plano",
required: "Permissão necessária",
@@ -349,6 +348,7 @@ export const ptBR: TranslationResources = {
added: "Adicionada",
started: "Iniciada",
completed: "Concluída",
reopened: "Reaberta",
},
},
compaction: {
+1 -1
View File
@@ -203,7 +203,6 @@ export const ru: TranslationResources = {
empty: "Начните общаться с этим агентом...",
scrollToBottom: "Прокрутить вниз",
historyLoadFailed: "Не удалось загрузить историю агента",
messageCapped: "Это сообщение было обрезано ({{bytes}} байт).",
permission: {
plan: "План",
required: "Требуется разрешение",
@@ -348,6 +347,7 @@ export const ru: TranslationResources = {
added: "Добавлена",
started: "Начата",
completed: "Завершена",
reopened: "Возобновлена",
},
},
compaction: {
+1 -1
View File
@@ -203,7 +203,6 @@ export const zhCN: TranslationResources = {
empty: "开始和这个 Agent 对话...",
scrollToBottom: "滚动到底部",
historyLoadFailed: "无法加载智能体历史记录",
messageCapped: "此消息已被截断({{bytes}} 字节)。",
permission: {
plan: "Plan",
required: "需要权限",
@@ -346,6 +345,7 @@ export const zhCN: TranslationResources = {
added: "已添加",
started: "已开始",
completed: "已完成",
reopened: "已重新打开",
},
},
compaction: {
+4 -1
View File
@@ -95,7 +95,7 @@ export function useOpenAgentListGesture(enabled: boolean) {
}
})
.onStart(() => {
startedRevision.value = beginGesture({ origin: "agent" });
startedRevision.value = beginGesture({ origin: "agent", preview: "agent-list" });
})
.onUpdate((event) => {
updateGesture(startedRevision.value, -event.translationX / windowWidth);
@@ -188,6 +188,7 @@ export function useCloseAgentListGesture() {
.onStart(() => {
startedRevision.value = beginGesture({
origin: "agent-list",
preview: "agent-list",
});
})
.onUpdate((event) => {
@@ -289,6 +290,7 @@ export function useOpenFileExplorerGesture({ enabled, onOpen }: OpenFileExplorer
.onStart(() => {
startedRevision.value = beginGesture({
origin: "agent",
preview: "file-explorer",
});
})
.onUpdate((event) => {
@@ -384,6 +386,7 @@ export function useCloseFileExplorerGesture() {
.onStart(() => {
startedRevision.value = beginGesture({
origin: "file-explorer",
preview: "file-explorer",
});
})
.onUpdate((event) => {
@@ -4,7 +4,6 @@ import {
canBeginMobilePanelGesture,
createMobilePanelMotionState,
getMobilePanelFrame,
isMobilePanelActive,
isMobilePanelGestureCurrent,
transitionMobilePanel,
type MobilePanelCommit,
@@ -78,71 +77,6 @@ class MobilePanelsScenario {
}
describe("mobile panel ownership", () => {
it("publishes activity only after motion settles", () => {
const initial = createMobilePanelMotionState({ target: "agent", revision: 0 });
const dragging = transitionMobilePanel(initial, {
type: "gesture.begin",
origin: "agent",
}).state;
const released = transitionMobilePanel(dragging, {
type: "gesture.finish",
startedRevision: 0,
success: true,
target: "agent-list",
}).state;
const commanded = transitionMobilePanel(released, {
type: "command",
selection: { target: "agent-list", revision: 1 },
}).state;
expect(isMobilePanelActive(dragging, "agent-list")).toBe(false);
expect(isMobilePanelActive(released, "agent-list")).toBe(false);
expect(isMobilePanelActive(commanded, "agent-list")).toBe(false);
const settled = transitionMobilePanel(commanded, {
type: "animation.finished",
revision: 1,
target: "agent-list",
}).state;
expect(isMobilePanelActive(settled, "agent-list")).toBe(true);
});
it("does not change activity for a cancelled preview", () => {
const initial = createMobilePanelMotionState({ target: "agent", revision: 0 });
const dragging = transitionMobilePanel(initial, {
type: "gesture.begin",
origin: "agent",
}).state;
const cancelled = transitionMobilePanel(dragging, {
type: "gesture.finish",
startedRevision: 0,
success: false,
target: "agent-list",
}).state;
expect(isMobilePanelActive(dragging, "agent")).toBe(true);
expect(isMobilePanelActive(cancelled, "agent")).toBe(true);
expect(isMobilePanelActive(cancelled, "agent-list")).toBe(false);
});
it("keeps the visible panel active until its closing motion settles", () => {
const initial = createMobilePanelMotionState({ target: "agent-list", revision: 0 });
const closing = transitionMobilePanel(initial, {
type: "command",
selection: { target: "agent", revision: 1 },
}).state;
expect(isMobilePanelActive(closing, "agent-list")).toBe(true);
const settled = transitionMobilePanel(closing, {
type: "animation.finished",
revision: 1,
target: "agent",
}).state;
expect(isMobilePanelActive(settled, "agent-list")).toBe(false);
expect(isMobilePanelActive(settled, "agent")).toBe(true);
});
it("follows programmatic commands through left, center, and right", () => {
const panels = new MobilePanelsScenario();

Some files were not shown because too many files have changed in this diff Show More