mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-22 01:02:41 +00:00
Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
49b622bd14 | ||
|
|
36e6ccd6c7 | ||
|
|
fa0f04058d | ||
|
|
d517b3314e | ||
|
|
a8e6c57f15 | ||
|
|
1f8a4559a8 | ||
|
|
2187124642 | ||
|
|
154a088d6e | ||
|
|
71b236d38a | ||
|
|
8a4ce5a482 | ||
|
|
b3ed7363c6 | ||
|
|
c062280429 | ||
|
|
febe9611bf | ||
|
|
642d69b142 | ||
|
|
5aee41952e | ||
|
|
48329facc3 | ||
|
|
97083dd736 | ||
|
|
5c2c85ebc8 | ||
|
|
30fb66c8cb | ||
|
|
05b074764d | ||
|
|
5285b7e502 | ||
|
|
409b8f9312 | ||
|
|
485221b739 | ||
|
|
ed48655a77 | ||
|
|
cc8fe41e28 | ||
|
|
8216e86ecb | ||
|
|
79a3942393 |
@@ -11,7 +11,7 @@ canonical files and are trying to add or change one.
|
||||
| ---------------------------------------- | ----------------------------------------------------------------- |
|
||||
| `components/ui/combobox.tsx` | Anchored picker with search; mobile falls back to bottom sheet |
|
||||
| `components/ui/tooltip.tsx` | Non-interactive hover/long-press tooltip |
|
||||
| `components/workspace-hover-card.tsx` | Desktop-web hover card with measure + computePosition + Portal |
|
||||
| `components/ui/hover-card.tsx` | Desktop-web hover card the pointer can move onto; Portal |
|
||||
| `components/ui/autocomplete-popover.tsx` | Slash-command autocomplete anchored to the focused composer input |
|
||||
|
||||
Each handles a different mix of concerns: combobox owns input focus, tooltip is
|
||||
@@ -92,7 +92,7 @@ portal can cover them.
|
||||
Painting and keyboard ownership use the same relative layer model. Register
|
||||
desktop modal, combobox, and dropdown focus scopes with `useWebOverlayRegistration`; the
|
||||
highest painted scope alone receives overlay keys, traps focus, and restores
|
||||
focus when it closes. Do not add component-local global Escape listeners: two
|
||||
focus when it closes. Hover cards register with `manageFocus={false}`: they claim overlay keys without moving or trapping focus on pointer hover. Do not add component-local global Escape listeners: two
|
||||
stacked overlays would both close on one keypress.
|
||||
|
||||
If an overlay is rendered by a global host rather than beneath its opener in
|
||||
|
||||
+2
-2
@@ -33,8 +33,8 @@ Authoritative terminology. UI label wins. Don't invent synonyms; use what's here
|
||||
- **Provider** — Agent backend (Claude Code, Codex, Copilot, OpenCode, Pi, Oh My Pi). UI: "Provider". Code: `ProviderSnapshotEntry` (`packages/protocol/src/messages.ts:198`).
|
||||
- **Usage source** — Plugin registration that discovers accounts and fetches plan usage. Code: `UsageSourceRegistration` (`packages/plugin/src/server/usage.ts`).
|
||||
- **Report ID** — Stable daemon-composed identity for one source account: `<sourceId>:<accountKey>`. The source owns the account key; clients treat the whole ID as opaque. Code: `UsageReportEntry.id` (`packages/protocol/src/messages.ts`).
|
||||
- **Usage report** — A source's normalized usage for one account, including status and optional windows, balances, and details. Its entry carries the Report ID, account label, and fetch time. Each report renders as one card on the Usage screen, in host Settings, and in an agent's context window details (a tooltip on wide screens, a sheet on compact ones), which show only the account that agent runs under, without pins. Only the sheet has Refresh. Code: `UsageReport` (`packages/plugin/src/server/usage.ts`), `UsageCard` (`packages/app/src/usage/card.tsx`), `AgentUsage` (`packages/app/src/usage/agent-usage.tsx`).
|
||||
- **Usage (sidebar item)** — The sidebar footer item showing each pinned window's source icon and percent, hidden while no pinned window has data (the footer's Usage icon still opens the screen); pressing it opens the Usage screen (a bottom sheet on phones). Off until the user turns on **Summary in sidebar** (Usage Settings) or the Usage row in Settings > Sidebar; window rows pin only while it is on, and saved pins come back when it is turned on again. A pin is `{ sourceId, windowId }` and shows once per account of that source. Pins and the used/remaining choice are one per-device preference (`AppSettings.usage`) that every usage surface follows. It reads the active workspace's host, else the first connected host with usage sources. Code: `packages/app/src/usage/sidebar-item.tsx`, `usage/pinned.ts`, `usage/preferences.ts`.
|
||||
- **Usage report** — A source's normalized usage for one account, including status and optional windows, balances, and details. Its entry carries the Report ID, account label, and fetch time. Each report renders as one card on the Usage screen, in host Settings, and in an agent's context window details (a hover card on desktop web, a tooltip on native wide screens, a sheet on compact ones), which show only the account that agent runs under, without pins. The hover card and the sheet have Refresh; the native tooltip takes no presses. Code: `UsageReport` (`packages/plugin/src/server/usage.ts`), `UsageCard` (`packages/app/src/usage/card.tsx`), `AgentUsage` (`packages/app/src/usage/agent-usage.tsx`).
|
||||
- **Usage (sidebar item)** — The sidebar footer item showing each pinned window's source icon and percent, hidden while no pinned window has data (the footer's Usage icon remains available); both entry points open the Usage screen on wide layouts and the same bottom sheet on phones. Off until the user turns on **Summary in sidebar** (Usage Settings) or the Usage row in Settings > Sidebar; window rows pin only while it is on, and saved pins come back when it is turned on again. A pin is `{ sourceId, windowId }` and shows once per account of that source. Pins and the used/remaining choice are one per-device preference (`AppSettings.usage`) that every usage surface follows. It reads the active workspace's host, else the first connected host with usage sources. Code: `packages/app/src/usage/sidebar-item.tsx`, `usage/pinned.ts`, `usage/preferences.ts`.
|
||||
- **Model** — A specific LLM offered by a provider. UI: "Model" / "Select model". Code: `AgentModelDefinition` (`packages/protocol/src/messages.ts:187`).
|
||||
- **Tab** — UI surface representing one session inside a workspace. Not a conceptual unit; use **Agent session** when talking about the model. Code: `WorkspaceTabDescriptor` (`packages/app/src/screens/workspace/workspace-tabs-types.ts`).
|
||||
- **Terminal** — Workspace-scoped PTY shell streamed over the binary mux channel. UI: "Terminal". Code: `TerminalStreamFrame` (`packages/protocol/src/terminal-stream-protocol.ts`).
|
||||
|
||||
+2
-2
@@ -135,7 +135,7 @@ Heuristic: if your hover state is going to be `useState`'d and read by anything
|
||||
|
||||
Sometimes the revealed content can't live inside the trigger — a hover card portals into a different layer, a tooltip floats above other content, a popover renders into a `Portal`. There's a real visual gap the user has to cross with the cursor.
|
||||
|
||||
For this case, use `useHoverSafeZone` (`packages/app/src/hooks/use-hover-safe-zone.ts`). It computes a rectangular "bridge" between the trigger and the content; while the pointer is inside trigger, content, or the bridge, the card stays open. A short grace timer absorbs jitter at the edges. The canonical caller is `packages/app/src/components/workspace-hover-card.tsx`.
|
||||
For a card whose content the user can point at or press, use `HoverCard` (`packages/app/src/components/ui/hover-card.tsx`). It is built on `useHoverSafeZone` (`packages/app/src/hooks/use-hover-safe-zone.ts`), which computes a rectangular "bridge" across the gap between the trigger and the content, whether the card sits beside, above, or below the trigger. While the pointer is inside trigger, content, or the bridge, the card stays open. A short grace timer absorbs jitter at the edges. `Tooltip` takes no pointer events and closes as soon as the pointer leaves the trigger. If the trigger has no focusable child, give `HoverCardTrigger` `focusable` and an accessible label so keyboard users can open the same content.
|
||||
|
||||
Don't roll your own. The math is annoying, the edge cases (pointer leaves window, drag in progress, content unmounts) are subtle, and we already paid for the hook.
|
||||
|
||||
@@ -150,5 +150,5 @@ Before opening a PR that touches hover:
|
||||
- [ ] Revealed content inside the trigger uses `opacity` + `pointerEvents`, not conditional rendering, if mounting it would reflow the trigger.
|
||||
- [ ] Visibility on native and compact layouts works without hover (`isHovered || isNative || isCompact`).
|
||||
- [ ] A menu opened from the revealed trigger keeps the trigger rendered while it is open, so losing hover can't strand it.
|
||||
- [ ] If the revealed content sits in a separate layer (portal, floating panel), `useHoverSafeZone` is wired up.
|
||||
- [ ] If the revealed content sits in a separate layer (portal, floating panel) and the user can point at it, it is a `HoverCard`.
|
||||
- [ ] You opened the dev server, hovered the trigger, and slowly moved the mouse along **every** revealed element — including any visible gaps — without losing hover state.
|
||||
|
||||
+2
-2
@@ -197,7 +197,7 @@ its own.
|
||||
inactive. An async action can navigate before its menu closes; a hidden panel must not leave a
|
||||
portal backdrop blocking the destination. On web the chat suspends one commit after it goes
|
||||
inactive, and that inactive commit is where the surface unmounts.
|
||||
- Anchoring, flipping, and edge clamping live in `menu-anchor.ts` and are unit-tested. Fix
|
||||
positioning bugs there, not at a call site.
|
||||
- Anchoring, flipping, and edge clamping live in `components/ui/anchor.ts`, shared with the hover
|
||||
card, and are unit-tested. Fix positioning bugs there, not at a call site.
|
||||
- Everything else about floating surfaces on Android — Portal/Modal escape, lifecycle gates,
|
||||
status-bar offset, the open flash — is in [floating-panels.md](floating-panels.md).
|
||||
|
||||
@@ -32,8 +32,10 @@ The UI worklet owns transient motion:
|
||||
|
||||
React publishes the active panel only when the canonical target and the UI-thread position agree at
|
||||
the final anchor. Retained content never observes gesture previews, progress, or an unsettled target.
|
||||
The gesture hosts stay mounted; worklets reveal their retained overlays through native styles while
|
||||
React owns pointer events and accessibility. Native panel hosts and their dependent draggable lists
|
||||
The gesture hosts stay mounted. Native worklets own overlay opacity and pointer events while
|
||||
React owns settled panel activity and accessibility. Keep hidden native overlays laid out: collapsing
|
||||
their scroll ranges makes Android spring retained offsets back to zero during touch cancellation or
|
||||
release. Native panel hosts and their dependent draggable lists
|
||||
also retain identity across appearance hydration and settings changes. Do not wrap those hosts in
|
||||
appearance keys; see [Unistyles appearance boundaries](unistyles.md#runtime-theme-patching-for-user-preferences).
|
||||
|
||||
|
||||
@@ -65,6 +65,26 @@ Metro, and device through the `PASEO_COMPOSER_KEYBOARD_*` variables in
|
||||
the headless input helper cannot verify the
|
||||
[visible composer constraints](floating-panels.md#gotcha-3--keyboard-layout-and-portal-anchors).
|
||||
|
||||
The Android sidebar scroll-retention flow requires a connected host with enough
|
||||
workspaces to overflow the compact sidebar. Pass `TOP_WORKSPACE` and
|
||||
`SCROLLED_WORKSPACE` as the `serverId:workspaceId` suffixes of their sidebar row
|
||||
IDs. Choose one row near the top and one initially below the viewport. Replace
|
||||
the quoted example values below with those IDs. Start in a workspace with the
|
||||
sidebar closed and keep the list stable during the run. The same flow checks
|
||||
reopening by swipe and button:
|
||||
|
||||
```bash
|
||||
agent-device replay packages/app/e2e/mobile/agent-device/native-sidebar-scroll-retention.android.yaml \
|
||||
--maestro --platform android --serial emulator-5556 --metro-port 8099 \
|
||||
--env TOP_WORKSPACE='server-id:top-workspace-id' \
|
||||
--env SCROLLED_WORKSPACE='server-id:scrolled-workspace-id'
|
||||
```
|
||||
|
||||
Pass this checkout's Metro port so the debug app uses the intended bundle.
|
||||
For iOS, compare the scrolled row's screen bounds and screenshots across reopening.
|
||||
Agent Device's iOS visibility lookup includes offscreen scroll descendants, so
|
||||
its `assertNotVisible` cannot establish the starting scroll position for this flow.
|
||||
|
||||
On a Play-image emulator, disable Gmail and Calendar first. Their welcome
|
||||
screens launch on their own, take input focus, and the run fails with
|
||||
`IME did not become visible` while the app still looks focused:
|
||||
|
||||
+10
-5
@@ -117,7 +117,12 @@ the bundled integration; an entry with `extends` shadows it with a custom provid
|
||||
|
||||
## Install from a registry
|
||||
|
||||
`paseo plugin install owner/slug` installs the registry's reviewed artifact. Registry installs
|
||||
Registry installs are off by default. Set `pluginRegistryEnabled: true` in daemon config or
|
||||
`PASEO_PLUGIN_REGISTRY_ENABLED=1`, then restart the daemon. While they are off, bare
|
||||
`owner/repo` is GitHub shorthand and the daemon never contacts a registry.
|
||||
|
||||
With registry installs on, `paseo plugin install owner/slug` installs the registry's reviewed
|
||||
artifact, and GitHub shorthand requires `github:`. Registry installs
|
||||
keep the registry URL and ID, so update checks use its approved pin. Explicit version/ref
|
||||
selection is unavailable for registry installs; install an explicit source to select your own.
|
||||
|
||||
@@ -133,13 +138,13 @@ owns static hosting, record shapes, pins, and advisory install counts.
|
||||
|
||||
## Install a Git source
|
||||
|
||||
GitHub shorthand requires `github:`. Other hosts use a Git URL. An existing directory
|
||||
still wins over source resolution.
|
||||
GitHub repositories use `owner/repository` or `github:owner/repository`. Other hosts use a Git
|
||||
URL. An existing directory still wins over source resolution.
|
||||
|
||||
```bash
|
||||
paseo plugin install github:owner/repository
|
||||
paseo plugin install owner/repository
|
||||
paseo plugin install https://gitlab.com/group/repository.git
|
||||
paseo plugin install github:owner/monorepo:plugins/review
|
||||
paseo plugin install owner/monorepo:plugins/review
|
||||
paseo plugin install github:owner/repository --ref main
|
||||
```
|
||||
|
||||
|
||||
@@ -51,7 +51,7 @@ Claude hook mapping:
|
||||
|
||||
- `UserPromptSubmit` → `running`
|
||||
- `Stop`, `StopFailure`, `SessionEnd` → `idle`
|
||||
- `Notification` with `reason` or `matcher` equal to `idle_prompt` → `needs-input`
|
||||
- `Notification` with `notification_type` equal to `idle_prompt` → `needs-input`
|
||||
|
||||
Claude does not run `Stop` when the user interrupts a turn. A standalone Ctrl-C or Escape input
|
||||
while terminal activity is working clears the activity without finished attention. The same
|
||||
|
||||
@@ -4,7 +4,6 @@ import { getServerId } from "../support/helpers/server-id";
|
||||
import { seedMockAgentWorkspace } from "../support/helpers/mock-agent";
|
||||
import { openAgentRoute } from "../support/helpers/mock-agent";
|
||||
import { resetSeededPageState, openSessions } from "../support/helpers/archive-tab";
|
||||
import { closeSidebarDisplayPreferences, openSidebarDisplayPage } from "../support/helpers/sidebar";
|
||||
|
||||
test("agent list age advances and command center says just now for a fresh agent", async ({
|
||||
page,
|
||||
@@ -41,9 +40,6 @@ test("agent list age advances and command center says just now for a fresh agent
|
||||
"3m ago",
|
||||
);
|
||||
|
||||
await openSidebarDisplayPage(page, "sidebar-display-show");
|
||||
await page.getByRole("menuitem", { name: "Last activity", exact: true }).click();
|
||||
await closeSidebarDisplayPreferences(page);
|
||||
await expect(page.getByTestId("sidebar-workspace-timestamp").first()).toHaveText("3m");
|
||||
} finally {
|
||||
await session.cleanup();
|
||||
|
||||
@@ -428,7 +428,16 @@ async function findFromComposer(page: Page, shortcut: string, testInfo: TestInfo
|
||||
}
|
||||
}
|
||||
|
||||
test("opens and refocuses Find with Control+f from the composer", async ({ page }, testInfo) => {
|
||||
test("opens and refocuses Find with Control+f from the composer on Linux", async ({
|
||||
page,
|
||||
}, testInfo) => {
|
||||
// Chromium retains the host navigator.platform even when its user agent is overridden.
|
||||
const session = await page.context().newCDPSession(page);
|
||||
await session.send("Emulation.setUserAgentOverride", {
|
||||
userAgent:
|
||||
"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36",
|
||||
platform: "Linux x86_64",
|
||||
});
|
||||
await findFromComposer(page, "Control+f", testInfo);
|
||||
});
|
||||
|
||||
|
||||
@@ -1,7 +1,8 @@
|
||||
import { test } from "../support/fixtures";
|
||||
import { expect, test, type Page } from "../support/fixtures";
|
||||
import {
|
||||
expectComposerDraft,
|
||||
expectComposerFocused,
|
||||
expectComposerNotFocused,
|
||||
expectComposerVisible,
|
||||
submitMessage,
|
||||
typeIntoFocusedComposer,
|
||||
@@ -27,3 +28,51 @@ test("submitting a message leaves the composer ready for the next message", asyn
|
||||
await agent.cleanup();
|
||||
}
|
||||
});
|
||||
|
||||
test("opening an agent focuses the composer when a mouse drives the UI", async ({ page }) => {
|
||||
const agent = await seedMockAgentWorkspace({
|
||||
repoPrefix: "composer-focus-open-",
|
||||
title: "Composer focus on open",
|
||||
});
|
||||
|
||||
try {
|
||||
await openAgentRoute(page, agent);
|
||||
await expectComposerFocused(page);
|
||||
} finally {
|
||||
await agent.cleanup();
|
||||
}
|
||||
});
|
||||
|
||||
async function waitForAnimationFrames(page: Page, count: number): Promise<void> {
|
||||
await page.evaluate(async (frames) => {
|
||||
for (let frame = 0; frame < frames; frame += 1) {
|
||||
await new Promise((resolve) => requestAnimationFrame(resolve));
|
||||
}
|
||||
}, count);
|
||||
}
|
||||
|
||||
test.describe("touch screen wide enough for the desktop layout", () => {
|
||||
// A tablet or an unfolded foldable gets the desktop layout, but focusing the
|
||||
// composer there raises the on-screen keyboard over the conversation.
|
||||
test.use({ viewport: { width: 1024, height: 768 }, isMobile: true, hasTouch: true });
|
||||
|
||||
test("opening an agent leaves the composer unfocused", async ({ page }) => {
|
||||
const agent = await seedMockAgentWorkspace({
|
||||
repoPrefix: "composer-focus-touch-",
|
||||
title: "Composer focus on touch",
|
||||
});
|
||||
|
||||
try {
|
||||
await openAgentRoute(page, agent);
|
||||
await expectComposerVisible(page);
|
||||
expect(
|
||||
await page.evaluate(() => window.matchMedia("(hover: hover) and (pointer: fine)").matches),
|
||||
).toBe(false);
|
||||
// Autofocus makes its first attempt on the next animation frame.
|
||||
await waitForAnimationFrames(page, 4);
|
||||
await expectComposerNotFocused(page);
|
||||
} finally {
|
||||
await agent.cleanup();
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
@@ -1,16 +1,21 @@
|
||||
import type { Locator, Page } from "@playwright/test";
|
||||
import { expect, test as base } from "../support/fixtures";
|
||||
import { expectComposerVisible } from "../support/helpers/composer";
|
||||
import {
|
||||
composerLocator,
|
||||
expectComposerVisible,
|
||||
submitMessageWithButton,
|
||||
} from "../support/helpers/composer";
|
||||
import {
|
||||
type AgentUsageScript,
|
||||
closeContextWindowSheet,
|
||||
contextWindowSheet,
|
||||
contextWindowDetails,
|
||||
expectRefreshButtons,
|
||||
expiredLogin,
|
||||
gate,
|
||||
hoverContextWindowMeter,
|
||||
leaveContextWindowMeter,
|
||||
type MockAgentSession,
|
||||
moveOntoContextWindowDetails,
|
||||
onPersonalLogin,
|
||||
onWorkLogin,
|
||||
openAgent,
|
||||
@@ -24,6 +29,7 @@ import {
|
||||
} from "../support/helpers/context-window";
|
||||
import { openAgentRoute, seedMockAgentWorkspace } from "../support/helpers/mock-agent";
|
||||
import { claudeAndCodexReports, expectUnpinnableRows } from "../support/helpers/usage-sidebar-item";
|
||||
import { installLoginUsage } from "../support/helpers/usage-login";
|
||||
|
||||
const test = base.extend<{ agent: MockAgentSession }>({
|
||||
agent: async ({ page: _page }, provide) => {
|
||||
@@ -107,6 +113,66 @@ const DESKTOP = { width: 1440, height: 900 };
|
||||
const COMPACT = { width: 390, height: 844 };
|
||||
const LOGIN_EXPIRED = /^Login expired .*Run claude to refresh it\.$/;
|
||||
|
||||
for (const layout of [
|
||||
{
|
||||
name: "desktop",
|
||||
viewport: DESKTOP,
|
||||
open: hoverContextWindowMeter,
|
||||
close: leaveContextWindowMeter,
|
||||
},
|
||||
{
|
||||
name: "compact",
|
||||
viewport: COMPACT,
|
||||
open: pressContextWindowMeter,
|
||||
close: closeContextWindowSheet,
|
||||
},
|
||||
]) {
|
||||
test(`shows account usage before the first turn (${layout.name})`, async ({ page }) => {
|
||||
test.setTimeout(180_000);
|
||||
const source = await installLoginUsage({
|
||||
status: "available",
|
||||
windows: [{ id: "session", label: "Session", usedPct: 31 }],
|
||||
});
|
||||
try {
|
||||
const agent = await seedMockAgentWorkspace({
|
||||
repoPrefix: "context-window-empty-",
|
||||
title: "Agent before its first turn",
|
||||
});
|
||||
try {
|
||||
await page.setViewportSize(layout.viewport);
|
||||
await openAgent(page, agent);
|
||||
|
||||
await test.step("the empty meter opens context details and account usage", async () => {
|
||||
const details = await layout.open(page, "Context window: No context data");
|
||||
await expect(details.getByText("No context data", { exact: true })).toBeVisible();
|
||||
await expect(details.getByText("0% used", { exact: true })).toHaveCount(0);
|
||||
await expect(details.getByText(/tokens$/)).toHaveCount(0);
|
||||
const account = usageCard(details, "login-journey:account");
|
||||
await expect(account.getByText("Session", { exact: true })).toBeVisible();
|
||||
await expect(account.getByText("31%", { exact: true })).toBeVisible();
|
||||
await qaScreenshot(page, `context-without-data-${layout.name}`);
|
||||
await layout.close(page);
|
||||
});
|
||||
|
||||
await test.step("the first context reading replaces the empty state", async () => {
|
||||
await submitMessageWithButton(page, "emit 32000 byte file agent stream payload");
|
||||
const details = await layout.open(page);
|
||||
await expect(details.getByText("25% used", { exact: true })).toBeVisible();
|
||||
await expect(details.getByText("32k / 128k tokens", { exact: true })).toBeVisible();
|
||||
await expect(details.getByText("No context data", { exact: true })).toHaveCount(0);
|
||||
await expect(
|
||||
usageCard(details, "login-journey:account").getByText("31%", { exact: true }),
|
||||
).toBeVisible();
|
||||
});
|
||||
} finally {
|
||||
await agent.cleanup();
|
||||
}
|
||||
} finally {
|
||||
await source.cleanup();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
type OpenDetails = (page: Page) => Promise<Locator>;
|
||||
type Shot = (state: string) => Promise<void>;
|
||||
|
||||
@@ -142,7 +208,6 @@ async function expectCardsToStreamIn(
|
||||
// Only the agent's login, never the host's default one, and no pins.
|
||||
await expect(details.getByText("dev@example.com", { exact: true })).toHaveCount(0);
|
||||
await expectUnpinnableRows(details);
|
||||
await expect(details.getByText("Updated just now", { exact: true })).toHaveCount(2);
|
||||
return details;
|
||||
}
|
||||
|
||||
@@ -177,24 +242,43 @@ async function expectOnlyContextWindowWithoutUsage(
|
||||
}
|
||||
|
||||
for (const theme of ["light", "dark"] as const) {
|
||||
test(`the context window tooltip shows the agent's usage (${theme})`, async ({ page, agent }) => {
|
||||
test(`the context window hover card shows the agent's usage (${theme})`, async ({
|
||||
page,
|
||||
agent,
|
||||
}) => {
|
||||
test.setTimeout(240_000);
|
||||
const [claude] = claudeAndCodexReports();
|
||||
const usage = await scriptAgentUsage(page);
|
||||
await page.emulateMedia({ colorScheme: theme });
|
||||
await page.setViewportSize(DESKTOP);
|
||||
await openAgent(page, agent);
|
||||
const shot: Shot = (state) => qaScreenshot(page, `tooltip-desktop-${theme}-${state}`);
|
||||
const shot: Shot = (state) => qaScreenshot(page, `hover-card-desktop-${theme}-${state}`);
|
||||
|
||||
await test.step("reports stream in one card at a time, without Refresh", async () => {
|
||||
const tooltip = await expectCardsToStreamIn(page, usage, hoverContextWindowMeter, shot);
|
||||
// The tooltip cannot be pressed, so its cards have no Refresh.
|
||||
await expectRefreshButtons(tooltip, 0);
|
||||
await test.step("reports stream in one card at a time, each with Refresh", async () => {
|
||||
const card = await expectCardsToStreamIn(page, usage, hoverContextWindowMeter, shot);
|
||||
await expectRefreshButtons(card, 2);
|
||||
await shot("ready");
|
||||
expect(usage.agentRequests()).toEqual([agent.agentId]);
|
||||
});
|
||||
|
||||
await test.step("the card stays open while the pointer moves onto it", async () => {
|
||||
const card = contextWindowDetails(page);
|
||||
await moveOntoContextWindowDetails(page, card);
|
||||
await page.waitForTimeout(300);
|
||||
await expect(card).toBeVisible();
|
||||
});
|
||||
|
||||
await test.step("Refresh replaces the card with the source's new report", async () => {
|
||||
usage.answerNext([expiredLogin(onWorkLogin(claude!))]);
|
||||
const card = contextWindowDetails(page);
|
||||
await refreshUsageCard(card, "Claude");
|
||||
await expect(card.getByText(LOGIN_EXPIRED)).toBeVisible();
|
||||
expect(usage.refreshedReports()).toEqual([["claude:work"]]);
|
||||
});
|
||||
|
||||
await test.step("after a resume under another login, only that login shows", async () => {
|
||||
// Refresh can retain focus; return to the composer before testing pointer dismissal.
|
||||
await composerLocator(page).focus();
|
||||
// Closed while the old login's report is still on its way.
|
||||
await leaveContextWindowMeter(page);
|
||||
const slowSource = gate();
|
||||
@@ -208,25 +292,25 @@ for (const theme of ["light", "dark"] as const) {
|
||||
usage.answerNext({
|
||||
stream: [resumed.promise, onPersonalLogin(claude!), finished.promise],
|
||||
});
|
||||
const tooltip = await hoverContextWindowMeter(page);
|
||||
await expect(tooltip.getByText("Loading usage...", { exact: true })).toBeVisible();
|
||||
await expect(tooltip.getByText("work@example.com", { exact: true })).toHaveCount(0);
|
||||
const card = await hoverContextWindowMeter(page);
|
||||
await expect(card.getByText("Loading usage...", { exact: true })).toBeVisible();
|
||||
await expect(card.getByText("work@example.com", { exact: true })).toHaveCount(0);
|
||||
|
||||
// The old login's report lands during the new request, before the new login's.
|
||||
slowSource.open();
|
||||
resumed.open();
|
||||
await expect(
|
||||
usageCard(tooltip, "claude:personal").getByText("personal@example.com", { exact: true }),
|
||||
usageCard(card, "claude:personal").getByText("personal@example.com", { exact: true }),
|
||||
).toBeVisible();
|
||||
await expect(tooltip.getByText("work@example.com", { exact: true })).toHaveCount(0);
|
||||
await expect(card.getByText("work@example.com", { exact: true })).toHaveCount(0);
|
||||
finished.open();
|
||||
});
|
||||
|
||||
await test.step("a report with a problem shows it on the card", async () => {
|
||||
usage.answerNext([expiredLogin(onWorkLogin(claude!))]);
|
||||
await reloadAgent(page);
|
||||
const tooltip = await hoverContextWindowMeter(page);
|
||||
await expect(tooltip.getByText(LOGIN_EXPIRED)).toBeVisible();
|
||||
const card = await hoverContextWindowMeter(page);
|
||||
await expect(card.getByText(LOGIN_EXPIRED)).toBeVisible();
|
||||
await shot("problem");
|
||||
});
|
||||
|
||||
@@ -256,13 +340,15 @@ for (const theme of ["light", "dark"] as const) {
|
||||
await test.step("reports stream in one card at a time, each with Refresh", async () => {
|
||||
const sheet = await expectCardsToStreamIn(page, usage, pressContextWindowMeter, shot);
|
||||
await expectRefreshButtons(sheet, 2);
|
||||
// Without hover, each card prints its freshness instead of a Refresh tooltip.
|
||||
await expect(sheet.getByText("Updated just now", { exact: true })).toHaveCount(2);
|
||||
await shot("ready");
|
||||
expect(usage.agentRequests()).toEqual([agent.agentId]);
|
||||
});
|
||||
|
||||
await test.step("Refresh replaces the card with the source's new report", async () => {
|
||||
usage.answerNext([expiredLogin(onWorkLogin(claude!))]);
|
||||
const sheet = contextWindowSheet(page);
|
||||
const sheet = contextWindowDetails(page);
|
||||
await refreshUsageCard(sheet, "Claude");
|
||||
await expect(sheet.getByText(LOGIN_EXPIRED)).toBeVisible();
|
||||
expect(usage.refreshedReports()).toEqual([["claude:work"]]);
|
||||
@@ -283,3 +369,81 @@ for (const theme of ["light", "dark"] as const) {
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
test("context details support keyboard entry and dismiss when the viewport moves", async ({
|
||||
page,
|
||||
agent,
|
||||
}) => {
|
||||
const usage = await scriptAgentUsage(page);
|
||||
await page.setViewportSize(DESKTOP);
|
||||
await openAgent(page, agent);
|
||||
await submitMessageWithButton(page, "withhold synthetic user message until interrupted");
|
||||
const stop = page.getByRole("button", { name: /stop|cancel/i }).first();
|
||||
await expect(stop).toBeVisible();
|
||||
const [claude] = claudeAndCodexReports();
|
||||
usage.answerNext([onPersonalLogin(claude!)]);
|
||||
const meter = page.getByTestId("context-window-meter");
|
||||
const trigger = page.getByRole("button", {
|
||||
name: (await meter.getAttribute("aria-label"))!,
|
||||
exact: true,
|
||||
});
|
||||
await expect(trigger).toHaveAttribute("tabindex", "0");
|
||||
await trigger.focus();
|
||||
const details = contextWindowDetails(page);
|
||||
await expect(details).toBeVisible();
|
||||
await expect(details.getByRole("button", { name: "Refresh Claude", exact: true })).toBeVisible();
|
||||
await trigger.press("ArrowDown");
|
||||
await expect(details.getByRole("button", { name: "Refresh Claude", exact: true })).toBeFocused();
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(details).toHaveCount(0);
|
||||
await expect(stop).toBeVisible();
|
||||
await expect(trigger).toBeFocused();
|
||||
for (const key of ["Enter", " "]) {
|
||||
usage.answerNext([onPersonalLogin(claude!)]);
|
||||
await trigger.press(key);
|
||||
await expect(details).toBeVisible();
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(details).toHaveCount(0);
|
||||
await expect(stop).toBeVisible();
|
||||
await expect(trigger).toBeFocused();
|
||||
}
|
||||
usage.answerNext([onPersonalLogin(claude!)]);
|
||||
await trigger.press("ArrowDown");
|
||||
await expect(details).toBeVisible();
|
||||
await page.setViewportSize({ width: 1280, height: 850 });
|
||||
await expect(details).toHaveCount(0);
|
||||
});
|
||||
|
||||
test("pointer hovering context details preserves composer focus", async ({ page, agent }) => {
|
||||
const usage = await scriptAgentUsage(page);
|
||||
await page.setViewportSize(DESKTOP);
|
||||
await openAgent(page, agent);
|
||||
const [claude] = claudeAndCodexReports();
|
||||
usage.answerNext([onPersonalLogin(claude!)]);
|
||||
const input = composerLocator(page);
|
||||
await input.focus();
|
||||
await hoverContextWindowMeter(page);
|
||||
await expect(input).toBeFocused();
|
||||
await leaveContextWindowMeter(page);
|
||||
await expect(input).toBeFocused();
|
||||
});
|
||||
|
||||
test("Find remains available after dismissing context details", async ({ page, agent }) => {
|
||||
const usage = await scriptAgentUsage(page);
|
||||
await page.setViewportSize(DESKTOP);
|
||||
await openAgent(page, agent);
|
||||
const [claude] = claudeAndCodexReports();
|
||||
usage.answerNext([onPersonalLogin(claude!)]);
|
||||
const meter = page.getByTestId("context-window-meter");
|
||||
const trigger = page.getByRole("button", {
|
||||
name: (await meter.getAttribute("aria-label"))!,
|
||||
exact: true,
|
||||
});
|
||||
await trigger.focus();
|
||||
await expect(contextWindowDetails(page)).toBeVisible();
|
||||
await page.keyboard.press("Escape");
|
||||
await expect(contextWindowDetails(page)).toHaveCount(0);
|
||||
await expect(trigger).toBeFocused();
|
||||
await page.keyboard.press("ControlOrMeta+f");
|
||||
await expect(page.getByRole("textbox", { name: "Find in pane", exact: true })).toBeFocused();
|
||||
});
|
||||
|
||||
@@ -96,6 +96,36 @@ async function seedAgentWithFileLink(input: LinkedFile) {
|
||||
}
|
||||
|
||||
test.describe("CodeMirror workspace file editing", () => {
|
||||
test("jumps to each relative reference to the same file", async ({ page }) => {
|
||||
const session = await seedMockAgentWorkspace({
|
||||
repoPrefix: "relative-reference-qa-",
|
||||
title: "Relative line references",
|
||||
initialPrompt: "Show both references",
|
||||
featureValues: {
|
||||
mockAssistantResponse: "First `src/router.go:46`. Then `src/router.go:403`.",
|
||||
},
|
||||
});
|
||||
try {
|
||||
await mkdir(path.join(session.cwd, "src"));
|
||||
await writeFile(
|
||||
path.join(session.cwd, "src/router.go"),
|
||||
Array.from({ length: 450 }, (_, n) => `// line ${n + 1}`).join("\n"),
|
||||
);
|
||||
await openAgentRoute(page, session);
|
||||
for (const line of [46, 403, 46]) {
|
||||
await page
|
||||
.getByTestId(`workspace-tab-agent_${session.agentId}`)
|
||||
.filter({ visible: true })
|
||||
.click();
|
||||
await page.getByText(`src/router.go:${line}`, { exact: true }).click();
|
||||
await expect(page.getByLabel(`Line ${line}, column 1`)).toBeVisible();
|
||||
}
|
||||
await page.screenshot({ path: test.info().outputPath("relative-line-target.png") });
|
||||
} finally {
|
||||
await session.cleanup();
|
||||
}
|
||||
});
|
||||
|
||||
test("shows an absolute POSIX assistant file link relative to the workspace on hover", async ({
|
||||
page,
|
||||
}) => {
|
||||
|
||||
@@ -155,6 +155,18 @@ test("keeps diagnostics available from Settings after globalizing the sheet", as
|
||||
test.describe("compact sidebar help", () => {
|
||||
test.use({ viewport: { width: 390, height: 844 }, isMobile: true, hasTouch: true });
|
||||
|
||||
test("footer buttons provide finger-sized targets and accept taps beyond the glyph", async ({
|
||||
page,
|
||||
}) => {
|
||||
await gotoAppShell(page);
|
||||
await openCompactSidebar(page);
|
||||
await expectFingerSizedFooterTargets(page);
|
||||
await tapHelpNearTargetEdge(page);
|
||||
await expect(page.getByTestId("sidebar-help-menu")).toBeVisible();
|
||||
await page.getByTestId("sidebar-help-diagnostics").click();
|
||||
await expectDiagnosticReport(page);
|
||||
});
|
||||
|
||||
test("offers diagnostics without advertising disabled keyboard shortcuts", async ({ page }) => {
|
||||
await gotoAppShell(page);
|
||||
await page.getByRole("button", { name: "Open menu", exact: true }).click();
|
||||
@@ -165,3 +177,26 @@ test.describe("compact sidebar help", () => {
|
||||
await expectDiagnosticReport(page);
|
||||
});
|
||||
});
|
||||
|
||||
async function openCompactSidebar(page: Page): Promise<void> {
|
||||
await page.getByRole("button", { name: "Open menu", exact: true }).click();
|
||||
await expect(page.getByTestId("sidebar-footer-bottom-line")).toBeVisible();
|
||||
}
|
||||
|
||||
async function expectFingerSizedFooterTargets(page: Page): Promise<void> {
|
||||
const buttons = page.getByTestId("sidebar-footer-bottom-line").getByRole("button");
|
||||
await expect(buttons).toHaveCount(5);
|
||||
for (const button of await buttons.all()) {
|
||||
const bounds = await button.boundingBox();
|
||||
expect(bounds?.width).toBeGreaterThanOrEqual(44);
|
||||
expect(bounds?.height).toBeGreaterThanOrEqual(44);
|
||||
// Glyphs stay at the composer toolbar size (some optically smaller); only the target grows.
|
||||
const glyphWidth = await button.locator("svg").first().getAttribute("width");
|
||||
expect(Number(glyphWidth)).toBeLessThanOrEqual(20);
|
||||
}
|
||||
}
|
||||
|
||||
async function tapHelpNearTargetEdge(page: Page): Promise<void> {
|
||||
const button = page.getByRole("button", { name: "Help and support", exact: true });
|
||||
await button.tap({ position: { x: 40, y: 40 } });
|
||||
}
|
||||
|
||||
@@ -88,6 +88,7 @@ async function openTouchWorkspaceList(page: Page, testInfo: TestInfo) {
|
||||
await gotoAppShell(page);
|
||||
await openMobileAgentSidebar(page);
|
||||
await expect(workspaceRow(page)).toBeVisible();
|
||||
await toggleTrailing(page, "Diff stats", true);
|
||||
await page.mouse.move(0, 0);
|
||||
await page.screenshot({ path: testInfo.outputPath("sidebar.png") });
|
||||
}
|
||||
@@ -106,6 +107,7 @@ async function openDesktopWorkspaceList(page: Page) {
|
||||
await gotoAppShell(page);
|
||||
const row = workspaceRow(page);
|
||||
await expect(row).toBeVisible();
|
||||
await toggleTrailing(page, "Diff stats");
|
||||
await page.mouse.move(0, 0);
|
||||
await expect(row.getByText("+12.3k", { exact: true })).toBeVisible();
|
||||
return titleWidth(row);
|
||||
|
||||
@@ -27,6 +27,8 @@ import {
|
||||
expectPinnedUsage,
|
||||
pinRow,
|
||||
openUsageOptions,
|
||||
closeUsageOptions,
|
||||
expectUsageOptionsFitContent,
|
||||
showUsageAs,
|
||||
refreshAllUsage,
|
||||
togglePin,
|
||||
@@ -243,7 +245,7 @@ test.describe("usage screen", () => {
|
||||
page.getByTestId(`usage-host-${serverId}`).getByText(/^Update .+ to see usage$/),
|
||||
).toBeVisible({ timeout: 10_000 });
|
||||
await qaScreenshot(page, "phase7-usage-update-host");
|
||||
await expect(page.getByTestId("usage-options-toggle")).toHaveCount(0);
|
||||
await expect(page.getByTestId("usage-options-menu")).toHaveCount(0);
|
||||
await expect(page.getByTestId("usage-refresh-all")).toHaveCount(0);
|
||||
expect(usage.listRequests()).toHaveLength(0);
|
||||
});
|
||||
@@ -426,7 +428,7 @@ for (const theme of ["light", "dark"] as const) {
|
||||
desktop: { width: 1440, height: 900 },
|
||||
compact: { width: 390, height: 844 },
|
||||
})) {
|
||||
test(`inline Usage Settings ${size} ${theme}`, async ({ page }, testInfo) => {
|
||||
test(`Usage Settings cog ${size} ${theme}`, async ({ page }, testInfo) => {
|
||||
test.setTimeout(120_000);
|
||||
await page.addInitScript((value) => {
|
||||
const key = "@paseo:app-settings";
|
||||
@@ -440,42 +442,24 @@ for (const theme of ["light", "dark"] as const) {
|
||||
await page.goto("/usage");
|
||||
const screen = page.getByTestId(`usage-host-${getServerId()}`);
|
||||
await expect(screen.getByText("Claude", { exact: true })).toBeVisible({ timeout: 30_000 });
|
||||
const settings = screen.getByRole("button", { name: "Settings", exact: true });
|
||||
const chevron = settings.locator("svg").locator("../..");
|
||||
const settings = page.getByTestId("usage-options-menu");
|
||||
await expect(settings).toHaveAccessibleName("Settings");
|
||||
await expect(settings).toHaveAttribute("aria-expanded", "false");
|
||||
await expect(chevron).toHaveCSS("transform", "none");
|
||||
await expect(screen.getByTestId("usage-display-used")).toHaveCount(0);
|
||||
await expect(
|
||||
pinRow(screen, "Claude", "Weekly").getByTestId("usage-pin-glyph-pinned"),
|
||||
).toHaveCSS("opacity", "1");
|
||||
await captureSettingsState(page, testInfo, `${size}-${theme}-collapsed`);
|
||||
await expect(page.getByTestId("usage-display-used")).toHaveCount(0);
|
||||
await captureSettingsState(page, testInfo, `${size}-${theme}-cog`);
|
||||
|
||||
await togglePin(screen, "Claude", "Weekly");
|
||||
await page.mouse.move(0, viewport.height - 1);
|
||||
await expect(
|
||||
pinRow(screen, "Claude", "Weekly").getByTestId("usage-pin-glyph-unpinned"),
|
||||
).toHaveCSS("opacity", "1");
|
||||
await openUsageOptions(page);
|
||||
await expect(settings).toHaveAttribute("aria-expanded", "true");
|
||||
await expect(chevron).toHaveCSS("transform", "matrix(0, 1, -1, 0, 0, 0)");
|
||||
await expect(screen.getByText("Pinned windows show in the sidebar footer")).toBeVisible();
|
||||
await expect(screen.getByTestId("usage-display-used")).toHaveAttribute(
|
||||
"aria-selected",
|
||||
"true",
|
||||
);
|
||||
await settings.blur();
|
||||
await page.mouse.move(0, viewport.height - 1);
|
||||
await captureSettingsState(page, testInfo, `${size}-${theme}-expanded`);
|
||||
await expectUsageOptionsFitContent(page);
|
||||
await expect(page.getByText("Pinned windows show in the sidebar footer")).toBeVisible();
|
||||
await expect(page.getByTestId("usage-display-used")).toHaveAttribute("aria-selected", "true");
|
||||
await captureSettingsState(page, testInfo, `${size}-${theme}-settings`);
|
||||
await showUsageAs(page, "remaining");
|
||||
await expect(screen.getByText("69% left")).toBeVisible();
|
||||
await showUsageAs(page, "used");
|
||||
await expect(pinRow(screen, "Claude", "Session")).toHaveAccessibleName(
|
||||
/^Pin Claude Session, 31% · resets /,
|
||||
);
|
||||
await settings.click();
|
||||
await expect(settings).toHaveAttribute("aria-expanded", "false");
|
||||
await expect(screen.getByTestId("usage-display-used")).toHaveCount(0);
|
||||
await openUsageOptions(page);
|
||||
await closeUsageOptions(page);
|
||||
await refreshAllUsage(page);
|
||||
await expect.poll(() => forcedRefreshes(usage)).toEqual([{ forceRefresh: true }]);
|
||||
});
|
||||
|
||||
@@ -95,8 +95,8 @@ test.describe("usage settings", () => {
|
||||
await expect(card.getByText("2026-12-31", { exact: true })).toBeVisible();
|
||||
await expect(card.getByText("Gamma auth expired", { exact: true })).toBeVisible();
|
||||
|
||||
// Percentages now live on the Usage screen, and still apply to the host section.
|
||||
await expect(card.getByTestId("usage-options-toggle")).toHaveCount(0);
|
||||
// The shared percentages setting applies to the host section.
|
||||
await expect(page.getByTestId("usage-options-menu")).toBeVisible();
|
||||
const hostUsageUrl = page.url();
|
||||
await page.goto("/usage");
|
||||
await showUsageAs(page, "remaining");
|
||||
|
||||
@@ -14,6 +14,9 @@ import {
|
||||
import { installUsageReportsFixture } from "../support/helpers/usage-reports";
|
||||
import {
|
||||
claudeAndCodexReports,
|
||||
closeUsageSheet,
|
||||
closeUsageOptions,
|
||||
openUsageSheetFromIcon,
|
||||
expectNoUsageItem,
|
||||
expectOnUsageScreen,
|
||||
expectPinnedUsage,
|
||||
@@ -62,6 +65,33 @@ async function footerClip(page: Page) {
|
||||
}
|
||||
|
||||
test.describe("Usage item", () => {
|
||||
test("both compact footer entry points open Usage as a sheet", async ({ page }) => {
|
||||
await page.setViewportSize(COMPACT);
|
||||
await installUsageReportsFixture(page, { lists: [() => claudeAndCodexReports()] });
|
||||
await seedSidebarFooterPreferences(page, [{ key: "usage", visible: false }]);
|
||||
await gotoAppShell(page);
|
||||
await openCompactSidebar(page);
|
||||
const startingUrl = page.url();
|
||||
await expectNoUsageItem(page);
|
||||
|
||||
await test.step("the icon opens a sheet without leaving the current screen", async () => {
|
||||
await openUsageSheetFromIcon(page);
|
||||
await expect(usageSheet(page).getByText("Claude", { exact: true })).toBeVisible();
|
||||
await expect(page).toHaveURL(startingUrl);
|
||||
await qaScreenshot(page, "compact-usage-icon-sheet");
|
||||
await setSummaryInSidebar(page, true);
|
||||
await expectPinnedUsage(page, ["31% 5h", "54% wk", "7% 5h", "12% wk"]);
|
||||
await closeUsageSheet(page);
|
||||
});
|
||||
|
||||
await test.step("the summary opens the same sheet", async () => {
|
||||
await usageItem(page).click();
|
||||
await expect(usageSheet(page).getByText("Codex", { exact: true })).toBeVisible();
|
||||
await expect(page).toHaveURL(startingUrl);
|
||||
await qaScreenshot(page, "compact-usage-summary-sheet");
|
||||
await closeUsageSheet(page);
|
||||
});
|
||||
});
|
||||
test("long usage reports stay in an 80% sheet and scroll to the final window", async ({
|
||||
page,
|
||||
}) => {
|
||||
@@ -189,25 +219,22 @@ test.describe("Usage item", () => {
|
||||
await expect(pinRow(sheet, "Claude", "Session")).toHaveAccessibleName(
|
||||
/^Pin Claude Session, \d+% left( · .+)?$/,
|
||||
);
|
||||
// The sheet carries the same inline Settings row and title-row Refresh all.
|
||||
await expect(sheet.getByTestId("usage-options-toggle")).toHaveAttribute(
|
||||
"aria-expanded",
|
||||
"false",
|
||||
);
|
||||
// Settings opens a second sheet; closing it restores the Usage sheet underneath.
|
||||
await expect(page.locator('[data-testid="usage-options-menu"]:visible')).toBeVisible();
|
||||
await expect(page.locator('[data-testid="usage-refresh-all"]:visible')).toBeVisible();
|
||||
await openUsageOptions(page);
|
||||
await expect(sheet.getByTestId("usage-display-remaining")).toHaveAttribute(
|
||||
await expect(page.getByTestId("usage-display-remaining")).toHaveAttribute(
|
||||
"aria-selected",
|
||||
"true",
|
||||
);
|
||||
await qaScreenshot(page, "compact-settings-expanded");
|
||||
await sheet.getByTestId("usage-options-toggle").click();
|
||||
await closeUsageOptions(page);
|
||||
await expect(sheet.getByTestId("usage-display-used")).toHaveCount(0);
|
||||
await expect(sheet).toBeVisible();
|
||||
await expect(page).not.toHaveURL(/\/usage$/);
|
||||
await waitForSettledPosition(sheet);
|
||||
const sheetBox = (await sheet.boundingBox())!;
|
||||
// Settings adds a row; the sheet still reserves the top 20% as its backdrop.
|
||||
// The Usage sheet reserves the top 20% as its backdrop.
|
||||
expect(sheetBox.y).toBeGreaterThanOrEqual(COMPACT.height * 0.2);
|
||||
expect(sheetBox.width).toBeGreaterThan(COMPACT.width * 0.8);
|
||||
await qaScreenshot(page, "compact-sheet");
|
||||
@@ -229,7 +256,7 @@ test.describe("Usage item", () => {
|
||||
"true",
|
||||
);
|
||||
await qaScreenshot(page, "usage-settings-expanded");
|
||||
await page.getByTestId("usage-options-toggle").click();
|
||||
await closeUsageOptions(page);
|
||||
});
|
||||
|
||||
await test.step("the Settings usage section shares the pins and the toggle", async () => {
|
||||
|
||||
@@ -203,6 +203,41 @@ test.describe("Workspace setup streaming", () => {
|
||||
}
|
||||
});
|
||||
|
||||
test("keeps a workspace usable when its setup config cannot be parsed", async ({ page }) => {
|
||||
const client = await connectWorkspaceSetupClient();
|
||||
const repo = await createTempGitRepo("setup-invalid-config-", {
|
||||
files: [{ path: "paseo.json", content: "{ invalid json\n" }],
|
||||
});
|
||||
|
||||
try {
|
||||
await seedProjectForWorkspaceSetup(client, repo.path);
|
||||
const failed = waitForWorkspaceSetupProgress(
|
||||
client,
|
||||
(payload) => payload.status === "failed",
|
||||
);
|
||||
const workspace = await createWorkspaceThroughDaemon(client, {
|
||||
cwd: repo.path,
|
||||
worktreeSlug: "workspace-setup-invalid-config",
|
||||
});
|
||||
const failedPayload = await failed;
|
||||
expect(failedPayload.error).toContain("Failed to parse paseo.json");
|
||||
expect(failedPayload.detail.commands).toEqual([]);
|
||||
|
||||
await openHomeWithProject(page, repo.path);
|
||||
await navigateToWorkspaceViaSidebar(page, workspace.id);
|
||||
await expectFailedSetupTabSeededInMainPane(page, workspace.id);
|
||||
await expect(page.getByText(/Failed to parse paseo\.json at/)).toBeVisible();
|
||||
await closeSetupTab(page, workspace.id);
|
||||
await clickNewChat(page);
|
||||
await expectComposerVisible(page);
|
||||
await openFileExplorer(page);
|
||||
await expectExplorerEntryVisible(page, "paseo.json");
|
||||
} finally {
|
||||
await client.close();
|
||||
await repo.cleanup();
|
||||
}
|
||||
});
|
||||
|
||||
daemonTest("emits a completed empty snapshot when no setup commands exist", async () => {
|
||||
const client = await connectWorkspaceSetupClient();
|
||||
const repo = await createTempGitRepo("setup-none-");
|
||||
|
||||
@@ -0,0 +1,4 @@
|
||||
appId: sh.paseo.debug
|
||||
---
|
||||
- launchApp
|
||||
- runFlow: ../../../maestro/sidebar-scroll-retention.yaml
|
||||
@@ -52,6 +52,10 @@ export async function expectComposerFocused(page: Page): Promise<void> {
|
||||
await expect(composerInput(page)).toBeFocused();
|
||||
}
|
||||
|
||||
export async function expectComposerNotFocused(page: Page): Promise<void> {
|
||||
await expect(composerInput(page)).not.toBeFocused();
|
||||
}
|
||||
|
||||
export async function submitMessage(page: Page, text: string): Promise<void> {
|
||||
const input = composerInput(page);
|
||||
await expect(input).toBeEditable({ timeout: 30_000 });
|
||||
@@ -59,6 +63,12 @@ export async function submitMessage(page: Page, text: string): Promise<void> {
|
||||
await input.press("Enter");
|
||||
}
|
||||
|
||||
/** The Send button works on compact screens, where Enter inserts a newline. */
|
||||
export async function submitMessageWithButton(page: Page, text: string): Promise<void> {
|
||||
await fillComposerDraft(page, text);
|
||||
await page.getByRole("button", { name: "Send message", exact: true }).click();
|
||||
}
|
||||
|
||||
export async function fillComposerDraft(page: Page, text: string): Promise<void> {
|
||||
await composerInput(page).fill(text);
|
||||
}
|
||||
|
||||
@@ -26,38 +26,50 @@ export async function openAgent(page: Page, session: MockAgentSession): Promise<
|
||||
}
|
||||
|
||||
export async function reloadAgent(page: Page): Promise<void> {
|
||||
await page.reload({ waitUntil: "commit" });
|
||||
// Reload must not reopen the card under a stationary pointer.
|
||||
await page.mouse.move(0, 0);
|
||||
await page.reload({ waitUntil: "domcontentloaded" });
|
||||
await expectComposerVisible(page);
|
||||
}
|
||||
|
||||
/** Wide screens show the meter's details in a tooltip while the pointer is on it. */
|
||||
export async function hoverContextWindowMeter(page: Page): Promise<Locator> {
|
||||
await page.getByRole("img", { name: METER_NAME }).hover({ timeout: 30_000 });
|
||||
const tooltip = page.getByRole("tooltip").filter({ hasText: "Context window" });
|
||||
await expect(tooltip).toBeVisible();
|
||||
return tooltip;
|
||||
/** Wide screens show the meter's details in a hover card while the pointer is on it. */
|
||||
export async function hoverContextWindowMeter(page: Page, name = METER_NAME): Promise<Locator> {
|
||||
await page.getByRole("img", { name, exact: true }).hover({ timeout: 30_000 });
|
||||
const card = contextWindowDetails(page);
|
||||
await expect(card).toBeVisible();
|
||||
await expect(card).toBeInViewport();
|
||||
return card;
|
||||
}
|
||||
|
||||
/** Walks the pointer from the meter up onto its hover card, across the gap between them. */
|
||||
export async function moveOntoContextWindowDetails(page: Page, card: Locator): Promise<void> {
|
||||
const meter = await page.getByRole("img", { name: METER_NAME }).boundingBox();
|
||||
const box = await card.boundingBox();
|
||||
if (!meter || !box) throw new Error("The meter and its hover card must be on screen.");
|
||||
await page.mouse.move(meter.x + meter.width / 2, box.y + box.height / 2, { steps: 20 });
|
||||
}
|
||||
|
||||
export async function leaveContextWindowMeter(page: Page): Promise<void> {
|
||||
await page.mouse.move(0, 0);
|
||||
await expect(page.getByRole("tooltip").filter({ hasText: "Context window" })).toHaveCount(0);
|
||||
await expect(contextWindowDetails(page)).toHaveCount(0);
|
||||
}
|
||||
|
||||
/** Compact screens open the meter's details in a sheet. */
|
||||
export async function pressContextWindowMeter(page: Page): Promise<Locator> {
|
||||
await page.getByRole("button", { name: METER_NAME }).click({ timeout: 30_000 });
|
||||
const sheet = contextWindowSheet(page);
|
||||
export async function pressContextWindowMeter(page: Page, name = METER_NAME): Promise<Locator> {
|
||||
await page.getByRole("button", { name, exact: true }).click({ timeout: 30_000 });
|
||||
const sheet = contextWindowDetails(page);
|
||||
await expect(sheet).toBeVisible();
|
||||
return sheet;
|
||||
}
|
||||
|
||||
export async function closeContextWindowSheet(page: Page): Promise<void> {
|
||||
const sheet = contextWindowSheet(page);
|
||||
const sheet = contextWindowDetails(page);
|
||||
await sheet.getByRole("button", { name: "Close", exact: true }).click();
|
||||
await expect(sheet).toHaveCount(0);
|
||||
}
|
||||
|
||||
export function contextWindowSheet(page: Page): Locator {
|
||||
/** The hover card on wide screens and the sheet on compact ones are both this dialog. */
|
||||
export function contextWindowDetails(page: Page): Locator {
|
||||
return page.getByRole("dialog", { name: "Context window" });
|
||||
}
|
||||
|
||||
@@ -159,7 +171,7 @@ export async function scriptAgentUsage(page: Page): Promise<AgentUsageScript> {
|
||||
export async function qaScreenshot(page: Page, name: string): Promise<void> {
|
||||
const directory = process.env.PASEO_QA_SCREENSHOT_DIR;
|
||||
if (!directory) return;
|
||||
// Let the sheet and tooltip animations settle.
|
||||
// Let the sheet and hover card animations settle.
|
||||
await page.waitForTimeout(600);
|
||||
await page.addStyleTag({ content: ".__expo_fast_refresh { display: none !important; }" });
|
||||
await page.screenshot({ path: path.join(directory, `${name}.png`) });
|
||||
|
||||
@@ -6,6 +6,7 @@ import type { UsageReportEntry } from "@getpaseo/protocol/messages";
|
||||
import { expect, type Locator, type Page } from "@playwright/test";
|
||||
import { connectNewWorkspaceDaemonClient } from "./new-workspace";
|
||||
import { pluginRequirements } from "./plugin-fixture";
|
||||
import { waitForSettledPosition } from "./sheet-layout";
|
||||
|
||||
/** Real usage-source plugin; its long report exercises the sheet's scrolling boundary. */
|
||||
export async function installTallUsageSource() {
|
||||
@@ -194,6 +195,21 @@ export async function openUsageScreenFromIcon(page: Page): Promise<void> {
|
||||
await expectOnUsageScreen(page);
|
||||
}
|
||||
|
||||
/** Both footer entry points open Usage over the current screen on a phone. */
|
||||
export async function openUsageSheetFromIcon(page: Page): Promise<void> {
|
||||
await page.getByRole("button", { name: "Usage", exact: true }).click();
|
||||
await expect(usageSheet(page)).toBeVisible();
|
||||
}
|
||||
|
||||
export async function closeUsageSheet(page: Page): Promise<void> {
|
||||
const sheet = usageSheet(page);
|
||||
await waitForSettledPosition(sheet);
|
||||
const bounds = await sheet.boundingBox();
|
||||
if (!bounds) throw new Error("Usage sheet must be visible before closing it.");
|
||||
await page.mouse.click(bounds.x + bounds.width / 2, bounds.y / 2);
|
||||
await expect(sheet).toHaveCount(0);
|
||||
}
|
||||
|
||||
function summaryInSidebarSwitch(page: Page): Locator {
|
||||
return page.getByRole("switch", { name: "Summary in sidebar", exact: true });
|
||||
}
|
||||
@@ -208,15 +224,39 @@ export async function setSummaryInSidebar(page: Page, on: boolean): Promise<void
|
||||
export async function expectSummaryInSidebar(page: Page, on: boolean): Promise<void> {
|
||||
await openUsageOptions(page);
|
||||
await expect(summaryInSidebarSwitch(page)).toBeChecked({ checked: on });
|
||||
await closeUsageOptions(page);
|
||||
}
|
||||
|
||||
/** Expand the inline Settings row when its controls are folded. */
|
||||
/** Open the cog's settings popover or compact sheet. */
|
||||
export async function openUsageOptions(page: Page): Promise<void> {
|
||||
const toggle = visible(page, "usage-options-toggle");
|
||||
if ((await toggle.getAttribute("aria-expanded")) === "false") await toggle.click();
|
||||
if (!(await visible(page, "usage-display-used").isVisible())) {
|
||||
await visible(page, "usage-options-menu").click();
|
||||
}
|
||||
await expect(visible(page, "usage-display-used")).toBeVisible();
|
||||
}
|
||||
|
||||
export function usageOptionsSurface(page: Page): Locator {
|
||||
return page
|
||||
.locator(
|
||||
'[data-testid="usage-options-surface"]:visible, [data-testid="usage-options-surface-content"]:visible',
|
||||
)
|
||||
.first();
|
||||
}
|
||||
|
||||
export async function expectUsageOptionsFitContent(page: Page): Promise<void> {
|
||||
await waitForSettledPosition(usageOptionsSurface(page));
|
||||
const surface = await usageOptionsSurface(page).boundingBox();
|
||||
const fields = await page.getByTestId("usage-options-fields").boundingBox();
|
||||
if (!surface || !fields) throw new Error("Settings must be visible before measuring its fit.");
|
||||
expect(surface.y + surface.height - (fields.y + fields.height)).toBeLessThanOrEqual(10);
|
||||
}
|
||||
|
||||
export async function closeUsageOptions(page: Page): Promise<void> {
|
||||
await waitForSettledPosition(usageOptionsSurface(page));
|
||||
await page.mouse.click(0, 0);
|
||||
await expect(page.getByTestId("usage-display-used")).toHaveCount(0);
|
||||
}
|
||||
|
||||
export async function showUsageAs(page: Page, displayAs: "used" | "remaining") {
|
||||
await openUsageOptions(page);
|
||||
await visible(page, `usage-display-${displayAs}`).click();
|
||||
@@ -224,6 +264,7 @@ export async function showUsageAs(page: Page, displayAs: "used" | "remaining") {
|
||||
"aria-selected",
|
||||
"true",
|
||||
);
|
||||
await closeUsageOptions(page);
|
||||
}
|
||||
|
||||
export async function refreshAllUsage(page: Page): Promise<void> {
|
||||
|
||||
@@ -0,0 +1,53 @@
|
||||
appId: sh.paseo.debug
|
||||
---
|
||||
# Start in a workspace with the sidebar closed. Both workspace IDs come from
|
||||
# the connected host: TOP_WORKSPACE is near the top; SCROLLED_WORKSPACE starts
|
||||
# below the viewport. The list must remain unchanged throughout the flow.
|
||||
- tapOn:
|
||||
id: menu-button
|
||||
- scrollUntilVisible:
|
||||
element:
|
||||
id: sidebar-workspace-row-${TOP_WORKSPACE}
|
||||
direction: UP
|
||||
timeout: 60000
|
||||
- assertNotVisible:
|
||||
id: sidebar-workspace-row-${SCROLLED_WORKSPACE}
|
||||
- scrollUntilVisible:
|
||||
element:
|
||||
id: sidebar-workspace-row-${SCROLLED_WORKSPACE}
|
||||
direction: DOWN
|
||||
timeout: 60000
|
||||
- waitForAnimationToEnd
|
||||
- assertVisible:
|
||||
id: sidebar-workspace-row-${SCROLLED_WORKSPACE}
|
||||
- assertNotVisible:
|
||||
id: sidebar-workspace-row-${TOP_WORKSPACE}
|
||||
- tapOn:
|
||||
id: sidebar-workspace-row-${SCROLLED_WORKSPACE}
|
||||
- waitForAnimationToEnd
|
||||
- assertNotVisible:
|
||||
id: sidebar-project-workspace-list-scroll
|
||||
- swipe:
|
||||
start: "5%,50%"
|
||||
end: "90%,50%"
|
||||
duration: 300
|
||||
- waitForAnimationToEnd
|
||||
- assertVisible:
|
||||
id: sidebar-workspace-row-${SCROLLED_WORKSPACE}
|
||||
- assertNotVisible:
|
||||
id: sidebar-workspace-row-${TOP_WORKSPACE}
|
||||
|
||||
# Selecting the current workspace removes workspace switching as a cause.
|
||||
# Reopening by button removes horizontal movement as a cause.
|
||||
- tapOn:
|
||||
id: sidebar-workspace-row-${SCROLLED_WORKSPACE}
|
||||
- waitForAnimationToEnd
|
||||
- tapOn:
|
||||
id: menu-button
|
||||
- waitForAnimationToEnd
|
||||
- assertVisible:
|
||||
id: sidebar-workspace-row-${SCROLLED_WORKSPACE}
|
||||
- assertNotVisible:
|
||||
id: sidebar-workspace-row-${TOP_WORKSPACE}
|
||||
- tapOn:
|
||||
id: sidebar-close
|
||||
@@ -59,7 +59,7 @@ export function useFileLink(source: AssistantFileLinkSource): UseFileLinkResult
|
||||
? assistantFileLinkQueryKey({
|
||||
serverId,
|
||||
workspaceRoot,
|
||||
ambiguousQuery: resolution.ambiguousQuery,
|
||||
token: resolution.token,
|
||||
})
|
||||
: DISABLED_QUERY_KEY,
|
||||
[resolution, serverId, workspaceRoot],
|
||||
@@ -179,7 +179,7 @@ function openAssistantFileLink(input: {
|
||||
const capturedQueryKey = assistantFileLinkQueryKey({
|
||||
serverId: capturedConfig.serverId,
|
||||
workspaceRoot: capturedConfig.workspaceRoot,
|
||||
ambiguousQuery: capturedResolution.ambiguousQuery,
|
||||
token: capturedResolution.token,
|
||||
});
|
||||
|
||||
const run = async () => {
|
||||
@@ -245,14 +245,9 @@ function useStableSource(source: AssistantFileLinkSource): AssistantFileLinkSour
|
||||
function assistantFileLinkQueryKey(input: {
|
||||
serverId?: string;
|
||||
workspaceRoot?: string;
|
||||
ambiguousQuery: string;
|
||||
token: string;
|
||||
}): AssistantFileLinkQueryKey {
|
||||
return [
|
||||
"assistantFileLink",
|
||||
input.serverId ?? null,
|
||||
input.workspaceRoot ?? null,
|
||||
input.ambiguousQuery,
|
||||
];
|
||||
return ["assistantFileLink", input.serverId ?? null, input.workspaceRoot ?? null, input.token];
|
||||
}
|
||||
|
||||
async function dispatchResolvedLink(input: {
|
||||
|
||||
@@ -7,26 +7,26 @@ import { formatTokenCount } from "./context-window-meter.utils";
|
||||
interface ContextWindowDetailsProps {
|
||||
serverId: string;
|
||||
agentId: string;
|
||||
percentage: number;
|
||||
usedTokens: number;
|
||||
maxTokens: number;
|
||||
context: {
|
||||
percentage: number;
|
||||
usedTokens: number;
|
||||
maxTokens: number;
|
||||
} | null;
|
||||
sessionCost: string | null;
|
||||
/** The tooltip titles itself; the sheet's header carries the title instead. */
|
||||
/** The hover card and tooltip title themselves; the sheet's header carries the title instead. */
|
||||
showTitle: boolean;
|
||||
/** Only the sheet can be pressed, so only its usage cards have a Refresh button. */
|
||||
/** Whether the usage cards have a Refresh button; without one they show their freshness. */
|
||||
refreshable: boolean;
|
||||
}
|
||||
|
||||
/**
|
||||
* What the context window meter opens: how full the window is, then the usage of the agent's
|
||||
* account. The wide tooltip and the compact sheet both render it.
|
||||
* account. The desktop hover card, the native wide tooltip, and the compact sheet all render it.
|
||||
*/
|
||||
export function ContextWindowDetails({
|
||||
serverId,
|
||||
agentId,
|
||||
percentage,
|
||||
usedTokens,
|
||||
maxTokens,
|
||||
context,
|
||||
sessionCost,
|
||||
showTitle,
|
||||
refreshable,
|
||||
@@ -36,13 +36,21 @@ export function ContextWindowDetails({
|
||||
<>
|
||||
<View style={styles.summary}>
|
||||
{showTitle ? <Text style={styles.title}>{t("contextWindow.title")}</Text> : null}
|
||||
<Text style={styles.text}>{t("contextWindow.used", { percentage })}</Text>
|
||||
<Text style={styles.detail}>
|
||||
{t("contextWindow.tokens", {
|
||||
used: formatTokenCount(usedTokens),
|
||||
max: formatTokenCount(maxTokens),
|
||||
})}
|
||||
</Text>
|
||||
{context ? (
|
||||
<>
|
||||
<Text style={styles.text}>
|
||||
{t("contextWindow.used", { percentage: context.percentage })}
|
||||
</Text>
|
||||
<Text style={styles.detail}>
|
||||
{t("contextWindow.tokens", {
|
||||
used: formatTokenCount(context.usedTokens),
|
||||
max: formatTokenCount(context.maxTokens),
|
||||
})}
|
||||
</Text>
|
||||
</>
|
||||
) : (
|
||||
<Text style={styles.detail}>{t("contextWindow.noData")}</Text>
|
||||
)}
|
||||
{sessionCost ? (
|
||||
<Text style={styles.detail}>{t("contextWindow.sessionCost", { cost: sessionCost })}</Text>
|
||||
) : null}
|
||||
|
||||
@@ -1,11 +1,14 @@
|
||||
import { useCallback, useState } from "react";
|
||||
import { useCallback, useMemo, useState } from "react";
|
||||
import { Pressable, Text, View, useWindowDimensions } from "react-native";
|
||||
import Svg, { Circle } from "react-native-svg";
|
||||
import { StyleSheet, useUnistyles } from "react-native-unistyles";
|
||||
import { StyleSheet, withUnistyles } from "react-native-unistyles";
|
||||
import { useTranslation } from "react-i18next";
|
||||
import { HoverCard, HoverCardContent, HoverCardTrigger } from "@/components/ui/hover-card";
|
||||
import { Tooltip, TooltipContent, TooltipTrigger } from "@/components/ui/tooltip";
|
||||
import { useIsCompactFormFactor } from "@/constants/layout";
|
||||
import { isNative } from "@/constants/platform";
|
||||
import { useHostReportsUsage } from "@/usage";
|
||||
import type { Theme } from "@/styles/theme";
|
||||
import { ContextWindowDetails } from "./context-window-details";
|
||||
import { ContextWindowSheet } from "./context-window-sheet";
|
||||
|
||||
@@ -16,19 +19,16 @@ interface ContextWindowMeterProps {
|
||||
usedTokens: number | null;
|
||||
totalCostUsd?: number | null;
|
||||
showPercentage?: boolean;
|
||||
/** Reserve the meter footprint and show a loading ring while usage is pending. */
|
||||
pending?: boolean;
|
||||
/** Optional glyph envelope for icon-toolbar alignment. */
|
||||
glyphSize?: number;
|
||||
}
|
||||
|
||||
const SVG_SIZE = 14;
|
||||
const USAGE_POPOVER_WIDTH = 300;
|
||||
const COMPACT_SVG_SIZE = 12;
|
||||
const COMPACT_CENTER = COMPACT_SVG_SIZE / 2;
|
||||
const COMPACT_RADIUS = 5;
|
||||
const STROKE_WIDTH = 2;
|
||||
const COMPACT_STROKE_WIDTH = 1.75;
|
||||
const COMPACT_CIRCUMFERENCE = 2 * Math.PI * COMPACT_RADIUS;
|
||||
|
||||
function isValidMaxTokens(value: number): boolean {
|
||||
return Number.isFinite(value) && value > 0;
|
||||
@@ -59,28 +59,22 @@ function formatSessionCost(value: number): string | null {
|
||||
return `$${value.toFixed(2)}`;
|
||||
}
|
||||
|
||||
function getMeterColors(
|
||||
percentage: number,
|
||||
theme: ReturnType<typeof useUnistyles>["theme"],
|
||||
): { progress: string; track: string } {
|
||||
const track = theme.colors.surface3;
|
||||
function getProgressColor(percentage: number, theme: Theme): string {
|
||||
if (percentage > 90) {
|
||||
return { progress: theme.colors.destructive, track };
|
||||
return theme.colors.destructive;
|
||||
}
|
||||
if (percentage >= 70) {
|
||||
return { progress: theme.colors.palette.amber[500], track };
|
||||
return theme.colors.palette.amber[500];
|
||||
}
|
||||
return { progress: theme.colors.foregroundMuted, track };
|
||||
return theme.colors.foregroundMuted;
|
||||
}
|
||||
|
||||
function getMeterGeometry(showPercentage: boolean, glyphSize?: number) {
|
||||
if (showPercentage) {
|
||||
return {
|
||||
svgSize: COMPACT_SVG_SIZE,
|
||||
center: COMPACT_CENTER,
|
||||
radius: COMPACT_RADIUS,
|
||||
strokeWidth: COMPACT_STROKE_WIDTH,
|
||||
circumference: COMPACT_CIRCUMFERENCE,
|
||||
containerStyle: styles.containerWithLabel,
|
||||
};
|
||||
}
|
||||
@@ -88,14 +82,65 @@ function getMeterGeometry(showPercentage: boolean, glyphSize?: number) {
|
||||
const resolvedStrokeWidth = glyphSize ? 2 : STROKE_WIDTH;
|
||||
return {
|
||||
svgSize: resolvedSize,
|
||||
center: resolvedSize / 2,
|
||||
radius: (resolvedSize - resolvedStrokeWidth) / 2,
|
||||
strokeWidth: resolvedStrokeWidth,
|
||||
circumference: Math.PI * (resolvedSize - resolvedStrokeWidth),
|
||||
containerStyle: styles.container,
|
||||
};
|
||||
}
|
||||
|
||||
// Wrap the whole SVG: withUnistyles adds a div on web, which cannot sit inside an SVG.
|
||||
const ContextWindowRing = withUnistyles(function ContextWindowRing({
|
||||
size,
|
||||
radius,
|
||||
strokeWidth,
|
||||
percentage,
|
||||
trackColor,
|
||||
progressColor,
|
||||
}: {
|
||||
size: number;
|
||||
radius: number;
|
||||
strokeWidth: number;
|
||||
percentage: number | null;
|
||||
trackColor: string;
|
||||
progressColor: string;
|
||||
}) {
|
||||
const center = size / 2;
|
||||
const circumference = 2 * Math.PI * radius;
|
||||
return (
|
||||
<Svg
|
||||
width={size}
|
||||
height={size}
|
||||
viewBox={`0 0 ${size} ${size}`}
|
||||
accessibilityElementsHidden
|
||||
importantForAccessibility="no-hide-descendants"
|
||||
>
|
||||
<Circle
|
||||
cx={center}
|
||||
cy={center}
|
||||
r={radius}
|
||||
fill="none"
|
||||
stroke={trackColor}
|
||||
strokeWidth={strokeWidth}
|
||||
/>
|
||||
{percentage !== null ? (
|
||||
<Circle
|
||||
cx={center}
|
||||
cy={center}
|
||||
r={radius}
|
||||
fill="none"
|
||||
stroke={progressColor}
|
||||
strokeWidth={strokeWidth}
|
||||
strokeLinecap="round"
|
||||
strokeDasharray={circumference}
|
||||
strokeDashoffset={circumference - (clampPercentage(percentage) / 100) * circumference}
|
||||
// SVG strokes start at three o'clock; the ring reads clockwise from twelve.
|
||||
transform={`rotate(-90 ${center} ${center})`}
|
||||
/>
|
||||
) : null}
|
||||
</Svg>
|
||||
);
|
||||
});
|
||||
|
||||
export function ContextWindowMeter({
|
||||
serverId,
|
||||
agentId,
|
||||
@@ -103,15 +148,13 @@ export function ContextWindowMeter({
|
||||
usedTokens,
|
||||
totalCostUsd,
|
||||
showPercentage = false,
|
||||
pending = false,
|
||||
glyphSize,
|
||||
}: ContextWindowMeterProps) {
|
||||
const { theme } = useUnistyles();
|
||||
const { t } = useTranslation();
|
||||
const { width } = useWindowDimensions();
|
||||
// Usage cards need a wider popover; without them it keeps the plain tooltip shape.
|
||||
const showsUsage = useHostReportsUsage(serverId);
|
||||
const popoverWidth = Math.min(360, width - 24);
|
||||
const popoverWidth = Math.min(USAGE_POPOVER_WIDTH, width - 24);
|
||||
// Compact screens open the details in a sheet, which can hold a pressable Refresh.
|
||||
const isCompact = useIsCompactFormFactor();
|
||||
const [isSheetOpen, setIsSheetOpen] = useState(false);
|
||||
@@ -121,79 +164,39 @@ export function ContextWindowMeter({
|
||||
maxTokens !== null && usedTokens !== null ? getUsagePercentage(maxTokens, usedTokens) : null;
|
||||
const geometry = getMeterGeometry(showPercentage, glyphSize);
|
||||
|
||||
// No usage yet: reserve the footprint with a track-only ring while a session is
|
||||
// active so the real ring fades in without shifting siblings. Render nothing when
|
||||
// no usage is expected.
|
||||
if (percentage === null || maxTokens === null || usedTokens === null) {
|
||||
if (!pending) {
|
||||
return null;
|
||||
}
|
||||
return (
|
||||
<View style={geometry.containerStyle}>
|
||||
<Svg
|
||||
width={geometry.svgSize}
|
||||
height={geometry.svgSize}
|
||||
viewBox={`0 0 ${geometry.svgSize} ${geometry.svgSize}`}
|
||||
accessibilityElementsHidden
|
||||
importantForAccessibility="no-hide-descendants"
|
||||
>
|
||||
<Circle
|
||||
cx={geometry.center}
|
||||
cy={geometry.center}
|
||||
r={geometry.radius}
|
||||
fill="none"
|
||||
stroke={theme.colors.surface3}
|
||||
strokeWidth={geometry.strokeWidth}
|
||||
/>
|
||||
</Svg>
|
||||
{showPercentage ? <View style={styles.skeletonLabel} /> : null}
|
||||
</View>
|
||||
);
|
||||
}
|
||||
|
||||
const clampedPercentage = clampPercentage(percentage);
|
||||
const roundedPercentage = Math.round(percentage);
|
||||
const { svgSize, center, radius, strokeWidth, circumference, containerStyle } = geometry;
|
||||
const dashOffset = circumference - (clampedPercentage / 100) * circumference;
|
||||
const colors = getMeterColors(clampedPercentage, theme);
|
||||
const context = useMemo(
|
||||
() =>
|
||||
percentage !== null && maxTokens !== null && usedTokens !== null
|
||||
? { percentage: Math.round(percentage), maxTokens, usedTokens }
|
||||
: null,
|
||||
[percentage, maxTokens, usedTokens],
|
||||
);
|
||||
const meterColors = useCallback(
|
||||
(theme: Theme) => ({
|
||||
progressColor: getProgressColor(percentage ?? 0, theme),
|
||||
trackColor: theme.colors.surface3,
|
||||
}),
|
||||
[percentage],
|
||||
);
|
||||
const formattedSessionCost =
|
||||
typeof totalCostUsd === "number" ? formatSessionCost(totalCostUsd) : null;
|
||||
|
||||
const containerStyle = geometry.containerStyle;
|
||||
const ring = (
|
||||
<Svg
|
||||
width={svgSize}
|
||||
height={svgSize}
|
||||
viewBox={`0 0 ${svgSize} ${svgSize}`}
|
||||
accessibilityElementsHidden
|
||||
importantForAccessibility="no-hide-descendants"
|
||||
>
|
||||
<Circle
|
||||
cx={center}
|
||||
cy={center}
|
||||
r={radius}
|
||||
fill="none"
|
||||
stroke={colors.track}
|
||||
strokeWidth={strokeWidth}
|
||||
/>
|
||||
<Circle
|
||||
cx={center}
|
||||
cy={center}
|
||||
r={radius}
|
||||
fill="none"
|
||||
stroke={colors.progress}
|
||||
strokeWidth={strokeWidth}
|
||||
strokeLinecap="round"
|
||||
strokeDasharray={circumference}
|
||||
strokeDashoffset={dashOffset}
|
||||
// SVG strokes start at three o'clock; the ring reads clockwise from twelve.
|
||||
transform={`rotate(-90 ${center} ${center})`}
|
||||
/>
|
||||
</Svg>
|
||||
<ContextWindowRing
|
||||
size={geometry.svgSize}
|
||||
radius={geometry.radius}
|
||||
strokeWidth={geometry.strokeWidth}
|
||||
percentage={percentage}
|
||||
uniProps={meterColors}
|
||||
/>
|
||||
);
|
||||
const percentageLabel = showPercentage ? (
|
||||
<Text style={styles.percentageLabel}>{`${roundedPercentage}%`}</Text>
|
||||
) : null;
|
||||
const accessibilityLabel = t("contextWindow.accessibility", { percentage: roundedPercentage });
|
||||
const percentageLabel =
|
||||
showPercentage && context ? (
|
||||
<Text style={styles.percentageLabel}>{`${context.percentage}%`}</Text>
|
||||
) : null;
|
||||
const accessibilityLabel = context
|
||||
? t("contextWindow.accessibility", { percentage: context.percentage })
|
||||
: t("contextWindow.accessibilityNoData");
|
||||
|
||||
if (isCompact) {
|
||||
return (
|
||||
@@ -212,9 +215,7 @@ export function ContextWindowMeter({
|
||||
<ContextWindowDetails
|
||||
serverId={serverId}
|
||||
agentId={agentId}
|
||||
percentage={roundedPercentage}
|
||||
usedTokens={usedTokens}
|
||||
maxTokens={maxTokens}
|
||||
context={context}
|
||||
sessionCost={formattedSessionCost}
|
||||
showTitle={false}
|
||||
refreshable
|
||||
@@ -224,10 +225,51 @@ export function ContextWindowMeter({
|
||||
);
|
||||
}
|
||||
|
||||
const popoverStyle = showsUsage
|
||||
? [styles.usagePopover, { width: popoverWidth }]
|
||||
: styles.plainPopover;
|
||||
|
||||
// Native wide screens have no hover, so the details open in a tooltip on press. The tooltip
|
||||
// takes no presses, so its usage cards have no Refresh.
|
||||
if (isNative) {
|
||||
return (
|
||||
<Tooltip delayDuration={0} enabledOnDesktop enabledOnMobile>
|
||||
<TooltipTrigger asChild triggerRefProp="ref">
|
||||
<Pressable
|
||||
style={containerStyle}
|
||||
testID="context-window-meter"
|
||||
accessibilityRole="image"
|
||||
accessibilityLabel={accessibilityLabel}
|
||||
>
|
||||
{ring}
|
||||
{percentageLabel}
|
||||
</Pressable>
|
||||
</TooltipTrigger>
|
||||
<TooltipContent
|
||||
side="top"
|
||||
align="center"
|
||||
offset={8}
|
||||
maxWidth={showsUsage ? popoverWidth : undefined}
|
||||
style={popoverStyle}
|
||||
testID="context-window-meter-tooltip"
|
||||
>
|
||||
<ContextWindowDetails
|
||||
serverId={serverId}
|
||||
agentId={agentId}
|
||||
context={context}
|
||||
sessionCost={formattedSessionCost}
|
||||
showTitle
|
||||
refreshable={false}
|
||||
/>
|
||||
</TooltipContent>
|
||||
</Tooltip>
|
||||
);
|
||||
}
|
||||
|
||||
return (
|
||||
<Tooltip delayDuration={0} enabledOnDesktop enabledOnMobile>
|
||||
<TooltipTrigger asChild triggerRefProp="ref">
|
||||
<Pressable
|
||||
<HoverCard>
|
||||
<HoverCardTrigger focusable accessibilityLabel={accessibilityLabel}>
|
||||
<View
|
||||
style={containerStyle}
|
||||
testID="context-window-meter"
|
||||
accessibilityRole="image"
|
||||
@@ -235,28 +277,26 @@ export function ContextWindowMeter({
|
||||
>
|
||||
{ring}
|
||||
{percentageLabel}
|
||||
</Pressable>
|
||||
</TooltipTrigger>
|
||||
<TooltipContent
|
||||
side="top"
|
||||
align="center"
|
||||
</View>
|
||||
</HoverCardTrigger>
|
||||
<HoverCardContent
|
||||
placement="top"
|
||||
offset={8}
|
||||
maxWidth={showsUsage ? popoverWidth : undefined}
|
||||
style={showsUsage ? [styles.popover, { width: popoverWidth }] : undefined}
|
||||
testID="context-window-meter-tooltip"
|
||||
role="dialog"
|
||||
accessibilityLabel={t("contextWindow.title")}
|
||||
testID="context-window-details"
|
||||
style={popoverStyle}
|
||||
>
|
||||
<ContextWindowDetails
|
||||
serverId={serverId}
|
||||
agentId={agentId}
|
||||
percentage={roundedPercentage}
|
||||
usedTokens={usedTokens}
|
||||
maxTokens={maxTokens}
|
||||
context={context}
|
||||
sessionCost={formattedSessionCost}
|
||||
showTitle
|
||||
refreshable={false}
|
||||
refreshable
|
||||
/>
|
||||
</TooltipContent>
|
||||
</Tooltip>
|
||||
</HoverCardContent>
|
||||
</HoverCard>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -281,11 +321,7 @@ const styles = StyleSheet.create((theme) => ({
|
||||
fontSize: theme.fontSize.base,
|
||||
fontWeight: theme.fontWeight.normal,
|
||||
},
|
||||
skeletonLabel: {
|
||||
width: 22,
|
||||
height: theme.fontSize.base,
|
||||
borderRadius: theme.borderRadius.full,
|
||||
backgroundColor: theme.colors.surface3,
|
||||
},
|
||||
popover: { padding: theme.spacing[4], gap: theme.spacing[4] },
|
||||
// Plain details use a small inset; account usage cards have their own content density.
|
||||
plainPopover: { paddingVertical: theme.spacing[1], paddingHorizontal: theme.spacing[2] },
|
||||
usagePopover: { padding: theme.spacing[3], gap: theme.spacing[3] },
|
||||
}));
|
||||
|
||||
@@ -26,6 +26,7 @@ import { SidebarSeparator } from "@/components/sidebar/sidebar-separator";
|
||||
import { SidebarNavRows } from "@/components/sidebar/sidebar-nav-rows";
|
||||
import { SidebarHelpMenu } from "@/components/sidebar/sidebar-help-menu";
|
||||
import { SidebarResizeHandle } from "@/components/sidebar-resize-handle";
|
||||
import { buttonControlHeight } from "@/components/ui/control-geometry";
|
||||
import { Shortcut } from "@/components/ui/shortcut";
|
||||
import { Tooltip, TooltipContent, TooltipTrigger } from "@/components/ui/tooltip";
|
||||
import { HEADER_INNER_HEIGHT, useIsCompactFormFactor } from "@/constants/layout";
|
||||
@@ -52,7 +53,12 @@ import { useCloseAgentListGesture } from "@/mobile-panels/gestures";
|
||||
import { MobilePanelOverlay } from "@/mobile-panels/presentation";
|
||||
import { buildSettingsAddHostRoute, buildSettingsRoute } from "@/utils/host-routes";
|
||||
import { openHostOverview } from "@/navigation/settings-navigation";
|
||||
import { UsageSidebarItem, useHasUsageSummary, useOpenUsageScreen } from "@/usage";
|
||||
import {
|
||||
UsageSidebarItem,
|
||||
UsageSidebarRoot,
|
||||
useHasUsageSummary,
|
||||
useOpenSidebarUsage,
|
||||
} from "@/usage";
|
||||
import { SidebarAgentListSkeleton } from "./sidebar-agent-list-skeleton";
|
||||
import { SidebarCalloutSlot } from "./sidebar-callout-slot";
|
||||
import { SidebarWorkspaceList } from "./sidebar-workspace-list";
|
||||
@@ -275,7 +281,7 @@ function FooterIconButton({
|
||||
testID,
|
||||
label,
|
||||
icon: Icon,
|
||||
iconSize,
|
||||
iconSizeAdjustment = 0,
|
||||
shortcutKeys,
|
||||
theme,
|
||||
}: {
|
||||
@@ -284,17 +290,20 @@ function FooterIconButton({
|
||||
label: string;
|
||||
icon: typeof FolderPlus;
|
||||
/** Only for a glyph that reads larger than the others at the same size. */
|
||||
iconSize?: number;
|
||||
iconSizeAdjustment?: number;
|
||||
shortcutKeys?: ReturnType<typeof useShortcutKeys>;
|
||||
theme: SidebarTheme;
|
||||
buttonRef?: RefObject<View | null>;
|
||||
}) {
|
||||
const isCompact = useIsCompactFormFactor();
|
||||
const iconSize = isCompact ? theme.iconSize.lg : theme.iconSize.md;
|
||||
|
||||
return (
|
||||
<Tooltip delayDuration={300}>
|
||||
<TooltipTrigger asChild>
|
||||
<Pressable
|
||||
ref={buttonRef}
|
||||
style={styles.footerIconButton}
|
||||
style={styles.footerIconButton(isCompact)}
|
||||
testID={testID}
|
||||
nativeID={testID}
|
||||
collapsable={false}
|
||||
@@ -305,7 +314,7 @@ function FooterIconButton({
|
||||
>
|
||||
{({ hovered }) => (
|
||||
<Icon
|
||||
size={iconSize ?? theme.iconSize.md}
|
||||
size={iconSize + iconSizeAdjustment}
|
||||
color={hovered ? theme.colors.foreground : theme.colors.foregroundMuted}
|
||||
/>
|
||||
)}
|
||||
@@ -367,7 +376,7 @@ function SidebarHostPicker({
|
||||
label={label}
|
||||
icon={Server}
|
||||
// Server's two boxes fill more of the square than the other glyphs.
|
||||
iconSize={theme.iconSize.md - 1}
|
||||
iconSizeAdjustment={-1}
|
||||
theme={theme}
|
||||
/>
|
||||
</HostPicker>
|
||||
@@ -414,46 +423,54 @@ function SidebarFooter({
|
||||
}) {
|
||||
const newAgentKeys = useShortcutKeys("new-agent");
|
||||
const settingsKeys = useShortcutKeys("toggle-settings");
|
||||
const openUsageScreen = useOpenUsageScreen();
|
||||
|
||||
// One line of icons: Add project, Usage, Hosts, then Help and Settings at the end.
|
||||
return (
|
||||
<View style={styles.footerContainer} testID="sidebar-footer">
|
||||
<SidebarFooterRows onBeforeNavigate={onBeforeNavigate} />
|
||||
<View style={styles.sidebarFooter} testID="sidebar-footer-bottom-line">
|
||||
<FooterIconButton
|
||||
onPress={handleOpenProject}
|
||||
testID="sidebar-add-project"
|
||||
label={labels.addProject}
|
||||
icon={FolderPlus}
|
||||
shortcutKeys={newAgentKeys}
|
||||
theme={theme}
|
||||
/>
|
||||
<FooterIconButton
|
||||
onPress={openUsageScreen}
|
||||
testID="sidebar-usage-icon"
|
||||
label={labels.usage}
|
||||
icon={CircleGauge}
|
||||
theme={theme}
|
||||
/>
|
||||
<SidebarHostPicker
|
||||
theme={theme}
|
||||
label={labels.hosts}
|
||||
onAddHost={handleAddHost}
|
||||
onOpenHostSettings={handleOpenHostSettings}
|
||||
/>
|
||||
<View style={styles.footerSpacer} />
|
||||
<SidebarHelpMenu />
|
||||
<FooterIconButton
|
||||
onPress={handleSettings}
|
||||
testID="sidebar-settings"
|
||||
label={labels.settings}
|
||||
icon={Settings}
|
||||
shortcutKeys={settingsKeys}
|
||||
theme={theme}
|
||||
/>
|
||||
<UsageSidebarRoot>
|
||||
<View style={styles.footerContainer} testID="sidebar-footer">
|
||||
<SidebarFooterRows onBeforeNavigate={onBeforeNavigate} />
|
||||
<View style={styles.sidebarFooter} testID="sidebar-footer-bottom-line">
|
||||
<FooterIconButton
|
||||
onPress={handleOpenProject}
|
||||
testID="sidebar-add-project"
|
||||
label={labels.addProject}
|
||||
icon={FolderPlus}
|
||||
shortcutKeys={newAgentKeys}
|
||||
theme={theme}
|
||||
/>
|
||||
<SidebarUsageIcon label={labels.usage} theme={theme} />
|
||||
<SidebarHostPicker
|
||||
theme={theme}
|
||||
label={labels.hosts}
|
||||
onAddHost={handleAddHost}
|
||||
onOpenHostSettings={handleOpenHostSettings}
|
||||
/>
|
||||
<View style={styles.footerSpacer} />
|
||||
<SidebarHelpMenu />
|
||||
<FooterIconButton
|
||||
onPress={handleSettings}
|
||||
testID="sidebar-settings"
|
||||
label={labels.settings}
|
||||
icon={Settings}
|
||||
shortcutKeys={settingsKeys}
|
||||
theme={theme}
|
||||
/>
|
||||
</View>
|
||||
</View>
|
||||
</View>
|
||||
</UsageSidebarRoot>
|
||||
);
|
||||
}
|
||||
|
||||
function SidebarUsageIcon({ label, theme }: { label: string; theme: SidebarTheme }) {
|
||||
const openUsage = useOpenSidebarUsage();
|
||||
return (
|
||||
<FooterIconButton
|
||||
onPress={openUsage}
|
||||
testID="sidebar-usage-icon"
|
||||
label={label}
|
||||
icon={CircleGauge}
|
||||
theme={theme}
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -923,7 +940,7 @@ const styles = StyleSheet.create((theme) => ({
|
||||
borderTopWidth: 1,
|
||||
borderTopColor: theme.colors.border,
|
||||
},
|
||||
// The icons' 28pt buttons sit edge to edge; their own inset spaces the glyphs.
|
||||
// Buttons sit edge to edge; their own inset spaces the glyphs.
|
||||
sidebarFooter: {
|
||||
flexDirection: "row",
|
||||
alignItems: "center",
|
||||
@@ -940,14 +957,14 @@ const styles = StyleSheet.create((theme) => ({
|
||||
paddingVertical: theme.spacing[1.5],
|
||||
gap: 2,
|
||||
},
|
||||
footerIconButton: {
|
||||
width: 28,
|
||||
height: 28,
|
||||
footerIconButton: (isCompact: boolean) => ({
|
||||
width: isCompact ? buttonControlHeight.md : buttonControlHeight.xs,
|
||||
height: isCompact ? buttonControlHeight.md : buttonControlHeight.xs,
|
||||
alignItems: "center",
|
||||
justifyContent: "center",
|
||||
paddingVertical: theme.spacing[1],
|
||||
paddingHorizontal: theme.spacing[1],
|
||||
},
|
||||
}),
|
||||
tooltipRow: {
|
||||
flexDirection: "row",
|
||||
alignItems: "center",
|
||||
|
||||
@@ -14,6 +14,8 @@ import {
|
||||
DropdownMenuSeparator,
|
||||
DropdownMenuTrigger,
|
||||
} from "@/components/ui/dropdown-menu";
|
||||
import { buttonControlHeight } from "@/components/ui/control-geometry";
|
||||
import { useIsCompactFormFactor } from "@/constants/layout";
|
||||
import { Tooltip, TooltipContent, TooltipTrigger } from "@/components/ui/tooltip";
|
||||
import { useAppDiagnosticStore } from "@/diagnostics/store";
|
||||
import { useKeyboardShortcutsAvailable } from "@/keyboard/availability";
|
||||
@@ -77,6 +79,7 @@ function HostVersionHint({ host }: { host: HostProfile }) {
|
||||
}
|
||||
|
||||
export function SidebarHelpMenu() {
|
||||
const isCompact = useIsCompactFormFactor();
|
||||
const { t } = useTranslation();
|
||||
const shortcutsAvailable = useKeyboardShortcutsAvailable();
|
||||
const openAppDiagnostic = useAppDiagnosticStore((state) => state.open);
|
||||
@@ -103,14 +106,14 @@ export function SidebarHelpMenu() {
|
||||
<TooltipTrigger asChild>
|
||||
<View>
|
||||
<DropdownMenuTrigger
|
||||
style={styles.trigger}
|
||||
style={styles.trigger(isCompact)}
|
||||
testID="sidebar-help"
|
||||
accessibilityRole="button"
|
||||
accessibilityLabel={t("sidebar.help.trigger")}
|
||||
>
|
||||
{({ hovered }) => (
|
||||
<ThemedCircleHelp
|
||||
size={ICON_SIZE.md}
|
||||
size={isCompact ? ICON_SIZE.lg : ICON_SIZE.md}
|
||||
uniProps={hovered ? foregroundColorMapping : foregroundMutedColorMapping}
|
||||
/>
|
||||
)}
|
||||
@@ -181,14 +184,14 @@ export function SidebarHelpMenu() {
|
||||
}
|
||||
|
||||
const styles = StyleSheet.create((theme) => ({
|
||||
trigger: {
|
||||
width: 28,
|
||||
height: 28,
|
||||
trigger: (isCompact: boolean) => ({
|
||||
width: isCompact ? buttonControlHeight.md : buttonControlHeight.xs,
|
||||
height: isCompact ? buttonControlHeight.md : buttonControlHeight.xs,
|
||||
alignItems: "center",
|
||||
justifyContent: "center",
|
||||
paddingVertical: theme.spacing[1],
|
||||
paddingHorizontal: theme.spacing[1],
|
||||
},
|
||||
}),
|
||||
tooltipText: {
|
||||
fontSize: theme.fontSize.base,
|
||||
color: theme.colors.popoverForeground,
|
||||
|
||||
+13
-1
@@ -1,5 +1,5 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { computePosition, getTransformOrigin, type Rect } from "./menu-anchor";
|
||||
import { computePosition, getTransformOrigin, type Rect } from "./anchor";
|
||||
|
||||
const DISPLAY: Rect = { x: 0, y: 0, width: 1000, height: 800 };
|
||||
const TRIGGER: Rect = { x: 100, y: 100, width: 40, height: 20 };
|
||||
@@ -55,6 +55,18 @@ describe("computePosition", () => {
|
||||
expect(right).toEqual({ x: 144, y: 100, actualPlacement: "right" });
|
||||
});
|
||||
|
||||
it("lets hover cards flip horizontally when the opposite side has room", () => {
|
||||
const result = position({
|
||||
triggerRect: { ...TRIGGER, x: 850 },
|
||||
placement: "right",
|
||||
flipHorizontal: true,
|
||||
});
|
||||
expect(result).toEqual({ x: 646, y: 100, actualPlacement: "left" });
|
||||
expect(
|
||||
position({ triggerRect: { ...TRIGGER, x: 850 }, placement: "right" }).actualPlacement,
|
||||
).toBe("right");
|
||||
});
|
||||
|
||||
it("keeps the surface inside a display area that does not start at the origin", () => {
|
||||
// Regression: the horizontal clamp used to ignore displayArea.x while the vertical one
|
||||
// honoured displayArea.y, so an offset display area pushed the surface off its left edge.
|
||||
+19
-7
@@ -1,10 +1,8 @@
|
||||
import type { View } from "react-native";
|
||||
|
||||
/**
|
||||
* Where a floating menu surface goes relative to the thing that opened it.
|
||||
*
|
||||
* This was two byte-identical copies, one in `dropdown-menu.tsx` and one in `context-menu.tsx`.
|
||||
* Submenus need a third caller, so it lives here now and the menus import it.
|
||||
* Where a floating surface goes relative to the thing that opened it. Menus and hover cards
|
||||
* place themselves with it.
|
||||
*/
|
||||
|
||||
export type Placement = "top" | "bottom" | "left" | "right";
|
||||
@@ -38,14 +36,15 @@ export function measureElement(element: View): Promise<Rect> {
|
||||
* there is more room above. Both conditions matter: flipping into a side that is equally
|
||||
* cramped just moves the clipping, so a surface taller than the whole viewport stays put.
|
||||
*
|
||||
* Only the vertical placements flip. A left/right submenu that doesn't fit is handled by the
|
||||
* caller choosing its side up front, because flipping it mid-open would move the surface out
|
||||
* from under the pointer that is travelling toward it.
|
||||
* Horizontal flipping is opt-in for hover cards. Submenus choose their direction up front so
|
||||
* they do not move out from under the pointer travelling toward them.
|
||||
*/
|
||||
function flipPlacement(input: {
|
||||
placement: Placement;
|
||||
triggerRect: Rect;
|
||||
contentHeight: number;
|
||||
contentWidth: number;
|
||||
flipHorizontal: boolean;
|
||||
displayArea: Rect;
|
||||
}): Placement {
|
||||
const { placement, triggerRect, contentHeight, displayArea } = input;
|
||||
@@ -58,6 +57,14 @@ function flipPlacement(input: {
|
||||
if (placement === "top" && spaceTop < contentHeight && spaceBottom > spaceTop) {
|
||||
return "bottom";
|
||||
}
|
||||
if (input.flipHorizontal) {
|
||||
const spaceLeft = triggerRect.x - displayArea.x;
|
||||
const spaceRight = displayArea.x + displayArea.width - (triggerRect.x + triggerRect.width);
|
||||
if (placement === "right" && spaceRight < input.contentWidth && spaceLeft > spaceRight)
|
||||
return "left";
|
||||
if (placement === "left" && spaceLeft < input.contentWidth && spaceRight > spaceLeft)
|
||||
return "right";
|
||||
}
|
||||
return placement;
|
||||
}
|
||||
|
||||
@@ -120,6 +127,7 @@ export function computePosition({
|
||||
placement,
|
||||
alignment,
|
||||
offset,
|
||||
flipHorizontal = false,
|
||||
}: {
|
||||
triggerRect: Rect;
|
||||
contentSize: Size;
|
||||
@@ -127,11 +135,15 @@ export function computePosition({
|
||||
placement: Placement;
|
||||
alignment: Alignment;
|
||||
offset: number;
|
||||
/** Hover cards can choose either side; submenu direction is owned by the menu. */
|
||||
flipHorizontal?: boolean;
|
||||
}): { x: number; y: number; actualPlacement: Placement } {
|
||||
const actualPlacement = flipPlacement({
|
||||
placement,
|
||||
triggerRect,
|
||||
contentHeight: contentSize.height,
|
||||
contentWidth: contentSize.width,
|
||||
flipHorizontal,
|
||||
displayArea,
|
||||
});
|
||||
const anchored = anchorToPlacement({
|
||||
@@ -0,0 +1,405 @@
|
||||
import {
|
||||
createContext,
|
||||
useCallback,
|
||||
useContext,
|
||||
useEffect,
|
||||
useMemo,
|
||||
useRef,
|
||||
useState,
|
||||
type ReactElement,
|
||||
type ReactNode,
|
||||
type RefObject,
|
||||
} from "react";
|
||||
import { Dimensions, View, type Role, type StyleProp, type ViewStyle } from "react-native";
|
||||
import { FadeIn, FadeOut } from "react-native-reanimated";
|
||||
import { StyleSheet } from "react-native-unistyles";
|
||||
import { Portal } from "@gorhom/portal";
|
||||
import { useBottomSheetModalInternal } from "@gorhom/bottom-sheet";
|
||||
import {
|
||||
OverlayLayerProvider,
|
||||
useOverlayLayer,
|
||||
useWebOverlayRegistration,
|
||||
} from "@/lib/overlay-root";
|
||||
import { FloatingSurface } from "@/components/ui/floating";
|
||||
import { isWeb } from "@/constants/platform";
|
||||
import { useHoverSafeZone } from "@/hooks/use-hover-safe-zone";
|
||||
import {
|
||||
computePosition,
|
||||
measureElement,
|
||||
type Alignment,
|
||||
type Placement,
|
||||
type Rect,
|
||||
type Size,
|
||||
} from "./anchor";
|
||||
|
||||
const CLOSE_GRACE_MS = 100;
|
||||
|
||||
interface HoverCardContextValue {
|
||||
open: boolean;
|
||||
layer: number;
|
||||
setTriggerRef: (node: View | null) => void;
|
||||
triggerRef: RefObject<View | null>;
|
||||
contentRef: RefObject<View | null>;
|
||||
openNow: () => void;
|
||||
scheduleClose: () => void;
|
||||
}
|
||||
|
||||
const HoverCardContext = createContext<HoverCardContextValue | null>(null);
|
||||
|
||||
/**
|
||||
* A card that opens while the pointer is on its trigger and stays open while the pointer crosses
|
||||
* onto it, so its content can be pressed. Hover only exists on web; elsewhere the trigger renders
|
||||
* alone and the content never mounts. See docs/hover.md.
|
||||
*
|
||||
* ```tsx
|
||||
* <HoverCard>
|
||||
* <HoverCardTrigger>{trigger}</HoverCardTrigger>
|
||||
* <HoverCardContent placement="top">{details}</HoverCardContent>
|
||||
* </HoverCard>
|
||||
* ```
|
||||
*/
|
||||
export function HoverCard({
|
||||
disabled = false,
|
||||
children,
|
||||
}: {
|
||||
/** Closes the card and keeps it closed, e.g. while its trigger is dragged. */
|
||||
disabled?: boolean;
|
||||
children: ReactNode;
|
||||
}): ReactNode {
|
||||
if (!isWeb) return children;
|
||||
return <WebHoverCard disabled={disabled}>{children}</WebHoverCard>;
|
||||
}
|
||||
|
||||
function WebHoverCard({
|
||||
disabled,
|
||||
children,
|
||||
}: {
|
||||
disabled: boolean;
|
||||
children: ReactNode;
|
||||
}): ReactElement {
|
||||
const layer = useOverlayLayer("floating");
|
||||
const triggerRef = useRef<View>(null);
|
||||
const contentRef = useRef<View>(null);
|
||||
const [open, setOpen] = useState(false);
|
||||
const graceTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
||||
|
||||
const clearGraceTimer = useCallback(() => {
|
||||
if (graceTimerRef.current) {
|
||||
clearTimeout(graceTimerRef.current);
|
||||
graceTimerRef.current = null;
|
||||
}
|
||||
}, []);
|
||||
|
||||
const focusInside = useCallback(() => {
|
||||
if (!isWeb) return false;
|
||||
const active = document.activeElement;
|
||||
return [triggerRef.current, contentRef.current].some((view) =>
|
||||
(view as unknown as HTMLElement | null)?.contains(active),
|
||||
);
|
||||
}, []);
|
||||
|
||||
const scheduleClose = useCallback(() => {
|
||||
if (focusInside()) return;
|
||||
if (graceTimerRef.current) return;
|
||||
graceTimerRef.current = setTimeout(() => {
|
||||
graceTimerRef.current = null;
|
||||
setOpen(false);
|
||||
}, CLOSE_GRACE_MS);
|
||||
}, [focusInside]);
|
||||
|
||||
const openNow = useCallback(() => {
|
||||
clearGraceTimer();
|
||||
if (!disabled) {
|
||||
setOpen(true);
|
||||
}
|
||||
}, [clearGraceTimer, disabled]);
|
||||
|
||||
const keyPressed = useCallback(
|
||||
(event: KeyboardEvent): boolean => {
|
||||
if (!isWeb) return false;
|
||||
const trigger = triggerRef.current as unknown as HTMLElement | null;
|
||||
if (!trigger) return false;
|
||||
if (event.key === "Escape" && open) {
|
||||
event.preventDefault();
|
||||
if (focusInside()) trigger.focus();
|
||||
clearGraceTimer();
|
||||
setOpen(false);
|
||||
return true;
|
||||
} else if (
|
||||
focusInside() &&
|
||||
event.target === trigger &&
|
||||
["ArrowDown", "Enter", " "].includes(event.key)
|
||||
) {
|
||||
event.preventDefault();
|
||||
openNow();
|
||||
requestAnimationFrame(() => {
|
||||
(contentRef.current as unknown as HTMLElement | null)
|
||||
?.querySelector<HTMLElement>(
|
||||
'button, [role="button"][tabindex="0"], a[href], input, [tabindex="0"]',
|
||||
)
|
||||
?.focus();
|
||||
});
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
},
|
||||
[clearGraceTimer, focusInside, open, openNow],
|
||||
);
|
||||
|
||||
const setOverlayScope = useWebOverlayRegistration({
|
||||
active: !disabled && open,
|
||||
layer,
|
||||
onKeyDown: keyPressed,
|
||||
manageFocus: false,
|
||||
});
|
||||
const setTriggerRef = useCallback(
|
||||
(node: View | null) => {
|
||||
triggerRef.current = node;
|
||||
setOverlayScope(node);
|
||||
},
|
||||
[setOverlayScope],
|
||||
);
|
||||
|
||||
useEffect(() => {
|
||||
if (!isWeb) return;
|
||||
const trigger = triggerRef.current as unknown as HTMLElement | null;
|
||||
if (!trigger) return;
|
||||
const close = () => {
|
||||
clearGraceTimer();
|
||||
setOpen(false);
|
||||
};
|
||||
const focusEntered = (event: FocusEvent) => {
|
||||
const target = event.target as Node;
|
||||
if (trigger.contains(target)) {
|
||||
openNow();
|
||||
} else if ((contentRef.current as unknown as HTMLElement | null)?.contains(target)) {
|
||||
clearGraceTimer();
|
||||
}
|
||||
};
|
||||
const focusLeft = (event: FocusEvent) => {
|
||||
const next = event.relatedTarget as Node | null;
|
||||
if (
|
||||
!trigger.contains(next) &&
|
||||
!(contentRef.current as unknown as HTMLElement | null)?.contains(next)
|
||||
) {
|
||||
scheduleClose();
|
||||
}
|
||||
};
|
||||
const activateClosedTrigger = (event: KeyboardEvent) => {
|
||||
if (
|
||||
!open &&
|
||||
!event.defaultPrevented &&
|
||||
!event.isComposing &&
|
||||
["ArrowDown", "Enter", " "].includes(event.key)
|
||||
)
|
||||
keyPressed(event);
|
||||
};
|
||||
const scrolled = (event: Event) => {
|
||||
if (!(contentRef.current as unknown as HTMLElement | null)?.contains(event.target as Node))
|
||||
close();
|
||||
};
|
||||
document.addEventListener("focusin", focusEntered);
|
||||
document.addEventListener("focusout", focusLeft);
|
||||
trigger.addEventListener("keydown", activateClosedTrigger);
|
||||
document.addEventListener("scroll", scrolled, true);
|
||||
window.addEventListener("resize", close);
|
||||
return () => {
|
||||
document.removeEventListener("focusin", focusEntered);
|
||||
document.removeEventListener("focusout", focusLeft);
|
||||
trigger.removeEventListener("keydown", activateClosedTrigger);
|
||||
document.removeEventListener("scroll", scrolled, true);
|
||||
window.removeEventListener("resize", close);
|
||||
};
|
||||
}, [clearGraceTimer, keyPressed, open, openNow, scheduleClose]);
|
||||
|
||||
// While open, the safe zone covers trigger + content + the bridge between
|
||||
// them. Close only fires when the pointer leaves the safe zone; re-entering
|
||||
// it (including the bridge) cancels the pending close.
|
||||
useHoverSafeZone({
|
||||
enabled: open,
|
||||
triggerRef,
|
||||
contentRef,
|
||||
onEnterSafeZone: clearGraceTimer,
|
||||
onLeaveSafeZone: scheduleClose,
|
||||
});
|
||||
|
||||
useEffect(() => {
|
||||
if (disabled) {
|
||||
clearGraceTimer();
|
||||
setOpen(false);
|
||||
}
|
||||
}, [clearGraceTimer, disabled]);
|
||||
|
||||
useEffect(() => clearGraceTimer, [clearGraceTimer]);
|
||||
|
||||
const value = useMemo<HoverCardContextValue>(
|
||||
() => ({ open, layer, setTriggerRef, triggerRef, contentRef, openNow, scheduleClose }),
|
||||
[open, layer, setTriggerRef, openNow, scheduleClose],
|
||||
);
|
||||
|
||||
return (
|
||||
<OverlayLayerProvider layer={layer}>
|
||||
<HoverCardContext.Provider value={value}>{children}</HoverCardContext.Provider>
|
||||
</OverlayLayerProvider>
|
||||
);
|
||||
}
|
||||
|
||||
export function HoverCardTrigger({
|
||||
children,
|
||||
focusable = false,
|
||||
accessibilityLabel,
|
||||
}: {
|
||||
children: ReactNode;
|
||||
focusable?: boolean;
|
||||
accessibilityLabel?: string;
|
||||
}): ReactNode {
|
||||
const ctx = useContext(HoverCardContext);
|
||||
if (!ctx) return children;
|
||||
return (
|
||||
<View
|
||||
ref={ctx.setTriggerRef}
|
||||
tabIndex={focusable ? 0 : undefined}
|
||||
accessibilityRole={focusable ? "button" : undefined}
|
||||
accessibilityLabel={accessibilityLabel}
|
||||
collapsable={false}
|
||||
onPointerEnter={ctx.openNow}
|
||||
onPointerLeave={ctx.scheduleClose}
|
||||
>
|
||||
{children}
|
||||
</View>
|
||||
);
|
||||
}
|
||||
|
||||
interface HoverCardContentProps {
|
||||
placement: Placement;
|
||||
alignment?: Alignment;
|
||||
offset?: number;
|
||||
/** Layered over the default popover surface. */
|
||||
style?: StyleProp<ViewStyle>;
|
||||
role?: Role;
|
||||
accessibilityLabel?: string;
|
||||
testID?: string;
|
||||
/** Mounted only while the card is open, so whatever it fetches runs only then. */
|
||||
children: ReactNode;
|
||||
}
|
||||
|
||||
export function HoverCardContent(props: HoverCardContentProps): ReactElement | null {
|
||||
const ctx = useContext(HoverCardContext);
|
||||
if (!ctx?.open) return null;
|
||||
return (
|
||||
<HoverCardSurface
|
||||
{...props}
|
||||
layer={ctx.layer}
|
||||
triggerRef={ctx.triggerRef}
|
||||
contentRef={ctx.contentRef}
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
||||
function HoverCardSurface({
|
||||
layer,
|
||||
triggerRef,
|
||||
contentRef,
|
||||
placement,
|
||||
alignment = "center",
|
||||
offset = 4,
|
||||
style,
|
||||
role,
|
||||
accessibilityLabel,
|
||||
testID,
|
||||
children,
|
||||
}: HoverCardContentProps & {
|
||||
layer: number;
|
||||
triggerRef: RefObject<View | null>;
|
||||
contentRef: RefObject<View | null>;
|
||||
}): ReactElement {
|
||||
const bottomSheetInternal = useBottomSheetModalInternal(true);
|
||||
const [triggerRect, setTriggerRect] = useState<Rect | null>(null);
|
||||
const [contentSize, setContentSize] = useState<Size | null>(null);
|
||||
const [position, setPosition] = useState<{ x: number; y: number } | null>(null);
|
||||
|
||||
useEffect(() => {
|
||||
if (!triggerRef.current) return;
|
||||
let cancelled = false;
|
||||
void measureElement(triggerRef.current).then((rect) => {
|
||||
if (!cancelled) setTriggerRect(rect);
|
||||
return undefined;
|
||||
});
|
||||
return () => {
|
||||
cancelled = true;
|
||||
};
|
||||
}, [triggerRef]);
|
||||
|
||||
useEffect(() => {
|
||||
if (!triggerRect || !contentSize) return;
|
||||
const { width, height } = Dimensions.get("window");
|
||||
const { x, y } = computePosition({
|
||||
triggerRect,
|
||||
contentSize,
|
||||
displayArea: { x: 0, y: 0, width, height },
|
||||
placement,
|
||||
flipHorizontal: true,
|
||||
alignment,
|
||||
offset,
|
||||
});
|
||||
setPosition({ x, y });
|
||||
}, [alignment, contentSize, offset, placement, triggerRect]);
|
||||
|
||||
const handleLayout = useCallback(
|
||||
(event: { nativeEvent: { layout: { width: number; height: number } } }) => {
|
||||
const { width, height } = event.nativeEvent.layout;
|
||||
setContentSize({ width, height });
|
||||
},
|
||||
[],
|
||||
);
|
||||
|
||||
const frameStyle = useMemo(
|
||||
() => ({
|
||||
position: "absolute" as const,
|
||||
top: position?.y ?? -9999,
|
||||
left: position?.x ?? -9999,
|
||||
}),
|
||||
[position?.x, position?.y],
|
||||
);
|
||||
const surfaceStyle = useMemo(() => [styles.surface, style], [style]);
|
||||
|
||||
return (
|
||||
<Portal hostName={bottomSheetInternal?.hostName}>
|
||||
<View pointerEvents="box-none" style={[styles.portalOverlay, { zIndex: layer }]}>
|
||||
<FloatingSurface
|
||||
ref={contentRef}
|
||||
entering={FadeIn.duration(80)}
|
||||
exiting={FadeOut.duration(80)}
|
||||
collapsable={false}
|
||||
onLayout={handleLayout}
|
||||
role={role}
|
||||
accessibilityLabel={accessibilityLabel}
|
||||
testID={testID}
|
||||
style={surfaceStyle}
|
||||
frameStyle={frameStyle}
|
||||
>
|
||||
{children}
|
||||
</FloatingSurface>
|
||||
</View>
|
||||
</Portal>
|
||||
);
|
||||
}
|
||||
|
||||
const styles = StyleSheet.create((theme) => ({
|
||||
portalOverlay: {
|
||||
position: "absolute",
|
||||
top: 0,
|
||||
right: 0,
|
||||
bottom: 0,
|
||||
left: 0,
|
||||
zIndex: 1000,
|
||||
},
|
||||
surface: {
|
||||
backgroundColor: theme.colors.popover,
|
||||
borderWidth: theme.borderWidth[1],
|
||||
borderColor: theme.colors.borderAccent,
|
||||
borderRadius: theme.borderRadius.xl,
|
||||
...theme.shadow.md,
|
||||
zIndex: 1000,
|
||||
},
|
||||
}));
|
||||
@@ -35,4 +35,4 @@ export {
|
||||
type MenuPresentation,
|
||||
} from "./menu-context";
|
||||
export { currentPageId, isSubPageOpen, MENU_ROOT_PATH, type MenuPath } from "./menu-navigation";
|
||||
export type { Alignment, Placement, Rect, Size } from "./menu-anchor";
|
||||
export type { Alignment, Placement, Rect, Size } from "../anchor";
|
||||
|
||||
@@ -9,7 +9,7 @@ import {
|
||||
openSubPage,
|
||||
type MenuPath,
|
||||
} from "./menu-navigation";
|
||||
import type { Rect } from "./menu-anchor";
|
||||
import type { Rect } from "../anchor";
|
||||
|
||||
/**
|
||||
* How a menu draws itself once it is open.
|
||||
|
||||
@@ -38,7 +38,7 @@ import {
|
||||
type Placement,
|
||||
type Rect,
|
||||
type Size,
|
||||
} from "./menu-anchor";
|
||||
} from "../anchor";
|
||||
|
||||
const SCROLL_CONTENT_STYLE = { flexGrow: 1 } as const;
|
||||
const CONTENT_ENTERING_DURATION_MS = 150;
|
||||
|
||||
@@ -26,7 +26,7 @@ import { MenuPage } from "./menu-item";
|
||||
import { currentPageId, isSubPageOpen } from "./menu-navigation";
|
||||
import { AnchoredSurface, MenuOverlay } from "./menu-overlay";
|
||||
import { getMenuSheetBottomPadding } from "./menu-sheet-layout";
|
||||
import type { Alignment, Placement } from "./menu-anchor";
|
||||
import type { Alignment, Placement } from "../anchor";
|
||||
import type { KeyboardFocusScope } from "@/keyboard/actions";
|
||||
|
||||
const ThemedChevronLeft = withUnistyles(ChevronLeft);
|
||||
|
||||
@@ -1,16 +1,12 @@
|
||||
import {
|
||||
useCallback,
|
||||
useEffect,
|
||||
useMemo,
|
||||
useRef,
|
||||
useState,
|
||||
type PropsWithChildren,
|
||||
type ReactElement,
|
||||
type ReactNode,
|
||||
} from "react";
|
||||
import { Dimensions, Text, View } from "react-native";
|
||||
import { Text, View } from "react-native";
|
||||
import { useTranslation } from "react-i18next";
|
||||
import { FadeIn, FadeOut } from "react-native-reanimated";
|
||||
import { StyleSheet, withUnistyles } from "react-native-unistyles";
|
||||
import {
|
||||
Check,
|
||||
@@ -27,17 +23,13 @@ import type { Theme } from "@/styles/theme";
|
||||
import { DiffStat } from "@/components/diff-stat";
|
||||
import { Pressable } from "react-native";
|
||||
import type { GestureResponderEvent } from "react-native";
|
||||
import { Portal } from "@gorhom/portal";
|
||||
import { useBottomSheetModalInternal } from "@gorhom/bottom-sheet";
|
||||
import type { SidebarWorkspaceEntry } from "@/hooks/use-sidebar-workspaces-list";
|
||||
import type { PrHint } from "@/git/use-pr-status-query";
|
||||
import { openExternalUrl } from "@/utils/open-external-url";
|
||||
import { copyToClipboard } from "@/utils/copy-to-clipboard";
|
||||
import { PrBadge } from "@/components/sidebar-workspace-list";
|
||||
import { useHoverSafeZone } from "@/hooks/use-hover-safe-zone";
|
||||
import { useIsCompactFormFactor } from "@/constants/layout";
|
||||
import { FloatingSurface } from "@/components/ui/floating";
|
||||
import { isWeb } from "@/constants/platform";
|
||||
import { HoverCard, HoverCardContent, HoverCardTrigger } from "@/components/ui/hover-card";
|
||||
import { useHosts } from "@/runtime/host-runtime";
|
||||
import {
|
||||
COUNTED_CHECK_PRESENTATIONS,
|
||||
@@ -48,52 +40,6 @@ import { formatCheckPresentationCountsLabel } from "@/git/check-presentation-cop
|
||||
import { CheckPresentationIcon, getCheckPresentationTone } from "@/git/check-presentation.view";
|
||||
import { buildForgeChecksUrl } from "@/git/forge-url";
|
||||
|
||||
interface Rect {
|
||||
x: number;
|
||||
y: number;
|
||||
width: number;
|
||||
height: number;
|
||||
}
|
||||
|
||||
function measureElement(element: View): Promise<Rect> {
|
||||
return new Promise((resolve) => {
|
||||
element.measureInWindow((x, y, width, height) => {
|
||||
resolve({ x, y, width, height });
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
function computeHoverCardPosition({
|
||||
triggerRect,
|
||||
contentSize,
|
||||
displayArea,
|
||||
offset,
|
||||
}: {
|
||||
triggerRect: Rect;
|
||||
contentSize: { width: number; height: number };
|
||||
displayArea: Rect;
|
||||
offset: number;
|
||||
}): { x: number; y: number } {
|
||||
let x = triggerRect.x + triggerRect.width + offset;
|
||||
let y = triggerRect.y;
|
||||
|
||||
// If it overflows right, try left
|
||||
if (x + contentSize.width > displayArea.width - 8) {
|
||||
x = triggerRect.x - contentSize.width - offset;
|
||||
}
|
||||
|
||||
// Constrain to screen
|
||||
const padding = 8;
|
||||
x = Math.max(padding, Math.min(displayArea.width - contentSize.width - padding, x));
|
||||
y = Math.max(
|
||||
displayArea.y + padding,
|
||||
Math.min(displayArea.y + displayArea.height - contentSize.height - padding, y),
|
||||
);
|
||||
|
||||
return { x, y };
|
||||
}
|
||||
|
||||
const HOVER_GRACE_MS = 100;
|
||||
const HOVER_CARD_WIDTH = 260;
|
||||
|
||||
interface WorkspaceHoverCardProps {
|
||||
@@ -110,237 +56,80 @@ export function WorkspaceHoverCard({
|
||||
disabled = false,
|
||||
children,
|
||||
}: PropsWithChildren<WorkspaceHoverCardProps>): ReactNode {
|
||||
const { t } = useTranslation();
|
||||
const isCompact = useIsCompactFormFactor();
|
||||
|
||||
if (!isWeb || isCompact) {
|
||||
if (isCompact) {
|
||||
return children;
|
||||
}
|
||||
|
||||
return (
|
||||
<WorkspaceHoverCardDesktop
|
||||
workspace={workspace}
|
||||
prHint={prHint}
|
||||
isDragging={isDragging}
|
||||
disabled={disabled}
|
||||
>
|
||||
{children}
|
||||
</WorkspaceHoverCardDesktop>
|
||||
);
|
||||
}
|
||||
|
||||
function WorkspaceHoverCardDesktop({
|
||||
workspace,
|
||||
prHint,
|
||||
isDragging,
|
||||
disabled = false,
|
||||
children,
|
||||
}: PropsWithChildren<WorkspaceHoverCardProps>): ReactElement {
|
||||
const triggerRef = useRef<View>(null);
|
||||
const contentRef = useRef<View>(null);
|
||||
const [open, setOpen] = useState(false);
|
||||
const graceTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
|
||||
const triggerHoveredRef = useRef(false);
|
||||
|
||||
const clearGraceTimer = useCallback(() => {
|
||||
if (graceTimerRef.current) {
|
||||
clearTimeout(graceTimerRef.current);
|
||||
graceTimerRef.current = null;
|
||||
}
|
||||
}, []);
|
||||
|
||||
const scheduleClose = useCallback(() => {
|
||||
if (graceTimerRef.current) return;
|
||||
graceTimerRef.current = setTimeout(() => {
|
||||
graceTimerRef.current = null;
|
||||
setOpen(false);
|
||||
}, HOVER_GRACE_MS);
|
||||
}, []);
|
||||
|
||||
const handleTriggerEnter = useCallback(() => {
|
||||
triggerHoveredRef.current = true;
|
||||
clearGraceTimer();
|
||||
if (!isDragging && !disabled) {
|
||||
setOpen(true);
|
||||
}
|
||||
}, [clearGraceTimer, disabled, isDragging]);
|
||||
|
||||
const handleTriggerLeave = useCallback(() => {
|
||||
triggerHoveredRef.current = false;
|
||||
scheduleClose();
|
||||
}, [scheduleClose]);
|
||||
|
||||
// While open, the safe zone covers trigger + content + the bridge between
|
||||
// them. Close only fires when the pointer leaves the safe zone; re-entering
|
||||
// it (including the bridge) cancels the pending close.
|
||||
useHoverSafeZone({
|
||||
enabled: open,
|
||||
triggerRef,
|
||||
contentRef,
|
||||
onEnterSafeZone: clearGraceTimer,
|
||||
onLeaveSafeZone: scheduleClose,
|
||||
});
|
||||
|
||||
// Close while another row interaction owns attention.
|
||||
useEffect(() => {
|
||||
if (isDragging || disabled) {
|
||||
clearGraceTimer();
|
||||
setOpen(false);
|
||||
}
|
||||
}, [clearGraceTimer, disabled, isDragging]);
|
||||
|
||||
// Cleanup on unmount
|
||||
useEffect(() => {
|
||||
return () => {
|
||||
clearGraceTimer();
|
||||
};
|
||||
}, [clearGraceTimer]);
|
||||
|
||||
return (
|
||||
<View
|
||||
ref={triggerRef}
|
||||
collapsable={false}
|
||||
onPointerEnter={handleTriggerEnter}
|
||||
onPointerLeave={handleTriggerLeave}
|
||||
>
|
||||
{children}
|
||||
{open ? (
|
||||
<WorkspaceHoverCardContent
|
||||
workspace={workspace}
|
||||
prHint={prHint}
|
||||
triggerRef={triggerRef}
|
||||
contentRef={contentRef}
|
||||
/>
|
||||
) : null}
|
||||
</View>
|
||||
<HoverCard disabled={isDragging || disabled}>
|
||||
<HoverCardTrigger>{children}</HoverCardTrigger>
|
||||
<HoverCardContent
|
||||
placement="right"
|
||||
role="menu"
|
||||
accessibilityLabel={t("workspace.hoverCard.scriptsAccessibility")}
|
||||
testID="workspace-hover-card"
|
||||
style={styles.card}
|
||||
>
|
||||
<WorkspaceHoverCardContent workspace={workspace} prHint={prHint} />
|
||||
</HoverCardContent>
|
||||
</HoverCard>
|
||||
);
|
||||
}
|
||||
|
||||
function WorkspaceHoverCardContent({
|
||||
workspace,
|
||||
prHint,
|
||||
triggerRef,
|
||||
contentRef,
|
||||
}: {
|
||||
workspace: SidebarWorkspaceEntry;
|
||||
prHint: PrHint | null;
|
||||
triggerRef: React.RefObject<View | null>;
|
||||
contentRef: React.RefObject<View | null>;
|
||||
}): ReactElement | null {
|
||||
}): ReactElement {
|
||||
const { t } = useTranslation();
|
||||
const bottomSheetInternal = useBottomSheetModalInternal(true);
|
||||
const [triggerRect, setTriggerRect] = useState<Rect | null>(null);
|
||||
const [contentSize, setContentSize] = useState<{ width: number; height: number } | null>(null);
|
||||
const [position, setPosition] = useState<{ x: number; y: number } | null>(null);
|
||||
|
||||
// Measure trigger — same pattern as tooltip.tsx
|
||||
useEffect(() => {
|
||||
if (!triggerRef.current) return;
|
||||
|
||||
let cancelled = false;
|
||||
measureElement(triggerRef.current).then((rect) => {
|
||||
if (cancelled) return;
|
||||
setTriggerRect(rect);
|
||||
return;
|
||||
});
|
||||
|
||||
return () => {
|
||||
cancelled = true;
|
||||
};
|
||||
}, [triggerRef]);
|
||||
|
||||
// Compute position when both measurements are available
|
||||
useEffect(() => {
|
||||
if (!triggerRect || !contentSize) return;
|
||||
const { width: screenWidth, height: screenHeight } = Dimensions.get("window");
|
||||
const displayArea = { x: 0, y: 0, width: screenWidth, height: screenHeight };
|
||||
const result = computeHoverCardPosition({
|
||||
triggerRect,
|
||||
contentSize,
|
||||
displayArea,
|
||||
offset: 4,
|
||||
});
|
||||
setPosition(result);
|
||||
}, [triggerRect, contentSize]);
|
||||
|
||||
const handleLayout = useCallback(
|
||||
(event: { nativeEvent: { layout: { width: number; height: number } } }) => {
|
||||
const { width, height } = event.nativeEvent.layout;
|
||||
setContentSize({ width, height });
|
||||
},
|
||||
[],
|
||||
);
|
||||
|
||||
const frameStyle = useMemo(
|
||||
() => ({
|
||||
position: "absolute" as const,
|
||||
top: position?.y ?? -9999,
|
||||
left: position?.x ?? -9999,
|
||||
}),
|
||||
[position?.x, position?.y],
|
||||
);
|
||||
|
||||
return (
|
||||
<Portal hostName={bottomSheetInternal?.hostName}>
|
||||
<View pointerEvents="box-none" style={styles.portalOverlay}>
|
||||
<FloatingSurface
|
||||
ref={contentRef}
|
||||
entering={FadeIn.duration(80)}
|
||||
exiting={FadeOut.duration(80)}
|
||||
collapsable={false}
|
||||
onLayout={handleLayout}
|
||||
accessibilityRole="menu"
|
||||
accessibilityLabel={t("workspace.hoverCard.scriptsAccessibility")}
|
||||
testID="workspace-hover-card"
|
||||
style={styles.card}
|
||||
frameStyle={frameStyle}
|
||||
>
|
||||
<View style={styles.cardHeader}>
|
||||
<Text style={styles.cardTitle} testID="hover-card-workspace-name">
|
||||
{workspace.name}
|
||||
</Text>
|
||||
</View>
|
||||
{prHint ? <PrBadge hint={prHint} style={styles.cardInfoRow} /> : null}
|
||||
{workspace.diffStat ? (
|
||||
<View style={styles.cardInfoRow}>
|
||||
<ThemedFileDiff size={12} uniProps={foregroundMutedColorMapping} />
|
||||
<DiffStat
|
||||
additions={workspace.diffStat.additions}
|
||||
deletions={workspace.diffStat.deletions}
|
||||
/>
|
||||
</View>
|
||||
) : null}
|
||||
<HostRow serverId={workspace.serverId} />
|
||||
{workspace.currentBranch ? (
|
||||
<CopyableInfoRow
|
||||
icon={ThemedGitBranch}
|
||||
value={workspace.currentBranch}
|
||||
copyValue={workspace.currentBranch}
|
||||
copyLabel={t("workspace.hoverCard.copyBranchName")}
|
||||
testID="hover-card-workspace-branch"
|
||||
/>
|
||||
) : null}
|
||||
{workspace.workspaceDirectoryLabel ? (
|
||||
<CopyableInfoRow
|
||||
icon={ThemedFolder}
|
||||
value={workspace.workspaceDirectoryLabel}
|
||||
copyValue={workspace.workspaceDirectory}
|
||||
copyLabel={t("workspace.hoverCard.copyPath")}
|
||||
testID="hover-card-workspace-cwd"
|
||||
/>
|
||||
) : null}
|
||||
{prHint?.checks && prHint.checks.length > 0 ? (
|
||||
<>
|
||||
<View style={styles.separator} />
|
||||
<ChecksSummaryPressable
|
||||
checks={prHint.checks}
|
||||
url={prHint.url}
|
||||
forge={prHint.forge}
|
||||
/>
|
||||
</>
|
||||
) : null}
|
||||
</FloatingSurface>
|
||||
<>
|
||||
<View style={styles.cardHeader}>
|
||||
<Text style={styles.cardTitle} testID="hover-card-workspace-name">
|
||||
{workspace.name}
|
||||
</Text>
|
||||
</View>
|
||||
</Portal>
|
||||
{prHint ? <PrBadge hint={prHint} style={styles.cardInfoRow} /> : null}
|
||||
{workspace.diffStat ? (
|
||||
<View style={styles.cardInfoRow}>
|
||||
<ThemedFileDiff size={12} uniProps={foregroundMutedColorMapping} />
|
||||
<DiffStat
|
||||
additions={workspace.diffStat.additions}
|
||||
deletions={workspace.diffStat.deletions}
|
||||
/>
|
||||
</View>
|
||||
) : null}
|
||||
<HostRow serverId={workspace.serverId} />
|
||||
{workspace.currentBranch ? (
|
||||
<CopyableInfoRow
|
||||
icon={ThemedGitBranch}
|
||||
value={workspace.currentBranch}
|
||||
copyValue={workspace.currentBranch}
|
||||
copyLabel={t("workspace.hoverCard.copyBranchName")}
|
||||
testID="hover-card-workspace-branch"
|
||||
/>
|
||||
) : null}
|
||||
{workspace.workspaceDirectoryLabel ? (
|
||||
<CopyableInfoRow
|
||||
icon={ThemedFolder}
|
||||
value={workspace.workspaceDirectoryLabel}
|
||||
copyValue={workspace.workspaceDirectory}
|
||||
copyLabel={t("workspace.hoverCard.copyPath")}
|
||||
testID="hover-card-workspace-cwd"
|
||||
/>
|
||||
) : null}
|
||||
{prHint?.checks && prHint.checks.length > 0 ? (
|
||||
<>
|
||||
<View style={styles.separator} />
|
||||
<ChecksSummaryPressable checks={prHint.checks} url={prHint.url} forge={prHint.forge} />
|
||||
</>
|
||||
) : null}
|
||||
</>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -561,14 +350,6 @@ function checksSummaryPressableStyle({ hovered = false }: { pressed: boolean; ho
|
||||
}
|
||||
|
||||
const styles = StyleSheet.create((theme) => ({
|
||||
portalOverlay: {
|
||||
position: "absolute",
|
||||
top: 0,
|
||||
right: 0,
|
||||
bottom: 0,
|
||||
left: 0,
|
||||
zIndex: 1000,
|
||||
},
|
||||
card: {
|
||||
backgroundColor: theme.colors.surface1,
|
||||
borderWidth: 1,
|
||||
@@ -581,7 +362,6 @@ const styles = StyleSheet.create((theme) => ({
|
||||
shadowOpacity: 0.2,
|
||||
shadowRadius: 8,
|
||||
elevation: 8,
|
||||
zIndex: 1000,
|
||||
},
|
||||
cardHeader: {
|
||||
flexDirection: "row",
|
||||
|
||||
@@ -22,11 +22,11 @@ import {
|
||||
useImperativeHandle,
|
||||
memo,
|
||||
type ReactElement,
|
||||
type ReactNode,
|
||||
} from "react";
|
||||
import { useTranslation } from "react-i18next";
|
||||
import { StyleSheet, withUnistyles } from "react-native-unistyles";
|
||||
import { useIsCompactFormFactor } from "@/constants/layout";
|
||||
import { useHasFinePointer } from "@/hooks/use-fine-pointer";
|
||||
import { useShallow } from "zustand/shallow";
|
||||
import {
|
||||
ArrowUp,
|
||||
@@ -278,41 +278,6 @@ function buildAgentStateSelector(serverId: string, agentId: string) {
|
||||
};
|
||||
}
|
||||
|
||||
function renderContextWindowMeter(
|
||||
serverId: string,
|
||||
agentId: string,
|
||||
contextWindowMaxTokens: number | null,
|
||||
contextWindowUsedTokens: number | null,
|
||||
totalCostUsd: number | null,
|
||||
showPercentage: boolean,
|
||||
pending: boolean,
|
||||
glyphSize: number,
|
||||
): ReactElement | null {
|
||||
const hasData = contextWindowMaxTokens !== null && contextWindowUsedTokens !== null;
|
||||
if (!hasData && !pending) {
|
||||
return null;
|
||||
}
|
||||
return (
|
||||
<ContextWindowMeter
|
||||
serverId={serverId}
|
||||
agentId={agentId}
|
||||
maxTokens={contextWindowMaxTokens}
|
||||
usedTokens={contextWindowUsedTokens}
|
||||
totalCostUsd={totalCostUsd}
|
||||
showPercentage={showPercentage}
|
||||
pending={pending}
|
||||
glyphSize={glyphSize}
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
||||
function resolveContextWindowPlacement(
|
||||
meter: ReactElement | null,
|
||||
reserveSlot: boolean,
|
||||
): ReactNode {
|
||||
return reserveSlot ? <View style={styles.contextWindowMeterSlot}>{meter}</View> : null;
|
||||
}
|
||||
|
||||
interface RenderLeftContentArgs {
|
||||
agentControls: DraftAgentControlsProps | undefined;
|
||||
agentId: string;
|
||||
@@ -1006,16 +971,6 @@ interface ComposerProps {
|
||||
const EMPTY_ARRAY: readonly QueuedMessage[] = [];
|
||||
const StableMessageInput = memo(MessageInput);
|
||||
|
||||
function resolveContextWindowValues(
|
||||
rawMax: number | null,
|
||||
rawUsed: number | null,
|
||||
): { contextWindowMaxTokens: number | null; contextWindowUsedTokens: number | null } {
|
||||
if (typeof rawMax === "number" && typeof rawUsed === "number") {
|
||||
return { contextWindowMaxTokens: rawMax, contextWindowUsedTokens: rawUsed };
|
||||
}
|
||||
return { contextWindowMaxTokens: null, contextWindowUsedTokens: null };
|
||||
}
|
||||
|
||||
interface ComposerAutocompleteHandle {
|
||||
onKeyPress: (event: ComposerKeyPressEvent) => boolean;
|
||||
}
|
||||
@@ -1312,6 +1267,7 @@ function ComposerContentImpl({
|
||||
const isCompactFormFactor = useIsCompactFormFactor();
|
||||
const isCompactLayout = resolveCompactLayout(isCompactLayoutOverride, isCompactFormFactor);
|
||||
const isDesktopWebBreakpoint = resolveIsDesktopWebBreakpoint(isCompactFormFactor);
|
||||
const hasFinePointer = useHasFinePointer();
|
||||
const isDesktopLayout = resolveIsDesktopWebBreakpoint(isCompactLayout);
|
||||
const messagePlaceholder = resolveMessagePlaceholder(inputMode, isDesktopLayout, t, placeholder);
|
||||
const hasText = useSyncExternalStore(
|
||||
@@ -2069,40 +2025,31 @@ function ComposerContentImpl({
|
||||
],
|
||||
);
|
||||
|
||||
const { contextWindowMaxTokens, contextWindowUsedTokens } = resolveContextWindowValues(
|
||||
agentState.contextWindowMaxTokens,
|
||||
agentState.contextWindowUsedTokens,
|
||||
);
|
||||
|
||||
const contextWindowPending = agentState.status === "initializing" || isAgentRunning;
|
||||
const contextWindowMeterGlyphSize = isCompactLayout ? ICON_SIZE.md : buttonIconSize;
|
||||
|
||||
const contextWindowMeter = useMemo(
|
||||
const beforeVoiceContent = useMemo(
|
||||
() =>
|
||||
renderContextWindowMeter(
|
||||
serverId,
|
||||
agentId,
|
||||
contextWindowMaxTokens,
|
||||
contextWindowUsedTokens,
|
||||
agentState.totalCostUsd,
|
||||
false,
|
||||
contextWindowPending,
|
||||
contextWindowMeterGlyphSize,
|
||||
),
|
||||
hasAgent ? (
|
||||
<View style={styles.contextWindowMeterSlot}>
|
||||
<ContextWindowMeter
|
||||
serverId={serverId}
|
||||
agentId={agentId}
|
||||
maxTokens={agentState.contextWindowMaxTokens}
|
||||
usedTokens={agentState.contextWindowUsedTokens}
|
||||
totalCostUsd={agentState.totalCostUsd}
|
||||
glyphSize={contextWindowMeterGlyphSize}
|
||||
/>
|
||||
</View>
|
||||
) : null,
|
||||
[
|
||||
hasAgent,
|
||||
serverId,
|
||||
agentId,
|
||||
contextWindowMaxTokens,
|
||||
contextWindowUsedTokens,
|
||||
agentState.contextWindowMaxTokens,
|
||||
agentState.contextWindowUsedTokens,
|
||||
agentState.totalCostUsd,
|
||||
contextWindowPending,
|
||||
contextWindowMeterGlyphSize,
|
||||
],
|
||||
);
|
||||
const beforeVoiceContent = useMemo(
|
||||
() => <>{resolveContextWindowPlacement(contextWindowMeter, hasAgent)}</>,
|
||||
[contextWindowMeter, hasAgent],
|
||||
);
|
||||
|
||||
const hasGithubAttachment = useMemo(
|
||||
() =>
|
||||
@@ -2383,7 +2330,8 @@ function ComposerContentImpl({
|
||||
{ disabled: isSubmitLoadingVisible },
|
||||
);
|
||||
|
||||
const messageInputAutoFocus = autoFocus && isDesktopWebBreakpoint;
|
||||
// Focusing the composer on a touch screen raises the on-screen keyboard over the conversation.
|
||||
const messageInputAutoFocus = autoFocus && isDesktopWebBreakpoint && hasFinePointer;
|
||||
const submitLoadingPressHandler = isAgentRunning ? handleCancelAgent : undefined;
|
||||
const sendErrorNode = useMemo(
|
||||
() =>
|
||||
|
||||
@@ -94,14 +94,30 @@ describe("hover safe-zone tracker", () => {
|
||||
expect(handle.leaves).toBe(1);
|
||||
});
|
||||
|
||||
it("bridges the gap to content above or below the trigger", () => {
|
||||
const handle = createHandle({
|
||||
trigger: { left: 100, right: 130, top: 60, bottom: 90 },
|
||||
content: { left: 0, right: 300, top: 0, bottom: 52 },
|
||||
});
|
||||
|
||||
// In the gap between the card and the trigger below it.
|
||||
handle.pointerMoved(115, 56);
|
||||
expect(handle.enters).toBe(1);
|
||||
expect(handle.leaves).toBe(0);
|
||||
|
||||
// Beside the trigger, past the gap — outside.
|
||||
handle.pointerMoved(200, 75);
|
||||
expect(handle.leaves).toBe(1);
|
||||
});
|
||||
|
||||
it("treats overlapping trigger and content as having no bridge", () => {
|
||||
const handle = createHandle({
|
||||
trigger: { left: 0, right: 200, top: 0, bottom: 50 },
|
||||
content: { left: 100, right: 300, top: 60, bottom: 100 },
|
||||
content: { left: 100, right: 300, top: 40, bottom: 100 },
|
||||
});
|
||||
|
||||
// Outside both rects, in what would be a bridge — should be outside.
|
||||
handle.pointerMoved(150, 55);
|
||||
// Outside both rects, in the corner neither of them covers — should be outside.
|
||||
handle.pointerMoved(250, 20);
|
||||
expect(handle.enters).toBe(0);
|
||||
expect(handle.leaves).toBe(1);
|
||||
});
|
||||
|
||||
@@ -62,9 +62,20 @@ function isInsideSafeZone(
|
||||
if (isInsideRect(trigger, x, y)) return true;
|
||||
if (isInsideRect(content, x, y)) return true;
|
||||
if (!trigger || !content) return false;
|
||||
return (
|
||||
isInsideHorizontalBridge(trigger, content, x, y) ||
|
||||
isInsideVerticalBridge(trigger, content, x, y)
|
||||
);
|
||||
}
|
||||
|
||||
// Bridge: the horizontal strip connecting trigger and content, stretched
|
||||
// vertically to span both. If they overlap horizontally there's no bridge.
|
||||
// A card beside its trigger: the strip between them, stretched vertically to
|
||||
// span both. If they overlap horizontally there's no horizontal bridge.
|
||||
function isInsideHorizontalBridge(
|
||||
trigger: RectLike,
|
||||
content: RectLike,
|
||||
x: number,
|
||||
y: number,
|
||||
): boolean {
|
||||
const bridgeLeft = Math.min(trigger.right, content.right);
|
||||
const bridgeRight = Math.max(trigger.left, content.left);
|
||||
if (bridgeLeft >= bridgeRight) return false;
|
||||
@@ -72,3 +83,19 @@ function isInsideSafeZone(
|
||||
const bridgeBottom = Math.max(trigger.bottom, content.bottom);
|
||||
return x >= bridgeLeft && x <= bridgeRight && y >= bridgeTop && y <= bridgeBottom;
|
||||
}
|
||||
|
||||
// A card above or below its trigger: the strip between them, stretched
|
||||
// horizontally to span both. If they overlap vertically there's no vertical bridge.
|
||||
function isInsideVerticalBridge(
|
||||
trigger: RectLike,
|
||||
content: RectLike,
|
||||
x: number,
|
||||
y: number,
|
||||
): boolean {
|
||||
const bridgeTop = Math.min(trigger.bottom, content.bottom);
|
||||
const bridgeBottom = Math.max(trigger.top, content.top);
|
||||
if (bridgeTop >= bridgeBottom) return false;
|
||||
const bridgeLeft = Math.min(trigger.left, content.left);
|
||||
const bridgeRight = Math.max(trigger.right, content.right);
|
||||
return x >= bridgeLeft && x <= bridgeRight && y >= bridgeTop && y <= bridgeBottom;
|
||||
}
|
||||
|
||||
@@ -150,7 +150,7 @@ export const DEFAULT_CLIENT_SETTINGS: AppSettings = {
|
||||
contentMaxWidth: null,
|
||||
syntaxTheme: "one",
|
||||
workspaceTitleSource: "title",
|
||||
sidebarWorkspaceTrailing: "diff",
|
||||
sidebarWorkspaceTrailing: "timestamp",
|
||||
sidebarRowItems: DEFAULT_SIDEBAR_ROW_ITEMS,
|
||||
sidebarChecksDisplay: DEFAULT_SIDEBAR_CHECKS_DISPLAY,
|
||||
sidebarNavItems: [],
|
||||
@@ -242,7 +242,7 @@ const StoredAppSettingsSchema = z
|
||||
.catch(null),
|
||||
syntaxTheme: z.string().refine(isSyntaxThemeId).catch("one"),
|
||||
workspaceTitleSource: z.enum(["title", "branch"]).catch("title"),
|
||||
sidebarWorkspaceTrailing: z.enum(["diff", "timestamp", "none"]).catch("diff"),
|
||||
sidebarWorkspaceTrailing: z.enum(["diff", "timestamp", "none"]).catch("timestamp"),
|
||||
sidebarRowItems: SidebarRowItemsSchema,
|
||||
sidebarChecksDisplay: z
|
||||
.enum(["iconAndText", "icon", "none"])
|
||||
|
||||
@@ -1931,6 +1931,8 @@ export const ar: TranslationResources = {
|
||||
dismiss: "رفض",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "لا توجد بيانات للسياق",
|
||||
accessibilityNoData: "نافذة السياق: لا توجد بيانات للسياق",
|
||||
title: "نافذة السياق",
|
||||
used: "تم استخدام{{percentage}}%",
|
||||
tokens: "رموز{{used}}/{{max}}",
|
||||
|
||||
@@ -1956,6 +1956,8 @@ export const en = {
|
||||
dismiss: "Dismiss",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "No context data",
|
||||
accessibilityNoData: "Context window: No context data",
|
||||
title: "Context window",
|
||||
used: "{{percentage}}% used",
|
||||
tokens: "{{used}} / {{max}} tokens",
|
||||
|
||||
@@ -1979,6 +1979,8 @@ export const es: TranslationResources = {
|
||||
dismiss: "Despedir",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "No hay datos de contexto",
|
||||
accessibilityNoData: "Ventana de contexto: No hay datos de contexto",
|
||||
title: "ventana contextual",
|
||||
used: "{{percentage}}% utilizado",
|
||||
tokens: "Fichas{{used}}/{{max}}",
|
||||
|
||||
@@ -1984,6 +1984,8 @@ export const fr: TranslationResources = {
|
||||
dismiss: "Rejeter",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "Aucune donnée de contexte",
|
||||
accessibilityNoData: "Fenêtre de contexte : aucune donnée de contexte",
|
||||
title: "Fenêtre contextuelle",
|
||||
used: "{{percentage}}% utilisé",
|
||||
tokens: "Jetons{{used}}/{{max}}",
|
||||
|
||||
@@ -1951,6 +1951,8 @@ export const ja: TranslationResources = {
|
||||
dismiss: "閉じる",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "コンテキストデータがありません",
|
||||
accessibilityNoData: "コンテキストウィンドウ:コンテキストデータがありません",
|
||||
title: "コンテキストウィンドウ",
|
||||
used: "{{percentage}}%使用",
|
||||
tokens: "{{used}} / {{max}}トークン",
|
||||
|
||||
@@ -1941,6 +1941,8 @@ export const ko: TranslationResources = {
|
||||
dismiss: "닫기",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "컨텍스트 데이터 없음",
|
||||
accessibilityNoData: "컨텍스트 창: 컨텍스트 데이터 없음",
|
||||
title: "컨텍스트 윈도우",
|
||||
used: "{{percentage}}% 사용됨",
|
||||
tokens: "{{used}} / {{max}} 토큰",
|
||||
|
||||
@@ -1964,6 +1964,8 @@ export const ptBR: TranslationResources = {
|
||||
dismiss: "Dispensar",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "Sem dados de contexto",
|
||||
accessibilityNoData: "Janela de contexto: sem dados de contexto",
|
||||
title: "Janela de contexto",
|
||||
used: "{{percentage}}% usado",
|
||||
tokens: "{{used}} / {{max}} tokens",
|
||||
|
||||
@@ -1964,6 +1964,8 @@ export const ru: TranslationResources = {
|
||||
dismiss: "Закрыть",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "Нет данных о контексте",
|
||||
accessibilityNoData: "Контекстное окно: нет данных о контексте",
|
||||
title: "Контекстное окно",
|
||||
used: "Использовано: {{percentage}}%",
|
||||
tokens: "Токены: {{used}} / {{max}}",
|
||||
|
||||
@@ -1909,6 +1909,8 @@ export const zhCN: TranslationResources = {
|
||||
dismiss: "关闭",
|
||||
},
|
||||
contextWindow: {
|
||||
noData: "暂无上下文数据",
|
||||
accessibilityNoData: "上下文窗口:暂无上下文数据",
|
||||
title: "上下文窗口",
|
||||
used: "已使用 {{percentage}}%",
|
||||
tokens: "{{used}} / {{max}} tokens",
|
||||
|
||||
@@ -88,6 +88,7 @@ interface WebOverlayEntry {
|
||||
getScope: () => HTMLElement | null;
|
||||
getKeyHandler: () => WebOverlayKeyHandler;
|
||||
restoreFocus: HTMLElement | null;
|
||||
manageFocus: boolean;
|
||||
}
|
||||
|
||||
const webOverlayEntries: WebOverlayEntry[] = [];
|
||||
@@ -140,7 +141,7 @@ function focusFirstElement(scope: HTMLElement): void {
|
||||
function handleWebOverlayFocus(event: FocusEvent): void {
|
||||
const top = getTopWebOverlay();
|
||||
const scope = top?.getScope();
|
||||
if (!scope || scope.contains(event.target as Node)) return;
|
||||
if (!top?.manageFocus || !scope || scope.contains(event.target as Node)) return;
|
||||
if (webOverlayFocusCheckQueued) return;
|
||||
|
||||
// React can autofocus a child before its parent scope ref attaches. Defer
|
||||
@@ -149,8 +150,10 @@ function handleWebOverlayFocus(event: FocusEvent): void {
|
||||
webOverlayFocusCheckQueued = true;
|
||||
queueMicrotask(() => {
|
||||
webOverlayFocusCheckQueued = false;
|
||||
const currentScope = getTopWebOverlay()?.getScope();
|
||||
if (!currentScope || currentScope.contains(document.activeElement)) return;
|
||||
const currentTop = getTopWebOverlay();
|
||||
const currentScope = currentTop?.getScope();
|
||||
if (!currentTop?.manageFocus || !currentScope || currentScope.contains(document.activeElement))
|
||||
return;
|
||||
focusFirstElement(currentScope);
|
||||
});
|
||||
}
|
||||
@@ -169,7 +172,7 @@ export function dispatchTopWebOverlayKeyDown(event: KeyboardEvent): boolean {
|
||||
const scope = top?.getScope();
|
||||
if (!top || !scope) return false;
|
||||
|
||||
if (event.key === "Tab") {
|
||||
if (top.manageFocus && event.key === "Tab") {
|
||||
const focusable = getFocusableElements(scope);
|
||||
const first = focusable[0];
|
||||
const last = focusable[focusable.length - 1];
|
||||
@@ -214,7 +217,12 @@ function addWebOverlay(entry: WebOverlayEntry): (options?: RemoveWebOverlayOptio
|
||||
|
||||
const focusFrame = window.requestAnimationFrame(() => {
|
||||
const scope = entry.getScope();
|
||||
if (getTopWebOverlay() === entry && scope && !scope.contains(document.activeElement)) {
|
||||
if (
|
||||
entry.manageFocus &&
|
||||
getTopWebOverlay() === entry &&
|
||||
scope &&
|
||||
!scope.contains(document.activeElement)
|
||||
) {
|
||||
focusFirstElement(scope);
|
||||
}
|
||||
});
|
||||
@@ -225,6 +233,7 @@ function addWebOverlay(entry: WebOverlayEntry): (options?: RemoveWebOverlayOptio
|
||||
if (index !== -1) webOverlayEntries.splice(index, 1);
|
||||
detachWebOverlayListeners();
|
||||
if (
|
||||
entry.manageFocus &&
|
||||
options?.restoreFocus !== false &&
|
||||
entry.restoreFocus &&
|
||||
document.contains(entry.restoreFocus)
|
||||
@@ -239,17 +248,20 @@ interface WebOverlayRegistration {
|
||||
layer: number;
|
||||
onKeyDown: WebOverlayKeyHandler;
|
||||
restoreFocusRef?: React.RefObject<unknown>;
|
||||
/** Hover surfaces claim overlay keys while preserving the user's existing focus. */
|
||||
manageFocus?: boolean;
|
||||
}
|
||||
|
||||
/**
|
||||
* Registers a focus scope in the same relative layer model used for painting.
|
||||
* Only the highest painted overlay receives keyboard input; focus is trapped
|
||||
* there and restored to the opener when that overlay closes.
|
||||
* Only the highest painted overlay receives keyboard input. By default, focus is trapped
|
||||
* there and restored to the opener when it closes; hover surfaces preserve focus instead.
|
||||
*/
|
||||
export function useWebOverlayRegistration({
|
||||
active,
|
||||
layer,
|
||||
onKeyDown,
|
||||
manageFocus = true,
|
||||
restoreFocusRef: preferredRestoreFocusRef,
|
||||
}: WebOverlayRegistration) {
|
||||
const idRef = useRef(Symbol("web-overlay"));
|
||||
@@ -305,10 +317,11 @@ export function useWebOverlayRegistration({
|
||||
getScope: () => scopeRef.current,
|
||||
getKeyHandler: () => keyHandlerRef.current,
|
||||
restoreFocus: capturedRestoreFocusRef.current,
|
||||
manageFocus,
|
||||
};
|
||||
removeEntryRef.current = addWebOverlay(entry);
|
||||
registeredRef.current = true;
|
||||
}, []);
|
||||
}, [manageFocus]);
|
||||
|
||||
const setScope = useCallback(
|
||||
(node: unknown) => {
|
||||
|
||||
@@ -42,7 +42,15 @@ export function MobilePanelOverlay({
|
||||
|
||||
const overlayAnimatedStyle = useAnimatedStyle(() => {
|
||||
const isVisible = isLeft ? position.value < 0 : position.value > 0;
|
||||
return { display: isVisible ? ("flex" as const) : ("none" as const) };
|
||||
if (isWeb) {
|
||||
return { display: isVisible ? ("flex" as const) : ("none" as const) };
|
||||
}
|
||||
// Preserve native scroll ranges while hidden. Collapsing layout makes Android
|
||||
// spring retained scroll offsets back to zero on touch cancellation or release.
|
||||
return {
|
||||
opacity: isVisible ? 1 : 0,
|
||||
pointerEvents: isVisible ? ("box-none" as const) : ("none" as const),
|
||||
};
|
||||
}, [isLeft]);
|
||||
|
||||
const positionedPanelStyle = isLeft ? styles.leftPanel : styles.rightPanel;
|
||||
@@ -79,10 +87,7 @@ export function MobilePanelOverlay({
|
||||
pointerEvents={overlayPointerEvents}
|
||||
style={styles.overlay}
|
||||
>
|
||||
<Animated.View
|
||||
pointerEvents={overlayPointerEvents}
|
||||
style={[styles.overlay, overlayAnimatedStyle]}
|
||||
>
|
||||
<Animated.View style={[styles.overlay, overlayAnimatedStyle]}>
|
||||
<Pressable
|
||||
accessible={false}
|
||||
accessibilityElementsHidden
|
||||
|
||||
@@ -3,6 +3,7 @@ import { StyleSheet } from "react-native-unistyles";
|
||||
import { HostFilter } from "@/components/hosts/host-filter";
|
||||
import { useMemo, type ReactElement } from "react";
|
||||
import { UsageRefreshButton } from "./refresh-button";
|
||||
import { UsageOptions } from "./options";
|
||||
import type { UsageHost } from "./model";
|
||||
import { useHostUsage } from "./queries";
|
||||
import type { UsageView } from "./types";
|
||||
@@ -16,7 +17,7 @@ export interface UsageHostSelection {
|
||||
|
||||
/**
|
||||
* The controls on the right of every usage title row: the host filter when there is more than one
|
||||
* host, and Refresh all. A host that cannot report usage keeps only the host filter.
|
||||
* host, Refresh all, and the Settings cog. A host that cannot report usage keeps only the host filter.
|
||||
*/
|
||||
export function UsageControls({
|
||||
view,
|
||||
@@ -41,7 +42,10 @@ export function UsageControls({
|
||||
/>
|
||||
) : null}
|
||||
{view.kind === "unavailable" ? null : (
|
||||
<UsageRefreshButton busy={busy} onRefresh={onRefresh} />
|
||||
<>
|
||||
<UsageRefreshButton busy={busy} onRefresh={onRefresh} />
|
||||
<UsageOptions />
|
||||
</>
|
||||
)}
|
||||
</View>
|
||||
);
|
||||
|
||||
@@ -2,4 +2,9 @@ export { AgentUsage } from "./agent-usage";
|
||||
export { HostUsageSection } from "./host-usage-section";
|
||||
export { useHostReportsUsage } from "./queries";
|
||||
export { UsageScreen } from "./usage-screen";
|
||||
export { UsageSidebarItem, useHasUsageSummary, useOpenUsageScreen } from "./sidebar-item";
|
||||
export {
|
||||
UsageSidebarItem,
|
||||
UsageSidebarRoot,
|
||||
useHasUsageSummary,
|
||||
useOpenSidebarUsage,
|
||||
} from "./sidebar-item";
|
||||
|
||||
@@ -1,14 +1,15 @@
|
||||
import { View } from "react-native";
|
||||
import {
|
||||
SettingsCard,
|
||||
SettingsCollapsibleRow,
|
||||
SettingsRow,
|
||||
SettingsSwitch,
|
||||
} from "@/components/settings";
|
||||
import { Settings } from "lucide-react-native";
|
||||
import { withUnistyles } from "react-native-unistyles";
|
||||
import { DropdownMenu, DropdownMenuContent } from "@/components/ui/dropdown-menu";
|
||||
import { extraMutedIconColorMapping } from "@/components/ui/icon-button-chrome";
|
||||
import { ToolbarButton, paneContentToolbarIconSize } from "@/components/ui/pane-content-toolbar";
|
||||
import { useIsCompactFormFactor } from "@/constants/layout";
|
||||
import { SettingsRow, SettingsSwitch } from "@/components/settings";
|
||||
import { SegmentedControl, type SegmentedControlOption } from "@/components/ui/segmented-control";
|
||||
import { settingsStyles } from "@/styles/settings";
|
||||
import { usageCopy } from "./copy";
|
||||
import type { UsageDisplay } from "./display";
|
||||
import { useUsagePreferences } from "./display";
|
||||
import { useUsageInSidebar } from "./in-sidebar";
|
||||
import type { UsageDisplayAs } from "./preferences";
|
||||
|
||||
@@ -17,16 +18,33 @@ const DISPLAY_AS_OPTIONS: SegmentedControlOption<UsageDisplayAs>[] = [
|
||||
{ value: "remaining", label: usageCopy.displayRemaining, testID: "usage-display-remaining" },
|
||||
];
|
||||
|
||||
/**
|
||||
* The usage options, folded above the reports: whether the sidebar shows the summary (the same
|
||||
* switch as Settings > Sidebar) and whether percents read as used or remaining.
|
||||
*/
|
||||
export function UsageOptions({ display }: { display: UsageDisplay }) {
|
||||
const ThemedSettings = withUnistyles(Settings);
|
||||
|
||||
/** The shared usage preferences, opened from a cog as a popover or compact sheet. */
|
||||
export function UsageOptions() {
|
||||
const compact = useIsCompactFormFactor();
|
||||
const { display } = useUsagePreferences();
|
||||
const { inSidebar, setInSidebar } = useUsageInSidebar();
|
||||
return (
|
||||
<View style={settingsStyles.section}>
|
||||
<SettingsCard>
|
||||
<SettingsCollapsibleRow label={usageCopy.options} testID="usage-options">
|
||||
<DropdownMenu compactMode="sheet">
|
||||
<ToolbarButton
|
||||
kind="menu"
|
||||
label={usageCopy.options}
|
||||
compact={compact}
|
||||
testID="usage-options-menu"
|
||||
>
|
||||
<ThemedSettings
|
||||
size={paneContentToolbarIconSize(compact)}
|
||||
uniProps={extraMutedIconColorMapping}
|
||||
/>
|
||||
</ToolbarButton>
|
||||
<DropdownMenuContent
|
||||
align="end"
|
||||
width={340}
|
||||
sheetTitle={usageCopy.options}
|
||||
testID="usage-options-surface"
|
||||
>
|
||||
<View testID="usage-options-fields">
|
||||
<SettingsSwitch
|
||||
label={usageCopy.showInSidebar}
|
||||
hint={usageCopy.showInSidebarHint}
|
||||
@@ -34,17 +52,19 @@ export function UsageOptions({ display }: { display: UsageDisplay }) {
|
||||
onValueChange={setInSidebar}
|
||||
testID="usage-show-in-sidebar"
|
||||
/>
|
||||
<SettingsRow label={usageCopy.displayAs}>
|
||||
<SegmentedControl
|
||||
options={DISPLAY_AS_OPTIONS}
|
||||
value={display.displayAs}
|
||||
onValueChange={display.setDisplayAs}
|
||||
size="sm"
|
||||
testID="usage-display-as"
|
||||
/>
|
||||
</SettingsRow>
|
||||
</SettingsCollapsibleRow>
|
||||
</SettingsCard>
|
||||
</View>
|
||||
<View style={settingsStyles.rowBorder}>
|
||||
<SettingsRow label={usageCopy.displayAs}>
|
||||
<SegmentedControl
|
||||
options={DISPLAY_AS_OPTIONS}
|
||||
value={display.displayAs}
|
||||
onValueChange={display.setDisplayAs}
|
||||
size="sm"
|
||||
testID="usage-display-as"
|
||||
/>
|
||||
</SettingsRow>
|
||||
</View>
|
||||
</View>
|
||||
</DropdownMenuContent>
|
||||
</DropdownMenu>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1,5 +1,13 @@
|
||||
import { router } from "expo-router";
|
||||
import { Fragment, useCallback, useMemo, useState } from "react";
|
||||
import {
|
||||
createContext,
|
||||
Fragment,
|
||||
useCallback,
|
||||
useContext,
|
||||
useMemo,
|
||||
useState,
|
||||
type ReactNode,
|
||||
} from "react";
|
||||
import { useTranslation } from "react-i18next";
|
||||
import {
|
||||
Pressable,
|
||||
@@ -12,7 +20,6 @@ import { StyleSheet } from "react-native-unistyles";
|
||||
import { SidebarPopoverRoot, SidebarPopoverSurface } from "@/components/sidebar/sidebar-popover";
|
||||
import { useIsCompactFormFactor } from "@/constants/layout";
|
||||
import { builtinSidebarNavLabelKey } from "@/sidebar-nav/model";
|
||||
import { usePanelStore } from "@/stores/panel-store";
|
||||
import { buildUsageRoute } from "@/utils/host-routes";
|
||||
import { useHostUsageWithControls } from "./controls";
|
||||
import { useUsagePreferences, type UsageDisplay } from "./display";
|
||||
@@ -29,7 +36,6 @@ import {
|
||||
type PinnedUsageSource,
|
||||
} from "./pinned";
|
||||
import type { UsageHost } from "./model";
|
||||
import { UsageOptions } from "./options";
|
||||
import { UsageBody } from "./usage-section";
|
||||
|
||||
/** Each summary window with data on the usage host, under its source; empty while none has. */
|
||||
@@ -50,55 +56,51 @@ export function useHasUsageSummary(): boolean {
|
||||
* Pressing it opens the Usage screen; on compact layouts it opens the usage sheet instead.
|
||||
*/
|
||||
export function UsageSidebarItem() {
|
||||
const { display } = useUsagePreferences();
|
||||
const sources = useUsageSummary();
|
||||
if (sources.length === 0) return null;
|
||||
return <UsageEntry sources={sources} display={display} />;
|
||||
}
|
||||
|
||||
/** Opens the Usage screen, over the sidebar on compact layouts. */
|
||||
export function useOpenUsageScreen(): () => void {
|
||||
const isCompact = useIsCompactFormFactor();
|
||||
const showMobileAgent = usePanelStore((state) => state.showMobileAgent);
|
||||
return useCallback(() => {
|
||||
if (isCompact) showMobileAgent();
|
||||
router.push(buildUsageRoute());
|
||||
}, [isCompact, showMobileAgent]);
|
||||
}
|
||||
|
||||
function UsageEntry({
|
||||
sources,
|
||||
display,
|
||||
}: {
|
||||
sources: readonly PinnedUsageSource[];
|
||||
display: UsageDisplay;
|
||||
}) {
|
||||
const { t } = useTranslation();
|
||||
const label = t(builtinSidebarNavLabelKey("usage"));
|
||||
const openUsage = useOpenSidebarUsage();
|
||||
const sources = useUsageSummary();
|
||||
if (sources.length === 0) return null;
|
||||
return <PinnedUsageTrigger label={label} sources={sources} onPress={openUsage} />;
|
||||
}
|
||||
|
||||
const OpenSidebarUsageContext = createContext<(() => void) | null>(null);
|
||||
|
||||
/** One owner for the footer icon and summary: a compact sheet or the wide Usage screen. */
|
||||
export function UsageSidebarRoot({ children }: { children: ReactNode }) {
|
||||
const { t } = useTranslation();
|
||||
const { display } = useUsagePreferences();
|
||||
const isCompact = useIsCompactFormFactor();
|
||||
const openUsageScreen = useOpenUsageScreen();
|
||||
const [open, setOpen] = useState(false);
|
||||
// The sheet mounts on first open; the summary already owns the report query.
|
||||
const [sheetMounted, setSheetMounted] = useState(false);
|
||||
const handlePress = useCallback(() => {
|
||||
if (!isCompact) {
|
||||
openUsageScreen();
|
||||
const openUsage = useCallback(() => {
|
||||
if (isCompact) {
|
||||
setSheetMounted(true);
|
||||
setOpen(true);
|
||||
return;
|
||||
}
|
||||
setSheetMounted(true);
|
||||
setOpen(true);
|
||||
}, [isCompact, openUsageScreen]);
|
||||
router.push(buildUsageRoute());
|
||||
}, [isCompact]);
|
||||
|
||||
const trigger = <PinnedUsageTrigger label={label} sources={sources} onPress={handlePress} />;
|
||||
if (!isCompact) return trigger;
|
||||
return (
|
||||
<SidebarPopoverRoot open={open} onOpenChange={setOpen}>
|
||||
{trigger}
|
||||
{sheetMounted ? <UsageSheet title={label} display={display} /> : null}
|
||||
</SidebarPopoverRoot>
|
||||
<OpenSidebarUsageContext.Provider value={openUsage}>
|
||||
<SidebarPopoverRoot open={isCompact && open} onOpenChange={setOpen}>
|
||||
{children}
|
||||
{isCompact && sheetMounted ? (
|
||||
<UsageSheet title={t(builtinSidebarNavLabelKey("usage"))} display={display} />
|
||||
) : null}
|
||||
</SidebarPopoverRoot>
|
||||
</OpenSidebarUsageContext.Provider>
|
||||
);
|
||||
}
|
||||
|
||||
/** Both sidebar entry points send the same open command. */
|
||||
export function useOpenSidebarUsage(): () => void {
|
||||
const openUsage = useContext(OpenSidebarUsageContext);
|
||||
if (!openUsage) throw new Error("Sidebar Usage must be inside UsageSidebarRoot.");
|
||||
return openUsage;
|
||||
}
|
||||
|
||||
/**
|
||||
* The compact usage sheet: the Usage screen's host, reports with pins, and controls, the controls
|
||||
* in its title row.
|
||||
@@ -144,7 +146,6 @@ function HostUsageSheet({
|
||||
testID="sidebar-usage-sheet"
|
||||
>
|
||||
<View style={styles.sheetBody} testID="usage-expanded">
|
||||
{view.kind === "unavailable" ? null : <UsageOptions display={display} />}
|
||||
<UsageBody serverId={serverId} view={view} display={display} onRefresh={refresh} />
|
||||
</View>
|
||||
</SidebarPopoverSurface>
|
||||
|
||||
@@ -8,7 +8,6 @@ import { usageCopy } from "./copy";
|
||||
import { useUsagePreferences } from "./display";
|
||||
import { useUsageHostSelection } from "./hosts";
|
||||
import type { UsageHost } from "./model";
|
||||
import { UsageOptions } from "./options";
|
||||
import { UsageBody, UsageMessage } from "./usage-section";
|
||||
|
||||
// The screen is reachable by URL, so there may be no history to go back to.
|
||||
@@ -66,7 +65,6 @@ function HostUsage({
|
||||
return (
|
||||
<UsagePage actions={controls}>
|
||||
<View testID={`usage-host-${serverId}`}>
|
||||
{view.kind === "unavailable" ? null : <UsageOptions display={display} />}
|
||||
<UsageBody serverId={serverId} view={view} display={display} onRefresh={refresh} />
|
||||
</View>
|
||||
</UsagePage>
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { describe, expect, it, vi } from "vitest";
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
const daemonTarget = { kind: "endpoint" as const, host: "example.test:12345" };
|
||||
|
||||
@@ -7,18 +7,45 @@ import { runDeleteCommand } from "./delete.js";
|
||||
const agent = {
|
||||
id: "11111111-1111-4111-8111-111111111111",
|
||||
status: "running",
|
||||
archivedAt: null,
|
||||
archivedAt: null as string | null,
|
||||
cwd: "/tmp/project",
|
||||
};
|
||||
const archivedAgent = {
|
||||
id: "22222222-2222-4222-8222-222222222222",
|
||||
status: "closed",
|
||||
archivedAt: "2026-10-01T00:00:00.000Z",
|
||||
cwd: "/tmp/project/nested",
|
||||
};
|
||||
const archivedOutsideAgent = {
|
||||
id: "33333333-3333-4333-8333-333333333333",
|
||||
status: "closed",
|
||||
archivedAt: "2026-10-01T00:00:00.000Z",
|
||||
cwd: "/tmp/elsewhere",
|
||||
};
|
||||
let daemonAgents: (typeof agent)[] = [agent];
|
||||
const toEntry = (entry: typeof agent) => ({ agent: entry });
|
||||
// The fake daemon pages history two agents at a time.
|
||||
const historyPage = (cursor: string | undefined) => {
|
||||
const start = Number(cursor ?? 0);
|
||||
const end = start + 2;
|
||||
return {
|
||||
entries: daemonAgents.slice(start, end).map(toEntry),
|
||||
pageInfo: { nextCursor: end < daemonAgents.length ? String(end) : null },
|
||||
};
|
||||
};
|
||||
const cancelAgent = vi.fn(async () => {
|
||||
throw new Error("active run cancellation was not acknowledged");
|
||||
});
|
||||
const fetchAgentHistory = vi.fn(async (options: { page: { cursor?: string } }) =>
|
||||
historyPage(options.page.cursor),
|
||||
);
|
||||
const deleteAgent = vi.fn(async () => undefined);
|
||||
const close = vi.fn(async () => undefined);
|
||||
|
||||
vi.mock("../../utils/client.js", () => ({
|
||||
connectToDaemon: vi.fn(async () => ({
|
||||
fetchAgents: vi.fn(async () => ({ entries: [{ agent }] })),
|
||||
fetchAgents: vi.fn(async () => historyPage(undefined)),
|
||||
fetchAgentHistory,
|
||||
fetchAgent: vi.fn(async () => ({ agent })),
|
||||
cancelAgent,
|
||||
deleteAgent,
|
||||
@@ -28,9 +55,16 @@ vi.mock("../../utils/client.js", () => ({
|
||||
}));
|
||||
|
||||
describe("runDeleteCommand", () => {
|
||||
beforeEach(() => {
|
||||
daemonAgents = [agent];
|
||||
deleteAgent.mockClear();
|
||||
fetchAgentHistory.mockClear();
|
||||
});
|
||||
|
||||
it("force-deletes a running agent when graceful cancellation is refused", async () => {
|
||||
const result = await runDeleteCommand(agent.id, { daemonTarget }, {} as never);
|
||||
|
||||
expect(fetchAgentHistory).not.toHaveBeenCalled();
|
||||
expect(cancelAgent).toHaveBeenCalledWith(agent.id);
|
||||
expect(deleteAgent).toHaveBeenCalledWith(agent.id);
|
||||
expect(result.data).toEqual({
|
||||
@@ -38,4 +72,30 @@ describe("runDeleteCommand", () => {
|
||||
agentIds: [agent.id],
|
||||
});
|
||||
});
|
||||
|
||||
it("deletes archived agents on every history page with --all", async () => {
|
||||
daemonAgents = [agent, archivedAgent, archivedOutsideAgent];
|
||||
|
||||
const result = await runDeleteCommand(undefined, { daemonTarget, all: true }, {} as never);
|
||||
|
||||
expect(result.data).toEqual({
|
||||
deletedCount: 3,
|
||||
agentIds: [agent.id, archivedAgent.id, archivedOutsideAgent.id],
|
||||
});
|
||||
});
|
||||
|
||||
it("deletes archived agents inside the directory with --cwd", async () => {
|
||||
daemonAgents = [agent, archivedAgent, archivedOutsideAgent];
|
||||
|
||||
const result = await runDeleteCommand(
|
||||
undefined,
|
||||
{ daemonTarget, cwd: "/tmp/project" },
|
||||
{} as never,
|
||||
);
|
||||
|
||||
expect(result.data).toEqual({
|
||||
deletedCount: 2,
|
||||
agentIds: [agent.id, archivedAgent.id],
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import type { Command } from "commander";
|
||||
import { connectToDaemon } from "../../utils/client.js";
|
||||
import { isSameOrDescendantPath } from "../../utils/paths.js";
|
||||
import type { DaemonClient, FetchAgentHistoryEntry } from "@getpaseo/client/internal/daemon-client";
|
||||
|
||||
export function addDeleteOptions(cmd: Command): Command {
|
||||
return cmd
|
||||
@@ -33,6 +34,20 @@ export interface AgentDeleteOptions extends CommandOptions {
|
||||
|
||||
export type AgentDeleteResult = SingleResult<DeleteResult>;
|
||||
|
||||
// History includes archived agents and agents whose provider is unavailable.
|
||||
async function fetchHistoryAgents(client: DaemonClient) {
|
||||
const agents: FetchAgentHistoryEntry["agent"][] = [];
|
||||
let cursor: string | undefined;
|
||||
do {
|
||||
const payload = await client.fetchAgentHistory({
|
||||
page: { limit: 200, ...(cursor ? { cursor } : {}) },
|
||||
});
|
||||
agents.push(...payload.entries.map((entry) => entry.agent));
|
||||
cursor = payload.pageInfo.nextCursor ?? undefined;
|
||||
} while (cursor);
|
||||
return agents;
|
||||
}
|
||||
|
||||
export async function runDeleteCommand(
|
||||
id: string | undefined,
|
||||
options: AgentDeleteOptions,
|
||||
@@ -50,19 +65,16 @@ export async function runDeleteCommand(
|
||||
const client = await connectToDaemon({ target: options.daemonTarget });
|
||||
|
||||
try {
|
||||
const fetchPayload = await client.fetchAgents({ filter: { includeArchived: true } });
|
||||
let agents = fetchPayload.entries.map((entry) => entry.agent);
|
||||
const deletedIds: string[] = [];
|
||||
let agents: FetchAgentHistoryEntry["agent"][];
|
||||
|
||||
if (options.all) {
|
||||
agents = agents.filter((a) => !a.archivedAt);
|
||||
} else if (options.cwd) {
|
||||
agents = agents.filter((a) => {
|
||||
if (a.archivedAt) return false;
|
||||
return isSameOrDescendantPath(options.cwd!, a.cwd);
|
||||
});
|
||||
} else if (id) {
|
||||
const fetchResult = await client.fetchAgent({ agentId: id });
|
||||
if (options.all || options.cwd) {
|
||||
agents = await fetchHistoryAgents(client);
|
||||
if (!options.all) {
|
||||
agents = agents.filter((a) => isSameOrDescendantPath(options.cwd!, a.cwd));
|
||||
}
|
||||
} else {
|
||||
const fetchResult = await client.fetchAgent({ agentId: id! });
|
||||
if (!fetchResult) {
|
||||
const error: CommandError = {
|
||||
code: "AGENT_NOT_FOUND",
|
||||
|
||||
@@ -146,7 +146,7 @@ test("managed two-home restart retains its supervisor and never routes ordinary
|
||||
expect(await f.ok(["project", "ls", "--home", a])).toEqual([]);
|
||||
expect((await f.ok(["project", "ls", "--home", b], poisoned)).length).toBe(1);
|
||||
const stream = await f.run(["logs", "missing-agent", "--follow", "--home", b], poisoned);
|
||||
expect(stream.stderr).toContain("Agent not found: missing-agent");
|
||||
expect(stream.stderr).toContain("No agent found matching: missing-agent");
|
||||
const restart = await f.ok(["restart", "--home", b, "--timeout", "30"], poisoned);
|
||||
expect(restart.supervisorPid).toBe(launchB.pid);
|
||||
expect(restart.workerPid).not.toBe(beforeB.workerPid);
|
||||
@@ -503,7 +503,7 @@ test("raw log following subscribes to a stored agent that exists only in B", asy
|
||||
const launchA = await f.ok(["start", "--home", a]);
|
||||
await f.ok(["start", "--home", b]);
|
||||
const absent = await f.run(["logs", agentId, "--home", a]);
|
||||
expect(absent.stderr).toContain("Agent not found");
|
||||
expect(absent.stderr).toContain(`No agent found matching: ${agentId}`);
|
||||
follower = spawn(
|
||||
process.execPath,
|
||||
[cli, "logs", agentId, "--follow", "--tail", "0", "--home", b],
|
||||
@@ -522,7 +522,7 @@ test("raw log following subscribes to a stored agent that exists only in B", asy
|
||||
errors += data;
|
||||
});
|
||||
await expect.poll(() => output, { timeout: 15_000 }).toContain("Following logs (no history;");
|
||||
expect(errors).not.toContain("Agent not found");
|
||||
expect(errors).not.toContain("No agent found matching");
|
||||
} finally {
|
||||
if (follower && follower.exitCode === null) {
|
||||
const exited = new Promise((resolve) => follower!.once("exit", resolve));
|
||||
|
||||
@@ -17,6 +17,15 @@ function inputFrom(value: string) {
|
||||
};
|
||||
}
|
||||
|
||||
function claudeNotification(notificationType: string) {
|
||||
return JSON.stringify({
|
||||
session_id: "session-1",
|
||||
hook_event_name: "Notification",
|
||||
message: "Claude is waiting for your input",
|
||||
notification_type: notificationType,
|
||||
});
|
||||
}
|
||||
|
||||
function ttyInput() {
|
||||
return {
|
||||
isTTY: true,
|
||||
@@ -123,7 +132,7 @@ describe("runHooksCommand", () => {
|
||||
const send = await runHook(
|
||||
claudeProvider.id,
|
||||
claudeProvider.events[4].event,
|
||||
inputFrom('{"reason":"idle_prompt"}'),
|
||||
inputFrom(claudeNotification("idle_prompt")),
|
||||
);
|
||||
|
||||
expectPostedState(send, "needs-input");
|
||||
@@ -131,11 +140,11 @@ describe("runHooksCommand", () => {
|
||||
|
||||
it.each(["permission_prompt", "elicitation_prompt", "elicitation_response", "auth_success"])(
|
||||
"ignores Claude %s notifications",
|
||||
async (reason) => {
|
||||
async (notificationType) => {
|
||||
const send = await runHook(
|
||||
claudeProvider.id,
|
||||
claudeProvider.events[4].event,
|
||||
inputFrom(JSON.stringify({ reason })),
|
||||
inputFrom(claudeNotification(notificationType)),
|
||||
);
|
||||
|
||||
expect(send.calls).toEqual([]);
|
||||
|
||||
@@ -218,7 +218,7 @@ export function createPluginCommand(): Command {
|
||||
.description("Trust and install a plugin from a directory, Git repository, or npm package")
|
||||
.argument(
|
||||
"<source>",
|
||||
"Registry owner/slug or host/owner/slug, host directory, github:owner/repo, git: or npm: source",
|
||||
"Host directory, GitHub owner/repo, git: or npm: source, optionally followed by :plugin/path",
|
||||
)
|
||||
.option("--id <id>", "Runtime plugin ID (defaults to paseo-plugin.json id)")
|
||||
.option("--ref <ref>", "Git branch, tag, or commit")
|
||||
|
||||
@@ -19,6 +19,7 @@
|
||||
|
||||
import assert from "node:assert";
|
||||
import { getAvailablePort } from "./helpers/network.ts";
|
||||
import { runPaseoCli, startTestDaemon } from "./helpers/test-daemon.ts";
|
||||
import { $ } from "zx";
|
||||
import { mkdtemp, rm } from "fs/promises";
|
||||
import { tmpdir } from "os";
|
||||
@@ -129,6 +130,28 @@ try {
|
||||
assert(!output.includes("error: option"), "should not have option parsing error");
|
||||
console.log("✓ -q (quiet) flag is accepted with stop\n");
|
||||
}
|
||||
|
||||
{
|
||||
console.log("Test 9: stop reports AGENT_NOT_FOUND for an unknown ID");
|
||||
const daemon = await startTestDaemon();
|
||||
try {
|
||||
const result = await runPaseoCli(daemon, [
|
||||
"agent",
|
||||
"stop",
|
||||
"does-not-exist",
|
||||
"--host",
|
||||
`127.0.0.1:${daemon.port}`,
|
||||
"--json",
|
||||
]);
|
||||
assert.notStrictEqual(result.exitCode, 0, "stop should fail for an unknown ID");
|
||||
const { error } = JSON.parse(result.stderr);
|
||||
assert.strictEqual(error.code, "AGENT_NOT_FOUND", result.stderr);
|
||||
assert.match(error.details, /paseo ls/);
|
||||
} finally {
|
||||
await daemon.stop();
|
||||
}
|
||||
console.log("✓ stop reports AGENT_NOT_FOUND for an unknown ID\n");
|
||||
}
|
||||
} finally {
|
||||
// Clean up temp directory
|
||||
await rm(paseoHome, { recursive: true, force: true });
|
||||
|
||||
@@ -13,6 +13,7 @@
|
||||
import assert from "node:assert";
|
||||
import { runLocalPaseo } from "./helpers/local-cli.ts";
|
||||
import { getAvailablePort } from "./helpers/network.ts";
|
||||
import { runPaseoCli, startTestDaemon } from "./helpers/test-daemon.ts";
|
||||
import { mkdtemp, rm } from "fs/promises";
|
||||
import { tmpdir } from "os";
|
||||
import { join } from "path";
|
||||
@@ -112,6 +113,28 @@ try {
|
||||
assert(!output.includes("error: option"), "should not have option parsing error");
|
||||
console.log("✓ -q (quiet) flag is accepted with delete\n");
|
||||
}
|
||||
|
||||
{
|
||||
console.log("Test 9: delete reports AGENT_NOT_FOUND for an unknown ID");
|
||||
const daemon = await startTestDaemon();
|
||||
try {
|
||||
const result = await runPaseoCli(daemon, [
|
||||
"agent",
|
||||
"delete",
|
||||
"does-not-exist",
|
||||
"--host",
|
||||
`127.0.0.1:${daemon.port}`,
|
||||
"--json",
|
||||
]);
|
||||
assert.notStrictEqual(result.exitCode, 0, "delete should fail for an unknown ID");
|
||||
const { error } = JSON.parse(result.stderr);
|
||||
assert.strictEqual(error.code, "AGENT_NOT_FOUND", result.stderr);
|
||||
assert.match(error.details, /paseo ls/);
|
||||
} finally {
|
||||
await daemon.stop();
|
||||
}
|
||||
console.log("✓ delete reports AGENT_NOT_FOUND for an unknown ID\n");
|
||||
}
|
||||
} finally {
|
||||
await rm(paseoHome, { recursive: true, force: true });
|
||||
}
|
||||
|
||||
@@ -5034,6 +5034,7 @@ test("setAgentThinkingOption surfaces a failed state read and keeps the previous
|
||||
|
||||
test("session config drift events update state through the stream channel", async () => {
|
||||
const workdir = mkdtempSync(join(tmpdir(), "agent-manager-session-config-events-"));
|
||||
const storage = new AgentStorage(join(workdir, "agents"), logger);
|
||||
let capturedSession: TestAgentSession | null = null;
|
||||
class ConfigEventClient extends TestAgentClient {
|
||||
override async createSession(config: AgentSessionConfig): Promise<AgentSession> {
|
||||
@@ -5046,6 +5047,7 @@ test("session config drift events update state through the stream channel", asyn
|
||||
clients: {
|
||||
codex: new ConfigEventClient(),
|
||||
},
|
||||
registry: storage,
|
||||
logger,
|
||||
idFactory: () => "00000000-0000-4000-8000-000000000133",
|
||||
});
|
||||
@@ -5100,6 +5102,7 @@ test("session config drift events update state through the stream channel", asyn
|
||||
|
||||
const agent = manager.getAgent(snapshot.id);
|
||||
expect(agent?.currentModeId).toBe("build");
|
||||
expect(agent?.config.modeId).toBe("build");
|
||||
expect(agent?.config.thinkingOptionId).toBe("high");
|
||||
expect(agent?.availableModes).toEqual([
|
||||
{ id: "plan", label: "Plan" },
|
||||
@@ -5111,6 +5114,10 @@ test("session config drift events update state through the stream channel", asyn
|
||||
thinkingOptionId: "high",
|
||||
});
|
||||
expect(streams.map((event) => event.type)).toEqual([]);
|
||||
|
||||
const persisted = await storage.get(snapshot.id);
|
||||
expect(persisted?.lastModeId).toBe("build");
|
||||
expect(persisted?.config?.modeId).toBe("build");
|
||||
});
|
||||
|
||||
test("setLabels merges and persists labels", async () => {
|
||||
@@ -9287,6 +9294,7 @@ test("respondToPermission updates currentModeId after plan approval", async () =
|
||||
class PlanModeTestClient implements AgentClient {
|
||||
readonly provider = "codex" as const;
|
||||
readonly capabilities = TEST_CAPABILITIES;
|
||||
resumedModeId: string | null | undefined;
|
||||
|
||||
async isAvailable(): Promise<boolean> {
|
||||
return true;
|
||||
@@ -9296,14 +9304,19 @@ test("respondToPermission updates currentModeId after plan approval", async () =
|
||||
return new PlanModeTestSession();
|
||||
}
|
||||
|
||||
async resumeSession(): Promise<AgentSession> {
|
||||
async resumeSession(
|
||||
_handle: AgentPersistenceHandle,
|
||||
overrides?: Partial<AgentSessionConfig>,
|
||||
): Promise<AgentSession> {
|
||||
this.resumedModeId = overrides?.modeId;
|
||||
return new PlanModeTestSession();
|
||||
}
|
||||
}
|
||||
|
||||
const client = new PlanModeTestClient();
|
||||
const manager = new AgentManager({
|
||||
clients: {
|
||||
codex: new PlanModeTestClient(),
|
||||
codex: client,
|
||||
},
|
||||
registry: storage,
|
||||
logger,
|
||||
@@ -9347,6 +9360,13 @@ test("respondToPermission updates currentModeId after plan approval", async () =
|
||||
await manager.flush();
|
||||
const persisted = await storage.get(snapshot.id);
|
||||
expect(persisted?.lastModeId).toBe("acceptEdits");
|
||||
|
||||
// The provider-managed switch must also reach config.modeId — otherwise a
|
||||
// reload resumes the session with the stale creation-time mode ("plan").
|
||||
expect(persisted?.config?.modeId).toBe("acceptEdits");
|
||||
const reloaded = await manager.reloadAgentSession(snapshot.id);
|
||||
expect(reloaded.config.modeId).toBe("acceptEdits");
|
||||
expect(client.resumedModeId).toBe("acceptEdits");
|
||||
});
|
||||
|
||||
test("respondToPermission refreshes features and runtime info after provider-managed plan approval", async () => {
|
||||
|
||||
@@ -190,10 +190,13 @@ function buildStoredAgentConfig(record: StoredAgentRecord): AgentSessionConfig {
|
||||
provider: record.provider,
|
||||
cwd: record.cwd,
|
||||
};
|
||||
// lastModeId is the last live mode — it also covers provider-side switches
|
||||
// that never reach record.config.modeId.
|
||||
const modeId = record.lastModeId ?? record.config?.modeId;
|
||||
if (modeId != null) config.modeId = modeId;
|
||||
if (!record.config) {
|
||||
return config;
|
||||
}
|
||||
if (record.config.modeId != null) config.modeId = record.config.modeId;
|
||||
if (record.config.model != null) config.model = record.config.model;
|
||||
if (record.config.thinkingOptionId != null) {
|
||||
config.thinkingOptionId = record.config.thinkingOptionId;
|
||||
@@ -3914,6 +3917,19 @@ export class AgentManager {
|
||||
return this.registry;
|
||||
}
|
||||
|
||||
/**
|
||||
* Provider-side mode switches (ACP current_mode_update, in-session
|
||||
* commands, permission-driven transitions) must land in config.modeId too —
|
||||
* reloadAgentSession and the persisted record derive the resumed session's
|
||||
* mode from it, so leaving it stale silently downgrades the mode on resume.
|
||||
*/
|
||||
private applyObservedMode(agent: ActiveManagedAgent, modeId: string | null): void {
|
||||
agent.currentModeId = modeId;
|
||||
if (modeId != null) {
|
||||
agent.config.modeId = modeId;
|
||||
}
|
||||
}
|
||||
|
||||
private async refreshSessionState(
|
||||
agent: ActiveManagedAgent,
|
||||
options?: { emit?: boolean },
|
||||
@@ -3926,7 +3942,7 @@ export class AgentManager {
|
||||
}
|
||||
|
||||
try {
|
||||
agent.currentModeId = await agent.session.getCurrentMode();
|
||||
this.applyObservedMode(agent, await agent.session.getCurrentMode());
|
||||
} catch {
|
||||
agent.currentModeId = null;
|
||||
}
|
||||
@@ -4306,7 +4322,7 @@ export class AgentManager {
|
||||
this.emitState(agent);
|
||||
return undefined;
|
||||
case "mode_changed":
|
||||
agent.currentModeId = event.currentModeId;
|
||||
this.applyObservedMode(agent, event.currentModeId);
|
||||
agent.availableModes = event.availableModes;
|
||||
if (agent.runtimeInfo) {
|
||||
agent.runtimeInfo = { ...agent.runtimeInfo, modeId: event.currentModeId };
|
||||
@@ -4322,7 +4338,7 @@ export class AgentManager {
|
||||
agent.cwd,
|
||||
);
|
||||
}
|
||||
agent.currentModeId = event.runtimeInfo.modeId ?? agent.currentModeId;
|
||||
this.applyObservedMode(agent, event.runtimeInfo.modeId ?? agent.currentModeId);
|
||||
flags.shouldDispatchEvent = false;
|
||||
this.emitState(agent);
|
||||
return undefined;
|
||||
|
||||
@@ -3,7 +3,7 @@ import { describe, expect, test } from "vitest";
|
||||
import { limitAgentTimelineItemContent } from "./agent-timeline-content.js";
|
||||
|
||||
describe("agent timeline content", () => {
|
||||
test("limits terminal input to the tool-call content budget", () => {
|
||||
test("marks truncated plain-text tool content within the content budget", () => {
|
||||
const oversizedInput = "x".repeat(64 * 1024 + 1);
|
||||
|
||||
const item = limitAgentTimelineItemContent({
|
||||
@@ -19,6 +19,7 @@ describe("agent timeline content", () => {
|
||||
},
|
||||
});
|
||||
|
||||
expect(limitAgentTimelineItemContent(item)).toEqual(item);
|
||||
expect(item).toEqual({
|
||||
type: "tool_call",
|
||||
callId: "terminal-session-4242",
|
||||
@@ -27,7 +28,7 @@ describe("agent timeline content", () => {
|
||||
error: null,
|
||||
detail: {
|
||||
type: "plain_text",
|
||||
text: "x".repeat(64 * 1024),
|
||||
text: "x".repeat(64 * 1024 - "\n\n[Content truncated]".length) + "\n\n[Content truncated]",
|
||||
icon: "square_terminal",
|
||||
},
|
||||
});
|
||||
|
||||
@@ -42,11 +42,12 @@ function limitPlainText(item: AgentTimelineItem): AgentTimelineItem {
|
||||
) {
|
||||
return item;
|
||||
}
|
||||
const notice = "\n\n[Content truncated]";
|
||||
return {
|
||||
...item,
|
||||
detail: {
|
||||
...item.detail,
|
||||
text: item.detail.text.slice(0, TOOL_CALL_CONTENT_MAX_LENGTH),
|
||||
text: item.detail.text.slice(0, TOOL_CALL_CONTENT_MAX_LENGTH - notice.length) + notice,
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
@@ -806,7 +806,6 @@ function createPaseoWorktreeForMcpTest(options: {
|
||||
emit: () => {},
|
||||
sessionLogger: createTestLogger(),
|
||||
terminalManager: null,
|
||||
archiveWorkspaceRecord: async () => {},
|
||||
serviceProxy: null,
|
||||
scriptRuntimeStore: null,
|
||||
getDaemonTcpPort: null,
|
||||
|
||||
@@ -825,6 +825,46 @@ describe("mapACPUsage", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("ACP context-window usage", () => {
|
||||
async function emitUsageUpdate(update: {
|
||||
used: number;
|
||||
size: number;
|
||||
}): Promise<{ events: unknown[] }> {
|
||||
const session = createSessionWithConfig({ provider: "dsh" });
|
||||
asInternals<ACPSessionInternals>(session).sessionId = "session-1";
|
||||
const events: unknown[] = [];
|
||||
session.subscribe((event) => {
|
||||
if (event.type === "usage_updated") events.push(event);
|
||||
});
|
||||
await session.sessionUpdate({
|
||||
sessionId: "session-1",
|
||||
update: { sessionUpdate: "usage_update", used: update.used, size: update.size },
|
||||
});
|
||||
return { events };
|
||||
}
|
||||
|
||||
test("forwards usage_update as context-window usage state", async () => {
|
||||
const { events } = await emitUsageUpdate({ used: 13_759, size: 1_000_000 });
|
||||
|
||||
expect(events).toEqual([
|
||||
{
|
||||
type: "usage_updated",
|
||||
provider: "dsh",
|
||||
usage: { contextWindowMaxTokens: 1_000_000, contextWindowUsedTokens: 13_759 },
|
||||
},
|
||||
]);
|
||||
});
|
||||
|
||||
test("emits nothing when size and used cannot both drive a meter", async () => {
|
||||
await expect(
|
||||
emitUsageUpdate({ used: -1, size: 0 }).then((result) => result.events),
|
||||
).resolves.toEqual([]);
|
||||
await expect(
|
||||
emitUsageUpdate({ used: 13_759, size: 0 }).then((result) => result.events),
|
||||
).resolves.toEqual([]);
|
||||
});
|
||||
});
|
||||
|
||||
describe("deriveModesFromACP", () => {
|
||||
test("prefers explicit ACP mode state", () => {
|
||||
const result = deriveModesFromACP(
|
||||
|
||||
@@ -2455,10 +2455,7 @@ export class ACPAgentSession implements AgentSession, ACPClient {
|
||||
return;
|
||||
}
|
||||
|
||||
for (const pending of this.pendingPermissions.values()) {
|
||||
pending.resolve({ outcome: { outcome: "cancelled" } });
|
||||
}
|
||||
this.pendingPermissions.clear();
|
||||
this.cancelPendingPermissions();
|
||||
|
||||
if (this.activeForegroundTurnId) {
|
||||
await this.connection.cancel({ sessionId: this.sessionId });
|
||||
@@ -2474,10 +2471,7 @@ export class ACPAgentSession implements AgentSession, ACPClient {
|
||||
this.deliverTranslatedEvents(this.flushPendingUserMessage());
|
||||
this.settleCommandsReady();
|
||||
|
||||
for (const pending of this.pendingPermissions.values()) {
|
||||
pending.resolve({ outcome: { outcome: "cancelled" } });
|
||||
}
|
||||
this.pendingPermissions.clear();
|
||||
this.cancelPendingPermissions();
|
||||
|
||||
if (this.connection && this.sessionId) {
|
||||
try {
|
||||
@@ -3178,8 +3172,29 @@ export class ACPAgentSession implements AgentSession, ACPClient {
|
||||
}
|
||||
}
|
||||
|
||||
// ACP reports context occupancy out of band from the prompt response, so the
|
||||
// composer's context meter cannot read it from `turn_completed`. Forward it as
|
||||
// the same `usage_updated` snapshot the native adapters emit, preserving the
|
||||
// turn usage this session already recorded. The guards match the meter's own
|
||||
// validity rules, so a provider cannot push a window the meter would reject.
|
||||
private handleUsageUpdate(update: UsageUpdate): void {
|
||||
void update;
|
||||
const contextWindowMaxTokens =
|
||||
Number.isFinite(update.size) && update.size > 0 ? update.size : undefined;
|
||||
const contextWindowUsedTokens =
|
||||
Number.isFinite(update.used) && update.used >= 0 ? update.used : undefined;
|
||||
if (contextWindowMaxTokens === undefined || contextWindowUsedTokens === undefined) {
|
||||
return;
|
||||
}
|
||||
this.pushEvent({
|
||||
type: "usage_updated",
|
||||
provider: this.provider,
|
||||
usage: {
|
||||
...this.currentTurnUsage,
|
||||
contextWindowMaxTokens,
|
||||
contextWindowUsedTokens,
|
||||
},
|
||||
turnId: this.activeForegroundTurnId ?? undefined,
|
||||
});
|
||||
}
|
||||
|
||||
private handlePromptResponse(response: PromptResponse, turnId: string): void {
|
||||
@@ -3277,6 +3292,11 @@ export class ACPAgentSession implements AgentSession, ACPClient {
|
||||
event: Extract<AgentStreamEvent, { type: "turn_completed" | "turn_failed" | "turn_canceled" }>,
|
||||
): void {
|
||||
this.deliverTranslatedEvents(this.flushPendingUserMessage());
|
||||
// A turn that ends without completing leaves no way to answer its open
|
||||
// permission requests, so tell the agent they were cancelled.
|
||||
if (event.type !== "turn_completed") {
|
||||
this.cancelPendingPermissions();
|
||||
}
|
||||
this.activeForegroundTurnId = null;
|
||||
this.fallbackAssistantMessageId = null;
|
||||
if (this.submittedUserMessageTurnId === event.turnId) {
|
||||
@@ -3285,6 +3305,13 @@ export class ACPAgentSession implements AgentSession, ACPClient {
|
||||
this.pushEvent(event);
|
||||
}
|
||||
|
||||
private cancelPendingPermissions(): void {
|
||||
for (const pending of this.pendingPermissions.values()) {
|
||||
pending.resolve({ outcome: { outcome: "cancelled" } });
|
||||
}
|
||||
this.pendingPermissions.clear();
|
||||
}
|
||||
|
||||
private emitBootstrapThreadEvent(): void {
|
||||
if (!this.bootstrapThreadEventPending || !this.sessionId) {
|
||||
return;
|
||||
|
||||
@@ -314,6 +314,127 @@ describe("background Claude subagents", () => {
|
||||
});
|
||||
});
|
||||
|
||||
test("keeps the Task card labeled when the child's frames arrive after its launch result", async () => {
|
||||
// Claude Code answers a background Agent call at once ("Agent launched") and only then streams
|
||||
// the child's frames, so they arrive after the parent's tool call has its result.
|
||||
queryFactory.mockImplementation(() =>
|
||||
buildQueryMock([
|
||||
{ type: "system", subtype: "init", session_id: "bg-session", permissionMode: "default" },
|
||||
{
|
||||
type: "assistant",
|
||||
message: {
|
||||
model: "claude-haiku-4-5",
|
||||
content: [
|
||||
{
|
||||
type: "tool_use",
|
||||
id: "toolu_background",
|
||||
name: "Agent",
|
||||
input: {
|
||||
subagent_type: "general-purpose",
|
||||
description: "Count files here",
|
||||
prompt: "Run ls and reply with the number of entries.",
|
||||
},
|
||||
},
|
||||
],
|
||||
},
|
||||
},
|
||||
{
|
||||
type: "system",
|
||||
subtype: "task_started",
|
||||
task_id: "bg-task",
|
||||
tool_use_id: "toolu_background",
|
||||
task_type: "local_agent",
|
||||
subagent_type: "general-purpose",
|
||||
description: "Count files here",
|
||||
prompt: "Run ls and reply with the number of entries.",
|
||||
},
|
||||
{
|
||||
type: "user",
|
||||
message: {
|
||||
role: "user",
|
||||
content: [
|
||||
{
|
||||
type: "tool_result",
|
||||
tool_use_id: "toolu_background",
|
||||
content: "Async agent launched successfully.",
|
||||
},
|
||||
],
|
||||
},
|
||||
},
|
||||
{
|
||||
type: "assistant",
|
||||
parent_tool_use_id: "toolu_background",
|
||||
message: {
|
||||
model: "claude-haiku-4-5",
|
||||
content: [
|
||||
{
|
||||
type: "tool_use",
|
||||
id: "toolu_ls",
|
||||
name: "Bash",
|
||||
input: { command: "ls -1", description: "List files" },
|
||||
},
|
||||
],
|
||||
},
|
||||
},
|
||||
{
|
||||
type: "user",
|
||||
parent_tool_use_id: "toolu_background",
|
||||
message: {
|
||||
role: "user",
|
||||
content: [{ type: "tool_result", tool_use_id: "toolu_ls", content: "a\nb\nc" }],
|
||||
},
|
||||
},
|
||||
{
|
||||
type: "assistant",
|
||||
parent_tool_use_id: "toolu_background",
|
||||
message: { model: "claude-haiku-4-5", content: [{ type: "text", text: "3" }] },
|
||||
},
|
||||
{
|
||||
type: "system",
|
||||
subtype: "task_updated",
|
||||
task_id: "bg-task",
|
||||
patch: { status: "completed" },
|
||||
},
|
||||
{
|
||||
type: "system",
|
||||
subtype: "task_notification",
|
||||
task_id: "bg-task",
|
||||
tool_use_id: "toolu_background",
|
||||
status: "completed",
|
||||
},
|
||||
{ type: "result", subtype: "success", usage: {}, total_cost_usd: 0 },
|
||||
]),
|
||||
);
|
||||
const session = await new ClaudeAgentClient({
|
||||
logger: createTestLogger(),
|
||||
queryFactory,
|
||||
resolveBinary: async () => "/test/claude/bin",
|
||||
}).createSession({ provider: "claude", cwd: process.cwd() });
|
||||
const events = await collectUntilTerminal(streamSession(session, "delegate work"));
|
||||
await session.close();
|
||||
|
||||
const rows: AgentTimelineRow[] = events
|
||||
.filter((event) => event.type === "timeline")
|
||||
.map((event, index) => ({
|
||||
seq: index + 1,
|
||||
timestamp: new Date(Date.UTC(2026, 9, 4, 0, 0, index)).toISOString(),
|
||||
item: event.item,
|
||||
}));
|
||||
const cards = projectTimelineRows({ rows, mode: "projected" })
|
||||
.map((entry) => entry.item)
|
||||
.filter((item) => item.type === "tool_call" && item.callId === "toolu_background");
|
||||
|
||||
expect(cards).toHaveLength(1);
|
||||
expect(cards[0]).toMatchObject({
|
||||
status: "completed",
|
||||
detail: {
|
||||
type: "sub_agent",
|
||||
subAgentType: "general-purpose",
|
||||
description: "Count files here",
|
||||
},
|
||||
});
|
||||
});
|
||||
|
||||
test.each([
|
||||
{
|
||||
source: "system task protocol",
|
||||
|
||||
@@ -1009,7 +1009,7 @@ describe("ClaudeAgentSession features", () => {
|
||||
|
||||
expect(queryFactory.mock.calls[0]?.[0].options).toMatchObject({
|
||||
effort: "xhigh",
|
||||
thinking: { type: "adaptive" },
|
||||
thinking: { type: "adaptive", display: "summarized" },
|
||||
settings: { ultracode: true },
|
||||
});
|
||||
|
||||
@@ -1223,7 +1223,7 @@ describe("ClaudeAgentSession features", () => {
|
||||
|
||||
test.each([
|
||||
["supported model", "claude-opus-4-8", { type: "disabled" }, undefined],
|
||||
["unsupported model", "claude-fable-5", { type: "adaptive" }, "high"],
|
||||
["unsupported model", "claude-fable-5", { type: "adaptive", display: "summarized" }, "high"],
|
||||
["custom model", "openrouter/anthropic/claude-opus-4-8", undefined, undefined],
|
||||
["provider default", null, undefined, undefined],
|
||||
])("reconciles Off when switching to a %s", async (_label, modelId, thinking, effort) => {
|
||||
@@ -3069,6 +3069,44 @@ describe("ClaudeAgentSession context window usage", () => {
|
||||
}
|
||||
});
|
||||
|
||||
test("reports the plan mode Claude enters on its own with EnterPlanMode", async () => {
|
||||
// Claude Code announces a mode it switched to itself as a status message
|
||||
// carrying the new permissionMode, right after the EnterPlanMode tool call.
|
||||
const client = new ClaudeAgentClient({
|
||||
logger,
|
||||
queryFactory: createQueryFactoryForTurns([
|
||||
[
|
||||
{ ...createInitMessage(), permissionMode: "acceptEdits" },
|
||||
{
|
||||
type: "system",
|
||||
subtype: "status",
|
||||
status: null,
|
||||
permissionMode: "plan",
|
||||
session_id: "session-1",
|
||||
},
|
||||
createSuccessResult(),
|
||||
],
|
||||
]),
|
||||
resolveBinary: async () => "/test/claude/bin",
|
||||
});
|
||||
const session = await client.createSession({
|
||||
provider: "claude",
|
||||
cwd: process.cwd(),
|
||||
modeId: "acceptEdits",
|
||||
});
|
||||
|
||||
try {
|
||||
const events = await collectStreamEvents(session, "enter plan mode");
|
||||
|
||||
expect(events).toContainEqual(
|
||||
expect.objectContaining({ type: "mode_changed", currentModeId: "plan" }),
|
||||
);
|
||||
expect(await session.getCurrentMode()).toBe("plan");
|
||||
} finally {
|
||||
await session.close();
|
||||
}
|
||||
});
|
||||
|
||||
test("a compaction abandoned mid-turn does not suppress the next compaction marker", async () => {
|
||||
// The first turn starts compacting and then ends without ever reaching a
|
||||
// compact_boundary, so the marker it opened is never resolved.
|
||||
|
||||
@@ -2092,7 +2092,11 @@ class ClaudeAgentSession implements AgentSession {
|
||||
// identity and status from frames for them. Detecting the capability beats comparing version
|
||||
// strings: it reacts to what this session actually does.
|
||||
isDescriptorOwnedElsewhere: () => this.taskProtocolSource.isActive,
|
||||
// The parent's tool call owns its card once its result arrives. A background child streams
|
||||
// its frames after Claude has already answered the call, and re-emitting the card from them
|
||||
// would replace the settled card with an unlabeled, running one.
|
||||
needsSyntheticParentToolCard: (toolUseId) =>
|
||||
this.toolUseCache.has(toolUseId) &&
|
||||
this.taskProtocolSource.needsSyntheticParentToolCard(toolUseId),
|
||||
});
|
||||
private persistedHistory: PersistedTimelineEntry[] = [];
|
||||
@@ -3244,10 +3248,18 @@ class ClaudeAgentSession implements AgentSession {
|
||||
return { thinking: { type: "disabled" }, effort: undefined, ultracode: false };
|
||||
}
|
||||
if (thinkingOptionId === CLAUDE_ULTRACODE_THINKING_OPTION_ID) {
|
||||
return { thinking: { type: "adaptive" }, effort: "xhigh", ultracode: true };
|
||||
return {
|
||||
thinking: { type: "adaptive", display: "summarized" },
|
||||
effort: "xhigh",
|
||||
ultracode: true,
|
||||
};
|
||||
}
|
||||
if (thinkingOptionId && isClaudeThinkingEffort(thinkingOptionId)) {
|
||||
return { thinking: { type: "adaptive" }, effort: thinkingOptionId, ultracode: false };
|
||||
return {
|
||||
thinking: { type: "adaptive", display: "summarized" },
|
||||
effort: thinkingOptionId,
|
||||
ultracode: false,
|
||||
};
|
||||
}
|
||||
return { thinking: undefined, effort: undefined, ultracode: false };
|
||||
}
|
||||
@@ -4309,6 +4321,19 @@ class ClaudeAgentSession implements AgentSession {
|
||||
return;
|
||||
}
|
||||
if (message.subtype === "status") {
|
||||
// Claude Code reports a mode it switched to on its own, such as entering
|
||||
// plan mode with the EnterPlanMode tool, through the status message.
|
||||
if (
|
||||
isPermissionMode(message.permissionMode) &&
|
||||
this.observePermissionMode(message.permissionMode)
|
||||
) {
|
||||
events.push({
|
||||
type: "mode_changed",
|
||||
provider: "claude",
|
||||
currentModeId: this.currentMode,
|
||||
availableModes: this.availableModes,
|
||||
});
|
||||
}
|
||||
const status = toObjectRecord(message)?.status;
|
||||
if (status === "compacting") {
|
||||
this.compacting = true;
|
||||
@@ -4620,10 +4645,7 @@ class ClaudeAgentSession implements AgentSession {
|
||||
notice = this.createClaudeSessionChangedNotice(existingSessionId, newSessionId);
|
||||
}
|
||||
this.availableModes = DEFAULT_MODES;
|
||||
this.currentMode = message.permissionMode;
|
||||
if (this.currentMode !== "plan") {
|
||||
this.planResumeMode = this.currentMode;
|
||||
}
|
||||
this.observePermissionMode(message.permissionMode);
|
||||
this.persistence = null;
|
||||
if (message.model) {
|
||||
const normalizedRuntimeModel = normalizeClaudeRuntimeModelId(message.model);
|
||||
@@ -4642,6 +4664,16 @@ class ClaudeAgentSession implements AgentSession {
|
||||
return { threadStartedSessionId, notice };
|
||||
}
|
||||
|
||||
/** Records a mode Claude Code reports, returning whether it differs from the current one. */
|
||||
private observePermissionMode(mode: PermissionMode): boolean {
|
||||
const changed = this.currentMode !== mode;
|
||||
this.currentMode = mode;
|
||||
if (mode !== "plan") {
|
||||
this.planResumeMode = mode;
|
||||
}
|
||||
return changed;
|
||||
}
|
||||
|
||||
private readMissingResumedConversationError(message: SDKMessage): string | null {
|
||||
if (message.type !== "result" || message.subtype !== "error_during_execution") {
|
||||
return null;
|
||||
|
||||
+1
-123
@@ -2,7 +2,7 @@ import { describe, expect, test, vi } from "vitest";
|
||||
import { execFileSync } from "node:child_process";
|
||||
import os from "node:os";
|
||||
import path from "node:path";
|
||||
import { createServer, type ServerResponse } from "node:http";
|
||||
import { createServer } from "node:http";
|
||||
import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
||||
import { once } from "node:events";
|
||||
|
||||
@@ -171,62 +171,6 @@ async function startMockResponsesServer(sequence: string[]): Promise<{
|
||||
};
|
||||
}
|
||||
|
||||
async function startHeldFirstResponseServer(): Promise<{
|
||||
url: string;
|
||||
requestBodies: string[];
|
||||
releaseFirstResponse: () => void;
|
||||
close: () => Promise<void>;
|
||||
}> {
|
||||
const requestBodies: string[] = [];
|
||||
let heldResponse: ServerResponse | null = null;
|
||||
const reply = (res: ServerResponse) => {
|
||||
res.statusCode = 200;
|
||||
res.setHeader("content-type", "text/event-stream");
|
||||
res.end(assistantMessageSse("done"));
|
||||
};
|
||||
const server = createServer((req, res) => {
|
||||
const chunks: Buffer[] = [];
|
||||
req.on("data", (chunk) => chunks.push(Buffer.from(chunk)));
|
||||
req.on("end", () => {
|
||||
if (req.method !== "POST" || req.url !== "/v1/responses") {
|
||||
res.statusCode = 404;
|
||||
res.end("not found");
|
||||
return;
|
||||
}
|
||||
requestBodies.push(Buffer.concat(chunks).toString("utf8"));
|
||||
if (requestBodies.length === 1) {
|
||||
heldResponse = res;
|
||||
} else {
|
||||
reply(res);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
server.listen(0, "127.0.0.1");
|
||||
await once(server, "listening");
|
||||
const address = server.address();
|
||||
if (!address || typeof address === "string") {
|
||||
throw new Error("Expected TCP address for mock responses server");
|
||||
}
|
||||
return {
|
||||
url: `http://127.0.0.1:${address.port}`,
|
||||
requestBodies,
|
||||
releaseFirstResponse: () => {
|
||||
if (!heldResponse) throw new Error("No held response to release");
|
||||
reply(heldResponse);
|
||||
heldResponse = null;
|
||||
},
|
||||
close: () =>
|
||||
new Promise<void>((resolve, reject) => {
|
||||
server.closeAllConnections();
|
||||
server.close((error) => {
|
||||
if (error) reject(error);
|
||||
else resolve();
|
||||
});
|
||||
}),
|
||||
};
|
||||
}
|
||||
|
||||
function writeMockCodexConfig(codexHome: string, serverUrl: string): void {
|
||||
writeFileSync(
|
||||
path.join(codexHome, "config.toml"),
|
||||
@@ -273,72 +217,6 @@ function waitForEvent<TEvent extends AgentStreamEvent>(params: {
|
||||
}
|
||||
|
||||
describe("Codex app-server provider (local e2e)", () => {
|
||||
test.runIf(isCodexInstalled())(
|
||||
"rewinding a steer message keeps the earlier prompt of its turn in model context",
|
||||
async () => {
|
||||
const cwd = mkdtempSync(path.join(os.tmpdir(), "codex-steer-rewind-cwd-"));
|
||||
const codexHome = mkdtempSync(path.join(os.tmpdir(), "codex-steer-rewind-home-"));
|
||||
const mockServer = await startHeldFirstResponseServer();
|
||||
|
||||
try {
|
||||
writeMockCodexConfig(codexHome, mockServer.url);
|
||||
const client = new CodexAppServerAgentClient(createTestLogger());
|
||||
const session = await client.createSession(
|
||||
{ provider: "codex", cwd, modeId: "auto", model: "mock-model" },
|
||||
{ env: { CODEX_HOME: codexHome } },
|
||||
);
|
||||
|
||||
try {
|
||||
const userMessageIds = new Map<string, string>();
|
||||
session.subscribe((event) => {
|
||||
if (
|
||||
event.type === "timeline" &&
|
||||
event.item.type === "user_message" &&
|
||||
event.item.messageId
|
||||
) {
|
||||
userMessageIds.set(event.item.text, event.item.messageId);
|
||||
}
|
||||
});
|
||||
const turnFinished = waitForEvent({
|
||||
session,
|
||||
timeoutMs: 15_000,
|
||||
label: "turn completion",
|
||||
predicate: (event): event is Extract<AgentStreamEvent, { type: "turn_completed" }> =>
|
||||
event.type === "turn_completed",
|
||||
});
|
||||
|
||||
const started = await session.startTurn("ORIGINAL_PROMPT");
|
||||
await vi.waitFor(() => expect(mockServer.requestBodies).toHaveLength(1), {
|
||||
timeout: 15_000,
|
||||
});
|
||||
await expect(
|
||||
session.steerActiveTurn!("STEER_PROMPT", { expectedTurnId: started.turnId }),
|
||||
).resolves.toEqual({ status: "accepted" });
|
||||
mockServer.releaseFirstResponse();
|
||||
await turnFinished;
|
||||
|
||||
await vi.waitFor(() => expect(userMessageIds.get("STEER_PROMPT")).toBeDefined(), {
|
||||
timeout: 15_000,
|
||||
});
|
||||
await expect(
|
||||
session.revertConversation!({ messageId: userMessageIds.get("STEER_PROMPT")! }),
|
||||
).rejects.toThrow("Select the first message in the turn instead");
|
||||
|
||||
await session.run("AFTER_REWIND");
|
||||
expect(mockServer.requestBodies.at(-1)).toContain("AFTER_REWIND");
|
||||
expect(mockServer.requestBodies.at(-1)).toContain("ORIGINAL_PROMPT");
|
||||
} finally {
|
||||
await session.close();
|
||||
}
|
||||
} finally {
|
||||
await mockServer.close();
|
||||
rmSync(cwd, { recursive: true, force: true });
|
||||
rmSync(codexHome, { recursive: true, force: true });
|
||||
}
|
||||
},
|
||||
45_000,
|
||||
);
|
||||
|
||||
test.runIf(isCodexInstalled())(
|
||||
"reloads a persisted idle thread repeatedly without overlapping writers",
|
||||
async () => {
|
||||
|
||||
@@ -105,7 +105,10 @@ interface CollaborationModeRecord {
|
||||
}
|
||||
|
||||
interface CodexSessionTestAccess {
|
||||
codexUserMessages(): { messageId: string; turnId: string | null }[];
|
||||
codexUserMessageTurns(): {
|
||||
resolve(messageId: string): { index: number; turnId: string | null } | null;
|
||||
count(): number;
|
||||
};
|
||||
ensureThreadLoaded(): Promise<void>;
|
||||
handleToolApprovalRequest(params: unknown): Promise<unknown>;
|
||||
handleNotification(method: string, params: unknown): void;
|
||||
@@ -2200,60 +2203,6 @@ describe("Codex app-server provider", () => {
|
||||
await session.close();
|
||||
});
|
||||
|
||||
test.each(["legacy", "paginated"] as const)(
|
||||
"rejects rewinding a steer message in a %s thread before forking",
|
||||
async (historyMode) => {
|
||||
const appServer = createFakeCodexAppServer({
|
||||
"thread/read": () => ({ thread: { id: "thread-1", historyMode, turns: [] } }),
|
||||
"turn/steer": () => ({ turnId: "turn-first" }),
|
||||
});
|
||||
const session = new CodexAppServerAgentSession(
|
||||
createConfig({ cwd: "/workspace/project" }),
|
||||
null,
|
||||
createTestLogger(),
|
||||
async () => appServer.child,
|
||||
);
|
||||
|
||||
try {
|
||||
const started = await session.startTurn("original prompt");
|
||||
appServer.startsTurn({ threadId: "thread-1", turnId: "turn-first" });
|
||||
const originalMessage = waitForNextTimelineItem(session, "user_message");
|
||||
emitCodexUserMessage(appServer, {
|
||||
id: "codex-first",
|
||||
text: "original prompt",
|
||||
turnId: "turn-first",
|
||||
});
|
||||
await originalMessage;
|
||||
await expect(
|
||||
session.steerActiveTurn("steer prompt", { expectedTurnId: started.turnId }),
|
||||
).resolves.toEqual({ status: "accepted" });
|
||||
const steerMessage = waitForNextTimelineItem(session, "user_message");
|
||||
emitCodexUserMessage(appServer, {
|
||||
id: "codex-steer",
|
||||
text: "steer prompt",
|
||||
turnId: "turn-first",
|
||||
});
|
||||
await steerMessage;
|
||||
appServer.completeTurn();
|
||||
|
||||
await expect(session.revertConversation({ messageId: "codex-steer" })).rejects.toThrow(
|
||||
"Select the first message in the turn instead",
|
||||
);
|
||||
expect(appServer.requests().filter((request) => request.method === "thread/fork")).toEqual(
|
||||
[],
|
||||
);
|
||||
expect(appServer.recordedRollbacks).toEqual([]);
|
||||
expect(session.id).toBe("thread-1");
|
||||
|
||||
await session.revertConversation({ messageId: "codex-first" });
|
||||
expect(session.id).toBe("forked-thread");
|
||||
appServer.assertNoErrors();
|
||||
} finally {
|
||||
await session.close();
|
||||
}
|
||||
},
|
||||
);
|
||||
|
||||
test.each(["legacy", "paginated"] as const)(
|
||||
"rewinds a %s thread onto a fork that keeps the custom provider and runtime MCP servers",
|
||||
async (historyMode) => {
|
||||
@@ -4689,9 +4638,10 @@ describe("Codex app-server provider", () => {
|
||||
|
||||
await asInternals(session).loadPersistedHistory(session.client);
|
||||
|
||||
expect(asInternals(session).codexUserMessages()).toEqual([
|
||||
{ messageId: "message-history", turnId: "native-turn-1" },
|
||||
]);
|
||||
expect(asInternals(session).codexUserMessageTurns().resolve("message-history")).toEqual({
|
||||
index: 0,
|
||||
turnId: "native-turn-1",
|
||||
});
|
||||
});
|
||||
|
||||
test("loads mixed legacy and MultiAgentV2 sub-agent history", async () => {
|
||||
|
||||
@@ -91,7 +91,7 @@ import {
|
||||
type CodexThreadRollbackResponse,
|
||||
type CodexAppServerTraceContext,
|
||||
} from "./codex/app-server-transport.js";
|
||||
import { type CodexUserMessage, revertCodexConversation } from "./codex/rewind.js";
|
||||
import { type CodexUserMessageTurnIndex, revertCodexConversation } from "./codex/rewind.js";
|
||||
import {
|
||||
materializeProviderImage,
|
||||
renderProviderImageOutputAsAssistantMarkdown,
|
||||
@@ -4529,11 +4529,16 @@ export class CodexAppServerAgentSession implements AgentSession {
|
||||
});
|
||||
}
|
||||
|
||||
private codexUserMessages(): CodexUserMessage[] {
|
||||
return this.userMessageTurnIds.map((messageId) => ({
|
||||
messageId,
|
||||
turnId: this.userMessageProviderTurnIds.get(messageId) ?? null,
|
||||
}));
|
||||
private codexUserMessageTurns(): CodexUserMessageTurnIndex {
|
||||
return {
|
||||
resolve: (messageId) => {
|
||||
const index = this.userMessageTurnIndexes.get(messageId);
|
||||
return index === undefined
|
||||
? null
|
||||
: { index, turnId: this.userMessageProviderTurnIds.get(messageId) ?? null };
|
||||
},
|
||||
count: () => this.userMessageTurnIds.length,
|
||||
};
|
||||
}
|
||||
|
||||
subscribe(callback: (event: AgentStreamEvent) => void): () => void {
|
||||
@@ -4950,7 +4955,7 @@ export class CodexAppServerAgentSession implements AgentSession {
|
||||
model: this.config.model ?? null,
|
||||
serviceTier: this.serviceTier,
|
||||
config: this.buildCodexInnerConfig(),
|
||||
userMessages: this.codexUserMessages(),
|
||||
userMessageTurns: this.codexUserMessageTurns(),
|
||||
threadRollbackAvailable: this.threadRollbackAvailable,
|
||||
setThreadId: async (threadId) => {
|
||||
this.currentThreadId = threadId;
|
||||
|
||||
@@ -6,7 +6,11 @@ import type {
|
||||
CodexThreadRollbackParams,
|
||||
CodexThreadRollbackResponse,
|
||||
} from "./app-server-transport.js";
|
||||
import { type CodexRewindClient, revertCodexConversation } from "./rewind.js";
|
||||
import {
|
||||
type CodexUserMessageTurnIndex,
|
||||
type CodexRewindClient,
|
||||
revertCodexConversation,
|
||||
} from "./rewind.js";
|
||||
|
||||
class FakeCodex implements CodexRewindClient {
|
||||
readonly recordedForks: CodexThreadForkParams[] = [];
|
||||
@@ -55,13 +59,33 @@ class FakeCodex implements CodexRewindClient {
|
||||
}
|
||||
}
|
||||
|
||||
class CodexMessageTurns implements CodexUserMessageTurnIndex {
|
||||
constructor(
|
||||
private readonly indexesByMessageId: Map<string, number>,
|
||||
private readonly turnIdsByMessageId: Map<string, string> = new Map(),
|
||||
) {}
|
||||
|
||||
resolve(messageId: string): { index: number; turnId: string | null } | null {
|
||||
const index = this.indexesByMessageId.get(messageId);
|
||||
return index === undefined
|
||||
? null
|
||||
: { index, turnId: this.turnIdsByMessageId.get(messageId) ?? null };
|
||||
}
|
||||
|
||||
count(): number {
|
||||
return this.indexesByMessageId.size;
|
||||
}
|
||||
}
|
||||
|
||||
describe("Codex Rewind", () => {
|
||||
test("rewinds the conversation by forking the thread and rolling back past the native user message", async () => {
|
||||
const codex = new FakeCodex();
|
||||
const userMessages = [
|
||||
{ messageId: "codex-first", turnId: null },
|
||||
{ messageId: "codex-second", turnId: null },
|
||||
];
|
||||
const userMessageTurns = new CodexMessageTurns(
|
||||
new Map([
|
||||
["codex-first", 0],
|
||||
["codex-second", 1],
|
||||
]),
|
||||
);
|
||||
let reboundThreadId: string | null = null;
|
||||
|
||||
await revertCodexConversation({
|
||||
@@ -71,7 +95,7 @@ describe("Codex Rewind", () => {
|
||||
cwd: "/workspace/project",
|
||||
model: "gpt-5.4-mini",
|
||||
serviceTier: null,
|
||||
userMessages,
|
||||
userMessageTurns,
|
||||
threadRollbackAvailable: true,
|
||||
setThreadId: (threadId) => {
|
||||
reboundThreadId = threadId;
|
||||
@@ -94,18 +118,20 @@ describe("Codex Rewind", () => {
|
||||
|
||||
test("rewinds the conversation using native user message ids hydrated from app-server history", async () => {
|
||||
const codex = new FakeCodex();
|
||||
const userMessages = [
|
||||
{ messageId: "codex-first", turnId: null },
|
||||
{ messageId: "codex-second", turnId: null },
|
||||
{ messageId: "codex-third", turnId: null },
|
||||
];
|
||||
const userMessageTurns = new CodexMessageTurns(
|
||||
new Map([
|
||||
["codex-first", 0],
|
||||
["codex-second", 1],
|
||||
["codex-third", 2],
|
||||
]),
|
||||
);
|
||||
let reboundThreadId: string | null = null;
|
||||
|
||||
await revertCodexConversation({
|
||||
client: codex,
|
||||
threadId: "source-thread",
|
||||
messageId: "codex-second",
|
||||
userMessages,
|
||||
userMessageTurns,
|
||||
threadRollbackAvailable: true,
|
||||
setThreadId: (threadId) => {
|
||||
reboundThreadId = threadId;
|
||||
@@ -131,10 +157,16 @@ describe("Codex Rewind", () => {
|
||||
}
|
||||
|
||||
const codex = new PaginatedCodex();
|
||||
const userMessages = [
|
||||
{ messageId: "codex-first", turnId: "turn-first" },
|
||||
{ messageId: "codex-second", turnId: "turn-second" },
|
||||
];
|
||||
const userMessageTurns = new CodexMessageTurns(
|
||||
new Map([
|
||||
["codex-first", 0],
|
||||
["codex-second", 1],
|
||||
]),
|
||||
new Map([
|
||||
["codex-first", "turn-first"],
|
||||
["codex-second", "turn-second"],
|
||||
]),
|
||||
);
|
||||
let reboundThreadId: string | null = null;
|
||||
|
||||
await revertCodexConversation({
|
||||
@@ -144,7 +176,7 @@ describe("Codex Rewind", () => {
|
||||
cwd: "/workspace/project",
|
||||
model: "gpt-5.4-mini",
|
||||
serviceTier: null,
|
||||
userMessages,
|
||||
userMessageTurns,
|
||||
threadRollbackAvailable: true,
|
||||
setThreadId: (threadId) => {
|
||||
reboundThreadId = threadId;
|
||||
@@ -177,7 +209,7 @@ describe("Codex Rewind", () => {
|
||||
}
|
||||
|
||||
const codex = new PaginatedCodex();
|
||||
const userMessages = [{ messageId: "codex-first", turnId: null }];
|
||||
const userMessageTurns = new CodexMessageTurns(new Map([["codex-first", 0]]));
|
||||
let reboundThreadId: string | null = null;
|
||||
|
||||
await expect(
|
||||
@@ -188,7 +220,7 @@ describe("Codex Rewind", () => {
|
||||
cwd: "/workspace/project",
|
||||
model: "gpt-5.4-mini",
|
||||
serviceTier: null,
|
||||
userMessages,
|
||||
userMessageTurns,
|
||||
threadRollbackAvailable: true,
|
||||
setThreadId: (threadId) => {
|
||||
reboundThreadId = threadId;
|
||||
@@ -203,14 +235,14 @@ describe("Codex Rewind", () => {
|
||||
|
||||
test("declines to rewind when the user message is not in the Codex thread", async () => {
|
||||
const codex = new FakeCodex();
|
||||
const userMessages = [{ messageId: "codex-first", turnId: null }];
|
||||
const userMessageTurns = new CodexMessageTurns(new Map([["codex-first", 0]]));
|
||||
|
||||
await expect(
|
||||
revertCodexConversation({
|
||||
client: codex,
|
||||
threadId: "source-thread",
|
||||
messageId: "missing-message",
|
||||
userMessages,
|
||||
userMessageTurns,
|
||||
threadRollbackAvailable: true,
|
||||
setThreadId: () => undefined,
|
||||
}),
|
||||
@@ -218,47 +250,4 @@ describe("Codex Rewind", () => {
|
||||
expect(codex.recordedForks).toEqual([]);
|
||||
expect(codex.recordedRollbacks).toEqual([]);
|
||||
});
|
||||
|
||||
test("rolls back whole turns when a later turn holds a steer message", async () => {
|
||||
const codex = new FakeCodex();
|
||||
|
||||
await revertCodexConversation({
|
||||
client: codex,
|
||||
threadId: "source-thread",
|
||||
messageId: "codex-second",
|
||||
userMessages: [
|
||||
{ messageId: "codex-first", turnId: "turn-first" },
|
||||
{ messageId: "codex-second", turnId: "turn-second" },
|
||||
{ messageId: "codex-steer", turnId: "turn-second" },
|
||||
],
|
||||
threadRollbackAvailable: true,
|
||||
setThreadId: () => undefined,
|
||||
});
|
||||
|
||||
expect(codex.recordedRollbacks).toEqual([{ threadId: "forked-thread", numTurns: 1 }]);
|
||||
});
|
||||
|
||||
test("declines to rewind a steer message without forking", async () => {
|
||||
const codex = new FakeCodex();
|
||||
let reboundThreadId: string | null = null;
|
||||
|
||||
await expect(
|
||||
revertCodexConversation({
|
||||
client: codex,
|
||||
threadId: "source-thread",
|
||||
messageId: "codex-steer",
|
||||
userMessages: [
|
||||
{ messageId: "codex-first", turnId: "turn-first" },
|
||||
{ messageId: "codex-steer", turnId: "turn-first" },
|
||||
],
|
||||
threadRollbackAvailable: true,
|
||||
setThreadId: (threadId) => {
|
||||
reboundThreadId = threadId;
|
||||
},
|
||||
}),
|
||||
).rejects.toThrow("Select the first message in the turn instead");
|
||||
expect(codex.recordedForks).toEqual([]);
|
||||
expect(codex.recordedRollbacks).toEqual([]);
|
||||
expect(reboundThreadId).toBeNull();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -15,9 +15,9 @@ export interface CodexRewindClient {
|
||||
request(method: string, params?: unknown, timeoutMs?: number): Promise<unknown>;
|
||||
}
|
||||
|
||||
export interface CodexUserMessage {
|
||||
messageId: string;
|
||||
turnId: string | null;
|
||||
export interface CodexUserMessageTurnIndex {
|
||||
resolve(messageId: string): { index: number; turnId: string | null } | null;
|
||||
count(): number;
|
||||
}
|
||||
|
||||
type CodexThreadHistoryMode = "legacy" | "paginated";
|
||||
@@ -60,12 +60,6 @@ async function rollbackCodexThread(
|
||||
return parseCodexThreadRollbackResponse(await client.request("thread/rollback", params));
|
||||
}
|
||||
|
||||
function countTurns(userMessages: readonly CodexUserMessage[]): number {
|
||||
return userMessages.filter(
|
||||
(message, index) => !message.turnId || message.turnId !== userMessages[index - 1]?.turnId,
|
||||
).length;
|
||||
}
|
||||
|
||||
export async function revertCodexConversation(input: {
|
||||
client: CodexRewindClient;
|
||||
threadId: string | null;
|
||||
@@ -74,7 +68,7 @@ export async function revertCodexConversation(input: {
|
||||
model?: string | null;
|
||||
serviceTier?: string | null;
|
||||
config?: Record<string, unknown> | null;
|
||||
userMessages: readonly CodexUserMessage[];
|
||||
userMessageTurns: CodexUserMessageTurnIndex;
|
||||
threadRollbackAvailable: boolean;
|
||||
setThreadId: (threadId: string) => void | Promise<void>;
|
||||
}): Promise<void> {
|
||||
@@ -82,21 +76,16 @@ export async function revertCodexConversation(input: {
|
||||
throw new Error("Codex thread is not ready for rewind");
|
||||
}
|
||||
|
||||
const targetIndex = input.userMessages.findIndex(
|
||||
(message) => message.messageId === input.messageId,
|
||||
);
|
||||
if (targetIndex === -1) {
|
||||
const targetTurn = input.userMessageTurns.resolve(input.messageId);
|
||||
if (targetTurn === null) {
|
||||
throw new Error(`Codex could not find user message ${input.messageId} in the current thread`);
|
||||
}
|
||||
const targetTurn = input.userMessages[targetIndex];
|
||||
// Codex rewinds whole turns; a steer cannot be removed without the earlier
|
||||
// messages of its turn.
|
||||
if (targetTurn.turnId && input.userMessages[targetIndex - 1]?.turnId === targetTurn.turnId) {
|
||||
throw new Error(
|
||||
"Codex cannot rewind a message sent during a turn without removing earlier messages. Select the first message in the turn instead.",
|
||||
);
|
||||
|
||||
const currentUserTurnCount = input.userMessageTurns.count();
|
||||
const numTurns = currentUserTurnCount - targetTurn.index;
|
||||
if (numTurns < 0) {
|
||||
throw new Error(`Codex user message ${input.messageId} is outside the current thread`);
|
||||
}
|
||||
const numTurns = countTurns(input.userMessages.slice(targetIndex));
|
||||
|
||||
// Codex does not carry the parent thread's config into a fork; without it the
|
||||
// forked thread falls back to the default model provider.
|
||||
|
||||
@@ -0,0 +1,26 @@
|
||||
import type { AgentTimelineItem } from "../agent-sdk-types.js";
|
||||
|
||||
/** Preserve extension context as an expandable tool row instead of assistant speech. */
|
||||
export function mapCustomMessageToToolCall(
|
||||
message: { role: "custom"; customType?: unknown; details?: unknown },
|
||||
text: string,
|
||||
callId: string,
|
||||
): Extract<AgentTimelineItem, { type: "tool_call" }> {
|
||||
const customType =
|
||||
typeof message.customType === "string" && message.customType.trim()
|
||||
? message.customType
|
||||
: "custom-message";
|
||||
return {
|
||||
type: "tool_call",
|
||||
callId,
|
||||
name: customType,
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text },
|
||||
metadata: {
|
||||
synthetic: true,
|
||||
customType,
|
||||
...(message.details === undefined ? {} : { details: message.details }),
|
||||
},
|
||||
error: null,
|
||||
};
|
||||
}
|
||||
+165
@@ -0,0 +1,165 @@
|
||||
import { mkdtemp, rm, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
import path from "node:path";
|
||||
|
||||
import { describe, expect, test } from "vitest";
|
||||
|
||||
import { createTestLogger } from "../../../test-utils/test-logger.js";
|
||||
import type { AgentSession, AgentStreamEvent } from "../agent-sdk-types.js";
|
||||
import { GenericACPAgentClient } from "./generic-acp-agent.js";
|
||||
|
||||
describe("GenericACPAgentClient permission requests when a turn ends early", () => {
|
||||
test.each([
|
||||
{ ending: "fail", terminalEvent: "turn_failed" },
|
||||
{ ending: "cancel", terminalEvent: "turn_canceled" },
|
||||
] as const)(
|
||||
"answers a permission request left open by a $terminalEvent turn with cancelled",
|
||||
async ({ ending, terminalEvent }) => {
|
||||
await withFakeACPAgent(ending, async (command, cwd) => {
|
||||
const client = new GenericACPAgentClient({ logger: createTestLogger(), command });
|
||||
const session = await client.createSession({ provider: "acp", cwd });
|
||||
try {
|
||||
const events = collectEvents(session);
|
||||
|
||||
await session.startTurn("turn one");
|
||||
await waitForEvent(events, terminalEvent);
|
||||
expect(hasEvent(events, "permission_requested")).toBe(true);
|
||||
expect(session.getPendingPermissions()).toEqual([]);
|
||||
|
||||
const replyStart = events.length;
|
||||
await session.startTurn("turn two");
|
||||
await waitForEvent(events, "turn_completed", replyStart);
|
||||
|
||||
expect(assistantText(events.slice(replyStart))).toBe(
|
||||
'perm-1 answered: {"outcome":{"outcome":"cancelled"}}',
|
||||
);
|
||||
} finally {
|
||||
await session.close();
|
||||
}
|
||||
});
|
||||
},
|
||||
);
|
||||
});
|
||||
|
||||
function collectEvents(session: AgentSession): AgentStreamEvent[] {
|
||||
const events: AgentStreamEvent[] = [];
|
||||
session.subscribe((event) => events.push(event));
|
||||
return events;
|
||||
}
|
||||
|
||||
function hasEvent(
|
||||
events: AgentStreamEvent[],
|
||||
type: AgentStreamEvent["type"],
|
||||
fromIndex = 0,
|
||||
): boolean {
|
||||
return events.slice(fromIndex).some((event) => event.type === type);
|
||||
}
|
||||
|
||||
async function waitForEvent(
|
||||
events: AgentStreamEvent[],
|
||||
type: AgentStreamEvent["type"],
|
||||
fromIndex = 0,
|
||||
): Promise<void> {
|
||||
const deadline = Date.now() + 5_000;
|
||||
while (!hasEvent(events, type, fromIndex)) {
|
||||
if (Date.now() > deadline) {
|
||||
throw new Error(`Timed out waiting for ${type}`);
|
||||
}
|
||||
await new Promise((resolve) => setTimeout(resolve, 10));
|
||||
}
|
||||
}
|
||||
|
||||
function assistantText(events: AgentStreamEvent[]): string {
|
||||
return events
|
||||
.flatMap((event) =>
|
||||
event.type === "timeline" && event.item.type === "assistant_message" ? [event.item.text] : [],
|
||||
)
|
||||
.join("");
|
||||
}
|
||||
|
||||
async function withFakeACPAgent(
|
||||
ending: "fail" | "cancel",
|
||||
run: (command: [string, ...string[]], cwd: string) => Promise<void>,
|
||||
): Promise<void> {
|
||||
const testDir = await mkdtemp(path.join(tmpdir(), "paseo-acp-permission-turn-failure-"));
|
||||
try {
|
||||
const scriptPath = path.join(testDir, "fake-acp-agent.cjs");
|
||||
await writeFile(scriptPath, fakeACPAgentScript, "utf8");
|
||||
await run([process.execPath, scriptPath, ending], testDir);
|
||||
} finally {
|
||||
await rm(testDir, { recursive: true, force: true });
|
||||
}
|
||||
}
|
||||
|
||||
// Turn one asks for permission, then fails or is cancelled while the request is
|
||||
// still open.
|
||||
// Later turns report whether that request was ever answered.
|
||||
const fakeACPAgentScript = `
|
||||
const readline = require("node:readline");
|
||||
|
||||
const ending = process.argv[2];
|
||||
const rl = readline.createInterface({ input: process.stdin });
|
||||
let promptCount = 0;
|
||||
let permissionAnswer = null;
|
||||
|
||||
function write(message) {
|
||||
process.stdout.write(JSON.stringify({ jsonrpc: "2.0", ...message }) + "\\n");
|
||||
}
|
||||
|
||||
rl.on("line", (line) => {
|
||||
const message = JSON.parse(line);
|
||||
if (message.method === undefined && message.id === "perm-1") {
|
||||
permissionAnswer = message.result ?? { error: message.error };
|
||||
return;
|
||||
}
|
||||
if (message.method === "initialize") {
|
||||
write({ id: message.id, result: { protocolVersion: 1, agentCapabilities: {} } });
|
||||
return;
|
||||
}
|
||||
if (message.method === "session/new") {
|
||||
write({ id: message.id, result: { sessionId: "session-1" } });
|
||||
return;
|
||||
}
|
||||
if (message.method === "session/prompt") {
|
||||
const sessionId = message.params.sessionId;
|
||||
promptCount += 1;
|
||||
if (promptCount === 1) {
|
||||
const toolCall = { toolCallId: "tool-1", title: "echo hello", kind: "execute", status: "pending" };
|
||||
write({ method: "session/update", params: { sessionId, update: { sessionUpdate: "tool_call", ...toolCall } } });
|
||||
write({
|
||||
id: "perm-1",
|
||||
method: "session/request_permission",
|
||||
params: {
|
||||
sessionId,
|
||||
toolCall,
|
||||
options: [
|
||||
{ optionId: "allow", name: "Allow once", kind: "allow_once" },
|
||||
{ optionId: "reject", name: "Reject", kind: "reject_once" },
|
||||
],
|
||||
},
|
||||
});
|
||||
setTimeout(() => {
|
||||
if (ending === "cancel") {
|
||||
write({ id: message.id, result: { stopReason: "cancelled" } });
|
||||
} else {
|
||||
write({ id: message.id, error: { code: -32603, message: "turn failed with a permission open" } });
|
||||
}
|
||||
}, 50);
|
||||
return;
|
||||
}
|
||||
const state = permissionAnswer === null ? "unanswered" : "answered: " + JSON.stringify(permissionAnswer);
|
||||
write({
|
||||
method: "session/update",
|
||||
params: {
|
||||
sessionId,
|
||||
update: { sessionUpdate: "agent_message_chunk", content: { type: "text", text: "perm-1 " + state } },
|
||||
},
|
||||
});
|
||||
write({ id: message.id, result: { stopReason: "end_turn" } });
|
||||
return;
|
||||
}
|
||||
if (message.id !== undefined) {
|
||||
write({ id: message.id, result: {} });
|
||||
}
|
||||
});
|
||||
`;
|
||||
@@ -737,6 +737,8 @@ export class MockLoadTestAgentSession implements AgentSession {
|
||||
readonly capabilities = CAPABILITIES;
|
||||
readonly features: AgentFeature[] = [];
|
||||
readonly id: string;
|
||||
private readonly usageSessionKey = randomUUID();
|
||||
|
||||
private readonly listeners = new Set<(event: AgentStreamEvent) => void>();
|
||||
private readonly history: AgentStreamEvent[] = [];
|
||||
private readonly logger?: Logger;
|
||||
@@ -792,6 +794,15 @@ export class MockLoadTestAgentSession implements AgentSession {
|
||||
);
|
||||
}
|
||||
|
||||
usageSession() {
|
||||
return {
|
||||
provider: this.provider,
|
||||
model: this.modelId ?? undefined,
|
||||
env: {},
|
||||
sessionKey: this.usageSessionKey,
|
||||
};
|
||||
}
|
||||
|
||||
async run(prompt: AgentPromptInput, options?: AgentRunOptions): Promise<AgentRunResult> {
|
||||
const { turnId } = await this.startTurn(prompt, options);
|
||||
const turn = this.activeTurn;
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { describe, expect, test } from "vitest";
|
||||
import { describe, expect, onTestFinished, test } from "vitest";
|
||||
import { setImmediate as waitForImmediate } from "node:timers/promises";
|
||||
import { mkdtemp, mkdir, writeFile } from "node:fs/promises";
|
||||
import { tmpdir } from "node:os";
|
||||
@@ -69,6 +69,51 @@ test("OMP import uses the runtime's custom agent directory without a configured
|
||||
expect.objectContaining({ providerHandleId: sessionFile }),
|
||||
]);
|
||||
});
|
||||
test("OMP resumes a session whose model was removed on the model OMP falls back to", async () => {
|
||||
const runtime = new FakeOmp();
|
||||
runtime.removeModel("9router/deepseek-v4-flash");
|
||||
runtime.queueSessionSetup((session) => {
|
||||
session.state = { ...session.state, model: { provider: "openrouter", id: "fallback" } };
|
||||
});
|
||||
const client = new OmpAgentClient({ logger: createTestLogger(), runtime });
|
||||
|
||||
const session = await client.resumeSession({
|
||||
provider: "omp",
|
||||
sessionId: "omp-session-1",
|
||||
nativeHandle: "/tmp/omp-session.jsonl",
|
||||
metadata: { cwd: "/workspace/project", model: "9router/deepseek-v4-flash" },
|
||||
});
|
||||
onTestFinished(() => session.close());
|
||||
|
||||
await expect(session.getRuntimeInfo()).resolves.toMatchObject({ model: "openrouter/fallback" });
|
||||
expect(session.describePersistence()?.metadata?.model).toBe("openrouter/fallback");
|
||||
});
|
||||
|
||||
test("OMP resumes a session on the requested model when it differs from the session's", async () => {
|
||||
const runtime = new FakeOmp();
|
||||
const requestedModel = { provider: "openrouter", id: "requested" };
|
||||
runtime.queueSessionSetup((session) => {
|
||||
session.state = { ...session.state, model: { provider: "openrouter", id: "recorded" } };
|
||||
session.models = [requestedModel];
|
||||
session.setModelResult = requestedModel;
|
||||
});
|
||||
const client = new OmpAgentClient({ logger: createTestLogger(), runtime });
|
||||
|
||||
const session = await client.resumeSession({
|
||||
provider: "omp",
|
||||
sessionId: "omp-session-1",
|
||||
nativeHandle: "/tmp/omp-session.jsonl",
|
||||
metadata: { cwd: "/workspace/project", model: "openrouter/requested" },
|
||||
});
|
||||
onTestFinished(() => session.close());
|
||||
|
||||
expect(runtime.latestSession().setModelRequests).toEqual([
|
||||
{ provider: "openrouter", modelId: "requested" },
|
||||
]);
|
||||
await expect(session.getRuntimeInfo()).resolves.toMatchObject({ model: "openrouter/requested" });
|
||||
expect(session.describePersistence()?.metadata?.model).toBe("openrouter/requested");
|
||||
});
|
||||
|
||||
class ManualIdleScheduler implements OmpProviderIdleScheduler {
|
||||
private readonly retries: Array<() => void> = [];
|
||||
private readonly waiters: Array<{ count: number; resolve: () => void }> = [];
|
||||
@@ -617,6 +662,46 @@ describe("OMP agent client and session", () => {
|
||||
expect(omp.completedTurnCount()).toBe(1);
|
||||
});
|
||||
|
||||
test("keeps custom context in separate tools while a turn continues", async () => {
|
||||
const omp = new OmpHarness();
|
||||
await omp.start();
|
||||
await omp.requireStartTurn("Explain the project");
|
||||
omp.runtime().beginTurn();
|
||||
for (const display of [true, false, true]) {
|
||||
omp.emit({
|
||||
type: "message_end",
|
||||
message: {
|
||||
role: "custom",
|
||||
customType: "project-context",
|
||||
content: [{ type: "text", text: "Project instructions" }],
|
||||
details: { project: "example" },
|
||||
display,
|
||||
},
|
||||
});
|
||||
}
|
||||
const items = omp.timeline();
|
||||
expect(items).toEqual(
|
||||
[1, 2].map(() => ({
|
||||
type: "tool_call",
|
||||
callId: expect.stringMatching(/^omp-custom-/),
|
||||
name: "project-context",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "Project instructions" },
|
||||
metadata: {
|
||||
synthetic: true,
|
||||
customType: "project-context",
|
||||
details: { project: "example" },
|
||||
},
|
||||
error: null,
|
||||
})),
|
||||
);
|
||||
expect(new Set(items.map((item) => item.type === "tool_call" && item.callId)).size).toBe(2);
|
||||
expect(omp.completedTurnCount()).toBe(0);
|
||||
omp.runtime().finishTurn();
|
||||
await waitForImmediate();
|
||||
expect(omp.completedTurnCount()).toBe(1);
|
||||
});
|
||||
|
||||
test("omits live custom messages when display is false", async () => {
|
||||
const omp = new OmpHarness();
|
||||
await omp.start();
|
||||
@@ -660,11 +745,19 @@ describe("OMP agent client and session", () => {
|
||||
message: "Background job DocsSmokeTwo completed",
|
||||
},
|
||||
]);
|
||||
// Non-notice custom messages still fall through as assistant messages with
|
||||
// their own id so the stream coalescer never glues them onto the open reply.
|
||||
expect(omp.timeline().filter((item) => item.type === "assistant_message")).toEqual([
|
||||
expect(
|
||||
omp.timeline().filter((item) => item.type !== "notification" && item.type !== "user_message"),
|
||||
).toEqual([
|
||||
{ type: "assistant_message", text: "done", messageId: "omp-assistant-1" },
|
||||
{ type: "assistant_message", text: "plain custom status text", messageId: "omp-custom-1" },
|
||||
{
|
||||
type: "tool_call",
|
||||
callId: expect.stringMatching(/^omp-custom-/),
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "plain custom status text" },
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
]);
|
||||
});
|
||||
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import { mapCustomMessageToToolCall } from "../custom-message.js";
|
||||
import { randomUUID } from "node:crypto";
|
||||
import { existsSync } from "node:fs";
|
||||
import { homedir } from "node:os";
|
||||
@@ -69,11 +70,7 @@ import {
|
||||
} from "./provider-config.js";
|
||||
export { formatOmpVersionSupport, resolveOmpDiagnosticPaths } from "./provider-config.js";
|
||||
import { OmpSubagentCardTracker, type OmpSubagentCardScheduler } from "./subagent-card-tracker.js";
|
||||
import {
|
||||
ompCustomMessageId,
|
||||
ompSkillPromptUserText,
|
||||
shouldDisplayOmpCustomMessage,
|
||||
} from "./custom-message.js";
|
||||
import { ompSkillPromptUserText, shouldDisplayOmpCustomMessage } from "./custom-message.js";
|
||||
import { getUserMessageText } from "./message-history.js";
|
||||
import { mapOmpSystemNoticeToNotification } from "./system-notice.js";
|
||||
import { materializeProviderImage } from "../provider-image-output.js";
|
||||
@@ -445,7 +442,6 @@ function buildResumeStartInput(input: {
|
||||
protocolMode: "rpc-ui",
|
||||
env: input.launchContext?.env,
|
||||
session: input.sessionFile,
|
||||
model: input.resumeConfig.model,
|
||||
thinkingOptionId: normalizeOmpThinkingOption(input.resumeConfig.thinkingOptionId) ?? undefined,
|
||||
...(input.launchMode.modeId ? { modeId: input.launchMode.modeId } : {}),
|
||||
...(input.launchMode.extraArgs ? { extraArgs: input.launchMode.extraArgs } : {}),
|
||||
@@ -721,7 +717,6 @@ export class OmpAgentSession implements AgentSession {
|
||||
private closed = false;
|
||||
private live: boolean;
|
||||
private readonly emittedUserMessageIds = new Set<string>();
|
||||
private customMessageIndex = 0;
|
||||
|
||||
private readonly usageSessionKey = randomUUID();
|
||||
|
||||
@@ -2001,14 +1996,8 @@ export class OmpAgentSession implements AgentSession {
|
||||
type: "timeline",
|
||||
provider: this.provider,
|
||||
turnId,
|
||||
item: item ?? {
|
||||
type: "assistant_message",
|
||||
text,
|
||||
messageId: ompCustomMessageId(event.message, () => {
|
||||
this.customMessageIndex += 1;
|
||||
return this.customMessageIndex;
|
||||
}),
|
||||
},
|
||||
item:
|
||||
item ?? mapCustomMessageToToolCall(event.message, text, `omp-custom-${randomUUID()}`),
|
||||
});
|
||||
}
|
||||
}
|
||||
@@ -2373,16 +2362,17 @@ export class OmpAgentClient implements AgentClient {
|
||||
resumeConfig.config,
|
||||
startInput.env,
|
||||
);
|
||||
const initialState = await this.restoreFastMode(
|
||||
runtimeSession,
|
||||
resumeConfig.config,
|
||||
await runtimeSession.getState(),
|
||||
);
|
||||
const resumedState = await this.applyResumeModel(runtimeSession, resumeConfig.model);
|
||||
const config = {
|
||||
...resumeConfig.config,
|
||||
model: modelToId(resumedState.model) ?? resumeConfig.config.model,
|
||||
};
|
||||
const initialState = await this.restoreFastMode(runtimeSession, config, resumedState);
|
||||
return new OmpAgentSession({
|
||||
runtimeSession,
|
||||
hostTools,
|
||||
restartRuntime: this.buildRestartRuntime(startInput, resumeConfig.config, launchContext),
|
||||
config: resumeConfig.config,
|
||||
restartRuntime: this.buildRestartRuntime(startInput, config, launchContext),
|
||||
config,
|
||||
initialState,
|
||||
currentModeId: launchMode.modeId,
|
||||
logger: this.logger,
|
||||
@@ -2400,6 +2390,35 @@ export class OmpAgentClient implements AgentClient {
|
||||
}
|
||||
}
|
||||
|
||||
// OMP resumes a session on the model it recorded, or on its default when that model
|
||||
// is gone. Switching afterwards keeps a removed model from blocking the resume.
|
||||
private async applyResumeModel(
|
||||
runtimeSession: OmpRuntimeSession,
|
||||
requestedModel: string | undefined,
|
||||
): Promise<OmpSessionState> {
|
||||
const state = await runtimeSession.getState();
|
||||
const reference = parseModelReference(requestedModel ?? null);
|
||||
if (!reference?.provider) {
|
||||
return state;
|
||||
}
|
||||
const { provider, id } = reference;
|
||||
const isRequested = (model: OmpModel | null | undefined) =>
|
||||
model?.provider === provider && model.id === id;
|
||||
if (isRequested(state.model)) {
|
||||
return state;
|
||||
}
|
||||
const availableModels = await runtimeSession.getAvailableModels();
|
||||
if (!availableModels.some(isRequested)) {
|
||||
this.logger.warn(
|
||||
{ requestedModel, sessionModel: modelToId(state.model) },
|
||||
"OMP resumed on the session's model because the requested model is unavailable",
|
||||
);
|
||||
return state;
|
||||
}
|
||||
await runtimeSession.setModel(provider, id);
|
||||
return runtimeSession.getState();
|
||||
}
|
||||
|
||||
private buildRestartRuntime(
|
||||
startInput: OmpStartSessionInput,
|
||||
config: AgentSessionConfig,
|
||||
|
||||
@@ -27,6 +27,40 @@ async function collectHistory(
|
||||
}
|
||||
|
||||
describe("OMP history mapper", () => {
|
||||
test("renders visible custom messages as completed tools with their type and content", async () => {
|
||||
const events = await collectHistory([
|
||||
{
|
||||
role: "custom",
|
||||
customType: "project-context",
|
||||
content: "Project instructions",
|
||||
display: true,
|
||||
},
|
||||
{
|
||||
role: "custom",
|
||||
customType: "private-context",
|
||||
content: "Hidden instructions",
|
||||
display: false,
|
||||
},
|
||||
{
|
||||
role: "custom",
|
||||
customType: "project-context",
|
||||
content: "Project instructions",
|
||||
display: true,
|
||||
},
|
||||
]);
|
||||
expect(events.map((event) => event.item)).toEqual(
|
||||
[1, 2].map((index) => ({
|
||||
type: "tool_call",
|
||||
callId: `omp-custom-${index}`,
|
||||
name: "project-context",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "Project instructions" },
|
||||
metadata: { synthetic: true, customType: "project-context" },
|
||||
error: null,
|
||||
})),
|
||||
);
|
||||
});
|
||||
|
||||
test("replays a web search details error as failed when OMP sets isError false", async () => {
|
||||
const events = await collectHistory([
|
||||
{
|
||||
@@ -204,9 +238,16 @@ describe("OMP history mapper", () => {
|
||||
events.push(event);
|
||||
expect(events.map((event) => event.item)).toEqual([
|
||||
{
|
||||
type: "assistant_message",
|
||||
text: "[developer] External instruction",
|
||||
messageId: "omp-custom-1",
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-1",
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: {
|
||||
type: "plain_text",
|
||||
text: "[developer] External instruction",
|
||||
},
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
]);
|
||||
});
|
||||
@@ -408,18 +449,26 @@ describe("OMP history mapper", () => {
|
||||
type: "timeline",
|
||||
provider: "omp",
|
||||
item: {
|
||||
type: "assistant_message",
|
||||
text: "visible explicit custom",
|
||||
messageId: "omp-custom-1",
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-1",
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "visible explicit custom" },
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
},
|
||||
{
|
||||
type: "timeline",
|
||||
provider: "omp",
|
||||
item: {
|
||||
type: "assistant_message",
|
||||
text: "visible legacy custom",
|
||||
messageId: "omp-custom-2",
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-2",
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "visible legacy custom" },
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
},
|
||||
{
|
||||
@@ -651,11 +700,26 @@ describe("OMP history mapper", () => {
|
||||
expect(events.map((event) => event.item)).toEqual([
|
||||
{ type: "user_message", text: "active branch", messageId: "user-active" },
|
||||
{
|
||||
type: "assistant_message",
|
||||
text: "[future_control] Unsupported history record",
|
||||
messageId: "omp-custom-1",
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-1",
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: {
|
||||
type: "plain_text",
|
||||
text: "[future_control] Unsupported history record",
|
||||
},
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
{
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-2",
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "[developer] developer note" },
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
{ type: "assistant_message", text: "[developer] developer note", messageId: "omp-custom-2" },
|
||||
]);
|
||||
|
||||
const omp = new FakeOmp();
|
||||
@@ -758,11 +822,30 @@ describe("OMP history mapper", () => {
|
||||
expect(events.map((event) => event.item)).toEqual([
|
||||
{ type: "assistant_message", text: "Done.", messageId: "resp-1" },
|
||||
{ type: "user_message", text: "/skill:commit", messageId: "omp-custom-skill-1-user" },
|
||||
{ type: "assistant_message", text: ircMessage, messageId: "omp-custom-irc-1" },
|
||||
{
|
||||
type: "assistant_message",
|
||||
text: "visible without display flag",
|
||||
messageId: "omp-custom-legacy-1",
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-irc-1",
|
||||
name: "irc:incoming",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: ircMessage },
|
||||
metadata: {
|
||||
synthetic: true,
|
||||
customType: "irc:incoming",
|
||||
details: { from: "worker-1", message: "ready for review" },
|
||||
},
|
||||
error: null,
|
||||
},
|
||||
{
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-legacy-1",
|
||||
name: "legacy-no-display",
|
||||
status: "completed",
|
||||
detail: {
|
||||
type: "plain_text",
|
||||
text: "visible without display flag",
|
||||
},
|
||||
metadata: { synthetic: true, customType: "legacy-no-display" },
|
||||
error: null,
|
||||
},
|
||||
]);
|
||||
});
|
||||
@@ -821,18 +904,44 @@ describe("OMP history mapper", () => {
|
||||
type: "timeline",
|
||||
provider: "omp",
|
||||
item: {
|
||||
type: "assistant_message",
|
||||
text: '[IMPORTANT: Agent invoked the "improve" skill.]',
|
||||
messageId: "omp-custom-skill-agent",
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-skill-agent",
|
||||
name: "skill-prompt",
|
||||
status: "completed",
|
||||
detail: {
|
||||
type: "plain_text",
|
||||
text: '[IMPORTANT: Agent invoked the "improve" skill.]',
|
||||
},
|
||||
metadata: {
|
||||
synthetic: true,
|
||||
customType: "skill-prompt",
|
||||
details: {
|
||||
name: "improve",
|
||||
path: "/home/me/.agents/skills/improve/SKILL.md",
|
||||
lineCount: 9,
|
||||
},
|
||||
},
|
||||
error: null,
|
||||
},
|
||||
},
|
||||
{
|
||||
type: "timeline",
|
||||
provider: "omp",
|
||||
item: {
|
||||
type: "assistant_message",
|
||||
text: "<irc>\n<from>worker-1</from>\n<message>hi</message>\n</irc>",
|
||||
messageId: "omp-custom-irc-user",
|
||||
type: "tool_call",
|
||||
callId: "omp-custom-irc-user",
|
||||
name: "irc:incoming",
|
||||
status: "completed",
|
||||
detail: {
|
||||
type: "plain_text",
|
||||
text: "<irc>\n<from>worker-1</from>\n<message>hi</message>\n</irc>",
|
||||
},
|
||||
metadata: {
|
||||
synthetic: true,
|
||||
customType: "irc:incoming",
|
||||
details: { from: "worker-1", message: "hi" },
|
||||
},
|
||||
error: null,
|
||||
},
|
||||
},
|
||||
]);
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import { mapCustomMessageToToolCall } from "../custom-message.js";
|
||||
import type { AgentStreamEvent, AgentTimelineItem, ToolCallDetail } from "../../agent-sdk-types.js";
|
||||
import type { OmpAgentMessage, OmpImageContent, OmpTextContent } from "./rpc-types.js";
|
||||
import type { OmpBridgedToolIdentity } from "./mcp-bridge.js";
|
||||
@@ -155,7 +156,7 @@ export class OmpHistoryMapper {
|
||||
{
|
||||
type: "timeline",
|
||||
provider: this.provider,
|
||||
item: { type: "assistant_message", text, messageId },
|
||||
item: mapCustomMessageToToolCall(message, text, messageId),
|
||||
},
|
||||
];
|
||||
}
|
||||
|
||||
@@ -54,6 +54,8 @@ export class FakeOmp implements OmpRuntime {
|
||||
private readonly sessions: FakeOmpSession[] = [];
|
||||
private readonly command: [string, ...string[]];
|
||||
private readonly queuedCommands: OmpRpcSlashCommand[][] = [];
|
||||
private readonly queuedSessionSetups: Array<(session: FakeOmpSession) => void> = [];
|
||||
private readonly removedModels = new Set<string>();
|
||||
private nextStartError: Error | null = null;
|
||||
private nextSessionId = 0;
|
||||
private readonly sessionIdsByFile = new Map<string, string>();
|
||||
@@ -75,16 +77,20 @@ export class FakeOmp implements OmpRuntime {
|
||||
session: input,
|
||||
});
|
||||
this.recordedLaunches.push(launch);
|
||||
if (launch.model && this.removedModels.has(launch.model)) {
|
||||
throw new Error(`Model "${launch.model}" not found`);
|
||||
}
|
||||
const sessionId =
|
||||
(launch.session ? this.sessionIdsByFile.get(launch.session) : undefined) ??
|
||||
`omp-session-${++this.nextSessionId}`;
|
||||
const session = new FakeOmpSession(launch, sessionId);
|
||||
const session = new FakeOmpSession(launch, sessionId, this.removedModels);
|
||||
if (!launch.noSession) this.sessionIdsByFile.set(session.state.sessionFile, sessionId);
|
||||
session.commands = this.queuedCommands.shift() ?? [];
|
||||
for (const [level, error] of this.queuedSubagentSubscriptionErrors) {
|
||||
session.subagentSubscriptionErrors.set(level, error);
|
||||
}
|
||||
this.queuedSubagentSubscriptionErrors.clear();
|
||||
this.queuedSessionSetups.shift()?.(session);
|
||||
this.sessions.push(session);
|
||||
return session;
|
||||
}
|
||||
@@ -93,6 +99,15 @@ export class FakeOmp implements OmpRuntime {
|
||||
this.queuedCommands.push(commands);
|
||||
}
|
||||
|
||||
queueSessionSetup(setup: (session: FakeOmpSession) => void): void {
|
||||
this.queuedSessionSetups.push(setup);
|
||||
}
|
||||
|
||||
// OMP refuses to launch with, or switch to, a model it no longer knows.
|
||||
removeModel(modelId: string): void {
|
||||
this.removedModels.add(modelId);
|
||||
}
|
||||
|
||||
failNextStart(error: Error): void {
|
||||
this.nextStartError = error;
|
||||
}
|
||||
@@ -174,7 +189,11 @@ export class FakeOmpSession implements OmpRuntimeSession {
|
||||
private activeHeldPrompt: { promise: Promise<void>; reject: (error: Error) => void } | null =
|
||||
null;
|
||||
|
||||
constructor(launch: OmpRuntimeLaunch, sessionId = "omp-session-1") {
|
||||
constructor(
|
||||
launch: OmpRuntimeLaunch,
|
||||
sessionId = "omp-session-1",
|
||||
private readonly removedModels: ReadonlySet<string> = new Set(),
|
||||
) {
|
||||
this.environment = launch.env ?? {};
|
||||
this.state = {
|
||||
model: null,
|
||||
@@ -333,9 +352,13 @@ export class FakeOmpSession implements OmpRuntimeSession {
|
||||
|
||||
async setModel(provider: string, modelId: string): Promise<OmpModel> {
|
||||
this.setModelRequests.push({ provider, modelId });
|
||||
if (this.removedModels.has(`${provider}/${modelId}`)) {
|
||||
throw new Error(`Model not found: ${provider}/${modelId}`);
|
||||
}
|
||||
if (!this.setModelResult) {
|
||||
throw new Error("FakeOmp setModel requires setModelResult to be scripted");
|
||||
}
|
||||
this.state = { ...this.state, model: this.setModelResult };
|
||||
return this.setModelResult;
|
||||
}
|
||||
|
||||
|
||||
@@ -15,29 +15,63 @@ import { OpenCodeServerManager } from "./opencode/server-manager.js";
|
||||
|
||||
test("dispatches ascending OpenCode message identifiers through the public provider path", async () => {
|
||||
const upstream = await createRecoveryUpstream();
|
||||
const fixture = await createPublicRecoverySession(upstream, new RecoveryTiming());
|
||||
const observed: AgentStreamEvent[] = [];
|
||||
fixture.session.subscribe((event) => observed.push(event));
|
||||
await upstream.connected(1);
|
||||
upstream.send(0, connectedRecord());
|
||||
|
||||
await fixture.session.startTurn("first");
|
||||
await upstream.dispatched(1);
|
||||
upstream.send(0, idleRecord());
|
||||
await eventually(() =>
|
||||
expect(observed.filter((event) => event.type === "turn_completed")).toHaveLength(1),
|
||||
const client = new OpenCodeAgentClient(
|
||||
createTestLogger(),
|
||||
{
|
||||
command: {
|
||||
mode: "replace",
|
||||
argv: [
|
||||
process.execPath,
|
||||
"-e",
|
||||
`setInterval(() => {}, 1000); fetch(${JSON.stringify(
|
||||
`${upstream.url}/test/listening`,
|
||||
)}).then(() => console.log("listening on test server"));`,
|
||||
"--",
|
||||
],
|
||||
},
|
||||
},
|
||||
{
|
||||
resolveHomeDir: () => process.cwd(),
|
||||
createClient: ({ directory }) => createOpencodeClient({ baseUrl: upstream.url, directory }),
|
||||
},
|
||||
);
|
||||
await fixture.session.startTurn("second");
|
||||
const ids = await upstream.dispatched(2);
|
||||
try {
|
||||
const creating = client.createSession({
|
||||
provider: "opencode",
|
||||
cwd: "/workspace",
|
||||
});
|
||||
void creating.catch(() => undefined);
|
||||
await upstream.awaitingListening();
|
||||
// The process is alive but has not reported listening, so even a reachable endpoint must stay untouched.
|
||||
await new Promise((resolve) => setTimeout(resolve, 100));
|
||||
expect(upstream.connectionCount()).toBe(0);
|
||||
upstream.reportListening();
|
||||
const session = await creating;
|
||||
const observed: AgentStreamEvent[] = [];
|
||||
session.subscribe((event) => observed.push(event));
|
||||
await upstream.connected(1);
|
||||
upstream.send(0, connectedRecord());
|
||||
|
||||
expect(ids).toHaveLength(2);
|
||||
expect(ids[0]).toMatch(/^msg_[0-9a-f]{12}[0-9A-Za-z]{14}$/);
|
||||
expect(ids[1]).toMatch(/^msg_[0-9a-f]{12}[0-9A-Za-z]{14}$/);
|
||||
expect((ids[0] as string) < (ids[1] as string)).toBe(true);
|
||||
await session.startTurn("first");
|
||||
await upstream.dispatched(1);
|
||||
upstream.send(0, idleRecord());
|
||||
await eventually(() =>
|
||||
expect(observed.filter((event) => event.type === "turn_completed")).toHaveLength(1),
|
||||
);
|
||||
await session.startTurn("second");
|
||||
const ids = await upstream.dispatched(2);
|
||||
|
||||
await fixture.session.close();
|
||||
await fixture.manager.shutdown();
|
||||
await upstream.close();
|
||||
expect(ids).toHaveLength(2);
|
||||
expect(ids[0]).toMatch(/^msg_[0-9a-f]{12}[0-9A-Za-z]{14}$/);
|
||||
expect(ids[1]).toMatch(/^msg_[0-9a-f]{12}[0-9A-Za-z]{14}$/);
|
||||
expect((ids[0] as string) < (ids[1] as string)).toBe(true);
|
||||
|
||||
await session.close();
|
||||
} finally {
|
||||
upstream.reportListening();
|
||||
await client.shutdown();
|
||||
await upstream.close();
|
||||
}
|
||||
});
|
||||
|
||||
test("recovers missed output after EOF without failing the active turn", async () => {
|
||||
@@ -306,7 +340,10 @@ async function createPublicRecoverySession(
|
||||
serverProcess?.exit();
|
||||
return "terminated";
|
||||
},
|
||||
createEventSource: (options) => new OpenCodeEventConsumer({ ...options, timing }),
|
||||
createEventSource: (options) => {
|
||||
expect(options.listening).toBeInstanceOf(Promise);
|
||||
return new OpenCodeEventConsumer({ ...options, timing });
|
||||
},
|
||||
});
|
||||
const client = new OpenCodeAgentClient(createTestLogger(), undefined, {
|
||||
serverManager: manager,
|
||||
@@ -338,6 +375,7 @@ class RecoveryServerProcess extends EventEmitter {
|
||||
|
||||
async function createRecoveryUpstream() {
|
||||
const streams: ServerResponse[] = [];
|
||||
let listeningResponse: ServerResponse | null = null;
|
||||
const dispatchIds: string[] = [];
|
||||
const mcpAddNames: string[] = [];
|
||||
let messages: unknown[] = [];
|
||||
@@ -345,6 +383,10 @@ async function createRecoveryUpstream() {
|
||||
let status: "busy" | "idle" = "idle";
|
||||
const server = createServer(async (request, response) => {
|
||||
const pathname = new URL(request.url ?? "/", "http://127.0.0.1").pathname;
|
||||
if (pathname === "/test/listening") {
|
||||
listeningResponse = response;
|
||||
return;
|
||||
}
|
||||
if (request.url?.startsWith("/global/event")) {
|
||||
response.writeHead(200, { "content-type": "text/event-stream" });
|
||||
response.flushHeaders();
|
||||
@@ -378,6 +420,10 @@ async function createRecoveryUpstream() {
|
||||
return {
|
||||
port: address.port,
|
||||
url: `http://127.0.0.1:${address.port}`,
|
||||
awaitingListening: async () =>
|
||||
expect.poll(() => listeningResponse, { timeout: 3_000 }).not.toBeNull(),
|
||||
reportListening: () => listeningResponse?.end(),
|
||||
connectionCount: () => streams.length,
|
||||
connected: async (count: number) => eventually(() => expect(streams).toHaveLength(count)),
|
||||
send(index: number, value: unknown) {
|
||||
streams[index]?.write(`data: ${JSON.stringify(value)}\n\n`);
|
||||
|
||||
@@ -1429,10 +1429,11 @@ export class OpenCodeAgentClient implements AgentClient {
|
||||
OpenCodeServerManager.getInstance(this.logger, runtimeSettings, {
|
||||
managedProcesses: deps.managedProcesses,
|
||||
resolveHomeDir: deps.resolveHomeDir,
|
||||
createEventSource: ({ serverUrl, processExit, logger: eventLogger }) =>
|
||||
createEventSource: ({ serverUrl, processExit, listening, logger: eventLogger }) =>
|
||||
new OpenCodeEventConsumer({
|
||||
serverUrl,
|
||||
processExit,
|
||||
listening,
|
||||
logger: eventLogger,
|
||||
createClient: (baseUrl) => this.createOpenCodeClient({ baseUrl, directory: "" }),
|
||||
}),
|
||||
|
||||
@@ -49,9 +49,11 @@ describe("OpenCodeEventConsumer", () => {
|
||||
const upstream = await createSseUpstream();
|
||||
const timing = new ControlledTiming();
|
||||
const processExit = deferred<Error>();
|
||||
const listening = deferred<void>();
|
||||
const consumer = new OpenCodeEventConsumer({
|
||||
serverUrl: upstream.url,
|
||||
processExit: processExit.promise,
|
||||
listening: listening.promise,
|
||||
logger: createRecordingLogger(),
|
||||
timing,
|
||||
});
|
||||
@@ -62,6 +64,10 @@ describe("OpenCodeEventConsumer", () => {
|
||||
const inputs: OpenCodeEventSourceInput[] = [];
|
||||
consumer.subscribe((input) => inputs.push(input));
|
||||
|
||||
await new Promise<void>((resolve) => setImmediate(resolve));
|
||||
expect(upstream.requests).toHaveLength(0);
|
||||
expect(consumer.diagnostics().attempt).toBe(0);
|
||||
listening.resolve();
|
||||
await upstream.connected(1);
|
||||
expect(await promiseState(consumer.ready())).toBe("pending");
|
||||
upstream.send(0, arbitraryRecord("/one"));
|
||||
@@ -106,10 +112,7 @@ describe("OpenCodeEventConsumer", () => {
|
||||
await consumer.ready();
|
||||
|
||||
timing.expireWatchdog();
|
||||
expect(timing.watchdogDelays).toEqual([
|
||||
EXPECTED_STREAM_WATCHDOG_MS,
|
||||
EXPECTED_STREAM_WATCHDOG_MS,
|
||||
]);
|
||||
expect(timing.watchdogDelays).toEqual([5_000, EXPECTED_STREAM_WATCHDOG_MS]);
|
||||
await timing.waiting();
|
||||
timing.advanceWait();
|
||||
await upstream.connected(2);
|
||||
@@ -120,6 +123,7 @@ describe("OpenCodeEventConsumer", () => {
|
||||
|
||||
test("retries a first-record watchdog and exposes the recovery attempt", async () => {
|
||||
const upstream = await createSseUpstream();
|
||||
upstream.stallNext(1);
|
||||
const timing = new ControlledTiming();
|
||||
const logger = createRecordingLogger();
|
||||
const consumer = new OpenCodeEventConsumer({
|
||||
@@ -127,6 +131,12 @@ describe("OpenCodeEventConsumer", () => {
|
||||
processExit: new Promise<Error>(() => undefined),
|
||||
logger,
|
||||
timing,
|
||||
createClient: (baseUrl) =>
|
||||
createOpencodeClient({
|
||||
baseUrl,
|
||||
// Keep the abandoned socket open to reproduce a fetch that does not unwind on abort.
|
||||
fetch: (request) => fetch(new Request(request, { signal: null })),
|
||||
}),
|
||||
});
|
||||
cleanups.push(async () => {
|
||||
await consumer.close();
|
||||
@@ -134,6 +144,7 @@ describe("OpenCodeEventConsumer", () => {
|
||||
});
|
||||
|
||||
await upstream.connected(1);
|
||||
expect(timing.watchdogDelays).toEqual([5_000]);
|
||||
timing.expireWatchdog();
|
||||
await timing.waiting();
|
||||
expect(consumer.diagnostics()).toMatchObject({
|
||||
@@ -156,7 +167,18 @@ describe("OpenCodeEventConsumer", () => {
|
||||
await upstream.connected(2);
|
||||
upstream.send(1, connectedRecord("/recovered"));
|
||||
await consumer.ready();
|
||||
expect(consumer.diagnostics()).toMatchObject({ attempt: 2, phase: "stream" });
|
||||
expect(consumer.diagnostics()).toMatchObject({
|
||||
attempt: 2,
|
||||
phase: "stream",
|
||||
});
|
||||
expect(upstream.isOpen(0)).toBe(true);
|
||||
upstream.resume(0);
|
||||
upstream.send(0, connectedRecord("/abandoned"));
|
||||
upstream.send(0, arbitraryRecord("/abandoned"));
|
||||
const inputs: OpenCodeEventSourceInput[] = [];
|
||||
consumer.subscribe((input) => inputs.push(input));
|
||||
await new Promise<void>((resolve) => setImmediate(resolve));
|
||||
expect(inputs).toEqual([]);
|
||||
});
|
||||
|
||||
test("publishes one terminal and stops reconnecting on process exit", async () => {
|
||||
@@ -422,6 +444,16 @@ describe("OpenCodeEventConsumer", () => {
|
||||
await consumer.close();
|
||||
|
||||
expect(inputs).toEqual([]);
|
||||
|
||||
const waitingConsumer = new OpenCodeEventConsumer({
|
||||
serverUrl: upstream.url,
|
||||
processExit: new Promise<Error>(() => undefined),
|
||||
listening: new Promise<void>(() => undefined),
|
||||
logger: createRecordingLogger(),
|
||||
});
|
||||
await waitingConsumer.close();
|
||||
await expect(waitingConsumer.ready()).rejects.toThrow("OpenCode event source closed");
|
||||
expect(upstream.requests).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -499,8 +531,14 @@ async function createSseUpstream() {
|
||||
const responses: ServerResponse[] = [];
|
||||
const requests: Array<{ url: string | undefined }> = [];
|
||||
let failuresRemaining = 0;
|
||||
let stallsRemaining = 0;
|
||||
const server = createServer((request, response) => {
|
||||
requests.push({ url: request.url });
|
||||
if (stallsRemaining > 0) {
|
||||
stallsRemaining -= 1;
|
||||
responses.push(response);
|
||||
return;
|
||||
}
|
||||
if (failuresRemaining > 0) {
|
||||
failuresRemaining -= 1;
|
||||
response.writeHead(503).end();
|
||||
@@ -533,7 +571,21 @@ async function createSseUpstream() {
|
||||
failNext(count: number) {
|
||||
failuresRemaining = count;
|
||||
},
|
||||
close: async () => new Promise<void>((resolve) => server.close(() => resolve())),
|
||||
stallNext(count: number) {
|
||||
stallsRemaining = count;
|
||||
},
|
||||
isOpen(index: number) {
|
||||
return responses[index]?.socket?.destroyed === false;
|
||||
},
|
||||
resume(index: number) {
|
||||
responses[index]?.writeHead(200, { "content-type": "text/event-stream" });
|
||||
responses[index]?.flushHeaders();
|
||||
},
|
||||
close: async () =>
|
||||
new Promise<void>((resolve) => {
|
||||
server.close(() => resolve());
|
||||
server.closeAllConnections();
|
||||
}),
|
||||
};
|
||||
}
|
||||
|
||||
|
||||
@@ -29,11 +29,13 @@ export interface OpenCodeEventConsumerTiming {
|
||||
export interface OpenCodeEventConsumerOptions {
|
||||
serverUrl: string;
|
||||
processExit: Promise<Error>;
|
||||
listening?: Promise<void>;
|
||||
logger: Pick<Logger, "debug" | "warn">;
|
||||
createClient?: (baseUrl: string) => OpencodeClient;
|
||||
timing?: OpenCodeEventConsumerTiming;
|
||||
}
|
||||
|
||||
const FIRST_RECORD_WATCHDOG_MS = 5_000;
|
||||
const WATCHDOG_MS = 30_000;
|
||||
const MAX_BACKOFF_MS = 5_000;
|
||||
const FAILURE_WARNING_ATTEMPT = 4;
|
||||
@@ -98,7 +100,7 @@ export class OpenCodeEventConsumer implements OpenCodeEventSource {
|
||||
this.rejectReady = reject;
|
||||
});
|
||||
void this.readyPromise.catch(() => undefined);
|
||||
this.connectionTask = this.consume(options.processExit);
|
||||
this.connectionTask = this.consume(options.processExit, options.listening);
|
||||
void this.connectionTask.catch(() => undefined);
|
||||
}
|
||||
|
||||
@@ -131,8 +133,23 @@ export class OpenCodeEventConsumer implements OpenCodeEventSource {
|
||||
await this.connectionTask.catch(() => undefined);
|
||||
}
|
||||
|
||||
private async consume(processExit: Promise<Error>): Promise<void> {
|
||||
private async consume(processExit: Promise<Error>, listening?: Promise<void>): Promise<void> {
|
||||
void processExit.then((error) => this.exit(error));
|
||||
if (listening) {
|
||||
const signal = this.connectionAbort.signal;
|
||||
let stopWaiting!: () => void;
|
||||
const stopped = new Promise<void>((resolve) => {
|
||||
stopWaiting = resolve;
|
||||
});
|
||||
signal.addEventListener("abort", stopWaiting, { once: true });
|
||||
try {
|
||||
await Promise.race([listening, stopped]);
|
||||
} catch {
|
||||
return;
|
||||
} finally {
|
||||
signal.removeEventListener("abort", stopWaiting);
|
||||
}
|
||||
}
|
||||
let reconnectAttempt = 0;
|
||||
while (!this.closed) {
|
||||
this.attempt += 1;
|
||||
@@ -150,62 +167,83 @@ export class OpenCodeEventConsumer implements OpenCodeEventSource {
|
||||
|
||||
private async consumeConnection(signal: AbortSignal): Promise<OpenCodeConnectionResult> {
|
||||
const requestAbort = new AbortController();
|
||||
const abortRequest = () => requestAbort.abort(signal.reason);
|
||||
const attemptToken = { active: true };
|
||||
let resolveAbandoned!: (result: OpenCodeConnectionResult) => void;
|
||||
const abandoned = new Promise<OpenCodeConnectionResult>((resolve) => {
|
||||
resolveAbandoned = resolve;
|
||||
});
|
||||
const abortRequest = () => {
|
||||
attemptToken.active = false;
|
||||
resolveAbandoned({ delivered, phase, outcome: "ended" });
|
||||
requestAbort.abort(signal.reason);
|
||||
};
|
||||
signal.addEventListener("abort", abortRequest, { once: true });
|
||||
let cancelWatchdog: () => void = () => undefined;
|
||||
let delivered = false;
|
||||
let phase: OpenCodeEventStreamPhase = "first-record";
|
||||
let watchdogPhase: OpenCodeEventStreamPhase | null = null;
|
||||
let sseError: unknown;
|
||||
const armWatchdog = () => {
|
||||
cancelWatchdog();
|
||||
cancelWatchdog = this.timing.arm(WATCHDOG_MS, () => {
|
||||
watchdogPhase = phase;
|
||||
requestAbort.abort(new Error(`OpenCode event stream ${phase} watchdog expired`));
|
||||
});
|
||||
};
|
||||
try {
|
||||
const result = await this.client.global.event({
|
||||
signal: requestAbort.signal,
|
||||
sseMaxRetryAttempts: 0,
|
||||
onSseError: (error) => {
|
||||
sseError = error;
|
||||
cancelWatchdog = this.timing.arm(
|
||||
this.connected ? WATCHDOG_MS : FIRST_RECORD_WATCHDOG_MS,
|
||||
() => {
|
||||
const error = new Error(`OpenCode event stream ${phase} watchdog expired`);
|
||||
// Abandon a stalled request even when fetch ignores abort, for example during OpenCode startup.
|
||||
attemptToken.active = false;
|
||||
resolveAbandoned({ delivered, phase, outcome: "watchdog", error });
|
||||
requestAbort.abort(error);
|
||||
},
|
||||
});
|
||||
armWatchdog();
|
||||
for await (const event of result.stream) {
|
||||
if (this.closed) {
|
||||
return { delivered, phase, outcome: "ended" };
|
||||
);
|
||||
};
|
||||
const consumeStream = async (): Promise<OpenCodeConnectionResult> => {
|
||||
try {
|
||||
const result = await this.client.global.event({
|
||||
signal: requestAbort.signal,
|
||||
sseMaxRetryAttempts: 0,
|
||||
onSseError: (error) => {
|
||||
sseError = error;
|
||||
},
|
||||
});
|
||||
for await (const event of result.stream) {
|
||||
// Ignore late records from abandoned requests, for example a delayed server.connected event.
|
||||
if (this.closed || !attemptToken.active) {
|
||||
return { delivered, phase, outcome: "ended" };
|
||||
}
|
||||
delivered = true;
|
||||
phase = "stream";
|
||||
this.phase = phase;
|
||||
if (!this.connected && event.payload.type === "server.connected") {
|
||||
this.connected = true;
|
||||
this.resolveReady();
|
||||
armWatchdog();
|
||||
continue;
|
||||
}
|
||||
armWatchdog();
|
||||
this.logPluginFailure(event);
|
||||
this.publish(event);
|
||||
}
|
||||
armWatchdog();
|
||||
delivered = true;
|
||||
phase = "stream";
|
||||
this.phase = phase;
|
||||
if (!this.connected && event.payload.type === "server.connected") {
|
||||
this.connected = true;
|
||||
this.resolveReady();
|
||||
continue;
|
||||
}
|
||||
this.logPluginFailure(event);
|
||||
this.publish(event);
|
||||
let outcome: OpenCodeConnectionOutcome = "ended";
|
||||
if (sseError !== undefined) outcome = "error";
|
||||
return {
|
||||
delivered,
|
||||
phase,
|
||||
outcome,
|
||||
...(sseError === undefined ? {} : { error: sseError }),
|
||||
};
|
||||
} catch (error) {
|
||||
return {
|
||||
delivered,
|
||||
phase,
|
||||
outcome: "error",
|
||||
error,
|
||||
};
|
||||
}
|
||||
let outcome: OpenCodeConnectionOutcome = "ended";
|
||||
if (watchdogPhase) outcome = "watchdog";
|
||||
else if (sseError !== undefined) outcome = "error";
|
||||
return {
|
||||
delivered,
|
||||
phase: watchdogPhase ?? phase,
|
||||
outcome,
|
||||
...(sseError === undefined ? {} : { error: sseError }),
|
||||
};
|
||||
} catch (error) {
|
||||
return {
|
||||
delivered,
|
||||
phase: watchdogPhase ?? phase,
|
||||
outcome: watchdogPhase ? "watchdog" : "error",
|
||||
error,
|
||||
};
|
||||
};
|
||||
armWatchdog();
|
||||
try {
|
||||
return await Promise.race([consumeStream(), abandoned]);
|
||||
} finally {
|
||||
attemptToken.active = false;
|
||||
cancelWatchdog();
|
||||
signal.removeEventListener("abort", abortRequest);
|
||||
requestAbort.abort();
|
||||
@@ -285,5 +323,5 @@ function containsPluginError(error: unknown): boolean {
|
||||
}
|
||||
|
||||
export type OpenCodeEventConsumerFactory = (
|
||||
options: Pick<OpenCodeEventConsumerOptions, "serverUrl" | "processExit" | "logger">,
|
||||
options: Pick<OpenCodeEventConsumerOptions, "serverUrl" | "processExit" | "logger" | "listening">,
|
||||
) => OpenCodeEventConsumer;
|
||||
|
||||
@@ -209,3 +209,25 @@ test.each([
|
||||
},
|
||||
10000,
|
||||
);
|
||||
|
||||
test("selects v2 for an OpenCode v2 binary that answers --version after 7 s", async () => {
|
||||
const { mkdtemp, writeFile, rm } = await import("node:fs/promises");
|
||||
const { tmpdir } = await import("node:os");
|
||||
const { join } = await import("node:path");
|
||||
const { OpenCodeRuntimeClient } = await import("./runtime-client.js");
|
||||
const { createTestLogger } = await import("../../../../test-utils/test-logger.js");
|
||||
const root = await mkdtemp(join(tmpdir(), "opencode-slow-version-"));
|
||||
const script = join(root, "version.cjs");
|
||||
await writeFile(script, 'setTimeout(() => console.log("opencode v2.0.22"), 7000)');
|
||||
const client = new OpenCodeRuntimeClient(createTestLogger(), {
|
||||
command: { mode: "replace", argv: [process.execPath, script] },
|
||||
});
|
||||
try {
|
||||
expect((await client.listFeatures({ provider: "opencode", cwd: root }))[0]?.label).toBe(
|
||||
"Auto-accept",
|
||||
);
|
||||
} finally {
|
||||
await client.shutdown();
|
||||
await rm(root, { recursive: true, force: true });
|
||||
}
|
||||
}, 20_000);
|
||||
|
||||
@@ -356,6 +356,12 @@ export class OpenCodeServerManager implements OpenCodeServerManagerLike {
|
||||
const processExit = new Promise<Error>((resolve) => {
|
||||
resolveProcessExit = resolve;
|
||||
});
|
||||
let resolveListening!: () => void;
|
||||
let rejectListening!: (error: Error) => void;
|
||||
const ready = new Promise<void>((resolve, reject) => {
|
||||
resolveListening = resolve;
|
||||
rejectListening = reject;
|
||||
});
|
||||
const server: OpenCodeServerGeneration = {
|
||||
environment,
|
||||
process: serverProcess,
|
||||
@@ -364,7 +370,12 @@ export class OpenCodeServerManager implements OpenCodeServerManagerLike {
|
||||
refCount: 0,
|
||||
retired: false,
|
||||
ready: Promise.resolve(),
|
||||
events: this.createEventSource({ serverUrl: url, processExit, logger: this.logger }),
|
||||
events: this.createEventSource({
|
||||
serverUrl: url,
|
||||
processExit,
|
||||
logger: this.logger,
|
||||
listening: ready,
|
||||
}),
|
||||
managedProcessRecord,
|
||||
};
|
||||
this.logger.info(
|
||||
@@ -403,7 +414,7 @@ export class OpenCodeServerManager implements OpenCodeServerManagerLike {
|
||||
return sections.join("\n");
|
||||
};
|
||||
|
||||
const ready = new Promise<void>((resolve, reject) => {
|
||||
{
|
||||
let timeout: ReturnType<typeof setTimeout>;
|
||||
const failStartup = (error: Error) => {
|
||||
if (settled) {
|
||||
@@ -411,7 +422,7 @@ export class OpenCodeServerManager implements OpenCodeServerManagerLike {
|
||||
}
|
||||
settled = true;
|
||||
clearTimeout(timeout);
|
||||
reject(error);
|
||||
rejectListening(error);
|
||||
};
|
||||
timeout = setTimeout(() => {
|
||||
if (!started) {
|
||||
@@ -426,7 +437,7 @@ export class OpenCodeServerManager implements OpenCodeServerManagerLike {
|
||||
started = true;
|
||||
settled = true;
|
||||
clearTimeout(timeout);
|
||||
resolve();
|
||||
resolveListening();
|
||||
}
|
||||
});
|
||||
|
||||
@@ -462,7 +473,7 @@ export class OpenCodeServerManager implements OpenCodeServerManagerLike {
|
||||
}
|
||||
}
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
server.ready = ready.catch(async (error) => {
|
||||
await this.killServer(server);
|
||||
|
||||
@@ -1036,6 +1036,47 @@ describe("PiRpcAgentSession", () => {
|
||||
]);
|
||||
});
|
||||
|
||||
test("keeps custom context in separate tools while a turn continues", async () => {
|
||||
const { pi, session, events } = await createSession();
|
||||
const runtime = pi.latestSession();
|
||||
await session.startTurn("Explain the project");
|
||||
runtime.emit({ type: "agent_start" });
|
||||
runtime.emit({ type: "turn_start" });
|
||||
for (const display of [true, false, true]) {
|
||||
runtime.emit({
|
||||
type: "message_end",
|
||||
message: {
|
||||
role: "custom",
|
||||
customType: "project-context",
|
||||
content: [{ type: "text", text: "Project instructions" }],
|
||||
details: { project: "example" },
|
||||
display,
|
||||
},
|
||||
});
|
||||
}
|
||||
const items = events.timelineItems();
|
||||
expect(items).toEqual(
|
||||
[1, 2].map(() => ({
|
||||
type: "tool_call",
|
||||
callId: expect.stringMatching(/^pi-custom-/),
|
||||
name: "project-context",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "Project instructions" },
|
||||
metadata: {
|
||||
synthetic: true,
|
||||
customType: "project-context",
|
||||
details: { project: "example" },
|
||||
},
|
||||
error: null,
|
||||
})),
|
||||
);
|
||||
expect(new Set(items.map((item) => item.type === "tool_call" && item.callId)).size).toBe(2);
|
||||
expect(events.turnCompletedEvents()).toHaveLength(0);
|
||||
runtime.finishTurn();
|
||||
await events.nextTurnCompletion();
|
||||
await session.close();
|
||||
});
|
||||
|
||||
test("surfaces Pi extension command messages and completes when no agent turn starts", async () => {
|
||||
const { pi, session, events } = await createSession();
|
||||
const fakeSession = pi.latestSession();
|
||||
@@ -1052,7 +1093,15 @@ describe("PiRpcAgentSession", () => {
|
||||
expect(events.timelineAndCompletionEvents()).toEqual([
|
||||
{
|
||||
type: "timeline",
|
||||
item: { type: "assistant_message", text: "Extension command output" },
|
||||
item: {
|
||||
type: "tool_call",
|
||||
callId: expect.stringMatching(/^pi-custom-/),
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "Extension command output" },
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
},
|
||||
{ type: "turn_completed" },
|
||||
]);
|
||||
@@ -1081,7 +1130,18 @@ describe("PiRpcAgentSession", () => {
|
||||
});
|
||||
|
||||
expect(events.timelineItems()).toEqual([
|
||||
{ type: "assistant_message", text: "Background process completed" },
|
||||
{
|
||||
type: "tool_call",
|
||||
callId: expect.stringMatching(/^pi-custom-/),
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: {
|
||||
type: "plain_text",
|
||||
text: "Background process completed",
|
||||
},
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
]);
|
||||
expect(events.turnLifecycleEvents()).toEqual([{ type: "turn_started", turnId: undefined }]);
|
||||
|
||||
@@ -1528,8 +1588,6 @@ describe("PiRpcAgentSession", () => {
|
||||
"pi",
|
||||
"--mode",
|
||||
"rpc",
|
||||
"--model",
|
||||
"openrouter/model-a",
|
||||
"--thinking",
|
||||
"high",
|
||||
"--session",
|
||||
@@ -1539,6 +1597,87 @@ describe("PiRpcAgentSession", () => {
|
||||
]);
|
||||
});
|
||||
|
||||
test("resumes a session whose model was removed on the model Pi falls back to", async () => {
|
||||
const pi = new FakePi();
|
||||
pi.removeModel("9router/deepseek-v4-flash");
|
||||
pi.queueSessionSetup((session) => {
|
||||
session.state = { ...session.state, model: RESTRICTED_THINKING_MODEL };
|
||||
});
|
||||
|
||||
const session = await createClient(pi).resumeSession({
|
||||
provider: "pi",
|
||||
sessionId: "pi-session-1",
|
||||
nativeHandle: "/tmp/native-pi-session",
|
||||
metadata: { cwd: "/workspace/project", model: "9router/deepseek-v4-flash" },
|
||||
});
|
||||
onTestFinished(() => session.close());
|
||||
|
||||
await expect(session.getRuntimeInfo()).resolves.toMatchObject({
|
||||
model: "kimi-coding/kimi-k3",
|
||||
});
|
||||
expect(session.describePersistence()?.metadata?.model).toBe("kimi-coding/kimi-k3");
|
||||
});
|
||||
|
||||
test("resumes a session on the requested model when it differs from the session's", async () => {
|
||||
const pi = new FakePi();
|
||||
const requestedModel = { ...RESTRICTED_THINKING_MODEL, provider: "openrouter", id: "a" };
|
||||
pi.queueSessionSetup((session) => {
|
||||
session.state = { ...session.state, model: RESTRICTED_THINKING_MODEL };
|
||||
session.models = [RESTRICTED_THINKING_MODEL, requestedModel];
|
||||
session.setModelResult = requestedModel;
|
||||
});
|
||||
|
||||
const session = await createClient(pi).resumeSession({
|
||||
provider: "pi",
|
||||
sessionId: "pi-session-1",
|
||||
nativeHandle: "/tmp/native-pi-session",
|
||||
metadata: { cwd: "/workspace/project", model: "openrouter/a" },
|
||||
});
|
||||
onTestFinished(() => session.close());
|
||||
|
||||
expect(pi.latestSession().setModelRequests).toEqual([{ provider: "openrouter", modelId: "a" }]);
|
||||
await expect(session.getRuntimeInfo()).resolves.toMatchObject({ model: "openrouter/a" });
|
||||
expect(session.describePersistence()?.metadata?.model).toBe("openrouter/a");
|
||||
});
|
||||
|
||||
test("resumes on a requested model written as provider:id", async () => {
|
||||
const pi = new FakePi();
|
||||
const requestedModel = { ...RESTRICTED_THINKING_MODEL, provider: "openrouter", id: "a" };
|
||||
pi.queueSessionSetup((session) => {
|
||||
session.state = { ...session.state, model: RESTRICTED_THINKING_MODEL };
|
||||
session.models = [RESTRICTED_THINKING_MODEL, requestedModel];
|
||||
session.setModelResult = requestedModel;
|
||||
});
|
||||
|
||||
const session = await createClient(pi).resumeSession({
|
||||
provider: "pi",
|
||||
sessionId: "pi-session-1",
|
||||
nativeHandle: "/tmp/native-pi-session",
|
||||
metadata: { cwd: "/workspace/project", model: "openrouter:a" },
|
||||
});
|
||||
onTestFinished(() => session.close());
|
||||
|
||||
await expect(session.getRuntimeInfo()).resolves.toMatchObject({ model: "openrouter/a" });
|
||||
});
|
||||
|
||||
test("fails the resume when switching to an available model fails", async () => {
|
||||
const pi = new FakePi();
|
||||
const requestedModel = { ...RESTRICTED_THINKING_MODEL, provider: "openrouter", id: "a" };
|
||||
pi.queueSessionSetup((session) => {
|
||||
session.state = { ...session.state, model: RESTRICTED_THINKING_MODEL };
|
||||
session.models = [RESTRICTED_THINKING_MODEL, requestedModel];
|
||||
});
|
||||
|
||||
await expect(
|
||||
createClient(pi).resumeSession({
|
||||
provider: "pi",
|
||||
sessionId: "pi-session-1",
|
||||
nativeHandle: "/tmp/native-pi-session",
|
||||
metadata: { cwd: "/workspace/project", model: "openrouter/a" },
|
||||
}),
|
||||
).rejects.toThrow("FakePi setModel requires setModelResult to be scripted");
|
||||
});
|
||||
|
||||
test("adopts Pi's clamped thinking level when resuming a session", async () => {
|
||||
const pi = new FakePi();
|
||||
pi.queueSessionSetup((session) => {
|
||||
@@ -1715,8 +1854,6 @@ describe("PiRpcAgentSession", () => {
|
||||
"pi",
|
||||
"--mode",
|
||||
"rpc",
|
||||
"--model",
|
||||
"openrouter/model-a",
|
||||
"--thinking",
|
||||
"high",
|
||||
"--session",
|
||||
@@ -2576,6 +2713,11 @@ describe("PiRpcAgentClient", () => {
|
||||
);
|
||||
const pi = new FakePi();
|
||||
pi.queueSessionSetup((session) => {
|
||||
session.state.model = {
|
||||
...RESTRICTED_THINKING_MODEL,
|
||||
provider: "openrouter",
|
||||
id: "anthropic/claude-sonnet-4.5",
|
||||
};
|
||||
session.state.thinkingLevel = "high";
|
||||
});
|
||||
const client = new PiRpcAgentClient({
|
||||
@@ -2594,8 +2736,6 @@ describe("PiRpcAgentClient", () => {
|
||||
"pi",
|
||||
"--mode",
|
||||
"rpc",
|
||||
"--model",
|
||||
"openrouter/anthropic/claude-sonnet-4.5",
|
||||
"--thinking",
|
||||
"high",
|
||||
"--session",
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import { mapCustomMessageToToolCall } from "../custom-message.js";
|
||||
import { randomUUID } from "node:crypto";
|
||||
import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
|
||||
import { homedir, tmpdir } from "node:os";
|
||||
@@ -495,7 +496,6 @@ function buildResumeStartInput(input: {
|
||||
cwd: input.resumeConfig.cwd,
|
||||
env: input.launchContext?.env,
|
||||
session: input.sessionFile,
|
||||
model: input.resumeConfig.model,
|
||||
thinkingOptionId: normalizePiThinkingOption(input.resumeConfig.thinkingOptionId) ?? undefined,
|
||||
mcpConfigPath: input.mcpConfigFile?.path,
|
||||
extensionPaths: input.paseoExtension ? [input.paseoExtension.path] : undefined,
|
||||
@@ -2369,12 +2369,16 @@ export class PiRpcAgentSession implements AgentSession {
|
||||
const customMapping = this.extensionHost.mapCustomMessage(event.message);
|
||||
this.emitExtensionOutput(customMapping, turnId);
|
||||
const text = getUserMessageText(event.message.content);
|
||||
if (text) {
|
||||
if (event.message.display !== false && text) {
|
||||
this.emit({
|
||||
type: "timeline",
|
||||
provider: this.provider,
|
||||
turnId,
|
||||
item: { type: "assistant_message", text },
|
||||
item: mapCustomMessageToToolCall(
|
||||
event.message,
|
||||
text,
|
||||
`${this.provider}-custom-${randomUUID()}`,
|
||||
),
|
||||
});
|
||||
}
|
||||
if (!this.activeTurnStarted) {
|
||||
@@ -2590,10 +2594,14 @@ export class PiRpcAgentClient implements AgentClient {
|
||||
throw error;
|
||||
}
|
||||
try {
|
||||
const initialState = await this.applyResumeModel(runtimeSession, resumeConfig.model);
|
||||
return new PiRpcAgentSession({
|
||||
runtimeSession,
|
||||
config: resumeConfig.config,
|
||||
initialState: await runtimeSession.getState(),
|
||||
config: {
|
||||
...resumeConfig.config,
|
||||
model: modelToId(initialState.model) ?? resumeConfig.config.model,
|
||||
},
|
||||
initialState,
|
||||
capabilities: capabilitiesForSession(mcp !== null),
|
||||
cleanup: combineCleanup([mcpConfigFile?.cleanup, paseoExtension?.cleanup]),
|
||||
extensionTimeoutMs: providerOptions.extensionTimeoutMs,
|
||||
@@ -2608,6 +2616,35 @@ export class PiRpcAgentClient implements AgentClient {
|
||||
}
|
||||
}
|
||||
|
||||
// Pi resumes a session on the model it recorded, or on its default when that model
|
||||
// is gone. Switching afterwards keeps a removed model from blocking the resume.
|
||||
private async applyResumeModel(
|
||||
runtimeSession: PiRuntimeSession,
|
||||
requestedModel: string | undefined,
|
||||
): Promise<PiSessionState> {
|
||||
const state = await runtimeSession.getState();
|
||||
const reference = parseModelReference(requestedModel ?? null);
|
||||
if (!reference?.provider) {
|
||||
return state;
|
||||
}
|
||||
const { provider, id } = reference;
|
||||
const isRequested = (model: PiModel | null | undefined) =>
|
||||
model?.provider === provider && model.id === id;
|
||||
if (isRequested(state.model)) {
|
||||
return state;
|
||||
}
|
||||
const availableModels = await runtimeSession.getAvailableModels();
|
||||
if (!availableModels.some(isRequested)) {
|
||||
this.logger.warn(
|
||||
{ requestedModel, sessionModel: modelToId(state.model) },
|
||||
"Pi resumed on the session's model because the requested model is unavailable",
|
||||
);
|
||||
return state;
|
||||
}
|
||||
await runtimeSession.setModel(provider, id);
|
||||
return runtimeSession.getState();
|
||||
}
|
||||
|
||||
async fetchCatalog(
|
||||
options: FetchCatalogOptions,
|
||||
context?: ProviderRefreshContext,
|
||||
|
||||
+16
-3
@@ -129,15 +129,28 @@ describe("@gotgenes/pi-subagents adapter", () => {
|
||||
expect(new Set(upserts.map((event) => event?.id)).size).toBe(1);
|
||||
expect(events.filter((event) => event.event.type === "timeline").length).toBeGreaterThan(0);
|
||||
});
|
||||
test("keeps claimed notification text visible in history", async () => {
|
||||
test("keeps claimed notification text in a tool row in history", async () => {
|
||||
const fixture = readSubagentFixture(new URL("./fixtures/background.json", import.meta.url));
|
||||
const text = fixture.messages.find((message) => message.role === "custom")?.content;
|
||||
const notification = fixture.messages.find((message) => message.role === "custom");
|
||||
const text = notification?.content;
|
||||
const events = [];
|
||||
for await (const event of streamPiHistory("pi", fixture.messages)) events.push(event);
|
||||
expect(events).toContainEqual({
|
||||
type: "timeline",
|
||||
provider: "pi",
|
||||
item: { type: "assistant_message", text },
|
||||
item: {
|
||||
type: "tool_call",
|
||||
callId: "pi-custom-1",
|
||||
name: notification?.customType,
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text },
|
||||
metadata: {
|
||||
synthetic: true,
|
||||
customType: notification?.customType,
|
||||
details: notification?.details,
|
||||
},
|
||||
error: null,
|
||||
},
|
||||
});
|
||||
expect(events.some((event) => event.type === "provider_subagent")).toBe(true);
|
||||
});
|
||||
|
||||
@@ -65,16 +65,46 @@ export async function verifySubagentFixture(
|
||||
});
|
||||
for (const message of fixture.messages) {
|
||||
if (message.role !== "custom" || typeof message.content !== "string") continue;
|
||||
const assistantText = {
|
||||
type: "assistant_message" as const,
|
||||
text: message.content,
|
||||
};
|
||||
expect(live).toContainEqual(
|
||||
expect.objectContaining({ type: "timeline", item: assistantText }),
|
||||
);
|
||||
expect(replay).toContainEqual(
|
||||
expect.objectContaining({ type: "timeline", item: assistantText }),
|
||||
);
|
||||
for (const events of [live, replay]) {
|
||||
const tools = events.flatMap((event) =>
|
||||
event.type === "timeline" &&
|
||||
event.item.type === "tool_call" &&
|
||||
event.item.detail.type === "plain_text" &&
|
||||
event.item.detail.text === message.content
|
||||
? [event.item]
|
||||
: [],
|
||||
);
|
||||
expect(tools).toEqual(
|
||||
message.display === false
|
||||
? []
|
||||
: [
|
||||
{
|
||||
type: "tool_call",
|
||||
callId: expect.stringMatching(/^pi-custom-/),
|
||||
name: message.customType ?? "custom-message",
|
||||
status: "completed",
|
||||
detail: {
|
||||
type: "plain_text",
|
||||
text: message.content,
|
||||
},
|
||||
metadata: {
|
||||
synthetic: true,
|
||||
customType: message.customType ?? "custom-message",
|
||||
...(message.details === undefined ? {} : { details: message.details }),
|
||||
},
|
||||
error: null,
|
||||
},
|
||||
],
|
||||
);
|
||||
expect(
|
||||
events.filter(
|
||||
(event) =>
|
||||
event.type === "timeline" &&
|
||||
event.item.type === "assistant_message" &&
|
||||
event.item.text === message.content,
|
||||
),
|
||||
).toEqual([]);
|
||||
}
|
||||
}
|
||||
const liveSubagents = live.filter((event) => event.type === "provider_subagent");
|
||||
const firstTimeline = liveSubagents.findIndex((event) => event.event.type === "timeline");
|
||||
|
||||
@@ -16,6 +16,35 @@ async function collectHistory(
|
||||
}
|
||||
|
||||
describe("Pi history mapper", () => {
|
||||
test("renders visible custom messages as completed tools and hides private context", async () => {
|
||||
const events = await collectHistory([
|
||||
{
|
||||
role: "custom",
|
||||
customType: "project-context",
|
||||
content: "Project instructions",
|
||||
display: true,
|
||||
},
|
||||
{
|
||||
role: "custom",
|
||||
customType: "private-context",
|
||||
content: "Hidden instructions",
|
||||
display: false,
|
||||
},
|
||||
{ role: "custom", customType: "project-context", content: "Project instructions" },
|
||||
]);
|
||||
expect(events.map((event) => event.item)).toEqual(
|
||||
[1, 2].map((index) => ({
|
||||
type: "tool_call",
|
||||
callId: `pi-custom-${index}`,
|
||||
name: "project-context",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "Project instructions" },
|
||||
metadata: { synthetic: true, customType: "project-context" },
|
||||
error: null,
|
||||
})),
|
||||
);
|
||||
});
|
||||
|
||||
test("replays user, assistant, reasoning, and completed tool calls", async () => {
|
||||
await expect(
|
||||
collectHistory([
|
||||
@@ -128,14 +157,22 @@ describe("Pi history mapper", () => {
|
||||
]);
|
||||
});
|
||||
|
||||
test("replays non-notice custom messages as assistant text, matching the live path", async () => {
|
||||
test("replays custom messages as completed tools, matching the live path", async () => {
|
||||
await expect(
|
||||
collectHistory([{ role: "custom", content: "Extension command output" }]),
|
||||
).resolves.toEqual([
|
||||
{
|
||||
type: "timeline",
|
||||
provider: "pi",
|
||||
item: { type: "assistant_message", text: "Extension command output" },
|
||||
item: {
|
||||
type: "tool_call",
|
||||
callId: "pi-custom-1",
|
||||
name: "custom-message",
|
||||
status: "completed",
|
||||
detail: { type: "plain_text", text: "Extension command output" },
|
||||
metadata: { synthetic: true, customType: "custom-message" },
|
||||
error: null,
|
||||
},
|
||||
},
|
||||
]);
|
||||
});
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import { mapCustomMessageToToolCall } from "../custom-message.js";
|
||||
import type { AgentStreamEvent, AgentTimelineItem, ToolCallDetail } from "../../agent-sdk-types.js";
|
||||
import {
|
||||
createPiExtensionHost,
|
||||
@@ -61,6 +62,7 @@ export class PiHistoryMapper {
|
||||
private readonly hydrations: Promise<AgentStreamEvent[]>[] = [];
|
||||
private userIndex = 0;
|
||||
private assistantIndex = 0;
|
||||
private customIndex = 0;
|
||||
|
||||
constructor(
|
||||
private readonly provider: string,
|
||||
@@ -125,6 +127,7 @@ export class PiHistoryMapper {
|
||||
): AgentStreamEvent[] {
|
||||
const extensionMapping = this.extensionHost.mapCustomMessage(message);
|
||||
const extensionEvents = this.extensionEvents(extensionMapping);
|
||||
if (message.display === false) return extensionEvents;
|
||||
const text = getUserMessageText(message.content);
|
||||
const mappedEvent = text ? this.hooks.mapCustomMessage?.(text, this.provider) : null;
|
||||
if (mappedEvent) {
|
||||
@@ -137,7 +140,11 @@ export class PiHistoryMapper {
|
||||
{
|
||||
type: "timeline",
|
||||
provider: this.provider,
|
||||
item: { type: "assistant_message", text },
|
||||
item: mapCustomMessageToToolCall(
|
||||
message,
|
||||
text,
|
||||
`${this.provider}-custom-${++this.customIndex}`,
|
||||
),
|
||||
} as AgentStreamEvent,
|
||||
]
|
||||
: []),
|
||||
|
||||
@@ -57,6 +57,7 @@ export class FakePi implements PiRuntime {
|
||||
private readonly command: [string, ...string[]];
|
||||
private readonly queuedCommands: PiRpcSlashCommand[][] = [];
|
||||
private readonly queuedSessionSetups: Array<(session: FakePiSession) => void> = [];
|
||||
private readonly removedModels = new Set<string>();
|
||||
|
||||
constructor(command: [string, ...string[]] = ["pi"]) {
|
||||
this.command = command;
|
||||
@@ -68,7 +69,10 @@ export class FakePi implements PiRuntime {
|
||||
session: input,
|
||||
});
|
||||
this.recordedLaunches.push(launch);
|
||||
const session = new FakePiSession(launch);
|
||||
if (launch.model && this.removedModels.has(launch.model)) {
|
||||
throw new Error(`Model "${launch.model}" not found`);
|
||||
}
|
||||
const session = new FakePiSession(launch, this.removedModels);
|
||||
session.commands = this.queuedCommands.shift() ?? [];
|
||||
this.queuedSessionSetups.shift()?.(session);
|
||||
this.sessions.push(session);
|
||||
@@ -83,6 +87,11 @@ export class FakePi implements PiRuntime {
|
||||
this.queuedSessionSetups.push(setup);
|
||||
}
|
||||
|
||||
// Pi refuses to launch with, or switch to, a model it no longer knows.
|
||||
removeModel(modelId: string): void {
|
||||
this.removedModels.add(modelId);
|
||||
}
|
||||
|
||||
latestSession(): FakePiSession {
|
||||
const session = this.sessions.at(-1);
|
||||
if (!session) {
|
||||
@@ -145,7 +154,10 @@ export class FakePiSession implements PiRuntimeSession {
|
||||
private activeHeldPrompt: { promise: Promise<void>; reject: (error: Error) => void } | null =
|
||||
null;
|
||||
|
||||
constructor(launch: PiRuntimeLaunch) {
|
||||
constructor(
|
||||
launch: PiRuntimeLaunch,
|
||||
private readonly removedModels: ReadonlySet<string> = new Set(),
|
||||
) {
|
||||
this.environment = launch.env ?? {};
|
||||
this.state = {
|
||||
model: null,
|
||||
@@ -267,6 +279,9 @@ export class FakePiSession implements PiRuntimeSession {
|
||||
|
||||
async setModel(provider: string, modelId: string): Promise<PiModel> {
|
||||
this.setModelRequests.push({ provider, modelId });
|
||||
if (this.removedModels.has(`${provider}/${modelId}`)) {
|
||||
throw new Error(`Model not found: ${provider}/${modelId}`);
|
||||
}
|
||||
if (!this.setModelResult) {
|
||||
throw new Error("FakePi setModel requires setModelResult to be scripted");
|
||||
}
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user