mirror of
https://github.com/getpaseo/paseo.git
synced 2026-07-29 12:01:31 +00:00
fix(fastlane): use version: kwarg for Spaceship Build.all
The submit_review lane was crashing with "unknown keyword: :filter" because Spaceship::ConnectAPI::Build.all doesn't accept a filter hash; it takes specific kwargs (app_id, version, build_number, etc.) and constructs the JSON:API filter internally. Also drop includes: "preReleaseVersion" — it's part of ESSENTIAL_INCLUDES by default. Add resubmit-ios-review.yml workflow so we can re-run only the fastlane submit_review lane (no rebuild) against an existing TestFlight build via workflow_dispatch.
This commit is contained in:
21
packages/app/.eas/workflows/resubmit-ios-review.yml
Normal file
21
packages/app/.eas/workflows/resubmit-ios-review.yml
Normal file
@@ -0,0 +1,21 @@
|
||||
name: Resubmit iOS for App Store review
|
||||
|
||||
# Standalone re-trigger for the App Store review submission step. The iOS
|
||||
# binary is already uploaded to TestFlight via the main release-mobile flow;
|
||||
# this workflow just runs the fastlane submit_review lane against the latest
|
||||
# TestFlight build, without rebuilding or re-uploading.
|
||||
|
||||
on:
|
||||
workflow_dispatch: {}
|
||||
|
||||
jobs:
|
||||
submit_ios_for_review:
|
||||
name: Submit iOS for App Store review
|
||||
environment: production
|
||||
runs_on: macos-medium
|
||||
steps:
|
||||
- uses: eas/checkout
|
||||
- name: Install fastlane
|
||||
run: bundle install
|
||||
- name: Submit for review
|
||||
run: bundle exec fastlane ios submit_review
|
||||
@@ -29,8 +29,7 @@ platform :ios do
|
||||
loop do
|
||||
builds = Spaceship::ConnectAPI::Build.all(
|
||||
app_id: app.id,
|
||||
filter: { "version" => build_number.to_s },
|
||||
includes: "preReleaseVersion",
|
||||
version: build_number.to_s,
|
||||
)
|
||||
build = builds.find { |b| b.pre_release_version&.platform == "IOS" }
|
||||
state = build&.processing_state
|
||||
|
||||
Reference in New Issue
Block a user