puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-07-29 12:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: memoize useWebSocket return value and improve formatting consistency

Browse Source
This commit is contained in:
Mohamed Boudra
2025-10-25 18:49:42 +02:00
parent 64d1518a6f
commit d2313b9d1c
2 changed files with 56 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
packages/server/src/server/acp/types.ts
View File

@@ -1,21 +1,43 @@
import type { SessionNotification, RequestPermissionRequest, ClientSideConnection } from "@agentclientprotocol/sdk";
import type {
SessionNotification,
RequestPermissionRequest,
ClientSideConnection,
} from "@agentclientprotocol/sdk";
import type { ChildProcess } from "child_process";
/**
* Extended update types with messageId for proper deduplication
* messageId is optional since some sources may not provide it
*/
type UserMessageChunkWithId = Extract<SessionNotification['update'], { sessionUpdate: 'user_message_chunk' }> & { messageId?: string };
type AgentMessageChunkWithId = Extract<SessionNotification['update'], { sessionUpdate: 'agent_message_chunk' }> & { messageId?: string };
type AgentThoughtChunkWithId = Extract<SessionNotification['update'], { sessionUpdate: 'agent_thought_chunk' }> & { messageId?: string };
type UserMessageChunkWithId = Extract<
SessionNotification["update"],
{ sessionUpdate: "user_message_chunk" }
> & { messageId?: string };
type AgentMessageChunkWithId = Extract<
SessionNotification["update"],
{ sessionUpdate: "agent_message_chunk" }
> & { messageId?: string };
type AgentThoughtChunkWithId = Extract<
SessionNotification["update"],
{ sessionUpdate: "agent_thought_chunk" }
> & { messageId?: string };
export type EnrichedSessionUpdate =
| UserMessageChunkWithId
| AgentMessageChunkWithId
| AgentThoughtChunkWithId
| Exclude<SessionNotification['update'], { sessionUpdate: 'user_message_chunk' | 'agent_message_chunk' | 'agent_thought_chunk' }>;
| Exclude<
SessionNotification["update"],
{
sessionUpdate:
| "user_message_chunk"
| "agent_message_chunk"
| "agent_thought_chunk";
}
>;
export interface EnrichedSessionNotification extends Omit<SessionNotification, 'update'> {
export interface EnrichedSessionNotification
extends Omit<SessionNotification, "update"> {
update: EnrichedSessionUpdate;
}
@@ -23,10 +45,15 @@ export interface EnrichedSessionNotification extends Omit<SessionNotification, '
* Discriminated union for all notification types in the agent update stream
*/
export type AgentNotification =
| { type: 'session'; notification: EnrichedSessionNotification }
| { type: 'permission'; requestId: string; request: RequestPermissionRequest }
| { type: 'permission_resolved'; requestId: string; agentId: string; optionId: string }
| { type: 'status'; status: AgentStatus; error?: string };
| { type: "session"; notification: EnrichedSessionNotification }
| { type: "permission"; requestId: string; request: RequestPermissionRequest }
| {
type: "permission_resolved";
requestId: string;
agentId: string;
optionId: string;
}
| { type: "status"; status: AgentStatus; error?: string };
/**
* Status of an agent
@@ -64,7 +91,11 @@ export interface AgentRuntime {
* Discriminated union for agent state
*/
export type ManagedAgentState =
| { type: "uninitialized"; persistedSessionId: string | null; lastError?: string }
| {
type: "uninitialized";
persistedSessionId: string | null;
lastError?: string;
}
| {
type: "initializing";
persistedSessionId: string | null;

22
packages/server/src/server/session.ts
View File

@@ -284,7 +284,8 @@ export class Session {
const hasUserMessage = updates.some(
(update) =>
update.notification.type === "session" &&
update.notification.notification.update.sessionUpdate === "user_message_chunk"
update.notification.notification.update.sessionUpdate ===
"user_message_chunk"
);
// Need at least one user message and some additional updates (3-5) for context
@@ -467,14 +468,15 @@ export class Session {
break;
case "create_agent_request":
await this.handleCreateAgentRequest(msg.cwd, msg.initialMode, msg.requestId);
await this.handleCreateAgentRequest(
msg.cwd,
msg.initialMode,
msg.requestId
);
break;
case "initialize_agent_request":
await this.handleInitializeAgentRequest(
msg.agentId,
msg.requestId
);
await this.handleInitializeAgentRequest(msg.agentId, msg.requestId);
break;
case "set_agent_mode":
@@ -790,8 +792,12 @@ export class Session {
this.subscribeToAgent(agentId);
// Auto-initialize agent immediately on explicit creation so it's ready to use
console.log(`[Session ${this.clientId}] Auto-initializing agent ${agentId}`);
const { info } = await this.agentManager.initializeAgentAndGetHistory(agentId);
console.log(
`[Session ${this.clientId}] Auto-initializing agent ${agentId}`
);
const { info } = await this.agentManager.initializeAgentAndGetHistory(
agentId
);
// Emit agent_created message with initialized info
this.emit({