puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-10-27 19:52:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(server): wait for repository observation before asserting ref refresh (#5303)

Browse Source 
* test(server): wait for repository observation before asserting ref refresh

The first checkout facts read can begin before the metadata watcher registers. The test sent an event through an optional watcher lookup at that point and silently dropped it, so a slow setup left only the initial snapshot. Hold the first read to reproduce the ordering and wait for observation setup and the initial refresh before emitting the ref event.

* test(server): isolate ref refresh from background fetch

An asynchronous background fetch could also schedule a structural refresh or populate the known-ref set. Give this test an empty fetch result and wait for that fetch to complete so the second facts read proves the injected watcher event caused it.

* test(server): require the registered repository watcher in the assertion
This commit is contained in:
Mohamed Boudra
2026-09-23 23:25:30 +02:00
committed by GitHub
parent b2bb512b31
commit c976e2e5a5
1 changed files with 32 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/server/workspace-git-service.observation.test.ts
+32 -15
View File
@@ -996,27 +996,44 @@ describe("WorkspaceGitService checkout observation", () => {
test("origin/main refreshes a main checkout without configured upstream", async () => {
const watcher = createWatcherHarness();
const getCheckoutSnapshotFacts = vi.fn(async (cwd: string) => ({
...createCheckoutFacts(cwd),
currentBranch: "main",
remoteUrl: REMOTE_URL,
resolvedBaseRef: "main",
comparisonBaseRef: null,
branchRemoteName: null,
branchMergeRef: null,
upstreamStatus: null,
const releaseInitialFacts = createDeferred<void>();
const getCheckoutSnapshotFacts = vi.fn(async (cwd: string) => {
await releaseInitialFacts.promise;
return {
...createCheckoutFacts(cwd),
currentBranch: "main",
remoteUrl: REMOTE_URL,
resolvedBaseRef: "main",
comparisonBaseRef: null,
branchRemoteName: null,
branchMergeRef: null,
upstreamStatus: null,
};
});
const runGitFetch = vi.fn(async () => ({
changes: [],
nonRemoteRefsChanged: false,
error: null,
}));
const service = createService(watcher, { getCheckoutSnapshotFacts });
const service = createService(watcher, { getCheckoutSnapshotFacts, runGitFetch });
const subscription = service.registerWorkspace({ cwd: REPO_CWD }, vi.fn());
await vi.waitFor(() => {
expect(getCheckoutSnapshotFacts).toHaveBeenCalledTimes(1);
});
watcher.records
.find((record) => record.directory === GIT_DIR)
?.callback(null, [
{ path: path.join(GIT_DIR, "refs", "remotes", "origin", "main"), type: "update" },
]);
releaseInitialFacts.resolve();
await vi.waitFor(() => {
expect(getWatcherRecordsForDirectory(watcher, GIT_DIR)).toHaveLength(1);
expect(service.getMetrics().workspaceRefreshInFlightCount).toBe(0);
expect(service.getMetrics().workspaceObservationSetupInFlightCount).toBe(0);
expect(service.getMetrics().fetchInFlightCount).toBe(0);
expect(runGitFetch).toHaveBeenCalledTimes(1);
});
expect(getCheckoutSnapshotFacts).toHaveBeenCalledTimes(1);
const repoWatcher = getWatcherRecordsForDirectory(watcher, GIT_DIR)[0]!;
repoWatcher.callback(null, [
{ path: path.join(GIT_DIR, "refs", "remotes", "origin", "main"), type: "update" },
]);
await vi.advanceTimersByTimeAsync(1_000);
await vi.waitFor(() => {
expect(getCheckoutSnapshotFacts).toHaveBeenCalledTimes(2);