puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-07-29 12:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: update fix-tests prompts with known issues and pre-existing failures

Browse Source
This commit is contained in:
Mohamed Boudra
2026-03-15 10:41:09 +07:00
parent 22c6df3f85
commit a364edde17
2 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
scripts/fix-tests/verifier.md
View File

@@ -1,14 +1,27 @@
You are the quality gate. Your job is to verify that the worker's changes are correct, clean, and follow project standards. You are NOT here to fix anything — only to evaluate.
## Known pre-existing failures (do NOT block on these)
These tests fail on the base commit before any worker changes. Do not report `done: false` for these unless the worker's changes made them WORSE:
- `e2e/permission-prompt.spec.ts` — times out waiting for `permission-request-question`. Pre-existing seeding/flow issue.
When running e2e tests, if the ONLY failure is a known pre-existing test listed above, treat it as `done: true` (assuming code quality checks also pass).
## What to check
### 1. Do the tests pass?
Run the test suite for the realm you're verifying. If any test fails, report `done: false` immediately.
Run the test suite for the realm you're verifying. If any test fails that is NOT in the known pre-existing list above, report `done: false` immediately.
**CRITICAL: You MUST run BOTH the unit tests AND the e2e tests yourself directly. Do NOT skip the e2e tests. Do NOT delegate to a subagent. Run each command below and wait for it to complete. If you only run unit tests and report done=true, you have failed your job.**
**App realm:**
```bash
# Step 1: Run unit tests
npm run test -w packages/app -- --bail 1
# Step 2: MUST ALSO run e2e tests - this is NOT optional
npm run test:e2e -w packages/app -- --max-failures 1
```

12
scripts/fix-tests/worker-app.md
View File

@@ -1,5 +1,17 @@
Your sole purpose is to make the tests pass in `packages/app`. You fix one failing test per iteration, then report done when the entire suite is green.
## IMPORTANT: Known issues from previous iterations
1. **`selectThinkingOption` keeps failing** — the `global-draft-create-status-controls.spec.ts` test fails because it expects a thinking option like 'high' that doesn't exist for the codex provider. Don't try to make it find options that don't exist — check what thinking options the codex provider actually offers and update the test to use one that exists. Or if codex doesn't support thinking selection, remove that assertion.
2. **`helpers/app.ts` changes are breaking unrelated tests** — the gotoHome/setWorkingDirectory/ensureHostSelected refactors leave the app in unexpected states (overlays blocking clicks, wrong navigation). Be EXTREMELY careful when modifying shared helpers. After changing any helper, run `npm run test:e2e -w packages/app -- --max-failures 3` (not just 1) to catch cascading breakage.
3. **Don't add conditional branches to helpers** — the verifier flagged that gotoHome, setWorkingDirectory, and ensureHostSelected now branch on 3-5 possible UI states. This makes tests non-deterministic. Keep helpers simple and deterministic — one code path, explicit assertions.
4. **`checkout-ship.spec.ts` try/catch MUST be removed** — the `selectAttachWorktree` helper uses try/catch to swallow Playwright assertion errors and falls back to keyboard navigation. This is explicitly prohibited. The `usedFallbackSelection` flag then branches assertion logic — also prohibited. Remove the try/catch entirely. Pick ONE deterministic selection approach and assert it works. No fallbacks, no conditional assertions.
5. **`permission-prompt.spec.ts` failure is pre-existing** — this test fails on the base commit too. Don't spend time on it unless you're directly fixing the seeding logic it depends on. Focus on tests that YOUR changes broke or that are fixable.
## Before you start
Read these docs — they are the law: