Record e2e rerun results

REPORT-e2e-rerun.md

@@ -0,0 +1,28 @@
+# E2E Rerun Findings (full server tests)
+
+## Command 1: Full suite
+- Command: `npm run test --workspace=@paseo/server`
+- Result: suite did not complete; multiple failures + skip; run interrupted after ~202s while stuck in `codex-mcp-agent.test.ts` at 3/13.
+
+### Observed failures/skips
+- `packages/server/src/server/agent/providers/codex-agent.test.ts`:
+  - Failing test: "hydrates persisted shell_command tool calls with completed status"
+  - Error: `expected undefined to be truthy`
+  - Likely assertion line: `packages/server/src/server/agent/providers/codex-agent.test.ts:498` (`expect(commandEntry).toBeTruthy()`)
+- Skipped test:
+  - `packages/server/src/server/agent/providers/codex-agent.test.ts`:
+    - "emits permission requests and resolves them when approvals are handled (awaiting Codex support)"
+
+### Hang/interrupt details
+- Run was interrupted manually after ~202s with the suite still at:
+  - `src/server/agent/providers/codex-mcp-agent.test.ts` 3/13 tests
+- No stack trace emitted before the interrupt.
+
+## Command 2: Verbose codex-mcp run (diagnostic)
+- Command: `npx vitest run packages/server/src/server/agent/providers/codex-mcp-agent.test.ts --reporter verbose`
+- Result: interrupted after ~61s; test file reached 6/13 with failure count increasing (4 failed by time of interrupt).
+- Last active tests before interrupt:
+  - "captures tool call inputs/outputs for commands, file changes, file reads, MCP tools, and web search" (test 3/13)
+  - "emits an error timeline item for failed MCP turns" (test 4/13)
+  - "persists session metadata and resumes with history" (test 5/13)
+- No failure stack traces emitted before interruption.

plan.md

@@ -593,10 +593,33 @@ Build a new Codex MCP provider side‑by‑side with the existing Codex SDK prov
 - [x] **Fix**: Resolve typecheck errors in `packages/server/src/server/agent/providers/codex-mcp-agent.ts:348`, `packages/server/src/server/agent/providers/codex-mcp-agent.ts:1674`, `packages/server/src/server/agent/providers/codex-mcp-agent.ts:2945`, `packages/server/src/server/agent/providers/codex-mcp-agent.ts:2959`, `packages/server/src/server/agent/providers/codex-mcp-agent.ts:2970`.
   - **Done (2025-12-25 11:25)**: WHAT: removed unused PatchChangeDetails alias, typed `CODEX_PROVIDER` as a literal, added typed session metadata schemas, and made config payload accept optional model in `packages/server/src/server/agent/providers/codex-mcp-agent.ts:63`, `packages/server/src/server/agent/providers/codex-mcp-agent.ts:1527`, `packages/server/src/server/agent/providers/codex-mcp-agent.ts:1700`. RESULT: codex-mcp provider typecheck errors at the listed lines are resolved; remaining typecheck failures are outside this file. EVIDENCE: `npm run typecheck --workspace=@paseo/server` (only `agent-projections.ts` and `claude-agent.ts` errors reported).
 
-- [ ] **Test (E2E)**: Rerun full server tests after fixes and verify zero failures/skips.
+- [x] **Test (E2E)**: Rerun full server tests after fixes and verify zero failures/skips.
+  - **Done (2025-12-25 11:31)**: WHAT: no files changed. RESULT: full `npm run test --workspace=@paseo/server` run did not reach zero failures/skips; 1 failure in `packages/server/src/server/agent/providers/codex-agent.test.ts` (`expected undefined to be truthy` at `packages/server/src/server/agent/providers/codex-agent.test.ts:498`), 1 skip in the same file, and the run stalled in `packages/server/src/server/agent/providers/codex-mcp-agent.test.ts` (stuck at 3/13) before manual interrupt. EVIDENCE: `REPORT-e2e-rerun.md:1`.
 
 - [ ] **Typecheck**: Rerun `npm run typecheck --workspace=@paseo/server` after fixes and verify zero errors.
 
+- [ ] **Review**: Is Codex MCP ready to go live? Parity and test audit.
+
+  Answer this question: **Can we ship Codex MCP as the default "codex" provider?**
+
+  **Checklist to verify:**
+  1. All `codex-mcp-agent.test.ts` tests pass (zero failures, zero skips)
+  2. All `claude-agent.test.ts` tests pass (for comparison baseline)
+  3. Typecheck passes with zero errors
+  4. Feature parity with Claude provider:
+     - Streaming text/reasoning events
+     - Tool call timeline items (command, file edit, file read, MCP tools)
+     - Permission request/response flow
+     - Session persistence and resume
+     - Abort/interrupt handling
+     - Runtime info (model, provider)
+  5. No workarounds or hacks remaining in `codex-mcp-agent.ts`
+
+  **Output:**
+  - If ready: mark this done and proceed to wire-up
+  - If NOT ready: add specific fix tasks immediately after this one for each gap
+  - Be specific: "missing X" or "Y test fails because Z"
+
 - [ ] **Wire up**: Replace old Codex SDK provider with Codex MCP provider.
 
   - Change the `"codex"` provider ID to use `codex-mcp-agent.ts` instead of `codex-agent.ts`