mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-14 13:22:37 +00:00
Confirm remote permission approvals before reporting success (#6607)
* fix(cli): await permission resolution before closing transport * test(cli): verify permission confirmation over real connections Exercise permission commands through a real WebSocket protocol peer, keeping responses pending until explicit resolution. This catches success before acknowledgement without replacing the client connector or process output. Retain the contributor permission fix and verify both commands, batches, and unconfirmed responses. Co-authored-by: Budi <11062155+budivoogt@users.noreply.github.com> * test(cli): catch permission batches completing after one reply Hold the second acknowledgement until a WebSocket round trip proves the first reply reached the client. A first-reply-only mutation must fail both batch tests. * test(cli): inject permission clients into command regression tests * test(cli): use timer helper for permission continuations * style(cli): format permission regression tests with oxfmt --------- Co-authored-by: Budi <11062155+budivoogt@users.noreply.github.com> Co-authored-by: paseo-bot[bot] <266920839+paseo-bot[bot]@users.noreply.github.com>
This commit is contained in:
paseo-bot[bot]
@@ -1,5 +1,8 @@
|
||||
import type { Command } from "commander";
|
||||
import type { AgentPermissionRequest } from "@getpaseo/protocol/agent-types";
|
||||
import type {
|
||||
AgentPermissionRequest,
|
||||
AgentPermissionResponse,
|
||||
} from "@getpaseo/protocol/agent-types";
|
||||
import { connectToDaemon } from "../../utils/client.js";
|
||||
import type { CommandOptions, ListResult, OutputSchema, CommandError } from "../../output/index.js";
|
||||
|
||||
@@ -55,106 +58,136 @@ export interface PermitAllowOptions extends CommandOptions {
|
||||
host?: string;
|
||||
}
|
||||
|
||||
export async function runAllowCommand(
|
||||
agentIdOrPrefix: string,
|
||||
reqId: string | undefined,
|
||||
options: PermitAllowOptions,
|
||||
_command: Command,
|
||||
): Promise<PermitAllowResult> {
|
||||
// No validation needed - if no reqId provided, allow all by default
|
||||
export interface PermitClient {
|
||||
fetchAgent(options: { agentId: string }): Promise<{
|
||||
agent: { id: string; pendingPermissions?: AgentPermissionRequest[] };
|
||||
} | null>;
|
||||
respondToPermissionAndWait(
|
||||
agentId: string,
|
||||
requestId: string,
|
||||
response: AgentPermissionResponse,
|
||||
): Promise<unknown>;
|
||||
close(): Promise<void>;
|
||||
}
|
||||
|
||||
// Parse input JSON if provided
|
||||
let updatedInput: Record<string, unknown> | undefined;
|
||||
if (options.input) {
|
||||
try {
|
||||
updatedInput = JSON.parse(options.input);
|
||||
} catch (err) {
|
||||
const error: CommandError = {
|
||||
code: "INVALID_JSON",
|
||||
message: `Invalid JSON for --input: ${err instanceof Error ? err.message : String(err)}`,
|
||||
details: 'Provide valid JSON, e.g., --input \'{"key": "value"}\'',
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
export type PermitClientConnector = (
|
||||
options: Parameters<typeof connectToDaemon>[0],
|
||||
) => Promise<PermitClient>;
|
||||
|
||||
const client = await connectToDaemon({ target: options.daemonTarget });
|
||||
export function createAllowCommand(connect: PermitClientConnector = connectToDaemon) {
|
||||
return async function runAllowCommand(
|
||||
agentIdOrPrefix: string,
|
||||
reqId: string | undefined,
|
||||
options: PermitAllowOptions,
|
||||
_command: Command,
|
||||
): Promise<PermitAllowResult> {
|
||||
// No validation needed - if no reqId provided, allow all by default
|
||||
|
||||
try {
|
||||
const fetchResult = await client.fetchAgent({ agentId: agentIdOrPrefix });
|
||||
if (!fetchResult) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "AGENT_NOT_FOUND",
|
||||
message: `Agent not found: ${agentIdOrPrefix}`,
|
||||
details: 'Use "paseo ls" to list available agents',
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
const agent = fetchResult.agent;
|
||||
const resolvedAgentId = agent.id;
|
||||
|
||||
// Get pending permissions for this agent
|
||||
const pendingPermissions = agent.pendingPermissions || [];
|
||||
if (pendingPermissions.length === 0) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "NO_PENDING_PERMISSIONS",
|
||||
message: `No pending permissions for agent ${agent.id.slice(0, 7)}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
|
||||
// Determine which permissions to allow
|
||||
let permissionsToAllow: AgentPermissionRequest[];
|
||||
if (!reqId || options.all) {
|
||||
// Default: allow all pending permissions if no req_id specified
|
||||
// --all flag is kept as an explicit alias for clarity
|
||||
permissionsToAllow = pendingPermissions;
|
||||
} else {
|
||||
// Find permission by ID prefix
|
||||
const permission = pendingPermissions.find((p) => p.id === reqId || p.id.startsWith(reqId));
|
||||
if (!permission) {
|
||||
await client.close();
|
||||
// Parse input JSON if provided
|
||||
let updatedInput: Record<string, unknown> | undefined;
|
||||
if (options.input) {
|
||||
try {
|
||||
updatedInput = JSON.parse(options.input);
|
||||
} catch (err) {
|
||||
const error: CommandError = {
|
||||
code: "PERMISSION_NOT_FOUND",
|
||||
message: `Permission request not found: ${reqId}`,
|
||||
details: `Available requests: ${pendingPermissions.map((p) => p.id.slice(0, 8)).join(", ")}`,
|
||||
code: "INVALID_JSON",
|
||||
message: `Invalid JSON for --input: ${err instanceof Error ? err.message : String(err)}`,
|
||||
details: 'Provide valid JSON, e.g., --input \'{"key": "value"}\'',
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
permissionsToAllow = [permission];
|
||||
}
|
||||
|
||||
// Allow permissions
|
||||
const results: PermissionResponseItem[] = await Promise.all(
|
||||
permissionsToAllow.map(async (permission) => {
|
||||
await client.respondToPermission(resolvedAgentId, permission.id, {
|
||||
behavior: "allow",
|
||||
...(updatedInput ? { updatedInput } : {}),
|
||||
});
|
||||
return toPermissionResponseItem(resolvedAgentId, permission, "allowed");
|
||||
}),
|
||||
);
|
||||
const client = await connect({ target: options.daemonTarget });
|
||||
|
||||
await client.close();
|
||||
try {
|
||||
const fetchResult = await client.fetchAgent({ agentId: agentIdOrPrefix });
|
||||
if (!fetchResult) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "AGENT_NOT_FOUND",
|
||||
message: `Agent not found: ${agentIdOrPrefix}`,
|
||||
details: 'Use "paseo ls" to list available agents',
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
const agent = fetchResult.agent;
|
||||
const resolvedAgentId = agent.id;
|
||||
|
||||
return {
|
||||
type: "list",
|
||||
data: results,
|
||||
schema: permitResponseSchema,
|
||||
};
|
||||
} catch (err) {
|
||||
await client.close().catch(() => {});
|
||||
// Re-throw CommandErrors
|
||||
if (err && typeof err === "object" && "code" in err) {
|
||||
throw err;
|
||||
// Get pending permissions for this agent
|
||||
const pendingPermissions = agent.pendingPermissions || [];
|
||||
if (pendingPermissions.length === 0) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "NO_PENDING_PERMISSIONS",
|
||||
message: `No pending permissions for agent ${agent.id.slice(0, 7)}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
|
||||
// Determine which permissions to allow
|
||||
let permissionsToAllow: AgentPermissionRequest[];
|
||||
if (!reqId || options.all) {
|
||||
// Default: allow all pending permissions if no req_id specified
|
||||
// --all flag is kept as an explicit alias for clarity
|
||||
permissionsToAllow = pendingPermissions;
|
||||
} else {
|
||||
// Find permission by ID prefix
|
||||
const permission = pendingPermissions.find((p) => p.id === reqId || p.id.startsWith(reqId));
|
||||
if (!permission) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "PERMISSION_NOT_FOUND",
|
||||
message: `Permission request not found: ${reqId}`,
|
||||
details: `Available requests: ${pendingPermissions.map((p) => p.id.slice(0, 8)).join(", ")}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
permissionsToAllow = [permission];
|
||||
}
|
||||
|
||||
// Allow permissions
|
||||
const results: PermissionResponseItem[] = await Promise.all(
|
||||
permissionsToAllow.map(async (permission) => {
|
||||
try {
|
||||
await client.respondToPermissionAndWait(resolvedAgentId, permission.id, {
|
||||
behavior: "allow",
|
||||
...(updatedInput ? { updatedInput } : {}),
|
||||
});
|
||||
} catch (err) {
|
||||
const message = err instanceof Error ? err.message : String(err);
|
||||
const error: CommandError = {
|
||||
code: "PERMISSION_RESPONSE_UNCONFIRMED",
|
||||
message: `Permission response unconfirmed for request ${permission.id}: ${message}`,
|
||||
details: 'Use "paseo permit ls" to check whether the request is still pending',
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
return toPermissionResponseItem(resolvedAgentId, permission, "allowed");
|
||||
}),
|
||||
);
|
||||
|
||||
await client.close();
|
||||
|
||||
return {
|
||||
type: "list",
|
||||
data: results,
|
||||
schema: permitResponseSchema,
|
||||
};
|
||||
} catch (err) {
|
||||
await client.close().catch(() => {});
|
||||
// Re-throw CommandErrors
|
||||
if (err && typeof err === "object" && "code" in err) {
|
||||
throw err;
|
||||
}
|
||||
const message = err instanceof Error ? err.message : String(err);
|
||||
const error: CommandError = {
|
||||
code: "ALLOW_PERMISSION_FAILED",
|
||||
message: `Failed to allow permission: ${message}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
const message = err instanceof Error ? err.message : String(err);
|
||||
const error: CommandError = {
|
||||
code: "ALLOW_PERMISSION_FAILED",
|
||||
message: `Failed to allow permission: ${message}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
export const runAllowCommand = createAllowCommand();
|
||||
|
||||
@@ -6,6 +6,7 @@ import {
|
||||
permitResponseSchema,
|
||||
toPermissionResponseItem,
|
||||
type PermissionResponseItem,
|
||||
type PermitClientConnector,
|
||||
} from "./allow.js";
|
||||
|
||||
export type PermitDenyResult = ListResult<PermissionResponseItem>;
|
||||
@@ -17,98 +18,114 @@ export interface PermitDenyOptions extends CommandOptions {
|
||||
host?: string;
|
||||
}
|
||||
|
||||
export async function runDenyCommand(
|
||||
agentIdOrPrefix: string,
|
||||
reqId: string | undefined,
|
||||
options: PermitDenyOptions,
|
||||
_command: Command,
|
||||
): Promise<PermitDenyResult> {
|
||||
// Validate arguments
|
||||
if (!options.all && !reqId) {
|
||||
const error: CommandError = {
|
||||
code: "MISSING_ARGUMENT",
|
||||
message: "Request ID is required unless --all is specified",
|
||||
details: "Usage: paseo permit deny <agent> <req_id> or paseo permit deny <agent> --all",
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
|
||||
const client = await connectToDaemon({ target: options.daemonTarget });
|
||||
|
||||
try {
|
||||
const fetchResult = await client.fetchAgent({ agentId: agentIdOrPrefix });
|
||||
if (!fetchResult) {
|
||||
await client.close();
|
||||
export function createDenyCommand(connect: PermitClientConnector = connectToDaemon) {
|
||||
return async function runDenyCommand(
|
||||
agentIdOrPrefix: string,
|
||||
reqId: string | undefined,
|
||||
options: PermitDenyOptions,
|
||||
_command: Command,
|
||||
): Promise<PermitDenyResult> {
|
||||
// Validate arguments
|
||||
if (!options.all && !reqId) {
|
||||
const error: CommandError = {
|
||||
code: "AGENT_NOT_FOUND",
|
||||
message: `Agent not found: ${agentIdOrPrefix}`,
|
||||
details: 'Use "paseo ls" to list available agents',
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
const agent = fetchResult.agent;
|
||||
const resolvedAgentId = agent.id;
|
||||
|
||||
// Get pending permissions for this agent
|
||||
const pendingPermissions = agent.pendingPermissions || [];
|
||||
if (pendingPermissions.length === 0) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "NO_PENDING_PERMISSIONS",
|
||||
message: `No pending permissions for agent ${agent.id.slice(0, 7)}`,
|
||||
code: "MISSING_ARGUMENT",
|
||||
message: "Request ID is required unless --all is specified",
|
||||
details: "Usage: paseo permit deny <agent> <req_id> or paseo permit deny <agent> --all",
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
|
||||
// Determine which permissions to deny
|
||||
let permissionsToDeny: AgentPermissionRequest[];
|
||||
if (options.all) {
|
||||
permissionsToDeny = pendingPermissions;
|
||||
} else {
|
||||
// Find permission by ID prefix
|
||||
const permission = pendingPermissions.find((p) => p.id === reqId || p.id.startsWith(reqId!));
|
||||
if (!permission) {
|
||||
const client = await connect({ target: options.daemonTarget });
|
||||
|
||||
try {
|
||||
const fetchResult = await client.fetchAgent({ agentId: agentIdOrPrefix });
|
||||
if (!fetchResult) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "PERMISSION_NOT_FOUND",
|
||||
message: `Permission request not found: ${reqId}`,
|
||||
details: `Available requests: ${pendingPermissions.map((p) => p.id.slice(0, 8)).join(", ")}`,
|
||||
code: "AGENT_NOT_FOUND",
|
||||
message: `Agent not found: ${agentIdOrPrefix}`,
|
||||
details: 'Use "paseo ls" to list available agents',
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
permissionsToDeny = [permission];
|
||||
const agent = fetchResult.agent;
|
||||
const resolvedAgentId = agent.id;
|
||||
|
||||
// Get pending permissions for this agent
|
||||
const pendingPermissions = agent.pendingPermissions || [];
|
||||
if (pendingPermissions.length === 0) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "NO_PENDING_PERMISSIONS",
|
||||
message: `No pending permissions for agent ${agent.id.slice(0, 7)}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
|
||||
// Determine which permissions to deny
|
||||
let permissionsToDeny: AgentPermissionRequest[];
|
||||
if (options.all) {
|
||||
permissionsToDeny = pendingPermissions;
|
||||
} else {
|
||||
// Find permission by ID prefix
|
||||
const permission = pendingPermissions.find(
|
||||
(p) => p.id === reqId || p.id.startsWith(reqId!),
|
||||
);
|
||||
if (!permission) {
|
||||
await client.close();
|
||||
const error: CommandError = {
|
||||
code: "PERMISSION_NOT_FOUND",
|
||||
message: `Permission request not found: ${reqId}`,
|
||||
details: `Available requests: ${pendingPermissions.map((p) => p.id.slice(0, 8)).join(", ")}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
permissionsToDeny = [permission];
|
||||
}
|
||||
|
||||
// Deny permissions
|
||||
const results: PermissionResponseItem[] = await Promise.all(
|
||||
permissionsToDeny.map(async (permission) => {
|
||||
try {
|
||||
await client.respondToPermissionAndWait(resolvedAgentId, permission.id, {
|
||||
behavior: "deny",
|
||||
...(options.message ? { message: options.message } : {}),
|
||||
...(options.interrupt ? { interrupt: true } : {}),
|
||||
});
|
||||
} catch (err) {
|
||||
const message = err instanceof Error ? err.message : String(err);
|
||||
const error: CommandError = {
|
||||
code: "PERMISSION_RESPONSE_UNCONFIRMED",
|
||||
message: `Permission response unconfirmed for request ${permission.id}: ${message}`,
|
||||
details: 'Use "paseo permit ls" to check whether the request is still pending',
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
return toPermissionResponseItem(resolvedAgentId, permission, "denied");
|
||||
}),
|
||||
);
|
||||
|
||||
await client.close();
|
||||
|
||||
return {
|
||||
type: "list",
|
||||
data: results,
|
||||
schema: permitResponseSchema,
|
||||
};
|
||||
} catch (err) {
|
||||
await client.close().catch(() => {});
|
||||
// Re-throw CommandErrors
|
||||
if (err && typeof err === "object" && "code" in err) {
|
||||
throw err;
|
||||
}
|
||||
const message = err instanceof Error ? err.message : String(err);
|
||||
const error: CommandError = {
|
||||
code: "DENY_PERMISSION_FAILED",
|
||||
message: `Failed to deny permission: ${message}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
|
||||
// Deny permissions
|
||||
const results: PermissionResponseItem[] = await Promise.all(
|
||||
permissionsToDeny.map(async (permission) => {
|
||||
await client.respondToPermission(resolvedAgentId, permission.id, {
|
||||
behavior: "deny",
|
||||
...(options.message ? { message: options.message } : {}),
|
||||
...(options.interrupt ? { interrupt: true } : {}),
|
||||
});
|
||||
return toPermissionResponseItem(resolvedAgentId, permission, "denied");
|
||||
}),
|
||||
);
|
||||
|
||||
await client.close();
|
||||
|
||||
return {
|
||||
type: "list",
|
||||
data: results,
|
||||
schema: permitResponseSchema,
|
||||
};
|
||||
} catch (err) {
|
||||
await client.close().catch(() => {});
|
||||
// Re-throw CommandErrors
|
||||
if (err && typeof err === "object" && "code" in err) {
|
||||
throw err;
|
||||
}
|
||||
const message = err instanceof Error ? err.message : String(err);
|
||||
const error: CommandError = {
|
||||
code: "DENY_PERMISSION_FAILED",
|
||||
message: `Failed to deny permission: ${message}`,
|
||||
};
|
||||
throw error;
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
export const runDenyCommand = createDenyCommand();
|
||||
|
||||
@@ -0,0 +1,177 @@
|
||||
import { setImmediate as waitForCommandContinuations } from "node:timers/promises";
|
||||
import { Command } from "commander";
|
||||
import type {
|
||||
AgentPermissionRequest,
|
||||
AgentPermissionResponse,
|
||||
} from "@getpaseo/protocol/agent-types";
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { createAllowCommand, type PermitClient } from "./allow.js";
|
||||
import { createDenyCommand } from "./deny.js";
|
||||
|
||||
const agentId = "2d85f428-fdaf-4d98-906f-c583de2b805f";
|
||||
const requests: AgentPermissionRequest[] = [
|
||||
{
|
||||
id: "permission-write",
|
||||
provider: "codex",
|
||||
name: "CodexBash",
|
||||
kind: "tool",
|
||||
},
|
||||
{ id: "permission-edit", provider: "codex", name: "CodexBash", kind: "tool" },
|
||||
];
|
||||
|
||||
class PermissionClient implements PermitClient {
|
||||
readonly pending = [...requests];
|
||||
readonly responses = new Map<string, AgentPermissionResponse>();
|
||||
closed = false;
|
||||
private notifyReceived = () => {};
|
||||
private readonly confirmations = new Map<
|
||||
string,
|
||||
{
|
||||
resolve: () => void;
|
||||
reject: (error: Error) => void;
|
||||
}
|
||||
>();
|
||||
|
||||
async fetchAgent() {
|
||||
return { agent: { id: agentId, pendingPermissions: this.pending } };
|
||||
}
|
||||
|
||||
async respondToPermission(
|
||||
_agentId: string,
|
||||
requestId: string,
|
||||
response: AgentPermissionResponse,
|
||||
) {
|
||||
this.responses.set(requestId, response);
|
||||
this.notifyReceived();
|
||||
}
|
||||
|
||||
async respondToPermissionAndWait(
|
||||
responseAgentId: string,
|
||||
requestId: string,
|
||||
response: AgentPermissionResponse,
|
||||
): Promise<void> {
|
||||
const confirmation = new Promise<void>((resolve, reject) => {
|
||||
this.confirmations.set(requestId, { resolve, reject });
|
||||
});
|
||||
await this.respondToPermission(responseAgentId, requestId, response);
|
||||
await confirmation;
|
||||
}
|
||||
|
||||
async close() {
|
||||
this.closed = true;
|
||||
}
|
||||
|
||||
async waitForResponses(count: number) {
|
||||
while (this.responses.size < count) {
|
||||
await new Promise<void>((resolve) => {
|
||||
this.notifyReceived = resolve;
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
confirm(requestId: string) {
|
||||
const confirmation = this.confirmations.get(requestId);
|
||||
if (!confirmation) throw new Error(`No confirmation waiter: ${requestId}`);
|
||||
this.pending.splice(
|
||||
this.pending.findIndex((request) => request.id === requestId),
|
||||
1,
|
||||
);
|
||||
confirmation.resolve();
|
||||
}
|
||||
|
||||
fail(requestId: string, error: Error) {
|
||||
const confirmation = this.confirmations.get(requestId);
|
||||
if (!confirmation) throw new Error(`No confirmation waiter: ${requestId}`);
|
||||
confirmation.reject(error);
|
||||
}
|
||||
}
|
||||
|
||||
const options = {
|
||||
daemonTarget: { kind: "endpoint" as const, host: "test.invalid" },
|
||||
};
|
||||
const actions = [
|
||||
{ name: "allow", create: createAllowCommand, result: "allowed" },
|
||||
{ name: "deny", create: createDenyCommand, result: "denied" },
|
||||
];
|
||||
for (const action of actions) {
|
||||
describe(`permit ${action.name}`, () => {
|
||||
it("returns success and closes only after confirmation", async () => {
|
||||
const client = new PermissionClient();
|
||||
let completed = false;
|
||||
const command = action.create(async () => client)(
|
||||
agentId,
|
||||
requests[0].id,
|
||||
options,
|
||||
new Command(),
|
||||
);
|
||||
void command.then(
|
||||
() => (completed = true),
|
||||
() => false,
|
||||
);
|
||||
await client.waitForResponses(1);
|
||||
await waitForCommandContinuations();
|
||||
expect(completed).toBe(false);
|
||||
expect(client.closed).toBe(false);
|
||||
expect(client.pending).toEqual(requests);
|
||||
client.confirm(requests[0].id);
|
||||
const result = await command;
|
||||
expect(result.data).toEqual([
|
||||
{
|
||||
requestId: requests[0].id,
|
||||
agentId,
|
||||
agentShortId: agentId.slice(0, 7),
|
||||
name: "CodexBash",
|
||||
result: action.result,
|
||||
},
|
||||
]);
|
||||
expect(client.closed).toBe(true);
|
||||
expect(client.pending).toEqual([requests[1]]);
|
||||
});
|
||||
|
||||
it("waits for every confirmation with --all", async () => {
|
||||
const client = new PermissionClient();
|
||||
let completed = false;
|
||||
const command = action.create(async () => client)(
|
||||
agentId,
|
||||
undefined,
|
||||
{ ...options, all: true },
|
||||
new Command(),
|
||||
);
|
||||
void command.then(
|
||||
() => (completed = true),
|
||||
() => false,
|
||||
);
|
||||
await client.waitForResponses(2);
|
||||
client.confirm(requests[0].id);
|
||||
// Wait beyond the first reply's promise continuations while withholding the second.
|
||||
await waitForCommandContinuations();
|
||||
expect(completed).toBe(false);
|
||||
expect(client.closed).toBe(false);
|
||||
client.confirm(requests[1].id);
|
||||
const result = await command;
|
||||
expect(result.data.map((item) => item.result)).toEqual([action.result, action.result]);
|
||||
expect(client.closed).toBe(true);
|
||||
expect(client.pending).toEqual([]);
|
||||
});
|
||||
|
||||
it("rejects an unconfirmed response without returning success", async () => {
|
||||
const client = new PermissionClient();
|
||||
const command = action.create(async () => client)(
|
||||
agentId,
|
||||
requests[0].id,
|
||||
options,
|
||||
new Command(),
|
||||
);
|
||||
const failure = expect(command).rejects.toMatchObject({
|
||||
code: "PERMISSION_RESPONSE_UNCONFIRMED",
|
||||
message: expect.stringContaining(requests[0].id),
|
||||
details: 'Use "paseo permit ls" to check whether the request is still pending',
|
||||
});
|
||||
await client.waitForResponses(1);
|
||||
client.fail(requests[0].id, new Error("Timeout waiting for message (15000ms)"));
|
||||
await failure;
|
||||
expect(client.closed).toBe(true);
|
||||
expect(client.pending).toEqual(requests);
|
||||
});
|
||||
});
|
||||
}
|
||||
Reference in New Issue
Block a user