puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-11-06 08:24:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): keep timeline still when tapping text

Browse Source 
Selectable Android text takes touch focus. React Native then scrolls focused children using untransformed coordinates, which moves inverted timelines even though the user did not scroll.\n\nSkip that auto-scroll only for touch-focused, selectable, non-editable text in inverted vertical scroll views, preserving normal focus navigation and editable inputs.
This commit is contained in:
Mohamed Boudra
2026-08-31 09:14:44 +02:00
parent f2f93087ed
commit 74a7507814
2 changed files with 41 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
patches/react-native+0.81.5.patch
+37
View File
@@ -0,0 +1,37 @@
diff --git a/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java b/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
index f708543..26df5e0 100644
--- a/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
+++ b/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
@@ -29,6 +29,7 @@ import android.view.ViewGroup;
import android.view.accessibility.AccessibilityNodeInfo;
import android.widget.OverScroller;
import android.widget.ScrollView;
+import android.widget.TextView;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.core.view.ViewCompat;
@@ -425,12 +426,23 @@ public class ReactScrollView extends ScrollView
*/
@Override
public void requestChildFocus(View child, View focused) {
- if (focused != null) {
+ if (focused != null && shouldScrollToFocusedChild(focused)) {
scrollToChild(focused);
}
super.requestChildFocus(child, focused);
}
+ private boolean shouldScrollToFocusedChild(View focused) {
+ if (getScaleY() >= 0 || !focused.isInTouchMode() || !(focused instanceof TextView)) {
+ return true;
+ }
+
+ // Selectable text takes focus when tapped. In inverted lists, scrolling to that focus uses
+ // untransformed coordinates and unexpectedly moves the timeline.
+ TextView textView = (TextView) focused;
+ return !textView.isTextSelectable() || textView.onCheckIsTextEditor();
+ }
+
private int getScrollDelta(View descendent) {
descendent.getDrawingRect(mTempRect);
offsetDescendantRectToMyCoords(descendent, mTempRect);
scripts/postinstall-patches.mjs
+4
View File
@@ -12,6 +12,10 @@ const patchedPackages = [
nodeModulesPath: "node_modules/react-native-markdown-display",
patchPrefix: "react-native-markdown-display+",
},
{
nodeModulesPath: "node_modules/react-native",
patchPrefix: "react-native+",
},
{
nodeModulesPath: "node_modules/react-native-draggable-flatlist",
patchPrefix: "react-native-draggable-flatlist+",