puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-07-29 12:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Measure the turn footer blink from when the footer appears

Browse Source 
Bounding the window at the prompt row conflated two things: the footer arriving a
frame after the row, and the footer leaving the layout and coming back. Bounded from
the footer's first frame, the blink still reproduces, so the footer-ownership race is
real rather than a sampling artifact.
This commit is contained in:
Mohamed Boudra
2026-07-29 12:41:12 +02:00
parent ceb06116f2
commit 58f8737a01
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/app/e2e/agent-consecutive-turns.spec.ts
View File

@@ -89,13 +89,16 @@ async function expectUninterruptedTurn(page: Page): Promise<void> {
if (!state) throw new Error("Turn frames were never recorded");
state.active = false;
const start = state.frames.findIndex((frame) => frame.promptVisible);
// The turn ends when the working indicator goes away for good. Anything before
// that is a blink: the footer left the layout and came back.
// The turn runs from the footer first appearing to it going away for good. Bounding
// it that way keeps this measuring one thing: the footer leaving the layout and
// coming back. How long the footer takes to appear after the row is a separate
// question and does not belong in this assertion.
const firstWorking = state.frames.findIndex((frame) => frame.workingVisible);
const lastWorking = state.frames.reduce(
(latest, frame, index) => (frame.workingVisible ? index : latest),
-1,
);
const turn = state.frames.slice(start, lastWorking + 1);
const turn = state.frames.slice(Math.max(start, firstWorking), lastWorking + 1);
const blinkAt = turn.findIndex((frame) => !frame.workingVisible);
let largestHeightDrop = 0;
let largestHeightDropAt = -1;