puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-11-01 14:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(acp): preserve slash command argument hints (#6920)

Browse Source 
ACP command updates discarded input hints before the autocomplete command list reached consumers. Preserve the advertised hint, retaining the empty hint for commands without input metadata.

Co-authored-by: paseo-bot[bot] <266920839+paseo-bot[bot]@users.noreply.github.com>
Co-authored-by: bwestlund17 <brian.westlund@proton.me>
This commit is contained in:
paseo-bot[bot]
2026-10-15 12:13:18 +02:00
committed by GitHub
co-authored by bwestlund17
parent d3efddb0b5
commit 4d5c3c13d4
2 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/server/agent/providers/acp-agent.ts
+1 -1
View File
@@ -3098,7 +3098,7 @@ export class ACPAgentSession implements AgentSession, ACPClient {
this.cachedCommands = update.availableCommands.map((command) => ({
name: command.name,
description: command.description,
argumentHint: "",
argumentHint: command.input?.hint ?? "",
kind: "command",
}));
this.settleCommandsReady();
packages/server/src/server/agent/providers/generic-acp-agent.commands.test.ts
+16 -5
View File
@@ -8,7 +8,7 @@ import { createTestLogger } from "../../../test-utils/test-logger.js";
import { GenericACPAgentClient } from "./generic-acp-agent.js";
describe("GenericACPAgentClient slash commands", () => {
test("lists commands an agent advertises right after session/new", async () => {
test("preserves argument hints in commands advertised right after session/new", async () => {
await withFakeACPAgent("commands-after-session-new", async (command, cwd) => {
const client = new GenericACPAgentClient({
logger: createTestLogger(),
@@ -17,9 +17,17 @@ describe("GenericACPAgentClient slash commands", () => {
});
const session = await client.createSession({ provider: "acp", cwd });
try {
await expect(session.listCommands?.()).resolves.toEqual([
{ name: "review", description: "Review the diff", argumentHint: "", kind: "command" },
]);
const commands = [
{
name: "review",
description: "Review the diff",
argumentHint: "query",
kind: "command",
},
{ name: "status", description: "Show status", argumentHint: "", kind: "command" },
];
await expect(session.listCommands?.()).resolves.toEqual(commands);
await expect(session.listCommands?.()).resolves.toEqual(commands);
} finally {
await session.close();
}
@@ -91,7 +99,10 @@ rl.on("line", (line) => {
sessionId: "session-1",
update: {
sessionUpdate: "available_commands_update",
availableCommands: [{ name: "review", description: "Review the diff" }],
availableCommands: [
{ name: "review", description: "Review the diff", input: { hint: "query" } },
{ name: "status", description: "Show status" },
],
},
},
},