puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-11-05 16:04:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(terminal): fail the worker launch the same way on every platform

Browse Source 
Windows opens a directory sitting at the launcher's log path, so the
worker started there and the #8810 test never saw a failed launch. An
invalid protocol override makes the worker exit before it writes its
record on every platform.
This commit is contained in:
Mohamed Boudra
2026-11-05 06:04:28 +01:00
parent 4cb84eec8e
commit 43ef214fc1
1 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/terminal/worker-terminal-manager.test.ts
+14 -12
View File
@@ -61,7 +61,6 @@ import {
listTerminalWorkerRecords,
readTerminalWorkerRecord,
terminalWorkerDirectory,
terminalWorkerLogPath,
terminalWorkerRecordPath,
writeTerminalWorkerRecord,
type TerminalWorkerRecord,
@@ -2679,20 +2678,23 @@ it.each([false, true])(
45000,
);
// #8810: a worker that cannot start must not take the daemon down. The launcher cannot open its
// log here (a directory sits at its path), so the launch fails before any worker runs.
// #8810: a worker that cannot start must not take the daemon down. An override that is not a
// protocol version makes the worker fail before it writes its record, on every platform.
it("starts without a worker when the worker cannot start, and launches one once it can", async () => {
const paseoHome = createTemporaryHome();
const logPath = terminalWorkerLogPath(paseoHome);
mkdirSync(logPath);
const previous = process.env[TERMINAL_WORKER_PROTOCOL_OVERRIDE_ENV];
process.env[TERMINAL_WORKER_PROTOCOL_OVERRIDE_ENV] = "not-a-version";
try {
manager = await startRealWorkerManager({ paseoHome });
expect(await workerRecords(paseoHome)).toEqual([]);
await expect(
manager.createTerminal({ workspaceId: "ws-no-worker", cwd: paseoHome }),
).rejects.toThrow(TerminalWorkerLaunchError);
} finally {
if (previous === undefined) delete process.env[TERMINAL_WORKER_PROTOCOL_OVERRIDE_ENV];
else process.env[TERMINAL_WORKER_PROTOCOL_OVERRIDE_ENV] = previous;
}
manager = await startRealWorkerManager({ paseoHome });
expect(await workerRecords(paseoHome)).toEqual([]);
await expect(
manager.createTerminal({ workspaceId: "ws-no-worker", cwd: paseoHome }),
).rejects.toThrow(TerminalWorkerLaunchError);
rmSync(logPath, { recursive: true });
trackTerminal(await manager.createTerminal({ workspaceId: "ws-no-worker", cwd: paseoHome }));
expect(await workerRecords(paseoHome)).toHaveLength(1);
}, 30000);