puter/paseo
1
0
Fork 0
mirror of https://github.com/getpaseo/paseo.git synced 2026-07-29 12:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address doctor health check code review findings

Browse Source
This commit is contained in:
Zi Makki
2026-03-09 12:55:44 +01:00
parent 3a4b463deb
commit 15d7763d0b
2 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/cli/src/commands/doctor.ts
View File

@@ -16,11 +16,11 @@ interface DoctorRow {
function statusIndicator(status: DoctorCheckResult['status']): string {
switch (status) {
case 'ok':
return 'ok'
return '✓ ok'
case 'warn':
return 'warn'
return '⚠ warn'
case 'error':
return 'error'
return '✗ error'
}
}
@@ -41,9 +41,10 @@ function createDoctorSchema(report: DoctorReport): OutputSchema<DoctorRow> {
header: 'STATUS',
field: 'status',
color: (value) => {
if (value === 'ok') return 'green'
if (value === 'warn') return 'yellow'
if (value === 'error') return 'red'
const v = typeof value === 'string' ? value : ''
if (v.includes('ok')) return 'green'
if (v.includes('warn')) return 'yellow'
if (v.includes('error')) return 'red'
return undefined
},
},

18
packages/server/src/server/doctor/checks/provider-checks.ts
View File

@@ -14,9 +14,12 @@ const PROVIDERS: ProviderDef[] = [
{ name: "opencode", command: "opencode", label: "OpenCode CLI" },
];
const EXEC_TIMEOUT_MS = 5000;
function whichCommand(command: string): string | null {
const whichBin = process.platform === "win32" ? "where" : "which";
try {
return execFileSync("which", [command], { encoding: "utf8" }).trim() || null;
return execFileSync(whichBin, [command], { encoding: "utf8", timeout: EXEC_TIMEOUT_MS }).trim() || null;
} catch {
return null;
}
@@ -24,14 +27,13 @@ function whichCommand(command: string): string | null {
function getVersion(binaryPath: string): string | null {
try {
return execFileSync(binaryPath, ["--version"], { encoding: "utf8" }).trim() || null;
return execFileSync(binaryPath, ["--version"], { encoding: "utf8", timeout: EXEC_TIMEOUT_MS }).trim() || null;
} catch {
return null;
}
}
function checkBinary(provider: ProviderDef): DoctorCheckResult {
const binaryPath = whichCommand(provider.command);
function checkBinary(provider: ProviderDef, binaryPath: string | null): DoctorCheckResult {
if (binaryPath) {
return {
id: `provider.${provider.name}.binary`,
@@ -48,8 +50,7 @@ function checkBinary(provider: ProviderDef): DoctorCheckResult {
};
}
function checkVersion(provider: ProviderDef): DoctorCheckResult {
const binaryPath = whichCommand(provider.command);
function checkVersion(provider: ProviderDef, binaryPath: string | null): DoctorCheckResult {
if (!binaryPath) {
return {
id: `provider.${provider.name}.version`,
@@ -80,8 +81,9 @@ function checkVersion(provider: ProviderDef): DoctorCheckResult {
export async function runProviderChecks(): Promise<DoctorCheckResult[]> {
const results: DoctorCheckResult[] = [];
for (const provider of PROVIDERS) {
results.push(checkBinary(provider));
results.push(checkVersion(provider));
const binaryPath = whichCommand(provider.command);
results.push(checkBinary(provider, binaryPath));
results.push(checkVersion(provider, binaryPath));
}
return results;
}