fix(pi): settle foreground workflow tools when the process exits

Deliver a failed terminal mapping for calls still owned by the Pi process. Detached runs have already returned their tool result, so their adapter-owned status is preserved.
This commit is contained in:
paseo-bot[bot]
2026-10-17 18:20:11 +02:00
parent e5f8c7ac25
commit 02216d601c
2 changed files with 55 additions and 0 deletions
@@ -2101,6 +2101,52 @@ describe("PiRpcAgentSession", () => {
});
});
test("fails an unfinished workflow on process exit while preserving detached runs", async () => {
const { pi, session, events } = await createSession();
onTestFinished(() => session.close());
const updates: AgentStreamEvent[] = [];
session.subscribe((event) => updates.push(event));
await session.startTurn("run workflows");
const runtime = pi.latestSession();
runtime.emit({
type: "tool_execution_start",
toolCallId: "detached",
toolName: "subagent",
args: { workflowScript: "return await runs.all([]);", async: true },
});
runtime.emit({
type: "tool_execution_end",
toolCallId: "detached",
toolName: "subagent",
result: {
details: {
mode: "workflow",
runId: "detached-run",
asyncId: "detached-run",
asyncDir: "/nonexistent/pi-exit-regression",
results: [],
},
},
});
runtime.emit({
type: "tool_execution_start",
toolCallId: "foreground",
toolName: "subagent",
args: { workflowScript: "return await runs.all([]);", async: false },
});
runtime.emit({ type: "process_exit", error: "Pi exited" });
await expect(events.nextTurnFailure()).resolves.toMatchObject({ error: "Pi exited" });
const statuses = (id: string) =>
updates.flatMap((event) =>
event.type === "provider_subagent" && event.event.type === "upsert" && event.event.id === id
? [event.event.status]
: [],
);
expect(statuses("foreground")).toEqual(["running", "failed"]);
expect(statuses("detached")).toEqual(["running", "running"]);
});
test("fails an autonomous turn when the Pi process exits before settlement", async () => {
const { pi, events } = await createSession();
const fakeSession = pi.latestSession();
@@ -2108,6 +2108,15 @@ export class PiRpcAgentSession implements AgentSession {
}
private handleProcessExit(error: string): void {
for (const [toolCallId, toolCall] of this.activeToolCalls) {
this.handleToolExecutionEnd({
type: "tool_execution_end",
toolCallId,
toolName: toolCall.toolName,
isError: true,
result: { content: [{ type: "text", text: error }] },
});
}
this.rejectAllExtensionResults(new Error(error));
this.interruptingTurn = null;
if (!this.activeTurnId && !this.activeTurnStarted) {