growqr-app/growqr-backend
3
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(resume): proxy empty success responses

Browse Source
This commit is contained in:
-Puter
2026-07-14 02:22:32 +05:30
parent a2292dd155
commit 8d43bea58e
3 changed files with 39 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
package.json
View File

@@ -15,6 +15,7 @@
"test:interview-user-identity": "tsx scripts/interview-user-identity.test.ts",
"test:ws-ticket": "tsx scripts/ws-ticket.test.ts",
"test:roleplay-drafts": "tsx scripts/roleplay-drafts.test.ts",
"test:resume-gateway": "tsx scripts/resume-gateway.test.ts",
"start": "node dist/index.js",
"typecheck": "tsc -p tsconfig.json --noEmit",
"workflows:smoke": "tsx src/workflows/smoke-test.ts",

37
scripts/resume-gateway.test.ts Normal file
View File

@@ -0,0 +1,37 @@
import assert from "node:assert/strict";
import { serviceRoutes } from "../src/routes/services.js";
const originalFetch = globalThis.fetch;
const requests: Request[] = [];
globalThis.fetch = (async (input, init) => {
const request = new Request(input, init);
requests.push(request);
const path = new URL(request.url).pathname;
if (request.method === "DELETE" && path.endsWith("/api/v1/resumes/resume-1")) {
return new Response(null, { status: 204 });
}
return new Response("<html>preview</html>", {
status: 200,
headers: { "content-type": "text/html; charset=utf-8" },
});
}) as typeof fetch;
const app = serviceRoutes({ skipAuth: true });
try {
const preview = await app.request("http://backend.test/resume/export/resumes/resume-1/preview");
assert.equal(preview.status, 200);
assert.equal(await preview.text(), "<html>preview</html>");
assert.equal(new URL(requests[0]!.url).pathname, "/api/v1/export/resumes/resume-1/preview");
assert.equal(requests[0]!.headers.get("x-growqr-user"), "user_test");
assert.match(requests[0]!.headers.get("authorization") ?? "", /^Bearer /);
const deleted = await app.request("http://backend.test/resume/resumes/resume-1", { method: "DELETE" });
assert.equal(deleted.status, 204);
assert.equal(await deleted.text(), "");
assert.equal(new URL(requests[1]!.url).pathname, "/api/v1/resumes/resume-1");
} finally {
globalThis.fetch = originalFetch;
}
console.log("resume gateway proxy tests passed");

2
src/routes/services.ts
View File

@@ -483,7 +483,7 @@ async function proxyResumeRequest(req: Request, rest: string, userId: string) {
mission,
}).catch((err) => log.warn({ err, path: normalizedRest }, "failed to record resume gateway event"));
return new Response(responseBuffer, {
return new Response(res.status === 204 || res.status === 205 || res.status === 304 ? null : responseBuffer, {
status: res.status,
statusText: res.statusText,
headers: decodedProxyHeaders(res.headers),