Merge commit '36c66dd290d3ce6eb1ccd310d0c658d4a32bb8eb' as 'repos/effect'

repos/effect/packages/sql/pg/test/TransactionAcquire.test.ts

@@ -0,0 +1,52 @@
+import { PgClient } from "@effect/sql-pg"
+import { assert, it } from "@effect/vitest"
+import { Effect } from "effect"
+import * as Reactivity from "effect/unstable/reactivity/Reactivity"
+
+type ConnectCb = (cause: unknown, client?: unknown, release?: (cause?: Error) => void) => void
+
+const makeFailingPool = (cause: unknown) => ({
+  options: {},
+  ending: false,
+  connect: (cb: ConnectCb) => cb(cause, undefined, () => undefined),
+  query: () => undefined
+})
+
+const makeMissingClientPool = () => ({
+  options: {},
+  ending: false,
+  connect: (cb: ConnectCb) => cb(null, undefined, () => undefined),
+  query: () => undefined
+})
+
+it.effect("withTransaction surfaces acquire failures instead of defecting", () =>
+  Effect.gen(function*() {
+    const sql = yield* PgClient.fromPool({
+      acquire: Effect.succeed(makeFailingPool({ code: "08006" }) as any)
+    })
+
+    const error = yield* Effect.flip(sql.withTransaction(sql`SELECT 1`))
+
+    assert.strictEqual(error.reason._tag, "ConnectionError")
+    assert.strictEqual(error.reason.message, "Failed to acquire connection for transaction")
+    assert.strictEqual(error.reason.operation, "acquireConnection")
+  }).pipe(
+    Effect.scoped,
+    Effect.provide(Reactivity.layer)
+  ))
+
+it.effect("withTransaction surfaces missing-client acquire as ConnectionError", () =>
+  Effect.gen(function*() {
+    const sql = yield* PgClient.fromPool({
+      acquire: Effect.succeed(makeMissingClientPool() as any)
+    })
+
+    const error = yield* Effect.flip(sql.withTransaction(sql`SELECT 1`))
+
+    assert.strictEqual(error.reason._tag, "ConnectionError")
+    assert.strictEqual(error.reason.message, "Failed to acquire connection for transaction")
+    assert.strictEqual(error.reason.operation, "acquireConnection")
+  }).pipe(
+    Effect.scoped,
+    Effect.provide(Reactivity.layer)
+  ))