Slices 2-4: Work becomes executable
Domain primitives: versioned WorkDefinition/DesignPacket with risk, questions, and approval gates; lifecycle transition table with invalidation rules; Resolver (Run/Attempt/outcomes/CodingKitV0); provider-neutral HarnessRuntime with normalized events and a deterministic FakeHarnessLive that always reaches a terminal classification and never claims implementation. Convex durable model: workDefinitions, workQuestions, workApprovals, designPackets, workSlices, workRuns, workAttempts, workAttemptEvents tables; broadened works.status union; generalized workEvents with optional signalId, referenceId, and payloadJson. Authenticated commands for definition request/ save/revise/approve, question answer/withdraw, design save/revise/approve, and simulated execution start/cancel/retry with leased attempts, checkpointed events, and expired-lease reconciliation. Private work-planner FLUE agent with proposal-only tools (definition, design, question). Convex validates and stores every proposal; FLUE never approves or advances Work. Expanded Work card with Outcome, Design, and Build sections wired to the new mutations. Slice 1 conversation and provenance preserved.
This commit is contained in:
151
packages/backend/convex/workPlanning.test.ts
Normal file
151
packages/backend/convex/workPlanning.test.ts
Normal file
@@ -0,0 +1,151 @@
|
||||
import { convexTest } from "convex-test";
|
||||
import { anyApi, makeFunctionReference } from "convex/server";
|
||||
import { describe, expect, test } from "vitest";
|
||||
|
||||
import type { Id } from "./_generated/dataModel";
|
||||
import schema from "./schema";
|
||||
|
||||
declare global {
|
||||
interface ImportMeta {
|
||||
readonly glob: (pattern: string) => Record<string, () => Promise<unknown>>;
|
||||
}
|
||||
}
|
||||
|
||||
const modules = import.meta.glob("./**/*.ts");
|
||||
const api = anyApi;
|
||||
const executeFakeAttemptRef = makeFunctionReference<
|
||||
"action",
|
||||
{ attemptId: string; scenario: "success" }
|
||||
>("workExecution:executeFakeAttempt");
|
||||
const identity = { tokenIdentifier: "https://convex.test|planner-user" };
|
||||
|
||||
describe("Work planning and execution commands", () => {
|
||||
test("binds approvals to exact versions and admits a fake Run only from Ready", async () => {
|
||||
const t = convexTest({ modules, schema });
|
||||
const fixture = await t.withIdentity(identity).run(async (ctx) => {
|
||||
const organizationId = await ctx.db.insert("organizations", {
|
||||
createdAt: 1,
|
||||
createdBy: identity.tokenIdentifier,
|
||||
kind: "personal",
|
||||
name: "Personal",
|
||||
});
|
||||
await ctx.db.insert("organizationMembers", {
|
||||
organizationId,
|
||||
userId: identity.tokenIdentifier,
|
||||
role: "owner",
|
||||
createdAt: 1,
|
||||
});
|
||||
const projectId = await ctx.db.insert("projects", {
|
||||
createdAt: 1,
|
||||
name: "Zopu",
|
||||
normalizedSourceUrl: "https://example.com/zopu",
|
||||
organizationId,
|
||||
repositoryPath: "puter/zopu",
|
||||
sourceHost: "example.com",
|
||||
sourceUrl: "https://example.com/zopu",
|
||||
updatedAt: 1,
|
||||
});
|
||||
const workId = await ctx.db.insert("works", {
|
||||
organizationId,
|
||||
projectId,
|
||||
title: "Executable work",
|
||||
objective: "Prove the flow",
|
||||
status: "proposed",
|
||||
createdAt: 1,
|
||||
updatedAt: 1,
|
||||
});
|
||||
return { projectId, workId };
|
||||
});
|
||||
|
||||
await t
|
||||
.withIdentity(identity)
|
||||
.mutation(api.workPlanning.requestDefinition, { workId: fixture.workId });
|
||||
const definition = await t
|
||||
.withIdentity(identity)
|
||||
.mutation(api.workPlanning.saveDefinitionProposal, {
|
||||
workId: fixture.workId,
|
||||
payloadJson: JSON.stringify({
|
||||
problem: "Need a proof",
|
||||
desiredOutcome: "A terminal simulation",
|
||||
affectedUsers: ["user"],
|
||||
inScope: ["fake"],
|
||||
outOfScope: [],
|
||||
acceptanceCriteria: ["terminal"],
|
||||
constraints: [],
|
||||
assumptions: [],
|
||||
questions: [],
|
||||
risk: "low",
|
||||
requiredArtifacts: ["events"],
|
||||
}),
|
||||
});
|
||||
await t
|
||||
.withIdentity(identity)
|
||||
.mutation(api.workPlanning.approveDefinition, {
|
||||
workId: fixture.workId,
|
||||
version: definition.version,
|
||||
});
|
||||
const design = await t
|
||||
.withIdentity(identity)
|
||||
.mutation(api.workPlanning.saveDesignProposal, {
|
||||
workId: fixture.workId,
|
||||
payloadJson: JSON.stringify({
|
||||
impactMap: { files: [], modules: [], risks: [], summary: "small" },
|
||||
architectureSummary: "fake",
|
||||
fileTreeDelta: [],
|
||||
callFlowDelta: [],
|
||||
keyInterfaces: [],
|
||||
invariants: ["terminal"],
|
||||
concerns: [],
|
||||
slices: [
|
||||
{
|
||||
id: "slice-1",
|
||||
title: "fake",
|
||||
objective: "fake",
|
||||
observableBehavior: "event",
|
||||
codeBoundaries: ["runtime"],
|
||||
evidenceRequirements: ["event"],
|
||||
verification: ["assert"],
|
||||
reviewRequired: false,
|
||||
dependsOn: [],
|
||||
},
|
||||
],
|
||||
evidenceRequirements: ["event"],
|
||||
tradeoffs: [],
|
||||
}),
|
||||
});
|
||||
await t.withIdentity(identity).mutation(api.workPlanning.approveDesign, {
|
||||
workId: fixture.workId,
|
||||
definitionVersion: definition.version,
|
||||
designVersion: design.version,
|
||||
});
|
||||
const started = await t
|
||||
.withIdentity(identity)
|
||||
.mutation(api.workExecution.startSimulatedExecution, {
|
||||
workId: fixture.workId,
|
||||
scenario: "success",
|
||||
sliceId: "slice-1",
|
||||
});
|
||||
expect(started.runId).toBeTruthy();
|
||||
const state = await t.run(async (ctx) => ctx.db.get(fixture.workId));
|
||||
expect(state?.status).toBe("executing");
|
||||
expect(state?.definitionApprovalVersion).toBe(definition.version);
|
||||
expect(state?.designApprovalVersion).toBe(design.version);
|
||||
await t.action(executeFakeAttemptRef, {
|
||||
attemptId: String(started.attemptId),
|
||||
scenario: "success",
|
||||
});
|
||||
const completed = await t.run(async (ctx) => ({
|
||||
attempt: await ctx.db
|
||||
.query("workAttempts")
|
||||
.withIndex("by_run_and_number", (q) => q.eq("runId", started.runId))
|
||||
.unique(),
|
||||
events: await ctx.db.query("workAttemptEvents").collect(),
|
||||
run: await ctx.db.get(started.runId as Id<"workRuns">),
|
||||
work: await ctx.db.get(fixture.workId),
|
||||
}));
|
||||
expect(completed.work?.status).toBe("ready");
|
||||
expect(completed.run?.terminalClassification).toBe("Succeeded");
|
||||
expect(completed.attempt?.status).toBe("terminal");
|
||||
expect(completed.events.length).toBeGreaterThan(0);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user