mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-30 13:13:25 +00:00
Keep app network delivery outside worker capture deadlines and hold captured geometry until parsing commits. Reconnect readiness is independent of the capture revision used for live-output deduplication. Remove redundant replay acknowledgements and hard cut the unreleased worker contract at protocol 5 while preserving bounded transports.
7.3 KiB
7.3 KiB
Terminal performance
How terminal output stays low-latency, what the invariants are, and how to measure before/after any change to the pipeline. Read this before touching anything under packages/server/src/terminal/ or packages/app/src/terminal/runtime/.
The pipeline
pty (node-pty, forked worker process)
→ headless xterm parse (worker, ANSI replay fidelity)
→ TerminalOutputCoalescer (worker, ≤1 socket frame per 5ms per terminal)
→ framed local socket → daemon main process
→ TerminalOutputCoalescer (per client stream, terminal-session-controller.ts)
→ binary ws frame (2-byte header + raw bytes)
→ client decode (daemon-client.ts) → stream router → emulator runtime
→ xterm.write (back-to-back; xterm batches internally)
Terminal frames share the daemon main event loop with all agent traffic. The eventLoopDelay block in the ws_runtime_metrics log line (every 30s in daemon.log) is the ground truth for "the daemon is busy" — p99/max there directly bound worst-case terminal frame delay.
Invariants (the easy-to-break ones)
- Replay is incremental across the daemon and SDK. The worker retains 1,000 history rows. Capable clients request their configured history; the worker bounds it by retained history. Older apps retain their own 200-row request. Explicit SDK history demand is unchanged against older ANSI hosts, which apply their existing 500-row ceiling. Begin resets once, chunks keep a streaming UTF-8 decoder/parser, and each renderer suppresses generated replies while parsing replay. Never concatenate capable replay chunks to feed the renderer.
- Coalescers are leading+trailing throttles. The first chunk after an idle window flushes immediately (synchronously); only sustained bursts wait for the trailing timer. Reverting to trailing-only adds a full window (~5ms) to every keystroke echo.
- Output coalescing happens in the worker, before IPC. One socket frame per pty chunk was a main-loop flood under build output. Non-output messages (snapshot/snapshotReady/titleChange/exit) must flush the coalescer first so ordering is preserved.
- Replay delivery is isolated per viewer. Live worker output never waits for app delivery. Each daemon stream owns its bounded live tail and revision deduplication; a slow or failed replay cannot pause another viewer of the same terminal.
- Replay geometry belongs to the parser queue. Native measurements and web fits must leave the captured dimensions intact through every chunk's commit. Apply the latest measured size after replay, before live bytes; clear, replacement and disposal must release that geometry ownership. A layout effect must not resize the renderer directly during replay.
- Coalesced output carries the LAST chunk's revision. Snapshot replay dedup (
replayTerminalOutputAfterSnapshot) skips buffered output withrevision <= replayRevision; a merged batch with a lower revision would be wrongly skipped (lost output). - The input-mode tracker runs once per process boundary, not per hop. The worker owns the authoritative tracker; the daemon caches the replay preamble from replay responses and
snapshotReadymessages. Do not reintroduce a per-chunkfeed()on the daemon main loop. - Snapshot catch-up is backpressure-gated. A stream falls back to a full snapshot only when
outputBytesSinceSnapshot > MAX_TERMINAL_OUTPUT_FRAME_BYTES(256KB) and the client transport reportsbufferedAmount > MAX_CLIENT_BUFFERED_BYTES(4MB). A client that keeps draining streams continuously, no matter how much output is produced. Before this gate existed, every 256KB of build output dropped a frame and forced a full JSON cell-grid snapshot (~200k objects across IPC) — the historical source of spiky lag and GC hitches. - Plugin daemon sessions report IPC queue bytes. Their virtual socket increments
bufferedAmountbeforeprocess.sendand decrements it only in the send callback. Text and binary frames share that ordered queue, so the normal snapshot catch-up and physical high-water gates remain valid for server-side plugin SDK traffic. - Client output writes are not serialized per frame. The emulator runtime drains contiguous plain writes straight into xterm (which buffers internally). Only barrier ops (
clear,snapshot,suppressInputwrites) wait — behind a zero-length sentinel write — so resets can't interleave with in-flight output. - Find preserves the inspected xterm viewport, including at the live bottom. Keep its output anchor inside the existing batched write path. Serializing output to preserve a search result would add terminal latency.
- Retained terminal tabs in the focused workspace keep their streams. Hidden mounted terminals continue applying output, so switching tabs does not resubscribe or request a fresh snapshot. The retained-panel LRU bounds the number of live streams; terminals in an unfocused workspace detach.
- Terminal size has one daemon-owned claimant. Focus and direct interaction send a
claim; later geometry changes from that connection sendupdate. A claim transfers ownership even when the dimensions are unchanged, while an update from any other connection is ignored. This lets an owning pane follow splits and keyboard insets without allowing an idle phone or browser to steal the PTY size.
Measuring
- Node-only benchmark (fast iteration, server pipeline):
npx tsx scripts/benchmark-terminal-latency.ts. Boots an isolated daemon (freshPASEO_HOME, random port — never 6767), measures echo latency percentiles, burst jitter, and snapshot counts under ramped mock-agent load. Writes JSON to/tmp/paseo-terminal-bench/. Healthy numbers (2026-06): echo p50 ~2.3ms, p95 ~3.3ms, a 2MB burst fully streamed withsnap=0. - Browser perf specs (user-perceived path): gated behind
PASEO_TERMINAL_PERF_E2E=1—packages/app/e2e/browser/terminal-performance.spec.tsandpackages/app/e2e/browser/terminal-keystroke-stress.spec.ts(per-stage keydown→xterm-commit breakdown under mock-agent load). Healthy: keydown→commit p50 ~18ms under 600-key burst. - Production: grep
daemon.logforws_runtime_metricsand readeventLoopDelay+bufferedAmount. - Git pressure: the same log line includes
git.commands(limiter occupancy, queue age, queue wait, execution time, failures, timeouts, and top operations),git.workspaceService(daemon-global Git observer ownership), and per-session workspace Git subscription totals underruntime. Queue wait and execution time are separate because the Git command timeout begins only after a command acquires a limiter slot.
Known remaining contention (follow-up candidates)
- A single large
agent_streammessage (e.g. a 250KB diff payload) measurably delays terminal echo (~100ms-class dips) — cost is split between daemon serialization and app-side parse/render on the shared browser main thread. See agent-stream-performance.md for that pipeline's own budgets. - Relay-attached clients pay pure-JS tweetnacl encryption on the daemon main loop (
packages/relay/src/encrypted-channel.ts). Negotiated binary application frames stay binary ciphertext and avoid base64 encode/decode; text and mixed-version traffic remain base64 WebSocket text frames. sendToClientre-stringifies session messages per socket; only matters for multi-socket connections.