mirror of
https://github.com/getpaseo/paseo.git
synced 2026-07-29 12:01:31 +00:00
d6f21b3568
What I changed:\n- Refactored worktree path handling in worktree ls into focused helpers: resolvePaseoHomePath, resolvePaseoWorktreesDir, and isAgentInManagedWorktree.\n- Switched worktree name extraction to node:path basename for clearer intent and path handling.\n- Added a focused regression test (20-worktree-ls-paths.test.ts) covering explicit PASEO_HOME and fallback home resolution behavior.\n\nReasoning:\n- The prior implementation repeated path derivation inline inside the agent loop, mixed decision logic with mapping, and relied on string concatenation for filesystem boundaries.\n- Extracting this logic reduces cognitive load, keeps policy in one place, and makes behavior directly testable without daemon dependencies.\n\nVerification:\n- npx tsx packages/cli/tests/20-worktree-ls-paths.test.ts\n- npx tsx packages/cli/tests/14-worktree.test.ts\n- npm run typecheck (all workspaces)\n\nNotes for next agent:\n- Similar inline PASEO_HOME/path derivation still exists in other CLI commands; these helpers can be reused to continue consistency work.\n- No behavior change intended for command output or error semantics; this was a structural-only refactor aligned with refactor-skill constraints.
39 lines
1.2 KiB
TypeScript
39 lines
1.2 KiB
TypeScript
#!/usr/bin/env npx tsx
|
|
|
|
import assert from 'node:assert'
|
|
import { homedir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { resolvePaseoHomePath, resolvePaseoWorktreesDir } from '../src/commands/worktree/ls.js'
|
|
|
|
console.log('=== Worktree LS Path Helper Tests ===\n')
|
|
|
|
const originalPaseoHome = process.env.PASEO_HOME
|
|
|
|
try {
|
|
{
|
|
console.log('Test 1: resolves explicit PASEO_HOME when set')
|
|
process.env.PASEO_HOME = '/tmp/paseo-explicit-home'
|
|
|
|
assert.strictEqual(resolvePaseoHomePath(), '/tmp/paseo-explicit-home')
|
|
assert.strictEqual(resolvePaseoWorktreesDir(), '/tmp/paseo-explicit-home/worktrees')
|
|
console.log('\u2713 explicit PASEO_HOME is respected\n')
|
|
}
|
|
|
|
{
|
|
console.log('Test 2: falls back to homedir/.paseo when PASEO_HOME is unset')
|
|
delete process.env.PASEO_HOME
|
|
|
|
assert.strictEqual(resolvePaseoHomePath(), join(homedir(), '.paseo'))
|
|
assert.strictEqual(resolvePaseoWorktreesDir(), join(homedir(), '.paseo', 'worktrees'))
|
|
console.log('\u2713 fallback home path is derived from os.homedir()\n')
|
|
}
|
|
} finally {
|
|
if (originalPaseoHome === undefined) {
|
|
delete process.env.PASEO_HOME
|
|
} else {
|
|
process.env.PASEO_HOME = originalPaseoHome
|
|
}
|
|
}
|
|
|
|
console.log('=== All worktree ls path helper tests passed ===')
|