mirror of
https://github.com/getpaseo/paseo.git
synced 2026-07-29 12:01:31 +00:00
What changed: - Updated packages/cli/tests/03-daemon.test.ts to match current daemon command semantics where reports local state and exits successfully when stopped. - Removed host-based failure assumptions from status/status --json checks and asserted deterministic output for an isolated PASEO_HOME. - Hardened restart coverage to use an isolated random port and explicit cleanup via . - Added best-effort forced cleanup in to avoid leaking a daemon process if assertions fail mid-test. Reasoning: - Recent CLI refactors switched from connection-failure behavior to local PID/config introspection, so the old test expectation () became incorrect and flaky. - The restart path can occasionally exceed graceful stop timeout immediately after spawn; forced cleanup makes the test reliable without changing product behavior. - This is a behavior-preserving test hardening refactor aligned with the refactor skill contract. Verification: - npx tsx packages/cli/tests/03-daemon.test.ts - npm run typecheck Accomplishments for next agent: - now validates current status semantics and no longer depends on transient host connectivity assumptions. - Restart coverage now cleans up deterministically, reducing local test pollution and follow-on failures. Challenges / notes for next agent: - Restart cleanup still depends on process management timing; this test now uses cleanup intentionally to keep CI/dev runs stable. - If you later tighten restart lifecycle behavior, consider adding a dedicated unit-level test around stop timeout + escalation in local daemon utilities.
115 lines
4.9 KiB
TypeScript
115 lines
4.9 KiB
TypeScript
#!/usr/bin/env npx tsx
|
|
|
|
/**
|
|
* Phase 2: Daemon Command Tests
|
|
*
|
|
* Tests daemon commands with an isolated PASEO_HOME.
|
|
*
|
|
* Tests:
|
|
* - daemon --help shows subcommands
|
|
* - daemon pair prints a local pairing link without requiring a running daemon
|
|
* - daemon status reports stopped when daemon not running
|
|
* - daemon status --json outputs valid JSON
|
|
* - daemon stop handles daemon not running gracefully
|
|
* - daemon restart starts the daemon and can be cleaned up
|
|
*/
|
|
|
|
import assert from 'node:assert'
|
|
import { $ } from 'zx'
|
|
import { mkdtemp, rm } from 'fs/promises'
|
|
import { tmpdir } from 'os'
|
|
import { join } from 'path'
|
|
|
|
$.verbose = false
|
|
|
|
console.log('=== Daemon Commands ===\n')
|
|
|
|
// Keep restart off default 6767 to avoid collisions with any existing daemon.
|
|
const port = 10000 + Math.floor(Math.random() * 50000)
|
|
const paseoHome = await mkdtemp(join(tmpdir(), 'paseo-test-home-'))
|
|
|
|
try {
|
|
// Test 1: daemon --help shows subcommands
|
|
{
|
|
console.log('Test 1: daemon --help shows subcommands')
|
|
const result = await $`npx paseo daemon --help`.nothrow()
|
|
assert.strictEqual(result.exitCode, 0, 'daemon --help should exit 0')
|
|
assert(result.stdout.includes('start'), 'help should mention start')
|
|
assert(result.stdout.includes('status'), 'help should mention status')
|
|
assert(result.stdout.includes('stop'), 'help should mention stop')
|
|
assert(result.stdout.includes('restart'), 'help should mention restart')
|
|
assert(result.stdout.includes('pair'), 'help should mention pair')
|
|
console.log('✓ daemon --help shows subcommands\n')
|
|
}
|
|
|
|
// Test 2: daemon pair works without daemon process
|
|
{
|
|
console.log('Test 2: daemon pair prints local pairing URL')
|
|
const result =
|
|
await $`PASEO_HOME=${paseoHome} npx paseo daemon pair`.nothrow()
|
|
assert.strictEqual(result.exitCode, 0, 'daemon pair should succeed')
|
|
assert(result.stdout.includes('Scan to pair:'), 'output should include scan header')
|
|
assert(result.stdout.includes('#offer='), 'output should include pairing offer fragment')
|
|
console.log('✓ daemon pair prints local pairing URL\n')
|
|
}
|
|
|
|
// Test 3: daemon status reports stopped when daemon not running
|
|
{
|
|
console.log('Test 3: daemon status reports stopped when not running')
|
|
const result =
|
|
await $`PASEO_HOME=${paseoHome} npx paseo daemon status`.nothrow()
|
|
assert.strictEqual(result.exitCode, 0, 'status should succeed when daemon is stopped')
|
|
const output = result.stdout.toLowerCase()
|
|
assert(output.includes('status'), 'status table should include Status row')
|
|
assert(output.includes('stopped'), 'status should report stopped')
|
|
console.log('✓ daemon status reports stopped when not running\n')
|
|
}
|
|
|
|
// Test 4: daemon status --json outputs valid JSON
|
|
{
|
|
console.log('Test 4: daemon status --json outputs JSON')
|
|
const result =
|
|
await $`PASEO_HOME=${paseoHome} npx paseo daemon status --json`.nothrow()
|
|
assert.strictEqual(result.exitCode, 0, '--json status should succeed')
|
|
const status = JSON.parse(result.stdout)
|
|
assert.strictEqual(status.status, 'stopped', 'json status should report stopped')
|
|
assert.strictEqual(status.home, paseoHome, 'json status should reflect the isolated home')
|
|
console.log('✓ daemon status --json outputs valid JSON\n')
|
|
}
|
|
|
|
// Test 5: daemon stop handles daemon not running gracefully
|
|
{
|
|
console.log('Test 5: daemon stop handles daemon not running')
|
|
const result =
|
|
await $`PASEO_HOME=${paseoHome} npx paseo daemon stop`.nothrow()
|
|
// Stop should succeed even if daemon is not running (idempotent).
|
|
assert.strictEqual(result.exitCode, 0, 'stop should succeed when daemon not running')
|
|
const output = result.stdout + result.stderr
|
|
const mentionsNotRunning =
|
|
output.toLowerCase().includes('not running') ||
|
|
output.toLowerCase().includes('was not running')
|
|
assert(mentionsNotRunning, 'output should mention daemon was not running')
|
|
console.log('✓ daemon stop succeeds gracefully when daemon not running\n')
|
|
}
|
|
|
|
// Test 6: daemon restart starts daemon and can be stopped
|
|
{
|
|
console.log('Test 6: daemon restart starts daemon and can be stopped')
|
|
const result =
|
|
await $`PASEO_HOME=${paseoHome} npx paseo daemon restart --port ${String(port)}`.nothrow()
|
|
assert.strictEqual(result.exitCode, 0, 'restart should succeed even when previously stopped')
|
|
assert(result.stdout.toLowerCase().includes('restarted'), 'output should report restart')
|
|
|
|
const cleanup = await $`PASEO_HOME=${paseoHome} npx paseo daemon stop --force`.nothrow()
|
|
assert.strictEqual(cleanup.exitCode, 0, 'cleanup stop should succeed after restart')
|
|
console.log('✓ daemon restart starts and stop cleanup succeeds\n')
|
|
}
|
|
} finally {
|
|
// Best-effort daemon cleanup in case assertions fail before explicit stop.
|
|
await $`PASEO_HOME=${paseoHome} npx paseo daemon stop --force`.nothrow()
|
|
// Clean up temp directory
|
|
await rm(paseoHome, { recursive: true, force: true })
|
|
}
|
|
|
|
console.log('=== All daemon tests passed ===')
|