mirror of
https://github.com/getpaseo/paseo.git
synced 2026-11-06 08:24:46 +00:00
Restore provider/model selection in Android tablet modal windows by giving both native modal hosts their own gesture-handler root. Preserve phone sheet and web portal behavior. Include native regression scripts, test dependency resolution, and verified CI test corrections. Generated media and logs are excluded. Refs #4475 and #4377; consolidates #4721 and #4771. Co-authored-by: Mike P. Kuhl <mkuhl@softmachine.at> Co-authored-by: Cameron Chin <cjcrjc@users.noreply.github.com>
279 lines
10 KiB
TypeScript
279 lines
10 KiB
TypeScript
import type { WorkspaceCreateRequest } from "@getpaseo/protocol/messages";
|
|
import { expect, type Page } from "@playwright/test";
|
|
import { daemonWsRoutePattern } from "./daemon-port";
|
|
import { gotoAppShell } from "./app";
|
|
import { gotoWorkspace } from "./launcher";
|
|
import { fillComposerDraft } from "./composer";
|
|
import { createAgentTabFromMenu } from "./workspace-tabs";
|
|
import {
|
|
openNewWorkspaceComposer,
|
|
selectWorkspaceIsolation,
|
|
loadSessionMessageReaders,
|
|
} from "./new-workspace";
|
|
import { seedWorkspace } from "./seed-client";
|
|
import {
|
|
waitForSidebarHydration,
|
|
switchWorkspaceViaSidebar,
|
|
workspaceDeckEntryLocator,
|
|
} from "./workspace-ui";
|
|
import { getServerId } from "./server-id";
|
|
import { WORKSPACE_DECK_MAX_MOUNTED_WORKSPACES } from "@/screens/workspace/workspace-deck-retention";
|
|
import type { installDaemonWebSocketGate } from "./daemon-websocket-gate";
|
|
|
|
/** Capture the submitted agent options; optionally stop provisioning for wire-only assertions. */
|
|
export async function captureWorkspaceAgentRequest(page: Page, options: { block: boolean }) {
|
|
const frames = await loadSessionMessageReaders();
|
|
type AgentIntent = NonNullable<WorkspaceCreateRequest["agent"]>;
|
|
let resolveRequest!: (agent: AgentIntent) => void;
|
|
const request = new Promise<AgentIntent>((resolve) => {
|
|
resolveRequest = resolve;
|
|
});
|
|
await page.routeWebSocket(daemonWsRoutePattern(), (ws) => {
|
|
const server = ws.connectToServer();
|
|
ws.onMessage((frame) => {
|
|
const message = frames.client(frame);
|
|
if (message?.type === "workspace.create.request" && message.agent) {
|
|
resolveRequest(message.agent);
|
|
if (options.block) return;
|
|
}
|
|
server.send(frame);
|
|
});
|
|
server.onMessage((frame) => ws.send(frame));
|
|
});
|
|
return { waitForRequest: () => request };
|
|
}
|
|
|
|
export async function pressSubmitBeforeTheNextRender(page: Page, name: string): Promise<void> {
|
|
const create = page.getByRole("button", { name, exact: true });
|
|
await expect(create).toBeEnabled();
|
|
// Dispatch the queued clicks in one JS task, before pending state can paint.
|
|
// Exercise DOM events rather than calling the app's submit handler directly.
|
|
await create.evaluate((button) => {
|
|
for (let click = 0; click < 3; click++) {
|
|
button.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
}
|
|
});
|
|
}
|
|
|
|
export async function observeCreationRequests(page: Page) {
|
|
const frames = await loadSessionMessageReaders();
|
|
const pending = new Set<string>();
|
|
page.on("websocket", (socket) => {
|
|
socket.on("framesent", ({ payload }) => {
|
|
const request = frames.client(payload);
|
|
if (
|
|
request?.type === "workspace.create.request" ||
|
|
request?.type === "agent.create.request"
|
|
) {
|
|
pending.add(request.requestId);
|
|
}
|
|
});
|
|
socket.on("framereceived", ({ payload }) => {
|
|
const response = frames.server(payload);
|
|
if (
|
|
response?.type === "workspace.create.response" ||
|
|
response?.type === "agent.create.response" ||
|
|
(response?.type === "status" &&
|
|
(response.payload.status === "agent_created" ||
|
|
response.payload.status === "agent_create_failed"))
|
|
) {
|
|
const requestId = response.payload.requestId;
|
|
if (typeof requestId === "string") pending.delete(requestId);
|
|
}
|
|
});
|
|
});
|
|
return {
|
|
async settled() {
|
|
await expect.poll(() => pending.size).toBe(0);
|
|
},
|
|
};
|
|
}
|
|
|
|
export async function retryNextAgentCreation(page: Page) {
|
|
const frames = await loadSessionMessageReaders();
|
|
const retryIds = new Set<string>();
|
|
const results: Array<{ status: string; agentId?: string }> = [];
|
|
let repeated = false;
|
|
await page.routeWebSocket(daemonWsRoutePattern(), (browser) => {
|
|
const server = browser.connectToServer();
|
|
browser.onMessage((frame) => {
|
|
const request = frames.client(frame);
|
|
if (!repeated && request?.type === "agent.create.request") {
|
|
repeated = true;
|
|
for (let attempt = 1; attempt <= 3; attempt++) {
|
|
const requestId = attempt === 1 ? request.requestId : `${request.requestId}-${attempt}`;
|
|
retryIds.add(requestId);
|
|
// Keep the app's operation key and payload; only RPC correlation changes.
|
|
server.send(JSON.stringify({ type: "session", message: { ...request, requestId } }));
|
|
}
|
|
return;
|
|
}
|
|
server.send(frame);
|
|
});
|
|
server.onMessage((frame) => {
|
|
const response = frames.server(frame);
|
|
if (
|
|
response?.type === "agent.create.response" &&
|
|
retryIds.delete(response.payload.requestId)
|
|
) {
|
|
results.push({
|
|
status: response.payload.error ? "agent_create_failed" : "agent_created",
|
|
agentId: response.payload.agent?.id,
|
|
});
|
|
}
|
|
browser.send(frame);
|
|
});
|
|
});
|
|
return {
|
|
async completedAgentIds() {
|
|
await expect.poll(() => results.length).toBe(3);
|
|
expect(results.map((result) => result.status)).toEqual([
|
|
"agent_created",
|
|
"agent_created",
|
|
"agent_created",
|
|
]);
|
|
return results.map((result) => result.agentId);
|
|
},
|
|
};
|
|
}
|
|
|
|
export async function createCreationScenario(page: Page) {
|
|
const requests = await observeCreationRequests(page);
|
|
const project = await seedWorkspace({ repoPrefix: "creation-idempotency-" });
|
|
let workspaceId = project.workspaceId;
|
|
return {
|
|
cleanup: project.cleanup,
|
|
async openWorkspaceForm(isolation: "local" | "worktree") {
|
|
await gotoAppShell(page);
|
|
await waitForSidebarHydration(page);
|
|
await openNewWorkspaceComposer(page, project);
|
|
await selectWorkspaceIsolation(page, isolation);
|
|
},
|
|
async openAgentDraft() {
|
|
await gotoWorkspace(page, project.workspaceId);
|
|
await createAgentTabFromMenu(page);
|
|
},
|
|
async startAnotherDraft() {
|
|
await createAgentTabFromMenu(page);
|
|
},
|
|
async submitPrompt(prompt: string, button = "Send message") {
|
|
await fillComposerDraft(page, prompt);
|
|
await page.getByRole("button", { name: button, exact: true }).click();
|
|
},
|
|
async submitRepeatedly(button: string, prompt?: string) {
|
|
if (prompt) await fillComposerDraft(page, prompt);
|
|
await pressSubmitBeforeTheNextRender(page, button);
|
|
},
|
|
async expectPromptVisible(prompt?: string) {
|
|
// Inactive agent tabs retain their timeline DOM beside the visible draft.
|
|
const rows = page.getByTestId("user-message").filter({ visible: true });
|
|
await expect(prompt ? rows.filter({ hasText: prompt }) : rows.first()).toBeVisible();
|
|
},
|
|
async expectWorkspaceReadyBeforeAgentCompletion() {
|
|
await expect(page).toHaveURL(/\/workspace\//);
|
|
await expect(page.getByTestId("user-message").first()).toBeVisible();
|
|
await expect(
|
|
page
|
|
.locator('[data-testid^="workspace-tab-draft_"][aria-selected="true"]')
|
|
.filter({ visible: true }),
|
|
).toBeVisible();
|
|
},
|
|
async expectAgentStillStarting() {
|
|
await this.expectWorkspaceReadyBeforeAgentCompletion();
|
|
expect((await project.client.fetchAgents()).entries).toHaveLength(0);
|
|
},
|
|
async expectStartupFailure() {
|
|
await expect(page.getByText(/Creation startup failed for test/).first()).toBeVisible();
|
|
},
|
|
async expectOneCreatedWorkspace() {
|
|
await expect(page).toHaveURL(/\/workspace\//);
|
|
await requests.settled();
|
|
const workspaces = (await project.client.fetchWorkspaces()).entries.filter(
|
|
(workspace) =>
|
|
workspace.projectId === project.projectId && workspace.id !== project.workspaceId,
|
|
);
|
|
expect(workspaces).toHaveLength(1);
|
|
workspaceId = workspaces[0]!.id;
|
|
},
|
|
async expectAgentCount(count: number) {
|
|
await requests.settled();
|
|
await expect
|
|
.poll(
|
|
async () =>
|
|
(await project.client.fetchAgents()).entries.filter(
|
|
({ agent }) => agent.workspaceId === workspaceId,
|
|
).length,
|
|
)
|
|
.toBe(count);
|
|
},
|
|
async expectAgentTitle(title: string) {
|
|
await expect
|
|
.poll(
|
|
async () =>
|
|
(await project.client.fetchAgents()).entries.find(
|
|
({ agent }) => agent.workspaceId === workspaceId,
|
|
)?.agent.title,
|
|
)
|
|
.toBe(title);
|
|
},
|
|
async evictAndReturnToDraft() {
|
|
const draft = page
|
|
.locator('[data-testid^="workspace-tab-draft_"][aria-selected="true"]')
|
|
.filter({ visible: true })
|
|
.first();
|
|
const draftTestId = await draft.getAttribute("data-testid");
|
|
expect(draftTestId).not.toBeNull();
|
|
for (let index = 0; index < WORKSPACE_DECK_MAX_MOUNTED_WORKSPACES; index++) {
|
|
const result = await project.client.createWorkspace({
|
|
source: { kind: "directory", path: project.repoPath },
|
|
});
|
|
if (!result.workspace) throw new Error(result.error ?? "Failed to seed eviction workspace");
|
|
await switchWorkspaceViaSidebar({
|
|
page,
|
|
serverId: getServerId(),
|
|
workspaceId: result.workspace.id,
|
|
});
|
|
}
|
|
await expect(workspaceDeckEntryLocator(page, getServerId(), workspaceId)).toHaveCount(0);
|
|
await switchWorkspaceViaSidebar({ page, serverId: getServerId(), workspaceId });
|
|
await page
|
|
.getByTestId(draftTestId!)
|
|
.filter({ visible: true })
|
|
.click({ position: { x: 12, y: 13 } });
|
|
},
|
|
};
|
|
}
|
|
|
|
export function createPromptRetryScenario(
|
|
page: Page,
|
|
gate: Awaited<ReturnType<typeof installDaemonWebSocketGate>>,
|
|
) {
|
|
let firstMessage: ReturnType<typeof gate.getClientRequests>[number] | undefined;
|
|
return {
|
|
holdAcknowledgement() {
|
|
gate.holdNextServerMessage("agent.create.response");
|
|
},
|
|
async waitForDeliveredPrompt() {
|
|
await gate.waitForHeldServerMessage("agent.create.response");
|
|
firstMessage = gate.getClientRequests("agent.create.request").at(-1);
|
|
},
|
|
async disconnectAndReconnect() {
|
|
const fetches = gate.getClientRequestCount("fetch_agents_request");
|
|
await gate.drop();
|
|
gate.restore();
|
|
await expect
|
|
.poll(() => gate.getClientRequestCount("fetch_agents_request"))
|
|
.toBeGreaterThan(fetches);
|
|
},
|
|
async expectSameAgentAndMessage() {
|
|
expect(gate.getClientRequestCount("agent.create.request")).toBe(1);
|
|
await expect
|
|
.poll(() => gate.getClientRequestCount("creation.subscribe.request"))
|
|
.toBeGreaterThan(0);
|
|
expect(gate.getClientRequests("agent.create.request").at(-1)).toEqual(firstMessage);
|
|
expect(gate.getClientRequestCount("send_agent_message_request")).toBe(0);
|
|
await expect(page.getByTestId("user-message").filter({ visible: true })).toHaveCount(1);
|
|
},
|
|
};
|
|
}
|