mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-28 04:03:05 +00:00
* feat(protocol): add forge check presentation metadata Expose optional rawStatus, isManual, and requiresAction fields while keeping older check payloads backward-compatible. * fix(gitea): model Actions jobs as tasks Gitea's /actions/tasks endpoint returns individual jobs rather than workflow runs. Preserve sibling tasks from the latest execution, avoid collapsing same-name jobs, and enrich blocked tasks with run-level approval metadata. * feat(app): distinguish forge check presentation states * fix(gitlab): preserve pipeline job semantics * refactor(app): centralize forge check presentation policy Use one canonical category order, count shape, visual policy, and translated copy mapping across sidebar, hover-card, PR-pane, and GitLab pipeline surfaces. * refactor: consolidate forge check handling * feat(forge): auto-attach pasted forge references * docs(compat): correct forge rollout metadata * refactor(forge): model check nuances as traits * fix(forge): harden checks from branch review Structural Gitea Actions shadow dedup by run id (verified upstream), rerun grouping without workflow_id, shared trait/status constants and Gitea state mapping in the protocol package, all cloud host aliases in pasted-link matching, logged glab job-detail failures, concurrent approvals/pipeline fetch, checks aggregate from the same pipeline as the job list, and removal of the unread check-level rawStatus. The released pipeline-level rawStatus is staged for removal under COMPAT(pipelineRawStatus). * fix(gitea): detect fork-PR Actions approval hold as action_required gitea.com represents a fork PR awaiting Actions approval as a run in status "waiting" with no tasks and pending shadow commit statuses; it does not expose need_approval. The previous mapping only set action_required from a task with blocked+need_approval, so the gate never surfaced (0 tasks -> early return; need_approval absent). Detect the hold from /actions/runs: a waiting/blocked run whose PR is cross-repo (head.repo.id != base.repo.id), or one that does expose need_approval (self-hosted). Tag the run's pending shadow statuses action_required. Runs are only fetched when a pending shadow has no covering task, keeping the common path at two requests. Verified live against gitea.com fork PR (run 715170, waiting, cross-repo). * fix(gitea): resolve cross-fork PRs by head sha The current-PR matcher gated candidates on the checkout owner (giteaHeadOwner === expectedHeadOwner), which excludes every fork PR: its head carries the fork owner while the checkout is the base repo, so a fork PR - the only shape that can be approval-held on Gitea - never resolved and its checks never showed in-app. GitLab has no such gate (it resolves fork MRs from the target project by source branch). Accept a recent PR whose head sha equals the workspace head sha regardless of owner; the sha is an unambiguous identity, so the anti-collision owner gate still applies when no sha match is available. Verified live against gitea.com fork PR #6 (resolves + renders action_required). * fix: resolve forge rebase drift * fix: type forge auto-attach boundary * fix(i18n): add Korean check status copy --------- Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
194 lines
5.5 KiB
TypeScript
194 lines
5.5 KiB
TypeScript
import React, { type ReactNode } from "react";
|
|
import { Pressable, Text, View } from "react-native";
|
|
import { StyleSheet, withUnistyles } from "react-native-unistyles";
|
|
import type { CountedCheckPresentation } from "@/git/check-presentation";
|
|
import { CONTROL_HEIGHTS } from "@/components/ui/control-geometry";
|
|
import {
|
|
CheckPresentationIcon,
|
|
getCheckPresentationTone,
|
|
type CheckPresentationTone,
|
|
} from "@/git/check-presentation.view";
|
|
import { ChevronDown, ChevronRight } from "lucide-react-native";
|
|
import type { Theme } from "@/styles/theme";
|
|
|
|
const ThemedChevronDown = withUnistyles(ChevronDown);
|
|
const ThemedChevronRight = withUnistyles(ChevronRight);
|
|
|
|
export const foregroundMutedColorMapping = (theme: Theme) => ({
|
|
color: theme.colors.foregroundMuted,
|
|
});
|
|
export const successColorMapping = (theme: Theme) => ({ color: theme.colors.statusSuccess });
|
|
export const dangerColorMapping = (theme: Theme) => ({ color: theme.colors.statusDanger });
|
|
export const warningColorMapping = (theme: Theme) => ({ color: theme.colors.statusWarning });
|
|
|
|
interface SectionProps {
|
|
title: string;
|
|
open: boolean;
|
|
onToggle: () => void;
|
|
summary: ReactNode;
|
|
children: ReactNode;
|
|
accessibilityLabel?: string;
|
|
}
|
|
|
|
export function Section({
|
|
title,
|
|
open,
|
|
onToggle,
|
|
summary,
|
|
children,
|
|
accessibilityLabel,
|
|
}: SectionProps) {
|
|
return (
|
|
<View>
|
|
<Pressable
|
|
accessibilityLabel={accessibilityLabel}
|
|
style={sectionKitStyles.sectionHeader}
|
|
onPress={onToggle}
|
|
>
|
|
{open ? (
|
|
<ThemedChevronDown size={14} uniProps={foregroundMutedColorMapping} />
|
|
) : (
|
|
<ThemedChevronRight size={14} uniProps={foregroundMutedColorMapping} />
|
|
)}
|
|
<Text style={sectionKitStyles.sectionTitle}>{title}</Text>
|
|
<View style={sectionKitStyles.summaryWrap}>{summary}</View>
|
|
</Pressable>
|
|
{open ? <View style={sectionKitStyles.sectionBody}>{children}</View> : null}
|
|
</View>
|
|
);
|
|
}
|
|
|
|
export type SummaryPillVariant = CheckPresentationTone;
|
|
|
|
export function SummaryPill({
|
|
count,
|
|
icon,
|
|
variant,
|
|
testID,
|
|
}: {
|
|
count: number;
|
|
icon: ReactNode;
|
|
variant: SummaryPillVariant;
|
|
testID?: string;
|
|
}) {
|
|
if (count === 0) return null;
|
|
return (
|
|
<View style={sectionKitStyles.summaryPill} testID={testID}>
|
|
{icon}
|
|
<Text style={summaryPillTextStyle(variant)}>{count}</Text>
|
|
</View>
|
|
);
|
|
}
|
|
|
|
function summaryPillTextStyle(variant: SummaryPillVariant) {
|
|
if (variant === "success") return sectionKitStyles.summaryPillSuccessText;
|
|
if (variant === "danger") return sectionKitStyles.summaryPillDangerText;
|
|
if (variant === "warning") return sectionKitStyles.summaryPillWarningText;
|
|
return sectionKitStyles.summaryPillMutedText;
|
|
}
|
|
|
|
export function CheckPresentationSummaryPill({
|
|
count,
|
|
presentation,
|
|
testID,
|
|
}: {
|
|
count: number;
|
|
presentation: CountedCheckPresentation;
|
|
testID?: string;
|
|
}) {
|
|
if (count === 0) return null;
|
|
return (
|
|
<View style={sectionKitStyles.summaryPill} testID={testID}>
|
|
<CheckPresentationIcon presentation={presentation} size={12} />
|
|
<Text style={summaryPillTextStyle(getCheckPresentationTone(presentation))}>{count}</Text>
|
|
</View>
|
|
);
|
|
}
|
|
|
|
export const sectionKitStyles = StyleSheet.create((theme) => ({
|
|
sectionHeader: {
|
|
flexDirection: "row",
|
|
alignItems: "center",
|
|
gap: theme.spacing[2],
|
|
paddingHorizontal: theme.spacing[3],
|
|
paddingVertical: theme.spacing[2],
|
|
},
|
|
sectionTitle: {
|
|
fontSize: theme.fontSize.sm,
|
|
fontWeight: theme.fontWeight.medium,
|
|
color: theme.colors.foregroundMuted,
|
|
},
|
|
sectionBody: {
|
|
paddingBottom: theme.spacing[3],
|
|
},
|
|
summaryWrap: {
|
|
marginLeft: "auto",
|
|
flexDirection: "row",
|
|
alignItems: "center",
|
|
gap: theme.spacing[2],
|
|
},
|
|
summaryPill: {
|
|
flexDirection: "row",
|
|
alignItems: "center",
|
|
gap: 3,
|
|
},
|
|
summaryPillSuccessText: {
|
|
fontSize: theme.fontSize.sm,
|
|
fontWeight: theme.fontWeight.normal,
|
|
color: theme.colors.statusSuccess,
|
|
},
|
|
summaryPillDangerText: {
|
|
fontSize: theme.fontSize.sm,
|
|
fontWeight: theme.fontWeight.normal,
|
|
color: theme.colors.statusDanger,
|
|
},
|
|
summaryPillWarningText: {
|
|
fontSize: theme.fontSize.sm,
|
|
fontWeight: theme.fontWeight.normal,
|
|
color: theme.colors.statusWarning,
|
|
},
|
|
summaryPillMutedText: {
|
|
fontSize: theme.fontSize.sm,
|
|
fontWeight: theme.fontWeight.normal,
|
|
color: theme.colors.foregroundMuted,
|
|
},
|
|
emptyText: {
|
|
fontSize: theme.fontSize.sm,
|
|
color: theme.colors.foregroundMuted,
|
|
paddingHorizontal: theme.spacing[3],
|
|
paddingVertical: theme.spacing[2],
|
|
},
|
|
checkRow: {
|
|
flexDirection: "row",
|
|
alignItems: "center",
|
|
gap: theme.spacing[2],
|
|
paddingHorizontal: theme.spacing[3],
|
|
// Fixed, not minHeight plus padding. A row's trailing slot holds an xs Button
|
|
// (28pt), which stacked on the vertical padding and made rows with an
|
|
// "Add to chat" button taller than rows without one. The row is single-line by
|
|
// construction, so it declares a height the button fits inside instead.
|
|
height: CONTROL_HEIGHTS.compact,
|
|
},
|
|
checkName: {
|
|
fontSize: theme.fontSize.base,
|
|
fontWeight: theme.fontWeight.normal,
|
|
color: theme.colors.foreground,
|
|
flexShrink: 1,
|
|
},
|
|
checkWorkflow: {
|
|
fontSize: theme.fontSize.sm,
|
|
color: theme.colors.foregroundMuted,
|
|
flexShrink: 1,
|
|
},
|
|
checkTrailing: {
|
|
marginLeft: "auto",
|
|
flexDirection: "row",
|
|
alignItems: "center",
|
|
gap: theme.spacing[2],
|
|
},
|
|
checkDuration: {
|
|
fontSize: theme.fontSize.sm,
|
|
color: theme.colors.foregroundMuted,
|
|
},
|
|
}));
|