mirror of
https://github.com/getpaseo/paseo.git
synced 2026-11-07 08:54:42 +00:00
Mohamed Boudra
ab8151d33f
Sidebar polish round. Menus. `dropdown-menu` and `context-menu` were two copies of one engine that differed only in how the trigger fires — identical from `computePosition` down — and neither could nest. Both are now thin wrappers over `components/ui/menu/`, which owns anchoring, a pure page-stack navigation model, and one presentation fork: flyout on pointer, pushed pages in a sheet on compact. All 31 call sites are unchanged. Items got a rounded inset fill, a visible separator, and `selected` (a check) split from `active` (a fill). Sidebar display preferences. The flat wall of four sections becomes one row per decision with its value, and per-feature toggles over what a workspace row shows: host, pull request, checks, scripts. Each is independent — a ticked toggle that draws nothing is a lie. `display-preferences/` hides that grouping lives in zustand while title source and row items are app settings. Timestamps. "Last activity" now ticks itself. The label rounds to the minute and never shows seconds; past a week it becomes a date. The timer lives in the leaf `<Text>`, at most one per resolution tier shared by every row, and a tick only re-renders when the string actually changed — so a memoized row that legitimately never re-renders still stays current. Colour. Full status tier regenerated at 90% of gamut max (was 85), same rule as the muted tier, lightness and hue untouched. File icons are pulled toward neutral in OKLab behind `getFileIconSvg` — material-icon-theme picks its palette for a tree where the icon is the only colour on the row, and ours is not. New/deleted files use the forge square-plus/square-minus glyphs at muted weight instead of tinted pills. Project icons round a little more; uploaded icons never do. The project status badge is a knockout again: it fills with the colour of the row behind it, so the ring reads as a gap in the icon rather than a white halo. File rows. The always-visible kebab is gone from the file explorer and diff tree in favour of right-click, which also reclaims the reserved action slot.
76 lines
2.5 KiB
TypeScript
76 lines
2.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
closeSubPage,
|
|
currentPageId,
|
|
goBack,
|
|
isSubPageOpen,
|
|
MENU_ROOT_PATH,
|
|
openSubPage,
|
|
} from "./menu-navigation";
|
|
|
|
describe("openSubPage", () => {
|
|
it("opens a submenu from the root", () => {
|
|
expect(openSubPage(MENU_ROOT_PATH, { id: "show", depth: 0 })).toEqual(["show"]);
|
|
});
|
|
|
|
it("nests a submenu opened from inside another", () => {
|
|
expect(openSubPage(["show"], { id: "colors", depth: 1 })).toEqual(["show", "colors"]);
|
|
});
|
|
|
|
it("swaps branches instead of nesting when the trigger is a sibling", () => {
|
|
// Sliding the pointer from one root trigger to another must not stack both flyouts.
|
|
expect(openSubPage(["grouping"], { id: "show", depth: 0 })).toEqual(["show"]);
|
|
});
|
|
|
|
it("drops deeper pages when an ancestor's sibling opens", () => {
|
|
expect(openSubPage(["show", "colors"], { id: "grouping", depth: 0 })).toEqual(["grouping"]);
|
|
});
|
|
|
|
it("returns the same path when the submenu is already open", () => {
|
|
const path = ["show"];
|
|
expect(openSubPage(path, { id: "show", depth: 0 })).toBe(path);
|
|
});
|
|
});
|
|
|
|
describe("closeSubPage", () => {
|
|
it("closes the page at a depth and everything below it", () => {
|
|
expect(closeSubPage(["show", "colors"], 0)).toEqual([]);
|
|
expect(closeSubPage(["show", "colors"], 1)).toEqual(["show"]);
|
|
});
|
|
|
|
it("returns the same path when nothing is open at that depth", () => {
|
|
const path = ["show"];
|
|
expect(closeSubPage(path, 1)).toBe(path);
|
|
expect(closeSubPage(MENU_ROOT_PATH, 0)).toBe(MENU_ROOT_PATH);
|
|
});
|
|
});
|
|
|
|
describe("goBack", () => {
|
|
it("pops one page", () => {
|
|
expect(goBack(["show", "colors"])).toEqual(["show"]);
|
|
expect(goBack(["show"])).toEqual([]);
|
|
});
|
|
|
|
it("is a no-op at the root", () => {
|
|
expect(goBack(MENU_ROOT_PATH)).toBe(MENU_ROOT_PATH);
|
|
});
|
|
});
|
|
|
|
describe("currentPageId", () => {
|
|
it("is null at the root and the last id otherwise", () => {
|
|
expect(currentPageId(MENU_ROOT_PATH)).toBeNull();
|
|
expect(currentPageId(["show", "colors"])).toBe("colors");
|
|
});
|
|
});
|
|
|
|
describe("isSubPageOpen", () => {
|
|
it("matches on id and depth together", () => {
|
|
const path = ["show", "colors"];
|
|
expect(isSubPageOpen(path, { id: "show", depth: 0 })).toBe(true);
|
|
expect(isSubPageOpen(path, { id: "colors", depth: 1 })).toBe(true);
|
|
// Right id, wrong level — a different trigger that happens to share a name.
|
|
expect(isSubPageOpen(path, { id: "colors", depth: 0 })).toBe(false);
|
|
expect(isSubPageOpen(path, { id: "grouping", depth: 0 })).toBe(false);
|
|
});
|
|
});
|