Files
paseo/packages/app/src/git/forge-refs.ts
T
nllptrxandMohamed Boudra 4a5716360b Feat/forge check semantics and followup fixes (#2337)
* feat(protocol): add forge check presentation metadata

Expose optional rawStatus, isManual, and requiresAction fields while keeping older check payloads backward-compatible.

* fix(gitea): model Actions jobs as tasks

Gitea's /actions/tasks endpoint returns individual jobs rather than workflow runs. Preserve sibling tasks from the latest execution, avoid collapsing same-name jobs, and enrich blocked tasks with run-level approval metadata.

* feat(app): distinguish forge check presentation states

* fix(gitlab): preserve pipeline job semantics

* refactor(app): centralize forge check presentation policy

Use one canonical category order, count shape, visual policy, and translated copy mapping across sidebar, hover-card, PR-pane, and GitLab pipeline surfaces.

* refactor: consolidate forge check handling

* feat(forge): auto-attach pasted forge references

* docs(compat): correct forge rollout metadata

* refactor(forge): model check nuances as traits

* fix(forge): harden checks from branch review

Structural Gitea Actions shadow dedup by run id (verified upstream),
rerun grouping without workflow_id, shared trait/status constants and
Gitea state mapping in the protocol package, all cloud host aliases in
pasted-link matching, logged glab job-detail failures, concurrent
approvals/pipeline fetch, checks aggregate from the same pipeline as
the job list, and removal of the unread check-level rawStatus. The
released pipeline-level rawStatus is staged for removal under
COMPAT(pipelineRawStatus).

* fix(gitea): detect fork-PR Actions approval hold as action_required

gitea.com represents a fork PR awaiting Actions approval as a run in
status "waiting" with no tasks and pending shadow commit statuses; it
does not expose need_approval. The previous mapping only set
action_required from a task with blocked+need_approval, so the gate
never surfaced (0 tasks -> early return; need_approval absent). Detect
the hold from /actions/runs: a waiting/blocked run whose PR is
cross-repo (head.repo.id != base.repo.id), or one that does expose
need_approval (self-hosted). Tag the run's pending shadow statuses
action_required. Runs are only fetched when a pending shadow has no
covering task, keeping the common path at two requests. Verified live
against gitea.com fork PR (run 715170, waiting, cross-repo).

* fix(gitea): resolve cross-fork PRs by head sha

The current-PR matcher gated candidates on the checkout owner
(giteaHeadOwner === expectedHeadOwner), which excludes every fork PR:
its head carries the fork owner while the checkout is the base repo, so
a fork PR - the only shape that can be approval-held on Gitea - never
resolved and its checks never showed in-app. GitLab has no such gate
(it resolves fork MRs from the target project by source branch). Accept
a recent PR whose head sha equals the workspace head sha regardless of
owner; the sha is an unambiguous identity, so the anti-collision owner
gate still applies when no sha match is available. Verified live against
gitea.com fork PR #6 (resolves + renders action_required).

* fix: resolve forge rebase drift

* fix: type forge auto-attach boundary

* fix(i18n): add Korean check status copy

---------

Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
2026-08-25 23:37:50 +02:00

146 lines
4.1 KiB
TypeScript

import { FORGE_DEFINITIONS } from "@getpaseo/protocol/forge-manifest";
import { normalizeHost, parseGitRemoteLocation } from "@getpaseo/protocol/git-remote";
import type { ForgeReferencePath } from "@/git/client-forge-module";
import { CLIENT_FORGE_LOGIC_MODULES } from "@/git/forges";
export interface ForgeRef {
kind: ForgeReferencePath["kind"];
number: number;
}
const WEB_URL_PATTERN = /https?:\/\/[^\s<>"'`)\]]+/giu;
const TRAILING_SENTENCE_PUNCTUATION = /[.,;:!]+$/u;
interface RemoteReferenceTarget {
webHosts: ReadonlySet<string>;
repoPath: string;
/** Known cloud forge ids, or null when a self-hosted domain is unresolved. */
forgeIds: ReadonlySet<string> | null;
}
/**
* Finds issue and change-request URLs belonging to the current repository.
* Route syntax comes entirely from the app forge registry: adding a forge's
* `urlGrammar.referencePaths` makes composer auto-attachment work without a
* central forge switch.
*/
export function extractForgeRefs(
text: string | null | undefined,
remoteUrl: string | null | undefined,
): ForgeRef[] {
const target = resolveRemoteReferenceTarget(remoteUrl);
const body = text?.trim();
if (!target || !body) {
return [];
}
const refs: ForgeRef[] = [];
const seen = new Set<string>();
for (const match of body.matchAll(WEB_URL_PATTERN)) {
const candidate = parsePastedWebUrl(match[0]);
if (!candidate || !target.webHosts.has(normalizeHost(candidate.hostname))) {
continue;
}
const pathname = decodePathname(candidate.pathname);
if (!pathname) {
continue;
}
for (const referencePath of registeredReferencePaths(target.forgeIds)) {
const ref = parseReferencePath(pathname, target.repoPath, referencePath);
if (!ref) {
continue;
}
const key = forgeRefKey(ref);
if (!seen.has(key)) {
seen.add(key);
refs.push(ref);
}
break;
}
}
return refs;
}
export function parseForgeRef(
text: string | null | undefined,
remoteUrl: string | null | undefined,
): ForgeRef | null {
return extractForgeRefs(text, remoteUrl)[0] ?? null;
}
function resolveRemoteReferenceTarget(
remoteUrl: string | null | undefined,
): RemoteReferenceTarget | null {
if (!remoteUrl) {
return null;
}
const remote = parseGitRemoteLocation(remoteUrl);
if (!remote) {
return null;
}
const webHosts = new Set([remote.host]);
const forgeIds = new Set<string>();
for (const definition of FORGE_DEFINITIONS) {
const cloudHosts = definition.cloudHosts?.map(normalizeHost) ?? [];
if (cloudHosts.includes(remote.host)) {
forgeIds.add(definition.id);
for (const host of cloudHosts) {
webHosts.add(host);
}
}
}
return {
webHosts,
repoPath: remote.path,
forgeIds: forgeIds.size > 0 ? forgeIds : null,
};
}
function parsePastedWebUrl(raw: string): URL | null {
try {
const parsed = new URL(raw.replace(TRAILING_SENTENCE_PUNCTUATION, ""));
return parsed.protocol === "http:" || parsed.protocol === "https:" ? parsed : null;
} catch {
return null;
}
}
function decodePathname(pathname: string): string | null {
try {
return decodeURIComponent(pathname);
} catch {
return null;
}
}
function registeredReferencePaths(
forgeIds: ReadonlySet<string> | null,
): readonly ForgeReferencePath[] {
return CLIENT_FORGE_LOGIC_MODULES.flatMap((module) =>
!forgeIds || forgeIds.has(module.id) ? (module.urlGrammar?.referencePaths ?? []) : [],
);
}
function parseReferencePath(
pathname: string,
repoPath: string,
referencePath: ForgeReferencePath,
): ForgeRef | null {
const prefix = `/${repoPath}${referencePath.infix}`;
if (!pathname.toLowerCase().startsWith(prefix.toLowerCase())) {
return null;
}
const suffix = pathname.slice(prefix.length);
const numberText = suffix.match(/^(\d+)(?:\/|$)/u)?.[1];
if (!numberText) {
return null;
}
const number = Number.parseInt(numberText, 10);
return Number.isSafeInteger(number) && number > 0 ? { kind: referencePath.kind, number } : null;
}
function forgeRefKey(ref: ForgeRef): string {
return `${ref.kind}:${ref.number}`;
}