mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-26 03:03:04 +00:00
nllptrxandMohamed Boudra
4a5716360b
* feat(protocol): add forge check presentation metadata Expose optional rawStatus, isManual, and requiresAction fields while keeping older check payloads backward-compatible. * fix(gitea): model Actions jobs as tasks Gitea's /actions/tasks endpoint returns individual jobs rather than workflow runs. Preserve sibling tasks from the latest execution, avoid collapsing same-name jobs, and enrich blocked tasks with run-level approval metadata. * feat(app): distinguish forge check presentation states * fix(gitlab): preserve pipeline job semantics * refactor(app): centralize forge check presentation policy Use one canonical category order, count shape, visual policy, and translated copy mapping across sidebar, hover-card, PR-pane, and GitLab pipeline surfaces. * refactor: consolidate forge check handling * feat(forge): auto-attach pasted forge references * docs(compat): correct forge rollout metadata * refactor(forge): model check nuances as traits * fix(forge): harden checks from branch review Structural Gitea Actions shadow dedup by run id (verified upstream), rerun grouping without workflow_id, shared trait/status constants and Gitea state mapping in the protocol package, all cloud host aliases in pasted-link matching, logged glab job-detail failures, concurrent approvals/pipeline fetch, checks aggregate from the same pipeline as the job list, and removal of the unread check-level rawStatus. The released pipeline-level rawStatus is staged for removal under COMPAT(pipelineRawStatus). * fix(gitea): detect fork-PR Actions approval hold as action_required gitea.com represents a fork PR awaiting Actions approval as a run in status "waiting" with no tasks and pending shadow commit statuses; it does not expose need_approval. The previous mapping only set action_required from a task with blocked+need_approval, so the gate never surfaced (0 tasks -> early return; need_approval absent). Detect the hold from /actions/runs: a waiting/blocked run whose PR is cross-repo (head.repo.id != base.repo.id), or one that does expose need_approval (self-hosted). Tag the run's pending shadow statuses action_required. Runs are only fetched when a pending shadow has no covering task, keeping the common path at two requests. Verified live against gitea.com fork PR (run 715170, waiting, cross-repo). * fix(gitea): resolve cross-fork PRs by head sha The current-PR matcher gated candidates on the checkout owner (giteaHeadOwner === expectedHeadOwner), which excludes every fork PR: its head carries the fork owner while the checkout is the base repo, so a fork PR - the only shape that can be approval-held on Gitea - never resolved and its checks never showed in-app. GitLab has no such gate (it resolves fork MRs from the target project by source branch). Accept a recent PR whose head sha equals the workspace head sha regardless of owner; the sha is an unambiguous identity, so the anti-collision owner gate still applies when no sha match is available. Verified live against gitea.com fork PR #6 (resolves + renders action_required). * fix: resolve forge rebase drift * fix: type forge auto-attach boundary * fix(i18n): add Korean check status copy --------- Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
43 lines
1.5 KiB
TypeScript
43 lines
1.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { classifyCheck, countCheckPresentations } from "./check-presentation";
|
|
|
|
describe("check presentation", () => {
|
|
it.each([
|
|
[{ status: "failure", traits: ["warning", "action_required"] }, "actionRequired"],
|
|
[{ status: "pending", traits: ["manual", "action_required"] }, "actionRequired"],
|
|
[{ status: "success", traits: ["action_required"] }, "actionRequired"],
|
|
[{ status: "success", traits: ["warning"] }, "warning"],
|
|
[{ status: "skipped", traits: ["manual"] }, "manual"],
|
|
[{ status: "success" }, "success"],
|
|
[{ status: "failure" }, "failure"],
|
|
[{ status: "skipped" }, "ignored"],
|
|
[{ status: "cancelled" }, "ignored"],
|
|
[{ status: "pending" }, "pending"],
|
|
[{ status: "success", traits: ["future-forge-trait"] }, "success"],
|
|
[{ status: "future-provider-state" }, "pending"],
|
|
] as const)("classifies %o as %s", (check, expected) => {
|
|
expect(classifyCheck(check)).toBe(expected);
|
|
});
|
|
|
|
it("counts mutually exclusive presentation categories", () => {
|
|
expect(
|
|
countCheckPresentations([
|
|
{ status: "success" },
|
|
{ status: "failure" },
|
|
{ status: "success", traits: ["warning"] },
|
|
{ status: "pending", traits: ["action_required"] },
|
|
{ status: "pending" },
|
|
{ status: "skipped", traits: ["manual"] },
|
|
{ status: "skipped" },
|
|
]),
|
|
).toEqual({
|
|
success: 1,
|
|
failure: 1,
|
|
warning: 1,
|
|
actionRequired: 1,
|
|
manual: 1,
|
|
pending: 1,
|
|
});
|
|
});
|
|
});
|