mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-22 17:22:47 +00:00
* Keep relative timestamps current in agent, schedule, and import-session rows Agent list rows, schedule rows, and import-session rows formatted their "5m ago" labels once at render, so an idle row kept its first label until something else re-rendered it. They now use useTimeAgo, which rides the same shared ticker the sidebar and desktop tabs already use. Closes #4625 * Say "just now" for the whole first minute so fresh labels stay honest The shared ticker wakes once a minute, so a seconds label could only go stale. The prose and compact formatters now share one age description, and the schedule spec anchors its clock to the schedule's creation time. * Run every cleanup in the schedule relative-time spec and name its steps * Keep relative labels current with focused subscriptions * Update usage card after relative-time hook rename * Anchor import-session age spec to fixture time --------- Co-authored-by: paseo-bot[bot] <266920839+paseo-bot[bot]@users.noreply.github.com> Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
136 lines
5.6 KiB
TypeScript
136 lines
5.6 KiB
TypeScript
import { execFileSync } from "node:child_process";
|
|
import { writeFile } from "node:fs/promises";
|
|
import path from "node:path";
|
|
import type { Locator } from "@playwright/test";
|
|
import { test, expect } from "../support/fixtures";
|
|
import { openChangesTreePanel } from "../support/helpers/workspace-tabs";
|
|
|
|
const COMMIT_SUBJECT = "Show commit timestamps";
|
|
|
|
test("commit history explains when the workspace has no commits ahead of its base", async ({
|
|
page,
|
|
withWorkspace,
|
|
}) => {
|
|
const workspace = await withWorkspace({ prefix: "commit-history-empty-workspace-" });
|
|
execFileSync("git", ["checkout", "-b", "feature"], { cwd: workspace.repoPath, stdio: "ignore" });
|
|
await workspace.navigateTo();
|
|
|
|
await openChangesTreePanel(page);
|
|
const commitsSection = page.getByRole("button", { name: /Commits/i });
|
|
await expect(commitsSection).toBeVisible({ timeout: 30_000 });
|
|
await commitsSection.click();
|
|
|
|
await expect(page.getByTestId("commits-section-no-workspace-commits")).toHaveText(
|
|
"No commits ahead of main yet",
|
|
{ timeout: 30_000 },
|
|
);
|
|
});
|
|
|
|
test("commit history shows dates and shares diff layout preferences", async ({
|
|
page,
|
|
withWorkspace,
|
|
}) => {
|
|
const workspace = await withWorkspace({ prefix: "commit-diff-panel-" });
|
|
await createFeatureCommit(workspace.repoPath);
|
|
await page.setViewportSize({ width: 1400, height: 900 });
|
|
await workspace.navigateTo();
|
|
|
|
await openChangesTreePanel(page);
|
|
const commitsSection = page.getByRole("button", { name: /Commits/i });
|
|
await expect(commitsSection).toBeVisible({ timeout: 30_000 });
|
|
await commitsSection.click();
|
|
|
|
const commitRow = page.locator('[data-testid^="commit-row-"]').filter({
|
|
hasText: COMMIT_SUBJECT,
|
|
});
|
|
await expect(commitRow).toContainText(COMMIT_SUBJECT, { timeout: 30_000 });
|
|
await expect(page.locator('[data-testid^="commit-row-"]')).toHaveCount(1);
|
|
await expect(commitRow).toContainText("Jan 15");
|
|
await commitRow.click();
|
|
|
|
const panel = page.getByTestId("commit-diff-panel").filter({ visible: true });
|
|
await expect(panel.getByTestId("commit-diff-toolbar")).toBeVisible({ timeout: 30_000 });
|
|
const layoutToggle = panel.getByTestId("commit-diff-toggle-layout");
|
|
const [commitToolbarBox, layoutToggleBox, layoutToggleGlyphBox] = await Promise.all([
|
|
panel.getByTestId("commit-diff-header").boundingBox(),
|
|
layoutToggle.boundingBox(),
|
|
layoutToggle.locator("svg").boundingBox(),
|
|
]);
|
|
if (!commitToolbarBox || !layoutToggleBox || !layoutToggleGlyphBox) {
|
|
throw new Error("Commit-diff toolbar geometry could not be measured");
|
|
}
|
|
expect(commitToolbarBox.height).toBe(36);
|
|
expect(layoutToggleBox.width).toBe(20);
|
|
expect(layoutToggleBox.height).toBe(20);
|
|
expect(layoutToggleGlyphBox.width).toBe(14);
|
|
expect(layoutToggleGlyphBox.height).toBe(14);
|
|
await expect(layoutToggle).toHaveAccessibleName("Switch to side-by-side diff");
|
|
await expect(panel.getByTestId("git-diff-canvas")).toBeVisible({ timeout: 30_000 });
|
|
await expectCommitDiffHeaderGeometry(panel);
|
|
|
|
await layoutToggle.click();
|
|
await expect(layoutToggle).toHaveAccessibleName("Switch to unified diff");
|
|
await expect(panel.locator('[data-testid^="diff-code-row-"]')).toHaveCount(0);
|
|
await expect(panel.getByTestId("diff-file-0-body")).toBeVisible();
|
|
|
|
await page.getByTestId(/^workspace-tab-commit_diff_/).hover();
|
|
await page.getByTestId(/^workspace-commit-diff-close-/).click();
|
|
await expect(panel).toHaveCount(0);
|
|
await commitRow.click();
|
|
await expect(panel.getByTestId("commit-diff-toggle-layout")).toHaveAccessibleName(
|
|
"Switch to unified diff",
|
|
{ timeout: 30_000 },
|
|
);
|
|
|
|
await page.setViewportSize({ width: 480, height: 900 });
|
|
await expect(panel.getByTestId("commit-diff-toolbar")).toHaveCount(0);
|
|
await expect(panel.getByTestId("git-diff-canvas")).toBeVisible();
|
|
});
|
|
|
|
test("a fresh commit says just now and its age advances", async ({ page, withWorkspace }) => {
|
|
const workspace = await withWorkspace({ prefix: "commit-relative-time-" });
|
|
const committedAt = new Date();
|
|
await createFeatureCommit(workspace.repoPath, committedAt.toISOString());
|
|
await page.clock.install({ time: committedAt });
|
|
await workspace.navigateTo();
|
|
|
|
await openChangesTreePanel(page);
|
|
await page.getByRole("button", { name: /Commits/i }).click();
|
|
const row = page.locator('[data-testid^="commit-row-"]').filter({ hasText: COMMIT_SUBJECT });
|
|
await expect(row).toContainText("just now", { timeout: 30_000 });
|
|
await page.clock.fastForward("03:00");
|
|
await expect(row).toContainText("3m ago");
|
|
});
|
|
|
|
async function createFeatureCommit(
|
|
repoPath: string,
|
|
authorDate = "2020-01-15T12:00:00Z",
|
|
): Promise<void> {
|
|
execFileSync("git", ["checkout", "-b", "feature"], { cwd: repoPath, stdio: "ignore" });
|
|
await writeFile(path.join(repoPath, "feature.txt"), "before\nafter\n");
|
|
execFileSync("git", ["add", "feature.txt"], { cwd: repoPath, stdio: "ignore" });
|
|
execFileSync("git", ["commit", "-m", COMMIT_SUBJECT], {
|
|
cwd: repoPath,
|
|
stdio: "ignore",
|
|
env: {
|
|
...process.env,
|
|
GIT_AUTHOR_DATE: authorDate,
|
|
GIT_COMMITTER_DATE: authorDate,
|
|
},
|
|
});
|
|
}
|
|
|
|
async function expectCommitDiffHeaderGeometry(panel: Locator): Promise<void> {
|
|
const [header, canvas] = await Promise.all([
|
|
panel.getByTestId("diff-file-0").boundingBox(),
|
|
panel.getByTestId("git-diff-sticky-header-0").boundingBox(),
|
|
]);
|
|
expect(header).not.toBeNull();
|
|
expect(canvas).not.toBeNull();
|
|
expect(header!.height).toBeCloseTo(30, 0);
|
|
expect(header!.x).toBeCloseTo(canvas!.x, 0);
|
|
expect(header!.width).toBeCloseTo(canvas!.width, 0);
|
|
expect(header!.y).toBeCloseTo(canvas!.y, 0);
|
|
await expect(panel.getByTestId("diff-file-0")).toHaveAccessibleName("feature.txt, +2, -0");
|
|
}
|