Files
paseo/packages/app/src/git/pull-request-panel/native-data.test.ts
T
nllptrxandMohamed Boudra 4a5716360b Feat/forge check semantics and followup fixes (#2337)
* feat(protocol): add forge check presentation metadata

Expose optional rawStatus, isManual, and requiresAction fields while keeping older check payloads backward-compatible.

* fix(gitea): model Actions jobs as tasks

Gitea's /actions/tasks endpoint returns individual jobs rather than workflow runs. Preserve sibling tasks from the latest execution, avoid collapsing same-name jobs, and enrich blocked tasks with run-level approval metadata.

* feat(app): distinguish forge check presentation states

* fix(gitlab): preserve pipeline job semantics

* refactor(app): centralize forge check presentation policy

Use one canonical category order, count shape, visual policy, and translated copy mapping across sidebar, hover-card, PR-pane, and GitLab pipeline surfaces.

* refactor: consolidate forge check handling

* feat(forge): auto-attach pasted forge references

* docs(compat): correct forge rollout metadata

* refactor(forge): model check nuances as traits

* fix(forge): harden checks from branch review

Structural Gitea Actions shadow dedup by run id (verified upstream),
rerun grouping without workflow_id, shared trait/status constants and
Gitea state mapping in the protocol package, all cloud host aliases in
pasted-link matching, logged glab job-detail failures, concurrent
approvals/pipeline fetch, checks aggregate from the same pipeline as
the job list, and removal of the unread check-level rawStatus. The
released pipeline-level rawStatus is staged for removal under
COMPAT(pipelineRawStatus).

* fix(gitea): detect fork-PR Actions approval hold as action_required

gitea.com represents a fork PR awaiting Actions approval as a run in
status "waiting" with no tasks and pending shadow commit statuses; it
does not expose need_approval. The previous mapping only set
action_required from a task with blocked+need_approval, so the gate
never surfaced (0 tasks -> early return; need_approval absent). Detect
the hold from /actions/runs: a waiting/blocked run whose PR is
cross-repo (head.repo.id != base.repo.id), or one that does expose
need_approval (self-hosted). Tag the run's pending shadow statuses
action_required. Runs are only fetched when a pending shadow has no
covering task, keeping the common path at two requests. Verified live
against gitea.com fork PR (run 715170, waiting, cross-repo).

* fix(gitea): resolve cross-fork PRs by head sha

The current-PR matcher gated candidates on the checkout owner
(giteaHeadOwner === expectedHeadOwner), which excludes every fork PR:
its head carries the fork owner while the checkout is the base repo, so
a fork PR - the only shape that can be approval-held on Gitea - never
resolved and its checks never showed in-app. GitLab has no such gate
(it resolves fork MRs from the target project by source branch). Accept
a recent PR whose head sha equals the workspace head sha regardless of
owner; the sha is an unambiguous identity, so the anti-collision owner
gate still applies when no sha match is available. Verified live against
gitea.com fork PR #6 (resolves + renders action_required).

* fix: resolve forge rebase drift

* fix: type forge auto-attach boundary

* fix(i18n): add Korean check status copy

---------

Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
2026-08-25 23:37:50 +02:00

162 lines
4.3 KiB
TypeScript

import { describe, expect, it } from "vitest";
import type { CheckoutPrStatusResponse } from "@getpaseo/protocol/messages";
import {
deriveGitlabApprovals,
deriveGitlabPipelineSummary,
type GitlabMergeFacts,
} from "@/git/forges/gitlab";
import { getNativeFallbackChecks } from "./native-data";
type CheckoutPrStatus = NonNullable<CheckoutPrStatusResponse["payload"]["status"]>;
function gitlabFacts(overrides: Partial<GitlabMergeFacts> = {}): GitlabMergeFacts {
return {
forge: "gitlab",
detailedMergeStatus: "mergeable",
mergeStatus: null,
hasConflicts: false,
blockingDiscussionsResolved: true,
approvalsRequired: 0,
approvalsGiven: 0,
pipelineStatus: null,
pipelineId: null,
pipelineUrl: null,
mergeWhenPipelineSucceeds: false,
...overrides,
};
}
function status(forgeSpecific: CheckoutPrStatus["forgeSpecific"], url: string): CheckoutPrStatus {
return {
forge: "gitea",
number: 7,
url,
title: "Native data",
state: "open",
baseRefName: "main",
headRefName: "feature",
isMerged: false,
isDraft: false,
mergeable: "UNKNOWN",
checks: [],
reviewDecision: null,
...(forgeSpecific ? { forgeSpecific } : {}),
};
}
describe("deriveGitlabPipelineSummary", () => {
it("summarizes a head pipeline, mapping the raw status onto a check status", () => {
expect(
deriveGitlabPipelineSummary(
gitlabFacts({
pipelineStatus: "running",
pipelineId: 306,
pipelineUrl: "https://gitlab.com/group/repo/-/pipelines/306",
}),
),
).toEqual({
id: 306,
status: "pending",
rawStatus: "running",
url: "https://gitlab.com/group/repo/-/pipelines/306",
});
});
it("returns null when the MR has no head pipeline", () => {
expect(deriveGitlabPipelineSummary(gitlabFacts({ pipelineId: null }))).toBeNull();
});
});
describe("deriveGitlabApprovals", () => {
it("surfaces N of M approvals", () => {
expect(deriveGitlabApprovals(gitlabFacts({ approvalsRequired: 2, approvalsGiven: 1 }))).toEqual(
{
given: 1,
required: 2,
},
);
});
it("returns null when no approvals are required", () => {
expect(deriveGitlabApprovals(gitlabFacts({ approvalsRequired: 0 }))).toBeNull();
});
});
describe("getNativeFallbackChecks", () => {
it("surfaces the Gitea aggregate CI status branded with the top-level forge", () => {
expect(
getNativeFallbackChecks(
status(
{ forge: "gitea", mergeable: true, hasMerged: false, ciStatus: "success" },
"https://gitea.com/group/repo/pulls/7",
),
"gitea",
),
).toEqual([
{
provider: "gitea",
name: "CI",
status: "success",
url: "https://gitea.com/group/repo/pulls/7",
},
]);
});
it("keeps Forgejo branding for the Gitea-family aggregate check", () => {
expect(
getNativeFallbackChecks(
status(
{ forge: "gitea", mergeable: true, hasMerged: false, ciStatus: "failure" },
"https://forgejo.example.com/group/repo/pulls/7",
),
"forgejo",
),
).toEqual([
{
provider: "forgejo",
name: "CI",
status: "failure",
url: "https://forgejo.example.com/group/repo/pulls/7",
},
]);
});
it("maps a Gitea 'warning' aggregate to a failing fallback check, not pending", () => {
expect(
getNativeFallbackChecks(
status(
{ forge: "gitea", mergeable: true, hasMerged: false, ciStatus: "warning" },
"https://gitea.com/group/repo/pulls/7",
),
"gitea",
),
).toEqual([
{
provider: "gitea",
name: "CI",
status: "failure",
traits: ["warning"],
url: "https://gitea.com/group/repo/pulls/7",
},
]);
});
it("returns no fallback checks for a forge that reports none", () => {
expect(
getNativeFallbackChecks(
status(
{ forge: "gitea", mergeable: true, hasMerged: false, ciStatus: null },
"https://gitea.com/group/repo/pulls/7",
),
"gitea",
),
).toEqual([]);
expect(
getNativeFallbackChecks(
status(gitlabFacts(), "https://gitlab.com/group/repo/-/merge_requests/7"),
"gitlab",
),
).toEqual([]);
});
});