mirror of
https://github.com/getpaseo/paseo.git
synced 2026-07-29 12:01:31 +00:00
0b78379b77
* test(server): add real-spawn round-trip for % in argv RED test: pass --format=%(refname)... through spawnProcess to a child node script that echoes argv[2]. Asserts the child receives the original string verbatim. Wired into the Windows CI matrix to expose the escapeWindowsCmdValue %-doubling bug under cmd.exe. * test(server): use bare 'node' command so cmd.exe path is exercised process.execPath has both an extension and a path separator on Windows, so shouldUseWindowsShell returns false and the broken %-escape pipeline is never invoked. Use the bare command name 'node' instead. * fix(server): stop doubling % in cmd.exe arg escaping on Windows cmd.exe only collapses `%%` → `%` inside batch files; on the command line / via `cmd /c "..."` `%%` stays literal. Doubling `%` in escapeWindowsCmdValue meant args like `--format=%(refname)` reached git as `--format=%%(refname)`, which git interprets as the escape sequence for a literal `%`, so format atoms appeared verbatim and the branch picker showed `%(refname)%09%(committerdate:unix)` instead of branch names. Update unit tests that pinned the broken doubling behavior.
47 lines
1.8 KiB
TypeScript
47 lines
1.8 KiB
TypeScript
import { extname } from "node:path";
|
|
|
|
export function isWindowsCommandScript(executablePath: string): boolean {
|
|
const extension = extname(executablePath).toLowerCase();
|
|
return process.platform === "win32" && (extension === ".cmd" || extension === ".bat");
|
|
}
|
|
|
|
function escapeWindowsCmdValue(value: string): string {
|
|
if (process.platform !== "win32") return value;
|
|
|
|
const isQuoted = value.startsWith('"') && value.endsWith('"');
|
|
const unquoted = isQuoted ? value.slice(1, -1) : value;
|
|
// Do NOT double `%` here. cmd.exe only collapses `%%` → `%` inside batch
|
|
// files; on the command line / `cmd /c "..."` `%%` stays literal, which
|
|
// breaks args like git's `--format=%(refname)` (git treats `%%` as the
|
|
// escape for a literal `%`, so the format atoms become literals).
|
|
const escaped = unquoted.replace(/([&|^<>()!])/g, "^$1");
|
|
|
|
if (isQuoted || /[\s"]/u.test(unquoted)) {
|
|
const quoted = escaped
|
|
.replace(/(\\*)"/g, (_match, slashes: string) => `${slashes}${slashes}\\"`)
|
|
.replace(/\\+$/u, (slashes) => `${slashes}${slashes}`);
|
|
return `"${quoted}"`;
|
|
}
|
|
|
|
return escaped;
|
|
}
|
|
|
|
/**
|
|
* When spawning with `shell: true` on Windows, the command is passed to
|
|
* `cmd.exe /d /s /c "command args"`. The `/s` strips outer quotes, so a
|
|
* command path with spaces (e.g. `C:\Program Files\...`) is split at the
|
|
* space. Wrapping it in quotes produces the correct `"C:\Program Files\..." args`.
|
|
*/
|
|
export function quoteWindowsCommand(command: string): string {
|
|
return escapeWindowsCmdValue(command);
|
|
}
|
|
|
|
/**
|
|
* `spawn(..., { shell: true })` on Windows also passes argv through `cmd.exe`.
|
|
* Any argument containing spaces must be quoted or it will be split before the
|
|
* child process sees it.
|
|
*/
|
|
export function quoteWindowsArgument(argument: string): string {
|
|
return escapeWindowsCmdValue(argument);
|
|
}
|