mirror of
https://github.com/getpaseo/paseo.git
synced 2026-07-29 12:01:31 +00:00
218097b7cc
* feat: clone GitHub repo into a workspace Add an end-to-end "clone a GitHub repo and register it as a Paseo workspace" flow: a new workspace.github.clone RPC, daemon handler, client method, CLI `paseo clone` command, and a GitHub-repo mode in the project picker modal. Gated behind the workspaceGithubClone server capability flag. - protocol: workspace.github.clone request/response schemas + feature flag - server: handleWorkspaceGithubCloneRequest, normalizeCloneRepository - client: DaemonClient.cloneGithubWorkspace - cli: `paseo clone <repo> --dir <path> [--protocol https|ssh]` - app: GitHub-repo mode, clone-protocol picker, error surfacing Review fixes: - CLI clone now checks the workspaceGithubClone capability and fails fast with a clear "update the host" error instead of hanging for the full request timeout against an older daemon. - Replace the duplicated client-side URL-detection regex (app + CLI) with a shared isCompleteGitRemote() in @getpaseo/protocol/git-remote, backed by parseGitRemoteLocation so clients classify remotes identically to the daemon (fixes confusing errors for git://, ftp://, file:// inputs). - Add git-remote.test.ts covering the shared classifier. * Fix GitHub clone failure handling --------- Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
100 lines
3.0 KiB
TypeScript
100 lines
3.0 KiB
TypeScript
const GITHUB_HOSTS = new Set(["github.com", "ssh.github.com"]);
|
|
|
|
const TRANSPORT_BY_PROTOCOL: Record<string, GitRemoteLocation["transport"]> = {
|
|
"https:": "https",
|
|
"http:": "http",
|
|
"ssh:": "ssh",
|
|
};
|
|
|
|
export interface GitRemoteLocation {
|
|
transport: "scp" | "ssh" | "http" | "https";
|
|
host: string;
|
|
path: string;
|
|
}
|
|
|
|
export interface GitHubRemoteIdentity {
|
|
owner: string;
|
|
name: string;
|
|
repo: string;
|
|
}
|
|
|
|
export function parseGitHubRemoteUrl(remoteUrl: string): GitHubRemoteIdentity | null {
|
|
const location = parseGitRemoteLocation(remoteUrl);
|
|
if (!location || !isGitHubHost(location.host)) return null;
|
|
return parseGitHubRemoteIdentity(location.path);
|
|
}
|
|
|
|
/**
|
|
* Whether `repo` is already a complete git remote (a URL or scp-like address)
|
|
* rather than `owner/repo` shorthand that still needs a clone protocol picked.
|
|
*
|
|
* Clients (app + CLI) and the daemon must agree on this classification: the
|
|
* daemon treats `parseGitRemoteLocation(repo) !== null` as "complete remote"
|
|
* and everything else as shorthand, so reuse the same parser here instead of a
|
|
* separate regex that would drift (e.g. accepting `git://` the parser rejects).
|
|
*/
|
|
export function isCompleteGitRemote(repo: string): boolean {
|
|
return parseGitRemoteLocation(repo) !== null;
|
|
}
|
|
|
|
export function parseGitRemoteLocation(remoteUrl: string): GitRemoteLocation | null {
|
|
const trimmed = remoteUrl.trim();
|
|
if (!trimmed) return null;
|
|
|
|
const scpLike = trimmed.match(/^[^@]+@([^:]+):(.+)$/u);
|
|
if (scpLike) {
|
|
const host = normalizeHost(scpLike[1] ?? "");
|
|
const path = normalizeRemotePath(scpLike[2] ?? "");
|
|
if (!isValidRemoteHost(host) || !path) return null;
|
|
return { transport: "scp", host, path };
|
|
}
|
|
|
|
let parsed: URL;
|
|
try {
|
|
parsed = new URL(trimmed);
|
|
} catch {
|
|
return null;
|
|
}
|
|
|
|
const transport = TRANSPORT_BY_PROTOCOL[parsed.protocol.toLowerCase()];
|
|
if (!transport) return null;
|
|
|
|
const host = normalizeHost(parsed.hostname);
|
|
let path: string;
|
|
try {
|
|
path = decodeURIComponent(parsed.pathname);
|
|
} catch {
|
|
return null;
|
|
}
|
|
const normalizedPath = normalizeRemotePath(path);
|
|
if (!isValidRemoteHost(host) || !normalizedPath) return null;
|
|
|
|
return { transport, host, path: normalizedPath };
|
|
}
|
|
|
|
export function parseGitHubRemoteIdentity(path: string): GitHubRemoteIdentity | null {
|
|
const segments = path.split("/").filter(Boolean);
|
|
if (segments.length !== 2) return null;
|
|
const [owner, name] = segments;
|
|
if (!owner || !name) return null;
|
|
return { owner, name, repo: `${owner}/${name}` };
|
|
}
|
|
|
|
export function isGitHubHost(host: string): boolean {
|
|
return GITHUB_HOSTS.has(host);
|
|
}
|
|
|
|
export function normalizeHost(host: string): string {
|
|
return host.trim().replace(/\.+$/u, "").toLowerCase();
|
|
}
|
|
|
|
function normalizeRemotePath(path: string): string | null {
|
|
let normalized = path.trim().replace(/^\/+|\/+$/gu, "");
|
|
if (normalized.endsWith(".git")) normalized = normalized.slice(0, -4);
|
|
return normalized || null;
|
|
}
|
|
|
|
function isValidRemoteHost(host: string): boolean {
|
|
return /^[a-z0-9](?:[a-z0-9._-]*[a-z0-9])?$/u.test(host);
|
|
}
|