mirror of
https://github.com/getpaseo/paseo.git
synced 2026-07-29 12:01:31 +00:00
* Make workspace IDs opaque, independent of the filesystem path Workspace IDs were the resolved checkout/worktree path, so code could treat an ID as a path: prefix matching, deriving directories from it, falling back to a path when a lookup missed. IDs are now opaque - compared only by exact equality and never used as a path. Anything path-shaped resolves the workspace record first and reads its cwd. New workspaces get a generated `wks_` ID; existing path-shaped IDs are read from disk and never regenerated, so there is no migration and no change to the wire or persisted schemas. Groundwork for running multiple workspaces in a single directory. * Keep attachment scope key stable and align refetch test The attachment scope key keeps `workspace=` instead of `wsid=` so existing persisted drafts are not orphaned; the rename was cosmetic. The SDK refetch test no longer asserts a filter, matching refetch fetching one page and selecting by id client-side. * Fix live agent updates in directories without a registered workspace The opaque-ID work removed buildProjectPlacementForCwd's directory fallback, so an agent running in a folder with no registered workspace (e.g. a fresh non-git dir) produced a null placement. forwardAgentUpdate then threw "Workspace not found", the error was swallowed by its catch, and no agent_update was emitted — live model/thinking switches and status updates silently stopped. Caught by the live-preferences e2e suite. The fallback builds a directory-scoped project placement keyed by the path. That key is a project grouping key (non-git projects group by path), not a workspace id, so it stays within the opaque-id rule. * Always run server worktree archive, even without a resolved workspace Archiving bailed out entirely when the workspace was not found in the client store, so a race or stale state could make "archive" do nothing server-side with only a console.warn. The server archive is keyed by worktreePath, which is always available, so it now runs regardless; only the optimistic client-side updates (keyed by workspace id) are gated on the workspace being resolved. * Expect a directory-scoped placement for unregistered agent dirs This unit test asserted the no-placement behavior reverted in the live agent-update fix, which had broken live model/thinking switching. Update it to expect the directory-scoped placement now emitted for an agent in a directory with no registered workspace. * Fix opaque workspace routing in app E2E * Preserve workspace IDs during partial bootstrap * Fix archive flows for opaque workspace IDs * Stop treating opaque workspace IDs as filesystem paths Workspace IDs are opaque (wks_<hex>), but several call sites still passed the id where a directory was expected, which broke those flows for opaque IDs. The branch switcher sent the id as a cwd to branch/stash/checkout git operations, and server archive/reconcile cleanup keyed git-watch and subscription teardown by id, leaking that state. Git and filesystem operations now take the workspace directory; the opaque id is used only for identity and cache keys. Archive/reconcile cleanup routes through a single teardownArchivedWorkspace helper that keeps the key split explicit: runtime store by id, git watch and subscription by cwd. Path-derived grouping keys are renamed to directory keys, and the helpers are split into workspace-identity and workspace-directory so the id-vs-path boundary is obvious.
203 lines
7.9 KiB
TypeScript
203 lines
7.9 KiB
TypeScript
import { expect, type Page } from "@playwright/test";
|
|
import { buildHostWorkspaceRoute } from "../../src/utils/host-routes";
|
|
import { createTempGitRepo } from "./workspace";
|
|
import { getServerId } from "./server-id";
|
|
|
|
// ─── Navigation ────────────────────────────────────────────────────────────
|
|
|
|
/** Navigate to a workspace and wait for the tab bar to appear. */
|
|
export async function gotoWorkspace(page: Page, workspaceId: string): Promise<void> {
|
|
const route = buildHostWorkspaceRoute(getServerId(), workspaceId);
|
|
await page.goto(route);
|
|
await waitForTabBar(page);
|
|
}
|
|
|
|
// ─── Tab bar queries ───────────────────────────────────────────────────────
|
|
|
|
/** Wait for the workspace tab bar to be visible. */
|
|
export async function waitForTabBar(page: Page): Promise<void> {
|
|
await expect(
|
|
page.getByTestId("workspace-tabs-row").filter({ visible: true }).first(),
|
|
).toBeVisible({
|
|
timeout: 30_000,
|
|
});
|
|
}
|
|
|
|
/** Return all tab test IDs currently in the tab bar. */
|
|
export async function getTabTestIds(page: Page): Promise<string[]> {
|
|
const tabs = page
|
|
.locator('[data-testid^="workspace-tab-"]:not([data-testid^="workspace-tab-context-"])')
|
|
.filter({ visible: true });
|
|
const count = await tabs.count();
|
|
const ids: string[] = [];
|
|
for (let i = 0; i < count; i++) {
|
|
const testId = await tabs.nth(i).getAttribute("data-testid");
|
|
if (testId) ids.push(testId);
|
|
}
|
|
return ids;
|
|
}
|
|
|
|
/** Return the number of tabs matching a kind prefix (e.g. "launcher", "draft", "terminal", "agent"). */
|
|
export async function countTabsOfKind(page: Page, kind: string): Promise<number> {
|
|
const ids = await getTabTestIds(page);
|
|
return ids.filter((id) => id.includes(kind)).length;
|
|
}
|
|
|
|
/** Return the currently active tab's test ID (the one with aria-selected or focus styling). */
|
|
export async function getActiveTabTestId(page: Page): Promise<string | null> {
|
|
// Active tab has the focused highlight — check for the aria-selected or data-active attribute
|
|
const activeTab = page
|
|
.locator(
|
|
'[data-testid^="workspace-tab-"]:not([data-testid^="workspace-tab-context-"])[aria-selected="true"]',
|
|
)
|
|
.filter({ visible: true })
|
|
.first();
|
|
if (await activeTab.isVisible().catch(() => false)) {
|
|
return activeTab.getAttribute("data-testid");
|
|
}
|
|
// Fallback: the tab with focused styling
|
|
return null;
|
|
}
|
|
|
|
// ─── Tab actions ───────────────────────────────────────────────────────────
|
|
|
|
/** Press Cmd+T (macOS) or Ctrl+T (Linux/Windows) to open a new tab. */
|
|
export async function pressNewTabShortcut(page: Page): Promise<void> {
|
|
const modifier = process.platform === "darwin" ? "Meta" : "Control";
|
|
await page.keyboard.press(`${modifier}+t`);
|
|
}
|
|
|
|
// ─── Tab bar assertions ───────────────────────────────────────────────────
|
|
|
|
/** Assert the inline new-agent plus button is visible in the tab bar. */
|
|
export async function assertNewChatTileVisible(page: Page): Promise<void> {
|
|
await expect(
|
|
page.getByTestId("workspace-new-agent-tab-inline").filter({ visible: true }).first(),
|
|
).toBeVisible();
|
|
}
|
|
|
|
/** Assert the new-tab dropdown trigger is visible in the tab bar. */
|
|
export async function assertNewTabMenuTriggerVisible(page: Page): Promise<void> {
|
|
await expect(
|
|
page.getByTestId("workspace-new-tab-menu-trigger").filter({ visible: true }).first(),
|
|
).toBeVisible();
|
|
}
|
|
|
|
// ─── Tab creation actions ─────────────────────────────────────────────────
|
|
|
|
/** Click the inline plus button to create a draft/chat tab. */
|
|
export async function clickNewChat(page: Page): Promise<void> {
|
|
const button = page
|
|
.getByTestId("workspace-new-agent-tab-inline")
|
|
.filter({ visible: true })
|
|
.first();
|
|
await expect(button).toBeVisible({ timeout: 10_000 });
|
|
await button.click();
|
|
}
|
|
|
|
/** Open the new-tab menu and click "New terminal". */
|
|
export async function clickNewTerminal(page: Page): Promise<void> {
|
|
const trigger = page
|
|
.getByTestId("workspace-new-tab-menu-trigger")
|
|
.filter({ visible: true })
|
|
.first();
|
|
await expect(trigger).toBeVisible({ timeout: 10_000 });
|
|
await trigger.click();
|
|
const item = page
|
|
.getByTestId("workspace-new-tab-menu-terminal")
|
|
.filter({ visible: true })
|
|
.first();
|
|
await expect(item).toBeVisible({ timeout: 10_000 });
|
|
await item.click();
|
|
}
|
|
|
|
// ─── Tab title assertions ──────────────────────────────────────────────────
|
|
|
|
/** Wait for any tab in the bar to display the given title text. */
|
|
export async function waitForTabWithTitle(
|
|
page: Page,
|
|
title: string | RegExp,
|
|
timeout = 30_000,
|
|
): Promise<void> {
|
|
const matcher = typeof title === "string" ? new RegExp(title, "i") : title;
|
|
await expect(
|
|
page
|
|
.locator('[data-testid^="workspace-tab-"]:not([data-testid^="workspace-tab-context-"])')
|
|
.filter({ hasText: matcher })
|
|
.filter({ visible: true })
|
|
.first(),
|
|
).toBeVisible({ timeout });
|
|
}
|
|
|
|
/** Assert the inline new-agent plus button is visible in the tab bar. */
|
|
export async function assertSingleNewTabButton(page: Page): Promise<void> {
|
|
const buttons = page.getByTestId("workspace-new-agent-tab-inline").filter({ visible: true });
|
|
const count = await buttons.count();
|
|
expect(count).toBeGreaterThanOrEqual(1);
|
|
}
|
|
|
|
// ─── No-flash measurement ──────────────────────────────────────────────────
|
|
|
|
/**
|
|
* Measure the time between clicking a launcher tile and the replacement panel becoming visible.
|
|
* Returns elapsed milliseconds.
|
|
*/
|
|
export async function measureTileTransition(
|
|
page: Page,
|
|
clickAction: () => Promise<void>,
|
|
successLocator: ReturnType<Page["locator"]>,
|
|
timeout = 5_000,
|
|
): Promise<number> {
|
|
const start = Date.now();
|
|
await clickAction();
|
|
await expect(successLocator).toBeVisible({ timeout });
|
|
return Date.now() - start;
|
|
}
|
|
|
|
/**
|
|
* Sample tab IDs at high frequency across a transition to detect blank/intermediate states.
|
|
* Returns all unique snapshots observed.
|
|
*/
|
|
export async function sampleTabsDuringTransition(
|
|
page: Page,
|
|
action: () => Promise<void>,
|
|
durationMs = 2_000,
|
|
intervalMs = 30,
|
|
): Promise<string[][]> {
|
|
const snapshots: string[][] = [];
|
|
const startSampling = async () => {
|
|
const start = Date.now();
|
|
while (Date.now() - start < durationMs) {
|
|
snapshots.push(await getTabTestIds(page));
|
|
await page.waitForTimeout(intervalMs);
|
|
}
|
|
};
|
|
|
|
const samplingPromise = startSampling();
|
|
await action();
|
|
await samplingPromise;
|
|
return snapshots;
|
|
}
|
|
|
|
export function terminalSurfaceLocator(page: Page) {
|
|
return page.locator('[data-testid="terminal-surface"]').first();
|
|
}
|
|
|
|
export async function expectAgentTabActive(page: Page, agentId: string): Promise<void> {
|
|
const tabTestId = `workspace-tab-agent_${agentId}`;
|
|
await expect(page.getByTestId(tabTestId).filter({ visible: true })).toHaveAttribute(
|
|
"aria-selected",
|
|
"true",
|
|
);
|
|
await expect(getActiveTabTestId(page)).resolves.toBe(tabTestId);
|
|
}
|
|
|
|
// ─── Workspace setup ───────────────────────────────────────────────────────
|
|
|
|
/** Create a temp git repo and return its path with a cleanup function. */
|
|
export async function createWorkspace(
|
|
prefix = "launcher-e2e-",
|
|
): ReturnType<typeof createTempGitRepo> {
|
|
return createTempGitRepo(prefix);
|
|
}
|