mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-31 13:42:50 +00:00
* feat(protocol): add forge check presentation metadata Expose optional rawStatus, isManual, and requiresAction fields while keeping older check payloads backward-compatible. * fix(gitea): model Actions jobs as tasks Gitea's /actions/tasks endpoint returns individual jobs rather than workflow runs. Preserve sibling tasks from the latest execution, avoid collapsing same-name jobs, and enrich blocked tasks with run-level approval metadata. * feat(app): distinguish forge check presentation states * fix(gitlab): preserve pipeline job semantics * refactor(app): centralize forge check presentation policy Use one canonical category order, count shape, visual policy, and translated copy mapping across sidebar, hover-card, PR-pane, and GitLab pipeline surfaces. * refactor: consolidate forge check handling * feat(forge): auto-attach pasted forge references * docs(compat): correct forge rollout metadata * refactor(forge): model check nuances as traits * fix(forge): harden checks from branch review Structural Gitea Actions shadow dedup by run id (verified upstream), rerun grouping without workflow_id, shared trait/status constants and Gitea state mapping in the protocol package, all cloud host aliases in pasted-link matching, logged glab job-detail failures, concurrent approvals/pipeline fetch, checks aggregate from the same pipeline as the job list, and removal of the unread check-level rawStatus. The released pipeline-level rawStatus is staged for removal under COMPAT(pipelineRawStatus). * fix(gitea): detect fork-PR Actions approval hold as action_required gitea.com represents a fork PR awaiting Actions approval as a run in status "waiting" with no tasks and pending shadow commit statuses; it does not expose need_approval. The previous mapping only set action_required from a task with blocked+need_approval, so the gate never surfaced (0 tasks -> early return; need_approval absent). Detect the hold from /actions/runs: a waiting/blocked run whose PR is cross-repo (head.repo.id != base.repo.id), or one that does expose need_approval (self-hosted). Tag the run's pending shadow statuses action_required. Runs are only fetched when a pending shadow has no covering task, keeping the common path at two requests. Verified live against gitea.com fork PR (run 715170, waiting, cross-repo). * fix(gitea): resolve cross-fork PRs by head sha The current-PR matcher gated candidates on the checkout owner (giteaHeadOwner === expectedHeadOwner), which excludes every fork PR: its head carries the fork owner while the checkout is the base repo, so a fork PR - the only shape that can be approval-held on Gitea - never resolved and its checks never showed in-app. GitLab has no such gate (it resolves fork MRs from the target project by source branch). Accept a recent PR whose head sha equals the workspace head sha regardless of owner; the sha is an unambiguous identity, so the anti-collision owner gate still applies when no sha match is available. Verified live against gitea.com fork PR #6 (resolves + renders action_required). * fix: resolve forge rebase drift * fix: type forge auto-attach boundary * fix(i18n): add Korean check status copy --------- Co-authored-by: Mohamed Boudra <boudra.moha@gmail.com>
127 lines
4.1 KiB
TypeScript
127 lines
4.1 KiB
TypeScript
import { test } from "../support/fixtures";
|
|
import {
|
|
openPrPane,
|
|
expectPrPaneTitle,
|
|
expectPrPaneState,
|
|
expectPrPaneCheckSummary,
|
|
expectPrPaneActivityCount,
|
|
} from "../support/helpers/pr-pane";
|
|
import { gotoWorkspace } from "../support/helpers/launcher";
|
|
import {
|
|
hasGithubAuth,
|
|
createTempGithubRepo,
|
|
type GhRepoFixture,
|
|
} from "../support/helpers/github-fixtures";
|
|
import {
|
|
connectWorkspaceSetupClient,
|
|
openProjectViaDaemon,
|
|
type WorkspaceSetupDaemonClient,
|
|
} from "../support/helpers/workspace-setup";
|
|
|
|
const GITHUB_AUTH = hasGithubAuth();
|
|
|
|
test.describe("PR pane", () => {
|
|
test.describe.configure({ retries: 1 });
|
|
|
|
let seedClient: WorkspaceSetupDaemonClient;
|
|
let repoFixture: GhRepoFixture;
|
|
const workspaceByTitle = new Map<string, string>();
|
|
|
|
test.beforeAll(async () => {
|
|
if (!GITHUB_AUTH) return;
|
|
|
|
seedClient = await connectWorkspaceSetupClient();
|
|
|
|
repoFixture = await createTempGithubRepo({
|
|
category: "pr-pane",
|
|
prs: [
|
|
{ title: "Review selected start ref", state: "open" },
|
|
{ title: "Merged feature branch", state: "merged" },
|
|
{ title: "Closed without merge", state: "closed" },
|
|
{ title: "Work in progress", state: "draft" },
|
|
{
|
|
title: "PR with mixed checks",
|
|
state: "open",
|
|
checks: [
|
|
{ context: "build-1", state: "success" },
|
|
{ context: "build-2", state: "success" },
|
|
{ context: "deploy", state: "failure" },
|
|
{ context: "security", state: "pending" },
|
|
],
|
|
},
|
|
{ title: "PR with reviews", state: "open", commentCount: 3 },
|
|
{ title: "PR with no checks", state: "open" },
|
|
],
|
|
});
|
|
|
|
for (const pr of repoFixture.prs) {
|
|
const workspace = await openProjectViaDaemon(seedClient, pr.localPath);
|
|
workspaceByTitle.set(pr.title, workspace.id);
|
|
}
|
|
});
|
|
|
|
test.afterAll(async () => {
|
|
await repoFixture?.cleanup().catch(() => undefined);
|
|
await seedClient?.close().catch(() => undefined);
|
|
});
|
|
|
|
test.beforeEach(async () => {
|
|
test.skip(!GITHUB_AUTH, "Requires GitHub authentication (gh auth login)");
|
|
test.setTimeout(60_000);
|
|
});
|
|
|
|
test("renders an open PR with title, state, and repo line", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("Review selected start ref")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneTitle(page, "Review selected start ref");
|
|
await expectPrPaneState(page, "open");
|
|
});
|
|
|
|
test("renders merged state label and icon", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("Merged feature branch")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneState(page, "merged");
|
|
await expectPrPaneTitle(page, "Merged feature branch");
|
|
});
|
|
|
|
test("renders closed state label and icon", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("Closed without merge")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneState(page, "closed");
|
|
await expectPrPaneTitle(page, "Closed without merge");
|
|
});
|
|
|
|
test("renders draft state label and icon", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("Work in progress")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneState(page, "draft");
|
|
await expectPrPaneTitle(page, "Work in progress");
|
|
});
|
|
|
|
test("renders check pills with correct success/failure/pending counts", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("PR with mixed checks")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneCheckSummary(page, { success: 2, failure: 1, pending: 1 });
|
|
});
|
|
|
|
test("renders activity rows with correct count", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("PR with reviews")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneActivityCount(page, 3);
|
|
});
|
|
|
|
test("renders gracefully with zero checks", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("PR with no checks")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneCheckSummary(page, { success: 0, failure: 0, pending: 0 });
|
|
await expectPrPaneTitle(page, "PR with no checks");
|
|
});
|
|
});
|