mirror of
https://github.com/getpaseo/paseo.git
synced 2026-10-25 10:42:45 +00:00
* perf(workspaces): stop duplicating setup output in progress snapshots Keep the required combined log field empty for setup clients, which display per-command output. Preserve concatenation only for legacy agent bootstrap timeline cards whose released renderers still read it directly. * refactor(workspaces): own setup exclusively at the workspace boundary Preserve keyed modern agent worktree creation while retiring legacy placement that selected an agent-owned setup lifecycle. Keep output in per-command workspace snapshots and retain empty strings required by existing wire schemas. * fix(server): avoid duplicate cwd in worktree provisioning request * test(e2e): keep developer toasts out of concurrent app assertions Concurrent layout measurements could invoke the same Playwright locator handler before its first dismissal finished, leaving checks waiting for a removed button. Hide only the Expo toast host through test styling while retaining console error capture.
383 lines
13 KiB
TypeScript
383 lines
13 KiB
TypeScript
import { realpathSync } from "node:fs";
|
|
import { expect, type Page } from "@playwright/test";
|
|
import type { DaemonClient as InternalDaemonClient } from "@getpaseo/client/internal/daemon-client";
|
|
import { parseHostWorkspaceRouteFromPathname } from "../../../src/utils/host-routes";
|
|
import { gotoAppShell } from "./app";
|
|
import { connectDaemonClient } from "./daemon-client-loader";
|
|
import { getServerId } from "./server-id";
|
|
import { withProjectOwnership } from "./project-ownership";
|
|
import { switchWorkspaceViaSidebar } from "./workspace-ui";
|
|
import type { SessionOutboundMessage } from "@getpaseo/protocol/messages";
|
|
|
|
type WorkspaceSetupDaemonClient = Pick<
|
|
InternalDaemonClient,
|
|
| "close"
|
|
| "addProject"
|
|
| "connect"
|
|
| "createPaseoWorktree"
|
|
| "createWorkspace"
|
|
| "fetchAgent"
|
|
| "fetchAgents"
|
|
| "fetchWorkspaces"
|
|
| "listTerminals"
|
|
| "observeEvents"
|
|
| "removeProject"
|
|
| "subscribeRawMessages"
|
|
>;
|
|
|
|
export type WorkspaceSetupProgressPayload = Extract<
|
|
SessionOutboundMessage,
|
|
{ type: "workspace_setup_progress" }
|
|
>["payload"];
|
|
|
|
export type { WorkspaceSetupDaemonClient };
|
|
|
|
export async function connectWorkspaceSetupClient(): Promise<WorkspaceSetupDaemonClient> {
|
|
const client = await connectDaemonClient<WorkspaceSetupDaemonClient>({
|
|
clientIdPrefix: "workspace-setup",
|
|
// COMPAT(workspaceSetupObservation): legacy streaming coverage; remove after 2027-04-19.
|
|
capabilities: { workspace_setup_observation: false },
|
|
});
|
|
// Establish demand before a caller can launch setup. Client close releases it.
|
|
try {
|
|
await client.observeEvents(["workspace_setup_progress"]).ready;
|
|
} catch (error) {
|
|
await client.close();
|
|
throw error;
|
|
}
|
|
return withProjectOwnership(client);
|
|
}
|
|
|
|
export async function openProjectViaDaemon(
|
|
client: WorkspaceSetupDaemonClient,
|
|
repoPath: string,
|
|
): Promise<{ id: string; name: string; workspaceDirectory: string }> {
|
|
const result = await client.createWorkspace({
|
|
source: { kind: "directory", path: repoPath },
|
|
});
|
|
if (!result.workspace || result.error) {
|
|
throw new Error(result.error ?? `Failed to create workspace ${repoPath}`);
|
|
}
|
|
return {
|
|
id: result.workspace.id,
|
|
name: result.workspace.name,
|
|
workspaceDirectory: result.workspace.workspaceDirectory,
|
|
};
|
|
}
|
|
|
|
export async function seedProjectForWorkspaceSetup(
|
|
client: WorkspaceSetupDaemonClient,
|
|
repoPath: string,
|
|
): Promise<void> {
|
|
const result = await client.addProject(repoPath);
|
|
if (!result.project || result.error) {
|
|
throw new Error(result.error ?? `Failed to add project ${repoPath}`);
|
|
}
|
|
}
|
|
|
|
export function projectNameFromPath(repoPath: string): string {
|
|
return repoPath.replace(/\/+$/, "").split("/").findLast(Boolean) ?? repoPath;
|
|
}
|
|
|
|
export async function openHomeWithProject(page: Page, repoPath: string): Promise<void> {
|
|
await gotoAppShell(page);
|
|
await expect(
|
|
page
|
|
.locator('[data-testid^="sidebar-project-row-"]')
|
|
.filter({ hasText: projectNameFromPath(repoPath) })
|
|
.first(),
|
|
).toBeVisible({ timeout: 30_000 });
|
|
}
|
|
|
|
function createWorkspaceButton(page: Page, repoPath: string) {
|
|
return page.getByRole("button", {
|
|
name: `Create a new workspace for ${projectNameFromPath(repoPath)}`,
|
|
});
|
|
}
|
|
|
|
async function revealWorkspaceButton(page: Page, repoPath: string): Promise<void> {
|
|
await page
|
|
.locator('[data-testid^="sidebar-project-row-"]')
|
|
.filter({ hasText: projectNameFromPath(repoPath) })
|
|
.first()
|
|
.hover();
|
|
}
|
|
|
|
export async function createWorkspaceFromSidebar(page: Page, repoPath: string): Promise<void> {
|
|
const button = createWorkspaceButton(page, repoPath);
|
|
await revealWorkspaceButton(page, repoPath);
|
|
await expect(button).toBeVisible({ timeout: 30_000 });
|
|
await expect(button).toBeEnabled({ timeout: 30_000 });
|
|
await button.click();
|
|
await expect(page).toHaveURL(/\/new\?/, { timeout: 30_000 });
|
|
await expect(page.getByRole("textbox", { name: "Message agent..." }).first()).toBeVisible({
|
|
timeout: 30_000,
|
|
});
|
|
}
|
|
|
|
export async function getCurrentWorkspaceIdFromRoute(page: Page): Promise<string> {
|
|
await expect
|
|
.poll(
|
|
() => parseHostWorkspaceRouteFromPathname(new URL(page.url()).pathname)?.workspaceId ?? null,
|
|
{ timeout: 30_000 },
|
|
)
|
|
.not.toBeNull();
|
|
|
|
const workspaceId =
|
|
parseHostWorkspaceRouteFromPathname(new URL(page.url()).pathname)?.workspaceId ?? null;
|
|
if (!workspaceId) {
|
|
throw new Error(`Expected a workspace route but found ${page.url()}`);
|
|
}
|
|
|
|
return workspaceId;
|
|
}
|
|
|
|
function workspaceSetupDialog(page: Page) {
|
|
return page.getByTestId("workspace-setup-dialog");
|
|
}
|
|
|
|
export async function createChatAgentFromWorkspaceSetup(
|
|
page: Page,
|
|
input: { message: string },
|
|
): Promise<void> {
|
|
const messageInput = page.getByRole("textbox", { name: "Message agent..." }).first();
|
|
await expect(messageInput).toBeVisible({ timeout: 15_000 });
|
|
await messageInput.fill(input.message);
|
|
await messageInput.press("Enter");
|
|
}
|
|
|
|
/**
|
|
* @deprecated The new workspace screen no longer has a standalone terminal button.
|
|
* Use the daemon API to create a workspace, then open a terminal from the launcher.
|
|
*/
|
|
export async function createStandaloneTerminalFromWorkspaceSetup(page: Page): Promise<void> {
|
|
await workspaceSetupDialog(page)
|
|
.getByRole("button", { name: /^Terminal Create the workspace/i })
|
|
.click();
|
|
}
|
|
|
|
export async function waitForWorkspaceSetupDialogToClose(
|
|
page: Page,
|
|
timeoutMs = 45_000,
|
|
): Promise<void> {
|
|
const dialog = workspaceSetupDialog(page);
|
|
|
|
try {
|
|
await expect(dialog).toHaveCount(0, { timeout: timeoutMs });
|
|
} catch (error) {
|
|
const dialogText = (await dialog.textContent().catch(() => null))?.replace(/\s+/g, " ").trim();
|
|
throw new Error(
|
|
dialogText
|
|
? `Workspace setup dialog stayed open. Visible text: ${dialogText}`
|
|
: `Workspace setup dialog did not close within ${timeoutMs}ms`,
|
|
{ cause: error },
|
|
);
|
|
}
|
|
}
|
|
|
|
export async function expectSetupPanel(page: Page): Promise<void> {
|
|
// If the setup panel is already visible (auto-opened), we're done.
|
|
const panel = page.getByTestId("workspace-setup-panel");
|
|
if (await panel.isVisible().catch(() => false)) {
|
|
return;
|
|
}
|
|
// Otherwise open it manually via workspace header actions menu.
|
|
// Use the specific testID to avoid matching the sidebar kebab which shares
|
|
// the same "Workspace actions" accessibility label.
|
|
const actionsButton = page.getByTestId("workspace-header-menu-trigger");
|
|
await expect(actionsButton).toBeVisible({ timeout: 10_000 });
|
|
await actionsButton.click();
|
|
const showSetup = page.getByTestId("workspace-header-show-setup");
|
|
await expect(showSetup).toBeVisible({ timeout: 5_000 });
|
|
await showSetup.click();
|
|
await expect(panel).toBeVisible({ timeout: 30_000 });
|
|
}
|
|
|
|
export async function expectSetupStatus(
|
|
page: Page,
|
|
status: "Running" | "Completed" | "Failed",
|
|
): Promise<void> {
|
|
await expect(page.getByTestId("workspace-setup-status")).toContainText(status, {
|
|
timeout: 30_000,
|
|
});
|
|
}
|
|
|
|
export async function expectSetupLogContains(page: Page, text: string): Promise<void> {
|
|
await expect(page.getByTestId("workspace-setup-log")).toContainText(text, {
|
|
timeout: 30_000,
|
|
});
|
|
}
|
|
|
|
export async function expectNoSetupMessage(page: Page): Promise<void> {
|
|
await expect(
|
|
page.getByText("No setup commands ran for this workspace.", { exact: true }),
|
|
).toBeVisible({
|
|
timeout: 30_000,
|
|
});
|
|
}
|
|
|
|
export async function createWorkspaceThroughDaemon(
|
|
client: WorkspaceSetupDaemonClient,
|
|
input: { cwd: string; worktreeSlug: string },
|
|
): Promise<{ id: string; name: string }> {
|
|
const result = await client.createPaseoWorktree(input);
|
|
if (!result.workspace || result.error) {
|
|
throw new Error(result.error ?? `Failed to create workspace for ${input.cwd}`);
|
|
}
|
|
return {
|
|
id: result.workspace.id,
|
|
name: result.workspace.name,
|
|
};
|
|
}
|
|
|
|
export async function findWorktreeWorkspaceForProject(
|
|
client: WorkspaceSetupDaemonClient,
|
|
repoPath: string,
|
|
): Promise<{
|
|
id: string;
|
|
name: string;
|
|
projectRootPath: string;
|
|
workspaceDirectory: string;
|
|
}> {
|
|
const payload = await client.fetchWorkspaces();
|
|
const normalizedRepoPath = realpathSync(repoPath);
|
|
const workspace =
|
|
payload.entries.find(
|
|
(entry) =>
|
|
entry.projectRootPath === normalizedRepoPath &&
|
|
entry.workspaceDirectory !== normalizedRepoPath,
|
|
) ?? null;
|
|
if (!workspace) {
|
|
throw new Error(`Failed to find created worktree workspace for ${repoPath}`);
|
|
}
|
|
return {
|
|
id: workspace.id,
|
|
name: workspace.name,
|
|
projectRootPath: workspace.projectRootPath,
|
|
workspaceDirectory: workspace.workspaceDirectory,
|
|
};
|
|
}
|
|
|
|
export async function fetchWorkspaceById(
|
|
client: WorkspaceSetupDaemonClient,
|
|
workspaceId: string,
|
|
): Promise<{
|
|
id: string;
|
|
name: string;
|
|
workspaceDirectory: string;
|
|
projectRootPath: string;
|
|
}> {
|
|
const payload = await client.fetchWorkspaces();
|
|
const workspace = payload.entries.find((entry) => entry.id === workspaceId) ?? null;
|
|
if (!workspace) {
|
|
throw new Error(`Workspace not found: ${workspaceId}`);
|
|
}
|
|
return workspace;
|
|
}
|
|
|
|
export async function navigateToWorkspaceViaSidebar(
|
|
page: Page,
|
|
workspaceId: string,
|
|
): Promise<void> {
|
|
await switchWorkspaceViaSidebar({
|
|
page,
|
|
serverId: getServerId(),
|
|
workspaceId,
|
|
});
|
|
}
|
|
|
|
export async function leaveWorkspaceViaHistory(page: Page): Promise<void> {
|
|
await page.getByRole("button", { name: "History", exact: true }).click();
|
|
await expect(page).toHaveURL(/\/sessions$/, { timeout: 30_000 });
|
|
}
|
|
|
|
export async function openWorkspaceScriptsMenu(page: Page): Promise<void> {
|
|
await page.getByTestId("workspace-scripts-button").click();
|
|
await expect(page.getByTestId("workspace-scripts-menu")).toBeVisible({ timeout: 10_000 });
|
|
}
|
|
|
|
export async function startWorkspaceScriptFromMenu(page: Page, scriptName: string): Promise<void> {
|
|
await page.getByTestId(`workspace-scripts-start-${scriptName}`).click();
|
|
}
|
|
|
|
export async function closeWorkspaceScriptsMenu(page: Page): Promise<void> {
|
|
await page.getByTestId("workspace-scripts-menu-backdrop").click();
|
|
}
|
|
|
|
export async function waitForWorkspaceSetupProgress(
|
|
client: WorkspaceSetupDaemonClient,
|
|
predicate: (payload: WorkspaceSetupProgressPayload) => boolean,
|
|
timeoutMs = 30_000,
|
|
): Promise<WorkspaceSetupProgressPayload> {
|
|
return new Promise((resolve, reject) => {
|
|
const timeout = setTimeout(() => {
|
|
unsubscribe();
|
|
reject(new Error(`Timed out waiting for workspace_setup_progress after ${timeoutMs}ms`));
|
|
}, timeoutMs);
|
|
|
|
const unsubscribe = client.subscribeRawMessages((message) => {
|
|
if (message.type !== "workspace_setup_progress") {
|
|
return;
|
|
}
|
|
if (!predicate(message.payload)) {
|
|
return;
|
|
}
|
|
clearTimeout(timeout);
|
|
unsubscribe();
|
|
resolve(message.payload);
|
|
});
|
|
});
|
|
}
|
|
|
|
/** Observe the browser's actual setup membership without requesting any output. */
|
|
export function observeSetupPanelTraffic(page: Page) {
|
|
const subscriptions: Array<{ workspaceId: string; subscriptionId: string }> = [];
|
|
const releases = new Set<string>();
|
|
const requests: string[] = [];
|
|
let legacySetupDemand = false;
|
|
const outputWorkspaces: string[] = [];
|
|
page.on("websocket", (socket) => {
|
|
socket.on("framesent", ({ payload }) => {
|
|
const frame = JSON.parse(String(payload));
|
|
if (frame.type !== "session") return;
|
|
if (frame.message?.type === "subscription.release.request")
|
|
releases.add(frame.message.subscriptionId);
|
|
if (frame.message?.type === "workspace.setup.subscribe.request")
|
|
requests.push(frame.message.workspaceId);
|
|
if (
|
|
frame.message?.type === "session.events.set_subscription.request" &&
|
|
frame.message.events.includes("workspace_setup_progress")
|
|
)
|
|
legacySetupDemand = true;
|
|
});
|
|
socket.on("framereceived", ({ payload }) => {
|
|
const frame = JSON.parse(String(payload));
|
|
if (frame.type !== "session") return;
|
|
if (frame.message?.type === "workspace.setup.subscribe.response")
|
|
subscriptions.push(frame.message.payload);
|
|
if (frame.message?.type === "workspace_setup_progress")
|
|
outputWorkspaces.push(frame.message.payload.workspaceId);
|
|
});
|
|
});
|
|
return {
|
|
async expectNoDemand() {
|
|
expect(requests).toEqual([]);
|
|
expect(legacySetupDemand).toBe(false);
|
|
expect(subscriptions).toEqual([]);
|
|
expect(outputWorkspaces).toEqual([]);
|
|
},
|
|
async expectSubscribed(workspaceId: string, count: number) {
|
|
await expect.poll(() => subscriptions.length).toBe(count);
|
|
expect(subscriptions[count - 1].workspaceId).toBe(workspaceId);
|
|
expect(requests).toEqual(Array(count).fill(workspaceId));
|
|
},
|
|
async expectReleased(index: number) {
|
|
await expect.poll(() => releases.has(subscriptions[index].subscriptionId)).toBe(true);
|
|
},
|
|
};
|
|
}
|
|
|
|
export function setupCommandOutput(detail: { commands: Array<{ log: string }> }): string {
|
|
return detail.commands.map((command) => command.log).join("\n");
|
|
}
|