mirror of
https://github.com/getpaseo/paseo.git
synced 2026-11-04 23:44:41 +00:00
Compare commits
134
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
5d1a2c10f8 | ||
|
|
a91bb4d406 | ||
|
|
15997a06d0 | ||
|
|
2d5b8eb1fd | ||
|
|
ac775a2904 | ||
|
|
0e7f452c2f | ||
|
|
cab5eedfe3 | ||
|
|
4407283a13 | ||
|
|
4f7813d3aa | ||
|
|
4991efddf8 | ||
|
|
fcbfb4f0d3 | ||
|
|
6221b0c8b7 | ||
|
|
bfbd4d5175 | ||
|
|
52b84b7835 | ||
|
|
d68271565a | ||
|
|
ce7b14a143 | ||
|
|
c7e137d4b4 | ||
|
|
d37262be56 | ||
|
|
0952ddbd4b | ||
|
|
67628b48fe | ||
|
|
eba5bdf810 | ||
|
|
66676d49e6 | ||
|
|
064243288b | ||
|
|
a880c9619d | ||
|
|
6740d41fab | ||
|
|
ca6b54fc2e | ||
|
|
4cd23a8f17 | ||
|
|
3084f32852 | ||
|
|
ce8196f6c5 | ||
|
|
40b95f70f4 | ||
|
|
93b9ac9ded | ||
|
|
eb8b5b8f94 | ||
|
|
51b9ad7695 | ||
|
|
1c4400194a | ||
|
|
1502b7f90f | ||
|
|
16f688b726 | ||
|
|
b507fc1986 | ||
|
|
e546497a21 | ||
|
|
b807c261ca | ||
|
|
85be2121b8 | ||
|
|
f4eeb8a538 | ||
|
|
e1b20384a1 | ||
|
|
fc710be1af | ||
|
|
66e1523f2f | ||
|
|
336e7d1b89 | ||
|
|
6f6712be62 | ||
|
|
a296bf3502 | ||
|
|
3857ed3365 | ||
|
|
736f7bf042 | ||
|
|
07a2e4accd | ||
|
|
1f64e68987 | ||
|
|
e06adf7a3e | ||
|
|
d2cc18b3a1 | ||
|
|
5062d5ee90 | ||
|
|
71dc9f44c9 | ||
|
|
7495c20f78 | ||
|
|
b92a34ab3d | ||
|
|
8018231a00 | ||
|
|
555818f5f7 | ||
|
|
27caf913f6 | ||
|
|
835bc49487 | ||
|
|
63302287fe | ||
|
|
3e3a707f5a | ||
|
|
d4ac64f335 | ||
|
|
70cb34927a | ||
|
|
b280ca5355 | ||
|
|
da8d58bfee | ||
|
|
7c2812dde6 | ||
|
|
b474beedce | ||
|
|
e2f0779379 | ||
|
|
a166a3317a | ||
|
|
efc64a5443 | ||
|
|
7efa14238d | ||
|
|
dbbcb103ba | ||
|
|
7f318bf7cf | ||
|
|
04fe4be40f | ||
|
|
2d75cc80b2 | ||
|
|
bfac132920 | ||
|
|
34f996b32a | ||
|
|
3e83f433da | ||
|
|
674530152e | ||
|
|
919e44b319 | ||
|
|
4fe44038e3 | ||
|
|
9b0542d127 | ||
|
|
8130147426 | ||
|
|
fa89738e3a | ||
|
|
14519bdb5b | ||
|
|
891e62309c | ||
|
|
6ae6308cfb | ||
|
|
ef77b823ae | ||
|
|
60f29a4350 | ||
|
|
8efb21f55c | ||
|
|
b2666a0aec | ||
|
|
82d5f6c580 | ||
|
|
da75aa7a4a | ||
|
|
86c60d367c | ||
|
|
5afa1a9f8e | ||
|
|
2d7adfc450 | ||
|
|
7d9741ef77 | ||
|
|
caf9300358 | ||
|
|
f0dfb9134c | ||
|
|
56c051503b | ||
|
|
85354fcb6a | ||
|
|
2dd931c8bd | ||
|
|
58eafd81e5 | ||
|
|
eab9ac3b03 | ||
|
|
e02fa9a5f8 | ||
|
|
b117e3fb0f | ||
|
|
2ac288f4d0 | ||
|
|
1008e9fffc | ||
|
|
74613e4bc3 | ||
|
|
0e5bcbd9f5 | ||
|
|
a7d9bb34fc | ||
|
|
fd65985e9d | ||
|
|
254166e7c1 | ||
|
|
9c5b47421a | ||
|
|
3b51b8ab2e | ||
|
|
9b3f1bfffd | ||
|
|
5ea639d9b2 | ||
|
|
9c926ed126 | ||
|
|
7b03f0ad21 | ||
|
|
0a549945b5 | ||
|
|
0be49c0620 | ||
|
|
186c132151 | ||
|
|
a4f696620b | ||
|
|
184ab66cde | ||
|
|
fbe24fcdb6 | ||
|
|
787edb1bf9 | ||
|
|
385c29b655 | ||
|
|
9477fe0c00 | ||
|
|
531370c4ce | ||
|
|
e299b21e94 | ||
|
|
1f79efcd62 | ||
|
|
e3682ba18c |
@@ -281,10 +281,10 @@ jobs:
|
|||||||
# otherwise has no server-test coverage. Scoped to the observer/watcher suites to
|
# otherwise has no server-test coverage. Scoped to the observer/watcher suites to
|
||||||
# bound runtime.
|
# bound runtime.
|
||||||
server-tests-macos:
|
server-tests-macos:
|
||||||
name: server-tests (macos-14, file observation)
|
name: server-tests (macos-latest, file observation)
|
||||||
needs: changes
|
needs: changes
|
||||||
if: ${{ !cancelled() && (needs.changes.outputs.full != 'false' || needs.changes.outputs.server != 'false') }}
|
if: ${{ !cancelled() && (needs.changes.outputs.full != 'false' || needs.changes.outputs.server != 'false') }}
|
||||||
runs-on: macos-14
|
runs-on: macos-latest
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
|||||||
@@ -100,10 +100,10 @@ jobs:
|
|||||||
fail-fast: false
|
fail-fast: false
|
||||||
matrix:
|
matrix:
|
||||||
include:
|
include:
|
||||||
- runner: macos-14
|
- runner: macos-latest
|
||||||
electron_arch: arm64
|
electron_arch: arm64
|
||||||
node_heap_mb: 4096
|
node_heap_mb: 4096
|
||||||
- runner: macos-15-intel
|
- runner: macos-26-intel
|
||||||
electron_arch: x64
|
electron_arch: x64
|
||||||
node_heap_mb: 8192
|
node_heap_mb: 8192
|
||||||
permissions:
|
permissions:
|
||||||
|
|||||||
@@ -101,7 +101,7 @@ jobs:
|
|||||||
run: nix build .#desktop -o result-desktop
|
run: nix build .#desktop -o result-desktop
|
||||||
|
|
||||||
build-desktop-darwin:
|
build-desktop-darwin:
|
||||||
runs-on: macos-14
|
runs-on: macos-latest
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
|||||||
@@ -406,10 +406,7 @@
|
|||||||
{
|
{
|
||||||
"files": [
|
"files": [
|
||||||
"packages/app/src/app/_layout.tsx",
|
"packages/app/src/app/_layout.tsx",
|
||||||
"packages/app/src/app/pair-scan.tsx",
|
|
||||||
"packages/app/src/components/adaptive-modal-sheet.tsx",
|
"packages/app/src/components/adaptive-modal-sheet.tsx",
|
||||||
"packages/app/src/components/add-host-method-modal.tsx",
|
|
||||||
"packages/app/src/components/add-host-modal.tsx",
|
|
||||||
"packages/app/src/components/agent-list.tsx",
|
"packages/app/src/components/agent-list.tsx",
|
||||||
"packages/app/src/components/agent-status-dot.tsx",
|
"packages/app/src/components/agent-status-dot.tsx",
|
||||||
"packages/app/src/components/attachment-lightbox.tsx",
|
"packages/app/src/components/attachment-lightbox.tsx",
|
||||||
@@ -428,7 +425,6 @@
|
|||||||
"packages/app/src/components/hosts/host-picker.tsx",
|
"packages/app/src/components/hosts/host-picker.tsx",
|
||||||
"packages/app/src/components/icons/paseo-logo.tsx",
|
"packages/app/src/components/icons/paseo-logo.tsx",
|
||||||
"packages/app/src/components/left-sidebar.tsx",
|
"packages/app/src/components/left-sidebar.tsx",
|
||||||
"packages/app/src/components/pair-link-modal.tsx",
|
|
||||||
"packages/app/src/components/plan-card.tsx",
|
"packages/app/src/components/plan-card.tsx",
|
||||||
"packages/app/src/components/provider-diagnostic-sheet.tsx",
|
"packages/app/src/components/provider-diagnostic-sheet.tsx",
|
||||||
"packages/app/src/components/question-form-card.tsx",
|
"packages/app/src/components/question-form-card.tsx",
|
||||||
@@ -543,14 +539,10 @@
|
|||||||
"packages/app/src/agent-skills/selection-sheet.tsx",
|
"packages/app/src/agent-skills/selection-sheet.tsx",
|
||||||
"packages/app/src/agent-stream/chat-outline/rail.web.tsx",
|
"packages/app/src/agent-stream/chat-outline/rail.web.tsx",
|
||||||
"packages/app/src/agent-stream/view.tsx",
|
"packages/app/src/agent-stream/view.tsx",
|
||||||
"packages/app/src/app/pair-scan.tsx",
|
|
||||||
"packages/app/src/changelog/internal/changelog-sheet.tsx",
|
"packages/app/src/changelog/internal/changelog-sheet.tsx",
|
||||||
"packages/app/src/command-center/command-center.tsx",
|
"packages/app/src/command-center/command-center.tsx",
|
||||||
"packages/app/src/components/adaptive-modal-sheet.tsx",
|
"packages/app/src/components/adaptive-modal-sheet.tsx",
|
||||||
"packages/app/src/components/add-host-method-modal.tsx",
|
|
||||||
"packages/app/src/components/add-host-modal.tsx",
|
|
||||||
"packages/app/src/components/add-project-flow.tsx",
|
"packages/app/src/components/add-project-flow.tsx",
|
||||||
"packages/app/src/components/add-remote-ssh-host-modal.tsx",
|
|
||||||
"packages/app/src/components/agent-list.tsx",
|
"packages/app/src/components/agent-list.tsx",
|
||||||
"packages/app/src/components/app-diagnostic-sheet.tsx",
|
"packages/app/src/components/app-diagnostic-sheet.tsx",
|
||||||
"packages/app/src/components/attachment-lightbox.tsx",
|
"packages/app/src/components/attachment-lightbox.tsx",
|
||||||
|
|||||||
+71
-8
@@ -1,19 +1,82 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
Not released yet. These changes are on `main` but not in 0.14.0; the next release entry includes them.
|
## 0.15.0 - 2026-11-03
|
||||||
|
|
||||||
Added:
|
Daemon restarts now keep terminal programs running. Interrupted agents can resume in their existing conversations when you turn on agent recovery.
|
||||||
|
|
||||||
- Copy gitignored files selected by `.worktreeinclude` into new worktrees before setup and agents, using the built-in `worktree-include` plugin ([#8100](https://github.com/getpaseo/paseo/pull/8100))
|
Mobile terminals have native rendering and draggable text-selection handles. Reconnecting restores up to 10,000 lines of terminal history.
|
||||||
- Let plugins choose worktree paths and creation options through `worktree.create.before`, with listing, archive, deletion, and recovery at custom locations; includes a sibling-directory placement example ([#8117](https://github.com/getpaseo/paseo/pull/8117))
|
|
||||||
|
|
||||||
Improved:
|
Worktree setup can copy ignored files and use plugin-defined locations before agents start.
|
||||||
|
|
||||||
- Added `server.addHook` with `subject.operation.position` names and the awaited `worktree.create.after` hook before setup and agents; deprecated the previous plugin hook registration methods without changing their behavior ([#8081](https://github.com/getpaseo/paseo/pull/8081))
|
### Added
|
||||||
|
|
||||||
Fixed:
|
- Insert known agent commands from replies into the Composer draft ([#8371](https://github.com/getpaseo/paseo/pull/8371))
|
||||||
|
- Reuse running OpenCode v2 services ([#7435](https://github.com/getpaseo/paseo/pull/7435) by [@mcowger](https://github.com/mcowger))
|
||||||
|
- Kept terminal programs running across daemon restarts, crashes and supported updates ([#7644](https://github.com/getpaseo/paseo/pull/7644), [#8155](https://github.com/getpaseo/paseo/pull/8155) by [@sebastianarena](https://github.com/sebastianarena))
|
||||||
|
- Added an opt-in setting to resume interrupted agents in their existing conversations after a host restart ([#8127](https://github.com/getpaseo/paseo/pull/8127), [#8619](https://github.com/getpaseo/paseo/pull/8619) by [@coolwindX](https://github.com/coolwindX), [@suntianc](https://github.com/suntianc))
|
||||||
|
- Added draggable terminal text-selection handles on iOS and Android ([#8348](https://github.com/getpaseo/paseo/pull/8348))
|
||||||
|
- Let phones and tablets rotate with the system orientation setting ([#8256](https://github.com/getpaseo/paseo/pull/8256) by [@magiclaw](https://github.com/magiclaw), [@yzim](https://github.com/yzim))
|
||||||
|
- Copy ignored files selected by `.worktreeinclude` into new worktrees before setup and agents start ([#8100](https://github.com/getpaseo/paseo/pull/8100) by [@cprecioso](https://github.com/cprecioso))
|
||||||
|
- Added daemon-wide support for `HTTP_PROXY`, `HTTPS_PROXY` and `NO_PROXY` ([#8177](https://github.com/getpaseo/paseo/pull/8177))
|
||||||
|
- Fetch usage only while displayed, with a host setting to disable usage checks entirely ([#8181](https://github.com/getpaseo/paseo/pull/8181))
|
||||||
|
|
||||||
- Keep an open agent on its current provider process when a session-open plugin reloads without changing env, tools, or MCP servers ([#8269](https://github.com/getpaseo/paseo/pull/8269))
|
### Improved
|
||||||
|
|
||||||
|
- Replaced mobile terminal text rendering to align CJK characters, emoji, styled text and the cursor with terminal columns ([#8336](https://github.com/getpaseo/paseo/pull/8336), [#8375](https://github.com/getpaseo/paseo/pull/8375))
|
||||||
|
- Restore the configured terminal scrollback on reconnect, up to 10,000 retained lines ([#8282](https://github.com/getpaseo/paseo/pull/8282) by [@DrakenKor](https://github.com/DrakenKor), [@lennartschoch](https://github.com/lennartschoch))
|
||||||
|
- Load paginated Codex histories when importing or reopening sessions ([#8171](https://github.com/getpaseo/paseo/pull/8171) by [@dundunHa](https://github.com/dundunHa), [@hr95savage](https://github.com/hr95savage))
|
||||||
|
- Stopped rereading and retaining an unused copy of Codex history when reopening a cached chat ([#8132](https://github.com/getpaseo/paseo/pull/8132))
|
||||||
|
- Split large daemon responses across relay frames instead of disconnecting at the frame limit ([#8302](https://github.com/getpaseo/paseo/pull/8302))
|
||||||
|
- Truncate oversized chat entries before sending them to the app, including large tool results and embedded data ([#8274](https://github.com/getpaseo/paseo/pull/8274))
|
||||||
|
- Show subagent activity in its own panel instead of duplicating it inside the parent’s tool card ([#8276](https://github.com/getpaseo/paseo/pull/8276))
|
||||||
|
- Show exact usage reset times alongside more precise countdowns ([#8162](https://github.com/getpaseo/paseo/pull/8162))
|
||||||
|
|
||||||
|
### Plugins
|
||||||
|
|
||||||
|
- Fixed discarded messages returning after rewinding plugin conversations ([#8368](https://github.com/getpaseo/paseo/pull/8368) by [@mcowger](https://github.com/mcowger), [@omercnet](https://github.com/omercnet))
|
||||||
|
- Reduced plugin downloads with smaller client bundles and a cache reused across reconnects and app launches ([#8040](https://github.com/getpaseo/paseo/pull/8040), [#8076](https://github.com/getpaseo/paseo/pull/8076) by [@luoph](https://github.com/luoph), [@RRD-dev](https://github.com/RRD-dev))
|
||||||
|
- Preserved plugin screens and local state during temporary host disconnections ([#8105](https://github.com/getpaseo/paseo/pull/8105) by [@luoph](https://github.com/luoph), [@RRD-dev](https://github.com/RRD-dev))
|
||||||
|
- Let plugins choose worktree locations and creation options through `worktree.create.before` ([#8117](https://github.com/getpaseo/paseo/pull/8117) by [@mcowger](https://github.com/mcowger))
|
||||||
|
- Added `server.addHook` with an awaited `worktree.create.after` hook before workspace setup and agents start ([#8081](https://github.com/getpaseo/paseo/pull/8081))
|
||||||
|
- Released redundant plugin streaming snapshots instead of retaining them for the session’s lifetime ([#7675](https://github.com/getpaseo/paseo/pull/7675) by [@suntianc](https://github.com/suntianc))
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
|
||||||
|
- Fixed rewinding Claude conversations to messages sent during an active turn ([#8372](https://github.com/getpaseo/paseo/pull/8372) by [@tieo](https://github.com/tieo))
|
||||||
|
- Fixed duplicate rows and missing replies when resuming Claude subagents after reopening a session ([#8408](https://github.com/getpaseo/paseo/pull/8408) by [@luoph](https://github.com/luoph), [@RRD-dev](https://github.com/RRD-dev))
|
||||||
|
- Fixed Codex agents created without a prompt failing after their runtime reopens ([#8393](https://github.com/getpaseo/paseo/pull/8393) by [@babo-jeonguk](https://github.com/babo-jeonguk))
|
||||||
|
- Fixed newly running agents appearing as finished immediately after creation ([#8396](https://github.com/getpaseo/paseo/pull/8396) by [@luoph](https://github.com/luoph))
|
||||||
|
- Fixed ACP startup exits waiting for a timeout instead of reporting the process error ([#8384](https://github.com/getpaseo/paseo/pull/8384) by [@Peanut-HZM](https://github.com/Peanut-HZM))
|
||||||
|
- Fixed skills missing from new ACP agents when commands arrive in multiple batches ([#8387](https://github.com/getpaseo/paseo/pull/8387) by [@Peanut-HZM](https://github.com/Peanut-HZM))
|
||||||
|
- Fixed sidebar titles and statuses stopping updates after directory subscriptions are released ([#8403](https://github.com/getpaseo/paseo/pull/8403) by [@ragokan](https://github.com/ragokan))
|
||||||
|
- Kept the open workspace visible in collapsed sidebar groups ([#8395](https://github.com/getpaseo/paseo/pull/8395) by [@0xroylee](https://github.com/0xroylee))
|
||||||
|
- Fixed relative chat links opening missing files instead of files in nested repositories ([#8361](https://github.com/getpaseo/paseo/pull/8361) by [@apple-ouyang](https://github.com/apple-ouyang))
|
||||||
|
- Accepted host:port and pasted URLs in the Direct connection Host field ([#8223](https://github.com/getpaseo/paseo/pull/8223) by [@DaydreamCoding](https://github.com/DaydreamCoding))
|
||||||
|
- Fixed terminal Ctrl+V paste over plain HTTP on non-Mac keyboards ([#8230](https://github.com/getpaseo/paseo/pull/8230) by [@DaydreamCoding](https://github.com/DaydreamCoding))
|
||||||
|
- Stopped failed history loads from repeatedly reopening the provider, with Retry available in the chat ([#8278](https://github.com/getpaseo/paseo/pull/8278))
|
||||||
|
- Fixed Claude settings files being discarded when Paseo adds its own launch settings ([#8148](https://github.com/getpaseo/paseo/pull/8148) by [@yayugu](https://github.com/yayugu))
|
||||||
|
- Fixed steering messages replacing a turn that was still starting and losing its original prompt ([#6192](https://github.com/getpaseo/paseo/pull/6192))
|
||||||
|
- Fixed Pi tool-result images missing during streaming and after reopening the chat ([#8280](https://github.com/getpaseo/paseo/pull/8280) by [@duyiliu](https://github.com/duyiliu))
|
||||||
|
- Fixed completed `edxeth/pi-subagents` children remaining marked as working ([#8176](https://github.com/getpaseo/paseo/pull/8176) by [@Zeno2019](https://github.com/Zeno2019))
|
||||||
|
- Fixed Claude background subagent status after reopening a conversation ([#6259](https://github.com/getpaseo/paseo/pull/6259))
|
||||||
|
- Fixed reused plugin subagents showing their previous completed status during new work ([#8080](https://github.com/getpaseo/paseo/pull/8080) by [@bccy](https://github.com/bccy))
|
||||||
|
- Fixed custom Codex providers with reserved names such as `ollama` ([#6954](https://github.com/getpaseo/paseo/pull/6954) by [@mr860819](https://github.com/mr860819))
|
||||||
|
- Fixed the MiniMax Code catalog command failing to select an executable ([#8201](https://github.com/getpaseo/paseo/pull/8201) by [@Peanut-HZM](https://github.com/Peanut-HZM))
|
||||||
|
- Fixed Android keeping the wrong layout after folding or unfolding while backgrounded ([#8285](https://github.com/getpaseo/paseo/pull/8285))
|
||||||
|
- Fixed Android workspace layouts and header fades retaining their old size after rotation ([#8349](https://github.com/getpaseo/paseo/pull/8349), [#8377](https://github.com/getpaseo/paseo/pull/8377))
|
||||||
|
- Fixed chat reconnecting and updating status being hidden behind the header on iOS and Android phones ([#8568](https://github.com/getpaseo/paseo/pull/8568))
|
||||||
|
- Fixed deleted agents leaving unclosable tabs in another window ([#8248](https://github.com/getpaseo/paseo/pull/8248) by [@loganmeyer](https://github.com/loganmeyer))
|
||||||
|
- Fixed transcript text retaining old theme colors after the theme changes while the window is hidden ([#8199](https://github.com/getpaseo/paseo/pull/8199) by [@Nurshot](https://github.com/Nurshot), [@dansabin](https://github.com/dansabin))
|
||||||
|
- Fixed web menus snapping back to their loading size after content arrives ([#8180](https://github.com/getpaseo/paseo/pull/8180) by [@babo-jeonguk](https://github.com/babo-jeonguk))
|
||||||
|
- Fixed split dividers drifting ahead of or behind the pointer while dragging ([#6011](https://github.com/getpaseo/paseo/pull/6011))
|
||||||
|
- Fixed delayed native filesystem watcher startup leaving Git updates unobserved ([#8107](https://github.com/getpaseo/paseo/pull/8107))
|
||||||
|
- Fixed bundled skill arguments being passed incorrectly to Codex and Pi ([#8252](https://github.com/getpaseo/paseo/pull/8252) by [@AspireOne](https://github.com/AspireOne))
|
||||||
|
|
||||||
|
### Notes
|
||||||
|
|
||||||
|
- The first upgrade from 0.14.0 still closes terminals; terminal preservation starts once the new daemon is installed, and Windows desktop app upgrades still close them
|
||||||
|
- Agent recovery is off by default; turn on **Resume agents after restart** in Host settings → Agents to send `Resume working.` or your own prompt
|
||||||
|
- Before downgrading to 0.14.0, restore a backed-up `config.json` or remove the saved agent-resume and usage-check settings
|
||||||
|
|
||||||
## 0.14.0 - 2026-10-29
|
## 0.14.0 - 2026-10-29
|
||||||
|
|
||||||
|
|||||||
+72
-9
@@ -1,19 +1,82 @@
|
|||||||
# 更新日志
|
# Changelog
|
||||||
|
|
||||||
尚未发布。以下变更已合入 `main`,但不包含在 0.14.0 中;下一个版本的条目会包含它们。
|
## 0.15.0 - 2026-11-03
|
||||||
|
|
||||||
新增:
|
daemon 重启后,终端中的程序继续运行。开启 Agent 恢复后,被中断的 Agent 会在原有会话中恢复工作。
|
||||||
|
|
||||||
- 在 setup 和 Agent 启动前,使用内置的 `worktree-include` 插件将 `.worktreeinclude` 选中的被 gitignore 忽略的文件复制到新工作树 ([#8100](https://github.com/getpaseo/paseo/pull/8100))
|
移动端终端采用原生渲染,并提供可拖动的文本选择手柄。重新连接时最多恢复 10,000 行终端历史。
|
||||||
- 插件可通过 `worktree.create.before` 选择工作树路径和创建选项,自定义位置的工作树支持列出、归档、删除和恢复;附带同级目录放置示例 ([#8117](https://github.com/getpaseo/paseo/pull/8117))
|
|
||||||
|
|
||||||
改进:
|
worktree 初始化支持复制被忽略的文件,并在 Agent 启动前使用插件指定的位置。
|
||||||
|
|
||||||
- 新增采用 `subject.operation.position` 命名的 `server.addHook` 和在 setup 及 Agent 之前等待的 `worktree.create.after` 钩子,弃用原有的插件钩子注册方法并保留原有行为 ([#8081](https://github.com/getpaseo/paseo/pull/8081))
|
### 新增
|
||||||
|
|
||||||
修复:
|
- 点击回复中的已知 Agent 命令,将其插入 Composer 草稿 ([#8371](https://github.com/getpaseo/paseo/pull/8371))
|
||||||
|
- 复用已运行的 OpenCode v2 服务 ([#7435](https://github.com/getpaseo/paseo/pull/7435),贡献者:[@mcowger](https://github.com/mcowger))
|
||||||
|
- 让终端中的程序在 daemon 重启、崩溃和支持的更新过程中继续运行 ([#7644](https://github.com/getpaseo/paseo/pull/7644), [#8155](https://github.com/getpaseo/paseo/pull/8155),贡献者:[@sebastianarena](https://github.com/sebastianarena))
|
||||||
|
- 新增可选设置,在主机重启后于原有会话中恢复被中断的 Agent ([#8127](https://github.com/getpaseo/paseo/pull/8127), [#8619](https://github.com/getpaseo/paseo/pull/8619),贡献者:[@coolwindX](https://github.com/coolwindX), [@suntianc](https://github.com/suntianc))
|
||||||
|
- 在 iOS 和 Android 终端中新增可拖动的文本选择手柄 ([#8348](https://github.com/getpaseo/paseo/pull/8348))
|
||||||
|
- 让手机和平板遵循系统屏幕旋转设置 ([#8256](https://github.com/getpaseo/paseo/pull/8256),贡献者:[@magiclaw](https://github.com/magiclaw), [@yzim](https://github.com/yzim))
|
||||||
|
- 通过 `.worktreeinclude` 选择要复制到新 worktree 的被忽略文件,在初始化和 Agent 启动前完成复制 ([#8100](https://github.com/getpaseo/paseo/pull/8100),贡献者:[@cprecioso](https://github.com/cprecioso))
|
||||||
|
- 让 daemon 的网络请求支持 `HTTP_PROXY`、`HTTPS_PROXY` 和 `NO_PROXY` ([#8177](https://github.com/getpaseo/paseo/pull/8177))
|
||||||
|
- 仅在显示用量时查询用量,并提供主机设置以完全关闭用量查询 ([#8181](https://github.com/getpaseo/paseo/pull/8181))
|
||||||
|
|
||||||
- 会话打开钩子重载后如果没有改变 env、工具或 MCP 服务器,就保持当前 provider 进程,不再为下一条消息关掉它 ([#8269](https://github.com/getpaseo/paseo/pull/8269))
|
### 改进
|
||||||
|
|
||||||
|
- 更换移动端终端文本渲染方式,让中日韩字符、表情符号、带样式文本和光标对齐终端列 ([#8336](https://github.com/getpaseo/paseo/pull/8336), [#8375](https://github.com/getpaseo/paseo/pull/8375))
|
||||||
|
- 重新连接时恢复设置指定的终端回滚历史,最多保留 10,000 行 ([#8282](https://github.com/getpaseo/paseo/pull/8282),贡献者:[@DrakenKor](https://github.com/DrakenKor), [@lennartschoch](https://github.com/lennartschoch))
|
||||||
|
- 导入或重新打开 Codex 会话时加载分页历史 ([#8171](https://github.com/getpaseo/paseo/pull/8171),贡献者:[@dundunHa](https://github.com/dundunHa), [@hr95savage](https://github.com/hr95savage))
|
||||||
|
- 重新打开已有缓存的 Codex 聊天时,不再重复读取并保留未使用的历史副本 ([#8132](https://github.com/getpaseo/paseo/pull/8132))
|
||||||
|
- 将 daemon 的大型响应拆分为多个 relay 帧,避免达到单帧限制时断开连接 ([#8302](https://github.com/getpaseo/paseo/pull/8302))
|
||||||
|
- 向应用发送聊天条目前截断超大内容,包括大型工具结果和内嵌数据 ([#8274](https://github.com/getpaseo/paseo/pull/8274))
|
||||||
|
- 在子 Agent 自己的面板中显示活动,不再在父 Agent 的工具卡片中重复显示 ([#8276](https://github.com/getpaseo/paseo/pull/8276))
|
||||||
|
- 在更精确的倒计时旁显示用量限制的具体重置时间 ([#8162](https://github.com/getpaseo/paseo/pull/8162))
|
||||||
|
|
||||||
|
### 插件
|
||||||
|
|
||||||
|
- 修复了插件会话回退后已丢弃的消息重新出现的问题 ([#8368](https://github.com/getpaseo/paseo/pull/8368),贡献者:[@mcowger](https://github.com/mcowger), [@omercnet](https://github.com/omercnet))
|
||||||
|
- 通过缩小客户端代码包并在重连和应用启动时复用缓存,减少插件下载量 ([#8040](https://github.com/getpaseo/paseo/pull/8040), [#8076](https://github.com/getpaseo/paseo/pull/8076),贡献者:[@luoph](https://github.com/luoph), [@RRD-dev](https://github.com/RRD-dev))
|
||||||
|
- 在主机暂时断开连接期间保留插件页面和本地状态 ([#8105](https://github.com/getpaseo/paseo/pull/8105),贡献者:[@luoph](https://github.com/luoph), [@RRD-dev](https://github.com/RRD-dev))
|
||||||
|
- 让插件通过 `worktree.create.before` 指定 worktree 的位置和创建选项 ([#8117](https://github.com/getpaseo/paseo/pull/8117),贡献者:[@mcowger](https://github.com/mcowger))
|
||||||
|
- 新增 `server.addHook`,并在工作区初始化和 Agent 启动前等待 `worktree.create.after` hook 完成 ([#8081](https://github.com/getpaseo/paseo/pull/8081))
|
||||||
|
- 释放多余的插件流式快照,不再将其保留到会话结束 ([#7675](https://github.com/getpaseo/paseo/pull/7675),贡献者:[@suntianc](https://github.com/suntianc))
|
||||||
|
|
||||||
|
### 修复
|
||||||
|
|
||||||
|
- 修复了无法将 Claude 会话回退到运行过程中发送的消息的问题 ([#8372](https://github.com/getpaseo/paseo/pull/8372),贡献者:[@tieo](https://github.com/tieo))
|
||||||
|
- 修复了重新打开会话后恢复 Claude 子 Agent 时出现重复行和回复缺失的问题 ([#8408](https://github.com/getpaseo/paseo/pull/8408),贡献者:[@luoph](https://github.com/luoph), [@RRD-dev](https://github.com/RRD-dev))
|
||||||
|
- 修复了未发送提示词的 Codex Agent 在运行时重新打开后无法使用的问题 ([#8393](https://github.com/getpaseo/paseo/pull/8393),贡献者:[@babo-jeonguk](https://github.com/babo-jeonguk))
|
||||||
|
- 修复了刚开始运行的 Agent 在创建后立即显示为已完成的问题 ([#8396](https://github.com/getpaseo/paseo/pull/8396),贡献者:[@luoph](https://github.com/luoph))
|
||||||
|
- 修复了 ACP 启动进程退出后仍等待超时而未及时报告错误的问题 ([#8384](https://github.com/getpaseo/paseo/pull/8384),贡献者:[@Peanut-HZM](https://github.com/Peanut-HZM))
|
||||||
|
- 修复了命令分批到达时新 ACP Agent 的技能列表不完整的问题 ([#8387](https://github.com/getpaseo/paseo/pull/8387),贡献者:[@Peanut-HZM](https://github.com/Peanut-HZM))
|
||||||
|
- 修复了目录订阅释放后侧栏标题和状态停止更新的问题 ([#8403](https://github.com/getpaseo/paseo/pull/8403),贡献者:[@ragokan](https://github.com/ragokan))
|
||||||
|
- 在折叠的侧栏分组中保持当前工作区可见 ([#8395](https://github.com/getpaseo/paseo/pull/8395),贡献者:[@0xroylee](https://github.com/0xroylee))
|
||||||
|
- 修复了聊天中的相对链接未打开嵌套仓库中的文件而指向不存在文件的问题 ([#8361](https://github.com/getpaseo/paseo/pull/8361),贡献者:[@apple-ouyang](https://github.com/apple-ouyang))
|
||||||
|
- 在直接连接的主机字段中支持 host:port 和粘贴的 URL ([#8223](https://github.com/getpaseo/paseo/pull/8223),贡献者:[@DaydreamCoding](https://github.com/DaydreamCoding))
|
||||||
|
- 修复了非 Mac 键盘通过普通 HTTP 访问网页终端时 Ctrl+V 无法粘贴的问题 ([#8230](https://github.com/getpaseo/paseo/pull/8230),贡献者:[@DaydreamCoding](https://github.com/DaydreamCoding))
|
||||||
|
- 停止在历史加载失败后反复重新打开 Provider,可在聊天中手动重试 ([#8278](https://github.com/getpaseo/paseo/pull/8278))
|
||||||
|
- 修复了 Paseo 添加自身启动设置时丢弃 Claude 设置文件的问题 ([#8148](https://github.com/getpaseo/paseo/pull/8148),贡献者:[@yayugu](https://github.com/yayugu))
|
||||||
|
- 修复了引导消息替换尚在启动的轮次并丢失原始提示词的问题 ([#6192](https://github.com/getpaseo/paseo/pull/6192))
|
||||||
|
- 修复了 Pi 工具结果中的图片在流式输出和重新打开聊天后缺失的问题 ([#8280](https://github.com/getpaseo/paseo/pull/8280),贡献者:[@duyiliu](https://github.com/duyiliu))
|
||||||
|
- 修复了 `edxeth/pi-subagents` 子 Agent 完成后仍显示为工作中的问题 ([#8176](https://github.com/getpaseo/paseo/pull/8176),贡献者:[@Zeno2019](https://github.com/Zeno2019))
|
||||||
|
- 修复了重新打开会话后的 Claude 后台子 Agent 状态 ([#6259](https://github.com/getpaseo/paseo/pull/6259))
|
||||||
|
- 修复了复用的插件子 Agent 开始新任务时仍显示上次已完成状态的问题 ([#8080](https://github.com/getpaseo/paseo/pull/8080),贡献者:[@bccy](https://github.com/bccy))
|
||||||
|
- 修复了使用 `ollama` 等保留名称的自定义 Codex Provider ([#6954](https://github.com/getpaseo/paseo/pull/6954),贡献者:[@mr860819](https://github.com/mr860819))
|
||||||
|
- 修复了 MiniMax Code 目录命令无法选定可执行文件的问题 ([#8201](https://github.com/getpaseo/paseo/pull/8201),贡献者:[@Peanut-HZM](https://github.com/Peanut-HZM))
|
||||||
|
- 修复了 Android 应用在后台折叠或展开后保留错误布局的问题 ([#8285](https://github.com/getpaseo/paseo/pull/8285))
|
||||||
|
- 修复了 Android 屏幕旋转后工作区布局和顶栏渐变保留旧尺寸的问题 ([#8349](https://github.com/getpaseo/paseo/pull/8349), [#8377](https://github.com/getpaseo/paseo/pull/8377))
|
||||||
|
- 修复了 iOS 和 Android 手机聊天中重新连接和更新状态被顶栏遮挡的问题 ([#8568](https://github.com/getpaseo/paseo/pull/8568))
|
||||||
|
- 修复了删除 Agent 后,另一个窗口留下无法关闭的标签页的问题 ([#8248](https://github.com/getpaseo/paseo/pull/8248),贡献者:[@loganmeyer](https://github.com/loganmeyer))
|
||||||
|
- 修复了窗口隐藏期间切换主题后,聊天文本保留旧主题颜色的问题 ([#8199](https://github.com/getpaseo/paseo/pull/8199),贡献者:[@Nurshot](https://github.com/Nurshot), [@dansabin](https://github.com/dansabin))
|
||||||
|
- 修复了网页菜单加载内容后跳回加载时尺寸的问题 ([#8180](https://github.com/getpaseo/paseo/pull/8180),贡献者:[@babo-jeonguk](https://github.com/babo-jeonguk))
|
||||||
|
- 修复了拖动分隔线时,分隔线偏离指针的问题 ([#6011](https://github.com/getpaseo/paseo/pull/6011))
|
||||||
|
- 修复了原生文件监听器启动延迟导致 Git 更新未被监听的问题 ([#8107](https://github.com/getpaseo/paseo/pull/8107))
|
||||||
|
- 修复了内置 skill 参数未正确传递给 Codex 和 Pi 的问题 ([#8252](https://github.com/getpaseo/paseo/pull/8252),贡献者:[@AspireOne](https://github.com/AspireOne))
|
||||||
|
|
||||||
|
### 说明
|
||||||
|
|
||||||
|
- 首次从 0.14.0 升级时仍会关闭终端;安装新 daemon 后才支持保留终端,Windows 桌面应用升级仍会关闭终端
|
||||||
|
- Agent 恢复默认关闭;在主机设置 → Agent 中开启 **重启后恢复智能体**,即可发送 `Resume working.` 或自定义提示词
|
||||||
|
- 降级到 0.14.0 前,请恢复备份的 `config.json`,或删除已保存的 Agent 恢复和用量查询设置
|
||||||
|
|
||||||
## 0.14.0 - 2026-10-29
|
## 0.14.0 - 2026-10-29
|
||||||
|
|
||||||
|
|||||||
@@ -34,6 +34,7 @@ At the start of non-trivial work, list `docs/` and skim anything relevant to the
|
|||||||
| [docs/hover.md](docs/hover.md) | Hover — the canonical pattern (plain View + onPointerEnter/Leave, separate inner Pressable) and the three ways agents break it |
|
| [docs/hover.md](docs/hover.md) | Hover — the canonical pattern (plain View + onPointerEnter/Leave, separate inner Pressable) and the three ways agents break it |
|
||||||
| [docs/unistyles.md](docs/unistyles.md) | Unistyles gotchas — `useUnistyles()` is forbidden, alternatives in order |
|
| [docs/unistyles.md](docs/unistyles.md) | Unistyles gotchas — `useUnistyles()` is forbidden, alternatives in order |
|
||||||
| [docs/floating-panels.md](docs/floating-panels.md) | Anchored popovers — Portal/Modal escape for Android, lifecycle gates, keyboard-shared-value, status-bar offset, the flash |
|
| [docs/floating-panels.md](docs/floating-panels.md) | Anchored popovers — Portal/Modal escape for Android, lifecycle gates, keyboard-shared-value, status-bar offset, the flash |
|
||||||
|
| [docs/keyboard-shortcuts.md](docs/keyboard-shortcuts.md) | The binding table, per-platform key sources, badges vs routing, iOS `UIKeyCommand` limits |
|
||||||
| [docs/menus.md](docs/menus.md) | The menu engine — popover vs sheet, submenu pages, hover intent, when a decision earns a submenu |
|
| [docs/menus.md](docs/menus.md) | The menu engine — popover vs sheet, submenu pages, hover intent, when a decision earns a submenu |
|
||||||
| [docs/expo-router.md](docs/expo-router.md) | Expo Router route ownership, startup restore, and native blank-screen gotchas |
|
| [docs/expo-router.md](docs/expo-router.md) | Expo Router route ownership, startup restore, and native blank-screen gotchas |
|
||||||
| [docs/notifications.md](docs/notifications.md) | Notification tap ownership, native replay and acknowledgement, startup handoff, and payload QA |
|
| [docs/notifications.md](docs/notifications.md) | Notification tap ownership, native replay and acknowledgement, startup handoff, and payload QA |
|
||||||
@@ -52,7 +53,9 @@ At the start of non-trivial work, list `docs/` and skim anything relevant to the
|
|||||||
| [docs/connected-hosts.md](docs/connected-hosts.md) | Daemon-owned host registrations, routed SDK scopes, identity and authority boundaries |
|
| [docs/connected-hosts.md](docs/connected-hosts.md) | Daemon-owned host registrations, routed SDK scopes, identity and authority boundaries |
|
||||||
| [docs/permissions.md](docs/permissions.md) | Semantic daemon permissions, principals, credentials, pairing invitations, and Hub authority |
|
| [docs/permissions.md](docs/permissions.md) | Semantic daemon permissions, principals, credentials, pairing invitations, and Hub authority |
|
||||||
| [docs/terminal-performance.md](docs/terminal-performance.md) | Terminal latency pipeline, coalescing/backpressure invariants, benchmark + perf spec usage |
|
| [docs/terminal-performance.md](docs/terminal-performance.md) | Terminal latency pipeline, coalescing/backpressure invariants, benchmark + perf spec usage |
|
||||||
|
| [docs/terminal-rendering.md](docs/terminal-rendering.md) | Native terminal view: xterm owns the grid, cluster placement, emoji widths, mixed-direction limits, render regression |
|
||||||
| [docs/agent-stream-performance.md](docs/agent-stream-performance.md) | Assistant text pipeline — coalescing window, paced reveal, why arrival lumps are smoothed at render |
|
| [docs/agent-stream-performance.md](docs/agent-stream-performance.md) | Assistant text pipeline — coalescing window, paced reveal, why arrival lumps are smoothed at render |
|
||||||
|
| [docs/agent-stream-disclosure.md](docs/agent-stream-disclosure.md) | Expand/collapse in the chat timeline — hold contract, native anchor sequence, frame spacing, render-window cost |
|
||||||
| [docs/markdown-renderer.md](docs/markdown-renderer.md) | Shared Markdown engine, native selection, links, images and library constraints |
|
| [docs/markdown-renderer.md](docs/markdown-renderer.md) | Shared Markdown engine, native selection, links, images and library constraints |
|
||||||
| [docs/native-text-selection.md](docs/native-text-selection.md) | Native diagram grouping, selection boundaries and leading inline image limitations |
|
| [docs/native-text-selection.md](docs/native-text-selection.md) | Native diagram grouping, selection boundaries and leading inline image limitations |
|
||||||
| [docs/file-observation.md](docs/file-observation.md) | Recursive watcher ownership, Linux constraints, teardown invariants, and Parcel comparison |
|
| [docs/file-observation.md](docs/file-observation.md) | Recursive watcher ownership, Linux constraints, teardown invariants, and Parcel comparison |
|
||||||
|
|||||||
+34
-14
@@ -14,9 +14,10 @@ Each live agent in `AgentManager` carries a `lastStatus` of `initializing`, `idl
|
|||||||
|
|
||||||
## Daemon restart recovery
|
## Daemon restart recovery
|
||||||
|
|
||||||
Hosts resume interrupted agents by default after graceful shutdown or a crash. The daemon
|
Restart recovery is off by default. Enable `agents.resumeOnStartup` in host config or
|
||||||
reopens the saved provider conversation and settings, then sends `Resume working.`. Change
|
Host settings → Agents to resume interrupted agents after graceful shutdown or a crash. The daemon
|
||||||
`agents.resumePrompt` or disable `agents.resumeOnStartup` in host config or Host settings → Agents.
|
reopens the saved provider conversation and settings, then sends `Resume working.`. Customize
|
||||||
|
the prompt with `agents.resumePrompt` or the same settings page.
|
||||||
Disabling recovery consumes pending intent; enabling it later does not revive old work.
|
Disabling recovery consumes pending intent; enabling it later does not revive old work.
|
||||||
|
|
||||||
Only agents recorded as running qualify. Idle and initializing agents stay inactive. Archived
|
Only agents recorded as running qualify. Idle and initializing agents stay inactive. Archived
|
||||||
@@ -182,23 +183,42 @@ Some providers can create their own child sessions inside one provider runtime.
|
|||||||
|
|
||||||
The provider still owns the underlying runtime. Paseo keeps an agent record so the child can be opened, tracked, archived, and cascaded with the parent, but prompts and history hydration route through the provider adapter for that native child handle.
|
The provider still owns the underlying runtime. Paseo keeps an agent record so the child can be opened, tracked, archived, and cascaded with the parent, but prompts and history hydration route through the provider adapter for that native child handle.
|
||||||
|
|
||||||
## Background workspaces
|
## Background visibility
|
||||||
|
|
||||||
`workspace.background` controls discovery only. Background workspaces contain ordinary durable
|
An agent is effectively background when it or its workspace is background:
|
||||||
agents and terminals: provider history, plugin hooks, parentage, archive, and restart recovery
|
`agent.background || workspace.background`. Background controls discovery only. Background agents
|
||||||
keep their normal behavior. Visibility is creation-only; selecting an existing workspace cannot
|
and the agents in background workspaces are ordinary durable agents: provider history, plugin
|
||||||
change it. New workspaces default to false, inherit the caller workspace's value when an agent
|
hooks, parentage, finish notifications to a caller, archive, and restart recovery keep their
|
||||||
creates one without an override, and accept explicit true or false.
|
normal behavior. Both flags are fixed at creation.
|
||||||
|
|
||||||
The daemon derives agent discovery from workspace ownership. Default workspace and agent lists,
|
- **Agent.** `create_agent_request.background` marks the agent. Use it for helpers the user does
|
||||||
including History requests, exclude background work; `filter.includeBackground` includes it.
|
not watch, such as a plugin's classifier in the user's open workspace. A background agent never
|
||||||
Exact-ID operations bypass discovery filtering. The app replicates both kinds and filters only
|
raises attention, adds nothing to its workspace's status bucket or Last prompt time, and stays
|
||||||
its sidebar with **Show background**, so direct navigation and restored tabs remain available.
|
out of tabs, the parent's subagent track and agent lists in the app. A tab opened by id still
|
||||||
|
works.
|
||||||
|
- **Workspace.** `workspace.background` hides the workspace from the sidebar unless **Show
|
||||||
|
background** is on.
|
||||||
|
- **Inheritance.** When `background` is omitted, an agent created by a caller agent takes the
|
||||||
|
caller's own `background`. A new workspace takes the caller's effective background. A request
|
||||||
|
that creates its workspace applies `background` to both the agent and the workspace. Explicit
|
||||||
|
true or false always wins.
|
||||||
|
|
||||||
|
`AgentDirectory` (`packages/server/src/server/agent/directory.ts`) owns visibility for lists.
|
||||||
|
Default workspace and agent lists, including History requests, exclude background work;
|
||||||
|
`includeBackground` includes it. Exact-ID operations bypass discovery filtering. The app
|
||||||
|
replicates inclusively and filters at each surface.
|
||||||
|
|
||||||
|
Sources without the `background_agents` hello capability get workspace-only visibility on
|
||||||
|
inclusive reads and subscriptions: agents in background workspaces, but no agent-level background
|
||||||
|
agents. Older apps replicate inclusively and auto-open a tab for every root agent, so a classifier
|
||||||
|
run would otherwise open a tab each turn. That visibility has its own directory sync generation.
|
||||||
|
|
||||||
Sequenced directories keep complete canonical collections. A filtered read must never replace
|
Sequenced directories keep complete canonical collections. A filtered read must never replace
|
||||||
those collections with its subset. Inclusive and default observations have distinct cursor
|
those collections with its subset. Inclusive and default observations have distinct cursor
|
||||||
scopes, so changing scope requires a fresh snapshot rather than reusing an incomplete cache.
|
scopes, so changing scope requires a fresh snapshot rather than reusing an incomplete cache.
|
||||||
Clients gate creation and inclusive discovery on `features.backgroundWorkspaces`.
|
Clients gate background workspaces and inclusive discovery on `features.backgroundWorkspaces`.
|
||||||
|
They gate a background agent placed in an existing workspace or under a caller on
|
||||||
|
`features.backgroundAgents`.
|
||||||
|
|
||||||
### Private daemon helpers
|
### Private daemon helpers
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,163 @@
|
|||||||
|
# Agent stream disclosures
|
||||||
|
|
||||||
|
Expanding or collapsing something in the chat timeline (a turn's summary line, a tool-call group,
|
||||||
|
a tool call's inline details, a todo card) keeps the tapped trigger at the same screen y in the
|
||||||
|
first painted frame. No animation.
|
||||||
|
|
||||||
|
## The contract
|
||||||
|
|
||||||
|
A disclosure component knows nothing about the list. It wraps its state change:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
const hold = useDisclosureHold();
|
||||||
|
const handleToggle = () => hold(() => setExpanded((value) => !value));
|
||||||
|
```
|
||||||
|
|
||||||
|
`view.tsx` wraps every timeline row in `DisclosureRow`, which routes `hold` to the strategy's
|
||||||
|
`holdRow(rowId, apply)` (`packages/app/src/agent-stream/disclosure.tsx`). Outside a timeline row,
|
||||||
|
`apply` runs as is. The strategy owns when `apply` runs and how the row keeps its place.
|
||||||
|
|
||||||
|
Following output:
|
||||||
|
|
||||||
|
- A hold always detaches the bottom anchor controller (`holdForDisclosure`).
|
||||||
|
- When the hold ends, the controller re-sticks only if the list sits at its end and no user scroll
|
||||||
|
owns the viewport (`releaseDisclosure({ isAtEnd })`). Expanding at the bottom therefore leaves
|
||||||
|
the list detached with the scroll-to-bottom pill showing; collapsing back to the end resumes
|
||||||
|
following.
|
||||||
|
- Scroll events during the hold never re-stick: the correction is a programmatic scroll that
|
||||||
|
would otherwise read as "back at the bottom".
|
||||||
|
|
||||||
|
The trigger can only stay put when the list has scroll room for the change. When the loaded
|
||||||
|
content fits the viewport, or a collapse at the end would need an offset past the end, the list
|
||||||
|
ends at its end and the trigger moves by the difference.
|
||||||
|
|
||||||
|
## Web
|
||||||
|
|
||||||
|
`holdRow` pins the row in the reading anchor and runs `apply`; the next reading reconcile restores
|
||||||
|
the row's top after layout, before paint (`strategy-web.tsx`).
|
||||||
|
|
||||||
|
## Native
|
||||||
|
|
||||||
|
On compact layouts, tool calls and tool-call groups open a sheet instead of expanding, so they do
|
||||||
|
not hold. Summary lines and todo cards expand inline.
|
||||||
|
|
||||||
|
The timeline is a LegendList in forward order: one `data` array of history rows followed by the
|
||||||
|
live head, oldest first (`strategy-native.tsx`). LegendList keeps a row in place across a size
|
||||||
|
change in the commit that makes it, so a hold needs no anchor neighbour, native child index or
|
||||||
|
render window stretch. The inverted FlatList it replaced needed all three, and three commits per
|
||||||
|
toggle; its applied commit took up to 3.5 s of JS on a long turn.
|
||||||
|
|
||||||
|
### Who owns the offset
|
||||||
|
|
||||||
|
One owner keeps the scroll offset at any moment:
|
||||||
|
|
||||||
|
| State | Owner |
|
||||||
|
| ---------------------- | ----------------------------------------------------------------------------------------- |
|
||||||
|
| Before rows are placed | LegendList's initial scroll to the end. It keeps the rows hidden until they are measured. |
|
||||||
|
| Following the end | The end pin (`native-end-pin.tsx`). |
|
||||||
|
| Disclosure hold | LegendList's `maintainVisibleContentPosition`, restoring only the held row. |
|
||||||
|
| User scroll | The finger. The controller detaches at drag start. |
|
||||||
|
| Detached | LegendList's `maintainVisibleContentPosition` on the first visible row. |
|
||||||
|
| Keyboard motion | Nobody. The keyboard translates the list with the composer and leaves the offset alone. |
|
||||||
|
|
||||||
|
The end pin is a zero-height view at the bottom of the content and the content's first native
|
||||||
|
child, with React Native's `maintainVisibleContentPosition` set to `{ minIndexForVisible: 0 }`. The
|
||||||
|
native correction runs on the UI thread around each mount, so a row that grows or lands at the end
|
||||||
|
scrolls in the frame it lays out. The controller scrolls only for a viewport resize (the composer
|
||||||
|
growing or shrinking) and an explicit jump, both through the native `scrollToEnd`.
|
||||||
|
|
||||||
|
Do not use LegendList's `maintainScrollAtEnd` instead. It scrolls from JS after the mount to the end
|
||||||
|
its JS sizes predict: growth paints below the viewport for a frame, and the scroll lands short of
|
||||||
|
the native end, which the controller reads as the user scrolling away.
|
||||||
|
|
||||||
|
The keyboard never changes the list's size, padding or offset. `KeyboardTranslateView` moves the list
|
||||||
|
and the composer together on the UI thread, and the composer viewport clips the top of the list
|
||||||
|
while the keyboard is open. Do not add a keyboard-sized inset to keep that content reachable: it can
|
||||||
|
only commit after the motion, and while detached or holding nothing corrects for it, so every row
|
||||||
|
jumps by the keyboard height after the keyboard settles.
|
||||||
|
|
||||||
|
### The hold
|
||||||
|
|
||||||
|
`holdRow(rowId, apply)` runs in the toggle's event:
|
||||||
|
|
||||||
|
1. Mark the row held and detach the controller (`holdForDisclosure`). The pin goes away and
|
||||||
|
LegendList's `maintainVisibleContentPosition` takes over, restoring only the held row
|
||||||
|
(`shouldRestorePosition`). Upstream LegendList anchors only rows from the first fully visible
|
||||||
|
one down, and a size change with no data change keeps the first row in view whatever
|
||||||
|
`shouldRestorePosition` says. A row cut off at the top would then let the row below it hold
|
||||||
|
instead, moving the trigger by the row's size change. The LegendList patch counts rows cut off
|
||||||
|
at the top as in view and applies `shouldRestorePosition` to size changes too.
|
||||||
|
2. Run `apply`.
|
||||||
|
3. Call the row's `useSyncLayout` trigger. The toggle changes the row from its own state, so
|
||||||
|
LegendList's container does not re-render and would learn the new height from `onLayout` a task
|
||||||
|
later, after the change painted. The trigger puts the measurement and the corrected positions
|
||||||
|
in the toggle's own commit.
|
||||||
|
|
||||||
|
The hold ends two frames after the last item size change, since the list measures the toggled row
|
||||||
|
and any rows it inserted over several frames (`native-disclosure-hold.ts`). The controller then
|
||||||
|
re-sticks only if the list is within 1 px of its end, the same distance web resumes from.
|
||||||
|
|
||||||
|
### User scroll
|
||||||
|
|
||||||
|
The controller detaches at `onScrollBeginDrag`, so lines that stream in during a drag grow below
|
||||||
|
the rows under the finger. The detach reaches native a JS round trip after the drag begins, so for
|
||||||
|
those frames the pin is still mounted. The scroll view subclasses skip the pin's correction while
|
||||||
|
the user drags (see [scroll view corrections](#scroll-view-corrections)). They skip only the pin's:
|
||||||
|
in the detached state LegendList uses the same native correction, and a history page that lands
|
||||||
|
mid-drag needs it. They key on the drag, not the touch, so a tap or long press while following
|
||||||
|
keeps following.
|
||||||
|
|
||||||
|
Following resumes only for a gesture that ends within 1 px of the end, either when the finger lifts
|
||||||
|
or when momentum stops. A release past the end counts: iOS bounces back to the end, and lines that
|
||||||
|
land during the bounce must keep scrolling in. A release anywhere short of the end stays detached
|
||||||
|
with the scroll-to-bottom pill, so the rows the user let go of never move.
|
||||||
|
|
||||||
|
### Draw distance
|
||||||
|
|
||||||
|
`drawDistance` is 2000 px on each side of the viewport. A fling over rows that were never measured
|
||||||
|
blanks the viewport until LegendList renders and measures them. Twelve flings over a chat with a
|
||||||
|
15,000 px turn expanded, Android emulator, dev build:
|
||||||
|
|
||||||
|
| List | Blank viewport | Janky frames | p50 / p90 / p99 |
|
||||||
|
| ----------------------------- | -------------------------- | ------------ | ---------------- |
|
||||||
|
| Inverted FlatList | 1.3 to 1.7 s over 5 flings | 10.8% | 27 / 48 / 109 ms |
|
||||||
|
| LegendList, drawDistance 500 | 1.0 to 1.5 s per fling | | |
|
||||||
|
| LegendList, drawDistance 2000 | none | 1.7% | 24 / 32 / 48 ms |
|
||||||
|
|
||||||
|
With every turn collapsed, flinging from a cold open into history did not blank at any value from
|
||||||
|
500 to 2000, and jank followed host load (19 to 40 on 16 cores) rather than draw distance. Measure
|
||||||
|
1000 and 1500 on the expanded chat, on a host under load 10, before lowering it.
|
||||||
|
|
||||||
|
### LegendList patch
|
||||||
|
|
||||||
|
`patches/@legendapp+list+3.7.1.patch` carries ten changes for the timeline. Its header lists
|
||||||
|
them by purpose, and
|
||||||
|
[legend-list #593](https://github.com/LegendApp/legend-list/issues/593) reports each upstream.
|
||||||
|
Drop a hunk when the installed LegendList ships its fix.
|
||||||
|
|
||||||
|
### Scroll view corrections
|
||||||
|
|
||||||
|
`modules/paseo-scroll` replaces React Native's scroll view on both platforms with a subclass:
|
||||||
|
Android's `PaseoScrollView` and iOS's `PaseoScrollViewComponentView`.
|
||||||
|
`VisibleContentPositionClampTest` covers Android; iOS has no native test harness.
|
||||||
|
|
||||||
|
**Content clamp.** A mount that shrinks the content while `maintainVisibleContentPosition` is set
|
||||||
|
applies the shrink twice on both platforms: the scroll view clamps its offset to the new end during
|
||||||
|
the mount, and React Native then adds the anchor's movement to the clamped offset
|
||||||
|
([RN #58578](https://github.com/react/react-native/issues/58578), fix in
|
||||||
|
[PR #58695](https://github.com/react/react-native/pull/58695)). A turn that folds while the list
|
||||||
|
follows its end lands above the end. Android defers the clamp to the pre-draw pass, and iOS restores
|
||||||
|
the pre-mount offset for the adjustment and clamps after it.
|
||||||
|
|
||||||
|
**Removed anchor (iOS).** A hold removes the end pin in the same mount that opens the tapped
|
||||||
|
disclosure, and React Native 0.86 on iOS moves the offset by the removed view's frame. The iOS
|
||||||
|
subclass keeps the offset. Android keeps a removed view's last frame, so it keeps the offset already.
|
||||||
|
React Native 0.88 skips the adjustment for a removed anchor
|
||||||
|
([PR #57294](https://github.com/react/react-native/pull/57294)).
|
||||||
|
|
||||||
|
**End pin during a drag.** Both subclasses recognize the pin by its native ID, `paseo-end-pin`,
|
||||||
|
and skip its correction while the user drags ([user scroll](#user-scroll)). This one has no React
|
||||||
|
Native counterpart; it stays while the timeline uses the pin.
|
||||||
|
|
||||||
|
Remove the content clamp and removed-anchor overrides once the installed React Native includes
|
||||||
|
their fixes.
|
||||||
@@ -34,10 +34,10 @@ So arrival sets a _target_ and the reveal rate is derived from the backlog inste
|
|||||||
- **First sight of a text is revealed whole.** Only growth is paced. This is what makes history hydration, timeline replay, a virtualized row remounting on scroll, and an already-finished message all render complete on first paint without a special case for each.
|
- **First sight of a text is revealed whole.** Only growth is paced. This is what makes history hydration, timeline replay, a virtualized row remounting on scroll, and an already-finished message all render complete on first paint without a special case for each.
|
||||||
- **Leaving `phase: "streaming"` snaps the reveal.** A completed turn must never be left holding characters. `layoutStream` sets the phase, so anything outside the live head with an active turn is already complete.
|
- **Leaving `phase: "streaming"` snaps the reveal.** A completed turn must never be left holding characters. `layoutStream` sets the phase, so anything outside the live head with an active turn is already complete.
|
||||||
- **The reducer queue commits on a frame, with a timer as the ceiling.** A frame callback never fires in a hidden tab, so a timer races it and wins when nothing is painting — the store has to keep advancing either way.
|
- **The reducer queue commits on a frame, with a timer as the ceiling.** A frame callback never fires in a hidden tab, so a timer races it and wins when nothing is painting — the store has to keep advancing either way.
|
||||||
- **A history row re-renders only when its item or layout item identity changes.** The inverted
|
- **A history row re-renders only when its item or layout item identity changes.** Every
|
||||||
FlatList hands every mounted cell a new `index` and `ref` whenever a row is prepended, so without a
|
coalesced tick hands the list a new layout. Without a memo boundary each tick re-rendered every
|
||||||
memo boundary each coalesced tick re-rendered every mounted row (about 50 on a phone, 100–250 ms of
|
mounted row (measured on the inverted FlatList native used before LegendList: about 50 rows on a
|
||||||
JS per tick). `layoutStream` keeps a layout item's identity when nothing about it changed,
|
phone, 100–250 ms of JS per tick). `layoutStream` keeps a layout item's identity when nothing about it changed,
|
||||||
`useRevisedHistoryRows` hands a fresh item identity to rows whose tool-call group, expanded state,
|
`useRevisedHistoryRows` hands a fresh item identity to rows whose tool-call group, expanded state,
|
||||||
or breakpoint changed, and `StreamRow` memoizes on both. Every viewport runs its history
|
or breakpoint changed, and `StreamRow` memoizes on both. Every viewport runs its history
|
||||||
through that hook; the web viewport once skipped it and history hosts of a live tool group went
|
through that hook; the web viewport once skipped it and history hosts of a live tool group went
|
||||||
|
|||||||
+23
-7
@@ -61,6 +61,18 @@ Gradle auto-fetches the platform/build-tools it needs once licenses are accepted
|
|||||||
|
|
||||||
## Local build + install
|
## Local build + install
|
||||||
|
|
||||||
|
The `react-native-svg@15.15.4` patch prevents header fades retaining their old painted size after
|
||||||
|
rotation. Rebuild native Android after changing it; Metro reloads cannot update this code. Keep the
|
||||||
|
resize hunks until upstream invalidates descendant geometry on canvas resize. Its instrumentation
|
||||||
|
regression renders real gradient pixels across growing and shrinking layouts, including a nested
|
||||||
|
group. From `packages/app/android`, run it on your selected emulator:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
ANDROID_SERIAL=emulator-5562 ./gradlew :react-native-svg:connectedDebugAndroidTest \
|
||||||
|
-Pandroid.testInstrumentationRunnerArguments.class=com.horcrux.svg.SvgResizeTest \
|
||||||
|
--no-daemon --max-workers=2 -Dorg.gradle.parallel=false
|
||||||
|
```
|
||||||
|
|
||||||
The locked `expo-modules-core@57.0.23` needs the patch installed by `npm install`.
|
The locked `expo-modules-core@57.0.23` needs the patch installed by `npm install`.
|
||||||
It backports
|
It backports
|
||||||
[Expo's Activity-result launcher fix](https://github.com/expo/expo/pull/49634): changing
|
[Expo's Activity-result launcher fix](https://github.com/expo/expo/pull/49634): changing
|
||||||
@@ -162,14 +174,18 @@ REACT_NATIVE_PACKAGER_HOSTNAME=localhost \
|
|||||||
|
|
||||||
This is the Android counterpart of the iOS local-simulator flow in [development.md](development.md): on iOS the simulator shares the Mac's loopback so `localhost:<port>` works directly; on Android you need `10.0.2.2` or `adb reverse`.
|
This is the Android counterpart of the iOS local-simulator flow in [development.md](development.md): on iOS the simulator shares the Mac's loopback so `localhost:<port>` works directly; on Android you need `10.0.2.2` or `adb reverse`.
|
||||||
|
|
||||||
## Inverted timeline selection
|
## Scroll view corrections
|
||||||
|
|
||||||
Android focus and selection visibility requests must not reposition inverted timelines. The
|
`modules/paseo-scroll` replaces React Native's vertical scroll view with `PaseoScrollView`, which
|
||||||
`modules/paseo-scroll` package keeps React Native's scroll manager interface and returns zero for
|
keeps React Native's scroll manager interface and corrects `maintainVisibleContentPosition` for the
|
||||||
child-reveal scroll calculations when the view's transform matrix inverts the vertical axis. React
|
chat timeline. [agent-stream-disclosure.md](agent-stream-disclosure.md#scroll-view-corrections)
|
||||||
Native's Android list uses `scale: -1`, which decomposes into a 180-degree rotation with positive
|
lists the corrections and the React Native issues they work around. Its instrumentation test,
|
||||||
`scaleY`; checking the scale property alone misses it. Dragging and explicit scroll
|
`VisibleContentPositionClampTest`, mounts through React Native's own mounting manager:
|
||||||
commands still work; non-inverted scroll views keep Android's default behavior.
|
|
||||||
|
```bash
|
||||||
|
cd packages/app/android
|
||||||
|
./gradlew :paseo-scroll:connectedDebugAndroidTest --no-daemon --max-workers=2 -Dorg.gradle.parallel=false
|
||||||
|
```
|
||||||
|
|
||||||
Register this package before React Native's core package through its Expo config plugin. Normal
|
Register this package before React Native's core package through its Expo config plugin. Normal
|
||||||
Android builds use the prebuilt `react-android` library, so patching Java under `node_modules` does
|
Android builds use the prebuilt `react-android` library, so patching Java under `node_modules` does
|
||||||
|
|||||||
@@ -493,6 +493,16 @@ The supervisor alone publishes its ready worker's endpoint in `paseo.pid`, clear
|
|||||||
|
|
||||||
Worker restart retains supervisor arguments/environment and rereads the configuration file. Updating a package and observing its new worker version do not refresh the running supervisor code; the launcher owns full-process replacement. See [CLI lifecycle contracts](../public-docs/cli.md#daemon-management).
|
Worker restart retains supervisor arguments/environment and rereads the configuration file. Updating a package and observing its new worker version do not refresh the running supervisor code; the launcher owns full-process replacement. See [CLI lifecycle contracts](../public-docs/cli.md#daemon-management).
|
||||||
|
|
||||||
|
## Outbound networking
|
||||||
|
|
||||||
|
The daemon and its plugin processes honor `HTTPS_PROXY`, `HTTP_PROXY`, and `NO_PROXY`
|
||||||
|
(including lowercase forms, which take precedence). Fetch and relay, Hub, and connected-host WebSockets
|
||||||
|
share this policy. Loopback (`localhost`, `127.0.0.1`, `::1`) always goes direct.
|
||||||
|
A proxy without a scheme uses HTTP. Invalid values and unsupported proxy schemes
|
||||||
|
are treated as unset, with one warning naming the variable in `daemon.log`.
|
||||||
|
Agent and terminal environments are unchanged. System proxy settings and SOCKS-only
|
||||||
|
`ALL_PROXY` configurations are not supported.
|
||||||
|
|
||||||
## Deployment models
|
## Deployment models
|
||||||
|
|
||||||
1. **Local daemon** (default): `paseo daemon start` on `127.0.0.1:6767`
|
1. **Local daemon** (default): `paseo daemon start` on `127.0.0.1:6767`
|
||||||
|
|||||||
@@ -74,7 +74,10 @@ registrations remain inspectable; a changed destination requires explicit identi
|
|||||||
|
|
||||||
Both daemons advertise `connectedHosts`; the shared link additionally requires `hostMultiplexing`.
|
Both daemons advertise `connectedHosts`; the shared link additionally requires `hostMultiplexing`.
|
||||||
A completes capability and pinned-identity checks on each physical recovery before admitting channels. There is no local fallback. An older daemon continues to serve existing local
|
A completes capability and pinned-identity checks on each physical recovery before admitting channels. There is no local fallback. An older daemon continues to serve existing local
|
||||||
operations; requesting this feature gives update guidance.
|
operations; requesting this feature gives update guidance. The registry retries an older destination
|
||||||
|
with capped backoff, so it comes online once updated. Self, duplicate, changed-identity, and
|
||||||
|
authentication failures stay in `error` until an update changes the connection, `enabled`, or
|
||||||
|
`replaceIdentity`, or A restarts.
|
||||||
|
|
||||||
Disposing a routed API releases its observations and session. It does not remove the saved host or
|
Disposing a routed API releases its observations and session. It does not remove the saved host or
|
||||||
affect sibling API scopes. Disposing the origin cascades to its derived scopes. Observations restore
|
affect sibling API scopes. Disposing the origin cascades to its derived scopes. Observations restore
|
||||||
|
|||||||
@@ -65,6 +65,7 @@ per-agent examples and provider-specific keys.
|
|||||||
## Table of Contents
|
## Table of Contents
|
||||||
|
|
||||||
- [Extending a built-in provider](#extending-a-built-in-provider)
|
- [Extending a built-in provider](#extending-a-built-in-provider)
|
||||||
|
- [OpenCode with an existing v2 server](#opencode-with-an-existing-v2-server)
|
||||||
- [Z.AI (Zhipu) coding plan](#zai-zhipu-coding-plan)
|
- [Z.AI (Zhipu) coding plan](#zai-zhipu-coding-plan)
|
||||||
- [Alibaba Cloud (Qwen) coding plan](#alibaba-cloud-qwen-coding-plan)
|
- [Alibaba Cloud (Qwen) coding plan](#alibaba-cloud-qwen-coding-plan)
|
||||||
- [Codex with a custom OpenAI-compatible endpoint](#codex-with-a-custom-openai-compatible-endpoint)
|
- [Codex with a custom OpenAI-compatible endpoint](#codex-with-a-custom-openai-compatible-endpoint)
|
||||||
@@ -107,6 +108,35 @@ See [Codex with a custom OpenAI-compatible endpoint](#codex-with-a-custom-openai
|
|||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
## OpenCode with an existing v2 server
|
||||||
|
|
||||||
|
Paseo first uses an explicitly configured server, then a healthy locally registered OpenCode v2 service, then starts its own helper. It never stops a reused service. To select a server explicitly, set its URL in the provider environment:
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"agents": {
|
||||||
|
"providers": {
|
||||||
|
"opencode": {
|
||||||
|
"env": {
|
||||||
|
"PASEO_OPENCODE_SERVER_URL": "http://127.0.0.1:4096",
|
||||||
|
"PASEO_OPENCODE_SERVER_PASSWORD": "<server password>"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
`PASEO_OPENCODE_SERVER_URL` must be an absolute `http` or `https` URL. Omit `PASEO_OPENCODE_SERVER_PASSWORD` when the server has no authentication; when set, Paseo authenticates with HTTP Basic auth as `opencode`.
|
||||||
|
|
||||||
|
A configured URL takes precedence even when unreachable; Paseo reports the connection error. The local service registration supplies its own authentication. For a discovered local service, Paseo installs its bridge package in OpenCode's watched global plugin directory without changing the existing configuration. Refresh reads the existing service's catalogs without starting another server.
|
||||||
|
|
||||||
|
An explicitly configured server needs the bridge installed separately. Connect once and start a session: the setup error gives the local package directory. Copy that directory to the server's OpenCode global `plugins` directory, then retry. For a server on another machine, set `PASEO_OPENCODE_BRIDGE_PORT` in the Paseo OpenCode provider environment before starting Paseo, and set `PASEO_OPENCODE_BRIDGE_URL` to the URL the OpenCode server can use to reach that port. For example, an SSH reverse tunnel can expose the Paseo loopback port on the OpenCode host. The bridge token is exchanged through the OpenCode connection and is not written into the plugin package.
|
||||||
|
|
||||||
|
OpenCode's custom MCP registrations are shared by all sessions in a location. Paseo rejects custom MCP servers and per-agent process environment overrides on a reused server rather than applying them to other sessions or ignoring them. Session identity is applied to each session's shell environment. A Paseo-owned helper supports custom process and MCP settings; it is selected when there is no explicit URL or healthy registered service.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
## Z.AI (Zhipu) coding plan
|
## Z.AI (Zhipu) coding plan
|
||||||
|
|
||||||
[Z.AI](https://z.ai) is a Chinese AI company (Zhipu AI) that offers an Anthropic-compatible API endpoint. Their GLM Coding Plan provides flat-rate access to GLM models through Claude Code's Anthropic API protocol. These are **not** Anthropic Claude models — they are Zhipu's own GLM models exposed through an Anthropic-compatible API.
|
[Z.AI](https://z.ai) is a Chinese AI company (Zhipu AI) that offers an Anthropic-compatible API endpoint. Their GLM Coding Plan provides flat-rate access to GLM models through Claude Code's Anthropic API protocol. These are **not** Anthropic Claude models — they are Zhipu's own GLM models exposed through an Anthropic-compatible API.
|
||||||
@@ -232,7 +262,7 @@ For pay-as-you-go, use `ANTHROPIC_API_KEY` with a standard Model Studio key (`sk
|
|||||||
|
|
||||||
Codex talks to OpenAI's Responses API by default. Custom providers that extend `"codex"` can point Codex at any OpenAI-compatible endpoint (OpenRouter, LiteLLM, vLLM, llama.cpp server, an internal gateway, etc.) by setting `OPENAI_BASE_URL` and `OPENAI_API_KEY` in the provider `env`.
|
Codex talks to OpenAI's Responses API by default. Custom providers that extend `"codex"` can point Codex at any OpenAI-compatible endpoint (OpenRouter, LiteLLM, vLLM, llama.cpp server, an internal gateway, etc.) by setting `OPENAI_BASE_URL` and `OPENAI_API_KEY` in the provider `env`.
|
||||||
|
|
||||||
Paseo passes those variables through to the Codex app-server process **and** maps them into Codex's thread config under `model_provider` / `model_providers`, because Codex reads provider routing from config rather than from `OPENAI_BASE_URL` alone.
|
Paseo passes those variables through to the Codex app-server process **and** maps them into Codex's thread config under `model_provider` / `model_providers`, because Codex reads provider routing from config rather than from `OPENAI_BASE_URL` alone. The generated Codex provider key is `paseo:<provider-id>`, so a Paseo provider such as `ollama` does not override a Codex built-in. Existing custom sessions created with a non-built-in provider key remain available in Import session. Native Codex conversations using a built-in key stay separate from a custom provider of the same name.
|
||||||
|
|
||||||
### Setup
|
### Setup
|
||||||
|
|
||||||
@@ -260,9 +290,9 @@ Paseo passes those variables through to the Codex app-server process **and** map
|
|||||||
Under the hood, for each custom Codex provider Paseo injects this into Codex's config:
|
Under the hood, for each custom Codex provider Paseo injects this into Codex's config:
|
||||||
|
|
||||||
```toml
|
```toml
|
||||||
model_provider = "my-codex"
|
model_provider = "paseo:my-codex"
|
||||||
|
|
||||||
[model_providers.my-codex]
|
[model_providers."paseo:my-codex"]
|
||||||
name = "My Codex"
|
name = "My Codex"
|
||||||
base_url = "https://custom-relay.example.com/v1"
|
base_url = "https://custom-relay.example.com/v1"
|
||||||
wire_api = "responses"
|
wire_api = "responses"
|
||||||
@@ -747,6 +777,8 @@ The built-in `claude` provider appends concrete model IDs from `~/.claude/settin
|
|||||||
|
|
||||||
This lets users who already configured Claude Code for Bedrock, OpenRouter, ollama, Z.AI, or another Anthropic-compatible gateway select the exact model ID in Paseo. Explicit model IDs are passed unchanged to Claude Code, even when the same string is a compatibility alias for a built-in model. When `agents.providers.claude.models` is set it **replaces** both the hardcoded first-party Claude list and any settings.json-discovered entries; use `agents.providers.claude.additionalModels` to keep the first-party list and append curated entries on top.
|
This lets users who already configured Claude Code for Bedrock, OpenRouter, ollama, Z.AI, or another Anthropic-compatible gateway select the exact model ID in Paseo. Explicit model IDs are passed unchanged to Claude Code, even when the same string is a compatibility alias for a built-in model. When `agents.providers.claude.models` is set it **replaces** both the hardcoded first-party Claude list and any settings.json-discovered entries; use `agents.providers.claude.additionalModels` to keep the first-party list and append curated entries on top.
|
||||||
|
|
||||||
|
Paseo's effort selector does not inherit `effortLevel` from Claude's settings.json. Select an effort in Paseo to choose a specific value.
|
||||||
|
|
||||||
### Gotcha: `extends: "claude"` with third-party endpoints
|
### Gotcha: `extends: "claude"` with third-party endpoints
|
||||||
|
|
||||||
When a custom provider extends `"claude"` but points `ANTHROPIC_BASE_URL` at a non-Anthropic API (Z.AI, Alibaba/Qwen, proxies), the Claude Agent SDK may try to use Anthropic-only server-side tools like `WebSearch`. Third-party APIs don't support these tools, causing errors.
|
When a custom provider extends `"claude"` but points `ANTHROPIC_BASE_URL` at a non-Anthropic API (Z.AI, Alibaba/Qwen, proxies), the Claude Agent SDK may try to use Anthropic-only server-side tools like `WebSearch`. Third-party APIs don't support these tools, causing errors.
|
||||||
|
|||||||
+15
-13
@@ -20,7 +20,7 @@ A semantic element used in three or more places is a primitive. One of a kind is
|
|||||||
|
|
||||||
Primitives live in `packages/app/src/components/ui/` and `packages/app/src/components/headers/`. Card and row layout live in `packages/app/src/styles/settings.ts`. Section structure lives in `packages/app/src/screens/settings/settings-section.tsx`.
|
Primitives live in `packages/app/src/components/ui/` and `packages/app/src/components/headers/`. Card and row layout live in `packages/app/src/styles/settings.ts`. Section structure lives in `packages/app/src/screens/settings/settings-section.tsx`.
|
||||||
|
|
||||||
A pressable styled to look like a button is wrong; the button is `<Button>` (`packages/app/src/components/ui/button.tsx`). A pressable wrapping an icon is wrong; the icon action is `<ToolbarButton>` (`packages/app/src/components/ui/pane-content-toolbar.tsx`), which owns the hitbox, the rounded `interactionHighlight` fill on hover and press, the compact size, and the tooltip. Rows on a menu surface are `<MenuItem>`, or `<ComposerTrackRow>` in a track panel; other rows are `<PressHighlight>` (`packages/app/src/components/ui/press-highlight.tsx`), which flashes on native the moment a finger lands. A bare `<Text>` styled to look like a section header is wrong; the section header is `<SettingsSection>` (`packages/app/src/screens/settings/settings-section.tsx`). A custom `Modal` for a confirmation is wrong; the confirmation is `confirmDialog` (`packages/app/src/utils/confirm-dialog.ts`). A hand-rolled overflow menu is wrong; the menu is `<DropdownMenu>` (`packages/app/src/components/ui/dropdown-menu.tsx`). A hand-rolled status pill is wrong; the pill is `<StatusBadge>` (`packages/app/src/components/ui/status-badge.tsx`). A circle pinned over a scrolling surface is wrong; the floating action is `<FloatingActionButton>` (`packages/app/src/components/ui/floating-action-button.tsx`), one per surface, and the surface reserves `FLOATING_ACTION_BUTTON_CLEARANCE` below its content so the button never traps the last row.
|
A pressable styled to look like a button is wrong; the button is `<Button>` (`packages/app/src/components/ui/button.tsx`). A pressable wrapping an icon is wrong; the icon action is `<ToolbarButton>` (`packages/app/src/components/ui/pane-content-toolbar.tsx`), which owns the hitbox, the rounded `interactionHighlight` fill on hover and press, the compact size, and the tooltip. Rows on a menu surface are `<MenuItem>`, or `<ComposerTrackRow>` in a track panel; other rows are `<PressHighlight>` (`packages/app/src/components/ui/press-highlight.tsx`), which flashes on native the moment a finger lands. A bare `<Text>` styled to look like a section header is wrong; the section header is `<SettingsSection>` (`packages/app/src/components/settings/headings/settings-section.tsx`). A docs link in its header is its `link` prop, which renders `Label ↗` on the title's rail; a ghost button with an arrow is wrong. A custom `Modal` for a confirmation is wrong; the confirmation is `confirmDialog` (`packages/app/src/utils/confirm-dialog.ts`). A hand-rolled overflow menu is wrong; the menu is `<DropdownMenu>` (`packages/app/src/components/ui/dropdown-menu.tsx`). A hand-rolled status pill is wrong; the pill is `<StatusBadge>` (`packages/app/src/components/ui/status-badge.tsx`). A circle pinned over a scrolling surface is wrong; the floating action is `<FloatingActionButton>` (`packages/app/src/components/ui/floating-action-button.tsx`), one per surface, and the surface reserves `FLOATING_ACTION_BUTTON_CLEARANCE` below its content so the button never traps the last row.
|
||||||
|
|
||||||
Before adding a new component, read `components/ui/`. The primitive usually exists.
|
Before adding a new component, read `components/ui/`. The primitive usually exists.
|
||||||
|
|
||||||
@@ -35,8 +35,8 @@ The authored interface ramp uses a 14px base. New native installs default to 15p
|
|||||||
Weight has three tiers, applied by role:
|
Weight has three tiers, applied by role:
|
||||||
|
|
||||||
- **Screen titles** — the title in app chrome — use `<ScreenTitle>` (`packages/app/src/components/headers/screen-title.tsx`), which renders `fontSize.base` at weight `400` on compact and `300` on desktop. The New workspace hero is the only larger product title; it uses `fontSize["2xl"]` (`packages/app/src/screens/new-workspace-screen.tsx`).
|
- **Screen titles** — the title in app chrome — use `<ScreenTitle>` (`packages/app/src/components/headers/screen-title.tsx`), which renders `fontSize.base` at weight `400` on compact and `300` on desktop. The New workspace hero is the only larger product title; it uses `fontSize["2xl"]` (`packages/app/src/screens/new-workspace-screen.tsx`).
|
||||||
- **Structural labels** use `fontWeight.medium`. This applies to section labels above a stack of rows (`packages/app/src/components/agent-list.tsx:519-523`, `packages/app/src/components/keyboard-shortcuts-dialog.tsx:63-67`), form field labels above an input inside a modal (`packages/app/src/components/add-host-modal.tsx:19-23`, `packages/app/src/components/pair-link-modal.tsx:24-28`), the title at the top of a modal/sheet/dialog (`packages/app/src/components/adaptive-modal-sheet.tsx:90-94`, `packages/app/src/components/ui/combobox.tsx:1607-1611`, `packages/app/src/components/welcome-screen.tsx:48-53`), action button labels in tight components such as the sidebar callout actions (`packages/app/src/components/sidebar-callout.tsx:218-221`), and inline data emphasis on dense metadata rows (`packages/app/src/components/git-diff-pane.tsx:2322-2327`, `packages/app/src/components/file-explorer-pane.tsx:1115-1122`).
|
- **Structural labels** use `fontWeight.medium`. This applies to section labels above a stack of rows (`packages/app/src/components/agent-list.tsx:519-523`, `packages/app/src/components/keyboard-shortcuts-dialog.tsx:63-67`), form field labels above an input inside a modal (`packages/app/src/hosts/add-host/internal/add-host-modal.tsx:19-23`, `packages/app/src/hosts/add-host/internal/pair-link-modal.tsx:24-28`), the title at the top of a modal/sheet/dialog (`packages/app/src/components/adaptive-modal-sheet.tsx:90-94`, `packages/app/src/components/ui/combobox.tsx:1607-1611`, `packages/app/src/components/welcome-screen.tsx:48-53`), action button labels in tight components such as the sidebar callout actions (`packages/app/src/components/sidebar-callout.tsx:218-221`), and inline data emphasis on dense metadata rows (`packages/app/src/components/git-diff-pane.tsx:2322-2327`, `packages/app/src/components/file-explorer-pane.tsx:1115-1122`).
|
||||||
- **Content** uses `fontWeight.normal`. This applies to settings rows (`packages/app/src/styles/settings.ts`), sidebar primary list-item titles (`packages/app/src/components/sidebar-workspace-list.tsx:2680-2686`, `packages/app/src/components/agent-list.tsx:572-578`), `<Button>` text (`packages/app/src/components/ui/button.tsx:80-84`), `<StatusBadge>` text (`packages/app/src/components/ui/status-badge.tsx:56-60`), and `<SidebarCallout>` titles (`packages/app/src/components/sidebar-callout.tsx:175-180`).
|
- **Content** uses `fontWeight.normal`. This applies to settings rows (`packages/app/src/styles/settings.ts`), sidebar primary list-item titles (`packages/app/src/components/sidebar-workspace-list.tsx:2680-2686`, `packages/app/src/components/agent-list.tsx:572-578`), `<StatusBadge>` text (`packages/app/src/components/ui/status-badge.tsx:56-60`), and `<SidebarCallout>` titles (`packages/app/src/components/sidebar-callout.tsx:175-180`).
|
||||||
|
|
||||||
The rule, condensed: text that _names_ a surface or a group is `medium`. Text that lives _inside_ a surface or a group is `normal`. Top-of-screen titles are `<ScreenTitle>`, which is lighter still.
|
The rule, condensed: text that _names_ a surface or a group is `medium`. Text that lives _inside_ a surface or a group is `normal`. Top-of-screen titles are `<ScreenTitle>`, which is lighter still.
|
||||||
|
|
||||||
@@ -68,9 +68,11 @@ the sidebar. Apply it as `backgroundColor`; setting `opacity` on the control als
|
|||||||
|
|
||||||
`destructive` is filled with `destructive`. It only appears inside a confirm. The button on the page is `outline`; the destructive button is the confirm button inside the dialog.
|
`destructive` is filled with `destructive`. It only appears inside a confirm. The button on the page is `outline`; the destructive button is the confirm button inside the dialog.
|
||||||
|
|
||||||
Sizes: `xs` for ultra-tight inline triggers. `sm` for any button sitting in a row. `md` is the page default. `lg` is reserved for large standalone CTAs.
|
Controls come in two sizes, defined once in `control-geometry.ts`. The default is the right size almost everywhere — pages, dialogs, forms, settings rows, the setup flow — so don't pass a size. It is 32px tall where a pointer drives it and 44px where controls are touch-sized, so every touch control meets the iOS HIG's 44pt hit region. `sm` is 28px pointer and 32px touch, with `fontSize.sm` labels, and is for tight chrome only: toolbars, nested settings rows, dense inline row actions. A `size="sm"` on an ordinary page or dialog is wrong, and so is choosing a size from `useIsCompactFormFactor()`.
|
||||||
|
|
||||||
Sizes are a shared contract across control kinds, defined once in `control-geometry.ts`: `xs` = 28px tall with `fontSize.sm` labels, `sm` = 32px with `fontSize.base`, `md`/`lg` = 44px with `fontSize.base`. `<SegmentedControl>` (`packages/app/src/components/ui/segmented-control.tsx`) takes the same `xs`/`sm`/`md` sizes — a segmented control next to a `<Button>` of the same size always matches in height, label size, and corner radius. Its segments run one padding step tighter than a button, because the gap between segments already reads as padding. The selected segment is a `surface3` fill with `foreground` text, not an inverted one — inverting it inside thin chrome puts a white slab in the toolbar. Text fields take `xs`, `sm` and `md`. Thin chrome such as the file toolbar uses `xs`. A settings row sizes the controls in its trailing slot itself, `sm` in a card and `xs` when nested (`packages/app/src/components/ui/control-size.tsx`), so don't pass a size to a button, dropdown or field placed in a row. Never shrink a control's font or padding locally to fit a context — if the context needs a smaller control, the size tier is missing or the wrong one is in use.
|
One gate, `resolveControlSizing`, picks touch or pointer sizing: touch when the layout is compact or the device has a touch screen. An iPad with the sidebar docked is wide and touch-sized; a desktop is pointer-sized; a phone is both compact and touch. The touch-screen fact is read once at startup (`hasTouchScreen` in `hooks/use-fine-pointer.ts`), so attaching a mouse or keyboard to a tablet never shrinks its controls. Stylesheets take sizes from `bySizing({ touch, pointer })`, which resolves to a breakpoint value, so a caller never sees which sizing it got. Rows, icon buttons and icon slots take theirs from `styles/density.ts`, which uses the same gate. An `{ xs, md }` literal for a hit target or glyph is wrong: on an iPad it yields the pointer size.
|
||||||
|
|
||||||
|
Buttons are pills (`borderRadius.full`) with medium-weight labels; an icon-only button is a circle. `<Switch>` follows the same two sizes: a 34×20 track by default and in `sm`, 44×26 where controls are touch-sized, and it reserves its size's control height so a row holding one lines up with a row holding a button. Buttons, text fields, dropdown triggers, and `<SegmentedControl>` (`packages/app/src/components/ui/segmented-control.tsx`) share the size contract — the same size name means the same height and label size on every control kind, so controls in one row line up. Segments run tighter than a button, because the gap between segments already reads as padding. The selected segment is a `surface3` fill with `foreground` text, not an inverted one — inverting it inside thin chrome puts a white slab in the toolbar. A settings row sizes the controls in its trailing slot itself, default in a card and `sm` when nested (`packages/app/src/components/ui/control-size.tsx`), so don't pass a size to a button, dropdown or field placed in a row. Code that computes with a control's height outside a stylesheet uses `controlHeightForLayout`. Never shrink a control's font or padding locally to fit a context — if the context needs a smaller control, the size tier is missing or the wrong one is in use.
|
||||||
|
|
||||||
A `<Pressable>` wrapping a `<Text>` is a sixth variant. It is wrong. `<Button>` accepts `style`, `textStyle`, `leftIcon`, `disabled`, `size`, and `variant`.
|
A `<Pressable>` wrapping a `<Text>` is a sixth variant. It is wrong. `<Button>` accepts `style`, `textStyle`, `leftIcon`, `disabled`, `size`, and `variant`.
|
||||||
|
|
||||||
@@ -102,7 +104,7 @@ Five primitives. The pick is determined by option count, the need to search, and
|
|||||||
|
|
||||||
`<ContextMenu>` is for right-click and long-press on a target. The row is the trigger; there is no visible affordance. Used for incidental actions on workspace rows in the sidebar (`packages/app/src/components/sidebar-workspace-list.tsx`).
|
`<ContextMenu>` is for right-click and long-press on a target. The row is the trigger; there is no visible affordance. Used for incidental actions on workspace rows in the sidebar (`packages/app/src/components/sidebar-workspace-list.tsx`).
|
||||||
|
|
||||||
`<AdaptiveModalSheet>` is for a focused task. Multi-field forms (`packages/app/src/components/add-host-modal.tsx`, `packages/app/src/components/pair-link-modal.tsx`, `packages/app/src/components/project-picker-modal.tsx`), confirmations with detail, anything that earns a backdrop. Bottom sheet on compact, centered card on desktop. Raw `Modal` is wrong for any of these.
|
`<AdaptiveModalSheet>` is for a focused task. Multi-field forms (`packages/app/src/hosts/add-host/internal/add-host-modal.tsx`, `packages/app/src/hosts/add-host/internal/pair-link-modal.tsx`, `packages/app/src/components/project-picker-modal.tsx`), confirmations with detail, anything that earns a backdrop. Bottom sheet on compact, centered card on desktop. Both sit on `surface0`, the same base as a screen, so settings cards and inputs inside a modal read the way they do on the Settings screen. Raw `Modal` is wrong for any of these.
|
||||||
|
|
||||||
`<AdaptiveModalSheet>` owns the presentation. Its content inset — the gutter that puts sheet content on the same rails as the sheet header — and compact bottom safe-area padding are the sheet's, not the caller's. A caller declares layout intent through `contentStyle` and never branches on form factor to add its own margins. If a sheet's first snap point is shorter than its header, content, and safe-area clearance, raise that snap point rather than moving the sheet container.
|
`<AdaptiveModalSheet>` owns the presentation. Its content inset — the gutter that puts sheet content on the same rails as the sheet header — and compact bottom safe-area padding are the sheet's, not the caller's. A caller declares layout intent through `contentStyle` and never branches on form factor to add its own margins. If a sheet's first snap point is shorter than its header, content, and safe-area clearance, raise that snap point rather than moving the sheet container.
|
||||||
|
|
||||||
@@ -114,7 +116,7 @@ Three themes is `DropdownMenu`. Thirty hosts is `Combobox`. A label and a value
|
|||||||
|
|
||||||
## 7. Density and rhythm
|
## 7. Density and rhythm
|
||||||
|
|
||||||
Settings detail pages, the projects detail page, and any list+detail content sit inside a centered, max-width 720 column (`packages/app/src/screens/settings-screen.tsx`, `packages/app/src/screens/projects-screen.tsx`). Lines stay readable, the eye does not have to track wide horizontal distances. Form modals carry their own narrower content frame (`packages/app/src/components/add-host-modal.tsx`).
|
Settings detail pages, the projects detail page, and any list+detail content sit inside a centered, max-width 720 column (`packages/app/src/screens/settings-screen.tsx`, `packages/app/src/screens/projects-screen.tsx`). Lines stay readable, the eye does not have to track wide horizontal distances. Form modals carry their own narrower content frame (`packages/app/src/hosts/add-host/internal/add-host-modal.tsx`).
|
||||||
|
|
||||||
Workspace and chat surfaces use the full width — these are working surfaces, not reading surfaces. The composer carries `MAX_CONTENT_WIDTH` from `packages/app/src/constants/layout.ts` to keep lines readable while letting the workspace pane fill the rest.
|
Workspace and chat surfaces use the full width — these are working surfaces, not reading surfaces. The composer carries `MAX_CONTENT_WIDTH` from `packages/app/src/constants/layout.ts` to keep lines readable while letting the workspace pane fill the rest.
|
||||||
|
|
||||||
@@ -126,7 +128,7 @@ Cards inside a section sit closer than sections. Rows inside a card touch — on
|
|||||||
|
|
||||||
Rows have generous vertical padding: roughly 16px of content plus 16px of vertical padding for settings rows, 8–12px for sidebar list items where many rows must fit. Compressing rows below the established density to fit more on the screen is wrong. Too many rows means more cards or more sections, not smaller rows.
|
Rows have generous vertical padding: roughly 16px of content plus 16px of vertical padding for settings rows, 8–12px for sidebar list items where many rows must fit. Compressing rows below the established density to fit more on the screen is wrong. Too many rows means more cards or more sections, not smaller rows.
|
||||||
|
|
||||||
Rows revealed under a `<SettingsCollapsibleRow>` are nested rows, one step smaller than card rows: 8px of vertical padding, `fontSize.sm` text, `xs` controls, and one fixed height so rows with and without a trailing button line up. The collapsible row sets this for everything under it (`packages/app/src/components/settings/row-density.tsx`). Never pass a density to a row, and never pad or resize a nested row by hand.
|
Rows revealed under a `<SettingsCollapsibleRow>` are nested rows, one step smaller than card rows: 8px of vertical padding, `fontSize.sm` text, `sm` controls, and one fixed height so rows with and without a trailing button line up. The collapsible row sets this for everything under it (`packages/app/src/components/settings/row-density.tsx`). Never pass a density to a row, and never pad or resize a nested row by hand.
|
||||||
|
|
||||||
The whitespace is the design.
|
The whitespace is the design.
|
||||||
|
|
||||||
@@ -150,7 +152,7 @@ One row off the rail makes the whole card look unconsidered.
|
|||||||
|
|
||||||
Compact-first. The small case is designed; the large case adds chrome around it.
|
Compact-first. The small case is designed; the large case adds chrome around it.
|
||||||
|
|
||||||
Use `md: 600` for both the compact/wide layout boundary and responsive density, in logical points on native and CSS pixels on web. Do not add a separate density breakpoint. Measured content constraints remain independent: composer controls use `COMPACT_CONTENT_WIDTH` (500), so a narrow pane can keep compact controls inside a wide window.
|
Use `md: 600` for the compact/wide layout boundary, in logical points on native and CSS pixels on web. Do not add a separate density breakpoint; touch sizing comes from the control sizing gate in [Buttons](#4-buttons). Measured content constraints remain independent: composer controls use `COMPACT_CONTENT_WIDTH` (500), so a narrow pane can keep compact controls inside a wide window.
|
||||||
|
|
||||||
The settings shell (`packages/app/src/screens/settings-screen.tsx`) and the projects screen (`packages/app/src/screens/projects-screen.tsx`) share the canonical list+detail navigation pattern:
|
The settings shell (`packages/app/src/screens/settings-screen.tsx`) and the projects screen (`packages/app/src/screens/projects-screen.tsx`) share the canonical list+detail navigation pattern:
|
||||||
|
|
||||||
@@ -197,11 +199,11 @@ Terminology:
|
|||||||
|
|
||||||
Loading is inline by default. `<LoadingSpinner size={14} color={foregroundMuted} />` sits next to the thing it relates to (`packages/app/src/screens/settings/providers-section.tsx:227-231`). Page-level loading is a centered `<LoadingSpinner size="large">` (`packages/app/src/screens/sessions-screen.tsx:69-72`). Card-level loading is a single short line, not a spinner. In-row dropdown items use `<DropdownMenuItem status="pending" pendingLabel="Removing...">`; the menu item handles its own pending state.
|
Loading is inline by default. `<LoadingSpinner size={14} color={foregroundMuted} />` sits next to the thing it relates to (`packages/app/src/screens/settings/providers-section.tsx:227-231`). Page-level loading is a centered `<LoadingSpinner size="large">` (`packages/app/src/screens/sessions-screen.tsx:69-72`). Card-level loading is a single short line, not a spinner. In-row dropdown items use `<DropdownMenuItem status="pending" pendingLabel="Removing...">`; the menu item handles its own pending state.
|
||||||
|
|
||||||
Screen-level empty states use a centered, muted noun phrase and at most one ghost button (`packages/app/src/screens/sessions-screen.tsx`). Sidebar list empty states use a quiet bordered card with a left-aligned `sm` title, a muted `sm` description, and `xs` `<Button>` actions. Use `secondary` for the primary action and `outline` for a secondary action (`packages/app/src/components/sidebar/empty-states.tsx`). Keep both forms short and free of illustrations.
|
Screen-level empty states use a centered, muted noun phrase and at most one ghost button (`packages/app/src/screens/sessions-screen.tsx`). Sidebar list empty states use a quiet bordered card with a left-aligned `sm` title, a muted `sm` description, and `sm` `<Button>` actions. Use `secondary` for the primary action and `outline` for a secondary action (`packages/app/src/components/sidebar/empty-states.tsx`). Keep both forms short and free of illustrations.
|
||||||
|
|
||||||
Inline errors are a single sentence in `palette.red[300]` `xs`, sitting under the field or inside the card it relates to (`packages/app/src/screens/settings/providers-section.tsx:115-119`).
|
Inline errors are a single sentence in `palette.red[300]` `xs`, sitting under the field or inside the card it relates to (`packages/app/src/screens/settings/providers-section.tsx:115-119`).
|
||||||
|
|
||||||
Page-level alerts — informational notices, success confirmations, warnings, or recoverable errors that need a small visible block on the page — use `<Alert>` (`packages/app/src/components/ui/alert.tsx`). Variants: `default`, `info`, `success`, `warning`, `error`. The chrome is quiet by design: a 1px tinted border, transparent background, a small variant-tinted icon, the title in the variant accent, the description in `foregroundMuted`. Actions go in the `children` slot as `<Button variant="outline" size="sm">` — recovery actions are low-frequency and outline keeps them quiet alongside the alert's accent (`packages/app/src/screens/project-settings-screen.tsx`). One `<Alert>` at a time per region.
|
Page-level alerts — informational notices, success confirmations, warnings, or recoverable errors that need a small visible block on the page — use `<Alert>` (`packages/app/src/components/ui/alert.tsx`). Variants: `default`, `info`, `success`, `warning`, `error`. The chrome is quiet by design: a 1px tinted border, transparent background, a small variant-tinted icon, the title in the variant accent, the description in `foregroundMuted`. Actions go in the `children` slot as `<Button variant="outline">` — recovery actions are low-frequency and outline keeps them quiet alongside the alert's accent (`packages/app/src/screens/project-settings-screen.tsx`). One `<Alert>` at a time per region.
|
||||||
|
|
||||||
Sidebar callouts — cross-cutting alerts that apply across the whole app, like worktree setup, Rosetta install, and desktop update available — register through `useSidebarCallouts()` and render in the left sidebar via `<SidebarCallout>` (`packages/app/src/components/sidebar-callout.tsx`). The chrome (top-border-only, full-width action buttons) is tuned for that ~280px column. Canonical sources: `packages/app/src/components/worktree-setup-callout-source.tsx`, `packages/app/src/desktop/updates/rosetta-callout-source.tsx`, `packages/app/src/desktop/updates/update-callout-source.tsx`. Never import `<SidebarCallout>` into a page — that's what `<Alert>` is for.
|
Sidebar callouts — cross-cutting alerts that apply across the whole app, like worktree setup, Rosetta install, and desktop update available — register through `useSidebarCallouts()` and render in the left sidebar via `<SidebarCallout>` (`packages/app/src/components/sidebar-callout.tsx`). The chrome (top-border-only, full-width action buttons) is tuned for that ~280px column. Canonical sources: `packages/app/src/components/worktree-setup-callout-source.tsx`, `packages/app/src/desktop/updates/rosetta-callout-source.tsx`, `packages/app/src/desktop/updates/update-callout-source.tsx`. Never import `<SidebarCallout>` into a page — that's what `<Alert>` is for.
|
||||||
|
|
||||||
@@ -251,7 +253,7 @@ New status pills use `<StatusBadge>`. Identity, shortcut, and interactive link b
|
|||||||
|
|
||||||
## 14. Forbidden
|
## 14. Forbidden
|
||||||
|
|
||||||
- `fontWeight.medium` on row titles, body text, button labels, badge text, or `<SidebarCallout>` titles. Medium is reserved for the structural-label tier described in §3 — section labels, modal/sheet titles, dense metadata emphasis, and tight action labels. Anything else is `normal`. `<ScreenTitle>` is responsive `400/300` and is never overridden.
|
- `fontWeight.medium` on row titles, body text, badge text, or `<SidebarCallout>` titles. Medium is reserved for the structural-label tier described in §3 — section labels, modal/sheet titles, dense metadata emphasis, and tight action labels. Anything else is `normal`. `<ScreenTitle>` is responsive `400/300` and is never overridden.
|
||||||
- `<Pressable>` wrapping `<Text>` to make a button. `<Button>` exists.
|
- `<Pressable>` wrapping `<Text>` to make a button. `<Button>` exists.
|
||||||
- Importing `Pressable` or a `Touchable*` outside `components/ui/`. A raw pressable has no standard press or hover feedback, so every one drifts. `paseo/no-raw-pressable` reports it; the files on its burn-down list in `.oxlintrc.json` may only leave it.
|
- Importing `Pressable` or a `Touchable*` outside `components/ui/`. A raw pressable has no standard press or hover feedback, so every one drifts. `paseo/no-raw-pressable` reports it; the files on its burn-down list in `.oxlintrc.json` may only leave it.
|
||||||
- Bare `<Text>` for a section header inside settings. `<SettingsSection>` exists.
|
- Bare `<Text>` for a section header inside settings. `<SettingsSection>` exists.
|
||||||
@@ -278,7 +280,7 @@ New status pills use `<StatusBadge>`. Identity, shortcut, and interactive link b
|
|||||||
| List+detail (compact stack, desktop sidebar+pane) | `packages/app/src/screens/settings-screen.tsx`, `packages/app/src/screens/projects-screen.tsx` |
|
| List+detail (compact stack, desktop sidebar+pane) | `packages/app/src/screens/settings-screen.tsx`, `packages/app/src/screens/projects-screen.tsx` |
|
||||||
| Detail card+row | `packages/app/src/screens/settings/host-page.tsx`, `packages/app/src/screens/settings/providers-section.tsx` |
|
| Detail card+row | `packages/app/src/screens/settings/host-page.tsx`, `packages/app/src/screens/settings/providers-section.tsx` |
|
||||||
| Section grouping inside a card list | `packages/app/src/screens/settings/settings-section.tsx` |
|
| Section grouping inside a card list | `packages/app/src/screens/settings/settings-section.tsx` |
|
||||||
| Form modal (label + input fields, primary + cancel) | `packages/app/src/components/add-host-modal.tsx`, `packages/app/src/components/pair-link-modal.tsx`, `packages/app/src/components/project-picker-modal.tsx` |
|
| Form modal (label + input fields, primary + cancel) | `packages/app/src/hosts/add-host/internal/add-host-modal.tsx`, `packages/app/src/hosts/add-host/internal/pair-link-modal.tsx`, `packages/app/src/components/project-picker-modal.tsx` |
|
||||||
| Destructive confirmation | `confirmDialog` invoked from `packages/app/src/screens/settings/host-page.tsx:541-547` |
|
| Destructive confirmation | `confirmDialog` invoked from `packages/app/src/screens/settings/host-page.tsx:541-547` |
|
||||||
| Centered hero / first-run | `packages/app/src/components/welcome-screen.tsx` |
|
| Centered hero / first-run | `packages/app/src/components/welcome-screen.tsx` |
|
||||||
| Sidebar list (workspaces, hosts) | `packages/app/src/components/sidebar-workspace-list.tsx`, `packages/app/src/components/left-sidebar.tsx` |
|
| Sidebar list (workspaces, hosts) | `packages/app/src/components/sidebar-workspace-list.tsx`, `packages/app/src/components/left-sidebar.tsx` |
|
||||||
|
|||||||
+11
-1
@@ -593,7 +593,17 @@ rerun passes only by landing elsewhere.
|
|||||||
|
|
||||||
To confirm, fetch the URL from several runners and compare `content-length`, the `cf-ray` colo
|
To confirm, fetch the URL from several runners and compare `content-length`, the `cf-ray` colo
|
||||||
suffix, and the number of `attestations` entries (#7730 has the probe). To fix, remove or
|
suffix, and the number of `attestations` entries (#7730 has the probe). To fix, remove or
|
||||||
replace that version in the lockfile and report the URL to npm so they purge it.
|
replace that version in the lockfile. If the dependent’s range cannot be changed, pin a clean
|
||||||
|
version in root `overrides`. Report the URL to npm so they purge it.
|
||||||
|
|
||||||
|
A lockfile regeneration is itself how new bad versions enter: the pkijs fix re-resolved the
|
||||||
|
electron-builder tree and pulled in `semver` 5.7.3 and 6.3.2, published two days earlier, and
|
||||||
|
5.7.3 then failed the same way. After editing `overrides`, run `npm install --package-lock-only`
|
||||||
|
and check that the changed `resolved` lines in `package-lock.json` are only the ones you meant.
|
||||||
|
|
||||||
|
A per-parent override such as `"tiny-async-pool": { "semver": "5.7.2" }` applies to that
|
||||||
|
parent's whole subtree, so it can also downgrade a grandchild that needs a different major. Key
|
||||||
|
the child by range (`{ "semver@^5": "5.7.2" }`) so only matching edges are replaced.
|
||||||
|
|
||||||
## ACP provider catalog versions
|
## ACP provider catalog versions
|
||||||
|
|
||||||
|
|||||||
+8
-1
@@ -58,6 +58,12 @@ restore the same workspace and could repeat the crash.
|
|||||||
|
|
||||||
## App-Wide Route Hops
|
## App-Wide Route Hops
|
||||||
|
|
||||||
|
Keep Add host in `hosts/add-host`, opened through `useAddHost()`. It is an in-place
|
||||||
|
flow; callers choose what happens after success. Settings opts into the new host’s
|
||||||
|
Overview. Do not send callers to Settings with an `addHost` query parameter: a
|
||||||
|
retained route replays that request when appearance changes remount its content.
|
||||||
|
The flow provider and sheet host stay outside appearance keys so open drafts survive.
|
||||||
|
|
||||||
When app-wide routes such as `/new`, `/settings`, or `/sessions` navigate back
|
When app-wide routes such as `/new`, `/settings`, or `/sessions` navigate back
|
||||||
into a host workspace, use `navigateToWorkspace()`. Do not make the caller
|
into a host workspace, use `navigateToWorkspace()`. Do not make the caller
|
||||||
branch on its current route.
|
branch on its current route.
|
||||||
@@ -90,7 +96,8 @@ hidden workspace can overwrite the remembered workspace before Settings or
|
|||||||
History returns.
|
History returns.
|
||||||
|
|
||||||
Plugin settings use the distinct `settings/hosts/[serverId]/plugins/[pluginId]/[screenId]` leaf;
|
Plugin settings use the distinct `settings/hosts/[serverId]/plugins/[pluginId]/[screenId]` leaf;
|
||||||
Back returns to that host's Plugins page.
|
Back returns to that host's Plugins page. Its screen tabs change `screenId` with `router.setParams`,
|
||||||
|
so switching tabs adds no stack entries.
|
||||||
|
|
||||||
Settings detail routes are separate siblings on purpose. Keep
|
Settings detail routes are separate siblings on purpose. Keep
|
||||||
`settings/[section]`, the host routes, the projects index, and project detail as
|
`settings/[section]`, the host routes, the projects index, and project detail as
|
||||||
|
|||||||
@@ -157,8 +157,7 @@ and the stream keeps its existing flick-to-dismiss gesture.
|
|||||||
The dock's private viewport and capacity model are extracted from chat. The
|
The dock's private viewport and capacity model are extracted from chat. The
|
||||||
app-wide `@/keyboard/shift` module owns shared motion for the dock, portals, streams,
|
app-wide `@/keyboard/shift` module owns shared motion for the dock, portals, streams,
|
||||||
terminal, explorer, and dialogs. Import only its public entry point: the provider,
|
terminal, explorer, and dialogs. Import only its public entry point: the provider,
|
||||||
shift hooks, shift style, translate view, keyboard anchor, settled stream inset, and explorer padding
|
shift hooks, shift style, translate view, and keyboard anchor. Its contexts and reconciliation stay private. Keep `KeyboardShiftProvider`
|
||||||
policy. Its contexts and reconciliation stay private. Keep `KeyboardShiftProvider`
|
|
||||||
at its root mount point outside the portal host when changing dock hosts.
|
at its root mount point outside the portal host when changing dock hosts.
|
||||||
|
|
||||||
`KeyboardTranslateView` owns visual keyboard motion inside `@/keyboard/shift`. Android uses the
|
`KeyboardTranslateView` owns visual keyboard motion inside `@/keyboard/shift`. Android uses the
|
||||||
@@ -171,15 +170,14 @@ animation. Keep this platform choice inside the keyboard module's private platfo
|
|||||||
`KeyboardTranslateView`. The panel root clips it at the header edge, so rows
|
`KeyboardTranslateView`. The panel root clips it at the header edge, so rows
|
||||||
slide under the header on open and out from under it on close. Do not swap the
|
slide under the header on open and out from under it on close. Do not swap the
|
||||||
dock to keyboard padding at rest. Changing its height creates either a blank
|
dock to keyboard padding at rest. Changing its height creates either a blank
|
||||||
band or a paused transition when the inverted list updates its viewport.
|
band or a paused transition when the stream list updates its viewport.
|
||||||
|
|
||||||
Do not animate a layout prop through the keyboard transition. On Android
|
Do not animate a layout prop through the keyboard transition. On Android
|
||||||
Fabric, each animated layout update clones the shadow tree and runs Yoga over
|
Fabric, each animated layout update clones the shadow tree and runs Yoga over
|
||||||
the dock subtree. This measured about 10 ms per frame on the emulator and the
|
the dock subtree. This measured about 10 ms per frame on the emulator and the
|
||||||
mounted layouts arrived in bursts every 2–4 frames. A transform does not dirty
|
mounted layouts arrived in bursts every 2–4 frames. A transform does not dirty
|
||||||
layout. Preserve the translated dock's history scroll range with a far-end
|
layout. The stream list gets no keyboard inset either; see
|
||||||
content inset on the inverted stream list. Update that inset only when keyboard
|
[who owns the offset](agent-stream-disclosure.md#who-owns-the-offset).
|
||||||
motion settles; never drive it per frame.
|
|
||||||
|
|
||||||
The translated dock's height is not the composer's available height. Bound the
|
The translated dock's height is not the composer's available height. Bound the
|
||||||
composer against the stationary space below the header inside
|
composer against the stationary space below the header inside
|
||||||
|
|||||||
+16
-13
@@ -97,19 +97,15 @@ Register the adapter in `defaultForgeRegistry` with:
|
|||||||
- `matchesHost` from manifest `cloudHosts`
|
- `matchesHost` from manifest `cloudHosts`
|
||||||
- `probeHost` when self-hosted/Enterprise detection is supported
|
- `probeHost` when self-hosted/Enterprise detection is supported
|
||||||
|
|
||||||
Current change-request lookup uses two identities deliberately:
|
Current change-request lookup matches the branch and repository for both open and
|
||||||
|
terminal requests. Prefer an open request, then a terminal request at the local
|
||||||
|
HEAD, then the most recently updated terminal request. A reused branch can show
|
||||||
|
its previous request until a new one opens. Auto-archive separately requires an
|
||||||
|
observed open-to-merged transition and a fresh exact match between checkout HEAD
|
||||||
|
and the PR head, along with the existing workspace safety checks.
|
||||||
|
|
||||||
- An open PR/MR belongs to the checkout when its head branch and head repository
|
Keep checkout HEAD in adapter cache and poll identities so checkout changes
|
||||||
match. Its remote head SHA may differ because the checkout can be ahead,
|
refresh the facts used by archive eligibility.
|
||||||
behind, or contain commits that have not been pushed yet.
|
|
||||||
- A merged or closed PR/MR belongs to the checkout only when its recorded head
|
|
||||||
SHA exactly matches the checkout's current `HEAD`. Branch names are reusable;
|
|
||||||
selecting the newest terminal request by branch alone can silently attach an
|
|
||||||
old promotion or feature request to new work.
|
|
||||||
|
|
||||||
Thread the checkout head SHA through adapter cache and poll identities as well
|
|
||||||
as the lookup itself. Otherwise a commit made on the same branch can inherit the
|
|
||||||
previous commit's cached terminal status until the cache expires.
|
|
||||||
|
|
||||||
Cloud hosts in the manifest are a bounded public-host list, not a self-host
|
Cloud hosts in the manifest are a bounded public-host list, not a self-host
|
||||||
allowlist. Self-hosted detection is a trust gate: Paseo only talks to a forge
|
allowlist. Self-hosted detection is a trust gate: Paseo only talks to a forge
|
||||||
@@ -125,7 +121,8 @@ rendering stack:
|
|||||||
`acme.ts` exports a `ClientForgeLogicModule`:
|
`acme.ts` exports a `ClientForgeLogicModule`:
|
||||||
|
|
||||||
- `id`
|
- `id`
|
||||||
- optional `urlGrammar` (including `referencePaths` for composer auto-attachment)
|
- optional `urlGrammar` (including `referencePaths` for composer auto-attachment
|
||||||
|
and Markdown shorthand references)
|
||||||
- optional `facts` registration (schema, merge-capability, native-check fallbacks)
|
- optional `facts` registration (schema, merge-capability, native-check fallbacks)
|
||||||
|
|
||||||
`acme.view.tsx` exports a `ClientForgeViewModule`:
|
`acme.view.tsx` exports a `ClientForgeViewModule`:
|
||||||
@@ -212,6 +209,12 @@ are stale, run `npm run build:server`.
|
|||||||
neutral extractor matches the pasted host and full repository path against
|
neutral extractor matches the pasted host and full repository path against
|
||||||
the current remote before it invokes cwd-routed forge search. Do not add a
|
the current remote before it invokes cwd-routed forge search. Do not add a
|
||||||
central forge switch or guess a self-hosted Gitea-family brand from URL shape.
|
central forge switch or guess a self-hosted Gitea-family brand from URL shape.
|
||||||
|
- Shorthand references in rendered Markdown (`#12`, GitLab and Gitea `!12`,
|
||||||
|
cross-repository `owner/repo#12`) come from the `sigil` on each
|
||||||
|
`referencePaths` entry. Leave `sigil` off a kind the forge does not link in
|
||||||
|
prose: GitHub has no `!`, and its `#` targets `/issues/`, which GitHub
|
||||||
|
redirects to the pull request. `packages/app/src/git/forge-shorthand` builds
|
||||||
|
the recognition pattern from the workspace descriptor's forge and remote.
|
||||||
- GitLab pipeline status constants belong to the GitLab adapter/client module,
|
- GitLab pipeline status constants belong to the GitLab adapter/client module,
|
||||||
not protocol.
|
not protocol.
|
||||||
- GitLab `manual` jobs need `allow_failure` to distinguish optional gray jobs
|
- GitLab `manual` jobs need `allow_failure` to distinguish optional gray jobs
|
||||||
|
|||||||
@@ -28,6 +28,7 @@ Authoritative terminology. UI label wins. Don't invent synonyms; use what's here
|
|||||||
- **Workspace-owned state** — Per-workspace state that never leaks to a same-`cwd` sibling: tabs, agents, terminals, panes, title, plus review drafts, diff-mode overrides, composer attachments, and file-explorer open/expand state. Keyed by `workspaceId` (`cwd` only as a fallback for old payloads). See [architecture.md](architecture.md#right-sidebar-boundary-directory-backed-vs-workspace-owned).
|
- **Workspace-owned state** — Per-workspace state that never leaks to a same-`cwd` sibling: tabs, agents, terminals, panes, title, plus review drafts, diff-mode overrides, composer attachments, and file-explorer open/expand state. Keyed by `workspaceId` (`cwd` only as a fallback for old payloads). See [architecture.md](architecture.md#right-sidebar-boundary-directory-backed-vs-workspace-owned).
|
||||||
- **Last prompt** — Sidebar workspace sort by the most recent human prompt recorded by an agent in that workspace, including archived agents. Agent output, agent-to-agent messages, scheduled prompts, and opening a workspace do not count. A workspace without a human prompt uses its creation time.
|
- **Last prompt** — Sidebar workspace sort by the most recent human prompt recorded by an agent in that workspace, including archived agents. Agent output, agent-to-agent messages, scheduled prompts, and opening a workspace do not count. A workspace without a human prompt uses its creation time.
|
||||||
- **Workspace status bucket** — Aggregate activity signal for a workspace row. Same-`cwd` workspaces intentionally share agent and terminal status buckets, while tab, agent, and terminal visibility remains scoped by `workspaceId`.
|
- **Workspace status bucket** — Aggregate activity signal for a workspace row. Same-`cwd` workspaces intentionally share agent and terminal status buckets, while tab, agent, and terminal visibility remains scoped by `workspaceId`.
|
||||||
|
- **Background agent** — An agent hidden from default discovery and from app surfaces that announce agents: tabs, the subagent track, agent lists, workspace status and attention. It is otherwise an ordinary durable agent, addressable by id. An agent is effectively background when it or its workspace is background. Fixed at creation. Code: `background` on `AgentSnapshotPayload` and `create_agent_request`. See [agent-lifecycle.md](agent-lifecycle.md#background-visibility). Don't confuse with background work (provider shells and monitors) or the daemon's private internal helpers, which are never public ([agent-lifecycle.md](agent-lifecycle.md#private-daemon-helpers)).
|
||||||
- **Agent session** — One running instance of an agent inside a workspace (one provider, one model, one cwd, one timeline). The conceptual unit; in the UI this opens as a tab. Moving toward this as the canonical term over "Agent". Code: `AgentSnapshotPayload` (`packages/protocol/src/messages.ts:608`).
|
- **Agent session** — One running instance of an agent inside a workspace (one provider, one model, one cwd, one timeline). The conceptual unit; in the UI this opens as a tab. Moving toward this as the canonical term over "Agent". Code: `AgentSnapshotPayload` (`packages/protocol/src/messages.ts:608`).
|
||||||
- **Session** — Two senses: (a) per-client connection to a daemon, internal; (b) user-facing agent session, see **Agent session**. Code: `Session` (`packages/server/src/server/session.ts`) for (a). Don't confuse with: provider-side agent session log.
|
- **Session** — Two senses: (a) per-client connection to a daemon, internal; (b) user-facing agent session, see **Agent session**. Code: `Session` (`packages/server/src/server/session.ts`) for (a). Don't confuse with: provider-side agent session log.
|
||||||
- **Profile** — Internal name for the persisted shape of a host. Code: `HostProfile` (`packages/app/src/types/host-connection.ts:37`). Never user-facing. Three other things are called "profile" in this codebase, so always qualify: **Agent profile**, **Terminal profile**, and the provider aliases in [custom-providers.md](custom-providers.md). Bare "profile" is forbidden in UI copy.
|
- **Profile** — Internal name for the persisted shape of a host. Code: `HostProfile` (`packages/app/src/types/host-connection.ts:37`). Never user-facing. Three other things are called "profile" in this codebase, so always qualify: **Agent profile**, **Terminal profile**, and the provider aliases in [custom-providers.md](custom-providers.md). Bare "profile" is forbidden in UI copy.
|
||||||
@@ -38,6 +39,7 @@ Authoritative terminology. UI label wins. Don't invent synonyms; use what's here
|
|||||||
- **Usage source** — Plugin registration that discovers accounts and fetches plan usage. Code: `UsageSourceRegistration` (`packages/plugin/src/server/usage.ts`).
|
- **Usage source** — Plugin registration that discovers accounts and fetches plan usage. Code: `UsageSourceRegistration` (`packages/plugin/src/server/usage.ts`).
|
||||||
- **Report ID** — Stable daemon-composed identity for one source account: `<sourceId>:<accountKey>`. The source owns the account key; clients treat the whole ID as opaque. Code: `UsageReportEntry.id` (`packages/protocol/src/messages.ts`).
|
- **Report ID** — Stable daemon-composed identity for one source account: `<sourceId>:<accountKey>`. The source owns the account key; clients treat the whole ID as opaque. Code: `UsageReportEntry.id` (`packages/protocol/src/messages.ts`).
|
||||||
- **Usage report** — A source's normalized usage for one account, including status and optional windows, balances, and details. Its entry carries the Report ID, account label, and fetch time. Each report renders as one card in the Usage modal, in host Settings, and in an agent's context window details (a hover card on desktop web, a tooltip on native wide screens, a sheet on compact ones), which show only the account that agent runs under, without pins. The hover card and the sheet have Refresh; the native tooltip takes no presses. Code: `UsageReport` (`packages/plugin/src/server/usage.ts`), `UsageCard` (`packages/app/src/usage/card.tsx`), `AgentUsage` (`packages/app/src/usage/agent-usage.tsx`).
|
- **Usage report** — A source's normalized usage for one account, including status and optional windows, balances, and details. Its entry carries the Report ID, account label, and fetch time. Each report renders as one card in the Usage modal, in host Settings, and in an agent's context window details (a hover card on desktop web, a tooltip on native wide screens, a sheet on compact ones), which show only the account that agent runs under, without pins. The hover card and the sheet have Refresh; the native tooltip takes no presses. Code: `UsageReport` (`packages/plugin/src/server/usage.ts`), `UsageCard` (`packages/app/src/usage/card.tsx`), `AgentUsage` (`packages/app/src/usage/agent-usage.tsx`).
|
||||||
|
- **Check usage** — Host-wide switch in Usage Settings, on by default. Turning it off stops login discovery and vendor requests on that host for every device. Usage shows an off state with **Turn on**; the sidebar summary and agent usage sections disappear.
|
||||||
- **Usage (sidebar item)** — The sidebar footer item showing each pinned window's source icon and percent, hidden while no pinned window has data (the footer's Usage icon remains available); both entry points open the Usage modal over the current screen: a dialog on wide layouts, a bottom sheet on compact ones. Usage has no route of its own. Off until the user turns on **Summary in sidebar** (Usage Settings) or the Usage row in Settings > Sidebar; window rows pin only while it is on, and saved pins come back when it is turned on again. A pin is `{ sourceId, windowId }` and shows once per account of that source. Pins and the used/remaining choice are one per-device preference (`AppSettings.usage`) that every usage surface follows. It reads the active workspace's host, else the first connected host with usage sources. Code: `packages/app/src/usage/sidebar-item.tsx`, `usage/usage-modal.tsx`, `usage/pinned.ts`, `usage/preferences.ts`.
|
- **Usage (sidebar item)** — The sidebar footer item showing each pinned window's source icon and percent, hidden while no pinned window has data (the footer's Usage icon remains available); both entry points open the Usage modal over the current screen: a dialog on wide layouts, a bottom sheet on compact ones. Usage has no route of its own. Off until the user turns on **Summary in sidebar** (Usage Settings) or the Usage row in Settings > Sidebar; window rows pin only while it is on, and saved pins come back when it is turned on again. A pin is `{ sourceId, windowId }` and shows once per account of that source. Pins and the used/remaining choice are one per-device preference (`AppSettings.usage`) that every usage surface follows. It reads the active workspace's host, else the first connected host with usage sources. Code: `packages/app/src/usage/sidebar-item.tsx`, `usage/usage-modal.tsx`, `usage/pinned.ts`, `usage/preferences.ts`.
|
||||||
- **Model** — A specific LLM offered by a provider. UI: "Model" / "Select model". Code: `AgentModelDefinition` (`packages/protocol/src/messages.ts:187`).
|
- **Model** — A specific LLM offered by a provider. UI: "Model" / "Select model". Code: `AgentModelDefinition` (`packages/protocol/src/messages.ts:187`).
|
||||||
- **Tab** — UI surface representing one session inside a workspace. Not a conceptual unit; use **Agent session** when talking about the model. Code: `WorkspaceTabDescriptor` (`packages/app/src/screens/workspace/workspace-tabs-types.ts`).
|
- **Tab** — UI surface representing one session inside a workspace. Not a conceptual unit; use **Agent session** when talking about the model. Code: `WorkspaceTabDescriptor` (`packages/app/src/screens/workspace/workspace-tabs-types.ts`).
|
||||||
|
|||||||
@@ -0,0 +1,86 @@
|
|||||||
|
# Keyboard shortcuts
|
||||||
|
|
||||||
|
Define shortcuts in [the shared binding table](../packages/app/src/keyboard/keyboard-shortcuts.ts). Platforms contribute key sources, not separate action maps, so matching and user rebinds stay consistent across runtimes. Add a shortcut through a binding; add platform support through a key source.
|
||||||
|
|
||||||
|
## Badges and routing
|
||||||
|
|
||||||
|
Routing runs whenever the app mounts its key sources, independently of layout.
|
||||||
|
Use `useHardwareKeyboardPresent()` for hints and the Shortcuts settings section.
|
||||||
|
iOS reads `GCKeyboard.coalesced` and connection notifications. Android watches input
|
||||||
|
devices and hardware keyboard configuration. Web starts with a fine hover pointer and recognizes the first modified
|
||||||
|
keydown, including on touch devices. Compact Electron keeps its bindings.
|
||||||
|
|
||||||
|
Keyboard navigation needs the sidebar's filtered workspace model even when its visual
|
||||||
|
panel is hidden. Retain that model while keyboard navigation is active; gating it on
|
||||||
|
panel visibility leaves number shortcuts with no targets after a compact startup.
|
||||||
|
|
||||||
|
Composer send-key customization remains a separate capability. Native retains its
|
||||||
|
existing Return submission path; advertising its web-only customization would expose
|
||||||
|
settings the native composer does not implement.
|
||||||
|
|
||||||
|
## Native sources
|
||||||
|
|
||||||
|
Use the iOS window press stream for hardware keys. `UIKeyCommand` only takes keys
|
||||||
|
that must bypass the focused text control: composer Return and the top overlay's
|
||||||
|
Enter and arrows. Keep the stream as the sole shortcut emitter: a command-owned
|
||||||
|
press is still observed by the window.
|
||||||
|
|
||||||
|
The source spike used an iPad Pro 11-inch (M4) simulator on iOS 18.6 with a
|
||||||
|
`UITextView` first responder. Both `UIWindow.sendEvent` and the root controller's
|
||||||
|
`pressesBegan` received Cmd+B, Cmd+P and Escape. With Escape registered as a
|
||||||
|
`UIKeyCommand`, the window observed it and the command handler also ran.
|
||||||
|
|
||||||
|
Simulator reserves Cmd+K for Toggle Software Keyboard. Injecting it produced
|
||||||
|
HID 184 with empty characters rather than K; plain K, Cmd+B and Cmd+P arrived
|
||||||
|
normally. Keep Simulator input capture off: Send Keyboard Input to Device
|
||||||
|
prevented synthetic AppleScript input from arriving, including plain text.
|
||||||
|
For simulator QA, use Cmd+B/P to check delivery and rebind the command center to
|
||||||
|
Cmd+J to check toggle and rebind behavior. Cmd+K delivery needs a physical iPad.
|
||||||
|
Simulator also reserves Cmd+1…4, Cmd+Shift+A and Cmd+comma. Exercise those actions
|
||||||
|
through rebinds. For numeric injection, use AppleScript physical key codes (for example
|
||||||
|
25 for 9); `keystroke "9"` did not deliver a digit in the QA session.
|
||||||
|
Simulator exposes a virtual `GCKeyboard` even with Connect Hardware Keyboard off.
|
||||||
|
Verify the iOS absence case on a physical iPhone.
|
||||||
|
|
||||||
|
Never register Backspace: it would take deletion away from text fields. Changes
|
||||||
|
to the native module require a native rebuild; an over-the-air JavaScript update
|
||||||
|
cannot deliver them.
|
||||||
|
|
||||||
|
## Overlay ownership
|
||||||
|
|
||||||
|
Register keyboard handling with `useOverlayRegistration` from `@/keyboard`.
|
||||||
|
Pass the surface's open state, layer, handled keys and `onKeyDown`. The highest
|
||||||
|
layer gets first refusal; the latest registration wins a tie. Native registration
|
||||||
|
does not need a DOM ref. Web adds focus trapping and restoration through its adapter.
|
||||||
|
|
||||||
|
Capture a global overlay’s layer in state for its opening lifetime. Memo caches can
|
||||||
|
be discarded or removed by React Compiler; recomputing against the registry lets an
|
||||||
|
open modal rise above its own children and creates competing focus traps.
|
||||||
|
|
||||||
|
Declare Enter and arrow keys only while the surface owns them. Native sources
|
||||||
|
use the top overlay's declarations to take those keys before text controls edit.
|
||||||
|
Backspace stays with the focused input. Composition confirmation must not select
|
||||||
|
an overlay row or submit the composer.
|
||||||
|
|
||||||
|
Android modals have their own windows. Observe them through React Native's
|
||||||
|
`ExtraWindowEventListener` as well as the activity window. The dev client bypasses
|
||||||
|
Expo's root-container handler, so an activity root-view wrapper misses presses.
|
||||||
|
A modal can forward an unhandled event into the activity window. Observe the event
|
||||||
|
once across that nested delivery without retaining recycled Android `KeyEvent`s.
|
||||||
|
Keep an overlay-owned press consumed through key-up, even if its key-down closes
|
||||||
|
the overlay; otherwise the modal's default Escape handler can close a second layer.
|
||||||
|
|
||||||
|
iOS scene startup installs the observing window after Expo creates its root view.
|
||||||
|
Keep that integration in the hardware keyboard module's config plugin. Its window
|
||||||
|
owns both the press stream and the text-control key commands, including above modals.
|
||||||
|
|
||||||
|
## Focus scopes
|
||||||
|
|
||||||
|
The composer and terminal declare focus with `useKeyboardFocusSurface`. Native
|
||||||
|
scope derives from those declarations and command-center state. Releasing an old
|
||||||
|
surface must not clear a newer owner's declaration during a tab switch. Web keeps
|
||||||
|
its DOM-derived scope.
|
||||||
|
|
||||||
|
Escape interrupts an agent only in the message input or an unclaimed surface.
|
||||||
|
A focused terminal excludes that binding. The source leaves terminal Escape alone;
|
||||||
|
terminal Escape/Ctrl forwarding is a separate feature.
|
||||||
@@ -10,9 +10,9 @@ Every block is separated by one gap, `density.blockGap`: 12 on compact layouts,
|
|||||||
|
|
||||||
## Links and images
|
## Links and images
|
||||||
|
|
||||||
Workspace file links use the shared file-link resolver. The workspace supplies its client, root and open-file action once; chat can supply the agent's more specific context. URLs use the same link press path. Recognized inline-code paths stay tappable. The library callback carries the tapped occurrence’s syntax context. Preserve it when opening files: explicit Markdown links decode URL escapes, while recognized inline-code paths preserve literal percent characters and use suffix lookup. Identical URL strings in different occurrences must stay distinct. Explicit absolute workspace links receive a relative hover title; existing authored titles remain intact.
|
Workspace file links use the shared file-link resolver. The workspace supplies its client, root and open-file action once; chat can supply the agent's more specific context. URLs use the same link press path. Recognized inline-code paths stay tappable. The library callback carries the tapped occurrence’s syntax context. Preserve it when opening files: explicit Markdown links decode URL escapes, while recognized inline-code paths preserve literal percent characters and use suffix lookup. Identical URL strings in different occurrences must stay distinct. Explicit absolute workspace links receive a relative hover title; existing authored titles remain intact. Inside a workspace, forge references such as `#12` and `owner/repo#12` are recognized in prose (not code) and open the workspace forge; the reference pattern comes before path recognition so `group/project#12` is not read as a path. See [forge providers](forge-providers.md#gotchas).
|
||||||
|
|
||||||
Resolve workspace image paths over the existing session RPC, then give the library a cached native file URL or web blob URL. HTTP(S) images pass through unchanged. This preserves relay, SSH and local socket connections, which do not expose a daemon HTTP endpoint. Each mounted renderer owns its image acquisition identity, so a later reply reads a rewritten path again while the earlier mounted reply retains its snapshot. Image taps open the attachment lightbox. File previews resolve relative images against the Markdown file's directory. An image alone on its line becomes its own paragraph before the library sees it, so it renders as a block on every platform; the library only treats sole-child paragraph images as blocks, and with hard soft breaks every newline is a break node, which left own-line images inline on iOS and web. Images that share a line with text stay inline.
|
Resolve workspace image paths over the existing session RPC, then give the library a cached native file URL or web blob URL. HTTP(S) images pass through unchanged. This preserves relay, SSH and local socket connections, which do not expose a daemon HTTP endpoint. Each mounted renderer owns its image acquisition identity, so a later reply reads a rewritten path again while the earlier mounted reply retains its snapshot. Image taps open the attachment lightbox. File previews resolve relative images against the Markdown file's directory. An image alone on its line becomes its own paragraph before the library sees it, so it renders as a block on every platform; the library only treats sole-child paragraph images as blocks, and with hard soft breaks every newline is a break node, which left own-line images inline on iOS and web. Images that share a line with text stay inline at line height and keep their aspect ratio. A linked image counts as an image, so review-bot badges such as `[](url) Confidence` stay inline on web; the library's web renderer only checked direct paragraph children, so it rendered them as full-width block images (local patch in `patches/react-native-enriched-markdown+*.patch`).
|
||||||
|
|
||||||
## Engine constraints
|
## Engine constraints
|
||||||
|
|
||||||
@@ -26,6 +26,8 @@ Native code blocks use the library's copy control and compiled grammars. Web cod
|
|||||||
|
|
||||||
The package patch also keeps overflowing native horizontal blocks in control of their drags: Android claims parent interception at touch-down and releases it for vertical drags so the chat list can scroll; iOS keeps its scroll recognizer active for outward drags at the leading edge. This prevents compact sidebar pans from taking block scrolling without changing sidebar swipes on prose or non-overflowing blocks. Native changes require a client rebuild.
|
The package patch also keeps overflowing native horizontal blocks in control of their drags: Android claims parent interception at touch-down and releases it for vertical drags so the chat list can scroll; iOS keeps its scroll recognizer active for outward drags at the leading edge. This prevents compact sidebar pans from taking block scrolling without changing sidebar swipes on prose or non-overflowing blocks. Native changes require a client rebuild.
|
||||||
|
|
||||||
|
On iOS a newly mounted Markdown view paints empty for a frame or more after it is laid out at its measured height: the library parses even a view's first content on a background queue and applies it in a later main-queue turn. Expanding a turn in chat therefore shows its rows in place with the text arriving a frame later (165 ms when the mount keeps the main thread busy). Android paints the text in the first frame. Rendering a view's first content synchronously fixes the frame but costs frame time when a fling mounts history rows, so the app keeps the library's behavior until [enriched-markdown #1131](https://github.com/software-mansion/enriched-markdown/issues/1131) is resolved.
|
||||||
|
|
||||||
Android measurements use a size-only, 512-entry LRU across view unmounts, matching the library’s existing iOS cache. Scrolling back through history can reuse layout sizes without parsing those rows again. Content, layout props and width identify each entry; font-scale changes and native layout invalidation discard affected sizes. The cache retains no views or spans.
|
Android measurements use a size-only, 512-entry LRU across view unmounts, matching the library’s existing iOS cache. Scrolling back through history can reuse layout sizes without parsing those rows again. Content, layout props and width identify each entry; font-scale changes and native layout invalidation discard affected sizes. The cache retains no views or spans.
|
||||||
|
|
||||||
The library determines how incomplete Markdown appears during streaming. Completed text uses the same component and engine as history. Find and scroll-to-message address source message ids; selection-copy understands semantic HTML and the web code component's copy metadata.
|
The library determines how incomplete Markdown appears during streaming. Completed text uses the same component and engine as history. Find and scroll-to-message address source message ids; selection-copy understands semantic HTML and the web code component's copy metadata.
|
||||||
|
|||||||
+39
-10
@@ -9,6 +9,10 @@ Compact layouts have three mutually exclusive destinations:
|
|||||||
They are one interaction, not two independent drawers. The implementation lives in
|
They are one interaction, not two independent drawers. The implementation lives in
|
||||||
`packages/app/src/mobile-panels/`.
|
`packages/app/src/mobile-panels/`.
|
||||||
|
|
||||||
|
Wide layouts reuse `agent-list` for the navigation overlay. When the left dock is collapsed or
|
||||||
|
yields its width, a touch swipe reveals the same sidebar over the workspace at the resolved sidebar
|
||||||
|
width. The workspace does not move, and the saved dock preference does not change.
|
||||||
|
|
||||||
## Ownership
|
## Ownership
|
||||||
|
|
||||||
React/Zustand owns the durable intent:
|
React/Zustand owns the durable intent:
|
||||||
@@ -23,6 +27,12 @@ interface MobilePanelSelection {
|
|||||||
Every semantic target change increments `revision`. Repeating the current target is idempotent.
|
Every semantic target change increments `revision`. Repeating the current target is idempotent.
|
||||||
Compact panel selection is not persisted; a cold start begins at `agent`.
|
Compact panel selection is not persisted; a cold start begins at `agent`.
|
||||||
|
|
||||||
|
Only an overlay sidebar holds `agent-list`, and only a compact layout holds `file-explorer`. App
|
||||||
|
chrome publishes the layout (compact or wide, and the left sidebar presentation `overlay`, `dock`, or
|
||||||
|
`hidden`) to `panel-store`, which drops any target the layout does not present. A stale
|
||||||
|
`agent-list` would reopen the overlay on the next collapse; a stale `file-explorer` after widening
|
||||||
|
would block the navigation swipe, which begins only from `agent`.
|
||||||
|
|
||||||
The UI worklet owns transient motion:
|
The UI worklet owns transient motion:
|
||||||
|
|
||||||
- one normalized position (`-1` left, `0` center, `1` right)
|
- one normalized position (`-1` left, `0` center, `1` right)
|
||||||
@@ -32,8 +42,10 @@ The UI worklet owns transient motion:
|
|||||||
|
|
||||||
React publishes the active panel only when the canonical target and the UI-thread position agree at
|
React publishes the active panel only when the canonical target and the UI-thread position agree at
|
||||||
the final anchor. Retained content never observes gesture previews, progress, or an unsettled target.
|
the final anchor. Retained content never observes gesture previews, progress, or an unsettled target.
|
||||||
The gesture hosts stay mounted. The Gesture Handler web patch keeps initially disabled hosts
|
The gesture hosts stay mounted. A pointer capture on a paragraph confines browser selection to that
|
||||||
from capturing paragraph pointers; that capture confines browser selection to its starting paragraph.
|
paragraph, so the Gesture Handler web patch keeps it off: initially disabled hosts register no
|
||||||
|
pointer listeners, and an enabled host captures only a pointer its handler still tracks after
|
||||||
|
pointer-down. The touch-only navigation pans fail a mouse at pointer-down and never capture it.
|
||||||
Native worklets own overlay opacity and pointer events while
|
Native worklets own overlay opacity and pointer events while
|
||||||
React owns settled panel activity and accessibility. Keep hidden native overlays laid out: collapsing
|
React owns settled panel activity and accessibility. Keep hidden native overlays laid out: collapsing
|
||||||
their scroll ranges makes Android spring retained offsets back to zero during touch cancellation or
|
their scroll ranges makes Android spring retained offsets back to zero during touch cancellation or
|
||||||
@@ -43,8 +55,11 @@ appearance keys; see [Unistyles appearance boundaries](unistyles.md#runtime-them
|
|||||||
|
|
||||||
## Why one position
|
## Why one position
|
||||||
|
|
||||||
Both transforms and both backdrop opacities are derived from the same normalized position. Window
|
Both transforms and both backdrop opacities are derived from the same normalized position. Panel
|
||||||
width is only a projection input. Rotation changes the projection, not the panel state.
|
width is only a projection input: the window width on the right, and on the left the width
|
||||||
|
`MobilePanelsProvider` resolves (the full window on compact layouts, the saved sidebar width
|
||||||
|
clamped to the viewport on wide ones). The dock, the overlay, and their gestures read that one
|
||||||
|
value. Rotation changes the projection, not the panel state.
|
||||||
|
|
||||||
This makes these invalid states unrepresentable:
|
This makes these invalid states unrepresentable:
|
||||||
|
|
||||||
@@ -62,7 +77,9 @@ A gesture captures the current revision when it becomes active. Per-frame update
|
|||||||
while that revision still owns the gesture.
|
while that revision still owns the gesture.
|
||||||
|
|
||||||
When a React command arrives during a drag, its newer revision clears gesture ownership and starts
|
When a React command arrives during a drag, its newer revision clears gesture ownership and starts
|
||||||
motion toward the new target. The older gesture's remaining updates and finish callback are ignored.
|
motion toward its target, even an unchanged one: docking mid-swipe keeps `agent` and still returns
|
||||||
|
the dragged position to its anchor. The older gesture's remaining updates and finish callback are
|
||||||
|
ignored.
|
||||||
Canceled gestures return to the latest canonical target. A successful gesture starts its finishing
|
Canceled gestures return to the latest canonical target. A successful gesture starts its finishing
|
||||||
motion immediately; the matching React command adopts that motion instead of restarting it. Position
|
motion immediately; the matching React command adopts that motion instead of restarting it. Position
|
||||||
settlement and command acceptance may arrive in either order. Activity changes after both agree on
|
settlement and command acceptance may arrive in either order. Activity changes after both agree on
|
||||||
@@ -80,6 +97,12 @@ definition, no longer eligible to begin.
|
|||||||
|
|
||||||
- Callers request semantic targets through `panel-store`; they never write shared values.
|
- Callers request semantic targets through `panel-store`; they never write shared values.
|
||||||
- Gesture behavior comes from the four explicit hooks in `mobile-panels/gestures.ts`.
|
- Gesture behavior comes from the four explicit hooks in `mobile-panels/gestures.ts`.
|
||||||
|
- Navigation gestures accept touch pointers only. Mouse and pen fail at touch-down, so dragging a
|
||||||
|
mouse to select text on a hybrid laptop never moves a panel. Browsers without a touch screen
|
||||||
|
(`hooks/pointer-capabilities`) never enable them.
|
||||||
|
- Phone web opens a drawer only from the 32px edge it slides in from, so interior swipes stay with
|
||||||
|
terminals, code blocks, and diff scrollers. Native drawers and the wide overlay open from anywhere.
|
||||||
|
Horizontal-scroll ownership and the open-gesture blocker still take precedence.
|
||||||
- A focused interactive surface may block panel-opening gestures through
|
- A focused interactive surface may block panel-opening gestures through
|
||||||
`useBlockMobilePanelOpenGestures`. Register only while the conflicting interaction is active and
|
`useBlockMobilePanelOpenGestures`. Register only while the conflicting interaction is active and
|
||||||
unregister when the surface is hidden or unfocused. The blocker never disables gestures that close
|
unregister when the surface is hidden or unfocused. The blocker never disables gestures that close
|
||||||
@@ -87,11 +110,17 @@ definition, no longer eligible to begin.
|
|||||||
- Keep `SidebarModelProvider` outside `MobileGestureWrapper`. The provider shares sidebar derivation
|
- Keep `SidebarModelProvider` outside `MobileGestureWrapper`. The provider shares sidebar derivation
|
||||||
across consumers, while Gesture Handler requires the wrapper's direct child to be a native `View`
|
across consumers, while Gesture Handler requires the wrapper's direct child to be a native `View`
|
||||||
so its injected `collapsable={false}` reaches Android/Fabric.
|
so its injected `collapsable={false}` reaches Android/Fabric.
|
||||||
- Mobile sidebars render through `MobilePanelOverlay`; do not duplicate overlay lifecycle or motion
|
- Sidebars render through `MobilePanelOverlay`; do not duplicate overlay lifecycle or motion styles
|
||||||
styles in sidebar components.
|
in sidebar components. The wide left sidebar keeps the same content and gesture hosts when switching
|
||||||
- The desktop left sidebar is retained too. App chrome owns separate mounted and visible decisions:
|
between dock and overlay. App chrome owns mounting and presentation; settled panel activity owns
|
||||||
closing it or yielding its width marks it inactive and applies `display: none` without conditionally
|
overlay work. A hidden dock is inactive with `display: none`; the sidebar tree stays mounted. Keep
|
||||||
removing the sidebar tree.
|
the native overlay laid out while hidden, as on compact layouts. Give the switching host no
|
||||||
|
Reanimated layout props: a width keyed on the presentation reaches Android after React commits the
|
||||||
|
switch, and a lost update left the workspace at the dock width. The dock sizes to its content and
|
||||||
|
the overlay host fills the window.
|
||||||
|
- The overlay's backdrop covers the whole window; safe-area padding applies to the sidebar and
|
||||||
|
workspace content only. It closes by swiping back, tapping the backdrop, or picking a destination:
|
||||||
|
every sidebar destination closes the overlay before it navigates.
|
||||||
- Animated panel nodes use React Native static styles plus inline theme values. Do not attach
|
- Animated panel nodes use React Native static styles plus inline theme values. Do not attach
|
||||||
Unistyles-generated styles to those nodes; Unistyles and Reanimated patching the same Fabric node
|
Unistyles-generated styles to those nodes; Unistyles and Reanimated patching the same Fabric node
|
||||||
has caused native crashes.
|
has caused native crashes.
|
||||||
|
|||||||
+15
-10
@@ -35,6 +35,20 @@ PASEO_MOBILE_E2E_METRO_PORT=62093 npm run test:e2e:mobile
|
|||||||
|
|
||||||
[native-terminal-basic.ios.ad](../packages/app/e2e/mobile/agent-device/native-terminal-basic.ios.ad) and [native-terminal-basic.android.ad](../packages/app/e2e/mobile/agent-device/native-terminal-basic.android.ad) are the smallest examples. Each opens a fresh terminal, types a command at zero delay, submits it, and asserts its distinct output. The app must be connected to a daemon with an active workspace.
|
[native-terminal-basic.ios.ad](../packages/app/e2e/mobile/agent-device/native-terminal-basic.ios.ad) and [native-terminal-basic.android.ad](../packages/app/e2e/mobile/agent-device/native-terminal-basic.android.ad) are the smallest examples. Each opens a fresh terminal, types a command at zero delay, submits it, and asserts its distinct output. The app must be connected to a daemon with an active workspace.
|
||||||
|
|
||||||
|
For Android background fold recovery, install the release APK on a foldable AVD, open a
|
||||||
|
connected workspace, close the keyboard, and run:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
ANDROID_SERIAL=emulator-5574 node packages/app/e2e/mobile/fold/android.mjs
|
||||||
|
```
|
||||||
|
|
||||||
|
The AVD must expose `CLOSED` and `OPENED` device states. The test backgrounds the app,
|
||||||
|
changes posture, resumes immediately, and asserts compact/wide workspace controls without
|
||||||
|
restarting the process. It writes snapshots and native failure state under
|
||||||
|
`.dev/agent-device-artifacts/android-fold`. Set `PASEO_MOBILE_APP_ID=sh.paseo` for a
|
||||||
|
production package. This needs a native rebuild when the Unistyles patch changes; a Metro
|
||||||
|
reload cannot update it.
|
||||||
|
|
||||||
For Android keyboard continuity, run the current checkout in the app, open an idle terminal
|
For Android keyboard continuity, run the current checkout in the app, open an idle terminal
|
||||||
with an empty prompt, hide its keyboard, and run:
|
with an empty prompt, hide its keyboard, and run:
|
||||||
|
|
||||||
@@ -438,18 +452,9 @@ Regular `View` components can safely use Unistyles dynamic styles — the confli
|
|||||||
|
|
||||||
## Native Chat Stream Layout
|
## Native Chat Stream Layout
|
||||||
|
|
||||||
The native agent stream uses an inverted `FlatList`, so chat layout has three coordinate systems:
|
|
||||||
|
|
||||||
- chronological stream order
|
|
||||||
- strategy-ordered array order
|
|
||||||
- native inverted cell visual order
|
|
||||||
|
|
||||||
Do not compute stream neighbors, history/live-head seams, turn footer ownership, assistant block spacing, or tool sequence endings inside React render loops. Those policies live in `packages/app/src/agent-stream/layout.ts` and are unit-tested without React Native rendering.
|
Do not compute stream neighbors, history/live-head seams, turn footer ownership, assistant block spacing, or tool sequence endings inside React render loops. Those policies live in `packages/app/src/agent-stream/layout.ts` and are unit-tested without React Native rendering.
|
||||||
|
|
||||||
Platform-specific stream edges belong on `StreamStrategy`:
|
Platform-specific stream edges belong on `StreamStrategy`. Web and native both render in chronological order, so both use the last history item as the history/live-head boundary and render content before a footer.
|
||||||
|
|
||||||
- forward web uses the last history item as the history/live-head boundary and renders content before a footer
|
|
||||||
- native inverted uses the first history item as the history/live-head boundary and compensates for inverted cell child order
|
|
||||||
|
|
||||||
If a chat footer looks duplicated or appears above the assistant message on mobile, start with `packages/app/src/agent-stream/layout.test.ts`. Do not add a React Native renderer test for this class of bug; make the pure layout invariant fail first.
|
If a chat footer looks duplicated or appears above the assistant message on mobile, start with `packages/app/src/agent-stream/layout.test.ts`. Do not add a React Native renderer test for this class of bug; make the pure layout invariant fail first.
|
||||||
|
|
||||||
|
|||||||
@@ -2,15 +2,6 @@
|
|||||||
|
|
||||||
Keep completed assistant prose in one native text view so selection crosses paragraphs, headings and lists. The shared [Markdown renderer](markdown-renderer.md) owns that view.
|
Keep completed assistant prose in one native text view so selection crosses paragraphs, headings and lists. The shared [Markdown renderer](markdown-renderer.md) owns that view.
|
||||||
|
|
||||||
## Android inverted chat
|
|
||||||
|
|
||||||
Keep selection visibility handling in `modules/paseo-scroll`. Android's visibility
|
|
||||||
rectangles ignore list inversion. React Native decomposes Android's `scale: -1`
|
|
||||||
into rotation with positive `scaleY`, so test the composed matrix when deciding
|
|
||||||
whether those requests should move the viewport. Native tests must apply the
|
|
||||||
list's transform through React Native's view manager; assigning `scaleY` directly
|
|
||||||
misses that decomposition.
|
|
||||||
|
|
||||||
## Diagrams in lists and quotes
|
## Diagrams in lists and quotes
|
||||||
|
|
||||||
Selection stops at a Mermaid diagram. Native extracts Mermaid fences into separate views because the library exposes no native block renderer override. A diagram inside a list or quote therefore appears outside that container, and its following prose starts a separate Markdown fragment.
|
Selection stops at a Mermaid diagram. Native extracts Mermaid fences into separate views because the library exposes no native block renderer override. A diagram inside a list or quote therefore appears outside that container, and its following prose starts a separate Markdown fragment.
|
||||||
|
|||||||
+22
-4
@@ -357,9 +357,27 @@ keys are stored under a `param.` prefix; plugins never see it and may use any ke
|
|||||||
`openScreen` validates its input once (`parsePluginOpenScreenInput`); code past it trusts the
|
`openScreen` validates its input once (`parsePluginOpenScreenInput`); code past it trusts the
|
||||||
params.
|
params.
|
||||||
|
|
||||||
RPC contracts validate inputs and outputs in both the app and plugin subprocess. `useRpc` returns a
|
RPC and subscription contracts validate inputs, outputs, and events in both the app and plugin
|
||||||
typed async function. Use the host-provided `@tanstack/react-query` for request state and caching;
|
subprocess. `useRpc` returns a typed async function. Use the host-provided `@tanstack/react-query`
|
||||||
Paseo gives each plugin installation its own query client.
|
for request state and caching; Paseo gives each plugin installation its own query client.
|
||||||
|
|
||||||
|
A subscription is a session-owned observation (`plugin-rpc` delivery family): the session that
|
||||||
|
subscribed owns its lifetime, so release, disconnect, plugin stop, and reload need no plugin code.
|
||||||
|
Each subscriber gets its own handler call in the subprocess; there is no fan-out or replay. The
|
||||||
|
runtime buffers pushes until the session has sent `plugin.rpc.subscribe.response`, so a client
|
||||||
|
never sees an event for an unknown subscription. The app installation's lifetime aborts every
|
||||||
|
subscription its surfaces left open, and a reload replaces the installation, which resubscribes
|
||||||
|
mounted hooks.
|
||||||
|
|
||||||
|
The byte rule (a top-level `Uint8Array` is binary, a nested one is a validation error) is checked
|
||||||
|
once per hop by `assertPluginWireValue`. Bytes ride plugin binary frames, opcodes `0x20`-`0x2f`
|
||||||
|
(`packages/protocol/src/binary-frames/plugin.ts`); nothing on the path copies or re-encodes them,
|
||||||
|
and `plugin-subscriptions.perf.e2e.test.ts` locks that. Keep it that way: never stringify a plugin
|
||||||
|
payload for a log, and the client's bootstrap buffer holds bytes only until the first observer
|
||||||
|
attaches. Binary outputs reach only clients that send `pluginBinaryPayloads`. A binary input
|
||||||
|
frame (`0x22`) becomes a synthetic `plugin.rpc.invoke.request` and runs through the normal message
|
||||||
|
path, so it is authorized like any other invoke. The author contract, including the native upload
|
||||||
|
limit, is in [stream events from the daemon](../public-docs/plugins/reference.md#subscriptions).
|
||||||
|
|
||||||
`usePaseo()` and the handler's `{ paseo }` context expose the same `PaseoApi`: projects,
|
`usePaseo()` and the handler's `{ paseo }` context expose the same `PaseoApi`: projects,
|
||||||
workspaces, agents, terminals, providers, and daemon config. They do not expose connection lifecycle.
|
workspaces, agents, terminals, providers, and daemon config. They do not expose connection lifecycle.
|
||||||
@@ -550,7 +568,7 @@ string is never inline SVG or a URL.
|
|||||||
|
|
||||||
Register a usage source from `index.server.ts` with `server.registerUsageSource()`. Import `UsageSourceRegistration` and normalization helpers from `@getpaseo/plugin/server/usage`. The plugin owns account discovery, harness labels, and credential-store reads; the daemon owns account grouping and the fetch cache. Agent popovers use only the agent's own login. The host-wide Usage modal falls back across an account's logins; any success shows usage only, and all failures show every login's labeled error and remedy. Follow the [usage source discovery contract](../public-docs/plugins/reference.md#usage-sources). The resolved launch environment crosses into the trusted, unsandboxed plugin subprocess for session discovery. Usage queries never run lifecycle hooks. Inputs are validated in the plugin process and remain daemon-side. `icon` uses the same SVG file rules as provider icons.
|
Register a usage source from `index.server.ts` with `server.registerUsageSource()`. Import `UsageSourceRegistration` and normalization helpers from `@getpaseo/plugin/server/usage`. The plugin owns account discovery, harness labels, and credential-store reads; the daemon owns account grouping and the fetch cache. Agent popovers use only the agent's own login. The host-wide Usage modal falls back across an account's logins; any success shows usage only, and all failures show every login's labeled error and remedy. Follow the [usage source discovery contract](../public-docs/plugins/reference.md#usage-sources). The resolved launch environment crosses into the trusted, unsandboxed plugin subprocess for session discovery. Usage queries never run lifecycle hooks. Inputs are validated in the plugin process and remain daemon-side. `icon` uses the same SVG file rules as provider icons.
|
||||||
|
|
||||||
The daemon calls discovery for `usage.list_reports`; the client gates this RPC on `server_info.features.usageSources`. The old `provider.usage.list` RPC maps discovered reports for older clients.
|
When the host’s **Check usage** switch is off, the daemon rejects usage requests before discovery, without reading logins or calling vendors. Otherwise, the daemon calls discovery for `usage.list_reports`; the client gates this RPC on `server_info.features.usageSources`. The old `provider.usage.list` RPC maps discovered reports for older clients.
|
||||||
|
|
||||||
## Contribute sidebar items
|
## Contribute sidebar items
|
||||||
|
|
||||||
|
|||||||
@@ -52,6 +52,47 @@ On capable daemons, connecting creates no timeline or event demand. Client subsc
|
|||||||
release it on unsubscribe, and restore it after reconnect. Raw message observers inspect traffic
|
release it on unsubscribe, and restore it after reconnect. Raw message observers inspect traffic
|
||||||
without requesting streams. Application caches and which agents are visible remain caller-owned.
|
without requesting streams. Application caches and which agents are visible remain caller-owned.
|
||||||
|
|
||||||
|
## Terminal ANSI replay
|
||||||
|
|
||||||
|
Terminal replay intentionally drops JSON-era apps, an exception to the general cross-version policy:
|
||||||
|
use app v0.1.81 or newer. Earlier apps omit `restore` and reject ANSI Restore (`0x05`), so they show
|
||||||
|
only subsequent live output, without the existing screen or history.
|
||||||
|
|
||||||
|
`terminal_chunked_replay` is SDK-owned delivery behavior. The daemon sends new binary opcodes only to a source
|
||||||
|
advertising the capability. The SDK keeps the established subscribe request against older
|
||||||
|
ANSI hosts and normalizes their single Restore frame into begin/data/end. `observeTerminal` defaults
|
||||||
|
to an explicit full snapshot: omitting restore on an ANSI-era host selects its discarded JSON path.
|
||||||
|
Explicit caller restore modes and history counts pass through unchanged. JSON snapshot
|
||||||
|
wire declarations remain accepted, but JSON snapshot frames have no rendering runtime.
|
||||||
|
Terminals require `terminal-restore-modes`; older hosts show an update message without attaching.
|
||||||
|
|
||||||
|
## Binary chunking
|
||||||
|
|
||||||
|
`binary_chunking_v1` in hello and optional `server_info.features.binaryChunkingV1`
|
||||||
|
negotiate connection-scoped framing. Application serializers and routed envelopes use
|
||||||
|
the same boundary. Small messages and handshakes keep their existing representation.
|
||||||
|
Older peers retain existing frame limits.
|
||||||
|
|
||||||
|
The reserved binary opcode `0x31` is followed by version `1`, original kind
|
||||||
|
(`0` text, `1` binary), and START/END flag bits `0`/`1`. Remaining bytes are an
|
||||||
|
unchanged slice. There is no total length or chunk count; a future receiver can
|
||||||
|
consume slices incrementally. Today the receiver buffers up to the existing
|
||||||
|
100 MiB logical limit and decodes UTF-8 only after END. Transfers cannot interleave.
|
||||||
|
Disconnect clears partial state and negotiation.
|
||||||
|
|
||||||
|
The lower transport supplies its plaintext frame budget, including encryption
|
||||||
|
overhead. The sender waits for drain between chunks while ordinary messages keep
|
||||||
|
the existing delivery path. Slow-client protections count messages queued behind
|
||||||
|
an active transfer as well as bytes already in the socket.
|
||||||
|
The framing module never selects an encryption construction.
|
||||||
|
|
||||||
|
Native uploads retain the platform's existing queue limits. React Native's
|
||||||
|
WebSocket does not report its queued bytes, so the client cannot wait for native
|
||||||
|
drain. Android's installed OkHttp transport closes when a send would put more
|
||||||
|
than 16 MiB in its queue. The native transport disables outbound chunking, including
|
||||||
|
on routed channels, and retains its existing single-frame admission errors.
|
||||||
|
Inbound chunking remains enabled; daemon-to-native responses use the daemon's paced writes.
|
||||||
|
|
||||||
## Owned observations
|
## Owned observations
|
||||||
|
|
||||||
`owned_subscriptions` and `server_info.features.ownedSubscriptions` negotiate the source-owned
|
`owned_subscriptions` and `server_info.features.ownedSubscriptions` negotiate the source-owned
|
||||||
|
|||||||
+3
-1
@@ -89,7 +89,7 @@ OMP supports native Paseo host tools. The adapter registers the full caller-scop
|
|||||||
|
|
||||||
Pi RPC extension UI dialog requests (`select`, `input`, `editor`, `confirm`) are bridged into Paseo question permissions and answered with `extension_ui_response`. Pi extensions such as `ask_user` may chain dialogs: for example, a `select` can be followed by an optional-comment `input`. When an `ask_user` tool call declares `allowComment: true`, Paseo presents the selection and optional comment as one question permission, answers Pi's initial `select` immediately, then auto-answers the follow-up optional `input` with the comment the user already supplied (or an empty string). Preserve placeholders and optional/skip semantics for standalone optional inputs so the app can still distinguish "skip this optional input" from "cancel the whole dialog." Fire-and-forget extension UI requests such as notifications are intentionally ignored by the provider adapter unless Paseo grows first-class UI for them.
|
Pi RPC extension UI dialog requests (`select`, `input`, `editor`, `confirm`) are bridged into Paseo question permissions and answered with `extension_ui_response`. Pi extensions such as `ask_user` may chain dialogs: for example, a `select` can be followed by an optional-comment `input`. When an `ask_user` tool call declares `allowComment: true`, Paseo presents the selection and optional comment as one question permission, answers Pi's initial `select` immediately, then auto-answers the follow-up optional `input` with the comment the user already supplied (or an empty string). Preserve placeholders and optional/skip semantics for standalone optional inputs so the app can still distinguish "skip this optional input" from "cancel the whole dialog." Fire-and-forget extension UI requests such as notifications are intentionally ignored by the provider adapter unless Paseo grows first-class UI for them.
|
||||||
|
|
||||||
OpenCode adapters target v1.14.46 and v2.0.10. V2 rejects binaries older than the tested 2.0.10 SDK at runtime selection. Runtime selection uses the configured command and environment. A recognized version is cached until provider configuration reload; a failed, timed-out, or unrecognized probe retains the v1 path and retries detection on the next operation. Load v2 code and materialize its plugin only after positive v2 selection; v1 sessions remain undecorated. Keep upstream SDK types inside the version-specific adapter. OpenCode owns storage migration; a missing native session must fail resume rather than create a replacement. V2 has no native archive/unarchive operation: archiving affects Paseo only. V1 retains native archiving.
|
OpenCode adapters target v1.14.46 and v2.0.10. V2 rejects versions older than 2.0.10. Paseo selects an explicit server, then a healthy local registered service, then its own helper. It never stops a reused service. A local service loads the Paseo bridge from its watched plugin directory; sessions bind their own bridge credentials through OpenCode RPC. See [OpenCode with an existing v2 server](custom-providers.md#opencode-with-an-existing-v2-server) for setup and isolation limits. Load v2 code and materialize its plugin only after positive v2 selection; v1 sessions remain undecorated. Keep upstream SDK types inside the version-specific adapter. OpenCode owns storage migration; a missing native session must fail resume rather than create a replacement. V2 has no native archive/unarchive operation: archiving affects Paseo only. V1 retains native archiving.
|
||||||
|
|
||||||
Use OpenCode v2 execution events to trigger turn completion, with active-state and durable-log reconciliation after admission, reconnect, and while a turn remains active. Do not use `session.wait`: a healthy turn exceeding Node's HTTP headers deadline produces a transport error while OpenCode keeps working. The live event feed has no replay, and shutdown interruption preserves the previous idle outcome, so the session snapshot alone cannot recover missed execution events. Quiet streams are healthy: v2 heartbeats are SSE comments, not application events.
|
Use OpenCode v2 execution events to trigger turn completion, with active-state and durable-log reconciliation after admission, reconnect, and while a turn remains active. Do not use `session.wait`: a healthy turn exceeding Node's HTTP headers deadline produces a transport error while OpenCode keeps working. The live event feed has no replay, and shutdown interruption preserves the previous idle outcome, so the session snapshot alone cannot recover missed execution events. Quiet streams are healthy: v2 heartbeats are SSE comments, not application events.
|
||||||
|
|
||||||
@@ -507,6 +507,8 @@ interface AgentSession {
|
|||||||
}
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
|
`describePersistence()` returns a handle only once a new provider process could resume it. Reload, idle runtime collection and daemon restart resume whatever handle the agent stored; a stored agent without one starts a new session instead. When there is no handle, `AgentManager` stores `getRuntimeInfo().sessionId` as one, so that ID follows the same rule. Codex, for example, starts a thread when the agent is created but writes its rollout only at its first turn, and `thread/resume` fails for it until then, so its adapter reports neither ID before Codex announces that turn.
|
||||||
|
|
||||||
`setMode` and `setThinkingOption` may return an `AgentProviderNotice` when the provider knows the change needs user-facing context. For example, providers that stage changes until the next turn should return an `info` notice while a turn is already running. The app renders the notice generically as a toast; provider-specific lifecycle behavior stays in the provider implementation.
|
`setMode` and `setThinkingOption` may return an `AgentProviderNotice` when the provider knows the change needs user-facing context. For example, providers that stage changes until the next turn should return an `info` notice while a turn is already running. The app renders the notice generically as a toast; provider-specific lifecycle behavior stays in the provider implementation.
|
||||||
|
|
||||||
### Steps
|
### Steps
|
||||||
|
|||||||
@@ -6,9 +6,9 @@ How terminal output stays low-latency, what the invariants are, and how to measu
|
|||||||
|
|
||||||
```
|
```
|
||||||
pty (node-pty, forked worker process)
|
pty (node-pty, forked worker process)
|
||||||
→ headless xterm parse (worker, snapshot fidelity)
|
→ headless xterm parse (worker, ANSI replay fidelity)
|
||||||
→ TerminalOutputCoalescer (worker, ≤1 IPC message per 5ms per terminal)
|
→ TerminalOutputCoalescer (worker, ≤1 socket frame per 5ms per terminal)
|
||||||
→ process.send IPC → daemon main process
|
→ framed local socket → daemon main process
|
||||||
→ TerminalOutputCoalescer (per client stream, terminal-session-controller.ts)
|
→ TerminalOutputCoalescer (per client stream, terminal-session-controller.ts)
|
||||||
→ binary ws frame (2-byte header + raw bytes)
|
→ binary ws frame (2-byte header + raw bytes)
|
||||||
→ client decode (daemon-client.ts) → stream router → emulator runtime
|
→ client decode (daemon-client.ts) → stream router → emulator runtime
|
||||||
@@ -19,11 +19,15 @@ Terminal frames share the daemon main event loop with all agent traffic. The `ev
|
|||||||
|
|
||||||
## Invariants (the easy-to-break ones)
|
## Invariants (the easy-to-break ones)
|
||||||
|
|
||||||
|
- **Replay is incremental across the daemon and SDK.** Capable clients request their configured history, bounded by [worker retention](terminal-worker.md#process-model). Older apps retain their own 200-row request. Explicit SDK history demand is unchanged against older ANSI hosts, which apply their existing 500-row ceiling. Begin resets once, chunks keep a streaming UTF-8 decoder/parser, and each renderer suppresses generated replies while parsing replay. Never concatenate capable replay chunks to feed the renderer.
|
||||||
|
- **Replay serialization reads xterm directly.** The [worker](terminal-worker.md#process-model) uses its existing buffer; text capture translates only the requested rows, and readiness scans row strings. Do not rebuild a full cell-object grid. Serialization still allocates a whole ANSI string and UTF-8 bytes before bounded delivery; chunking does not bound those allocations.
|
||||||
- **Coalescers are leading+trailing throttles.** The first chunk after an idle window flushes immediately (synchronously); only sustained bursts wait for the trailing timer. Reverting to trailing-only adds a full window (~5ms) to every keystroke echo.
|
- **Coalescers are leading+trailing throttles.** The first chunk after an idle window flushes immediately (synchronously); only sustained bursts wait for the trailing timer. Reverting to trailing-only adds a full window (~5ms) to every keystroke echo.
|
||||||
- **Output coalescing happens in the worker, before IPC.** One `process.send` per pty chunk was a main-loop flood under build output. Non-output messages (snapshot/snapshotReady/titleChange/exit) must flush the coalescer first so ordering is preserved.
|
- **Output coalescing happens in the worker, before IPC.** One socket frame per pty chunk was a main-loop flood under build output. Non-output messages (snapshotReady/titleChange/exit) must flush the coalescer first so ordering is preserved.
|
||||||
|
- **Replay delivery is isolated per viewer.** Live worker output never waits for app delivery. Each daemon stream owns its bounded live tail and revision deduplication; a slow or failed replay cannot pause another viewer of the same terminal.
|
||||||
|
- **Replay geometry belongs to the parser queue.** Native measurements and web fits must leave the captured dimensions intact through every chunk's commit. Apply the latest measured size after replay, before live bytes; clear, replacement and disposal must release that geometry ownership. A layout effect must not resize the renderer directly during replay.
|
||||||
- **Coalesced output carries the LAST chunk's revision.** Snapshot replay dedup (`replayTerminalOutputAfterSnapshot`) skips buffered output with `revision <= replayRevision`; a merged batch with a lower revision would be wrongly skipped (lost output).
|
- **Coalesced output carries the LAST chunk's revision.** Snapshot replay dedup (`replayTerminalOutputAfterSnapshot`) skips buffered output with `revision <= replayRevision`; a merged batch with a lower revision would be wrongly skipped (lost output).
|
||||||
- **The input-mode tracker runs once per process boundary, not per hop.** The worker owns the authoritative tracker; the daemon caches the replay preamble from `getTerminalState` responses and `snapshotReady` messages. Do not reintroduce a per-chunk `feed()` on the daemon main loop.
|
- **The input-mode tracker runs once per process boundary, not per hop.** The worker commits its authoritative tracker with xterm parsing before publishing the corresponding revision; the daemon caches current modes from ordered worker events and adoption. A replay response carries capture-time modes for its viewer; it must not overwrite the shared cache after newer live output. Apply that viewer's preamble before its buffered live bytes. Do not reintroduce a per-chunk `feed()` on the daemon main loop.
|
||||||
- **Snapshot catch-up is backpressure-gated.** A stream falls back to a full snapshot only when `outputBytesSinceSnapshot > MAX_TERMINAL_OUTPUT_FRAME_BYTES` (256KB) **and** the client transport reports `bufferedAmount > MAX_CLIENT_BUFFERED_BYTES` (4MB). A client that keeps draining streams continuously, no matter how much output is produced. Before this gate existed, every 256KB of build output dropped a frame and forced a full JSON cell-grid snapshot (~200k objects across IPC) — the historical source of spiky lag and GC hitches.
|
- **Snapshot catch-up is backpressure-gated.** After more than 256 KiB of output, a stream catches up only when its transport reports more than 4 MiB queued, or exposes no backpressure reading. A draining client streams continuously. Pressure recovery sends at most 500 recent history rows plus the screen, preserving smaller explicit demands including zero; even a live-only subscription needs this resynchronization. It does not change the subscription's configured demand: later attach/reconnect restores still request the full configured history. The recent window avoids repeatedly serializing all retained history for a slow viewer.
|
||||||
- **Plugin daemon sessions report IPC queue bytes.** Their virtual socket increments `bufferedAmount` before `process.send` and decrements it only in the send callback. Text and binary frames share that ordered queue, so the normal snapshot catch-up and physical high-water gates remain valid for server-side plugin SDK traffic.
|
- **Plugin daemon sessions report IPC queue bytes.** Their virtual socket increments `bufferedAmount` before `process.send` and decrements it only in the send callback. Text and binary frames share that ordered queue, so the normal snapshot catch-up and physical high-water gates remain valid for server-side plugin SDK traffic.
|
||||||
- **Client output writes are not serialized per frame.** The emulator runtime drains contiguous plain writes straight into xterm (which buffers internally). Only barrier ops (`clear`, `snapshot`, `suppressInput` writes) wait — behind a zero-length sentinel write — so resets can't interleave with in-flight output.
|
- **Client output writes are not serialized per frame.** The emulator runtime drains contiguous plain writes straight into xterm (which buffers internally). Only barrier ops (`clear`, `snapshot`, `suppressInput` writes) wait — behind a zero-length sentinel write — so resets can't interleave with in-flight output.
|
||||||
- **Find preserves the inspected xterm viewport, including at the live bottom.** Keep its output anchor inside the existing batched write path. Serializing output to preserve a search result would add terminal latency.
|
- **Find preserves the inspected xterm viewport, including at the live bottom.** Keep its output anchor inside the existing batched write path. Serializing output to preserve a search result would add terminal latency.
|
||||||
|
|||||||
@@ -0,0 +1,75 @@
|
|||||||
|
# Terminal rendering
|
||||||
|
|
||||||
|
Web and Electron draw terminals with xterm.js. iOS and Android keep an `@xterm/headless` buffer in JS and draw it with the `PaseoTerminal` native view in `packages/app/modules/paseo-terminal`: CoreText on iOS, `Canvas.drawTextRun` on Android. `src/terminal/native-renderer/terminal-frame.ts` turns the visible buffer into frames, and both native views take the same props.
|
||||||
|
|
||||||
|
## xterm owns the grid
|
||||||
|
|
||||||
|
xterm decides which column every cell occupies. The native views never let text advance move a cell. Each row is shaped once, one run per font face, so Hangul jamo, ligatures, combining marks, conjuncts and fallback fonts see their neighbours. Each shaped cluster is then drawn at its first cell's column, centred in the columns it owns, and scaled down when its glyphs are wider. Cursor, selection, hit-testing and copy all use xterm's columns, so they stay correct whatever the font does.
|
||||||
|
|
||||||
|
A cluster is the run of cells the shaper merged, and it is drawn once from the shaped row. xterm usually keeps a conjunct in one cell (see [Character widths](#character-widths)), but a colour change inside it leaves `क्` and `ष` in separate cells that still shape together. Drawing part of a cluster on its own reshapes it: the conjunct comes apart into `क्` with a visible virama. So colour and selection never split a cluster. A cluster whose cells differ in colour is drawn once per colour, clipped to that colour's columns.
|
||||||
|
|
||||||
|
Android also groups cells with `android.icu.text.BreakIterator`, because Minikin's advances and cursor boundaries alone split some clusters that span cells. Grouping only merges whole cells, so a conjunct xterm keeps in one cell cannot be split by the OS. Grapheme rules follow the OS ICU version, and we accept that to avoid bundling approximately 14 MB of ICU4J data. Before the buffers used grapheme widths, Android 10 (API 29) split `स्ते` across its two cells. This renderer does not guarantee identical shaping across OS versions.
|
||||||
|
|
||||||
|
`TerminalRowLayoutTest.kt` is the Android regression test. It draws the rows of `grapheme-rows.json` and compares each with its grapheme clusters drawn one at a time, and with a wrong clustering that must not match. `terminal-frame.test.ts` checks that those rows are what xterm produces and that the clusters are UAX #29 grapheme clusters. Run it with `./gradlew :paseo-terminal:connectedDebugAndroidTest` from `packages/app/android`, with `ANDROID_SERIAL` set.
|
||||||
|
|
||||||
|
The view reports ready only after it has measured its grid size. The pane attaches with that size, so the daemon replays the terminal at the client's size. Before this, the replay arrived at the PTY's old size, the resize came after it, and the shell's redraw landed on the wrong rows.
|
||||||
|
|
||||||
|
## Character widths
|
||||||
|
|
||||||
|
The daemon, native and web buffers all load `@xterm/addon-unicode-graphemes`: the daemon through `packages/server/src/terminal/headless-terminal.ts`, native in `createNativeHeadlessTerminal`, web in `terminal-emulator-runtime.ts`. Each emoji cluster takes one two-column cell, including VS16 (`❤️`), skin tones (`👋🏽`), flags (`🇰🇷`) and ZWJ sequences (`👨👩👧`). That is the width colour-emoji fonts draw at. Under xterm's default Unicode 6 table `😀` got one column, and the native views scaled it to half size to fit.
|
||||||
|
|
||||||
|
Every buffer must use the same table. The daemon answers cursor-position reports (`CSI 6n`) from its buffer, and a client re-parses the daemon's ANSI replay with its own table. A disagreement moves the cursor and the later cells of any row that holds a disputed cluster: after replay from a Unicode 6 daemon, the cursor that followed `A😀😀😀B` lands inside the third emoji.
|
||||||
|
|
||||||
|
Daemons that use grapheme widths advertise `server_info.features["terminal-grapheme-widths"]`. `terminal-pane.tsx` reads it once and passes `characterWidths` to the emulator. Against an older daemon the app keeps each renderer's previous table: xterm's default on native, Unicode 11 on web. An older app against a newer daemon cannot match it, because every client shares the daemon's one buffer. A terminal kept by a worker from an unreleased pre-grapheme build keeps that worker's table until it exits.
|
||||||
|
|
||||||
|
The table follows Unicode grapheme clusters, as Node's `string-width` does for Ink-based agent TUIs. Indic conjuncts follow the same rule: `क्ष` and `स्ते` take one column, and the native views scale them down to fit it. Shells measure with the C library's `wcwidth` instead. glibc counts `❤️` as one column, `👋🏽` as four and `क्ष` as two, so a line editor that measures those disagrees with the terminal.
|
||||||
|
|
||||||
|
Use `@xterm/addon-unicode-graphemes` 0.5.0-beta.330 or later. Earlier versions read their width table from the wrong offset when Node decodes it into a pooled `Buffer`, which gives wrong widths or a load error depending on earlier allocations. `headless-terminal.test.ts` forces that case in a fresh process.
|
||||||
|
|
||||||
|
## Ink outside the row
|
||||||
|
|
||||||
|
Marks stacked above or below a letter, Arabic letter tails and some fallback glyphs ink into the rows next to theirs. Neither view clips a row to its own bounds, because a row clip also cuts marks and Arabic dots. Rows draw top to bottom, so a later row's cell backgrounds cover the ink that reaches into it.
|
||||||
|
|
||||||
|
Android redraws every row on each frame, so overhanging ink cannot go stale. Its row `RenderNode`s are created with `setClipToBounds(false)`. The default would clip only unselected rows, because selected rows are drawn straight onto the view's canvas.
|
||||||
|
|
||||||
|
iOS repaints only the rows that changed. Each `TerminalRowLayout` records how far its glyphs ink above and below the row. A changed row invalidates its old and new ink extent, and `draw(_:)` redraws every row whose ink extent meets the dirty rect. Invalidating only the row's own rect left an erased row's marks in the row next to it, erased a neighbour's marks when a row was rewritten, and showed or hid overhang depending on which rows changed together.
|
||||||
|
|
||||||
|
## Mixed-direction text
|
||||||
|
|
||||||
|
Rows draw left to right in logical order on both platforms. Terminal bidi escape modes are not implemented. On iOS the row needs both the `kCTWritingDirection` override and an LTR paragraph base direction. Without the base direction, bidi rule L1 moves trailing spaces ahead of a row that starts with Arabic or Hebrew, and the whole row shifts.
|
||||||
|
|
||||||
|
Arabic still gets the contextual form its logical neighbours select, but in left-to-right order, so letters join on the wrong side. Correct visual Arabic needs implicit bidi per row: reorder RTL runs for display and map cursor, selection and hit-testing through the visual-to-logical index. That changes which column a character appears in, so it has to be decided as product behaviour first. Shaping alone cannot fix it.
|
||||||
|
|
||||||
|
## Render regression
|
||||||
|
|
||||||
|
The scripts live in `packages/app/e2e/mobile/terminal-rendering`. Run them from `packages/app` on the daemon's host, starting from an idle, focused terminal with an empty prompt.
|
||||||
|
|
||||||
|
`render.mjs` prints a mixed-script fixture, screenshots it with agent-device, and checks the geometry with `check.mjs`. The check rebuilds the expected buffer with `@xterm/headless` and measures the grid from a ruler row. It checks that:
|
||||||
|
|
||||||
|
- every grapheme cluster has ink inside its own columns, and blank cells stay blank;
|
||||||
|
- on the accent rows, every cell is drawn in its own colour, including cells inside one cluster;
|
||||||
|
- the cursor is drawn after the text;
|
||||||
|
- every row is exposed as `terminal-row-<n>`;
|
||||||
|
- selecting one cell of a conjunct highlights only that cell.
|
||||||
|
|
||||||
|
On iOS the screenshot is taken at 3 pixels per point (`PASEO_TERMINAL_RENDERING_PIXEL_DENSITY`), because the simulator's default is one pixel per point and a glyph is then about 12 pixels. Focus the terminal before a run: with the simulator's hardware keyboard connected the key bar shows without a focused input, and `type` fails. In a debug build, the dev client's floating gear button covers the right end of the first row, so ruler cells there fail.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
PLATFORM=android ANDROID_SERIAL=emulator-5554 node e2e/mobile/terminal-rendering/render.mjs
|
||||||
|
PLATFORM=ios IOS_DEVICE="iPhone 17" node e2e/mobile/terminal-rendering/render.mjs
|
||||||
|
```
|
||||||
|
|
||||||
|
Geometry passes when a cell holds the wrong glyph. `identity.mjs` judges each cluster of a `render.mjs` run against pango's rendering of the same characters in the device's fonts. The reference is cut at the edges of the cluster's columns, placed as the renderer places it, because glyphs such as Devanagari letters ink past their advance and the device cuts them there too. A shape passes when its coverage correlates with its own reference at 0.6 or more, and no other cluster of the corpus matches it better. Box and block characters are judged against their Unicode definition. Shades are judged by even density over a 4×4 grid, because the device and pango fall back to different shade fonts. Clusters that pango draws without ink are reported as unjudged instead: flags on both platforms and Apple Color Emoji. The `rect` and `swap` controls fill every cluster with white, or judge each one against another cluster. Both must fail every cluster, which shows the oracle refuses ink that is present but wrong. An Arabic letter is compared with all four of its positional forms, so the oracle shows the right letter is drawn, not that it has the right form. Ink that a neighbouring row draws into a cluster's cells counts as that cluster's ink. On iOS the tail of `م` in the Arabic row reaches one pixel into the `न` below it, so `न` fails although both rows are drawn correctly.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
FONTCONFIG_FILE=fonts.conf node e2e/mobile/terminal-rendering/identity.mjs <run dir> [none|rect|swap]
|
||||||
|
```
|
||||||
|
|
||||||
|
`fonts.conf` points fontconfig at the device's font files and lists, for `monospace`, the terminal font followed by the device's fallbacks for Hangul, Arabic, Devanagari, CJK, emoji and symbols:
|
||||||
|
|
||||||
|
- **Android:** pull the fonts from `/system/fonts` with `adb pull`. The terminal font is Droid Sans Mono.
|
||||||
|
- **iOS:** copy the simulator runtime's fonts from `RuntimeRoot/System/Library/Fonts`. The terminal font is Menlo. PingFang stores its outlines in Apple's `hvgl` table, which FreeType cannot draw, so the CJK references come from Apple SD Gothic Neo instead. `語` then scores below the threshold although the device draws it correctly.
|
||||||
|
|
||||||
|
`overhang.mjs` prints rows whose marks reach the rows next to them. In one update it writes into two rows that hold a neighbour's marks and erases two rows whose marks reach a blank row. The marks must be drawn before the update, stay drawn in the written rows, and leave no ink behind the erased rows. Run it like `render.mjs`.
|
||||||
|
|
||||||
|
`reattach.mjs` checks the restore size. It changes the PTY size by opening the keyboard (`RESIZE=keyboard`) or folding an Android foldable (`RESIZE=fold`), relaunches the app, and compares the client's rows with `paseo terminal capture`. A trial where no terminal rows appear, for example after a launch crash, counts as never attached and fails the run.
|
||||||
+15
-1
@@ -15,6 +15,8 @@ supervisor (paseo.pid) ──► daemon worker ──► launcher ──► term
|
|||||||
- The worker exits on its own when it has no controller and no terminals, on `shutdown`, on SIGTERM (killing its terminals), and when its record disappears (a deleted `$PASEO_HOME`: nobody can ever reach it again).
|
- The worker exits on its own when it has no controller and no terminals, on `shutdown`, on SIGTERM (killing its terminals), and when its record disappears (a deleted `$PASEO_HOME`: nobody can ever reach it again).
|
||||||
- Its stderr goes to `$PASEO_HOME/terminal-worker.log`. No pipe to the daemon survives the daemon.
|
- Its stderr goes to `$PASEO_HOME/terminal-worker.log`. No pipe to the daemon survives the daemon.
|
||||||
|
|
||||||
|
The worker retains a fixed 10,000 history rows plus the screen in its existing xterm. Replay uses `@xterm/addon-serialize` 0.14 against headless xterm 6; no second cell grid or lifetime byte log is retained. The serializer boundary owns cursor position, visibility and explicit program-selected presentation; the addon alone does not preserve all three. An unset program style leaves each client’s configured cursor defaults intact. Standard modes come from the serializer; the existing input-mode tracker retains protocol modes such as Kitty and Win32 input. Commit that tracker with parsed output so replay bytes and metadata describe the same cut.
|
||||||
|
|
||||||
Which triggers keep terminals and which close them is owned by the stop reason (`keepTerminals`) that flows from the request through the supervisor to `stop()`. The kill side always ends in the reaper (`terminal-worker-reaper.ts`), the only path that signals terminal processes outside a connected daemon.
|
Which triggers keep terminals and which close them is owned by the stop reason (`keepTerminals`) that flows from the request through the supervisor to `stop()`. The kill side always ends in the reaper (`terminal-worker-reaper.ts`), the only path that signals terminal processes outside a connected daemon.
|
||||||
|
|
||||||
## Record, socket and secret
|
## Record, socket and secret
|
||||||
@@ -40,10 +42,22 @@ The worker writes `$PASEO_HOME/terminal-worker/<pid>.json` (owner-only) with its
|
|||||||
|
|
||||||
Never more than two workers run. A new worker launches only when none is current, none is incompatible and fewer than two run. The count comes from the records, so an unreachable or unidentified worker counts, and so does one a cleanup could not confirm gone. When two run, the daemon starts with no current worker, and the first terminal created after one of them exits launches it.
|
Never more than two workers run. A new worker launches only when none is current, none is incompatible and fewer than two run. The count comes from the records, so an unreachable or unidentified worker counts, and so does one a cleanup could not confirm gone. When two run, the daemon starts with no current worker, and the first terminal created after one of them exits launches it.
|
||||||
|
|
||||||
**The frozen envelope never changes across versions:** the frame format (4-byte length + `v8.serialize`), `hello`/`helloAck`, the `listTerminals` info fields and `shutdown`. That is what lets any daemon close any worker: a kill stop sends `shutdown` to a newer worker it cannot otherwise drive. When you bump the version, keep a previous-version adapter so the draining worker can still be driven, and drop the adapter for the version before that.
|
**The frozen envelope never changes across versions:** the frame format (4-byte length + `v8.serialize`), `hello`/`helloAck`, the `listTerminals` info fields and `shutdown`. That is what lets any daemon close any worker: a kill stop sends `shutdown` to a newer worker it cannot otherwise drive. Protocol 5 hard cuts unreleased protocols 1 through 4, including the acknowledgement-based replay contract: those workers are obsolete and close. For future versions, keep a previous-version adapter so the draining worker can still be driven, and drop the adapter for the version before that.
|
||||||
|
|
||||||
Tests stand up other versions with `PASEO_TERMINAL_WORKER_PROTOCOL_OVERRIDE`, read by the worker. It is test-only.
|
Tests stand up other versions with `PASEO_TERMINAL_WORKER_PROTOCOL_OVERRIDE`, read by the worker. It is test-only.
|
||||||
|
|
||||||
|
## Display replay
|
||||||
|
|
||||||
|
The worker keeps the headless xterm model and generates ANSI. A replay request emits begin metadata (dimensions, retained history, revision and input modes), at most 64 KiB per data chunk, and end. Live output keeps flowing independently during replay. Capture is synchronous with PTY callbacks; flush the output coalescer before the cut so a later batch never includes bytes already in replay. Retained-history metadata counts the worker history before the request limit.
|
||||||
|
|
||||||
|
ConPTY renders a console rather than forwarding every program escape sequence unchanged. A program write callback does not establish that its hidden cursor move or input modes reached the worker. Test exact ANSI fidelity at the serializer boundary; PTY integration compares the initial replay plus committed observed output at the capture cut, including startup modes.
|
||||||
|
|
||||||
|
The worker paces replay writes on its local socket; the daemon synchronously queues each event into the application's bounded transport. App network delivery does not extend the worker's request deadline. There is no per-chunk acknowledgement or second replay delivery queue in the daemon. The physical application transport owns its 64 MiB high-water close, so a backed-up app cannot hold worker capture open. Each daemon viewer still holds at most 4 MiB of live output during capture, then drops revisions already present in the worker replay. Capture failure and tail overflow affect only that viewer; PTYs and healthy viewers keep running.
|
||||||
|
|
||||||
|
Live traffic that fills the shared worker socket beyond 4 MiB disconnects the stalled controller. Reconnection adopts the surviving sessions and requests fresh replay for existing streams. Readiness does not require a revision: adoption announces readiness without one, while the replay capture supplies the revision used for deduplication.
|
||||||
|
|
||||||
|
The SDK advertises `terminal_chunked_replay` only because it decodes begin/data/end. Capable clients receive these events directly; the daemon collects one Restore frame only for older ANSI clients. The SDK normalizes an older host's single Restore into the same lifecycle. Capture stays a worker request; bootstrap readiness uses `hasOutput`, not a transported grid.
|
||||||
|
|
||||||
## Running from its own copy
|
## Running from its own copy
|
||||||
|
|
||||||
A worker outlives the installation that started it. An npm or desktop update replaces that installation's files, and the next terminal the old worker creates would load node-pty's `spawn-helper` and the zsh integration from paths that no longer exist. So a built daemon does not launch the worker from its install:
|
A worker outlives the installation that started it. An npm or desktop update replaces that installation's files, and the next terminal the old worker creates would load node-pty's `spawn-helper` and the zsh integration from paths that no longer exist. So a built daemon does not launch the worker from its install:
|
||||||
|
|||||||
+14
-7
@@ -21,10 +21,16 @@ The invariants are:
|
|||||||
> agent establishes the daemon's current tail in one complete-turn request, with older history reachable
|
> agent establishes the daemon's current tail in one complete-turn request, with older history reachable
|
||||||
> through backward pagination.
|
> through backward pagination.
|
||||||
|
|
||||||
Tool output is bounded before it enters either delivery path. Canonical shell tool output is sliced
|
Every item is bounded before it enters either delivery path, because a timeline page is one
|
||||||
to 64 KiB, and the same bounded item is used for runtime timeline rows and live stream events.
|
WebSocket message and the daemon closes a socket whose outbound buffer passes 64 MiB. Tool calls get
|
||||||
Provider history hydration applies the same rule so reopening an agent cannot restore an oversized
|
64 KiB and other items 256 KiB. Over budget, the largest strings are cut to a shared length with a
|
||||||
tool payload.
|
`…[truncated 12.3 MB]` marker, and an oversized `data:` URL is replaced by the marker. Strings up
|
||||||
|
to 1 KiB stay whole, so ids and paths survive. Arrays drop their trailing elements without a marker
|
||||||
|
element, so typed arrays still match the wire schema. Limiting an item twice gives the same item. The
|
||||||
|
budget does not bound wide objects or multi-byte text. The same
|
||||||
|
bounded item is used for runtime timeline rows and live stream events. Provider history hydration
|
||||||
|
applies the same rule so reopening an agent cannot restore an oversized payload. Fetches apply it
|
||||||
|
again to assistant and reasoning rows the projection merges from many chunks.
|
||||||
|
|
||||||
## Presence is not delivery
|
## Presence is not delivery
|
||||||
|
|
||||||
@@ -89,9 +95,10 @@ Provider message IDs are not guaranteed for every displayed item. Paseo-generate
|
|||||||
Actions that address a point in chat history, such as Fork, use the daemon timeline `epoch` plus the projected item's `seqEnd`. The app carries that position on the rendered assistant item for both live and fetched history. When adjacent projected chunks merge, the merged item retains the newer chunk's position.
|
Actions that address a point in chat history, such as Fork, use the daemon timeline `epoch` plus the projected item's `seqEnd`. The app carries that position on the rendered assistant item for both live and fetched history. When adjacent projected chunks merge, the merged item retains the newer chunk's position.
|
||||||
|
|
||||||
The daemon validates the epoch and locates the projected item at the selected position. A fork
|
The daemon validates the epoch and locates the projected item at the selected position. A fork
|
||||||
includes projected items through that checkpoint. If an item spans the checkpoint and changed
|
includes projected items through that checkpoint. If an item the fork copies spans the checkpoint
|
||||||
afterward, the daemon refuses that fork with an actionable error: discarded historical payloads
|
and changed afterward, the daemon refuses that fork with an actionable error: discarded historical
|
||||||
cannot be reconstructed from sequence metadata. Forking the current context remains available.
|
payloads cannot be reconstructed from sequence metadata. Plugin cards are not copied, so a card
|
||||||
|
updated after the checkpoint does not block it. Forking the current context remains available.
|
||||||
|
|
||||||
## Resume behavior
|
## Resume behavior
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,10 @@
|
|||||||
|
Daemon restarts now keep terminal programs running. Interrupted agents can resume in their existing conversations when you turn on agent recovery.
|
||||||
|
|
||||||
|
Mobile terminals have native rendering and draggable text-selection handles. Reconnecting restores up to 10,000 lines of terminal history.
|
||||||
|
|
||||||
|
Worktree setup can copy ignored files and use plugin-defined locations before agents start.
|
||||||
|
|
||||||
|
Added
|
||||||
|
- Insert known agent commands from replies into the Composer draft
|
||||||
|
|
||||||
|
Full notes: https://paseo.sh/changelog
|
||||||
@@ -0,0 +1,10 @@
|
|||||||
|
Daemon restarts now keep terminal programs running. Interrupted agents can resume in their existing conversations when you turn on agent recovery.
|
||||||
|
|
||||||
|
Mobile terminals have native rendering and draggable text-selection handles. Reconnecting restores up to 10,000 lines of terminal history.
|
||||||
|
|
||||||
|
Worktree setup can copy ignored files and use plugin-defined locations before agents start.
|
||||||
|
|
||||||
|
Added
|
||||||
|
- Insert known agent commands from replies into the Composer draft
|
||||||
|
|
||||||
|
Full notes: https://paseo.sh/changelog
|
||||||
@@ -0,0 +1,10 @@
|
|||||||
|
Daemon restarts now keep terminal programs running. Interrupted agents can resume in their existing conversations when you turn on agent recovery.
|
||||||
|
|
||||||
|
Mobile terminals have native rendering and draggable text-selection handles. Reconnecting restores up to 10,000 lines of terminal history.
|
||||||
|
|
||||||
|
Worktree setup can copy ignored files and use plugin-defined locations before agents start.
|
||||||
|
|
||||||
|
Added
|
||||||
|
- Insert known agent commands from replies into the Composer draft
|
||||||
|
|
||||||
|
Full notes: https://paseo.sh/changelog
|
||||||
@@ -0,0 +1,10 @@
|
|||||||
|
Daemon restarts now keep terminal programs running. Interrupted agents can resume in their existing conversations when you turn on agent recovery.
|
||||||
|
|
||||||
|
Mobile terminals have native rendering and draggable text-selection handles. Reconnecting restores up to 10,000 lines of terminal history.
|
||||||
|
|
||||||
|
Worktree setup can copy ignored files and use plugin-defined locations before agents start.
|
||||||
|
|
||||||
|
Added
|
||||||
|
- Insert known agent commands from replies into the Composer draft
|
||||||
|
|
||||||
|
Full notes: https://paseo.sh/changelog
|
||||||
@@ -127,7 +127,7 @@ buildNpmPackage {
|
|||||||
# The Nix output is not a distributable DMG, so leave it unsigned and
|
# The Nix output is not a distributable DMG, so leave it unsigned and
|
||||||
# disable the hardened runtime that requires a matching signature.
|
# disable the hardened runtime that requires a matching signature.
|
||||||
CSC_IDENTITY_AUTO_DISCOVERY=false \
|
CSC_IDENTITY_AUTO_DISCOVERY=false \
|
||||||
../../node_modules/.bin/electron-builder \
|
npm exec --offline -- electron-builder \
|
||||||
--config electron-builder.yml \
|
--config electron-builder.yml \
|
||||||
--dir \
|
--dir \
|
||||||
--mac \
|
--mac \
|
||||||
|
|||||||
+1
-1
@@ -1 +1 @@
|
|||||||
sha256-6C4Rjh0mRVrC9akBVGK0NZaCaLJhwKObT7HrgPmcvyw=
|
sha256-plC3c5pOkD/q2Q8Oi/5ARTyVVmN4eze+scbHoEUC7NA=
|
||||||
|
|||||||
Generated
+791
-915
File diff suppressed because it is too large
Load Diff
+10
-2
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "paseo",
|
"name": "paseo",
|
||||||
"version": "0.14.0",
|
"version": "0.15.0",
|
||||||
"private": true,
|
"private": true,
|
||||||
"description": "Paseo: voice-controlled development environment for local AI coding agents",
|
"description": "Paseo: voice-controlled development environment for local AI coding agents",
|
||||||
"keywords": [
|
"keywords": [
|
||||||
@@ -131,6 +131,7 @@
|
|||||||
"concurrently": "^9.2.1",
|
"concurrently": "^9.2.1",
|
||||||
"cross-env": "^10.1.0",
|
"cross-env": "^10.1.0",
|
||||||
"electron": "44.2.0",
|
"electron": "44.2.0",
|
||||||
|
"electron-builder": "26.18.0",
|
||||||
"expo-module-scripts": "^5.0.8",
|
"expo-module-scripts": "^5.0.8",
|
||||||
"get-port-cli": "^3.0.0",
|
"get-port-cli": "^3.0.0",
|
||||||
"js-yaml": "^4.1.1",
|
"js-yaml": "^4.1.1",
|
||||||
@@ -148,14 +149,21 @@
|
|||||||
"overrides": {
|
"overrides": {
|
||||||
"@codemirror/language": "6.12.4",
|
"@codemirror/language": "6.12.4",
|
||||||
"@codemirror/view": "6.43.6",
|
"@codemirror/view": "6.43.6",
|
||||||
|
"@electron/get@^3.0.0": {
|
||||||
|
"semver@^6": "6.3.1"
|
||||||
|
},
|
||||||
"expo": "~57.0.30",
|
"expo": "~57.0.30",
|
||||||
"expo-router": "~57.0.28",
|
"expo-router": "~57.0.28",
|
||||||
"lightningcss": "1.30.1",
|
"lightningcss": "1.30.1",
|
||||||
|
"pkijs": "3.4.2",
|
||||||
"react": "19.2.3",
|
"react": "19.2.3",
|
||||||
"react-dom": "19.2.3",
|
"react-dom": "19.2.3",
|
||||||
"react-native": "0.86.3",
|
"react-native": "0.86.3",
|
||||||
"react-native-gesture-handler": "~2.32.0",
|
"react-native-gesture-handler": "~2.32.0",
|
||||||
"react-native-reanimated": "4.5.5",
|
"react-native-reanimated": "4.5.5",
|
||||||
"react-native-worklets": "0.10.4"
|
"react-native-worklets": "0.10.4",
|
||||||
|
"tiny-async-pool": {
|
||||||
|
"semver@^5": "5.7.2"
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -142,6 +142,7 @@ export default {
|
|||||||
searchPaths: ["../../node_modules", "./node_modules"],
|
searchPaths: ["../../node_modules", "./node_modules"],
|
||||||
},
|
},
|
||||||
plugins: [
|
plugins: [
|
||||||
|
"./modules/paseo-hardware-keyboard/app.plugin",
|
||||||
"expo-router",
|
"expo-router",
|
||||||
withPasteInput,
|
withPasteInput,
|
||||||
withAndroidScroll,
|
withAndroidScroll,
|
||||||
|
|||||||
@@ -94,3 +94,21 @@ it("allows all orientations on iPhone and iPad", async () => {
|
|||||||
await rm(root, { recursive: true, force: true });
|
await rm(root, { recursive: true, force: true });
|
||||||
}
|
}
|
||||||
}, 30_000);
|
}, 30_000);
|
||||||
|
|
||||||
|
// Scene startup is the integration boundary for the iOS keyboard window.
|
||||||
|
describe("hardware keyboard scene integration", () => {
|
||||||
|
it("installs observation after Expo creates the scene window and is idempotent", () => {
|
||||||
|
const {
|
||||||
|
configureHardwareKeyboardAppDelegate,
|
||||||
|
} = require("./modules/paseo-hardware-keyboard/app.plugin.js");
|
||||||
|
const source =
|
||||||
|
"import Expo\nclass Scene {\n super.scene(scene, willConnectTo: session, options: connectionOptions)\n}\n";
|
||||||
|
const configured = configureHardwareKeyboardAppDelegate(source);
|
||||||
|
expect(configured).toContain("import PaseoHardwareKeyboard");
|
||||||
|
expect(configured).toContain("PaseoHardwareKeyboardWindow.observing(window)");
|
||||||
|
expect(configured.indexOf("super.scene")).toBeLessThan(
|
||||||
|
configured.indexOf(".observing(window)"),
|
||||||
|
);
|
||||||
|
expect(configureHardwareKeyboardAppDelegate(configured)).toBe(configured);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import path from "node:path";
|
|||||||
import { test, expect } from "../support/fixtures";
|
import { test, expect } from "../support/fixtures";
|
||||||
import {
|
import {
|
||||||
addProjectFlow,
|
addProjectFlow,
|
||||||
|
chooseAddHostFromProjectFlow,
|
||||||
addProjectFlowBack,
|
addProjectFlowBack,
|
||||||
addProjectFlowHost,
|
addProjectFlowHost,
|
||||||
addProjectFlowInput,
|
addProjectFlowInput,
|
||||||
@@ -14,11 +15,14 @@ import {
|
|||||||
expectNewWorkspaceForAddedProject,
|
expectNewWorkspaceForAddedProject,
|
||||||
expectAddProjectResultVisible,
|
expectAddProjectResultVisible,
|
||||||
navigateAddProjectResults,
|
navigateAddProjectResults,
|
||||||
|
navigateAndDismissAddProject,
|
||||||
|
watchAddProjectRenderWarnings,
|
||||||
openAddProjectFlow,
|
openAddProjectFlow,
|
||||||
openAddProjectHostSelection,
|
openAddProjectHostSelection,
|
||||||
} from "../support/helpers/add-project-flow";
|
} from "../support/helpers/add-project-flow";
|
||||||
import { gotoAppShell } from "../support/helpers/app";
|
import { gotoAppShell } from "../support/helpers/app";
|
||||||
import {
|
import {
|
||||||
|
disconnectAllHostsAndReload,
|
||||||
addConnectedHostAndReload,
|
addConnectedHostAndReload,
|
||||||
addConnectedHostsAndReload,
|
addConnectedHostsAndReload,
|
||||||
addOfflineHostAndReload,
|
addOfflineHostAndReload,
|
||||||
@@ -69,6 +73,19 @@ async function expectProjectHasNoWorkspaces(projectId: string): Promise<void> {
|
|||||||
test.describe("Add Project command-center flow", () => {
|
test.describe("Add Project command-center flow", () => {
|
||||||
test.describe.configure({ timeout: 180_000 });
|
test.describe.configure({ timeout: 180_000 });
|
||||||
|
|
||||||
|
test("Add host replaces the project dialog when no hosts are connected", async ({ page }) => {
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await disconnectAllHostsAndReload(page);
|
||||||
|
await openAddProjectHostSelection(page);
|
||||||
|
const originalUrl = page.url();
|
||||||
|
await chooseAddHostFromProjectFlow(page);
|
||||||
|
await expect(addProjectFlow(page)).toBeHidden();
|
||||||
|
await expect(
|
||||||
|
page.getByRole("button", { name: "Direct connection", exact: true }),
|
||||||
|
).toBeVisible();
|
||||||
|
await expect(page).toHaveURL(originalUrl);
|
||||||
|
});
|
||||||
|
|
||||||
test("method selection shows the daemon's available project sources without search", async ({
|
test("method selection shows the daemon's available project sources without search", async ({
|
||||||
page,
|
page,
|
||||||
}) => {
|
}) => {
|
||||||
@@ -131,6 +148,7 @@ test.describe("Add Project command-center flow", () => {
|
|||||||
test("Escape and Back restore searchable page input before closing at the root", async ({
|
test("Escape and Back restore searchable page input before closing at the root", async ({
|
||||||
page,
|
page,
|
||||||
}) => {
|
}) => {
|
||||||
|
const renderWarnings = watchAddProjectRenderWarnings(page);
|
||||||
await gotoAppShell(page);
|
await gotoAppShell(page);
|
||||||
await addConnectedHostAndReload(page, {
|
await addConnectedHostAndReload(page, {
|
||||||
serverId: secondaryHost.serverId,
|
serverId: secondaryHost.serverId,
|
||||||
@@ -168,8 +186,9 @@ test.describe("Add Project command-center flow", () => {
|
|||||||
|
|
||||||
await page.keyboard.press("Escape");
|
await page.keyboard.press("Escape");
|
||||||
await expectAddProjectPage(page, "host");
|
await expectAddProjectPage(page, "host");
|
||||||
await page.keyboard.press("Escape");
|
await navigateAndDismissAddProject(page);
|
||||||
await expect(addProjectFlow(page)).not.toBeVisible();
|
await expect(addProjectFlow(page)).not.toBeVisible();
|
||||||
|
expect(renderWarnings).toEqual([]);
|
||||||
});
|
});
|
||||||
|
|
||||||
test("New directory creates a Project on the selected remote host", async ({ page }) => {
|
test("New directory creates a Project on the selected remote host", async ({ page }) => {
|
||||||
|
|||||||
@@ -9,9 +9,11 @@ test("shows Pure black in the appearance picker", async ({ page }, testInfo) =>
|
|||||||
await expect(page.getByTestId("settings-sidebar")).toBeVisible();
|
await expect(page.getByTestId("settings-sidebar")).toBeVisible();
|
||||||
await openSettingsSection(page, "appearance");
|
await openSettingsSection(page, "appearance");
|
||||||
|
|
||||||
const themeTrigger = page.getByLabel("Theme: System", { exact: true });
|
await expect(page.getByRole("radio", { name: "System", exact: true })).toBeChecked();
|
||||||
await themeTrigger.click();
|
await expect(
|
||||||
await expect(page.getByText("Pure black", { exact: true })).toBeVisible();
|
page.getByRole("radiogroup", { name: "Theme" }).getByRole("radio").first(),
|
||||||
|
).toHaveAccessibleName("System");
|
||||||
|
await expect(page.getByRole("radio", { name: "Pure black", exact: true })).toBeVisible();
|
||||||
await page.screenshot({
|
await page.screenshot({
|
||||||
path: testInfo.outputPath("appearance-theme-picker.png"),
|
path: testInfo.outputPath("appearance-theme-picker.png"),
|
||||||
fullPage: true,
|
fullPage: true,
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import { writeFile } from "node:fs/promises";
|
import { execFileSync } from "node:child_process";
|
||||||
|
import { mkdir, writeFile } from "node:fs/promises";
|
||||||
import path from "node:path";
|
import path from "node:path";
|
||||||
import { test, expect, type Page } from "../support/fixtures";
|
import { test, expect, type Page } from "../support/fixtures";
|
||||||
import { openAgentRoute, seedMockAgentWorkspace } from "../support/helpers/mock-agent";
|
import { openAgentRoute, seedMockAgentWorkspace } from "../support/helpers/mock-agent";
|
||||||
@@ -67,3 +68,54 @@ test("opening an assistant file link dismisses its tooltip over the file tab", a
|
|||||||
await agent.cleanup();
|
await agent.cleanup();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
async function readLinkedGuide(page: Page, linkName: string, content: string): Promise<void> {
|
||||||
|
await page.getByRole("link", { name: linkName, exact: true }).click();
|
||||||
|
await expect(page.getByTestId("markdown-preview-frame").filter({ visible: true })).toContainText(
|
||||||
|
content,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
async function returnToNestedLinks(page: Page): Promise<void> {
|
||||||
|
await page.getByRole("button", { name: "Nested file links", exact: true }).click();
|
||||||
|
await expect(page.getByRole("link", { name: "nested guide", exact: true })).toBeVisible();
|
||||||
|
}
|
||||||
|
|
||||||
|
test("assistant directory paths find nested files and preserve exact workspace paths", async ({
|
||||||
|
page,
|
||||||
|
}, testInfo) => {
|
||||||
|
testInfo.setTimeout(120_000);
|
||||||
|
const agent = await seedMockAgentWorkspace({
|
||||||
|
repoPrefix: "nested-file-link-",
|
||||||
|
title: "Nested file links",
|
||||||
|
featureValues: {
|
||||||
|
mockStreamingAssistantResponse:
|
||||||
|
"Read [nested guide](schema/x.md), [exact guide](schema/exact.md), and [missing guide](schema/missing.md).",
|
||||||
|
mockStreamingAssistantIntervalMs: 5,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
try {
|
||||||
|
await mkdir(path.join(agent.cwd, "repo-a/schema"), { recursive: true });
|
||||||
|
execFileSync("git", ["init", "-b", "main"], { cwd: path.join(agent.cwd, "repo-a") });
|
||||||
|
await writeFile(
|
||||||
|
path.join(agent.cwd, "repo-a/schema/x.md"),
|
||||||
|
"# Nested file content\n\nDetails\n",
|
||||||
|
);
|
||||||
|
await mkdir(path.join(agent.cwd, "schema"), { recursive: true });
|
||||||
|
await writeFile(path.join(agent.cwd, "schema/exact.md"), "# Exact file content\n");
|
||||||
|
await writeFile(path.join(agent.cwd, "repo-a/schema/exact.md"), "# Wrong nested content\n");
|
||||||
|
await openAgentRoute(page, agent);
|
||||||
|
await agent.client.sendAgentMessage(agent.agentId, "Show the file links.");
|
||||||
|
await agent.client.waitForFinish(agent.agentId, 30_000);
|
||||||
|
|
||||||
|
await expect(page.getByRole("textbox", { name: "Message agent..." }).first()).toBeEnabled();
|
||||||
|
await readLinkedGuide(page, "nested guide", "Nested file content");
|
||||||
|
await returnToNestedLinks(page);
|
||||||
|
await readLinkedGuide(page, "exact guide", "Exact file content");
|
||||||
|
await returnToNestedLinks(page);
|
||||||
|
await page.getByRole("link", { name: "missing guide", exact: true }).click();
|
||||||
|
await expect(page.getByText("File not found", { exact: true })).toBeVisible();
|
||||||
|
} finally {
|
||||||
|
await agent.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|||||||
@@ -723,3 +723,46 @@ test("copying a selection across an assistant image keeps its Markdown source an
|
|||||||
await agent.cleanup();
|
await agent.cleanup();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test.describe("on a touch-capable desktop browser", () => {
|
||||||
|
// A touch screen registers the navigation pan's pointer listeners over the whole workspace.
|
||||||
|
// The pan accepts touch only, and a mouse drag must still extend the browser's selection.
|
||||||
|
test.use({ hasTouch: true });
|
||||||
|
|
||||||
|
test("a mouse drag selects across assistant paragraphs", async ({ page }) => {
|
||||||
|
const agent = await seedMockAgentWorkspace({
|
||||||
|
repoPrefix: "assistant-selection-drag-",
|
||||||
|
title: "Assistant selection drag",
|
||||||
|
initialPrompt: "Render three paragraphs.",
|
||||||
|
featureValues: {
|
||||||
|
mockAssistantResponse: "First paragraph.\n\nSecond paragraph.\n\nThird paragraph.",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
try {
|
||||||
|
await agent.client.waitForAgentUpsert(
|
||||||
|
agent.agentId,
|
||||||
|
(snapshot) => snapshot.status === "idle",
|
||||||
|
30_000,
|
||||||
|
);
|
||||||
|
await openAgentRoute(page, agent);
|
||||||
|
const blocks = assistantMessageBlocks(page);
|
||||||
|
const first = await blocks.getByText("First paragraph.").boundingBox();
|
||||||
|
const third = await blocks.getByText("Third paragraph.").boundingBox();
|
||||||
|
if (!first || !third) {
|
||||||
|
throw new Error("Expected rendered paragraphs");
|
||||||
|
}
|
||||||
|
|
||||||
|
await page.mouse.move(first.x + 1, first.y + first.height / 2);
|
||||||
|
await page.mouse.down();
|
||||||
|
await page.mouse.move(third.x + third.width - 1, third.y + third.height / 2, { steps: 20 });
|
||||||
|
await page.mouse.up();
|
||||||
|
|
||||||
|
const selected = await page.evaluate(() => window.getSelection()?.toString() ?? "");
|
||||||
|
expect(selected).toContain("First paragraph.");
|
||||||
|
expect(selected).toContain("Third paragraph.");
|
||||||
|
} finally {
|
||||||
|
await agent.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -0,0 +1,65 @@
|
|||||||
|
import { test } from "../support/fixtures";
|
||||||
|
import {
|
||||||
|
expectWorkspaceShownIdle,
|
||||||
|
finishAndArchiveAgent,
|
||||||
|
startBackgroundAgent,
|
||||||
|
} from "../support/helpers/background-agents";
|
||||||
|
import { openAgentRoute } from "../support/helpers/mock-agent";
|
||||||
|
import { seedWorkspace, type SeededWorkspace } from "../support/helpers/seed-client";
|
||||||
|
import {
|
||||||
|
expectSubagentRowGone,
|
||||||
|
expectSubagentRowVisible,
|
||||||
|
openSubagentsTrack,
|
||||||
|
seedParentWithSubagent,
|
||||||
|
seedSubagent,
|
||||||
|
} from "../support/helpers/subagents";
|
||||||
|
import { expectOnlyWorkspaceAgentTabsVisible } from "../support/helpers/workspace-tabs";
|
||||||
|
|
||||||
|
test.describe("Background agents", () => {
|
||||||
|
let workspace: SeededWorkspace;
|
||||||
|
|
||||||
|
test.beforeAll(async () => {
|
||||||
|
workspace = await seedWorkspace({
|
||||||
|
repoPrefix: "background-agents-",
|
||||||
|
title: "Classifier workspace",
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test.afterAll(async () => {
|
||||||
|
await workspace?.cleanup();
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a background agent runs in an open workspace without announcing itself", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
const agents = await seedParentWithSubagent(workspace, {
|
||||||
|
parentTitle: "Feature agent",
|
||||||
|
childTitle: "Visible helper",
|
||||||
|
});
|
||||||
|
await openAgentRoute(page, { workspaceId: agents.workspaceId, agentId: agents.parent.id });
|
||||||
|
await openSubagentsTrack(page);
|
||||||
|
await expectSubagentRowVisible(page, agents.child.id);
|
||||||
|
|
||||||
|
const classifier = await test.step("a plugin starts a background agent", () =>
|
||||||
|
startBackgroundAgent(workspace, { parentId: agents.parent.id, title: "Classifier" }));
|
||||||
|
// A visible child created after the classifier reaches the app on the same stream, so once
|
||||||
|
// its row shows, the app has processed the classifier too.
|
||||||
|
const marker = await seedSubagent(workspace, {
|
||||||
|
parentId: agents.parent.id,
|
||||||
|
title: "Ordering marker",
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("it stays out of the track, the tabs and the sidebar status", async () => {
|
||||||
|
await expectSubagentRowVisible(page, marker.id);
|
||||||
|
await expectSubagentRowGone(page, classifier.id);
|
||||||
|
await expectOnlyWorkspaceAgentTabsVisible(page, [agents.parent.id]);
|
||||||
|
await expectWorkspaceShownIdle(page, "Classifier workspace");
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("the plugin reads its finish and archives it", async () => {
|
||||||
|
await finishAndArchiveAgent(workspace, classifier.id);
|
||||||
|
await expectOnlyWorkspaceAgentTabsVisible(page, [agents.parent.id]);
|
||||||
|
await expectSubagentRowGone(page, classifier.id);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -928,11 +928,11 @@ test("compact Changes keeps its actions compact and menu-only", async ({ page })
|
|||||||
throw new Error("Compact Changes toolbar geometry could not be measured");
|
throw new Error("Compact Changes toolbar geometry could not be measured");
|
||||||
}
|
}
|
||||||
expect(actionsBox.width).toBe(48);
|
expect(actionsBox.width).toBe(48);
|
||||||
expect(actionsBox.height).toBe(28);
|
expect(actionsBox.height).toBe(32);
|
||||||
expect(optionsBox.width).toBe(32);
|
expect(optionsBox.width).toBe(44);
|
||||||
expect(optionsBox.height).toBe(32);
|
expect(optionsBox.height).toBe(44);
|
||||||
expect(glyphBox.width).toBe(18);
|
expect(glyphBox.width).toBe(20);
|
||||||
expect(glyphBox.height).toBe(18);
|
expect(glyphBox.height).toBe(20);
|
||||||
|
|
||||||
await expect(actions).not.toContainText("Commit");
|
await expect(actions).not.toContainText("Commit");
|
||||||
await expect(actions.locator("svg")).toHaveCount(2);
|
await expect(actions.locator("svg")).toHaveCount(2);
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import { execFileSync } from "node:child_process";
|
import { execFileSync } from "node:child_process";
|
||||||
import { mkdtemp, writeFile } from "node:fs/promises";
|
import { mkdtemp, writeFile } from "node:fs/promises";
|
||||||
import path from "node:path";
|
import path from "node:path";
|
||||||
|
import type { Locator } from "@playwright/test";
|
||||||
import { test, expect, type Page } from "../support/fixtures";
|
import { test, expect, type Page } from "../support/fixtures";
|
||||||
import { getServerId } from "../support/helpers/server-id";
|
import { getServerId } from "../support/helpers/server-id";
|
||||||
import { connectSeedClient } from "../support/helpers/seed-client";
|
import { connectSeedClient } from "../support/helpers/seed-client";
|
||||||
@@ -59,6 +60,14 @@ async function openCompactActionsMenu(page: Page, workspaceId: string) {
|
|||||||
return menu;
|
return menu;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function expectActionsInOrder(menu: Locator, labels: readonly string[]) {
|
||||||
|
const items = menu.getByRole("menuitem");
|
||||||
|
await expect(items).toHaveCount(labels.length);
|
||||||
|
for (const [index, label] of labels.entries()) {
|
||||||
|
await expect(items.nth(index).getByText(label, { exact: true })).toBeVisible();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
test("compact git actions menu lists a promoted Pull once", async ({ page }) => {
|
test("compact git actions menu lists a promoted Pull once", async ({ page }) => {
|
||||||
const repoPath = await createRemoteRepo("compact-menu-pull-");
|
const repoPath = await createRemoteRepo("compact-menu-pull-");
|
||||||
cleanupTasks.push(async () => {
|
cleanupTasks.push(async () => {
|
||||||
@@ -83,12 +92,7 @@ test("compact git actions menu lists a promoted Pull once", async ({ page }) =>
|
|||||||
const menu = await openCompactActionsMenu(page, workspaceId);
|
const menu = await openCompactActionsMenu(page, workspaceId);
|
||||||
|
|
||||||
await expect(menu.getByTestId("changes-menu-pull")).toHaveCount(1);
|
await expect(menu.getByTestId("changes-menu-pull")).toHaveCount(1);
|
||||||
await expect(menu.getByRole("menuitem")).toHaveText([
|
await expectActionsInOrder(menu, ["Pull", "Push", "Pull and push", "Archive workspace"]);
|
||||||
"Pull",
|
|
||||||
"Push",
|
|
||||||
"Pull and push",
|
|
||||||
"Archive workspace",
|
|
||||||
]);
|
|
||||||
});
|
});
|
||||||
|
|
||||||
test("compact git actions menu lists a promoted Push once", async ({ page }) => {
|
test("compact git actions menu lists a promoted Push once", async ({ page }) => {
|
||||||
@@ -106,10 +110,5 @@ test("compact git actions menu lists a promoted Push once", async ({ page }) =>
|
|||||||
const menu = await openCompactActionsMenu(page, workspaceId);
|
const menu = await openCompactActionsMenu(page, workspaceId);
|
||||||
|
|
||||||
await expect(menu.getByTestId("changes-menu-push")).toHaveCount(1);
|
await expect(menu.getByTestId("changes-menu-push")).toHaveCount(1);
|
||||||
await expect(menu.getByRole("menuitem")).toHaveText([
|
await expectActionsInOrder(menu, ["Push", "Pull", "Pull and push", "Archive workspace"]);
|
||||||
"Push",
|
|
||||||
"Pull",
|
|
||||||
"Pull and push",
|
|
||||||
"Archive workspace",
|
|
||||||
]);
|
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,5 +1,6 @@
|
|||||||
import type { Page, TestInfo } from "@playwright/test";
|
import type { Page, TestInfo } from "@playwright/test";
|
||||||
import { test, expect } from "../support/fixtures";
|
import { test, expect } from "../support/fixtures";
|
||||||
|
import { pauseWorkspaceTerminalWorker } from "../support/helpers/workspace-setup";
|
||||||
import { seedWorkspace } from "../support/helpers/seed-client";
|
import { seedWorkspace } from "../support/helpers/seed-client";
|
||||||
import { openAgentRoute } from "../support/helpers/mock-agent";
|
import { openAgentRoute } from "../support/helpers/mock-agent";
|
||||||
import { getServerId } from "../support/helpers/server-id";
|
import { getServerId } from "../support/helpers/server-id";
|
||||||
@@ -190,3 +191,49 @@ test("compact header menu runs, shows, and stops workspace scripts", async ({ pa
|
|||||||
await workspace.cleanup();
|
await workspace.cleanup();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
async function restartScriptAcrossHeaderRemoval(page: Page, terminalId: string) {
|
||||||
|
await openRunningScriptPage(page, "lint");
|
||||||
|
const resumeWorker = await pauseWorkspaceTerminalWorker(terminalId);
|
||||||
|
try {
|
||||||
|
await menuRow(page, "Restart").click();
|
||||||
|
await page.setViewportSize({ width: 1280, height: 844 });
|
||||||
|
await expect(page.getByRole("button", { name: /Switch tabs/ })).toHaveCount(0);
|
||||||
|
await expect(page.getByTestId("workspace-scripts-button")).toBeVisible();
|
||||||
|
} finally {
|
||||||
|
resumeWorker();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
async function expectScriptTerminalReplaced(
|
||||||
|
workspace: Awaited<ReturnType<typeof openWorkspaceWithScripts>>,
|
||||||
|
previousId: string,
|
||||||
|
) {
|
||||||
|
await expect
|
||||||
|
.poll(
|
||||||
|
async () => {
|
||||||
|
const after = await workspace.client.listTerminals(undefined, undefined, {
|
||||||
|
workspaceId: workspace.workspaceId,
|
||||||
|
});
|
||||||
|
return after.terminals.filter((terminal) => terminal.id !== previousId).length;
|
||||||
|
},
|
||||||
|
{ timeout: 15_000 },
|
||||||
|
)
|
||||||
|
.toBe(1);
|
||||||
|
}
|
||||||
|
|
||||||
|
test("pending script restart survives removal of the compact header", async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width: 390, height: 844 });
|
||||||
|
const workspace = await openWorkspaceWithScripts(page);
|
||||||
|
try {
|
||||||
|
await runScriptFromScriptsPage(page, "lint");
|
||||||
|
const before = await workspace.client.listTerminals(undefined, undefined, {
|
||||||
|
workspaceId: workspace.workspaceId,
|
||||||
|
});
|
||||||
|
expect(before.terminals).toHaveLength(1);
|
||||||
|
await restartScriptAcrossHeaderRemoval(page, before.terminals[0]!.id);
|
||||||
|
await expectScriptTerminalReplaced(workspace, before.terminals[0]!.id);
|
||||||
|
} finally {
|
||||||
|
await workspace.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|||||||
@@ -1,5 +1,9 @@
|
|||||||
import { expect, test, type Page } from "../support/fixtures";
|
import { expect, test, type Page } from "../support/fixtures";
|
||||||
import { composerLocator, expectComposerVisible } from "../support/helpers/composer";
|
import {
|
||||||
|
attachFileFromMenu,
|
||||||
|
composerLocator,
|
||||||
|
expectComposerVisible,
|
||||||
|
} from "../support/helpers/composer";
|
||||||
import {
|
import {
|
||||||
openAgentRoute,
|
openAgentRoute,
|
||||||
seedMockAgentWorkspace,
|
seedMockAgentWorkspace,
|
||||||
@@ -365,6 +369,56 @@ function expectPopoverDoesNotDisappearAfterFirstVisible(frames: PopoverFrame[]):
|
|||||||
}
|
}
|
||||||
|
|
||||||
test.describe("Composer autocomplete", () => {
|
test.describe("Composer autocomplete", () => {
|
||||||
|
test("inserts suggested commands from assistant messages without sending", async ({ page }) => {
|
||||||
|
const requests = recordCommandRequestsByAgentId(page);
|
||||||
|
const session = await seedMockAgentWorkspace({
|
||||||
|
repoPrefix: "suggested-command-",
|
||||||
|
title: "Suggested commands",
|
||||||
|
initialPrompt: "Suggest `/mock` without running it",
|
||||||
|
featureValues: { mockAssistantResponse: "Try `/mock` or [Run mock](/mock)." },
|
||||||
|
});
|
||||||
|
try {
|
||||||
|
await openAgentRoute(page, session);
|
||||||
|
const message = page.getByTestId("assistant-message").filter({ hasText: "Run mock" });
|
||||||
|
await expect(message).toBeVisible();
|
||||||
|
await expect(page.getByTestId("user-message").getByRole("link")).toHaveCount(0);
|
||||||
|
await expect.poll(() => requests.length).toBe(1);
|
||||||
|
await attachFileFromMenu(page, {
|
||||||
|
name: "note.txt",
|
||||||
|
mimeType: "text/plain",
|
||||||
|
buffer: Buffer.from("attachment"),
|
||||||
|
});
|
||||||
|
await expect(page.getByTestId("composer-file-attachment-pill")).toContainText("note.txt");
|
||||||
|
await message.getByRole("link", { name: "/mock", exact: true }).click();
|
||||||
|
await expect(composerLocator(page)).toHaveValue("/mock ");
|
||||||
|
await expect(
|
||||||
|
page.getByTestId("composer-autocomplete-popover").filter({ visible: true }),
|
||||||
|
).toHaveCount(0);
|
||||||
|
await expect(composerLocator(page)).toBeFocused();
|
||||||
|
await message.getByRole("link", { name: "Run mock" }).click();
|
||||||
|
await expect(composerLocator(page)).toHaveValue("/mock /mock ");
|
||||||
|
await expect(
|
||||||
|
page.getByTestId("composer-autocomplete-popover").filter({ visible: true }),
|
||||||
|
).toHaveCount(0);
|
||||||
|
await expect(composerLocator(page)).toBeFocused();
|
||||||
|
await expect(page.getByTestId("composer-file-attachment-pill")).toContainText("note.txt");
|
||||||
|
await composerLocator(page).fill("draft");
|
||||||
|
await composerLocator(page).evaluate((element: HTMLTextAreaElement) =>
|
||||||
|
element.setSelectionRange(0, 0),
|
||||||
|
);
|
||||||
|
await message.getByRole("link", { name: "/mock", exact: true }).click();
|
||||||
|
await composerLocator(page).pressSequentially("argument");
|
||||||
|
await expect(composerLocator(page)).toHaveValue("draft /mock argument");
|
||||||
|
await composerLocator(page).fill("/");
|
||||||
|
await expect(
|
||||||
|
page.getByTestId("composer-autocomplete-popover").filter({ visible: true }),
|
||||||
|
).toContainText("/mock");
|
||||||
|
expect(requests).toHaveLength(1);
|
||||||
|
} finally {
|
||||||
|
await session.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
test("keeps New workspace off the running-agent command list before a project is chosen", async ({
|
test("keeps New workspace off the running-agent command list before a project is chosen", async ({
|
||||||
page,
|
page,
|
||||||
}) => {
|
}) => {
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import {
|
|||||||
recordComposerToolbarFrames,
|
recordComposerToolbarFrames,
|
||||||
} from "../support/helpers/composer-control-density";
|
} from "../support/helpers/composer-control-density";
|
||||||
import { clickNewChat, gotoWorkspace } from "../support/helpers/launcher";
|
import { clickNewChat, gotoWorkspace } from "../support/helpers/launcher";
|
||||||
|
import { openAgentRoute, seedMockAgentWorkspace } from "../support/helpers/mock-agent";
|
||||||
import { seedWorkspace, type SeededWorkspace } from "../support/helpers/seed-client";
|
import { seedWorkspace, type SeededWorkspace } from "../support/helpers/seed-client";
|
||||||
|
|
||||||
const SETTLE_MS = 1_000;
|
const SETTLE_MS = 1_000;
|
||||||
@@ -92,3 +93,34 @@ test.describe("Composer control density across tab switches", () => {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test.describe("Composer controls folding on a touch device", () => {
|
||||||
|
test.use({ viewport: { width: 1194, height: 834 }, isMobile: true, hasTouch: true });
|
||||||
|
test.describe.configure({ timeout: 180_000 });
|
||||||
|
|
||||||
|
test("an open menu stays closed after the controls fold and unfold", async ({ page }) => {
|
||||||
|
const session = await seedMockAgentWorkspace({
|
||||||
|
repoPrefix: "composer-density-fold-",
|
||||||
|
title: "Folding chat",
|
||||||
|
model: "ten-second-stream",
|
||||||
|
});
|
||||||
|
try {
|
||||||
|
await openAgentRoute(page, session);
|
||||||
|
const thinking = page.getByTestId("agent-thinking-selector").filter({ visible: true });
|
||||||
|
const thinkingMenu = page.getByTestId("combobox-desktop-container");
|
||||||
|
|
||||||
|
await thinking.click();
|
||||||
|
await expect(thinkingMenu).toBeVisible();
|
||||||
|
|
||||||
|
// Still a wide layout, but too narrow for separate controls: they fold into the model control.
|
||||||
|
await page.setViewportSize({ width: 640, height: 834 });
|
||||||
|
await expect(thinking).toHaveCount(0);
|
||||||
|
|
||||||
|
await page.setViewportSize({ width: 1194, height: 834 });
|
||||||
|
await expect(thinking).toBeVisible();
|
||||||
|
await expect(thinkingMenu).toHaveCount(0);
|
||||||
|
} finally {
|
||||||
|
await session.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -18,7 +18,7 @@ function visibleMainPane(page: Page) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function composerChangesPill(page: Page) {
|
function composerChangesPill(page: Page) {
|
||||||
return page.getByTestId("composer-diff-stat-pill");
|
return page.getByRole("button", { name: "Open Changes tab", exact: true });
|
||||||
}
|
}
|
||||||
|
|
||||||
async function revealComposerChangesInExplorer(page: Page) {
|
async function revealComposerChangesInExplorer(page: Page) {
|
||||||
@@ -78,7 +78,8 @@ test("composer diff stat reveals Changes, then opens the diff in the configured
|
|||||||
const workspace = await seedChangedAgent("composer-diff-stat-side-");
|
const workspace = await seedChangedAgent("composer-diff-stat-side-");
|
||||||
|
|
||||||
try {
|
try {
|
||||||
await page.setViewportSize({ width: 1400, height: 900 });
|
// Keep both workspace rails visible alongside app navigation and Explorer.
|
||||||
|
await page.setViewportSize({ width: 1900, height: 900 });
|
||||||
await openAgentRoute(page, {
|
await openAgentRoute(page, {
|
||||||
workspaceId: workspace.workspaceId,
|
workspaceId: workspace.workspaceId,
|
||||||
agentId: workspace.agentId,
|
agentId: workspace.agentId,
|
||||||
@@ -498,6 +499,7 @@ test.describe("send review feedback", () => {
|
|||||||
test("only open tabs in this workspace appear in compact and wide recipient menus", async ({
|
test("only open tabs in this workspace appear in compact and wide recipient menus", async ({
|
||||||
page,
|
page,
|
||||||
}) => {
|
}) => {
|
||||||
|
test.setTimeout(120000);
|
||||||
const workspace = await seedChangedAgent("review-feedback-multiple-");
|
const workspace = await seedChangedAgent("review-feedback-multiple-");
|
||||||
const other = await seedChangedAgent("review-feedback-other-");
|
const other = await seedChangedAgent("review-feedback-other-");
|
||||||
try {
|
try {
|
||||||
|
|||||||
@@ -25,7 +25,7 @@ import {
|
|||||||
expectMobileAgentSidebarVisible,
|
expectMobileAgentSidebarVisible,
|
||||||
expectMobileExplorerHidden,
|
expectMobileExplorerHidden,
|
||||||
expectMobileExplorerVisible,
|
expectMobileExplorerVisible,
|
||||||
swipeOpenMobileAgentSidebar,
|
openMobileAgentSidebarWithKeyboard,
|
||||||
swipeOpenMobileExplorer,
|
swipeOpenMobileExplorer,
|
||||||
} from "../support/helpers/sidebar";
|
} from "../support/helpers/sidebar";
|
||||||
import { readScrollMetrics } from "../support/helpers/agent-bottom-anchor";
|
import { readScrollMetrics } from "../support/helpers/agent-bottom-anchor";
|
||||||
@@ -249,7 +249,7 @@ test.describe("touch screen wide enough for the desktop layout", () => {
|
|||||||
const COMPACT_PANELS = [
|
const COMPACT_PANELS = [
|
||||||
{
|
{
|
||||||
name: "agent list",
|
name: "agent list",
|
||||||
open: swipeOpenMobileAgentSidebar,
|
open: openMobileAgentSidebarWithKeyboard,
|
||||||
expectOpen: expectMobileAgentSidebarVisible,
|
expectOpen: expectMobileAgentSidebarVisible,
|
||||||
close: closeMobileAgentSidebar,
|
close: closeMobileAgentSidebar,
|
||||||
expectClosed: expectMobileAgentSidebarHidden,
|
expectClosed: expectMobileAgentSidebarHidden,
|
||||||
|
|||||||
@@ -3,7 +3,7 @@ import {
|
|||||||
composerLocator,
|
composerLocator,
|
||||||
expectComposerDraft,
|
expectComposerDraft,
|
||||||
expectComposerVisible,
|
expectComposerVisible,
|
||||||
submitMessage,
|
fillComposerDraft,
|
||||||
typeIntoFocusedComposer,
|
typeIntoFocusedComposer,
|
||||||
} from "../support/helpers/composer";
|
} from "../support/helpers/composer";
|
||||||
import { openAgentRoute, seedMockAgentWorkspace } from "../support/helpers/mock-agent";
|
import { openAgentRoute, seedMockAgentWorkspace } from "../support/helpers/mock-agent";
|
||||||
@@ -12,8 +12,14 @@ function userMessages(page: Page) {
|
|||||||
return page.getByTestId("user-message");
|
return page.getByTestId("user-message");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function sendDraftWhenReady(page: Page) {
|
||||||
|
await expect(page.getByRole("button", { name: "Send message", exact: true })).toBeEnabled();
|
||||||
|
await pressInComposer(page, "Enter");
|
||||||
|
}
|
||||||
|
|
||||||
async function sendAndWaitForMessage(page: Page, text: string, expectedCount: number) {
|
async function sendAndWaitForMessage(page: Page, text: string, expectedCount: number) {
|
||||||
await submitMessage(page, text);
|
await fillComposerDraft(page, text);
|
||||||
|
await sendDraftWhenReady(page);
|
||||||
await expect(userMessages(page)).toHaveCount(expectedCount, { timeout: 30_000 });
|
await expect(userMessages(page)).toHaveCount(expectedCount, { timeout: 30_000 });
|
||||||
await expectComposerDraft(page, "");
|
await expectComposerDraft(page, "");
|
||||||
}
|
}
|
||||||
@@ -49,7 +55,7 @@ test.describe("Composer recall", () => {
|
|||||||
await pressInComposer(page, "ArrowUp");
|
await pressInComposer(page, "ArrowUp");
|
||||||
await expectComposerDraft(page, "add tests for login");
|
await expectComposerDraft(page, "add tests for login");
|
||||||
|
|
||||||
await pressInComposer(page, "Enter");
|
await sendDraftWhenReady(page);
|
||||||
await expect(userMessages(page)).toHaveCount(3, { timeout: 30_000 });
|
await expect(userMessages(page)).toHaveCount(3, { timeout: 30_000 });
|
||||||
await expect(userMessages(page).last()).toContainText("add tests for login");
|
await expect(userMessages(page).last()).toContainText("add tests for login");
|
||||||
} finally {
|
} finally {
|
||||||
|
|||||||
@@ -37,7 +37,7 @@ import {
|
|||||||
closeMobileAgentSidebar,
|
closeMobileAgentSidebar,
|
||||||
expectMobileAgentSidebarHidden,
|
expectMobileAgentSidebarHidden,
|
||||||
expectMobileAgentSidebarVisible,
|
expectMobileAgentSidebarVisible,
|
||||||
swipeOpenMobileAgentSidebar,
|
openMobileAgentSidebarWithKeyboard,
|
||||||
} from "../support/helpers/sidebar";
|
} from "../support/helpers/sidebar";
|
||||||
|
|
||||||
async function composerHeight(page: Page): Promise<number> {
|
async function composerHeight(page: Page): Promise<number> {
|
||||||
@@ -541,8 +541,8 @@ test("the compact sidebar over a fullscreen editor leaves the exit action alone"
|
|||||||
await writeCompactDraft(page, draft);
|
await writeCompactDraft(page, draft);
|
||||||
await enterComposerFullscreen(page);
|
await enterComposerFullscreen(page);
|
||||||
await expectWorkspaceHeaderHidden(page);
|
await expectWorkspaceHeaderHidden(page);
|
||||||
// Fullscreen hides the header's menu button; the edge swipe still opens the list over it.
|
// Fullscreen hides the header's menu button; the keyboard shortcut opens the list over it.
|
||||||
await swipeOpenMobileAgentSidebar(page);
|
await openMobileAgentSidebarWithKeyboard(page);
|
||||||
await expectMobileAgentSidebarVisible(page);
|
await expectMobileAgentSidebarVisible(page);
|
||||||
// The list covers the pane, so the editor's exit action is not armed.
|
// The list covers the pane, so the editor's exit action is not armed.
|
||||||
await page.keyboard.press("Escape");
|
await page.keyboard.press("Escape");
|
||||||
|
|||||||
@@ -429,6 +429,32 @@ test("context details support keyboard entry and dismiss when the viewport moves
|
|||||||
await expect(details).toHaveCount(0);
|
await expect(details).toHaveCount(0);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("context details stay open while the chat streams", async ({ page }) => {
|
||||||
|
test.setTimeout(120_000);
|
||||||
|
await page.setViewportSize(DESKTOP);
|
||||||
|
const session = await seedMockAgentWorkspace({
|
||||||
|
repoPrefix: "context-window-streaming-",
|
||||||
|
title: "Context details while streaming",
|
||||||
|
model: "ten-second-stream",
|
||||||
|
});
|
||||||
|
try {
|
||||||
|
await openAgentRoute(page, session);
|
||||||
|
await expectComposerVisible(page);
|
||||||
|
await submitMessageWithButton(page, "Stream while the context details are open.");
|
||||||
|
const stop = page.getByRole("button", { name: /stop|cancel/i }).first();
|
||||||
|
await expect(stop).toBeVisible();
|
||||||
|
const details = await pressContextWindowMeter(page, /^Context window/);
|
||||||
|
await expect(stop).toBeVisible();
|
||||||
|
await qaScreenshot(page, "context-details-while-streaming");
|
||||||
|
|
||||||
|
await expect(stop).toHaveCount(0, { timeout: 30_000 });
|
||||||
|
await expect(details).toBeVisible();
|
||||||
|
await qaScreenshot(page, "context-details-after-streaming");
|
||||||
|
} finally {
|
||||||
|
await session.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
test("pointer hovering context details preserves composer focus", async ({ page, agent }) => {
|
test("pointer hovering context details preserves composer focus", async ({ page, agent }) => {
|
||||||
const usage = await scriptAgentUsage(page);
|
const usage = await scriptAgentUsage(page);
|
||||||
await page.setViewportSize(DESKTOP);
|
await page.setViewportSize(DESKTOP);
|
||||||
|
|||||||
@@ -1,8 +1,9 @@
|
|||||||
import { randomUUID } from "node:crypto";
|
import { randomUUID } from "node:crypto";
|
||||||
import { mkdtemp, writeFile } from "node:fs/promises";
|
import { mkdtemp, writeFile, rm } from "node:fs/promises";
|
||||||
|
import { existsSync } from "node:fs";
|
||||||
import { tmpdir } from "node:os";
|
import { tmpdir } from "node:os";
|
||||||
import path from "node:path";
|
import path from "node:path";
|
||||||
import { expect, test } from "../support/fixtures";
|
import { expect, test, daemonTest as cleanupTest } from "../support/fixtures";
|
||||||
import { startIsolatedHostDaemon } from "../support/helpers/isolated-host-daemon";
|
import { startIsolatedHostDaemon } from "../support/helpers/isolated-host-daemon";
|
||||||
import {
|
import {
|
||||||
openDaemonOverview,
|
openDaemonOverview,
|
||||||
@@ -13,6 +14,10 @@ import {
|
|||||||
readWorkerPid,
|
readWorkerPid,
|
||||||
openLongLivedTerminal,
|
openLongLivedTerminal,
|
||||||
listTerminalIds,
|
listTerminalIds,
|
||||||
|
suspendDaemonProcess,
|
||||||
|
resumeDaemonProcess,
|
||||||
|
daemonProcessCanWrite,
|
||||||
|
readTerminalProcessIds,
|
||||||
} from "../support/helpers/daemon-lifecycle";
|
} from "../support/helpers/daemon-lifecycle";
|
||||||
|
|
||||||
test("settings restart waits for a replacement worker while retaining the supervisor", async ({
|
test("settings restart waits for a replacement worker while retaining the supervisor", async ({
|
||||||
@@ -119,3 +124,51 @@ async function createHomeWithSlowProvider(versionDelayMs: number): Promise<strin
|
|||||||
);
|
);
|
||||||
return paseoHome;
|
return paseoHome;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Cleanup has no renderer demand: drive the same isolated daemon owner directly.
|
||||||
|
// A stopped worker deterministically outlives the old helper's five-second
|
||||||
|
// supervisor-only kill and logs into its deleted home when resumed.
|
||||||
|
cleanupTest(
|
||||||
|
"isolated cleanup prevents a stopped worker from recreating its deleted home",
|
||||||
|
async () => {
|
||||||
|
cleanupTest.skip(process.platform === "win32", "POSIX stopped-process failure injection");
|
||||||
|
const daemon = await startIsolatedHostDaemon(randomUUID());
|
||||||
|
const workerPid = await readWorkerPid(daemon);
|
||||||
|
try {
|
||||||
|
suspendDaemonProcess(workerPid);
|
||||||
|
await daemon.close();
|
||||||
|
resumeDaemonProcess(workerPid);
|
||||||
|
await expect.poll(() => daemonProcessCanWrite(workerPid)).toBe(false);
|
||||||
|
expect(existsSync(daemon.paseoHome)).toBe(false);
|
||||||
|
} finally {
|
||||||
|
resumeDaemonProcess(workerPid);
|
||||||
|
await daemon.close();
|
||||||
|
await rm(daemon.paseoHome, { recursive: true, force: true });
|
||||||
|
}
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
cleanupTest(
|
||||||
|
"isolated cleanup force-stops a frozen supervisor and its detached terminal writers",
|
||||||
|
async () => {
|
||||||
|
cleanupTest.skip(process.platform === "win32", "POSIX stopped-process failure injection");
|
||||||
|
const daemon = await startIsolatedHostDaemon(randomUUID());
|
||||||
|
const supervisorPid = daemon.getPid()!;
|
||||||
|
const workerPid = await readWorkerPid(daemon);
|
||||||
|
try {
|
||||||
|
await openLongLivedTerminal(daemon);
|
||||||
|
const terminalProcesses = await readTerminalProcessIds(daemon);
|
||||||
|
expect(terminalProcesses.length).toBeGreaterThanOrEqual(2);
|
||||||
|
suspendDaemonProcess(supervisorPid);
|
||||||
|
await daemon.close();
|
||||||
|
const writerStates = await Promise.all(
|
||||||
|
[supervisorPid, workerPid, ...terminalProcesses].map(daemonProcessCanWrite),
|
||||||
|
);
|
||||||
|
expect(writerStates).toEqual(Array(terminalProcesses.length + 2).fill(false));
|
||||||
|
expect(existsSync(daemon.paseoHome)).toBe(false);
|
||||||
|
} finally {
|
||||||
|
resumeDaemonProcess(supervisorPid);
|
||||||
|
await daemon.close();
|
||||||
|
}
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|||||||
@@ -1,3 +1,5 @@
|
|||||||
|
import { installLocalDesktopHost } from "../support/helpers/local-desktop-host";
|
||||||
|
import type { Locator, Page } from "@playwright/test";
|
||||||
import { expect, test } from "../support/fixtures";
|
import { expect, test } from "../support/fixtures";
|
||||||
import { runWorkspaceActionFromCommandCenter } from "../support/helpers/command-center-workspace-actions";
|
import { runWorkspaceActionFromCommandCenter } from "../support/helpers/command-center-workspace-actions";
|
||||||
import {
|
import {
|
||||||
@@ -9,6 +11,7 @@ import { seedWorkspace } from "../support/helpers/seed-client";
|
|||||||
import { waitForWorkspaceTabsVisible } from "../support/helpers/workspace-tabs";
|
import { waitForWorkspaceTabsVisible } from "../support/helpers/workspace-tabs";
|
||||||
|
|
||||||
test.describe("Direct terminal shortcut pane placement", () => {
|
test.describe("Direct terminal shortcut pane placement", () => {
|
||||||
|
test.use({ viewport: { width: 1600, height: 900 } });
|
||||||
test("opens a terminal in the focused pane", async ({ page }) => {
|
test("opens a terminal in the focused pane", async ({ page }) => {
|
||||||
const workspace = await seedWorkspace({ repoPrefix: "direct-terminal-shortcut-pane-" });
|
const workspace = await seedWorkspace({ repoPrefix: "direct-terminal-shortcut-pane-" });
|
||||||
|
|
||||||
@@ -47,3 +50,88 @@ test.describe("Direct terminal shortcut pane placement", () => {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
async function prepareUnfocusedCompactPane(page: Page, workspaceId: string) {
|
||||||
|
await page.setViewportSize({ width: 1600, height: 900 });
|
||||||
|
await gotoWorkspace(page, workspaceId);
|
||||||
|
await waitForWorkspaceTabsVisible(page);
|
||||||
|
await clickNewChat(page);
|
||||||
|
await runWorkspaceActionFromCommandCenter(page, "Split pane right");
|
||||||
|
const draftPane = page
|
||||||
|
.locator('[data-testid^="workspace-pane-"]')
|
||||||
|
.filter({ has: page.getByTestId("message-input-root") });
|
||||||
|
const emptyPane = page
|
||||||
|
.locator('[data-testid^="workspace-pane-"]')
|
||||||
|
.filter({ has: page.getByTestId("workspace-new-tab-panel") });
|
||||||
|
const draftPaneId = await draftPane.getAttribute("data-testid");
|
||||||
|
const emptyPaneId = await emptyPane.getAttribute("data-testid");
|
||||||
|
expect(draftPaneId).not.toBeNull();
|
||||||
|
expect(emptyPaneId).not.toBeNull();
|
||||||
|
await page.setViewportSize({ width: 760, height: 900 });
|
||||||
|
return {
|
||||||
|
originalPane: page.getByTestId(draftPaneId!),
|
||||||
|
otherPane: page.getByTestId(emptyPaneId!),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
async function launchTerminalFromCompactPane(page: Page, pane: Locator) {
|
||||||
|
await pane.getByTestId("workspace-tab-switcher-trigger").click();
|
||||||
|
await page.getByTestId("workspace-tab-switcher-new-terminal").click();
|
||||||
|
await expect(pane.getByTestId("terminal-surface")).toBeVisible({ timeout: 30_000 });
|
||||||
|
}
|
||||||
|
|
||||||
|
async function maximizeAndRestoreCompactPane(page: Page, pane: Locator) {
|
||||||
|
await pane.getByTestId("workspace-header-menu-trigger").click();
|
||||||
|
await expect(page.getByRole("menuitem", { name: "Split pane right", exact: true })).toBeVisible();
|
||||||
|
await page.getByRole("menuitem", { name: "Maximize pane", exact: true }).click();
|
||||||
|
await pane.getByTestId("workspace-header-menu-trigger").click();
|
||||||
|
await page.getByRole("menuitem", { name: "Restore pane", exact: true }).click();
|
||||||
|
}
|
||||||
|
|
||||||
|
test("compact pane launch stays in its owning pane and pane controls remain reachable", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
const workspace = await seedWorkspace({ repoPrefix: "compact-pane-launch-" });
|
||||||
|
try {
|
||||||
|
const { originalPane, otherPane } = await prepareUnfocusedCompactPane(
|
||||||
|
page,
|
||||||
|
workspace.workspaceId,
|
||||||
|
);
|
||||||
|
await launchTerminalFromCompactPane(page, originalPane);
|
||||||
|
await expect(otherPane.getByTestId("workspace-new-tab-panel")).toBeVisible();
|
||||||
|
await maximizeAndRestoreCompactPane(page, originalPane);
|
||||||
|
await expect(otherPane).toBeVisible();
|
||||||
|
} finally {
|
||||||
|
await workspace.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
async function expectPaneHasWindowDragSurface(pane: Locator) {
|
||||||
|
await expect
|
||||||
|
.poll(() =>
|
||||||
|
pane.evaluate((element) =>
|
||||||
|
Array.from(element.querySelectorAll<HTMLElement>("div")).some(
|
||||||
|
(node) => node.style.getPropertyValue("-webkit-app-region") === "drag",
|
||||||
|
),
|
||||||
|
),
|
||||||
|
)
|
||||||
|
.toBe(true);
|
||||||
|
}
|
||||||
|
|
||||||
|
test("compact desktop panes retain window dragging with both sidebars closed", async ({ page }) => {
|
||||||
|
const workspace = await seedWorkspace({ repoPrefix: "compact-pane-window-drag-" });
|
||||||
|
try {
|
||||||
|
await installLocalDesktopHost(page, workspace.repoPath);
|
||||||
|
const { originalPane, otherPane } = await prepareUnfocusedCompactPane(
|
||||||
|
page,
|
||||||
|
workspace.workspaceId,
|
||||||
|
);
|
||||||
|
await runWorkspaceActionFromCommandCenter(page, "Toggle left sidebar");
|
||||||
|
await expect(originalPane.getByTestId("workspace-tab-switcher-trigger")).toBeVisible();
|
||||||
|
await expect(otherPane.getByTestId("workspace-tab-switcher-trigger")).toBeVisible();
|
||||||
|
await expectPaneHasWindowDragSurface(originalPane);
|
||||||
|
await expectPaneHasWindowDragSurface(otherPane);
|
||||||
|
} finally {
|
||||||
|
await workspace.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|||||||
@@ -56,9 +56,9 @@ test.describe("New tab keyboard launcher", () => {
|
|||||||
await expectLauncherSelection(launcher, "Diff");
|
await expectLauncherSelection(launcher, "Diff");
|
||||||
await page.keyboard.press("Enter");
|
await page.keyboard.press("Enter");
|
||||||
|
|
||||||
await expect(
|
await expect(page.getByTestId("working-diff-panel").filter({ visible: true })).toBeVisible({
|
||||||
page.getByTestId("workspace-tab-working_diff").filter({ visible: true }),
|
timeout: 30_000,
|
||||||
).toBeVisible({ timeout: 30_000 });
|
});
|
||||||
} finally {
|
} finally {
|
||||||
await workspace.cleanup();
|
await workspace.cleanup();
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -105,6 +105,9 @@ function collectConsoleErrors(page: Page): string[] {
|
|||||||
return errors;
|
return errors;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// These drag and tab-menu journeys need full rails beside the docked Explorer.
|
||||||
|
test.use({ viewport: { width: 1900, height: 900 } });
|
||||||
|
|
||||||
test.describe("explorer pane tab placement", () => {
|
test.describe("explorer pane tab placement", () => {
|
||||||
test("agents open in the main pane and New-tab splits keep the app usable", async ({
|
test("agents open in the main pane and New-tab splits keep the app usable", async ({
|
||||||
page,
|
page,
|
||||||
|
|||||||
@@ -63,6 +63,24 @@ function htmlPreview(page: Page) {
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function followHtmlPreviewLink(page: Page, name: string): Promise<void> {
|
||||||
|
await htmlPreview(page).document.getByRole("link", { name, exact: true }).click();
|
||||||
|
}
|
||||||
|
|
||||||
|
async function expectPageHandlesFragment(
|
||||||
|
page: Page,
|
||||||
|
handler: "Document" | "Window",
|
||||||
|
): Promise<void> {
|
||||||
|
const preview = htmlPreview(page);
|
||||||
|
await followHtmlPreviewLink(page, `${handler} handled jump`);
|
||||||
|
await expect(preview.document.getByRole("status")).toHaveText(`${handler} handled click`);
|
||||||
|
await expect(
|
||||||
|
preview.document.getByRole("heading", { name: "Target section" }),
|
||||||
|
).not.toBeInViewport();
|
||||||
|
expect(await preview.document.locator("body").evaluate(() => location.hash)).toBe("");
|
||||||
|
expect(await preview.document.locator("body").evaluate(() => window.scrollY)).toBe(0);
|
||||||
|
}
|
||||||
|
|
||||||
async function selectFileView(page: Page, view: "Preview" | "Source"): Promise<void> {
|
async function selectFileView(page: Page, view: "Preview" | "Source"): Promise<void> {
|
||||||
const option = page.getByTestId("file-panel-bar").getByRole("button", {
|
const option = page.getByTestId("file-panel-bar").getByRole("button", {
|
||||||
name: view,
|
name: view,
|
||||||
@@ -417,7 +435,8 @@ test.describe("CodeMirror workspace file editing", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
try {
|
try {
|
||||||
await page.setViewportSize({ width: 1280, height: 900 });
|
// Keep both tab rails available alongside the docked Explorer.
|
||||||
|
await page.setViewportSize({ width: 1900, height: 900 });
|
||||||
await openAgentRoute(page, session);
|
await openAgentRoute(page, session);
|
||||||
|
|
||||||
await openWorkspaceFile(page, "target.ts");
|
await openWorkspaceFile(page, "target.ts");
|
||||||
@@ -826,6 +845,192 @@ test.describe("CodeMirror workspace file editing", () => {
|
|||||||
await expect(preview.host).toBeVisible();
|
await expect(preview.host).toBeVisible();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("keeps HTML fragment links in the preview and scrolls to the target", async ({
|
||||||
|
page,
|
||||||
|
withWorkspace,
|
||||||
|
}) => {
|
||||||
|
const workspace = await withWorkspace({ prefix: "html-fragments-" });
|
||||||
|
await writeFile(
|
||||||
|
path.join(workspace.repoPath, "fragments.html"),
|
||||||
|
`<!doctype html><html><body>
|
||||||
|
<a href="#section">Jump to section</a>
|
||||||
|
<div style="height: 1200px"></div>
|
||||||
|
<h2 id="section">Target section</h2>
|
||||||
|
</body></html>`,
|
||||||
|
"utf8",
|
||||||
|
);
|
||||||
|
await workspace.navigateTo();
|
||||||
|
await openWorkspaceFile(page, "fragments.html");
|
||||||
|
|
||||||
|
const preview = htmlPreview(page);
|
||||||
|
await expect(preview.document.getByRole("link", { name: "Jump to section" })).toBeVisible();
|
||||||
|
await page.screenshot({ path: test.info().outputPath("fragment-before-click.png") });
|
||||||
|
await preview.document.getByRole("link", { name: "Jump to section" }).click();
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
preview.document.getByRole("heading", { name: "Target section" }),
|
||||||
|
).toBeInViewport();
|
||||||
|
expect(await preview.document.locator("body").evaluate(() => location.hash)).toBe("#section");
|
||||||
|
expect(await preview.document.locator("body").evaluate(() => window.scrollY)).toBeGreaterThan(
|
||||||
|
0,
|
||||||
|
);
|
||||||
|
await page.screenshot({ path: test.info().outputPath("fragment-after-click.png") });
|
||||||
|
});
|
||||||
|
|
||||||
|
test("lets an HTML page prevent fragment navigation", async ({ page, withWorkspace }) => {
|
||||||
|
const workspace = await withWorkspace({ prefix: "html-fragment-handler-" });
|
||||||
|
await writeFile(
|
||||||
|
path.join(workspace.repoPath, "handled.html"),
|
||||||
|
`<!doctype html><html><body>
|
||||||
|
<a href="#section" onclick="event.preventDefault(); document.querySelector('output').textContent = 'Page handled click'">Handled jump</a>
|
||||||
|
<output>Waiting for click</output>
|
||||||
|
<div style="height: 1200px"></div><h2 id="section">Target section</h2>
|
||||||
|
</body></html>`,
|
||||||
|
"utf8",
|
||||||
|
);
|
||||||
|
await workspace.navigateTo();
|
||||||
|
await openWorkspaceFile(page, "handled.html");
|
||||||
|
|
||||||
|
const preview = htmlPreview(page);
|
||||||
|
await preview.document.getByRole("link", { name: "Handled jump" }).click();
|
||||||
|
await expect(preview.document.locator("output")).toHaveText("Page handled click");
|
||||||
|
await expect(
|
||||||
|
preview.document.getByRole("heading", { name: "Target section" }),
|
||||||
|
).not.toBeInViewport();
|
||||||
|
expect(await preview.document.locator("body").evaluate(() => location.hash)).toBe("");
|
||||||
|
expect(await preview.document.locator("body").evaluate(() => window.scrollY)).toBe(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("respects delegated HTML fragment handlers and normal URL parsing", async ({
|
||||||
|
page,
|
||||||
|
withWorkspace,
|
||||||
|
}) => {
|
||||||
|
const workspace = await withWorkspace({ prefix: "html-fragment-defaults-" });
|
||||||
|
await writeFile(
|
||||||
|
path.join(workspace.repoPath, "defaults.html"),
|
||||||
|
`<!doctype html><html><body>
|
||||||
|
<nav style="position: fixed; top: 0; background: white">
|
||||||
|
<a href="#section" id="document-handler">Document handled jump</a>
|
||||||
|
<a href="#section" id="window-handler">Window handled jump</a>
|
||||||
|
<a href=" \t#section\n">Whitespace jump</a>
|
||||||
|
<a href="#100%">Percent jump</a>
|
||||||
|
<output>Waiting for click</output>
|
||||||
|
</nav>
|
||||||
|
<div style="height: 1200px"></div><h2 id="section">Target section</h2>
|
||||||
|
<div style="height: 1200px"></div><h2 id="100%">Percent target</h2>
|
||||||
|
<div style="height: 1200px"></div>
|
||||||
|
<script>
|
||||||
|
document.addEventListener('click', function(event) {
|
||||||
|
if (event.target.id === 'document-handler') {
|
||||||
|
event.preventDefault(); document.querySelector('output').textContent = 'Document handled click';
|
||||||
|
}
|
||||||
|
});
|
||||||
|
window.addEventListener('click', function(event) {
|
||||||
|
if (event.target.id === 'window-handler') {
|
||||||
|
event.preventDefault(); document.querySelector('output').textContent = 'Window handled click';
|
||||||
|
}
|
||||||
|
});
|
||||||
|
</script></body></html>`,
|
||||||
|
"utf8",
|
||||||
|
);
|
||||||
|
await workspace.navigateTo();
|
||||||
|
await openWorkspaceFile(page, "defaults.html");
|
||||||
|
|
||||||
|
const preview = htmlPreview(page);
|
||||||
|
await expectPageHandlesFragment(page, "Document");
|
||||||
|
await expectPageHandlesFragment(page, "Window");
|
||||||
|
|
||||||
|
await followHtmlPreviewLink(page, "Whitespace jump");
|
||||||
|
await expect(
|
||||||
|
preview.document.getByRole("heading", { name: "Target section" }),
|
||||||
|
).toBeInViewport();
|
||||||
|
await followHtmlPreviewLink(page, "Percent jump");
|
||||||
|
await expect(
|
||||||
|
preview.document.getByRole("heading", { name: "Percent target" }),
|
||||||
|
).toBeInViewport();
|
||||||
|
});
|
||||||
|
|
||||||
|
test("handles HTML fragment targets, empty and missing fragments, and modified clicks", async ({
|
||||||
|
page,
|
||||||
|
withWorkspace,
|
||||||
|
}) => {
|
||||||
|
const workspace = await withWorkspace({ prefix: "html-fragment-targets-" });
|
||||||
|
await writeFile(
|
||||||
|
path.join(workspace.repoPath, "targets.html"),
|
||||||
|
`<!doctype html><html><head><style>:target { color: rgb(255, 0, 0); }</style></head><body>
|
||||||
|
<nav style="position: fixed; top: 0; background: white">
|
||||||
|
<a href="#section"><span>Nested jump</span></a>
|
||||||
|
<a href="#legacy">Named jump</a>
|
||||||
|
<a href="#encoded%20section">Encoded jump</a>
|
||||||
|
<a href="#missing">Missing jump</a>
|
||||||
|
<a href="#">Empty jump</a>
|
||||||
|
<output>Waiting for hashchange</output><output id="modified">Waiting for modified click</output>
|
||||||
|
</nav>
|
||||||
|
<div style="height: 1200px"></div><h2 id="section">Target section</h2>
|
||||||
|
<div style="height: 1200px"></div><a name="legacy">Named target</a>
|
||||||
|
<div style="height: 1200px"></div><h2 id="encoded section">Encoded target</h2>
|
||||||
|
<div style="height: 1200px"></div>
|
||||||
|
<script>
|
||||||
|
window.addEventListener('hashchange', function () { document.querySelector('output').textContent = location.hash || '(empty)'; });
|
||||||
|
function modifiedClick(event) {
|
||||||
|
if (event.button === 1 || event.ctrlKey || event.metaKey || event.shiftKey || event.altKey) {
|
||||||
|
document.getElementById('modified').textContent = String(event.defaultPrevented);
|
||||||
|
event.preventDefault();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
window.addEventListener('click', modifiedClick);
|
||||||
|
window.addEventListener('auxclick', modifiedClick);
|
||||||
|
window.addEventListener('contextmenu', modifiedClick);
|
||||||
|
</script></body></html>`,
|
||||||
|
"utf8",
|
||||||
|
);
|
||||||
|
await workspace.navigateTo();
|
||||||
|
await openWorkspaceFile(page, "targets.html");
|
||||||
|
|
||||||
|
const preview = htmlPreview(page);
|
||||||
|
const body = preview.document.locator("body");
|
||||||
|
const nested = preview.document.getByText("Nested jump", { exact: true });
|
||||||
|
await nested.click();
|
||||||
|
await expect(preview.document.locator("output").first()).toHaveText("#section");
|
||||||
|
await expect(
|
||||||
|
preview.document.getByRole("heading", { name: "Target section" }),
|
||||||
|
).toBeInViewport();
|
||||||
|
await expect(preview.document.locator("#section")).toHaveCSS("color", "rgb(255, 0, 0)");
|
||||||
|
|
||||||
|
await body.evaluate(() => window.scrollTo(0, 0));
|
||||||
|
await nested.click();
|
||||||
|
await expect(
|
||||||
|
preview.document.getByRole("heading", { name: "Target section" }),
|
||||||
|
).toBeInViewport();
|
||||||
|
|
||||||
|
await preview.document.getByRole("link", { name: "Named jump" }).click();
|
||||||
|
await expect(preview.document.getByText("Named target", { exact: true })).toBeInViewport();
|
||||||
|
await expect(preview.document.locator("output").first()).toHaveText("#legacy");
|
||||||
|
|
||||||
|
await preview.document.getByRole("link", { name: "Encoded jump" }).click();
|
||||||
|
await expect(
|
||||||
|
preview.document.getByRole("heading", { name: "Encoded target" }),
|
||||||
|
).toBeInViewport();
|
||||||
|
await expect(preview.document.locator("output").first()).toHaveText("#encoded%20section");
|
||||||
|
const scrollY = await body.evaluate(() => window.scrollY);
|
||||||
|
await preview.document.getByRole("link", { name: "Missing jump" }).click();
|
||||||
|
expect(await body.evaluate(() => location.hash)).toBe("#missing");
|
||||||
|
expect(await body.evaluate(() => window.scrollY)).toBe(scrollY);
|
||||||
|
|
||||||
|
await preview.document.getByRole("link", { name: "Empty jump" }).click();
|
||||||
|
await expect(preview.document.locator("output").first()).toHaveText("(empty)");
|
||||||
|
expect(await body.evaluate(() => window.scrollY)).toBe(0);
|
||||||
|
|
||||||
|
for (const modifier of ["Control", "Meta", "Shift", "Alt"] as const) {
|
||||||
|
await nested.click({ modifiers: [modifier] });
|
||||||
|
await expect(preview.document.locator("#modified")).toHaveText("false");
|
||||||
|
}
|
||||||
|
await nested.click({ button: "middle" });
|
||||||
|
await expect(preview.document.locator("#modified")).toHaveText("false");
|
||||||
|
expect(await body.evaluate(() => location.hash)).toBe("");
|
||||||
|
expect(await body.evaluate(() => window.scrollY)).toBe(0);
|
||||||
|
});
|
||||||
|
|
||||||
test("runs inline scripts without allowing fetch egress", async ({ page, withWorkspace }) => {
|
test("runs inline scripts without allowing fetch egress", async ({ page, withWorkspace }) => {
|
||||||
test.setTimeout(90_000);
|
test.setTimeout(90_000);
|
||||||
const workspace = await withWorkspace({ prefix: "file-editing-html-csp-" });
|
const workspace = await withWorkspace({ prefix: "file-editing-html-csp-" });
|
||||||
|
|||||||
@@ -1,4 +1,6 @@
|
|||||||
import { test } from "../support/fixtures";
|
import { writeFile } from "node:fs/promises";
|
||||||
|
import path from "node:path";
|
||||||
|
import { expect, test } from "../support/fixtures";
|
||||||
import {
|
import {
|
||||||
collapseFolder,
|
collapseFolder,
|
||||||
expandFolder,
|
expandFolder,
|
||||||
@@ -8,6 +10,7 @@ import {
|
|||||||
openFileExplorer,
|
openFileExplorer,
|
||||||
openFileFromExplorer,
|
openFileFromExplorer,
|
||||||
} from "../support/helpers/file-explorer";
|
} from "../support/helpers/file-explorer";
|
||||||
|
import { delayDirectoryListingResponse } from "../support/helpers/directory-listing-gate";
|
||||||
import { gotoWorkspace } from "../support/helpers/launcher";
|
import { gotoWorkspace } from "../support/helpers/launcher";
|
||||||
import { seedWorkspace, type SeededWorkspace } from "../support/helpers/seed-client";
|
import { seedWorkspace, type SeededWorkspace } from "../support/helpers/seed-client";
|
||||||
|
|
||||||
@@ -49,3 +52,66 @@ test.describe("File explorer collapse", () => {
|
|||||||
await expectExplorerEntryVisible(page, "guide.md");
|
await expectExplorerEntryVisible(page, "guide.md");
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("Files Refresh reveals new files when a cached collapsed folder is reopened", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
await gotoWorkspace(page, workspace.workspaceId);
|
||||||
|
await openFileExplorer(page);
|
||||||
|
await expandFolder(page, "docs");
|
||||||
|
await expectExplorerEntryVisible(page, "guide.md");
|
||||||
|
await collapseFolder(page, "docs");
|
||||||
|
await expectExplorerEntryHidden(page, "guide.md");
|
||||||
|
await createFileOutsidePaseo("docs/NEW.md");
|
||||||
|
await refreshFiles(page);
|
||||||
|
await expandFolder(page, "docs");
|
||||||
|
await expectExplorerEntryVisible(page, "guide.md");
|
||||||
|
await expectExplorerEntryVisible(page, "NEW.md");
|
||||||
|
|
||||||
|
await createFileOutsidePaseo("docs/NEXT.md");
|
||||||
|
await refreshFiles(page);
|
||||||
|
await expectExplorerEntryVisible(page, "NEXT.md");
|
||||||
|
});
|
||||||
|
|
||||||
|
async function refreshFiles(page: import("@playwright/test").Page): Promise<void> {
|
||||||
|
const refresh = page.getByRole("button", { name: "Refresh files", exact: true });
|
||||||
|
await refresh.click();
|
||||||
|
await expect(refresh).toBeEnabled();
|
||||||
|
}
|
||||||
|
|
||||||
|
async function createFileOutsidePaseo(filePath: string): Promise<void> {
|
||||||
|
await writeFile(path.join(workspace.repoPath, filePath), "# New output\n");
|
||||||
|
}
|
||||||
|
|
||||||
|
test("Files Refresh ignores an old reply for a folder collapsed while loading", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
const reply = await delayDirectoryListingResponse(page, "docs");
|
||||||
|
await gotoWorkspace(page, workspace.workspaceId);
|
||||||
|
await openFileExplorer(page);
|
||||||
|
await expandFolder(page, "docs");
|
||||||
|
await reply.waitUntilHeld();
|
||||||
|
await collapseFolder(page, "docs");
|
||||||
|
await createFileOutsidePaseo("docs/DELAYED.md");
|
||||||
|
await refreshFiles(page);
|
||||||
|
await reply.release();
|
||||||
|
await expandFolder(page, "docs");
|
||||||
|
await expectExplorerEntryVisible(page, "DELAYED.md");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("Files Refresh preserves expanded folders while their saved view is restoring", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
await gotoWorkspace(page, workspace.workspaceId);
|
||||||
|
await openFileExplorer(page);
|
||||||
|
await expandFolder(page, "docs");
|
||||||
|
await expectExplorerEntryVisible(page, "guide.md");
|
||||||
|
const reply = await delayDirectoryListingResponse(page, "docs");
|
||||||
|
await page.reload();
|
||||||
|
await openFileExplorer(page);
|
||||||
|
await reply.waitUntilHeld();
|
||||||
|
await refreshFiles(page);
|
||||||
|
await expectExplorerEntryVisible(page, "guide.md");
|
||||||
|
await reply.release();
|
||||||
|
await expectExplorerEntryVisible(page, "guide.md");
|
||||||
|
});
|
||||||
|
|||||||
@@ -294,10 +294,17 @@ test("creates, renames, copies, and deletes entries through the file explorer",
|
|||||||
|
|
||||||
await entry("renamed.txt").click({ button: "right" });
|
await entry("renamed.txt").click({ button: "right" });
|
||||||
const deleteAction = page.getByTestId(/file-explorer-row-\d+-delete$/);
|
const deleteAction = page.getByTestId(/file-explorer-row-\d+-delete$/);
|
||||||
const deleteLabelColor = await deleteAction
|
await expect
|
||||||
|
.poll(async () => {
|
||||||
|
const labelColor = await deleteAction
|
||||||
.getByText("Delete", { exact: true })
|
.getByText("Delete", { exact: true })
|
||||||
.evaluate((element) => getComputedStyle(element).color);
|
.evaluate((element) => getComputedStyle(element).color);
|
||||||
await expect(deleteAction.locator("svg")).toHaveCSS("stroke", deleteLabelColor);
|
const iconColor = await deleteAction
|
||||||
|
.locator("svg")
|
||||||
|
.evaluate((element) => getComputedStyle(element).stroke);
|
||||||
|
return labelColor !== "" && iconColor === labelColor;
|
||||||
|
})
|
||||||
|
.toBe(true);
|
||||||
const cancelledConfirmation = new Promise<string>((resolve) => {
|
const cancelledConfirmation = new Promise<string>((resolve) => {
|
||||||
page.once("dialog", async (dialog) => {
|
page.once("dialog", async (dialog) => {
|
||||||
const message = dialog.message();
|
const message = dialog.message();
|
||||||
|
|||||||
@@ -81,6 +81,8 @@ for (const folder of [
|
|||||||
"docs/guides",
|
"docs/guides",
|
||||||
"docs/guides/",
|
"docs/guides/",
|
||||||
"docs/指南",
|
"docs/指南",
|
||||||
|
"examples/next.js/",
|
||||||
|
"examples/next.js",
|
||||||
]) {
|
]) {
|
||||||
test(`chat folder link opens folder contents: ${folder}`, async ({ page }) => {
|
test(`chat folder link opens folder contents: ${folder}`, async ({ page }) => {
|
||||||
const session = await seedMockAgentWorkspace({
|
const session = await seedMockAgentWorkspace({
|
||||||
@@ -92,6 +94,9 @@ for (const folder of [
|
|||||||
try {
|
try {
|
||||||
await mkdir(path.join(session.cwd, folder), { recursive: true });
|
await mkdir(path.join(session.cwd, folder), { recursive: true });
|
||||||
await writeFile(path.join(session.cwd, folder, "guide.md"), "# Folder link destination\n");
|
await writeFile(path.join(session.cwd, folder, "guide.md"), "# Folder link destination\n");
|
||||||
|
const competingFile = path.join(session.cwd, "repo-a", folder.replace(/\/$/, ""));
|
||||||
|
await mkdir(path.dirname(competingFile), { recursive: true });
|
||||||
|
await writeFile(competingFile, "This is a file, not the requested folder.\n");
|
||||||
await session.client.waitForFinish(session.agentId, 30_000);
|
await session.client.waitForFinish(session.agentId, 30_000);
|
||||||
await page.addInitScript(() => {
|
await page.addInitScript(() => {
|
||||||
localStorage.setItem(
|
localStorage.setItem(
|
||||||
|
|||||||
@@ -1,3 +1,4 @@
|
|||||||
|
import { chooseModel, startWithoutRememberedModel } from "../support/helpers/model-memory";
|
||||||
import {
|
import {
|
||||||
composerLocator,
|
composerLocator,
|
||||||
enterComposerFullscreen,
|
enterComposerFullscreen,
|
||||||
@@ -97,6 +98,7 @@ test.describe("New workspace composer draft", () => {
|
|||||||
const project = await seedWorkspace({ repoPrefix: "new-workspace-submitted-draft-" });
|
const project = await seedWorkspace({ repoPrefix: "new-workspace-submitted-draft-" });
|
||||||
|
|
||||||
try {
|
try {
|
||||||
|
await startWithoutRememberedModel(page);
|
||||||
await gotoAppShell(page);
|
await gotoAppShell(page);
|
||||||
await waitForSidebarHydration(page);
|
await waitForSidebarHydration(page);
|
||||||
await openNewWorkspaceComposer(page, {
|
await openNewWorkspaceComposer(page, {
|
||||||
@@ -104,6 +106,7 @@ test.describe("New workspace composer draft", () => {
|
|||||||
projectDisplayName: project.projectDisplayName,
|
projectDisplayName: project.projectDisplayName,
|
||||||
});
|
});
|
||||||
|
|
||||||
|
await chooseModel(page, "mock", "Ten second stream");
|
||||||
const composer = page.getByRole("textbox", { name: "Message agent..." });
|
const composer = page.getByRole("textbox", { name: "Message agent..." });
|
||||||
const createButton = page.getByTestId("workspace-create-submit");
|
const createButton = page.getByTestId("workspace-create-submit");
|
||||||
await expect(composer).toBeEditable({ timeout: 30_000 });
|
await expect(composer).toBeEditable({ timeout: 30_000 });
|
||||||
|
|||||||
@@ -122,10 +122,14 @@ test.describe("New workspace entry points", () => {
|
|||||||
});
|
});
|
||||||
const hostTrigger = page.getByTestId("host-picker-trigger");
|
const hostTrigger = page.getByTestId("host-picker-trigger");
|
||||||
await expect(hostTrigger).toContainText("localhost", { timeout: 30_000 });
|
await expect(hostTrigger).toContainText("localhost", { timeout: 30_000 });
|
||||||
|
const originalUrl = page.url();
|
||||||
await hostTrigger.click();
|
await hostTrigger.click();
|
||||||
await expect(page.getByTestId("new-workspace-host-picker-add-host")).toBeVisible();
|
await expect(page.getByTestId("new-workspace-host-picker-add-host")).toBeVisible();
|
||||||
await page.getByTestId("new-workspace-host-picker-add-host").click();
|
await page.getByTestId("new-workspace-host-picker-add-host").click();
|
||||||
await expect(page).toHaveURL(/\/settings\/general\?addHost=/);
|
await expect(
|
||||||
|
page.getByRole("button", { name: "Direct connection", exact: true }),
|
||||||
|
).toBeVisible();
|
||||||
|
await expect(page).toHaveURL(originalUrl);
|
||||||
} finally {
|
} finally {
|
||||||
await seeded.cleanup();
|
await seeded.cleanup();
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,311 @@
|
|||||||
|
import { execFileSync } from "node:child_process";
|
||||||
|
import { mkdir, rm } from "node:fs/promises";
|
||||||
|
import path from "node:path";
|
||||||
|
import { expect, metroTest as test } from "../support/fixtures";
|
||||||
|
import {
|
||||||
|
addProjectFromSetup,
|
||||||
|
continueSetup,
|
||||||
|
expectSetupStep,
|
||||||
|
finishSetup,
|
||||||
|
goToSetupStep,
|
||||||
|
hostGivesAgentsPaseoTools,
|
||||||
|
openAppAsNewUser,
|
||||||
|
openRelayPairingFromSetup,
|
||||||
|
closeRelayPairing,
|
||||||
|
openTailscaleDocsFromSetup,
|
||||||
|
paseoToolsSwitch,
|
||||||
|
pickTheme,
|
||||||
|
projectSuggestion,
|
||||||
|
projectSuggestionRow,
|
||||||
|
setupModal,
|
||||||
|
setupPrimaryButton,
|
||||||
|
showSetupAgainFromSettings,
|
||||||
|
skipSetup,
|
||||||
|
startSetupHost,
|
||||||
|
} from "../support/helpers/onboarding";
|
||||||
|
import {
|
||||||
|
chooseCustomSkills,
|
||||||
|
openSkillSelection,
|
||||||
|
saveSkillSelection,
|
||||||
|
} from "../support/helpers/agent-skills";
|
||||||
|
import { installDaemonWebSocketGate } from "../support/helpers/daemon-websocket-gate";
|
||||||
|
import { enableRelayAndExpectOffer } from "../support/helpers/pair-device";
|
||||||
|
import { seedWorkspace } from "../support/helpers/seed-client";
|
||||||
|
import { openSettingsHostSection } from "../support/helpers/settings";
|
||||||
|
import { createTempDirectory, createTempGitRepo } from "../support/helpers/workspace";
|
||||||
|
|
||||||
|
// Midnight's muted foreground (#9a9db0), which the step description is drawn in.
|
||||||
|
const MIDNIGHT_MUTED_FOREGROUND = "rgb(154, 157, 176)";
|
||||||
|
|
||||||
|
test("a new user is walked through setup once", async ({ page }, testInfo) => {
|
||||||
|
const host = await startSetupHost("fresh");
|
||||||
|
const repo = await createTempGitRepo("onboarding-folder-");
|
||||||
|
|
||||||
|
try {
|
||||||
|
await openAppAsNewUser(page, host);
|
||||||
|
|
||||||
|
await test.step("setup opens on Appearance and a theme applies at once", async () => {
|
||||||
|
await expectSetupStep(page, "Welcome to Paseo");
|
||||||
|
await pickTheme(page, "Midnight");
|
||||||
|
await expect(
|
||||||
|
setupModal(page).getByText("Let's start by picking a look", { exact: true }),
|
||||||
|
).toHaveCSS("color", MIDNIGHT_MUTED_FOREGROUND);
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("1-appearance.png") });
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("Providers shows the same provider list as Settings", async () => {
|
||||||
|
await continueSetup(page);
|
||||||
|
await expectSetupStep(page, "Your agents");
|
||||||
|
await expect(setupModal(page).getByTestId("host-page-providers-card")).toBeVisible();
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("2-providers.png") });
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("with no agent history, Add project opens the regular flow and the folder shows as added", async () => {
|
||||||
|
await continueSetup(page);
|
||||||
|
await expectSetupStep(page, "Add your projects");
|
||||||
|
await expect(
|
||||||
|
setupModal(page).getByText("No recent projects found", { exact: true }),
|
||||||
|
).toBeVisible({ timeout: 60_000 });
|
||||||
|
await addProjectFromSetup(page, repo.path);
|
||||||
|
await expectSetupStep(page, "Add your projects");
|
||||||
|
await expect(setupModal(page).getByText(repo.path, { exact: true })).toBeVisible();
|
||||||
|
await expect(setupModal(page).getByText("Added", { exact: true })).toBeVisible();
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("3-projects.png") });
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("Orchestration starts with its switches on", async () => {
|
||||||
|
await continueSetup(page);
|
||||||
|
await expectSetupStep(page, "Let agents use Paseo");
|
||||||
|
await expect(paseoToolsSwitch(setupModal(page))).toBeChecked();
|
||||||
|
await expect(
|
||||||
|
setupModal(page).getByRole("switch", { name: "Orchestration skills", exact: true }),
|
||||||
|
).toBeChecked();
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("4-orchestration.png") });
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("Skip setup closes it for good", async () => {
|
||||||
|
await skipSetup(page);
|
||||||
|
await page.reload();
|
||||||
|
await expect(
|
||||||
|
page.locator('[data-testid^="sidebar-project-row-"]').filter({
|
||||||
|
hasText: path.basename(repo.path),
|
||||||
|
}),
|
||||||
|
).toBeVisible({ timeout: 60_000 });
|
||||||
|
await expect(setupModal(page)).toHaveCount(0);
|
||||||
|
});
|
||||||
|
} finally {
|
||||||
|
await host.close();
|
||||||
|
await repo.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test("setup suggests the repos the user already ran agents in", async ({ page }, testInfo) => {
|
||||||
|
const repo = await createTempGitRepo("onboarding-history-");
|
||||||
|
const repoName = path.basename(repo.path);
|
||||||
|
const subdirectory = path.join(repo.path, "packages", "web");
|
||||||
|
await mkdir(subdirectory, { recursive: true });
|
||||||
|
const worktree = `${repo.path}-fix`;
|
||||||
|
execFileSync("git", ["worktree", "add", "-b", "fix", worktree], { cwd: repo.path });
|
||||||
|
const scratch = await createTempDirectory("onboarding-scratch-");
|
||||||
|
const scratchName = path.basename(scratch.path);
|
||||||
|
const host = await startSetupHost("history", {
|
||||||
|
claudeSessionsIn: [repo.path, subdirectory, worktree, scratch.path, scratch.path, scratch.path],
|
||||||
|
withBrokenProvider: true,
|
||||||
|
});
|
||||||
|
|
||||||
|
try {
|
||||||
|
await openAppAsNewUser(page, host);
|
||||||
|
await expectSetupStep(page, "Welcome to Paseo");
|
||||||
|
await goToSetupStep(page, "Projects");
|
||||||
|
await expectSetupStep(page, "Add your projects");
|
||||||
|
|
||||||
|
await test.step("the repo, its subfolder and its worktree become one checked row", async () => {
|
||||||
|
await expect(projectSuggestion(page, repoName)).toBeChecked({ timeout: 60_000 });
|
||||||
|
await expect(projectSuggestion(page, scratchName)).toBeChecked();
|
||||||
|
await expect(setupModal(page).getByTestId("project-suggestion")).toHaveCount(2);
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("a provider that cannot read its history adds nothing and shows no error", async () => {
|
||||||
|
await expect(setupModal(page).getByTestId("project-suggestions-skeleton")).toHaveCount(0, {
|
||||||
|
timeout: 60_000,
|
||||||
|
});
|
||||||
|
await expect(setupModal(page).getByText(/Broken ACP/)).toHaveCount(0);
|
||||||
|
await expect(setupModal(page).getByTestId("project-suggestion")).toHaveCount(2);
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("the footer adds what is checked; the Add project flow is separate", async () => {
|
||||||
|
await expect(setupPrimaryButton(page, "Add 2 projects")).toBeVisible();
|
||||||
|
await expect(setupModal(page).getByRole("button", { name: "Continue" })).toHaveCount(0);
|
||||||
|
await expect(
|
||||||
|
setupModal(page).getByRole("button", { name: "Add project", exact: true }),
|
||||||
|
).toBeVisible();
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("8-project-suggestions.png") });
|
||||||
|
await projectSuggestion(page, repoName).click();
|
||||||
|
await projectSuggestion(page, scratchName).click();
|
||||||
|
await expect(setupPrimaryButton(page, "Continue")).toBeVisible();
|
||||||
|
await projectSuggestion(page, repoName).click();
|
||||||
|
await projectSuggestion(page, scratchName).click();
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("a folder that cannot be added keeps the user on the step", async () => {
|
||||||
|
await scratch.cleanup();
|
||||||
|
await setupPrimaryButton(page, "Add 2 projects").click();
|
||||||
|
await expect(setupPrimaryButton(page, "Add 1 project")).toBeVisible({ timeout: 30_000 });
|
||||||
|
await expectSetupStep(page, "Add your projects");
|
||||||
|
await expect(projectSuggestion(page, scratchName)).toBeChecked();
|
||||||
|
await expect(projectSuggestionRow(page, scratchName)).toContainText("Directory not found");
|
||||||
|
await expect(projectSuggestion(page, repoName)).toHaveCount(0);
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("9-project-suggestion-failed.png") });
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("with nothing checked, Continue moves on without adding", async () => {
|
||||||
|
await projectSuggestion(page, scratchName).click();
|
||||||
|
await setupPrimaryButton(page, "Continue").click();
|
||||||
|
await expectSetupStep(page, "Let agents use Paseo");
|
||||||
|
await expect(
|
||||||
|
page.locator('[data-testid^="sidebar-project-row-"]').filter({ hasText: repoName }),
|
||||||
|
).toBeVisible({ timeout: 60_000 });
|
||||||
|
await expect(
|
||||||
|
page.locator('[data-testid^="sidebar-project-row-"]').filter({ hasText: scratchName }),
|
||||||
|
).toHaveCount(0);
|
||||||
|
});
|
||||||
|
} finally {
|
||||||
|
await host.close();
|
||||||
|
await rm(worktree, { recursive: true, force: true });
|
||||||
|
await repo.cleanup();
|
||||||
|
await scratch.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test("an existing user only sees setup when they ask for it", async ({ page }) => {
|
||||||
|
const host = await startSetupHost("existing");
|
||||||
|
const workspace = await seedWorkspace({ repoPrefix: "onboarding-existing-", port: host.port });
|
||||||
|
|
||||||
|
try {
|
||||||
|
await openAppAsNewUser(page, host);
|
||||||
|
await expect(
|
||||||
|
page.getByTestId(`sidebar-workspace-row-${host.serverId}:${workspace.workspaceId}`),
|
||||||
|
).toBeVisible({ timeout: 60_000 });
|
||||||
|
await expect(setupModal(page)).toHaveCount(0);
|
||||||
|
|
||||||
|
await showSetupAgainFromSettings(page);
|
||||||
|
await expectSetupStep(page, "Welcome to Paseo");
|
||||||
|
await expect(setupModal(page).getByRole("tab", { name: "Appearance" })).toHaveAttribute(
|
||||||
|
"aria-selected",
|
||||||
|
"true",
|
||||||
|
);
|
||||||
|
} finally {
|
||||||
|
await workspace.cleanup();
|
||||||
|
await host.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test("setup choices carry over to Settings and the phone step pairs over relay", async ({
|
||||||
|
page,
|
||||||
|
}, testInfo) => {
|
||||||
|
const host = await startSetupHost("phone", { mutableRelay: { enabled: false } });
|
||||||
|
|
||||||
|
try {
|
||||||
|
await openAppAsNewUser(page, host);
|
||||||
|
await expectSetupStep(page, "Welcome to Paseo");
|
||||||
|
|
||||||
|
await test.step("Paseo tools start on in setup and Continue turns them on", async () => {
|
||||||
|
await goToSetupStep(page, "Orchestration");
|
||||||
|
await expectSetupStep(page, "Let agents use Paseo");
|
||||||
|
await expect(paseoToolsSwitch(setupModal(page))).toBeChecked();
|
||||||
|
await continueSetup(page);
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("Phone offers Tailscale docs and pairs over relay in its own modal", async () => {
|
||||||
|
await expectSetupStep(page, "Take your agents with you");
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("5-phone.png") });
|
||||||
|
expect(await openTailscaleDocsFromSetup(page)).toBe(
|
||||||
|
"https://paseo.sh/docs/connectivity#tailscale",
|
||||||
|
);
|
||||||
|
const pairing = await openRelayPairingFromSetup(page);
|
||||||
|
await expect(pairing.getByText("Enable relay?", { exact: true })).toBeVisible();
|
||||||
|
await enableRelayAndExpectOffer(page);
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("6-phone-qr.png") });
|
||||||
|
await closeRelayPairing(pairing);
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("Finish closes setup and Settings shows the same Paseo tools value", async () => {
|
||||||
|
await finishSetup(page);
|
||||||
|
await page.locator('[data-testid="sidebar-settings"]:visible').first().click();
|
||||||
|
await openSettingsHostSection(page, host.serverId, "agents");
|
||||||
|
await expect(paseoToolsSwitch(page)).toBeChecked();
|
||||||
|
await page.screenshot({ path: testInfo.outputPath("7-settings-agents.png") });
|
||||||
|
});
|
||||||
|
} finally {
|
||||||
|
await host.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test("with no skills picked, skills read as off and Continue moves on", async ({ page }) => {
|
||||||
|
const host = await startSetupHost("no-skills");
|
||||||
|
|
||||||
|
try {
|
||||||
|
await openAppAsNewUser(page, host);
|
||||||
|
await expectSetupStep(page, "Welcome to Paseo");
|
||||||
|
await goToSetupStep(page, "Orchestration");
|
||||||
|
await expectSetupStep(page, "Let agents use Paseo");
|
||||||
|
|
||||||
|
await openSkillSelection(page);
|
||||||
|
await chooseCustomSkills(page, []);
|
||||||
|
await saveSkillSelection(page);
|
||||||
|
const skillsSwitch = setupModal(page).getByRole("switch", {
|
||||||
|
name: "Orchestration skills",
|
||||||
|
exact: true,
|
||||||
|
});
|
||||||
|
await expect(skillsSwitch).not.toBeChecked();
|
||||||
|
|
||||||
|
await continueSetup(page);
|
||||||
|
await expectSetupStep(page, "Take your agents with you");
|
||||||
|
} finally {
|
||||||
|
await host.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test("in the compact layout, Finish on Orchestration applies its switches", async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width: 390, height: 844 });
|
||||||
|
const host = await startSetupHost("compact");
|
||||||
|
const gate = await installDaemonWebSocketGate(page, { port: host.port });
|
||||||
|
// The compact sheet is the only surface on screen, and Orchestration is its last step.
|
||||||
|
const step = (title: string) =>
|
||||||
|
expect(page.getByRole("heading", { name: title, exact: true })).toBeVisible({
|
||||||
|
timeout: 60_000,
|
||||||
|
});
|
||||||
|
const primary = (label: string) => page.getByRole("button", { name: label, exact: true });
|
||||||
|
|
||||||
|
try {
|
||||||
|
await openAppAsNewUser(page, host);
|
||||||
|
await step("Welcome to Paseo");
|
||||||
|
await primary("Continue").click();
|
||||||
|
await step("Your agents");
|
||||||
|
await primary("Continue").click();
|
||||||
|
await step("Add your projects");
|
||||||
|
await primary("Continue").click();
|
||||||
|
|
||||||
|
// The setup host starts with Paseo tools off; the switch starts on.
|
||||||
|
expect(await hostGivesAgentsPaseoTools(host)).toBe(false);
|
||||||
|
await step("Let agents use Paseo");
|
||||||
|
await expect(paseoToolsSwitch(page)).toBeChecked();
|
||||||
|
// Skills are not installed, so leaving them off has nothing to apply.
|
||||||
|
const skillsSwitch = page.getByRole("switch", { name: "Orchestration skills", exact: true });
|
||||||
|
await skillsSwitch.click();
|
||||||
|
await expect(skillsSwitch).not.toBeChecked();
|
||||||
|
gate.holdNextClientRequest("set_daemon_config_request");
|
||||||
|
await primary("Finish").click();
|
||||||
|
|
||||||
|
// While the choices apply, none of them can change.
|
||||||
|
await gate.waitForHeldClientRequest();
|
||||||
|
await expect(paseoToolsSwitch(page)).toBeDisabled();
|
||||||
|
await expect(skillsSwitch).toBeDisabled();
|
||||||
|
gate.releaseHeldClientRequest();
|
||||||
|
|
||||||
|
await expect.poll(() => hostGivesAgentsPaseoTools(host), { timeout: 30_000 }).toBe(true);
|
||||||
|
await expect(page.getByRole("heading", { name: "Let agents use Paseo" })).toHaveCount(0);
|
||||||
|
} finally {
|
||||||
|
await host.close();
|
||||||
|
}
|
||||||
|
});
|
||||||
@@ -10,6 +10,7 @@ test("plugin header and composer buttons share actions, menus, content, and upda
|
|||||||
await buttons.verifyObservationLifetime();
|
await buttons.verifyObservationLifetime();
|
||||||
await buttons.openWideMenusAndPopovers();
|
await buttons.openWideMenusAndPopovers();
|
||||||
await buttons.runAndUpdateActions();
|
await buttons.runAndUpdateActions();
|
||||||
|
await buttons.keepTrackSpaceWithoutPills();
|
||||||
await buttons.openCompactSheets();
|
await buttons.openCompactSheets();
|
||||||
await buttons.useCompactWorkspaceMenu();
|
await buttons.useCompactWorkspaceMenu();
|
||||||
await buttons.hideAndUnloadOpenButtons();
|
await buttons.hideAndUnloadOpenButtons();
|
||||||
|
|||||||
@@ -16,6 +16,14 @@ import {
|
|||||||
returnAndReopenSettings,
|
returnAndReopenSettings,
|
||||||
returnToPluginsPage,
|
returnToPluginsPage,
|
||||||
expectSettingsUnavailable,
|
expectSettingsUnavailable,
|
||||||
|
openPluginsPage,
|
||||||
|
expectActionsMenuWithoutSettings,
|
||||||
|
expectNoSettingsCogWithoutScreens,
|
||||||
|
openTabbedSettings,
|
||||||
|
selectSettingsTab,
|
||||||
|
openTabbedSettingsLink,
|
||||||
|
expectSettingsTooltip,
|
||||||
|
expectNamedPluginRow,
|
||||||
} from "../support/helpers/plugin-settings";
|
} from "../support/helpers/plugin-settings";
|
||||||
|
|
||||||
test("display preferences survive a reload", async ({ page }) => {
|
test("display preferences survive a reload", async ({ page }) => {
|
||||||
@@ -49,6 +57,32 @@ test("Back to plugins returns from a plugin settings screen", async ({ page }) =
|
|||||||
await returnToPluginsPage(page);
|
await returnToPluginsPage(page);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("plugin settings open from the cog and show a tab per screen", async ({ page }) => {
|
||||||
|
await openPluginsPage(page);
|
||||||
|
await test.step("plugin rows show the display name", async () => {
|
||||||
|
await expectNamedPluginRow(page);
|
||||||
|
});
|
||||||
|
await test.step("the cog explains itself", async () => {
|
||||||
|
await expectSettingsTooltip(page);
|
||||||
|
});
|
||||||
|
await test.step("the actions menu keeps only plugin actions", async () => {
|
||||||
|
await expectActionsMenuWithoutSettings(page);
|
||||||
|
});
|
||||||
|
await test.step("tabs switch between the plugin's settings screens", async () => {
|
||||||
|
await openTabbedSettings(page);
|
||||||
|
await selectSettingsTab(page, "Advanced");
|
||||||
|
await selectSettingsTab(page, "General");
|
||||||
|
await returnToPluginsPage(page);
|
||||||
|
});
|
||||||
|
await test.step("a plugin without settings screens shows no cog", async () => {
|
||||||
|
await expectNoSettingsCogWithoutScreens(page);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a settings screen link opens its tab", async ({ page }) => {
|
||||||
|
await openTabbedSettingsLink(page, "Advanced");
|
||||||
|
});
|
||||||
|
|
||||||
test.describe("compact plugin settings", () => {
|
test.describe("compact plugin settings", () => {
|
||||||
test.use({ viewport: { width: 390, height: 844 } });
|
test.use({ viewport: { width: 390, height: 844 } });
|
||||||
|
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ import path from "node:path";
|
|||||||
import type { Locator, Page } from "@playwright/test";
|
import type { Locator, Page } from "@playwright/test";
|
||||||
import { expect, test } from "../support/fixtures";
|
import { expect, test } from "../support/fixtures";
|
||||||
import { gotoWorkspace } from "../support/helpers/launcher";
|
import { gotoWorkspace } from "../support/helpers/launcher";
|
||||||
|
import { gotoAppShell } from "../support/helpers/app";
|
||||||
import {
|
import {
|
||||||
BOTS_PLUGIN_ID,
|
BOTS_PLUGIN_ID,
|
||||||
COMPACT,
|
COMPACT,
|
||||||
@@ -27,6 +28,7 @@ import { seedWorkspace } from "../support/helpers/seed-client";
|
|||||||
import { getServerId } from "../support/helpers/server-id";
|
import { getServerId } from "../support/helpers/server-id";
|
||||||
import { installUsageReportsFixture } from "../support/helpers/usage-reports";
|
import { installUsageReportsFixture } from "../support/helpers/usage-reports";
|
||||||
import { claudeAndCodexReports } from "../support/helpers/usage-sidebar-item";
|
import { claudeAndCodexReports } from "../support/helpers/usage-sidebar-item";
|
||||||
|
import { daemonWsRoutePattern } from "../support/helpers/daemon-port";
|
||||||
|
|
||||||
const APP_SETTINGS_KEY = "@paseo:app-settings";
|
const APP_SETTINGS_KEY = "@paseo:app-settings";
|
||||||
|
|
||||||
@@ -133,6 +135,30 @@ function sidebarFooter(page: Page): Locator {
|
|||||||
return visibleTestId(page, "sidebar-add-project").locator("xpath=..");
|
return visibleTestId(page, "sidebar-add-project").locator("xpath=..");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function isPluginCatalogResponse(message: string | Buffer): boolean {
|
||||||
|
if (typeof message !== "string") return false;
|
||||||
|
const frame = JSON.parse(message);
|
||||||
|
return frame.type === "session" && frame.message?.type === "plugin.catalog.get.response";
|
||||||
|
}
|
||||||
|
|
||||||
|
async function holdNextPluginCatalogResponse(page: Page) {
|
||||||
|
const response = Promise.withResolvers<() => void>();
|
||||||
|
let holdCatalog = true;
|
||||||
|
await page.routeWebSocket(daemonWsRoutePattern(), (socket) => {
|
||||||
|
const server = socket.connectToServer();
|
||||||
|
socket.onMessage((message) => server.send(message));
|
||||||
|
server.onMessage((message) => {
|
||||||
|
if (holdCatalog && isPluginCatalogResponse(message)) {
|
||||||
|
holdCatalog = false;
|
||||||
|
response.resolve(() => socket.send(message));
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
socket.send(message);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
return { response: response.promise };
|
||||||
|
}
|
||||||
|
|
||||||
test.describe("Plugin sidebar items", () => {
|
test.describe("Plugin sidebar items", () => {
|
||||||
let workspaceId: string;
|
let workspaceId: string;
|
||||||
let cleanup: () => Promise<void>;
|
let cleanup: () => Promise<void>;
|
||||||
@@ -151,6 +177,69 @@ test.describe("Plugin sidebar items", () => {
|
|||||||
await cleanup();
|
await cleanup();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("a short compact sidebar keeps workspaces usable while navigation scrolls", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
await page.setViewportSize({ width: 390, height: 600 });
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await page.getByRole("button", { name: "Open menu", exact: true }).first().click();
|
||||||
|
await expect(botRow(page, "status")).toBeAttached();
|
||||||
|
const workspace = visibleTestId(page, `sidebar-workspace-row-${getServerId()}:${workspaceId}`);
|
||||||
|
await expect(workspace).toBeInViewport({ ratio: 1 });
|
||||||
|
|
||||||
|
await test.step("scrolling navigation reaches its last row without moving workspaces", async () => {
|
||||||
|
const before = await boxOf(workspace);
|
||||||
|
await visibleTestId(page, "sidebar-global-new-workspace").hover();
|
||||||
|
await page.mouse.wheel(0, 800);
|
||||||
|
await expect(botRow(page, "status")).toBeInViewport({ ratio: 1 });
|
||||||
|
await expect(workspace).toBeInViewport({ ratio: 1 });
|
||||||
|
expect((await boxOf(workspace)).y).toBe(before.y);
|
||||||
|
await botRow(page, "status").click();
|
||||||
|
await expect(page.getByText("Bot status details", { exact: true })).toBeVisible();
|
||||||
|
await page.getByRole("button", { name: "Close bot status", exact: true }).click();
|
||||||
|
});
|
||||||
|
|
||||||
|
await test.step("the workspace still opens and closes the sidebar", async () => {
|
||||||
|
await workspace.click();
|
||||||
|
await expect(
|
||||||
|
page.getByRole("button", { name: "Open menu", exact: true }).first(),
|
||||||
|
).toBeVisible();
|
||||||
|
await expect(workspace).not.toBeInViewport();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a restored plugin screen waits for its catalog before rendering", async ({ page }) => {
|
||||||
|
await page.setViewportSize(WIDE);
|
||||||
|
await gotoWorkspace(page, workspaceId);
|
||||||
|
const row = headerRow(page, SHOWCASE_PLUGIN_ID, "deploys");
|
||||||
|
await expect(row).toBeVisible({ timeout: 30_000 });
|
||||||
|
await row.click();
|
||||||
|
const body = page.getByText("Deploys screen body", { exact: true });
|
||||||
|
await expect(body).toBeVisible();
|
||||||
|
const screenUrl = page.url();
|
||||||
|
const catalog = await holdNextPluginCatalogResponse(page);
|
||||||
|
|
||||||
|
await page.reload();
|
||||||
|
const releaseCatalog = await catalog.response;
|
||||||
|
try {
|
||||||
|
await expect(
|
||||||
|
page.getByRole("progressbar", { name: "Loading plugin", exact: true }),
|
||||||
|
).toBeVisible();
|
||||||
|
await expect(
|
||||||
|
page.getByText("This plugin surface is unavailable.", { exact: true }),
|
||||||
|
).toHaveCount(0);
|
||||||
|
await expect(body).toHaveCount(0);
|
||||||
|
} finally {
|
||||||
|
releaseCatalog();
|
||||||
|
}
|
||||||
|
|
||||||
|
await expect(body).toBeVisible();
|
||||||
|
await expect(
|
||||||
|
page.getByRole("progressbar", { name: "Loading plugin", exact: true }),
|
||||||
|
).toHaveCount(0);
|
||||||
|
await expect(page).toHaveURL(screenUrl);
|
||||||
|
});
|
||||||
|
|
||||||
test("a plugin's screen, header row, footer popover and command work together", async ({
|
test("a plugin's screen, header row, footer popover and command work together", async ({
|
||||||
page,
|
page,
|
||||||
}) => {
|
}) => {
|
||||||
@@ -228,7 +317,10 @@ test.describe("Plugin sidebar items", () => {
|
|||||||
const compactSync = footerItem(page, SHOWCASE_PLUGIN_ID, "sync");
|
const compactSync = footerItem(page, SHOWCASE_PLUGIN_ID, "sync");
|
||||||
await expect(compactSync).toBeInViewport();
|
await expect(compactSync).toBeInViewport();
|
||||||
await expectFooterRow(page, compactSync);
|
await expectFooterRow(page, compactSync);
|
||||||
await expect(headerRow(page, SHOWCASE_PLUGIN_ID, "deploys")).toBeInViewport();
|
// The compact nav block is capped at half the sidebar and scrolls past it.
|
||||||
|
const compactDeploys = headerRow(page, SHOWCASE_PLUGIN_ID, "deploys");
|
||||||
|
await compactDeploys.scrollIntoViewIfNeeded();
|
||||||
|
await expect(compactDeploys).toBeInViewport();
|
||||||
await qaScreenshot(page, "phase2-compact-sidebar");
|
await qaScreenshot(page, "phase2-compact-sidebar");
|
||||||
await qaScreenshot(page, "phase5-compact-footer", sidebarFooter(page));
|
await qaScreenshot(page, "phase5-compact-footer", sidebarFooter(page));
|
||||||
await compactSync.click();
|
await compactSync.click();
|
||||||
|
|||||||
@@ -0,0 +1,79 @@
|
|||||||
|
import { writeFile } from "node:fs/promises";
|
||||||
|
import path from "node:path";
|
||||||
|
import { expect, test, type Page } from "../support/fixtures";
|
||||||
|
import { gotoAppShell } from "../support/helpers/app";
|
||||||
|
import { openCommandCenter } from "../support/helpers/command-center";
|
||||||
|
import { connectNewWorkspaceDaemonClient } from "../support/helpers/new-workspace";
|
||||||
|
import { copyPluginExample } from "../support/helpers/plugin-fixture";
|
||||||
|
import { seedWorkspace, type SeededWorkspace } from "../support/helpers/seed-client";
|
||||||
|
import { getServerId } from "../support/helpers/server-id";
|
||||||
|
import {
|
||||||
|
switchWorkspaceViaSidebar,
|
||||||
|
waitForWorkspaceInSidebar,
|
||||||
|
} from "../support/helpers/workspace-ui";
|
||||||
|
|
||||||
|
async function runCommand(page: Page, title: string): Promise<void> {
|
||||||
|
const panel = await openCommandCenter(page);
|
||||||
|
await panel.getByTestId("command-center-input").fill(title);
|
||||||
|
await panel.getByRole("button", { name: title, exact: true }).click();
|
||||||
|
await expect(panel).not.toBeVisible();
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Installs a plugin example, opens a seeded workspace, and runs `exercise` against them. */
|
||||||
|
async function withExample(
|
||||||
|
page: Page,
|
||||||
|
example: { name: string; id: string },
|
||||||
|
exercise: (workspace: SeededWorkspace) => Promise<void>,
|
||||||
|
): Promise<void> {
|
||||||
|
const client = await connectNewWorkspaceDaemonClient({ ownProjects: false });
|
||||||
|
const previous = await client.getDaemonConfig();
|
||||||
|
const copy = await copyPluginExample(example.name);
|
||||||
|
const workspace = await seedWorkspace({ repoPrefix: `${example.name}-` });
|
||||||
|
try {
|
||||||
|
await client.patchDaemonConfig({ pluginsEnabled: true });
|
||||||
|
await client.installDirectoryPlugin(copy.directory);
|
||||||
|
await page.setViewportSize({ width: 1280, height: 800 });
|
||||||
|
await gotoAppShell(page);
|
||||||
|
const target = { serverId: getServerId(), workspaceId: workspace.workspaceId };
|
||||||
|
await waitForWorkspaceInSidebar(page, target);
|
||||||
|
await switchWorkspaceViaSidebar({ page, ...target });
|
||||||
|
await exercise(workspace);
|
||||||
|
} finally {
|
||||||
|
try {
|
||||||
|
await client.removePlugin(example.id);
|
||||||
|
} finally {
|
||||||
|
await client.patchDaemonConfig({ pluginsEnabled: previous.config.pluginsEnabled });
|
||||||
|
await workspace.cleanup();
|
||||||
|
await client.close();
|
||||||
|
await copy.cleanup();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
test.describe("plugin subscriptions", () => {
|
||||||
|
test.describe.configure({ timeout: 180_000 });
|
||||||
|
|
||||||
|
test("a panel follows events the daemon pushes as files change", async ({ page }) => {
|
||||||
|
await withExample(page, { name: "diff-watch", id: "diff-watch" }, async (workspace) => {
|
||||||
|
await runCommand(page, "Open live changes");
|
||||||
|
await expect(page.getByText("No changes", { exact: true })).toBeVisible();
|
||||||
|
|
||||||
|
await writeFile(path.join(workspace.repoPath, "pushed.txt"), "from the test\n");
|
||||||
|
await expect(page.getByText("1 file changed", { exact: true })).toBeVisible();
|
||||||
|
await expect(page.getByText("pushed.txt", { exact: true })).toBeVisible();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a panel plays streamed bytes and sends bytes back", async ({ page }) => {
|
||||||
|
await withExample(page, { name: "media-stream", id: "media-stream" }, async () => {
|
||||||
|
await runCommand(page, "Open media stream");
|
||||||
|
await expect(page.getByText("live", { exact: true })).toBeVisible();
|
||||||
|
await expect(page.getByText(/^[1-9]\d* video frames/)).toBeVisible();
|
||||||
|
|
||||||
|
await page.getByRole("button", { name: "Send this frame back", exact: true }).click();
|
||||||
|
await expect(
|
||||||
|
page.getByText(/^The daemon received [1-9]\d* bytes, sha256 [0-9a-f]{12}$/),
|
||||||
|
).toBeVisible();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -2,7 +2,6 @@ import { pluginRequirements } from "../support/helpers/plugin-fixture";
|
|||||||
import { mkdtemp, rm, writeFile } from "node:fs/promises";
|
import { mkdtemp, rm, writeFile } from "node:fs/promises";
|
||||||
import { tmpdir } from "node:os";
|
import { tmpdir } from "node:os";
|
||||||
import path from "node:path";
|
import path from "node:path";
|
||||||
import type { Page } from "@playwright/test";
|
|
||||||
import { expect, test } from "../support/fixtures";
|
import { expect, test } from "../support/fixtures";
|
||||||
import { connectNewWorkspaceDaemonClient } from "../support/helpers/new-workspace";
|
import { connectNewWorkspaceDaemonClient } from "../support/helpers/new-workspace";
|
||||||
import { openSettingsSection } from "../support/helpers/settings";
|
import { openSettingsSection } from "../support/helpers/settings";
|
||||||
@@ -69,8 +68,7 @@ test("applies a contributed theme and falls back when its plugin is gone", async
|
|||||||
await openSettingsSection(page, "appearance");
|
await openSettingsSection(page, "appearance");
|
||||||
|
|
||||||
const sectionTitle = page.getByText("Theme", { exact: true }).first();
|
const sectionTitle = page.getByText("Theme", { exact: true }).first();
|
||||||
await page.getByLabel("Theme: System", { exact: true }).click();
|
const mochaItem = page.getByRole("radio", { name: "Catppuccin Mocha", exact: true });
|
||||||
const mochaItem = page.getByText("Catppuccin Mocha", { exact: true });
|
|
||||||
await expect(mochaItem).toBeVisible({ timeout: 30_000 });
|
await expect(mochaItem).toBeVisible({ timeout: 30_000 });
|
||||||
await page.screenshot({
|
await page.screenshot({
|
||||||
path: testInfo.outputPath("plugin-theme-picker.png"),
|
path: testInfo.outputPath("plugin-theme-picker.png"),
|
||||||
@@ -79,14 +77,14 @@ test("applies a contributed theme and falls back when its plugin is gone", async
|
|||||||
});
|
});
|
||||||
|
|
||||||
await test.step("a contributed light theme uses the light palette", async () => {
|
await test.step("a contributed light theme uses the light palette", async () => {
|
||||||
await page.getByText("Catppuccin Latte", { exact: true }).click();
|
const latteItem = page.getByRole("radio", { name: "Catppuccin Latte", exact: true });
|
||||||
await expect(page.getByLabel("Theme: Catppuccin Latte", { exact: true })).toBeVisible();
|
await latteItem.click();
|
||||||
|
await expect(latteItem).toBeChecked();
|
||||||
await expect(sectionTitle).toHaveCSS("color", LATTE_MUTED_FOREGROUND);
|
await expect(sectionTitle).toHaveCSS("color", LATTE_MUTED_FOREGROUND);
|
||||||
await page.getByLabel("Theme: Catppuccin Latte", { exact: true }).click();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
await mochaItem.click();
|
await mochaItem.click();
|
||||||
await expect(page.getByLabel("Theme: Catppuccin Mocha", { exact: true })).toBeVisible();
|
await expect(mochaItem).toBeChecked();
|
||||||
await expect(sectionTitle).toHaveCSS("color", MOCHA_MUTED_FOREGROUND);
|
await expect(sectionTitle).toHaveCSS("color", MOCHA_MUTED_FOREGROUND);
|
||||||
await page.screenshot({
|
await page.screenshot({
|
||||||
path: testInfo.outputPath("plugin-theme-applied.png"),
|
path: testInfo.outputPath("plugin-theme-applied.png"),
|
||||||
@@ -95,15 +93,13 @@ test("applies a contributed theme and falls back when its plugin is gone", async
|
|||||||
|
|
||||||
await test.step("the selection survives a reload", async () => {
|
await test.step("the selection survives a reload", async () => {
|
||||||
await page.reload();
|
await page.reload();
|
||||||
await expect(page.getByLabel("Theme: Catppuccin Mocha", { exact: true })).toBeVisible({
|
await expect(mochaItem).toBeChecked({ timeout: 30_000 });
|
||||||
timeout: 30_000,
|
|
||||||
});
|
|
||||||
await expect(sectionTitle).toHaveCSS("color", MOCHA_MUTED_FOREGROUND);
|
await expect(sectionTitle).toHaveCSS("color", MOCHA_MUTED_FOREGROUND);
|
||||||
});
|
});
|
||||||
|
|
||||||
await test.step("removing the plugin falls back to the default theme", async () => {
|
await test.step("removing the plugin falls back to the default theme", async () => {
|
||||||
await client.removePlugin(PLUGIN_ID);
|
await client.removePlugin(PLUGIN_ID);
|
||||||
await expect(page.getByLabel("Theme: System", { exact: true })).toBeVisible({
|
await expect(page.getByRole("radio", { name: "System", exact: true })).toBeChecked({
|
||||||
timeout: 30_000,
|
timeout: 30_000,
|
||||||
});
|
});
|
||||||
await expect(sectionTitle).not.toHaveCSS("color", MOCHA_MUTED_FOREGROUND);
|
await expect(sectionTitle).not.toHaveCSS("color", MOCHA_MUTED_FOREGROUND);
|
||||||
@@ -147,15 +143,7 @@ const MANY_THEMES_SOURCE = `export default function contribute(plugin) {
|
|||||||
return () => {};
|
return () => {};
|
||||||
}`;
|
}`;
|
||||||
|
|
||||||
async function scrollThemeMenuToLastTheme(page: Page) {
|
test("reaches the last theme when a plugin contributes more themes than fit", async ({
|
||||||
const firstTheme = page.getByText("Pack theme 1", { exact: true });
|
|
||||||
await expect(firstTheme).toBeVisible({ timeout: 30_000 });
|
|
||||||
await firstTheme.hover();
|
|
||||||
await page.mouse.wheel(0, 4000);
|
|
||||||
await expect(page.getByText(LAST_THEME_NAME, { exact: true })).toBeInViewport({ ratio: 1 });
|
|
||||||
}
|
|
||||||
|
|
||||||
test("scrolls to the last theme when a plugin contributes more themes than fit", async ({
|
|
||||||
page,
|
page,
|
||||||
}, testInfo) => {
|
}, testInfo) => {
|
||||||
const directory = await mkdtemp(path.join(tmpdir(), "paseo-plugin-theme-many-e2e-"));
|
const directory = await mkdtemp(path.join(tmpdir(), "paseo-plugin-theme-many-e2e-"));
|
||||||
@@ -175,15 +163,16 @@ test("scrolls to the last theme when a plugin contributes more themes than fit",
|
|||||||
await expect(page.getByTestId("settings-sidebar")).toBeVisible();
|
await expect(page.getByTestId("settings-sidebar")).toBeVisible();
|
||||||
await openSettingsSection(page, "appearance");
|
await openSettingsSection(page, "appearance");
|
||||||
|
|
||||||
await page.getByLabel("Theme: System", { exact: true }).click();
|
const lastTheme = page.getByRole("radio", { name: LAST_THEME_NAME, exact: true });
|
||||||
await scrollThemeMenuToLastTheme(page);
|
await expect(lastTheme).toBeAttached({ timeout: 30_000 });
|
||||||
|
await lastTheme.scrollIntoViewIfNeeded();
|
||||||
await page.screenshot({
|
await page.screenshot({
|
||||||
path: testInfo.outputPath("plugin-theme-picker-scrolled.png"),
|
path: testInfo.outputPath("plugin-theme-picker-scrolled.png"),
|
||||||
animations: "disabled",
|
animations: "disabled",
|
||||||
});
|
});
|
||||||
|
|
||||||
await page.getByText(LAST_THEME_NAME, { exact: true }).click();
|
await lastTheme.click();
|
||||||
await expect(page.getByLabel(`Theme: ${LAST_THEME_NAME}`, { exact: true })).toBeVisible();
|
await expect(lastTheme).toBeChecked();
|
||||||
} finally {
|
} finally {
|
||||||
await client.removePlugin(MANY_THEMES_PLUGIN_ID).catch(() => undefined);
|
await client.removePlugin(MANY_THEMES_PLUGIN_ID).catch(() => undefined);
|
||||||
await client
|
await client
|
||||||
|
|||||||
@@ -108,10 +108,7 @@ test.describe("Question option text", () => {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
test("selecting description text never answers, and the label still does", async ({
|
test("selecting description text keeps the question open", async ({ page, context }) => {
|
||||||
page,
|
|
||||||
context,
|
|
||||||
}) => {
|
|
||||||
test.setTimeout(180_000);
|
test.setTimeout(180_000);
|
||||||
const { session, card } = await openLinkedQuestions(page, context);
|
const { session, card } = await openLinkedQuestions(page, context);
|
||||||
try {
|
try {
|
||||||
@@ -120,16 +117,13 @@ test.describe("Question option text", () => {
|
|||||||
|
|
||||||
await dragAcross(page, description);
|
await dragAcross(page, description);
|
||||||
await expect.poll(() => selectedText(page)).toBe(DONE_DESCRIPTION);
|
await expect.poll(() => selectedText(page)).toBe(DONE_DESCRIPTION);
|
||||||
await expectChecked(done, false);
|
|
||||||
|
|
||||||
await description.getByText("Logs are at", { exact: false }).dblclick({
|
await description.getByText("Logs are at", { exact: false }).dblclick({
|
||||||
position: { x: 4, y: 4 },
|
position: { x: 4, y: 4 },
|
||||||
});
|
});
|
||||||
await expect.poll(() => selectedText(page)).toBe("Logs");
|
await expect.poll(() => selectedText(page)).toBe("Logs");
|
||||||
await expectCurrentQuestion(page, { index: 1, total: 2, question: LINKED_QUESTION });
|
await expectCurrentQuestion(page, { index: 1, total: 2, question: LINKED_QUESTION });
|
||||||
await expectChecked(done, false);
|
await expectChecked(done, true);
|
||||||
|
await continueToNextQuestion(page);
|
||||||
await done.getByText("Done", { exact: true }).click();
|
|
||||||
await expectCurrentQuestion(page, { index: 2, total: 2, question: CHECKS_QUESTION });
|
await expectCurrentQuestion(page, { index: 2, total: 2, question: CHECKS_QUESTION });
|
||||||
await openQuestion(page, { index: 1, total: 2 });
|
await openQuestion(page, { index: 1, total: 2 });
|
||||||
await expectChecked(done, true);
|
await expectChecked(done, true);
|
||||||
@@ -138,11 +132,17 @@ test.describe("Question option text", () => {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
test("double-clicking a single-select label answers once", async ({ page, context }) => {
|
test("double-clicking a single-select label selects once without advancing", async ({
|
||||||
|
page,
|
||||||
|
context,
|
||||||
|
}) => {
|
||||||
test.setTimeout(180_000);
|
test.setTimeout(180_000);
|
||||||
const { session, card } = await openLinkedQuestions(page, context);
|
const { session, card } = await openLinkedQuestions(page, context);
|
||||||
try {
|
try {
|
||||||
await card.getByRole("radio", { name: "Done" }).getByText("Done", { exact: true }).dblclick();
|
await card.getByRole("radio", { name: "Done" }).getByText("Done", { exact: true }).dblclick();
|
||||||
|
await expectCurrentQuestion(page, { index: 1, total: 2, question: LINKED_QUESTION });
|
||||||
|
await expectChecked(card.getByRole("radio", { name: "Done" }), true);
|
||||||
|
await continueToNextQuestion(page);
|
||||||
|
|
||||||
await expectCurrentQuestion(page, { index: 2, total: 2, question: CHECKS_QUESTION });
|
await expectCurrentQuestion(page, { index: 2, total: 2, question: CHECKS_QUESTION });
|
||||||
await expectChecked(card.getByRole("checkbox", { name: "Lint" }), false);
|
await expectChecked(card.getByRole("checkbox", { name: "Lint" }), false);
|
||||||
@@ -154,14 +154,12 @@ test.describe("Question option text", () => {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
test("multi-select description links and selection leave the option unchanged", async ({
|
test("multi-select descriptions support links and text selection", async ({ page, context }) => {
|
||||||
page,
|
|
||||||
context,
|
|
||||||
}) => {
|
|
||||||
test.setTimeout(180_000);
|
test.setTimeout(180_000);
|
||||||
const { session, card } = await openLinkedQuestions(page, context);
|
const { session, card } = await openLinkedQuestions(page, context);
|
||||||
try {
|
try {
|
||||||
await card.getByRole("radio", { name: "Done" }).getByText("Done", { exact: true }).click();
|
await card.getByRole("radio", { name: "Done" }).getByText("Done", { exact: true }).click();
|
||||||
|
await continueToNextQuestion(page);
|
||||||
await expectCurrentQuestion(page, { index: 2, total: 2, question: CHECKS_QUESTION });
|
await expectCurrentQuestion(page, { index: 2, total: 2, question: CHECKS_QUESTION });
|
||||||
|
|
||||||
const lint = card.getByRole("checkbox", { name: "Lint" });
|
const lint = card.getByRole("checkbox", { name: "Lint" });
|
||||||
@@ -177,18 +175,16 @@ test.describe("Question option text", () => {
|
|||||||
|
|
||||||
await dragAcross(page, description);
|
await dragAcross(page, description);
|
||||||
await expect.poll(() => selectedText(page)).toBe(LINT_DESCRIPTION);
|
await expect.poll(() => selectedText(page)).toBe(LINT_DESCRIPTION);
|
||||||
await expectChecked(lint, false);
|
|
||||||
|
|
||||||
await description.getByText("Rules:", { exact: false }).dblclick({
|
await description.getByText("Rules:", { exact: false }).dblclick({
|
||||||
position: { x: 4, y: 4 },
|
position: { x: 4, y: 4 },
|
||||||
});
|
});
|
||||||
await expect.poll(() => selectedText(page)).toBe("Rules");
|
await expect.poll(() => selectedText(page)).toBe("Rules");
|
||||||
await expectChecked(lint, false);
|
await expectChecked(lint, true);
|
||||||
|
|
||||||
await typecheck.getByText("Typecheck", { exact: true }).dblclick();
|
await typecheck.getByText("Typecheck", { exact: true }).dblclick();
|
||||||
await expectChecked(typecheck, true);
|
await expectChecked(typecheck, true);
|
||||||
await lint.getByText("Lint", { exact: true }).click();
|
await lint.getByText("Lint", { exact: true }).click();
|
||||||
await expectChecked(lint, true);
|
await expectChecked(lint, false);
|
||||||
} finally {
|
} finally {
|
||||||
await session.cleanup();
|
await session.cleanup();
|
||||||
}
|
}
|
||||||
@@ -268,6 +264,7 @@ test.describe("Question prompt pagination", () => {
|
|||||||
await expectQuestionHidden(page, SUCCESS_QUESTION);
|
await expectQuestionHidden(page, SUCCESS_QUESTION);
|
||||||
|
|
||||||
await chooseQuestionOption(page, "App");
|
await chooseQuestionOption(page, "App");
|
||||||
|
await continueToNextQuestion(page);
|
||||||
await expectCurrentQuestion(page, {
|
await expectCurrentQuestion(page, {
|
||||||
index: 2,
|
index: 2,
|
||||||
total: TOTAL_QUESTIONS,
|
total: TOTAL_QUESTIONS,
|
||||||
@@ -288,6 +285,7 @@ test.describe("Question prompt pagination", () => {
|
|||||||
preview: 'flags.enabled("new-surface")',
|
preview: 'flags.enabled("new-surface")',
|
||||||
});
|
});
|
||||||
await chooseQuestionOption(page, "Behind feature flag");
|
await chooseQuestionOption(page, "Behind feature flag");
|
||||||
|
await continueToNextQuestion(page);
|
||||||
await expectCurrentQuestion(page, {
|
await expectCurrentQuestion(page, {
|
||||||
index: 3,
|
index: 3,
|
||||||
total: TOTAL_QUESTIONS,
|
total: TOTAL_QUESTIONS,
|
||||||
@@ -466,7 +464,9 @@ retryTest(
|
|||||||
retryTest.setTimeout(180_000);
|
retryTest.setTimeout(180_000);
|
||||||
const card = page.getByTestId("question-form-card");
|
const card = page.getByTestId("question-form-card");
|
||||||
await chooseQuestionOption(page, "App");
|
await chooseQuestionOption(page, "App");
|
||||||
|
await continueToNextQuestion(page);
|
||||||
await chooseQuestionOption(page, "Behind feature flag");
|
await chooseQuestionOption(page, "Behind feature flag");
|
||||||
|
await continueToNextQuestion(page);
|
||||||
await fillQuestionAnswer(page, {
|
await fillQuestionAnswer(page, {
|
||||||
question: SUCCESS_QUESTION,
|
question: SUCCESS_QUESTION,
|
||||||
answer: "Preserve my answers after a failed submission.",
|
answer: "Preserve my answers after a failed submission.",
|
||||||
@@ -520,7 +520,9 @@ retryTest(
|
|||||||
const card = page.getByTestId("question-form-card");
|
const card = page.getByTestId("question-form-card");
|
||||||
questionClient.releaseFirstResponse();
|
questionClient.releaseFirstResponse();
|
||||||
await chooseQuestionOption(page, "App");
|
await chooseQuestionOption(page, "App");
|
||||||
|
await continueToNextQuestion(page);
|
||||||
await chooseQuestionOption(page, "Behind feature flag");
|
await chooseQuestionOption(page, "Behind feature flag");
|
||||||
|
await continueToNextQuestion(page);
|
||||||
await fillQuestionAnswer(page, {
|
await fillQuestionAnswer(page, {
|
||||||
question: SUCCESS_QUESTION,
|
question: SUCCESS_QUESTION,
|
||||||
answer: "Start with the internal team.",
|
answer: "Start with the internal team.",
|
||||||
|
|||||||
@@ -1,3 +1,8 @@
|
|||||||
|
import {
|
||||||
|
openGlobalNewWorkspaceComposer,
|
||||||
|
fillNewWorkspaceDraft,
|
||||||
|
expectNewWorkspaceDraft,
|
||||||
|
} from "../support/helpers/new-workspace";
|
||||||
import { readFile, mkdir, rename, rm } from "node:fs/promises";
|
import { readFile, mkdir, rename, rm } from "node:fs/promises";
|
||||||
import path from "node:path";
|
import path from "node:path";
|
||||||
import type { DaemonClient } from "@getpaseo/client/internal/daemon-client";
|
import type { DaemonClient } from "@getpaseo/client/internal/daemon-client";
|
||||||
@@ -257,12 +262,15 @@ test.describe("Settings host page", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
test("restart recovery host controls persist the opt-out and custom prompt", async ({ page }) => {
|
test("restart recovery defaults off and persists opt-in and custom prompt", async ({ page }) => {
|
||||||
const serverId = getServerId();
|
const serverId = getServerId();
|
||||||
await gotoAppShell(page);
|
await gotoAppShell(page);
|
||||||
await openSettings(page);
|
await openSettings(page);
|
||||||
await openSettingsHost(page, serverId);
|
await openSettingsHost(page, serverId);
|
||||||
await openHostSection(page, serverId, "agents");
|
await openHostSection(page, serverId, "agents");
|
||||||
|
await expectRestartRecoveryEnabled(page, false);
|
||||||
|
await setRestartRecoveryEnabled(page, true);
|
||||||
|
await page.reload();
|
||||||
await expectRestartRecoveryEnabled(page, true);
|
await expectRestartRecoveryEnabled(page, true);
|
||||||
await expectRestartRecoveryPrompt(page, "Resume working.");
|
await expectRestartRecoveryPrompt(page, "Resume working.");
|
||||||
await editRestartRecoveryPrompt(page, "Continue the interrupted work.");
|
await editRestartRecoveryPrompt(page, "Continue the interrupted work.");
|
||||||
@@ -273,3 +281,71 @@ test("restart recovery host controls persist the opt-out and custom prompt", asy
|
|||||||
await expectRestartRecoveryPrompt(page, "Continue the interrupted work.");
|
await expectRestartRecoveryPrompt(page, "Continue the interrupted work.");
|
||||||
await editRestartRecoveryPrompt(page, "Resume working.");
|
await editRestartRecoveryPrompt(page, "Resume working.");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("sidebar Add host preserves its caller and stays closed after theme changes", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await expect(page).toHaveURL(/\/open-project$/);
|
||||||
|
const originalUrl = page.url();
|
||||||
|
await openSidebarAddHost(page);
|
||||||
|
await expect(page).toHaveURL(originalUrl);
|
||||||
|
await closeAddHostAndChangeTheme(page);
|
||||||
|
await expect(page.getByRole("button", { name: "Direct connection", exact: true })).toBeHidden();
|
||||||
|
await expect(page).toHaveURL(originalUrl);
|
||||||
|
});
|
||||||
|
|
||||||
|
async function openSidebarAddHost(page: import("@playwright/test").Page) {
|
||||||
|
await page.getByRole("button", { name: "Hosts", exact: true }).click();
|
||||||
|
await page.getByRole("button", { name: "Add host", exact: true }).click();
|
||||||
|
await expect(page.getByRole("button", { name: "Direct connection", exact: true })).toBeVisible();
|
||||||
|
}
|
||||||
|
|
||||||
|
async function closeAddHostAndChangeTheme(page: import("@playwright/test").Page) {
|
||||||
|
await page.getByRole("button", { name: "Close", exact: true }).click();
|
||||||
|
await expect(page.getByRole("button", { name: "Direct connection", exact: true })).toBeHidden();
|
||||||
|
await page.keyboard.press("Control+Alt+t");
|
||||||
|
}
|
||||||
|
|
||||||
|
test("sidebar Add host completes without navigating", async ({ page }) => {
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await expect(page).toHaveURL(/\/open-project$/);
|
||||||
|
const originalUrl = page.url();
|
||||||
|
await openSidebarAddHost(page);
|
||||||
|
await connectToTestHost(page);
|
||||||
|
await expect(page).toHaveURL(originalUrl);
|
||||||
|
await expect(page.getByRole("button", { name: "Hosts", exact: true })).toBeVisible();
|
||||||
|
});
|
||||||
|
|
||||||
|
test("Settings Add host opens the saved host Overview", async ({ page }) => {
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await openSettings(page);
|
||||||
|
await addDirectHostFromSettings(page, { host: "127.0.0.1", port: Number(getE2EDaemonPort()) });
|
||||||
|
await expectSettingsHeader(page, "Overview");
|
||||||
|
await expect(page).toHaveURL(new RegExp(`/settings/hosts/${getServerId()}/host$`));
|
||||||
|
});
|
||||||
|
|
||||||
|
test("New workspace Add host preserves the prompt after connecting", async ({ page }) => {
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await openGlobalNewWorkspaceComposer(page);
|
||||||
|
await fillNewWorkspaceDraft(page, "Keep this unfinished prompt while I add a host.");
|
||||||
|
const originalUrl = page.url();
|
||||||
|
await openNewWorkspaceAddHost(page);
|
||||||
|
await expect(page).toHaveURL(originalUrl);
|
||||||
|
await connectToTestHost(page);
|
||||||
|
await expect(page).toHaveURL(originalUrl);
|
||||||
|
await expectNewWorkspaceDraft(page, "Keep this unfinished prompt while I add a host.");
|
||||||
|
});
|
||||||
|
|
||||||
|
async function openNewWorkspaceAddHost(page: import("@playwright/test").Page) {
|
||||||
|
await page.getByTestId("host-picker-trigger").click();
|
||||||
|
await page.getByRole("button", { name: "Add host", exact: true }).click();
|
||||||
|
}
|
||||||
|
|
||||||
|
async function connectToTestHost(page: import("@playwright/test").Page) {
|
||||||
|
await page.getByRole("button", { name: "Direct connection", exact: true }).click();
|
||||||
|
await page.getByRole("textbox", { name: "Host", exact: true }).fill("127.0.0.1");
|
||||||
|
await page.getByRole("textbox", { name: "Port", exact: true }).fill(String(getE2EDaemonPort()));
|
||||||
|
await page.getByRole("button", { name: "Connect", exact: true }).click();
|
||||||
|
await expect(page.getByTestId("add-host-modal")).toBeHidden({ timeout: 30_000 });
|
||||||
|
}
|
||||||
|
|||||||
@@ -38,6 +38,9 @@ import {
|
|||||||
fillDirectHostUri,
|
fillDirectHostUri,
|
||||||
expectDirectHostFormValues,
|
expectDirectHostFormValues,
|
||||||
expectDirectHostSslEnabled,
|
expectDirectHostSslEnabled,
|
||||||
|
expectDirectHostSslDisabled,
|
||||||
|
fillDirectHostAddress,
|
||||||
|
toggleDirectHostSsl,
|
||||||
expectDirectHostUriValue,
|
expectDirectHostUriValue,
|
||||||
expectDirectHostUriHidden,
|
expectDirectHostUriHidden,
|
||||||
expectDiagnosticsContent,
|
expectDiagnosticsContent,
|
||||||
@@ -284,6 +287,16 @@ test.describe("Settings sidebar navigation", () => {
|
|||||||
await expectAddHostMethodOptions(page);
|
await expectAddHostMethodOptions(page);
|
||||||
await selectHostConnectionType(page, "direct");
|
await selectHostConnectionType(page, "direct");
|
||||||
|
|
||||||
|
await fillDirectHostAddress(page, "example.paseo.test", "7443");
|
||||||
|
await expectDirectHostSslDisabled(page);
|
||||||
|
await toggleDirectHostSsl(page);
|
||||||
|
await expectDirectHostSslEnabled(page);
|
||||||
|
await toggleHostAdvanced(page);
|
||||||
|
await expectDirectHostUriValue(page, "tcp://example.paseo.test:7443?ssl=true");
|
||||||
|
await toggleHostAdvanced(page);
|
||||||
|
await toggleDirectHostSsl(page);
|
||||||
|
await expectDirectHostSslDisabled(page);
|
||||||
|
|
||||||
await toggleHostAdvanced(page);
|
await toggleHostAdvanced(page);
|
||||||
await fillDirectHostUri(page, "tcp://example.paseo.test:7443?ssl=true&password=shared-secret");
|
await fillDirectHostUri(page, "tcp://example.paseo.test:7443?ssl=true&password=shared-secret");
|
||||||
await toggleHostAdvanced(page);
|
await toggleHostAdvanced(page);
|
||||||
@@ -313,12 +326,12 @@ test.describe("Settings sidebar navigation", () => {
|
|||||||
|
|
||||||
await test.step("a dropdown owns Escape", async () => {
|
await test.step("a dropdown owns Escape", async () => {
|
||||||
await openSettingsSection(page, "appearance");
|
await openSettingsSection(page, "appearance");
|
||||||
await page.getByLabel(/Theme:/).click();
|
await page.getByLabel(/Highlight theme:/).click();
|
||||||
await expect(page.getByRole("menuitem", { name: "System", exact: true })).toBeVisible();
|
await expect(page.getByRole("menuitem", { name: "GitHub", exact: true })).toBeVisible();
|
||||||
|
|
||||||
await page.keyboard.press("Escape");
|
await page.keyboard.press("Escape");
|
||||||
|
|
||||||
await expect(page.getByRole("menuitem", { name: "System", exact: true })).toHaveCount(0);
|
await expect(page.getByRole("menuitem", { name: "GitHub", exact: true })).toHaveCount(0);
|
||||||
await expect(page).toHaveURL(/\/settings(\/|$)/);
|
await expect(page).toHaveURL(/\/settings(\/|$)/);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -97,6 +97,7 @@ test("fixed footer line keeps its five icons, Help and Settings at the end", asy
|
|||||||
await setFooterItemVisible(page, "usage", true);
|
await setFooterItemVisible(page, "usage", true);
|
||||||
await leaveSettings(page);
|
await leaveSettings(page);
|
||||||
await page.setViewportSize({ width: 390, height: 844 });
|
await page.setViewportSize({ width: 390, height: 844 });
|
||||||
|
await openCompactSidebar(page);
|
||||||
await expectCompactSidebarOpen(page);
|
await expectCompactSidebarOpen(page);
|
||||||
await expectFooterSeparator(page, true);
|
await expectFooterSeparator(page, true);
|
||||||
await expectFooterIconRow(page);
|
await expectFooterIconRow(page);
|
||||||
|
|||||||
@@ -426,3 +426,81 @@ test("Manual restores pre-beta order and keeps drag order across sorting and rel
|
|||||||
await seed.cleanup();
|
await seed.cleanup();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
function workspaceRows(page: Page, ids: string[]) {
|
||||||
|
return page.locator(
|
||||||
|
ids.map((id) => `[data-testid="sidebar-workspace-row-${getServerId()}:${id}"]`).join(", "),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
async function openWorkspaceRow(page: Page, workspaceId: string) {
|
||||||
|
await page.getByTestId(`sidebar-workspace-row-${getServerId()}:${workspaceId}`).click();
|
||||||
|
await expect(page).toHaveURL(new RegExp(`/workspace/${workspaceId}`));
|
||||||
|
}
|
||||||
|
|
||||||
|
test("collapsed groups lead with the open workspace instead of hiding it behind Show more", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
test.setTimeout(120_000);
|
||||||
|
const { seed, ids } = await seedCompactProject();
|
||||||
|
try {
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await waitForSidebarHydration(page);
|
||||||
|
await selectWorkspaceSort(page, "Created");
|
||||||
|
const { rows, group } = compactProjectRows(page, seed);
|
||||||
|
await expectWorkspaceOrder(rows, ids.slice(0, 7));
|
||||||
|
await revealWorkspaces(group, "Show more");
|
||||||
|
await openWorkspaceRow(page, ids[9]!);
|
||||||
|
await expectWorkspaceOrder(rows, ids);
|
||||||
|
await revealWorkspaces(group, "Show less");
|
||||||
|
await expectWorkspaceOrder(rows, [ids[9]!, ...ids.slice(0, 7)]);
|
||||||
|
await expect(
|
||||||
|
page.getByTestId(`sidebar-workspace-row-${getServerId()}:${ids[9]!}`),
|
||||||
|
).toHaveAttribute("aria-selected", "true");
|
||||||
|
await reconnectSidebar(page);
|
||||||
|
await expectWorkspaceOrder(rows, [ids[9]!, ...ids.slice(0, 7)]);
|
||||||
|
await expect(
|
||||||
|
page.getByTestId(`sidebar-workspace-row-${getServerId()}:${ids[9]!}`),
|
||||||
|
).toHaveAttribute("aria-selected", "true");
|
||||||
|
await openWorkspaceRow(page, ids[2]!);
|
||||||
|
await expectWorkspaceOrder(rows, ids.slice(0, 7));
|
||||||
|
await expect(
|
||||||
|
page.getByTestId(`sidebar-workspace-row-${getServerId()}:${ids[2]!}`),
|
||||||
|
).toHaveAttribute("aria-selected", "true");
|
||||||
|
} finally {
|
||||||
|
await seed.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test("a Manual drag in a collapsed group keeps the open workspace's saved place", async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
test.setTimeout(120_000);
|
||||||
|
const { seed, ids } = await seedCompactProject();
|
||||||
|
try {
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await waitForSidebarHydration(page);
|
||||||
|
const projectKey = projectEquivalenceViewKey(seed.projectKey);
|
||||||
|
await restorePreBetaOrder(
|
||||||
|
page,
|
||||||
|
projectKey,
|
||||||
|
ids.map((id) => `${getServerId()}:${id}`),
|
||||||
|
);
|
||||||
|
await selectWorkspaceSort(page, "Manual");
|
||||||
|
const rows = workspaceRows(page, ids);
|
||||||
|
const toggle = page.getByTestId(`sidebar-project-show-more-${projectKey}`);
|
||||||
|
await expectWorkspaceOrder(rows, ids.slice(0, 7));
|
||||||
|
await toggle.click();
|
||||||
|
await openWorkspaceRow(page, ids[9]!);
|
||||||
|
await toggle.click();
|
||||||
|
await expectWorkspaceOrder(rows, [ids[9]!, ...ids.slice(0, 7)]);
|
||||||
|
await quickDragFirstRowAfterSecond(workspaceRows(page, [ids[0]!, ids[1]!]), pressWorkspaceRow);
|
||||||
|
await expectWorkspaceOrder(rows, [ids[9]!, ids[1]!, ids[0]!, ...ids.slice(2, 7)]);
|
||||||
|
await reconnectSidebar(page);
|
||||||
|
await expectWorkspaceOrder(rows, [ids[9]!, ids[1]!, ids[0]!, ...ids.slice(2, 7)]);
|
||||||
|
await toggle.click();
|
||||||
|
await expectWorkspaceOrder(rows, [ids[1]!, ids[0]!, ...ids.slice(2)]);
|
||||||
|
} finally {
|
||||||
|
await seed.cleanup();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|||||||
@@ -13,6 +13,7 @@ import {
|
|||||||
movePointerAwayFromWorkspaceHoverCard,
|
movePointerAwayFromWorkspaceHoverCard,
|
||||||
openMobileAgentSidebar,
|
openMobileAgentSidebar,
|
||||||
pinWorkspaceFromSidebar,
|
pinWorkspaceFromSidebar,
|
||||||
|
scrollWorkspaceList,
|
||||||
} from "../support/helpers/sidebar";
|
} from "../support/helpers/sidebar";
|
||||||
import { seedWorkspace } from "../support/helpers/seed-client";
|
import { seedWorkspace } from "../support/helpers/seed-client";
|
||||||
import { expectWorkspaceHeader } from "../support/helpers/workspace-ui";
|
import { expectWorkspaceHeader } from "../support/helpers/workspace-ui";
|
||||||
@@ -582,6 +583,12 @@ test.describe("Half-screen desktop layout", () => {
|
|||||||
await page.getByTestId("menu-button").click();
|
await page.getByTestId("menu-button").click();
|
||||||
await expect(page.getByTestId("sidebar-global-new-workspace")).toBeVisible();
|
await expect(page.getByTestId("sidebar-global-new-workspace")).toBeVisible();
|
||||||
await expect(sidebarScroll).toHaveJSProperty("scrollTop", scrollTop);
|
await expect(sidebarScroll).toHaveJSProperty("scrollTop", scrollTop);
|
||||||
|
|
||||||
|
await movePointerAwayFromWorkspaceHoverCard(page);
|
||||||
|
await focusWorkspaceRowWithKeyboard(page, lastWorkspaceId);
|
||||||
|
await expectWorkspaceHoverCardOpen(page);
|
||||||
|
await scrollWorkspaceList(page);
|
||||||
|
await expectWorkspaceHoverCardClosed(page);
|
||||||
} finally {
|
} finally {
|
||||||
await workspace.cleanup();
|
await workspace.cleanup();
|
||||||
}
|
}
|
||||||
@@ -645,6 +652,9 @@ test.describe("Half-screen desktop layout", () => {
|
|||||||
.locator('[data-testid^="workspace-pane-"]')
|
.locator('[data-testid^="workspace-pane-"]')
|
||||||
.getByTestId("workspace-tabs-row")
|
.getByTestId("workspace-tabs-row")
|
||||||
.filter({ visible: true }),
|
.filter({ visible: true }),
|
||||||
|
).toHaveCount(0);
|
||||||
|
await expect(
|
||||||
|
page.getByTestId("workspace-tab-switcher-trigger").filter({ visible: true }),
|
||||||
).toHaveCount(1);
|
).toHaveCount(1);
|
||||||
|
|
||||||
await explorerToggle.click();
|
await explorerToggle.click();
|
||||||
|
|||||||
@@ -38,8 +38,12 @@ async function openParentInRightPane(page: Page, parentId: string, workspaceId:
|
|||||||
await expect(left).toBeVisible();
|
await expect(left).toBeVisible();
|
||||||
await expect(right).toBeVisible();
|
await expect(right).toBeVisible();
|
||||||
await expect(right).not.toHaveAttribute("data-testid", "workspace-pane-main");
|
await expect(right).not.toHaveAttribute("data-testid", "workspace-pane-main");
|
||||||
|
// A later split can replace the parent pane's rail with compact chrome.
|
||||||
|
// Keep the pane identity instead of finding it again through that rail.
|
||||||
|
const rightPaneId = await right.getAttribute("data-testid");
|
||||||
|
expect(rightPaneId).not.toBeNull();
|
||||||
await left.locator('[data-testid^="workspace-tab-draft_"]').click();
|
await left.locator('[data-testid^="workspace-tab-draft_"]').click();
|
||||||
return { left, right };
|
return { left, right: page.getByTestId(rightPaneId!) };
|
||||||
}
|
}
|
||||||
|
|
||||||
test.beforeEach(async ({ page }) => {
|
test.beforeEach(async ({ page }) => {
|
||||||
|
|||||||
@@ -1,3 +1,4 @@
|
|||||||
|
import { getServerId } from "../support/helpers/server-id";
|
||||||
import { runWorkspaceActionFromCommandCenter } from "../support/helpers/command-center-workspace-actions";
|
import { runWorkspaceActionFromCommandCenter } from "../support/helpers/command-center-workspace-actions";
|
||||||
import { spawnSync } from "node:child_process";
|
import { spawnSync } from "node:child_process";
|
||||||
import { readFile, writeFile } from "node:fs/promises";
|
import { readFile, writeFile } from "node:fs/promises";
|
||||||
@@ -413,6 +414,8 @@ test("searches retained output without sending Find input to the shell", async (
|
|||||||
test("keeps terminal Find owned by retained tabs and the focused split pane", async ({
|
test("keeps terminal Find owned by retained tabs and the focused split pane", async ({
|
||||||
page,
|
page,
|
||||||
}, testInfo) => {
|
}, testInfo) => {
|
||||||
|
// This journey selects tabs from the full rails in both split panes.
|
||||||
|
await page.setViewportSize({ width: 1600, height: 900 });
|
||||||
const first = await harness.createTerminal({
|
const first = await harness.createTerminal({
|
||||||
name: "First search",
|
name: "First search",
|
||||||
command: "bash",
|
command: "bash",
|
||||||
@@ -487,3 +490,142 @@ test("keeps the shared Find controls usable in a compact dark browser", async ({
|
|||||||
await page.getByRole("button", { name: "Close Find" }).click();
|
await page.getByRole("button", { name: "Close Find" }).click();
|
||||||
await expect(input(page)).toBeFocused();
|
await expect(input(page)).toBeFocused();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// A phone browser installs xterm's document-level touch gesture listener too.
|
||||||
|
// Keep this journey touch-enabled so it catches duplicate scroll handling.
|
||||||
|
test.describe("terminal history with a finger", () => {
|
||||||
|
test.use({ isMobile: true, hasTouch: true, viewport: { width: 390, height: 844 } });
|
||||||
|
|
||||||
|
test("scrolls history once per finger drag", async ({ page }) => {
|
||||||
|
await openPhoneTerminalHistory(page);
|
||||||
|
await expectSingleFingerScroll(page, 24);
|
||||||
|
await expectSingleFingerScroll(page, 1);
|
||||||
|
await expectMouseWheelScrollsHistory(page);
|
||||||
|
});
|
||||||
|
|
||||||
|
for (const mode of ["alternate", "mouse"] as const) {
|
||||||
|
test(`preserves finger navigation in ${mode} input mode`, async ({ page }) => {
|
||||||
|
await openPhoneInputCapture(page, mode);
|
||||||
|
await expectFingerNavigationInput(page, mode);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
async function expectFingerNavigationInput(page: Page, mode: "alternate" | "mouse") {
|
||||||
|
await dragTerminalWithFinger(page, 24, async () => {
|
||||||
|
const prefix = mode === "alternate" ? "TOUCH_BYTES:1b4f41" : "TOUCH_BYTES:1b5b3c3634";
|
||||||
|
await expect.poll(() => getTerminalBufferText(page)).toContain(prefix);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
async function openPhoneTerminalHistory(page: Page) {
|
||||||
|
await harness.createTerminal({
|
||||||
|
name: "Finger scroll history",
|
||||||
|
command: "bash",
|
||||||
|
args: [
|
||||||
|
"--noprofile",
|
||||||
|
"--norc",
|
||||||
|
"-c",
|
||||||
|
"for i in $(seq 1 150); do echo HISTORY_$i; done; exec sleep 300",
|
||||||
|
],
|
||||||
|
});
|
||||||
|
await openPhoneTerminal(page);
|
||||||
|
await expect.poll(() => getTerminalBufferText(page)).toContain("HISTORY_150");
|
||||||
|
}
|
||||||
|
|
||||||
|
async function openPhoneInputCapture(page: Page, mode: "alternate" | "mouse") {
|
||||||
|
const escapes = mode === "alternate" ? "\x1b[?1049h\x1b[?1h" : "\x1b[?1000h\x1b[?1006h";
|
||||||
|
await harness.createTerminal({
|
||||||
|
name: "Touch application input",
|
||||||
|
command: process.execPath,
|
||||||
|
args: [
|
||||||
|
"-e",
|
||||||
|
`
|
||||||
|
process.stdin.setRawMode(true);
|
||||||
|
process.stdin.once("data", () => {
|
||||||
|
process.stdin.on("data", chunk => {
|
||||||
|
process.stdout.write("\\r\\nTOUCH_BYTES:" + chunk.toString("hex") + ":END\\r\\n");
|
||||||
|
});
|
||||||
|
process.stdout.write(${JSON.stringify(escapes)} + "TOUCH_INPUT_READY\\r\\n");
|
||||||
|
});
|
||||||
|
process.stdout.write("TOUCH_START_READY\\r\\n");
|
||||||
|
`,
|
||||||
|
],
|
||||||
|
});
|
||||||
|
await openPhoneTerminal(page);
|
||||||
|
await expect.poll(() => getTerminalBufferText(page)).toContain("TOUCH_START_READY");
|
||||||
|
await input(page).press("x");
|
||||||
|
await expect.poll(() => getTerminalBufferText(page)).toContain("TOUCH_INPUT_READY");
|
||||||
|
await expect
|
||||||
|
.poll(() => page.evaluate(() => window.__paseoTerminal!.buffer.active.type))
|
||||||
|
.toBe(mode === "alternate" ? "alternate" : "normal");
|
||||||
|
await expect
|
||||||
|
.poll(() => page.evaluate(() => window.__paseoTerminal!.modes.mouseTrackingMode))
|
||||||
|
.toBe(mode === "mouse" ? "vt200" : "none");
|
||||||
|
}
|
||||||
|
|
||||||
|
async function openPhoneTerminal(page: Page) {
|
||||||
|
await page.goto("/");
|
||||||
|
await page.getByRole("button", { name: "Open menu", exact: true }).click();
|
||||||
|
await page.getByTestId(`sidebar-workspace-row-${getServerId()}:${harness.workspaceId}`).click();
|
||||||
|
await expect(page.getByRole("textbox", { name: "Terminal input" })).toBeVisible();
|
||||||
|
await expect(page.getByTestId("terminal-surface").filter({ visible: true })).toBeVisible();
|
||||||
|
}
|
||||||
|
|
||||||
|
async function expectMouseWheelScrollsHistory(page: Page) {
|
||||||
|
const beforeWheel = (await viewport(page))!;
|
||||||
|
await page.mouse.move(200, 300);
|
||||||
|
await page.mouse.wheel(0, -120);
|
||||||
|
await expect.poll(() => viewport(page)).toBeLessThan(beforeWheel);
|
||||||
|
}
|
||||||
|
|
||||||
|
async function expectSingleFingerScroll(page: Page, moves: number) {
|
||||||
|
await dragTerminalWithFinger(page, moves, async ({ lineHeight, before }) => {
|
||||||
|
await expect.poll(async () => before - (await viewport(page))!).toBeGreaterThan(0);
|
||||||
|
const moved = before - (await viewport(page))!;
|
||||||
|
await test.info().attach("finger-scroll", {
|
||||||
|
body: JSON.stringify({ moves, distancePx: 120, lineHeight, rowsMoved: moved }),
|
||||||
|
contentType: "application/json",
|
||||||
|
});
|
||||||
|
expect(moved, "one gesture must not scroll twice its physical distance").toBeLessThanOrEqual(
|
||||||
|
Math.ceil(120 / lineHeight),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
async function dragTerminalWithFinger(
|
||||||
|
page: Page,
|
||||||
|
moves: number,
|
||||||
|
inspect: (state: { lineHeight: number; before: number }) => Promise<void>,
|
||||||
|
) {
|
||||||
|
await test.step(`Drag history with ${moves} touch moves`, async () => {
|
||||||
|
const screen = page
|
||||||
|
.getByTestId("terminal-surface")
|
||||||
|
.filter({ visible: true })
|
||||||
|
.locator(".xterm-screen");
|
||||||
|
const box = await screen.boundingBox();
|
||||||
|
if (!box) throw new Error("Terminal screen is not visible");
|
||||||
|
const rows = await page.evaluate(() => window.__paseoTerminal!.rows);
|
||||||
|
const lineHeight = box.height / rows;
|
||||||
|
const before = (await viewport(page))!;
|
||||||
|
const session = await page.context().newCDPSession(page);
|
||||||
|
try {
|
||||||
|
const start = { x: box.x + box.width / 2, y: box.y + box.height / 3 };
|
||||||
|
await session.send("Input.dispatchTouchEvent", {
|
||||||
|
type: "touchStart",
|
||||||
|
touchPoints: [{ ...start, id: 1 }],
|
||||||
|
});
|
||||||
|
for (let step = 1; step <= moves; step++) {
|
||||||
|
await session.send("Input.dispatchTouchEvent", {
|
||||||
|
type: "touchMove",
|
||||||
|
touchPoints: [{ x: start.x, y: start.y + (120 * step) / moves, id: 1 }],
|
||||||
|
});
|
||||||
|
}
|
||||||
|
// Check before lifting the finger to exclude inertial scrolling.
|
||||||
|
await inspect({ lineHeight, before });
|
||||||
|
} finally {
|
||||||
|
await session.send("Input.dispatchTouchEvent", { type: "touchEnd", touchPoints: [] });
|
||||||
|
await session.detach();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|||||||
@@ -1,5 +1,10 @@
|
|||||||
import type { Page } from "@playwright/test";
|
import type { Page } from "@playwright/test";
|
||||||
import { expect, test } from "../support/fixtures";
|
import { expect, test } from "../support/fixtures";
|
||||||
|
import {
|
||||||
|
expectTerminalCursor,
|
||||||
|
getTerminalBufferText,
|
||||||
|
waitForTerminalContent,
|
||||||
|
} from "../support/helpers/terminal-perf";
|
||||||
import { TerminalE2EHarness } from "../support/helpers/terminal-dsl";
|
import { TerminalE2EHarness } from "../support/helpers/terminal-dsl";
|
||||||
|
|
||||||
interface AttachOverlayProbeWindow extends Window {
|
interface AttachOverlayProbeWindow extends Window {
|
||||||
@@ -59,4 +64,65 @@ test.describe("retained terminal tab streams", () => {
|
|||||||
|
|
||||||
expect(await terminalAttachOverlayWasSeen(page)).toBe(false);
|
expect(await terminalAttachOverlayWasSeen(page)).toBe(false);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
for (const { count, retainedMarker } of [
|
||||||
|
{ count: 3000, retainedMarker: "history-0001界🙂" },
|
||||||
|
{ count: 12050, retainedMarker: "history-3000界🙂" },
|
||||||
|
]) {
|
||||||
|
test(`reattach restores retained styled Unicode history from ${count} lines`, async ({
|
||||||
|
page,
|
||||||
|
}) => {
|
||||||
|
await page.addInitScript(() => {
|
||||||
|
const key = "@paseo:app-settings";
|
||||||
|
const settings = JSON.parse(localStorage.getItem(key) ?? "{}");
|
||||||
|
localStorage.setItem(key, JSON.stringify({ ...settings, terminalScrollbackLines: 10000 }));
|
||||||
|
});
|
||||||
|
const terminal = await harness.createTerminal({
|
||||||
|
name: `history-${count}`,
|
||||||
|
command: "/bin/sh",
|
||||||
|
args: [
|
||||||
|
"-lc",
|
||||||
|
`i=1; while [ $i -le ${count} ]; do printf '\\033[31mhistory-%04d界🙂 payload-abcdefghijklmnopqrstuvwxyz0123456789\\033[0m\\n' $i; i=$((i+1)); done; sleep 120`,
|
||||||
|
],
|
||||||
|
});
|
||||||
|
const last = `history-${String(count).padStart(4, "0")}界🙂`;
|
||||||
|
await harness.openTerminal(page, { terminalId: terminal.id });
|
||||||
|
await waitForTerminalContent(page, (text) => text.includes(last), 10000);
|
||||||
|
expect(await getTerminalBufferText(page)).toContain(retainedMarker);
|
||||||
|
await page.reload();
|
||||||
|
await waitForTerminalContent(page, (text) => text.includes(last), 10000);
|
||||||
|
const restored = await getTerminalBufferText(page);
|
||||||
|
expect(restored).toContain(retainedMarker);
|
||||||
|
expect(restored.match(/history-\d{4,5}/g)?.length).toBeGreaterThanOrEqual(
|
||||||
|
Math.min(count, 10000),
|
||||||
|
);
|
||||||
|
if (count > 10000) expect(restored).not.toContain("history-0001界🙂");
|
||||||
|
});
|
||||||
|
}
|
||||||
|
for (const input of [
|
||||||
|
{ name: "client blinking bar", presentation: "", shape: "bar" as const, blinking: true },
|
||||||
|
{
|
||||||
|
name: "program blinking underline",
|
||||||
|
presentation: "\x1b[3 q",
|
||||||
|
shape: "underline" as const,
|
||||||
|
blinking: true,
|
||||||
|
},
|
||||||
|
]) {
|
||||||
|
test(`reattach preserves the ${input.name} cursor`, async ({ page }) => {
|
||||||
|
const terminal = await harness.createTerminal({
|
||||||
|
name: "cursor-presentation",
|
||||||
|
command: process.execPath,
|
||||||
|
args: [
|
||||||
|
"-e",
|
||||||
|
`process.stdout.write(${JSON.stringify(input.presentation + "CURSOR-READY\r\n")});setInterval(()=>{},1000)`,
|
||||||
|
],
|
||||||
|
});
|
||||||
|
await harness.openTerminal(page, { terminalId: terminal.id });
|
||||||
|
await waitForTerminalContent(page, (text) => text.includes("CURSOR-READY"), 10000);
|
||||||
|
await expectTerminalCursor(page, input);
|
||||||
|
await page.reload();
|
||||||
|
await waitForTerminalContent(page, (text) => text.includes("CURSOR-READY"), 10000);
|
||||||
|
await expectTerminalCursor(page, input);
|
||||||
|
});
|
||||||
|
}
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ import type { DaemonClient } from "@getpaseo/client/internal/daemon-client";
|
|||||||
import path from "node:path";
|
import path from "node:path";
|
||||||
import {
|
import {
|
||||||
holdOlderHistoryPages,
|
holdOlderHistoryPages,
|
||||||
|
scrollTimelineRowIntoView,
|
||||||
userScrollsTimelineToHistoryStart,
|
userScrollsTimelineToHistoryStart,
|
||||||
} from "../support/helpers/timeline-pagination";
|
} from "../support/helpers/timeline-pagination";
|
||||||
import { getActiveTabTestId } from "../support/helpers/launcher";
|
import { getActiveTabTestId } from "../support/helpers/launcher";
|
||||||
@@ -529,6 +530,7 @@ async function expectThinkingPresentation(page: Page, autoExpandReasoning: boole
|
|||||||
.last();
|
.last();
|
||||||
await expect(group).toContainText(/read 1 file/i);
|
await expect(group).toContainText(/read 1 file/i);
|
||||||
await expect(group.getByRole("button").first()).not.toContainText(/thought/i);
|
await expect(group.getByRole("button").first()).not.toContainText(/thought/i);
|
||||||
|
await scrollTimelineRowIntoView(page, group);
|
||||||
await group.getByRole("button").first().click();
|
await group.getByRole("button").first().click();
|
||||||
// Expand thinking is off: the group opens its rows, but the thought row stays closed
|
// Expand thinking is off: the group opens its rows, but the thought row stays closed
|
||||||
// until the reader opens it.
|
// until the reader opens it.
|
||||||
|
|||||||
@@ -0,0 +1,69 @@
|
|||||||
|
import { expect, test } from "../support/fixtures";
|
||||||
|
import { gotoAppShell } from "../support/helpers/app";
|
||||||
|
import { seedSidebarFooterPreferences } from "../support/helpers/sidebar-nav-settings";
|
||||||
|
import { installUsageReportsFixture } from "../support/helpers/usage-reports";
|
||||||
|
import {
|
||||||
|
claudeAndCodexReports,
|
||||||
|
openUsageFromIcon,
|
||||||
|
openUsageOptions,
|
||||||
|
closeUsageOptions,
|
||||||
|
closeUsage,
|
||||||
|
expectNoUsageItem,
|
||||||
|
expectPinnedUsage,
|
||||||
|
} from "../support/helpers/usage-sidebar-item";
|
||||||
|
|
||||||
|
test("Check usage applies to the host and Turn on restores cards", async ({
|
||||||
|
page,
|
||||||
|
e2eWorkerClient,
|
||||||
|
}) => {
|
||||||
|
test.setTimeout(180_000);
|
||||||
|
const previous = (await e2eWorkerClient.getDaemonConfig()).config.usage ?? { enabled: true };
|
||||||
|
try {
|
||||||
|
const usage = await installUsageReportsFixture(page, {
|
||||||
|
lists: [() => claudeAndCodexReports()],
|
||||||
|
});
|
||||||
|
await page.setViewportSize({ width: 1440, height: 1000 });
|
||||||
|
await seedSidebarFooterPreferences(page, [{ key: "usage", visible: true }]);
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await expectPinnedUsage(page, ["31% 5h", "54% wk", "7% 5h", "12% wk"]);
|
||||||
|
await openUsageFromIcon(page);
|
||||||
|
await usage.waitForListRequests(1);
|
||||||
|
await openUsageOptions(page);
|
||||||
|
await page.getByRole("switch", { name: "Check usage", exact: true }).click();
|
||||||
|
await closeUsageOptions(page);
|
||||||
|
await expect(page.getByRole("button", { name: "Turn on", exact: true })).toBeVisible();
|
||||||
|
await expect(page.getByRole("button", { name: "Refresh all", exact: true })).toHaveCount(0);
|
||||||
|
expect((await e2eWorkerClient.getDaemonConfig()).config.usage).toEqual({ enabled: false });
|
||||||
|
await expectNoUsageItem(page);
|
||||||
|
const before = usage.listRequests().length;
|
||||||
|
await closeUsage(page);
|
||||||
|
await page.reload();
|
||||||
|
await openUsageFromIcon(page);
|
||||||
|
await expect(page.getByRole("button", { name: "Turn on", exact: true })).toBeVisible();
|
||||||
|
expect(usage.listRequests()).toHaveLength(before);
|
||||||
|
await page.getByRole("button", { name: "Turn on", exact: true }).click();
|
||||||
|
await expect(page.getByText("Claude", { exact: true })).toBeVisible();
|
||||||
|
expect((await e2eWorkerClient.getDaemonConfig()).config.usage).toEqual({ enabled: true });
|
||||||
|
// A separate client changes the policy, as another device would.
|
||||||
|
await e2eWorkerClient.patchDaemonConfig({ usage: { enabled: false } });
|
||||||
|
await expect(page.getByRole("button", { name: "Turn on", exact: true })).toBeVisible();
|
||||||
|
await e2eWorkerClient.patchDaemonConfig({ usage: { enabled: true } });
|
||||||
|
await expect(page.getByText("Claude", { exact: true })).toBeVisible();
|
||||||
|
} finally {
|
||||||
|
await e2eWorkerClient.patchDaemonConfig({ usage: previous });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test("older hosts keep usage without a Check usage switch", async ({ page }) => {
|
||||||
|
test.setTimeout(180_000);
|
||||||
|
await installUsageReportsFixture(page, {
|
||||||
|
usageSettingSupported: false,
|
||||||
|
lists: [() => claudeAndCodexReports()],
|
||||||
|
});
|
||||||
|
await page.setViewportSize({ width: 1440, height: 1000 });
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await openUsageFromIcon(page);
|
||||||
|
await expect(page.getByText("Claude", { exact: true })).toBeVisible();
|
||||||
|
await openUsageOptions(page);
|
||||||
|
await expect(page.getByRole("switch", { name: "Check usage", exact: true })).toHaveCount(0);
|
||||||
|
});
|
||||||
@@ -441,3 +441,31 @@ test("released hosts supply source logos through the client conversion", async (
|
|||||||
).toHaveAttribute("d", codexPath);
|
).toHaveAttribute("d", codexPath);
|
||||||
await qaScreenshot(page, "released-host-usage-modal");
|
await qaScreenshot(page, "released-host-usage-modal");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("hidden usage sends no requests until opened", async ({ page }) => {
|
||||||
|
test.setTimeout(180_000);
|
||||||
|
const usage = await installUsageReportsFixture(page, { lists: [() => claudeAndCodexReports()] });
|
||||||
|
await page.setViewportSize(WIDE);
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await expectNoUsageItem(page);
|
||||||
|
await expect(page.getByRole("button", { name: "Usage", exact: true })).toBeVisible({
|
||||||
|
timeout: 90_000,
|
||||||
|
});
|
||||||
|
await openSidebarNavSettings(page);
|
||||||
|
await expectFooterItemSetting(page, "usage", false);
|
||||||
|
await leaveSettings(page);
|
||||||
|
expect(usage.listRequests()).toHaveLength(0);
|
||||||
|
await openUsageFromIcon(page);
|
||||||
|
await usage.waitForListRequests(1);
|
||||||
|
expect(usage.listRequests()).toHaveLength(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("visible usage summary requests reports on load", async ({ page }) => {
|
||||||
|
test.setTimeout(180_000);
|
||||||
|
const usage = await installUsageReportsFixture(page, { lists: [() => claudeAndCodexReports()] });
|
||||||
|
await seedSidebarFooterPreferences(page, [{ key: "usage", visible: true }]);
|
||||||
|
await page.setViewportSize(WIDE);
|
||||||
|
await gotoAppShell(page);
|
||||||
|
await expectPinnedUsage(page, ["31% 5h", "54% wk", "7% 5h", "12% wk"]);
|
||||||
|
expect(usage.listRequests()).toHaveLength(1);
|
||||||
|
});
|
||||||
|
|||||||
@@ -357,6 +357,8 @@ test.describe("Viewed agent timelines", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
test("two visible split chats both stay current", async ({ page }) => {
|
test("two visible split chats both stay current", async ({ page }) => {
|
||||||
|
// Keep both split panes wide enough for the tab-rail interactions below.
|
||||||
|
await page.setViewportSize({ width: 1600, height: 900 });
|
||||||
const scenario = await seedViewedTimelineScenario();
|
const scenario = await seedViewedTimelineScenario();
|
||||||
try {
|
try {
|
||||||
await enableMoveTabShortcut(page);
|
await enableMoveTabShortcut(page);
|
||||||
|
|||||||
@@ -101,3 +101,20 @@ test("focus mode only applies to the active workspace screen", async ({ page, wi
|
|||||||
await expect(exitFocusMode).toHaveCount(0);
|
await expect(exitFocusMode).toHaveCount(0);
|
||||||
await expect(settingsButton).toBeVisible();
|
await expect(settingsButton).toBeVisible();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
async function exitFocusModeFromCompactHeader(page: Page) {
|
||||||
|
await page.setViewportSize({ width: 400, height: 844 });
|
||||||
|
await page.getByTestId("workspace-header-menu-trigger").click();
|
||||||
|
await page.getByRole("menuitem", { name: "Exit focus mode", exact: true }).click();
|
||||||
|
await page.setViewportSize({ width: 1280, height: 900 });
|
||||||
|
}
|
||||||
|
|
||||||
|
test("compact workspace menu keeps focus mode exit reachable", async ({ page, withWorkspace }) => {
|
||||||
|
const workspace = await withWorkspace({ prefix: "compact-focus-exit-" });
|
||||||
|
await page.setViewportSize({ width: 1280, height: 900 });
|
||||||
|
await workspace.navigateTo();
|
||||||
|
await enterFocusMode(page);
|
||||||
|
await exitFocusModeFromCompactHeader(page);
|
||||||
|
await expect(exitFocusModeButton(page)).toHaveCount(0);
|
||||||
|
await expect(page.getByTestId("sidebar-global-new-workspace")).toBeVisible();
|
||||||
|
});
|
||||||
|
|||||||
@@ -52,6 +52,8 @@ async function waitForWorkspaceRoute(page: Page, route: string) {
|
|||||||
test.describe("Workspace pane mounting", () => {
|
test.describe("Workspace pane mounting", () => {
|
||||||
test("workspace navigation keeps the existing agent composer mounted", async ({ page }) => {
|
test("workspace navigation keeps the existing agent composer mounted", async ({ page }) => {
|
||||||
test.setTimeout(90_000);
|
test.setTimeout(90_000);
|
||||||
|
// Keep both split panes wide enough for the tab-rail interactions below.
|
||||||
|
await page.setViewportSize({ width: 1600, height: 900 });
|
||||||
const serverId = getServerId();
|
const serverId = getServerId();
|
||||||
|
|
||||||
const workspace = await seedWorkspace({ repoPrefix: "pane-remount-" });
|
const workspace = await seedWorkspace({ repoPrefix: "pane-remount-" });
|
||||||
|
|||||||
@@ -70,25 +70,31 @@ test("previous and next traverse every visible workspace while digit shortcuts s
|
|||||||
workspaceId: order[8],
|
workspaceId: order[8],
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
await test.step("hidden Done rows remain shortcut targets without expanding the project", async () => {
|
await test.step("collapsed groups keep shortcut targets selected without expanding", async () => {
|
||||||
await expectHiddenWorkspaceShortcuts(page, order);
|
await expectCollapsedWorkspaceShortcuts(page, order);
|
||||||
});
|
});
|
||||||
} finally {
|
} finally {
|
||||||
await project.cleanup();
|
await project.cleanup();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
async function expectHiddenWorkspaceShortcuts(page: Page, order: string[]) {
|
async function expectCollapsedWorkspaceShortcuts(page: Page, order: string[]) {
|
||||||
await page.getByLabel("Show less", { exact: true }).click();
|
await page.getByLabel("Show less", { exact: true }).click();
|
||||||
const rows = page.getByRole("button", { name: /^Workspace \d{2}$/ });
|
const rows = page.getByRole("button", { name: /^Workspace \d{2}$/ });
|
||||||
await expect(rows).toHaveCount(7);
|
await expect(rows).toHaveCount(8);
|
||||||
|
await expectSidebarWorkspaceSelected({ page, serverId: getServerId(), workspaceId: order[8] });
|
||||||
await switchWorkspaceViaSidebar({ page, serverId: getServerId(), workspaceId: order[0] });
|
await switchWorkspaceViaSidebar({ page, serverId: getServerId(), workspaceId: order[0] });
|
||||||
|
await expect(rows).toHaveCount(7);
|
||||||
await page.keyboard.press("Alt+9");
|
await page.keyboard.press("Alt+9");
|
||||||
await expect(page).toHaveURL(new RegExp(`/workspace/${order[8]}$`));
|
await expect(page).toHaveURL(new RegExp(`/workspace/${order[8]}$`));
|
||||||
|
await expectSidebarWorkspaceSelected({ page, serverId: getServerId(), workspaceId: order[8] });
|
||||||
|
await expect(rows).toHaveCount(8);
|
||||||
|
await page.keyboard.press("Alt+]");
|
||||||
|
await expect(page).toHaveURL(new RegExp(`/workspace/${order[9]}$`));
|
||||||
|
await expectSidebarWorkspaceSelected({ page, serverId: getServerId(), workspaceId: order[9] });
|
||||||
|
await expect(rows).toHaveCount(8);
|
||||||
await expect(page.getByTestId(`sidebar-workspace-row-${getServerId()}:${order[8]}`)).toHaveCount(
|
await expect(page.getByTestId(`sidebar-workspace-row-${getServerId()}:${order[8]}`)).toHaveCount(
|
||||||
0,
|
0,
|
||||||
);
|
);
|
||||||
await page.keyboard.press("Alt+]");
|
await expect(page.getByLabel("Show more", { exact: true })).toBeVisible();
|
||||||
await expect(page).toHaveURL(new RegExp(`/workspace/${order[9]}$`));
|
|
||||||
await expect(rows).toHaveCount(7);
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -6,6 +6,11 @@ env APP_ID=sh.paseo.debug
|
|||||||
# Hold past drag arming (180ms), then release.
|
# Hold past drag arming (180ms), then release.
|
||||||
open "${APP_ID}"
|
open "${APP_ID}"
|
||||||
press "label=\"Open menu\""
|
press "label=\"Open menu\""
|
||||||
|
wait "id=\"sidebar-close\"" 10000
|
||||||
|
press "id=\"sidebar-close\""
|
||||||
|
# The close target must clear system controls, including a trailing status column.
|
||||||
|
wait "label=\"Open menu\"" 5000
|
||||||
|
press "label=\"Open menu\""
|
||||||
wait "id=\"${WORKSPACE_ROW}\"" 10000
|
wait "id=\"${WORKSPACE_ROW}\"" 10000
|
||||||
longpress "id=\"${WORKSPACE_ROW}\"" 250
|
longpress "id=\"${WORKSPACE_ROW}\"" 250
|
||||||
press "id=\"${WORKSPACE_ROW}\""
|
press "id=\"${WORKSPACE_ROW}\""
|
||||||
|
|||||||
@@ -0,0 +1,104 @@
|
|||||||
|
// Run a release build with a connected workspace open and the keyboard hidden.
|
||||||
|
// ANDROID_SERIAL=emulator-5574 node packages/app/e2e/mobile/fold/android.mjs
|
||||||
|
import assert from "node:assert/strict";
|
||||||
|
import { execFileSync } from "node:child_process";
|
||||||
|
import { mkdirSync, writeFileSync } from "node:fs";
|
||||||
|
import { resolve } from "node:path";
|
||||||
|
import { setTimeout as delay } from "node:timers/promises";
|
||||||
|
|
||||||
|
const serial = process.env.ANDROID_SERIAL;
|
||||||
|
assert(serial, "Set ANDROID_SERIAL to a booted Android foldable emulator");
|
||||||
|
const appId = process.env.PASEO_MOBILE_APP_ID ?? "sh.paseo.debug";
|
||||||
|
const session = "android-fold";
|
||||||
|
const artifacts = resolve(".dev/agent-device-artifacts/android-fold");
|
||||||
|
const env = {
|
||||||
|
...process.env,
|
||||||
|
AGENT_DEVICE_STATE_DIR: resolve(".dev/agent-device-android-fold"),
|
||||||
|
};
|
||||||
|
mkdirSync(artifacts, { recursive: true });
|
||||||
|
|
||||||
|
function run(binary, args) {
|
||||||
|
return execFileSync(binary, args, { env, encoding: "utf8", timeout: 60_000 });
|
||||||
|
}
|
||||||
|
function adb(...args) {
|
||||||
|
return run("adb", ["-s", serial, ...args]);
|
||||||
|
}
|
||||||
|
function ad(...args) {
|
||||||
|
return run("agent-device", [...args, "--session", session]);
|
||||||
|
}
|
||||||
|
function pid() {
|
||||||
|
return adb("shell", "pidof", appId).trim();
|
||||||
|
}
|
||||||
|
function open() {
|
||||||
|
ad("open", appId, "--platform", "android", "--serial", serial, "--no-test-ime");
|
||||||
|
}
|
||||||
|
function stateId(name) {
|
||||||
|
const states = adb("shell", "cmd", "device_state", "print-states");
|
||||||
|
const match = states.match(new RegExp(`identifier=(\\d+), name='${name}'`));
|
||||||
|
assert(match, `Emulator must expose the ${name} posture: ${states}`);
|
||||||
|
return match[1];
|
||||||
|
}
|
||||||
|
|
||||||
|
async function expectLayout(posture) {
|
||||||
|
const compact = posture === "CLOSED";
|
||||||
|
const expectedId = compact ? "workspace-tab-switcher-trigger" : "workspace-tabs-scroll";
|
||||||
|
const unexpectedId = compact ? "workspace-tabs-scroll" : "workspace-tab-switcher-trigger";
|
||||||
|
const deadline = Date.now() + 15_000;
|
||||||
|
let nodes = [];
|
||||||
|
do {
|
||||||
|
let data;
|
||||||
|
try {
|
||||||
|
({ data } = JSON.parse(ad("snapshot", "-i", "--json")));
|
||||||
|
} catch (error) {
|
||||||
|
// During display handoff Android briefly has no capturable app window.
|
||||||
|
if (!error.stdout?.includes("insufficient foreground app content")) throw error;
|
||||||
|
await delay(200);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
assert.equal(data.appBundleId, appId, "Snapshot must belong to Paseo");
|
||||||
|
nodes = data.nodes;
|
||||||
|
if (
|
||||||
|
nodes.some((node) => node.identifier === expectedId) &&
|
||||||
|
!nodes.some((node) => node.identifier === unexpectedId)
|
||||||
|
) {
|
||||||
|
writeFileSync(resolve(artifacts, `${posture}.json`), JSON.stringify(data, null, 2));
|
||||||
|
console.log(`PASS: ${posture} uses ${compact ? "compact" : "wide"} workspace controls`);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
await delay(200);
|
||||||
|
} while (Date.now() < deadline);
|
||||||
|
writeFileSync(resolve(artifacts, `${posture}-failure.json`), JSON.stringify(nodes, null, 2));
|
||||||
|
writeFileSync(
|
||||||
|
resolve(artifacts, "native-failure.txt"),
|
||||||
|
adb("shell", "dumpsys", "activity", "top"),
|
||||||
|
);
|
||||||
|
assert.fail(`${posture}: expected ${expectedId}, without ${unexpectedId}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
const closed = stateId("CLOSED");
|
||||||
|
const opened = stateId("OPENED");
|
||||||
|
const initialState = adb("shell", "cmd", "device_state", "state").match(
|
||||||
|
/Committed state: DeviceState\{identifier=(\d+)/,
|
||||||
|
)?.[1];
|
||||||
|
assert(initialState, "Could not read the initial fold state");
|
||||||
|
|
||||||
|
try {
|
||||||
|
adb("shell", "cmd", "device_state", "state", opened);
|
||||||
|
open();
|
||||||
|
await expectLayout("OPENED");
|
||||||
|
const initialPid = pid();
|
||||||
|
for (const [posture, id] of [
|
||||||
|
["CLOSED", closed],
|
||||||
|
["OPENED", opened],
|
||||||
|
]) {
|
||||||
|
adb("shell", "input", "keyevent", "KEYCODE_HOME");
|
||||||
|
adb("shell", "cmd", "device_state", "state", id);
|
||||||
|
// Resume immediately: waiting for configuration delivery hides the regression.
|
||||||
|
open();
|
||||||
|
await expectLayout(posture);
|
||||||
|
assert.equal(pid(), initialPid, "Fold/resume must preserve the app process");
|
||||||
|
}
|
||||||
|
} finally {
|
||||||
|
adb("shell", "cmd", "device_state", "state", initialState);
|
||||||
|
ad("close");
|
||||||
|
}
|
||||||
@@ -38,12 +38,9 @@ async function expectDarkIcons(expected, context) {
|
|||||||
assert.equal(windowState(), expected, context);
|
assert.equal(windowState(), expected, context);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Settings > Appearance shows every theme as a tile in one radio group.
|
||||||
function selectTheme(theme) {
|
function selectTheme(theme) {
|
||||||
const current = ad("snapshot", "-i").match(/"Theme: ([^"]+)"/)?.[1];
|
|
||||||
assert(current, "Start on Settings > Appearance");
|
|
||||||
ad("press", `label="Theme: ${current}"`, "--settle");
|
|
||||||
ad("press", `label="${theme}"`, "--settle");
|
ad("press", `label="${theme}"`, "--settle");
|
||||||
ad("wait", "text", `Theme: ${theme}`, "5000");
|
|
||||||
}
|
}
|
||||||
|
|
||||||
ad("settings", "appearance", "light");
|
ad("settings", "appearance", "light");
|
||||||
|
|||||||
@@ -0,0 +1,314 @@
|
|||||||
|
import assert from "node:assert/strict";
|
||||||
|
import { writeFileSync } from "node:fs";
|
||||||
|
import { UnicodeGraphemesAddon } from "@xterm/addon-unicode-graphemes";
|
||||||
|
import xterm from "@xterm/headless";
|
||||||
|
import { PNG } from "pngjs";
|
||||||
|
import { ACCENT, fixtureLines, fixtureOutput, RULER_CELLS, SELECT_LINE } from "./fixture.mjs";
|
||||||
|
|
||||||
|
/** A pixel is ink when one channel differs from the terminal background by more than this. */
|
||||||
|
const INK_THRESHOLD = 70;
|
||||||
|
/** Ink pixels a printed grapheme cluster needs inside its own columns. */
|
||||||
|
const MIN_CLUSTER_INK = 3;
|
||||||
|
/** How far a pixel may sit from the background-to-color blend line and still count as that color. */
|
||||||
|
const BLEND_TOLERANCE = 40;
|
||||||
|
/** Pixels of another cell's color tolerated in a cell, for antialiasing at the cell edge. */
|
||||||
|
const MAX_FOREIGN_INK = 2;
|
||||||
|
|
||||||
|
const graphemes = new Intl.Segmenter("und", { granularity: "grapheme" });
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Checks a screenshot of the fixture against the cells xterm assigns: every printed grapheme
|
||||||
|
* cluster has ink inside its own columns, blank cells stay blank, and the cursor sits right after
|
||||||
|
* the text. A cluster that spans cells, such as a Devanagari conjunct, is shaped as one unit, so
|
||||||
|
* it is judged across all its columns. On rows that use the fixture's accent color, every cell
|
||||||
|
* must be drawn in its own color, including cells that share a shaped cluster.
|
||||||
|
*
|
||||||
|
* These are geometry and color checks: they cannot tell a correct glyph from a wrong one.
|
||||||
|
*
|
||||||
|
* `rows` maps a terminal row index to its rect in screenshot pixels.
|
||||||
|
*/
|
||||||
|
export async function checkTerminalScreenshot({ png, size, rows }) {
|
||||||
|
const terminal = await fixtureTerminal(size);
|
||||||
|
assert.ok(rows.get(0), "The ruler row is not exposed as terminal-row-0");
|
||||||
|
const grid = measureGrid(png, rows.get(0));
|
||||||
|
const { failures, slots } = checkRows({ png, terminal, rows, grid });
|
||||||
|
terminal.dispose();
|
||||||
|
return { grid, failures, slots };
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Where the harness selects: the first cell of the conjunct that starts the `select` line. */
|
||||||
|
export async function selectionTarget({ size }) {
|
||||||
|
const terminal = await fixtureTerminal(size);
|
||||||
|
const row = lineNames(terminal.buffer.active, terminal.buffer.active.cursorY + 1).indexOf(
|
||||||
|
SELECT_LINE,
|
||||||
|
);
|
||||||
|
terminal.dispose();
|
||||||
|
return { row, col: 0, clusterColumns: 2 };
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Checks a screenshot taken with only the first cell of the `select` conjunct selected: that cell
|
||||||
|
* has the selection background and the conjunct's second, unselected cell keeps its accent color.
|
||||||
|
*/
|
||||||
|
export function checkPartialSelection({ png, rows, grid, target }) {
|
||||||
|
const rect = rows.get(target.row);
|
||||||
|
if (!rect) return [{ row: target.row, kind: "missing-row" }];
|
||||||
|
const cell = (col) => ({
|
||||||
|
left: grid.left + col * grid.cellWidth + 1,
|
||||||
|
right: grid.left + (col + 1) * grid.cellWidth - 1,
|
||||||
|
top: rect.y,
|
||||||
|
bottom: rect.y + rect.height,
|
||||||
|
});
|
||||||
|
const selected = cell(target.col);
|
||||||
|
const unselected = cell(target.col + 1);
|
||||||
|
const selectionBackground = pixelAt(png, selected.left + 1, selected.top + 1);
|
||||||
|
const unselectedBackground = pixelAt(png, unselected.left + 1, unselected.top + 1);
|
||||||
|
if (
|
||||||
|
!differs(selectionBackground, grid.background) ||
|
||||||
|
differs(unselectedBackground, grid.background)
|
||||||
|
) {
|
||||||
|
return [{ row: target.row, col: target.col, kind: "selection-not-set-up" }];
|
||||||
|
}
|
||||||
|
const failures = [];
|
||||||
|
const ownInk = countColor(png, unselected, grid.background, ACCENT);
|
||||||
|
if (ownInk < MIN_CLUSTER_INK) {
|
||||||
|
failures.push({ row: target.row, col: target.col + 1, kind: "unselected-cell-lost-color" });
|
||||||
|
}
|
||||||
|
return failures;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function fixtureTerminal(size) {
|
||||||
|
const terminal = new xterm.Terminal({
|
||||||
|
cols: size.columns,
|
||||||
|
rows: size.rows,
|
||||||
|
allowProposedApi: true,
|
||||||
|
});
|
||||||
|
// The app's buffer uses grapheme widths; the expected cells must too.
|
||||||
|
terminal.loadAddon(new UnicodeGraphemesAddon());
|
||||||
|
await new Promise((done) =>
|
||||||
|
terminal.write(fixtureOutput(size.columns).replaceAll("\n", "\r\n"), done),
|
||||||
|
);
|
||||||
|
return terminal;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function writeOverlay(png, slots, path) {
|
||||||
|
const out = new PNG({ width: png.width, height: png.height });
|
||||||
|
png.data.copy(out.data);
|
||||||
|
for (const slot of slots) {
|
||||||
|
const color = slot.ok ? [0, 200, 0] : [255, 0, 0];
|
||||||
|
const { left, right, top, bottom } = slot.box;
|
||||||
|
for (let x = Math.ceil(left); x < right; x += 1) {
|
||||||
|
for (const y of [Math.ceil(top), Math.floor(bottom) - 1]) {
|
||||||
|
const offset = (out.width * y + x) * 4;
|
||||||
|
out.data.set(color, offset);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (!slot.ok) {
|
||||||
|
for (let y = Math.ceil(top); y < bottom; y += 1) {
|
||||||
|
for (const x of [Math.ceil(left), Math.floor(right) - 1]) {
|
||||||
|
out.data.set(color, (out.width * y + x) * 4);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
writeFileSync(path, PNG.sync.write(out));
|
||||||
|
}
|
||||||
|
|
||||||
|
function inkAt(png, x, y, background) {
|
||||||
|
const offset = (png.width * Math.round(y) + Math.round(x)) * 4;
|
||||||
|
return (
|
||||||
|
Math.abs(png.data[offset] - background[0]) > INK_THRESHOLD ||
|
||||||
|
Math.abs(png.data[offset + 1] - background[1]) > INK_THRESHOLD ||
|
||||||
|
Math.abs(png.data[offset + 2] - background[2]) > INK_THRESHOLD
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Pixels in `box` that differ from `background` in some channel by more than the ink threshold. */
|
||||||
|
export function countInk(png, box, background) {
|
||||||
|
let count = 0;
|
||||||
|
for (let y = Math.ceil(box.top); y < Math.floor(box.bottom); y += 1) {
|
||||||
|
for (let x = Math.ceil(box.left); x < Math.floor(box.right); x += 1) {
|
||||||
|
if (inkAt(png, x, y, background)) count += 1;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return count;
|
||||||
|
}
|
||||||
|
|
||||||
|
function differs(a, b) {
|
||||||
|
return a.some((channel, index) => Math.abs(channel - b[index]) > INK_THRESHOLD);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Distance from `pixel` to the nearest blend of `background` toward `color`. */
|
||||||
|
function blendDistance(pixel, background, color) {
|
||||||
|
const direction = color.map((channel, index) => channel - background[index]);
|
||||||
|
const length = direction.reduce((sum, value) => sum + value * value, 0);
|
||||||
|
const offset = pixel.map((channel, index) => channel - background[index]);
|
||||||
|
const along = offset.reduce((sum, value, index) => sum + value * direction[index], 0);
|
||||||
|
const alpha = length === 0 ? 0 : Math.min(1, Math.max(0, along / length));
|
||||||
|
return Math.hypot(...offset.map((value, index) => value - alpha * direction[index]));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Ink pixels in `box` that are a blend of the background toward `color`. */
|
||||||
|
function countColor(png, box, background, color, other) {
|
||||||
|
let count = 0;
|
||||||
|
for (let y = Math.ceil(box.top); y < Math.floor(box.bottom); y += 1) {
|
||||||
|
for (let x = Math.ceil(box.left); x < Math.floor(box.right); x += 1) {
|
||||||
|
if (!inkAt(png, x, y, background)) continue;
|
||||||
|
const pixel = pixelAt(png, x, y);
|
||||||
|
const distance = blendDistance(pixel, background, color);
|
||||||
|
if (distance > BLEND_TOLERANCE) continue;
|
||||||
|
if (other && blendDistance(pixel, background, other) <= distance) continue;
|
||||||
|
count += 1;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return count;
|
||||||
|
}
|
||||||
|
|
||||||
|
function pixelAt(png, x, y) {
|
||||||
|
const offset = (png.width * Math.round(y) + Math.round(x)) * 4;
|
||||||
|
return [png.data[offset], png.data[offset + 1], png.data[offset + 2]];
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Reads the grid origin and cell width from a ruler row of `RULER_CELLS` full blocks. */
|
||||||
|
export function measureGrid(png, rulerRect) {
|
||||||
|
const y = rulerRect.y + rulerRect.height / 2;
|
||||||
|
const background = pixelAt(png, rulerRect.x + rulerRect.width - 2, y);
|
||||||
|
let left = -1;
|
||||||
|
let right = -1;
|
||||||
|
for (let x = Math.ceil(rulerRect.x); x < rulerRect.x + rulerRect.width; x += 1) {
|
||||||
|
if (!inkAt(png, x, y, background)) continue;
|
||||||
|
if (left < 0) left = x;
|
||||||
|
right = x + 1;
|
||||||
|
}
|
||||||
|
assert.ok(left >= 0, "The ruler row has no ink");
|
||||||
|
const foreground = pixelAt(png, Math.round((left + right) / 2), y);
|
||||||
|
return { left, cellWidth: (right - left) / RULER_CELLS, background, foreground };
|
||||||
|
}
|
||||||
|
|
||||||
|
function lineNames(buffer, count) {
|
||||||
|
const names = fixtureLines(0).map((line) => line.name);
|
||||||
|
const result = [];
|
||||||
|
let index = -1;
|
||||||
|
for (let row = 0; row < count; row += 1) {
|
||||||
|
if (!buffer.getLine(row).isWrapped) index += 1;
|
||||||
|
result.push(names[index] ?? `line-${index}`);
|
||||||
|
}
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** The row's printed cells, consecutive cells of one grapheme cluster grouped together. */
|
||||||
|
function rowClusters(line, columns, cell) {
|
||||||
|
const cells = [];
|
||||||
|
let text = "";
|
||||||
|
for (let col = 0; col < columns; col += 1) {
|
||||||
|
line.getCell(col, cell);
|
||||||
|
const width = cell.getWidth();
|
||||||
|
if (width === 0) continue;
|
||||||
|
const chars = cell.getChars() || " ";
|
||||||
|
cells.push({
|
||||||
|
col,
|
||||||
|
width,
|
||||||
|
chars,
|
||||||
|
offset: text.length,
|
||||||
|
painted: cell.isInverse() || !cell.isBgDefault(),
|
||||||
|
accent: cell.isFgRGB() && cell.getFgColor() === rgbValue(ACCENT),
|
||||||
|
});
|
||||||
|
text += chars;
|
||||||
|
}
|
||||||
|
const clusterEnds = [...graphemes.segment(text)].map(
|
||||||
|
(segment) => segment.index + segment.segment.length,
|
||||||
|
);
|
||||||
|
const clusters = [];
|
||||||
|
let end = 0;
|
||||||
|
for (const entry of cells) {
|
||||||
|
while (entry.offset >= clusterEnds[end]) end += 1;
|
||||||
|
const last = clusters.at(-1);
|
||||||
|
if (last && last.end === end) last.cells.push(entry);
|
||||||
|
else clusters.push({ end, cells: [entry] });
|
||||||
|
}
|
||||||
|
return clusters.map((cluster) => cluster.cells);
|
||||||
|
}
|
||||||
|
|
||||||
|
function rgbValue([red, green, blue]) {
|
||||||
|
return (red << 16) | (green << 8) | blue;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Each cell of a cluster that uses the accent color holds ink of its own color only. */
|
||||||
|
function checkClusterColors({ png, cluster, rect, grid }) {
|
||||||
|
const kinds = [];
|
||||||
|
for (const entry of cluster) {
|
||||||
|
const box = {
|
||||||
|
left: grid.left + entry.col * grid.cellWidth + 1,
|
||||||
|
right: grid.left + (entry.col + entry.width) * grid.cellWidth - 1,
|
||||||
|
top: rect.y,
|
||||||
|
bottom: rect.y + rect.height,
|
||||||
|
};
|
||||||
|
const [color, other] = entry.accent ? [ACCENT, grid.foreground] : [grid.foreground, ACCENT];
|
||||||
|
const own = countColor(png, box, grid.background, color, other);
|
||||||
|
const foreign = countColor(png, box, grid.background, other, color);
|
||||||
|
if (own < MIN_CLUSTER_INK || foreign > MAX_FOREIGN_INK) {
|
||||||
|
kinds.push({ col: entry.col, kind: entry.accent ? "accent-color-lost" : "color-leaked" });
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return kinds;
|
||||||
|
}
|
||||||
|
|
||||||
|
function checkRows({ png, terminal, rows, grid }) {
|
||||||
|
const buffer = terminal.buffer.active;
|
||||||
|
const lastRow = buffer.cursorY;
|
||||||
|
const names = lineNames(buffer, lastRow + 1);
|
||||||
|
const failures = [];
|
||||||
|
const slots = [];
|
||||||
|
const cell = buffer.getNullCell();
|
||||||
|
for (let row = 0; row <= lastRow; row += 1) {
|
||||||
|
const rect = rows.get(row);
|
||||||
|
if (!rect) {
|
||||||
|
failures.push({ row, line: names[row], kind: "missing-row" });
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
const clusters = rowClusters(buffer.getLine(row), terminal.cols, cell);
|
||||||
|
// Color is judged on whole rows that use the accent, so a color leaking into a neighbouring
|
||||||
|
// default-colored cell fails too.
|
||||||
|
const checksColor = clusters.some((cluster) => cluster.some((entry) => entry.accent));
|
||||||
|
for (const cluster of clusters) {
|
||||||
|
const first = cluster[0];
|
||||||
|
const columns = cluster.reduce((sum, entry) => sum + entry.width, 0);
|
||||||
|
const left = grid.left + first.col * grid.cellWidth;
|
||||||
|
const right = left + columns * grid.cellWidth;
|
||||||
|
const box = { left: left + 1, right: right - 1, top: rect.y, bottom: rect.y + rect.height };
|
||||||
|
const chars = cluster.map((entry) => entry.chars).join("");
|
||||||
|
const isCursor = row === lastRow && first.col === buffer.cursorX;
|
||||||
|
let kind = null;
|
||||||
|
if (isCursor) {
|
||||||
|
const covered = countInk(png, box, grid.background);
|
||||||
|
const area = (box.right - box.left) * (box.bottom - box.top);
|
||||||
|
if (covered < area * 0.25) kind = "cursor-not-drawn";
|
||||||
|
} else if (chars.trim() !== "") {
|
||||||
|
if (countInk(png, box, grid.background) < MIN_CLUSTER_INK) kind = "missing-ink";
|
||||||
|
} else if (!cluster.some((entry) => entry.painted)) {
|
||||||
|
const quarter = (right - left) / 4;
|
||||||
|
const center = { ...box, left: left + quarter, right: right - quarter };
|
||||||
|
if (countInk(png, center, grid.background) > 0) kind = "ink-in-blank";
|
||||||
|
}
|
||||||
|
const colorFailures =
|
||||||
|
kind === null && checksColor && chars.trim() !== ""
|
||||||
|
? checkClusterColors({ png, cluster, rect, grid })
|
||||||
|
: [];
|
||||||
|
slots.push({
|
||||||
|
row,
|
||||||
|
line: names[row],
|
||||||
|
col: first.col,
|
||||||
|
width: columns,
|
||||||
|
chars,
|
||||||
|
isCursor,
|
||||||
|
box,
|
||||||
|
ok: kind === null && colorFailures.length === 0,
|
||||||
|
});
|
||||||
|
if (kind) failures.push({ row, line: names[row], col: first.col, char: chars, kind });
|
||||||
|
for (const failure of colorFailures) {
|
||||||
|
failures.push({ row, line: names[row], char: chars, ...failure });
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return { failures, slots };
|
||||||
|
}
|
||||||
@@ -0,0 +1,59 @@
|
|||||||
|
// Terminal output covering the scripts and styles the native renderer must place on the grid.
|
||||||
|
// Each entry is one line of output; `ruler` is drawn with full blocks so the harness can read
|
||||||
|
// the grid origin and cell width from pixels, independent of the renderer under test.
|
||||||
|
|
||||||
|
const ESC = "\u001b";
|
||||||
|
const sgr = (codes, text) => `${ESC}[${codes}m${text}${ESC}[0m`;
|
||||||
|
|
||||||
|
export const RULER_CELLS = 20;
|
||||||
|
/** A foreground no theme uses, so its pixels can be told apart from default text. */
|
||||||
|
export const ACCENT = [255, 64, 160];
|
||||||
|
const accent = (text) => sgr(`38;2;${ACCENT.join(";")}`, text);
|
||||||
|
/**
|
||||||
|
* The `select` line starts with a conjunct whose first cell the harness selects on its own. Its
|
||||||
|
* second cell uses the accent, which no theme's selection foreground matches.
|
||||||
|
*/
|
||||||
|
export const SELECT_LINE = "select";
|
||||||
|
|
||||||
|
export function fixtureLines(columns) {
|
||||||
|
const wrapSyllables = Math.ceil(columns / 2) + 6;
|
||||||
|
return [
|
||||||
|
{ name: "ruler", text: "█".repeat(RULER_CELLS) },
|
||||||
|
{ name: "ascii", text: "ASCII abcdefghij 0123456789 end" },
|
||||||
|
{ name: "hangul-mixed", text: "한글 문장 Hello end" },
|
||||||
|
{ name: "hangul-color-boundary", text: `안녕하세요${sgr(31, "NEXT")} end` },
|
||||||
|
{ name: "hangul-bold-boundary", text: `${sgr(1, "안녕하세요")}NEXT end` },
|
||||||
|
{ name: "hangul-decomposed", text: "한글 end" },
|
||||||
|
{ name: "cjk", text: "日本語テキスト 中文字符 end" },
|
||||||
|
{ name: "combining", text: "é ä ñ x̣̂ end" },
|
||||||
|
{ name: "arabic", text: "مرحبا لا 123 abc end" },
|
||||||
|
{ name: "devanagari", text: "नमस्ते क्षत्रिय end" },
|
||||||
|
{ name: "emoji", text: "👍 ❤️ 👋🏽 👩💻 🇰🇷 end" },
|
||||||
|
// One shaped cluster over two cells, colored per cell: the color must follow the cell.
|
||||||
|
{ name: "split-color", text: `क्${accent("ष")} ${accent("क्")}ष ल${accent("ا")} end` },
|
||||||
|
{ name: SELECT_LINE, text: `क्${accent("ष")} end` },
|
||||||
|
{ name: "box", text: "╭──┬──╮ │ab│cd│ ╰──┴──╯ ▀▄▌▐░▒▓ end" },
|
||||||
|
{
|
||||||
|
name: "styles",
|
||||||
|
text: [
|
||||||
|
sgr(1, "bold"),
|
||||||
|
sgr(3, "italic"),
|
||||||
|
sgr(4, "under"),
|
||||||
|
sgr(7, "inverse"),
|
||||||
|
sgr(42, "bg"),
|
||||||
|
sgr(9, "strike"),
|
||||||
|
"end",
|
||||||
|
].join(" "),
|
||||||
|
},
|
||||||
|
{ name: "hangul-wrap", text: "가".repeat(wrapSyllables) },
|
||||||
|
// The last line has no newline: the shell sleeps with the cursor right after it.
|
||||||
|
{ name: "cursor", text: "> 안녕하세요" },
|
||||||
|
];
|
||||||
|
}
|
||||||
|
|
||||||
|
/** The bytes `cat` writes; the tty turns each newline into CR LF. */
|
||||||
|
export function fixtureOutput(columns) {
|
||||||
|
return fixtureLines(columns)
|
||||||
|
.map((line) => line.text)
|
||||||
|
.join("\n");
|
||||||
|
}
|
||||||
@@ -0,0 +1,423 @@
|
|||||||
|
import { execFileSync } from "node:child_process";
|
||||||
|
import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
|
||||||
|
import { tmpdir } from "node:os";
|
||||||
|
import { resolve } from "node:path";
|
||||||
|
import { PNG } from "pngjs";
|
||||||
|
import { checkTerminalScreenshot } from "./check.mjs";
|
||||||
|
|
||||||
|
// Checks that every printed cluster of a `render.mjs` run is the right glyph. `check.mjs` proves
|
||||||
|
// where ink lands and what color it has; this compares each cluster's ink with pango's (HarfBuzz)
|
||||||
|
// rendering of the same characters in the device's own fonts, so a wrong glyph, tofu, a solid
|
||||||
|
// block, a split conjunct or a cluster from elsewhere fails.
|
||||||
|
//
|
||||||
|
// FONTCONFIG_FILE=<fonts.conf> node e2e/mobile/terminal-rendering/identity.mjs <run dir> [control]
|
||||||
|
//
|
||||||
|
// The fonts.conf lists the device's font files and prefers, for `monospace`, the terminal font
|
||||||
|
// followed by the device's fallbacks; `docs/terminal-rendering.md` says how to build one. Needs
|
||||||
|
// `pango-view` on the PATH.
|
||||||
|
//
|
||||||
|
// control:
|
||||||
|
// none judge the screenshot (default); exits 1 when a cluster fails.
|
||||||
|
// rect first fill every judged cluster's box with white; exits 1 unless every cluster fails.
|
||||||
|
// swap judge each cluster against a different cluster of the corpus; exits 1 unless every
|
||||||
|
// cluster fails.
|
||||||
|
// The two controls prove the oracle refuses ink that is present but wrong.
|
||||||
|
|
||||||
|
/** Coverage grid side used to compare shapes. */
|
||||||
|
const GRID = 16;
|
||||||
|
/** A pixel at or above this ink strength (0..1) is part of a glyph's bounding box. */
|
||||||
|
const INK = 0.25;
|
||||||
|
/** Lowest shape correlation a cluster may have with its own reference. */
|
||||||
|
const THRESHOLD = 0.6;
|
||||||
|
/** How much better another cluster may match before the cluster's own match stops counting. */
|
||||||
|
const MARGIN = 0.02;
|
||||||
|
/** Lines whose cells carry decorations or a custom-drawn ruler; they stay geometry-only. */
|
||||||
|
const SKIPPED_LINES = new Set(["ruler", "styles"]);
|
||||||
|
const ZWJ = "";
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The renderer draws box and block characters to fill the cell, so they are judged against their
|
||||||
|
* Unicode definition. Shades come from the font, whose fallback differs between the device and
|
||||||
|
* pango, so a shade is judged by how evenly and densely it inks its own bounding box. Fonts dither
|
||||||
|
* differently: ░ ▒ ▓ measure 0.16, 0.31, 0.75 in Droid Sans Mono and 0.19, 0.50, 0.81 in Menlo. The
|
||||||
|
* bands split between those, and do not overlap, so one shade never passes as another.
|
||||||
|
*/
|
||||||
|
const CELL_GLYPHS = {
|
||||||
|
"─": { arms: "LR" },
|
||||||
|
"│": { arms: "UD" },
|
||||||
|
"┬": { arms: "LRD" },
|
||||||
|
"┴": { arms: "LRU" },
|
||||||
|
"╭": { arms: "DR" },
|
||||||
|
"╮": { arms: "DL" },
|
||||||
|
"╰": { arms: "UR" },
|
||||||
|
"╯": { arms: "UL" },
|
||||||
|
"▀": { fill: "top" },
|
||||||
|
"▄": { fill: "bottom" },
|
||||||
|
"▌": { fill: "left" },
|
||||||
|
"▐": { fill: "right" },
|
||||||
|
"░": { shade: [0.08, 0.25] },
|
||||||
|
"▒": { shade: [0.25, 0.625] },
|
||||||
|
"▓": { shade: [0.625, 0.9] },
|
||||||
|
};
|
||||||
|
/** A shade must ink each region of this grid over its bounding box within its band. */
|
||||||
|
const SHADE_GRID = 4;
|
||||||
|
/** Regions of the cell, as fractions [left, top, right, bottom], that a line to each edge crosses. */
|
||||||
|
const ARM_REGIONS = {
|
||||||
|
U: [0.3, 0, 0.7, 0.2],
|
||||||
|
D: [0.3, 0.8, 0.7, 1],
|
||||||
|
L: [0, 0.3, 0.2, 0.7],
|
||||||
|
R: [0.8, 0.3, 1, 0.7],
|
||||||
|
};
|
||||||
|
/** [filled, empty] halves of each half block. */
|
||||||
|
const HALVES = {
|
||||||
|
top: [
|
||||||
|
[0, 0, 1, 0.5],
|
||||||
|
[0, 0.5, 1, 1],
|
||||||
|
],
|
||||||
|
bottom: [
|
||||||
|
[0, 0.5, 1, 1],
|
||||||
|
[0, 0, 1, 0.5],
|
||||||
|
],
|
||||||
|
left: [
|
||||||
|
[0, 0, 0.5, 1],
|
||||||
|
[0.5, 0, 1, 1],
|
||||||
|
],
|
||||||
|
right: [
|
||||||
|
[0.5, 0, 1, 1],
|
||||||
|
[0, 0, 0.5, 1],
|
||||||
|
],
|
||||||
|
};
|
||||||
|
|
||||||
|
const [dirArg, control = "none"] = process.argv.slice(2);
|
||||||
|
if (!dirArg || !["none", "rect", "swap"].includes(control)) {
|
||||||
|
throw new Error("Usage: identity.mjs <run dir> [none|rect|swap]");
|
||||||
|
}
|
||||||
|
const dir = resolve(dirArg);
|
||||||
|
const report = JSON.parse(readFileSync(resolve(dir, "report.json"), "utf8"));
|
||||||
|
const png = PNG.sync.read(readFileSync(resolve(dir, "terminal.png")));
|
||||||
|
const rows = new Map(report.rows.map((row) => [row.index, row.rect]));
|
||||||
|
const { grid, slots } = await checkTerminalScreenshot({ png, size: report.size, rows });
|
||||||
|
|
||||||
|
const printed = slots.filter(
|
||||||
|
(slot) => !SKIPPED_LINES.has(slot.line) && !slot.isCursor && slot.chars.trim() !== "",
|
||||||
|
);
|
||||||
|
/** The columns xterm gives each printed cluster. */
|
||||||
|
const columnsOf = new Map(printed.map((slot) => [slot.chars, slot.width]));
|
||||||
|
|
||||||
|
if (control === "rect") {
|
||||||
|
for (const { box } of printed) {
|
||||||
|
for (let y = Math.ceil(box.top); y < Math.floor(box.bottom); y += 1) {
|
||||||
|
for (let x = Math.ceil(box.left); x < Math.floor(box.right); x += 1) {
|
||||||
|
png.data.set([255, 255, 255, 255], (png.width * y + x) * 4);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Ink strength 0..1 of each pixel in a box: the largest channel distance from the background. */
|
||||||
|
function screenshotInk(box) {
|
||||||
|
const left = Math.ceil(box.left);
|
||||||
|
const top = Math.ceil(box.top);
|
||||||
|
const width = Math.floor(box.right) - left;
|
||||||
|
const height = Math.floor(box.bottom) - top;
|
||||||
|
const ink = new Float32Array(width * height);
|
||||||
|
for (let y = 0; y < height; y += 1) {
|
||||||
|
for (let x = 0; x < width; x += 1) {
|
||||||
|
const offset = (png.width * (top + y) + left + x) * 4;
|
||||||
|
let distance = 0;
|
||||||
|
for (let channel = 0; channel < 3; channel += 1) {
|
||||||
|
distance = Math.max(
|
||||||
|
distance,
|
||||||
|
Math.abs(png.data[offset + channel] - grid.background[channel]),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
ink[y * width + x] = distance / 255;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return { ink, width, height };
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Ink of the slot's whole cells, scaled so the foreground color is 1. */
|
||||||
|
function cellInk(slot) {
|
||||||
|
const left = Math.round(grid.left + slot.col * grid.cellWidth);
|
||||||
|
const right = Math.round(grid.left + (slot.col + slot.width) * grid.cellWidth);
|
||||||
|
const cells = screenshotInk({ left, right, top: slot.box.top, bottom: slot.box.bottom });
|
||||||
|
const full =
|
||||||
|
Math.max(...[0, 1, 2].map((c) => Math.abs(grid.foreground[c] - grid.background[c]))) / 255;
|
||||||
|
for (let i = 0; i < cells.ink.length; i += 1) cells.ink[i] = Math.min(1, cells.ink[i] / full);
|
||||||
|
return cells;
|
||||||
|
}
|
||||||
|
|
||||||
|
const scratch = mkdtempSync(resolve(tmpdir(), "terminal-identity-"));
|
||||||
|
/** pango-view sizes its image to the text's advance plus this margin on each side. */
|
||||||
|
const REFERENCE_MARGIN = 48;
|
||||||
|
function pangoInk(text) {
|
||||||
|
const out = resolve(scratch, "reference.png");
|
||||||
|
execFileSync("pango-view", [
|
||||||
|
"--no-display",
|
||||||
|
"--dpi=72",
|
||||||
|
"--font=monospace 96px",
|
||||||
|
`--text=${text}`,
|
||||||
|
"--background=black",
|
||||||
|
"--foreground=white",
|
||||||
|
`--margin=${REFERENCE_MARGIN}`,
|
||||||
|
"-o",
|
||||||
|
out,
|
||||||
|
]);
|
||||||
|
const image = PNG.sync.read(readFileSync(out));
|
||||||
|
const ink = new Float32Array(image.width * image.height);
|
||||||
|
for (let i = 0; i < ink.length; i += 1) {
|
||||||
|
const o = i * 4;
|
||||||
|
ink[i] = Math.max(image.data[o], image.data[o + 1], image.data[o + 2]) / 255;
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
ink,
|
||||||
|
width: image.width,
|
||||||
|
height: image.height,
|
||||||
|
advance: image.width - 2 * REFERENCE_MARGIN,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/** The terminal font's cell advance at the reference size. */
|
||||||
|
const referenceCell = pangoInk("M").advance;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The text as the renderer places it in `columns` cells: centred, scaled down when its advance is
|
||||||
|
* wider, and cut at the cells' edges. Glyphs whose ink overhangs their advance, such as Devanagari
|
||||||
|
* headlines, are cut on the device too.
|
||||||
|
*/
|
||||||
|
function referenceInk(text, columns) {
|
||||||
|
const image = pangoInk(text);
|
||||||
|
const box = Math.max(image.advance, columns * referenceCell);
|
||||||
|
const left = Math.round(REFERENCE_MARGIN + (image.advance - box) / 2);
|
||||||
|
const right = Math.round(REFERENCE_MARGIN + (image.advance + box) / 2);
|
||||||
|
for (let y = 0; y < image.height; y += 1) {
|
||||||
|
for (let x = 0; x < image.width; x += 1) {
|
||||||
|
if (x < left || x >= right) image.ink[y * image.width + x] = 0;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return image;
|
||||||
|
}
|
||||||
|
|
||||||
|
function regionInk({ ink, width, height }, [x0, y0, x1, y1]) {
|
||||||
|
let [sum, max, count] = [0, 0, 0];
|
||||||
|
for (let y = Math.floor(y0 * height); y < Math.ceil(y1 * height); y += 1) {
|
||||||
|
for (let x = Math.floor(x0 * width); x < Math.ceil(x1 * width); x += 1) {
|
||||||
|
const value = ink[y * width + x] ?? 0;
|
||||||
|
sum += value;
|
||||||
|
max = Math.max(max, value);
|
||||||
|
count += 1;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return { mean: sum / count, max };
|
||||||
|
}
|
||||||
|
|
||||||
|
function inkBox({ ink, width, height }) {
|
||||||
|
let [minX, minY, maxX, maxY] = [width, height, -1, -1];
|
||||||
|
for (let y = 0; y < height; y += 1) {
|
||||||
|
for (let x = 0; x < width; x += 1) {
|
||||||
|
if (ink[y * width + x] < INK) continue;
|
||||||
|
minX = Math.min(minX, x);
|
||||||
|
maxX = Math.max(maxX, x);
|
||||||
|
minY = Math.min(minY, y);
|
||||||
|
maxY = Math.max(maxY, y);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return maxX < 0 ? null : { x: minX, y: minY, width: maxX - minX + 1, height: maxY - minY + 1 };
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Whether an unbroken line crosses the region to the cell edge: a row for L/R, a column for U/D. */
|
||||||
|
function lineCrosses({ ink, width, height }, arm) {
|
||||||
|
const [x0, y0, x1, y1] = ARM_REGIONS[arm];
|
||||||
|
const [left, top, right, bottom] = [
|
||||||
|
Math.floor(x0 * width),
|
||||||
|
Math.floor(y0 * height),
|
||||||
|
Math.ceil(x1 * width),
|
||||||
|
Math.ceil(y1 * height),
|
||||||
|
];
|
||||||
|
const horizontal = arm === "L" || arm === "R";
|
||||||
|
const [outerFrom, outerTo, innerFrom, innerTo] = horizontal
|
||||||
|
? [top, bottom, left, right]
|
||||||
|
: [left, right, top, bottom];
|
||||||
|
for (let outer = outerFrom; outer < outerTo; outer += 1) {
|
||||||
|
let unbroken = true;
|
||||||
|
for (let inner = innerFrom; inner < innerTo && unbroken; inner += 1) {
|
||||||
|
const [x, y] = horizontal ? [inner, outer] : [outer, inner];
|
||||||
|
unbroken = (ink[y * width + x] ?? 0) >= 0.5;
|
||||||
|
}
|
||||||
|
if (unbroken) return true;
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** 1 when the cell matches the character's definition, 0 otherwise. */
|
||||||
|
function cellGlyphScore(slot, spec) {
|
||||||
|
const ink = cellInk(slot);
|
||||||
|
if (spec.arms) {
|
||||||
|
const matches = Object.keys(ARM_REGIONS).every((arm) =>
|
||||||
|
spec.arms.includes(arm) ? lineCrosses(ink, arm) : regionInk(ink, ARM_REGIONS[arm]).max < 0.3,
|
||||||
|
);
|
||||||
|
return matches ? 1 : 0;
|
||||||
|
}
|
||||||
|
if (spec.fill) {
|
||||||
|
const [filled, empty] = HALVES[spec.fill].map((region) => regionInk(ink, region).mean);
|
||||||
|
return filled >= 0.8 && empty <= 0.2 ? 1 : 0;
|
||||||
|
}
|
||||||
|
const box = inkBox(ink);
|
||||||
|
if (!box || box.width < 0.7 * ink.width || box.height < 0.5 * ink.height) return 0;
|
||||||
|
const [x0, y0] = [box.x / ink.width, box.y / ink.height];
|
||||||
|
const [x1, y1] = [(box.x + box.width) / ink.width, (box.y + box.height) / ink.height];
|
||||||
|
const [w, h] = [(x1 - x0) / SHADE_GRID, (y1 - y0) / SHADE_GRID];
|
||||||
|
const regions = Array.from({ length: SHADE_GRID * SHADE_GRID }, (_, index) => {
|
||||||
|
const [gx, gy] = [index % SHADE_GRID, Math.floor(index / SHADE_GRID)];
|
||||||
|
return [x0 + gx * w, y0 + gy * h, x0 + (gx + 1) * w, y0 + (gy + 1) * h];
|
||||||
|
});
|
||||||
|
const means = regions.map((region) => regionInk(ink, region).mean);
|
||||||
|
return means.every((mean) => mean >= spec.shade[0] && mean < spec.shade[1]) ? 1 : 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Coverage of the ink's bounding box, centered in a square that keeps its aspect, at GRID². */
|
||||||
|
function coverage(image) {
|
||||||
|
const box = inkBox(image);
|
||||||
|
if (!box) return null;
|
||||||
|
const side = Math.max(box.width, box.height);
|
||||||
|
const originX = box.x - (side - box.width) / 2;
|
||||||
|
const originY = box.y - (side - box.height) / 2;
|
||||||
|
const vector = new Float32Array(GRID * GRID);
|
||||||
|
const step = side / GRID;
|
||||||
|
const samples = 4;
|
||||||
|
for (let gy = 0; gy < GRID; gy += 1) {
|
||||||
|
for (let gx = 0; gx < GRID; gx += 1) {
|
||||||
|
let sum = 0;
|
||||||
|
for (let sample = 0; sample < samples * samples; sample += 1) {
|
||||||
|
const x = Math.floor(originX + (gx + ((sample % samples) + 0.5) / samples) * step);
|
||||||
|
const y = Math.floor(
|
||||||
|
originY + (gy + (Math.floor(sample / samples) + 0.5) / samples) * step,
|
||||||
|
);
|
||||||
|
sum +=
|
||||||
|
x >= 0 && y >= 0 && x < image.width && y < image.height
|
||||||
|
? image.ink[y * image.width + x]
|
||||||
|
: 0;
|
||||||
|
}
|
||||||
|
vector[gy * GRID + gx] = sum / (samples * samples);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return vector;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Pearson correlation of two coverage vectors; -1 when either has no ink or no contrast. */
|
||||||
|
function correlation(a, b) {
|
||||||
|
if (!a || !b) return -1;
|
||||||
|
const n = a.length;
|
||||||
|
let [ma, mb] = [0, 0];
|
||||||
|
for (let i = 0; i < n; i += 1) {
|
||||||
|
ma += a[i];
|
||||||
|
mb += b[i];
|
||||||
|
}
|
||||||
|
ma /= n;
|
||||||
|
mb /= n;
|
||||||
|
let [num, da, db] = [0, 0, 0];
|
||||||
|
for (let i = 0; i < n; i += 1) {
|
||||||
|
num += (a[i] - ma) * (b[i] - mb);
|
||||||
|
da += (a[i] - ma) ** 2;
|
||||||
|
db += (b[i] - mb) ** 2;
|
||||||
|
}
|
||||||
|
return da === 0 || db === 0 ? -1 : num / Math.sqrt(da * db);
|
||||||
|
}
|
||||||
|
|
||||||
|
const references = new Map();
|
||||||
|
/**
|
||||||
|
* The cluster alone and with a zero-width joiner before, after and on both sides, so any Arabic
|
||||||
|
* positional form of the right letter matches.
|
||||||
|
*/
|
||||||
|
function referenceVectors(chars) {
|
||||||
|
if (!references.has(chars)) {
|
||||||
|
const forms = [chars, ZWJ + chars, chars + ZWJ, ZWJ + chars + ZWJ];
|
||||||
|
references.set(
|
||||||
|
chars,
|
||||||
|
forms.map((text) => coverage(referenceInk(text, columnsOf.get(chars)))),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return references.get(chars);
|
||||||
|
}
|
||||||
|
|
||||||
|
function shapeScore(vector, chars) {
|
||||||
|
return Math.max(...referenceVectors(chars).map((reference) => correlation(vector, reference)));
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* pango draws no ink for Apple Color Emoji, and draws flags on neither device. Those clusters have
|
||||||
|
* no reference and are reported instead of judged.
|
||||||
|
*/
|
||||||
|
const hasReference = (chars) =>
|
||||||
|
CELL_GLYPHS[chars] ||
|
||||||
|
(!/^\p{Regional_Indicator}{2}$/u.test(chars) && referenceVectors(chars).some(Boolean));
|
||||||
|
const judged = printed.filter((slot) => hasReference(slot.chars));
|
||||||
|
const unjudged = printed
|
||||||
|
.filter((slot) => !hasReference(slot.chars))
|
||||||
|
.map((slot) => ({
|
||||||
|
line: slot.line,
|
||||||
|
col: slot.col,
|
||||||
|
chars: slot.chars,
|
||||||
|
reason: "no reference ink",
|
||||||
|
}));
|
||||||
|
|
||||||
|
const distinct = [...new Set(judged.map((slot) => slot.chars))];
|
||||||
|
const shapes = distinct.filter((chars) => !CELL_GLYPHS[chars]);
|
||||||
|
|
||||||
|
/** The cluster a slot is judged against: its own, or under `swap` a different one. */
|
||||||
|
function expectedChars(slot, index) {
|
||||||
|
if (control !== "swap") return slot.chars;
|
||||||
|
const own = distinct.indexOf(slot.chars);
|
||||||
|
const other = distinct[(own + 1 + (index % (distinct.length - 1))) % distinct.length];
|
||||||
|
return other === slot.chars ? distinct[(own + 1) % distinct.length] : other;
|
||||||
|
}
|
||||||
|
|
||||||
|
function judge(slot, index) {
|
||||||
|
const expected = expectedChars(slot, index);
|
||||||
|
const result = { line: slot.line, row: slot.row, col: slot.col, chars: slot.chars, expected };
|
||||||
|
const spec = CELL_GLYPHS[expected];
|
||||||
|
if (spec) {
|
||||||
|
result.score = cellGlyphScore(slot, spec);
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
// The shape must also resemble its own cluster at least as much as any other cluster in the
|
||||||
|
// corpus, within MARGIN, so a near-lookalike such as g judged as 8 fails.
|
||||||
|
const vector = coverage(screenshotInk(slot.box));
|
||||||
|
const score = shapeScore(vector, expected);
|
||||||
|
let nearest = { chars: expected, score };
|
||||||
|
for (const other of shapes) {
|
||||||
|
if (other === expected) continue;
|
||||||
|
const otherScore = shapeScore(vector, other);
|
||||||
|
if (otherScore > nearest.score) nearest = { chars: other, score: otherScore };
|
||||||
|
}
|
||||||
|
const distinctive = nearest.chars === expected || nearest.score - score <= MARGIN;
|
||||||
|
result.score = distinctive ? score : Math.min(score, 0);
|
||||||
|
result.nearest = nearest;
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
const results = judged.map(judge);
|
||||||
|
rmSync(scratch, { recursive: true, force: true });
|
||||||
|
|
||||||
|
const passed = results.filter((result) => result.score >= THRESHOLD);
|
||||||
|
const failed = results.filter((result) => result.score < THRESHOLD);
|
||||||
|
const outDir = resolve(dir, "identity");
|
||||||
|
mkdirSync(outDir, { recursive: true });
|
||||||
|
writeFileSync(
|
||||||
|
resolve(outDir, `${control}.json`),
|
||||||
|
`${JSON.stringify({ control, threshold: THRESHOLD, unjudged, results }, null, 2)}\n`,
|
||||||
|
);
|
||||||
|
|
||||||
|
const format = (result) =>
|
||||||
|
`${result.line}@${result.col}(${result.chars}${result.expected === result.chars ? "" : `→${result.expected}`})=${result.score.toFixed(2)}${result.nearest && result.nearest.chars !== result.expected ? ` nearest ${result.nearest.chars}` : ""}`;
|
||||||
|
console.log(
|
||||||
|
`${report.label} ${control}: ${results.length} clusters judged, ${passed.length} pass, ${failed.length} fail, ${unjudged.length} unjudged (${outDir})`,
|
||||||
|
);
|
||||||
|
if (control === "none") {
|
||||||
|
for (const result of failed) console.log(` fail ${format(result)}`);
|
||||||
|
process.exitCode = failed.length === 0 ? 0 : 1;
|
||||||
|
} else {
|
||||||
|
for (const result of passed) console.log(` accepted ${format(result)}`);
|
||||||
|
process.exitCode = passed.length === 0 ? 0 : 1;
|
||||||
|
}
|
||||||
@@ -0,0 +1,236 @@
|
|||||||
|
import assert from "node:assert/strict";
|
||||||
|
import { execFileSync } from "node:child_process";
|
||||||
|
import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
|
||||||
|
import { homedir, tmpdir } from "node:os";
|
||||||
|
import { resolve } from "node:path";
|
||||||
|
import { setTimeout } from "node:timers/promises";
|
||||||
|
import { PNG } from "pngjs";
|
||||||
|
import { countInk, measureGrid } from "./check.mjs";
|
||||||
|
import { RULER_CELLS } from "./fixture.mjs";
|
||||||
|
|
||||||
|
// Checks ink that leaves its row: stacked marks above and below a row reach into the rows next to
|
||||||
|
// it. The script prints such rows, then in one update writes into two rows that hold another row's
|
||||||
|
// overhang and erases two rows whose overhang reaches a blank row. The overhang must be drawn
|
||||||
|
// before the update, stay drawn in the written rows, and leave no ink behind the erased rows.
|
||||||
|
//
|
||||||
|
// Preconditions are the same as `render.mjs`: the app runs the build being verified against a
|
||||||
|
// daemon on the same host as this script, and shows an idle, focused terminal with an empty prompt.
|
||||||
|
//
|
||||||
|
// PLATFORM=android ANDROID_SERIAL=emulator-5554 node e2e/mobile/terminal-rendering/overhang.mjs
|
||||||
|
// PLATFORM=ios IOS_DEVICE="iPhone 17" node e2e/mobile/terminal-rendering/overhang.mjs
|
||||||
|
const platform = process.env.PLATFORM ?? "android";
|
||||||
|
const appId = process.env.PASEO_TERMINAL_RENDERING_APP_ID ?? "sh.paseo.debug";
|
||||||
|
const label = process.env.PASEO_TERMINAL_RENDERING_LABEL ?? "overhang";
|
||||||
|
const session = process.env.AGENT_DEVICE_SESSION ?? `terminal-rendering-${platform}`;
|
||||||
|
const artifacts = resolve(
|
||||||
|
process.env.PASEO_TERMINAL_RENDERING_ARTIFACTS ??
|
||||||
|
resolve(homedir(), ".paseo/artifacts/terminal-rendering", platform),
|
||||||
|
label,
|
||||||
|
);
|
||||||
|
const fixtureDir = process.env.PASEO_TERMINAL_RENDERING_FIXTURE_DIR ?? tmpdir();
|
||||||
|
const screenshotArgs =
|
||||||
|
platform === "ios"
|
||||||
|
? ["--pixel-density", process.env.PASEO_TERMINAL_RENDERING_PIXEL_DENSITY ?? "3"]
|
||||||
|
: [];
|
||||||
|
const env = {
|
||||||
|
...process.env,
|
||||||
|
AGENT_DEVICE_STATE_DIR:
|
||||||
|
process.env.AGENT_DEVICE_STATE_DIR ??
|
||||||
|
resolve(homedir(), ".paseo/artifacts/terminal-rendering/device-state"),
|
||||||
|
};
|
||||||
|
mkdirSync(artifacts, { recursive: true });
|
||||||
|
|
||||||
|
/** Marks stacked below the row: Arabic dots, rings below `g`, a vowel sign below a consonant. */
|
||||||
|
const BELOW = "پپپ ييي ججج g̥̥̥̥ कृ";
|
||||||
|
/** Marks stacked above the row: accents over `e` and `s`, candrabindu, om. */
|
||||||
|
const ABOVE = "é́́́ ŝ̂̂ कँ ॐ";
|
||||||
|
/** The marks rows stay left of this column; the update writes at it, outside the checked boxes. */
|
||||||
|
const CHECKED_COLUMNS = 26;
|
||||||
|
const WRITE_COLUMN = 30;
|
||||||
|
/** 0-based rows. Each source row's overhang reaches the row next to it. */
|
||||||
|
const SOURCES = [
|
||||||
|
{ row: 2, text: BELOW, overhangRow: 3, update: "write" },
|
||||||
|
{ row: 6, text: ABOVE, overhangRow: 5, update: "erase" },
|
||||||
|
{ row: 9, text: BELOW, overhangRow: 10, update: "erase" },
|
||||||
|
{ row: 13, text: ABOVE, overhangRow: 12, update: "write" },
|
||||||
|
];
|
||||||
|
const PARK_ROW = 16;
|
||||||
|
|
||||||
|
function ad(...args) {
|
||||||
|
return execFileSync("agent-device", [...args, "--session", session], {
|
||||||
|
env,
|
||||||
|
encoding: "utf8",
|
||||||
|
timeout: 60_000,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function deviceArgs() {
|
||||||
|
if (platform === "android") {
|
||||||
|
return [
|
||||||
|
"--platform",
|
||||||
|
"android",
|
||||||
|
...(process.env.ANDROID_SERIAL ? ["--serial", process.env.ANDROID_SERIAL] : []),
|
||||||
|
];
|
||||||
|
}
|
||||||
|
return [
|
||||||
|
"--platform",
|
||||||
|
"ios",
|
||||||
|
...(process.env.IOS_DEVICE ? ["--device", process.env.IOS_DEVICE] : []),
|
||||||
|
];
|
||||||
|
}
|
||||||
|
|
||||||
|
function snapshotNodes() {
|
||||||
|
return JSON.parse(ad("snapshot", "--json")).data.nodes;
|
||||||
|
}
|
||||||
|
|
||||||
|
function pressControl(id) {
|
||||||
|
const node = JSON.parse(ad("snapshot", "-i", "--json")).data.nodes.find(
|
||||||
|
(candidate) => candidate.identifier === id,
|
||||||
|
);
|
||||||
|
assert.ok(node?.rect, `No ${id} control on screen`);
|
||||||
|
const { x, y, width, height } = node.rect;
|
||||||
|
ad("press", String(Math.round(x + width / 2)), String(Math.round(y + height / 2)));
|
||||||
|
}
|
||||||
|
|
||||||
|
async function pressEnter() {
|
||||||
|
pressControl("terminal-key-enter");
|
||||||
|
await setTimeout(2_000);
|
||||||
|
}
|
||||||
|
|
||||||
|
async function runCommand(command) {
|
||||||
|
ad("type", command, "--delay-ms", "0");
|
||||||
|
await pressEnter();
|
||||||
|
}
|
||||||
|
|
||||||
|
async function terminalSize() {
|
||||||
|
await runCommand("clear; stty size");
|
||||||
|
for (const node of snapshotNodes()) {
|
||||||
|
const match = /^(\d+) (\d+)$/.exec((node.label ?? "").trim());
|
||||||
|
if (match && (node.identifier ?? "").startsWith("terminal-row-")) {
|
||||||
|
return { rows: Number(match[1]), columns: Number(match[2]) };
|
||||||
|
}
|
||||||
|
}
|
||||||
|
throw new Error("No terminal row showed the `stty size` output");
|
||||||
|
}
|
||||||
|
|
||||||
|
function shellQuote(text) {
|
||||||
|
return `'${text.replaceAll("'", "'\\''")}'`;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Prints the source rows, waits for Enter, applies the update, and waits for Enter again. */
|
||||||
|
function fixtureScript() {
|
||||||
|
const at = (row, col) => `\\033[${row + 1};${col + 1}H`;
|
||||||
|
const print = (row, text) => `printf '${at(row, 0)}%s' ${shellQuote(text)}`;
|
||||||
|
const update = SOURCES.map((source) =>
|
||||||
|
source.update === "write"
|
||||||
|
? `${at(source.overhangRow, WRITE_COLUMN)}x`
|
||||||
|
: `${at(source.row, 0)}\\033[2K`,
|
||||||
|
).join("");
|
||||||
|
return [
|
||||||
|
"stty -echo",
|
||||||
|
"printf '\\033[2J\\033[3J'",
|
||||||
|
print(0, "█".repeat(RULER_CELLS)),
|
||||||
|
...SOURCES.map((source) => print(source.row, source.text)),
|
||||||
|
`printf '${at(PARK_ROW, 0)}'`,
|
||||||
|
"read -r _",
|
||||||
|
`printf '${update}${at(PARK_ROW, 0)}'`,
|
||||||
|
"read -r _",
|
||||||
|
"stty echo",
|
||||||
|
"",
|
||||||
|
].join("\n");
|
||||||
|
}
|
||||||
|
|
||||||
|
function screenshot(name) {
|
||||||
|
const path = resolve(artifacts, name);
|
||||||
|
ad("screenshot", path, ...screenshotArgs);
|
||||||
|
return PNG.sync.read(readFileSync(path));
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Pixels in `box` where the two screenshots differ by more than the ink threshold. */
|
||||||
|
function changedPixels(before, after, box) {
|
||||||
|
const difference = new PNG({ width: before.width, height: before.height });
|
||||||
|
for (let index = 0; index < before.data.length; index += 1) {
|
||||||
|
difference.data[index] = Math.abs(before.data[index] - after.data[index]);
|
||||||
|
}
|
||||||
|
return countInk(difference, box, [0, 0, 0]);
|
||||||
|
}
|
||||||
|
|
||||||
|
ad("open", appId, ...deviceArgs());
|
||||||
|
const controls = JSON.parse(ad("snapshot", "-i", "--json")).data.nodes;
|
||||||
|
const hasControl = (id) => controls.some((node) => node.identifier === id);
|
||||||
|
assert.ok(hasControl("terminal-keyboard-toggle"), "Open a terminal first");
|
||||||
|
if (!hasControl("terminal-key-enter")) pressControl("terminal-keyboard-toggle");
|
||||||
|
|
||||||
|
const size = await terminalSize();
|
||||||
|
assert.ok(
|
||||||
|
size.rows > PARK_ROW && size.columns > WRITE_COLUMN,
|
||||||
|
`Terminal too small: ${JSON.stringify(size)}`,
|
||||||
|
);
|
||||||
|
const scriptPath = resolve(fixtureDir, "paseo-terminal-overhang.sh");
|
||||||
|
writeFileSync(scriptPath, fixtureScript());
|
||||||
|
await runCommand(`sh ${scriptPath}`);
|
||||||
|
|
||||||
|
const nodes = snapshotNodes();
|
||||||
|
const before = screenshot("before.png");
|
||||||
|
await pressEnter();
|
||||||
|
const after = screenshot("after.png");
|
||||||
|
await pressEnter();
|
||||||
|
|
||||||
|
// Snapshot rects are in points on iOS and pixels on Android; the checks work in screenshot pixels.
|
||||||
|
const scale = before.width / Math.max(...nodes.map((node) => node.rect?.width ?? 0));
|
||||||
|
const ruler = nodes.find((node) => node.identifier === "terminal-row-0")?.rect;
|
||||||
|
assert.ok(ruler, "The ruler row is not exposed as terminal-row-0");
|
||||||
|
const rulerRect = {
|
||||||
|
x: ruler.x * scale,
|
||||||
|
y: ruler.y * scale,
|
||||||
|
width: ruler.width * scale,
|
||||||
|
height: ruler.height * scale,
|
||||||
|
};
|
||||||
|
const grid = measureGrid(before, rulerRect);
|
||||||
|
const rowBox = (row) => ({
|
||||||
|
left: grid.left,
|
||||||
|
right: grid.left + CHECKED_COLUMNS * grid.cellWidth,
|
||||||
|
top: rulerRect.y + row * rulerRect.height,
|
||||||
|
bottom: rulerRect.y + (row + 1) * rulerRect.height,
|
||||||
|
});
|
||||||
|
|
||||||
|
/** Measures one source row's overhang before and after the update. */
|
||||||
|
function measure(source) {
|
||||||
|
const box = rowBox(source.overhangRow);
|
||||||
|
const overhangBefore = countInk(before, box, grid.background);
|
||||||
|
if (source.update === "write") {
|
||||||
|
const changedAfterWrite = changedPixels(before, after, box);
|
||||||
|
const failures = [
|
||||||
|
...(overhangBefore === 0 ? ["overhang-not-drawn"] : []),
|
||||||
|
...(changedAfterWrite > 0 ? ["overhang-lost-after-write"] : []),
|
||||||
|
];
|
||||||
|
return { ...source, overhangBefore, changedAfterWrite, failures };
|
||||||
|
}
|
||||||
|
const inkAfterErase = countInk(after, box, grid.background);
|
||||||
|
const sourceInkAfterErase = countInk(after, rowBox(source.row), grid.background);
|
||||||
|
const failures = [
|
||||||
|
...(overhangBefore === 0 ? ["overhang-not-drawn"] : []),
|
||||||
|
...(inkAfterErase > 0 ? ["overhang-left-after-erase"] : []),
|
||||||
|
...(sourceInkAfterErase > 0 ? ["source-left-after-erase"] : []),
|
||||||
|
];
|
||||||
|
return { ...source, overhangBefore, inkAfterErase, sourceInkAfterErase, failures };
|
||||||
|
}
|
||||||
|
|
||||||
|
const results = SOURCES.map(measure);
|
||||||
|
|
||||||
|
const report = { platform, label, size, grid, rulerRect, results };
|
||||||
|
writeFileSync(resolve(artifacts, "report.json"), `${JSON.stringify(report, null, 2)}\n`);
|
||||||
|
const failures = results.flatMap((result) =>
|
||||||
|
result.failures.map((failure) => `row ${result.overhangRow}: ${failure}`),
|
||||||
|
);
|
||||||
|
console.log(`${label}: ${failures.length} failures (${artifacts})`);
|
||||||
|
for (const result of results) {
|
||||||
|
console.log(
|
||||||
|
` row ${result.row} -> ${result.overhangRow} (${result.update}): overhang ${result.overhangBefore}` +
|
||||||
|
(result.update === "write"
|
||||||
|
? `, changed after write ${result.changedAfterWrite}`
|
||||||
|
: `, left after erase ${result.inkAfterErase}, source left ${result.sourceInkAfterErase}`),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
for (const failure of failures) console.log(` ${failure}`);
|
||||||
|
process.exitCode = failures.length === 0 ? 0 : 1;
|
||||||
@@ -0,0 +1,149 @@
|
|||||||
|
import { homedir } from "node:os";
|
||||||
|
import { execFileSync } from "node:child_process";
|
||||||
|
import { mkdirSync, writeFileSync } from "node:fs";
|
||||||
|
import { resolve } from "node:path";
|
||||||
|
import { setTimeout } from "node:timers/promises";
|
||||||
|
|
||||||
|
// Reattaches to a terminal whose PTY has a different size than the app will measure, and checks
|
||||||
|
// that the client rows equal the daemon's rows. RESIZE=keyboard opens the keyboard, and the
|
||||||
|
// relaunched app starts with it closed. RESIZE=fold folds an Android foldable emulator and
|
||||||
|
// relaunches the app unfolded. Either way the shell redraws its prompt on attach.
|
||||||
|
//
|
||||||
|
// Preconditions: the app shows terminal TERMINAL_ID, idle at an empty shell prompt, against the
|
||||||
|
// daemon at PASEO_HOST.
|
||||||
|
//
|
||||||
|
// PLATFORM=android TERMINAL_ID=511fd9f0 PASEO_HOST=localhost:6870 \
|
||||||
|
// node e2e/mobile/terminal-rendering/reattach.mjs
|
||||||
|
//
|
||||||
|
// The client used to be sized after the replay arrived, so the shell's redraw landed on the
|
||||||
|
// wrong rows in most trials. TRIALS sets how many reattaches to check.
|
||||||
|
const platform = process.env.PLATFORM ?? "android";
|
||||||
|
const appId = process.env.PASEO_TERMINAL_RENDERING_APP_ID ?? "sh.paseo.debug";
|
||||||
|
const appUrl = process.env.PASEO_TERMINAL_RENDERING_APP_URL;
|
||||||
|
const terminalId = process.env.TERMINAL_ID;
|
||||||
|
const host = process.env.PASEO_HOST;
|
||||||
|
const trials = Number(process.env.TRIALS ?? 5);
|
||||||
|
const resize = process.env.RESIZE ?? "keyboard";
|
||||||
|
const label = process.env.PASEO_TERMINAL_RENDERING_LABEL ?? "reattach";
|
||||||
|
const session = process.env.AGENT_DEVICE_SESSION ?? `terminal-rendering-${platform}`;
|
||||||
|
const artifacts = resolve(
|
||||||
|
process.env.PASEO_TERMINAL_RENDERING_ARTIFACTS ??
|
||||||
|
resolve(homedir(), ".paseo/artifacts/terminal-rendering", platform),
|
||||||
|
label,
|
||||||
|
);
|
||||||
|
const env = {
|
||||||
|
...process.env,
|
||||||
|
AGENT_DEVICE_STATE_DIR:
|
||||||
|
process.env.AGENT_DEVICE_STATE_DIR ??
|
||||||
|
resolve(homedir(), ".paseo/artifacts/terminal-rendering/device-state"),
|
||||||
|
};
|
||||||
|
if (!terminalId || !host) throw new Error("Set TERMINAL_ID and PASEO_HOST");
|
||||||
|
mkdirSync(artifacts, { recursive: true });
|
||||||
|
|
||||||
|
function ad(...args) {
|
||||||
|
return execFileSync("agent-device", [...args, "--session", session], {
|
||||||
|
env,
|
||||||
|
encoding: "utf8",
|
||||||
|
timeout: 120_000,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function paseo(...args) {
|
||||||
|
return execFileSync("npm", ["run", "-s", "cli", "--", ...args, "--host", host], {
|
||||||
|
cwd: resolve(import.meta.dirname, "../../../../.."),
|
||||||
|
encoding: "utf8",
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function pressControl(id) {
|
||||||
|
const node = JSON.parse(ad("snapshot", "-i", "--json")).data.nodes.find(
|
||||||
|
(candidate) => candidate.identifier === id,
|
||||||
|
);
|
||||||
|
if (!node?.rect) throw new Error(`No ${id} control on screen`);
|
||||||
|
const { x, y, width, height } = node.rect;
|
||||||
|
ad("press", String(Math.round(x + width / 2)), String(Math.round(y + height / 2)));
|
||||||
|
}
|
||||||
|
|
||||||
|
async function resizePty() {
|
||||||
|
if (resize === "keyboard") {
|
||||||
|
pressControl("terminal-keyboard-toggle");
|
||||||
|
await setTimeout(2_000);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
const adb = (...args) =>
|
||||||
|
execFileSync("adb", [
|
||||||
|
...(process.env.ANDROID_SERIAL ? ["-s", process.env.ANDROID_SERIAL] : []),
|
||||||
|
...args,
|
||||||
|
]);
|
||||||
|
adb("emu", "fold");
|
||||||
|
await setTimeout(5_000);
|
||||||
|
adb("shell", "am", "force-stop", appId);
|
||||||
|
adb("emu", "unfold");
|
||||||
|
await setTimeout(3_000);
|
||||||
|
}
|
||||||
|
|
||||||
|
function clientRows() {
|
||||||
|
const nodes = JSON.parse(ad("snapshot", "--json")).data.nodes;
|
||||||
|
const byIndex = new Map(nodes.map((node) => [node.index, node]));
|
||||||
|
const rows = [];
|
||||||
|
for (const node of nodes) {
|
||||||
|
const match = /^terminal-row-(\d+)$/.exec(node.identifier ?? "");
|
||||||
|
if (!match) continue;
|
||||||
|
// agent-device leaves the label on the parent when the row inherits it.
|
||||||
|
const text = node.label ?? (node.inheritsLabel ? byIndex.get(node.parentIndex)?.label : "");
|
||||||
|
rows[Number(match[1])] = (text ?? "").trim();
|
||||||
|
}
|
||||||
|
return rows;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Waits for the relaunched app to show terminal rows, then for the shell's redraw to land.
|
||||||
|
* Returns null when no row appears, for example when the app crashed on launch.
|
||||||
|
*/
|
||||||
|
async function attachedClientRows() {
|
||||||
|
for (let attempt = 0; attempt < 30; attempt += 1) {
|
||||||
|
await setTimeout(2_000);
|
||||||
|
if (clientRows().some((text) => text !== "")) {
|
||||||
|
await setTimeout(3_000);
|
||||||
|
return clientRows();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function mismatches(client, server) {
|
||||||
|
const rows = [];
|
||||||
|
for (let row = 0; row < Math.max(client.length, server.length); row += 1) {
|
||||||
|
const expected = (server[row] ?? "").trim();
|
||||||
|
const actual = client[row] ?? "";
|
||||||
|
if (expected !== actual) rows.push({ row, server: expected, client: actual });
|
||||||
|
}
|
||||||
|
return rows;
|
||||||
|
}
|
||||||
|
|
||||||
|
const results = [];
|
||||||
|
for (let trial = 1; trial <= trials; trial += 1) {
|
||||||
|
paseo("terminal", "send-keys", terminalId, "clear", "Enter");
|
||||||
|
await setTimeout(1_500);
|
||||||
|
await resizePty();
|
||||||
|
ad("open", appId, ...(appUrl ? [appUrl] : []), "--relaunch");
|
||||||
|
const client = await attachedClientRows();
|
||||||
|
ad("screenshot", resolve(artifacts, `trial-${trial}.png`));
|
||||||
|
if (!client) {
|
||||||
|
results.push({ trial, attached: false });
|
||||||
|
console.log(`${label} trial ${trial}: no terminal rows appeared`);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
const server = paseo("terminal", "capture", terminalId).split("\n");
|
||||||
|
const rows = mismatches(client, server);
|
||||||
|
results.push({ trial, attached: true, mismatchedRows: rows });
|
||||||
|
console.log(`${label} trial ${trial}: ${rows.length} mismatched rows`);
|
||||||
|
}
|
||||||
|
|
||||||
|
writeFileSync(resolve(artifacts, "report.json"), `${JSON.stringify(results, null, 2)}\n`);
|
||||||
|
const attached = results.filter((result) => result.attached);
|
||||||
|
const failed = attached.filter((result) => result.mismatchedRows.length > 0).length;
|
||||||
|
console.log(
|
||||||
|
`${label}: ${failed} of ${attached.length} reattaches differ from the daemon, ${trials - attached.length} never attached (${artifacts})`,
|
||||||
|
);
|
||||||
|
process.exitCode = failed === 0 && attached.length === trials ? 0 : 1;
|
||||||
@@ -0,0 +1,197 @@
|
|||||||
|
import assert from "node:assert/strict";
|
||||||
|
import { execFileSync } from "node:child_process";
|
||||||
|
import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
|
||||||
|
import { homedir, tmpdir } from "node:os";
|
||||||
|
import { resolve } from "node:path";
|
||||||
|
import { setTimeout } from "node:timers/promises";
|
||||||
|
import { PNG } from "pngjs";
|
||||||
|
import {
|
||||||
|
checkPartialSelection,
|
||||||
|
checkTerminalScreenshot,
|
||||||
|
selectionTarget,
|
||||||
|
writeOverlay,
|
||||||
|
} from "./check.mjs";
|
||||||
|
import { fixtureOutput } from "./fixture.mjs";
|
||||||
|
|
||||||
|
// Renders the fixture in a real Paseo terminal and checks the screenshot with `check.mjs`, then
|
||||||
|
// selects one cell of a conjunct and checks a second screenshot.
|
||||||
|
//
|
||||||
|
// Preconditions: the app runs the build being verified against a daemon on the same host as
|
||||||
|
// this script, and shows an idle, focused terminal with an empty shell prompt.
|
||||||
|
//
|
||||||
|
// PLATFORM=android ANDROID_SERIAL=emulator-5554 node e2e/mobile/terminal-rendering/render.mjs
|
||||||
|
// PLATFORM=ios IOS_DEVICE="iPhone 17" node e2e/mobile/terminal-rendering/render.mjs
|
||||||
|
const platform = process.env.PLATFORM ?? "android";
|
||||||
|
const appId = process.env.PASEO_TERMINAL_RENDERING_APP_ID ?? "sh.paseo.debug";
|
||||||
|
const label = process.env.PASEO_TERMINAL_RENDERING_LABEL ?? "run";
|
||||||
|
const session = process.env.AGENT_DEVICE_SESSION ?? `terminal-rendering-${platform}`;
|
||||||
|
const artifacts = resolve(
|
||||||
|
process.env.PASEO_TERMINAL_RENDERING_ARTIFACTS ??
|
||||||
|
resolve(homedir(), ".paseo/artifacts/terminal-rendering", platform),
|
||||||
|
label,
|
||||||
|
);
|
||||||
|
const fixtureDir = process.env.PASEO_TERMINAL_RENDERING_FIXTURE_DIR ?? tmpdir();
|
||||||
|
// iOS simulators screenshot at one pixel per point unless asked; glyph identity needs the
|
||||||
|
// device's real density. Android screenshots are always in device pixels.
|
||||||
|
const screenshotArgs =
|
||||||
|
platform === "ios"
|
||||||
|
? ["--pixel-density", process.env.PASEO_TERMINAL_RENDERING_PIXEL_DENSITY ?? "3"]
|
||||||
|
: [];
|
||||||
|
const env = {
|
||||||
|
...process.env,
|
||||||
|
AGENT_DEVICE_STATE_DIR:
|
||||||
|
process.env.AGENT_DEVICE_STATE_DIR ??
|
||||||
|
resolve(homedir(), ".paseo/artifacts/terminal-rendering/device-state"),
|
||||||
|
};
|
||||||
|
mkdirSync(artifacts, { recursive: true });
|
||||||
|
|
||||||
|
function ad(...args) {
|
||||||
|
return execFileSync("agent-device", [...args, "--session", session], {
|
||||||
|
env,
|
||||||
|
encoding: "utf8",
|
||||||
|
timeout: 60_000,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function deviceArgs() {
|
||||||
|
if (platform === "android") {
|
||||||
|
return [
|
||||||
|
"--platform",
|
||||||
|
"android",
|
||||||
|
...(process.env.ANDROID_SERIAL ? ["--serial", process.env.ANDROID_SERIAL] : []),
|
||||||
|
];
|
||||||
|
}
|
||||||
|
return [
|
||||||
|
"--platform",
|
||||||
|
"ios",
|
||||||
|
...(process.env.IOS_DEVICE ? ["--device", process.env.IOS_DEVICE] : []),
|
||||||
|
];
|
||||||
|
}
|
||||||
|
|
||||||
|
function snapshotNodes() {
|
||||||
|
return JSON.parse(ad("snapshot", "--json")).data.nodes;
|
||||||
|
}
|
||||||
|
|
||||||
|
function rowNodes(nodes) {
|
||||||
|
const rows = new Map();
|
||||||
|
for (const node of nodes) {
|
||||||
|
const match = /^terminal-row-(\d+)$/.exec(node.identifier ?? "");
|
||||||
|
if (match && node.rect) rows.set(Number(match[1]), node);
|
||||||
|
}
|
||||||
|
return rows;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Taps a control at its center. On iOS the keyboard toolbar is a full-screen accessibility node
|
||||||
|
* listed after the key bar, so pressing by selector reports the keys as covered.
|
||||||
|
*/
|
||||||
|
function pressControl(id) {
|
||||||
|
const node = JSON.parse(ad("snapshot", "-i", "--json")).data.nodes.find(
|
||||||
|
(candidate) => candidate.identifier === id,
|
||||||
|
);
|
||||||
|
assert.ok(node?.rect, `No ${id} control on screen`);
|
||||||
|
const { x, y, width, height } = node.rect;
|
||||||
|
ad("press", String(Math.round(x + width / 2)), String(Math.round(y + height / 2)));
|
||||||
|
}
|
||||||
|
|
||||||
|
async function runCommand(command) {
|
||||||
|
ad("type", command, "--delay-ms", "0");
|
||||||
|
pressControl("terminal-key-enter");
|
||||||
|
await setTimeout(2_000);
|
||||||
|
}
|
||||||
|
|
||||||
|
async function terminalSize() {
|
||||||
|
await runCommand("clear; stty size");
|
||||||
|
for (const node of snapshotNodes()) {
|
||||||
|
const match = /^(\d+) (\d+)$/.exec((node.label ?? "").trim());
|
||||||
|
if (match && (node.identifier ?? "").startsWith("terminal-row-")) {
|
||||||
|
return { rows: Number(match[1]), columns: Number(match[2]) };
|
||||||
|
}
|
||||||
|
}
|
||||||
|
throw new Error("No terminal row showed the `stty size` output");
|
||||||
|
}
|
||||||
|
|
||||||
|
ad("open", appId, ...deviceArgs());
|
||||||
|
const controls = JSON.parse(ad("snapshot", "-i", "--json")).data.nodes;
|
||||||
|
const hasControl = (id) => controls.some((node) => node.identifier === id);
|
||||||
|
assert.ok(hasControl("terminal-keyboard-toggle"), "Open a terminal first");
|
||||||
|
if (!hasControl("terminal-key-enter")) pressControl("terminal-keyboard-toggle");
|
||||||
|
|
||||||
|
const size = await terminalSize();
|
||||||
|
const fixturePath = resolve(fixtureDir, "paseo-terminal-rendering.txt");
|
||||||
|
const scriptPath = resolve(fixtureDir, "paseo-terminal-rendering.sh");
|
||||||
|
writeFileSync(fixturePath, fixtureOutput(size.columns));
|
||||||
|
writeFileSync(scriptPath, `printf '\\033[2J\\033[3J\\033[H'; cat '${fixturePath}'; sleep 120\n`);
|
||||||
|
await runCommand(`sh ${scriptPath}`);
|
||||||
|
|
||||||
|
const nodes = snapshotNodes();
|
||||||
|
const screenshotPath = resolve(artifacts, "terminal.png");
|
||||||
|
ad("screenshot", screenshotPath, ...screenshotArgs);
|
||||||
|
const png = PNG.sync.read(readFileSync(screenshotPath));
|
||||||
|
// Snapshot rects are in points on iOS and pixels on Android; the checks work in screenshot pixels.
|
||||||
|
const scale = png.width / Math.max(...nodes.map((node) => node.rect?.width ?? 0));
|
||||||
|
const toPixels = ({ x, y, width, height }) => ({
|
||||||
|
x: x * scale,
|
||||||
|
y: y * scale,
|
||||||
|
width: width * scale,
|
||||||
|
height: height * scale,
|
||||||
|
});
|
||||||
|
const rows = rowNodes(nodes);
|
||||||
|
const rects = new Map([...rows].map(([index, node]) => [index, toPixels(node.rect)]));
|
||||||
|
const { grid, failures, slots } = await checkTerminalScreenshot({ png, size, rows: rects });
|
||||||
|
|
||||||
|
// Long-press selects the conjunct as a word; dragging back from its second cell leaves the first.
|
||||||
|
const target = await selectionTarget({ size });
|
||||||
|
const targetRect = rects.get(target.row);
|
||||||
|
assert.ok(targetRect, "The select line is not on screen");
|
||||||
|
const y = Math.round((targetRect.y + targetRect.height / 2) / scale);
|
||||||
|
const cellX = (offset) => Math.round((grid.left + (target.col + offset) * grid.cellWidth) / scale);
|
||||||
|
ad("longpress", String(cellX(0.5)), String(y), "800");
|
||||||
|
ad("gesture", "pan", String(cellX(1.75)), String(y), String(cellX(0.5) - cellX(1.75)), "0", "600");
|
||||||
|
const selectionPath = resolve(artifacts, "selection.png");
|
||||||
|
ad("screenshot", selectionPath, ...screenshotArgs);
|
||||||
|
const selectionFailures = checkPartialSelection({
|
||||||
|
png: PNG.sync.read(readFileSync(selectionPath)),
|
||||||
|
rows: rects,
|
||||||
|
grid,
|
||||||
|
target,
|
||||||
|
});
|
||||||
|
for (const failure of selectionFailures) failures.push({ line: "select", ...failure });
|
||||||
|
// A tap clears the selection; it would otherwise survive into the next run's screenshot.
|
||||||
|
const lastRect = rects.get(size.rows - 1);
|
||||||
|
if (lastRect) {
|
||||||
|
ad("press", String(cellX(4)), String(Math.round((lastRect.y + lastRect.height / 2) / scale)));
|
||||||
|
}
|
||||||
|
try {
|
||||||
|
pressControl("terminal-key-ctrl");
|
||||||
|
ad("type", "c", "--delay-ms", "0");
|
||||||
|
} catch (error) {
|
||||||
|
console.warn(`Could not interrupt the fixture: ${error.message}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
writeOverlay(png, slots, resolve(artifacts, "overlay.png"));
|
||||||
|
const report = {
|
||||||
|
platform,
|
||||||
|
label,
|
||||||
|
size,
|
||||||
|
grid,
|
||||||
|
checkedClusters: slots.length,
|
||||||
|
failures,
|
||||||
|
rows: [...rows.keys()].map((index) => ({
|
||||||
|
index,
|
||||||
|
label: rows.get(index).label,
|
||||||
|
rect: rects.get(index),
|
||||||
|
})),
|
||||||
|
};
|
||||||
|
writeFileSync(resolve(artifacts, "report.json"), `${JSON.stringify(report, null, 2)}\n`);
|
||||||
|
|
||||||
|
const byLine = Map.groupBy(failures, (failure) => failure.line);
|
||||||
|
console.log(
|
||||||
|
`${label}: ${slots.length} clusters checked, ${failures.length} failures (${artifacts})`,
|
||||||
|
);
|
||||||
|
for (const [line, list] of byLine) {
|
||||||
|
console.log(
|
||||||
|
` ${line}: ${list.map((failure) => `${failure.kind}@${failure.col ?? "-"}${failure.char ? `(${failure.char})` : ""}`).join(" ")}`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
process.exitCode = failures.length === 0 ? 0 : 1;
|
||||||
@@ -0,0 +1,54 @@
|
|||||||
|
// Open an existing compact chat, with the keyboard closed, then interrupt its host connection.
|
||||||
|
// Hold that interruption externally (for example, stop a disposable SSH TCP forward).
|
||||||
|
// Leave the daemon running. This test observes the public reconnecting state.
|
||||||
|
// node placement.mjs <session> <platform> <coordinate-scale> <composer-label> <artifacts>
|
||||||
|
// coordinate-scale is screenshot pixels per layout point (Android density; iOS snapshots use 1).
|
||||||
|
import assert from "node:assert/strict";
|
||||||
|
import { execFileSync } from "node:child_process";
|
||||||
|
import { mkdirSync, writeFileSync } from "node:fs";
|
||||||
|
import path from "node:path";
|
||||||
|
|
||||||
|
const [, , session, platform, coordinateScale, composerLabel, artifacts] = process.argv;
|
||||||
|
assert(
|
||||||
|
session && ["android", "ios"].includes(platform) && composerLabel && artifacts,
|
||||||
|
"Pass all five arguments",
|
||||||
|
);
|
||||||
|
const scale = Number(coordinateScale);
|
||||||
|
assert(scale > 0, "Pass a positive coordinate scale");
|
||||||
|
mkdirSync(artifacts, { recursive: true });
|
||||||
|
function ad(...args) {
|
||||||
|
return execFileSync("agent-device", ["--session", session, "--platform", platform, ...args], {
|
||||||
|
encoding: "utf8",
|
||||||
|
timeout: 90_000,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
function capture(name) {
|
||||||
|
const snapshot = ad("snapshot", "--raw", "--json");
|
||||||
|
writeFileSync(path.join(artifacts, `${name}.json`), snapshot);
|
||||||
|
ad("screenshot", path.join(artifacts, `${name}.png`));
|
||||||
|
const nodes = JSON.parse(snapshot).data.nodes;
|
||||||
|
const header = nodes.find((node) => node.identifier === "floating-header");
|
||||||
|
const toast = nodes.find((node) => node.identifier === "agent-reconnecting-toast");
|
||||||
|
assert(header?.rect && toast?.rect, "Measured header and reconnecting toast must be present");
|
||||||
|
assert(toast.rect.height > 0 && toast.rect.width > 0, "Toast must have visible bounds");
|
||||||
|
const gap = (toast.rect.y - header.rect.y - header.rect.height) / scale;
|
||||||
|
assert(Math.abs(gap - 12) <= 1, `${name}: actual header-to-toast gap ${gap}, expected12 points`);
|
||||||
|
return toast.rect.y / scale;
|
||||||
|
}
|
||||||
|
|
||||||
|
ad("wait", 'id="agent-reconnecting-toast"', "20000");
|
||||||
|
const closedTop = capture("keyboard-closed");
|
||||||
|
ad("press", `label=${JSON.stringify(composerLabel)}`);
|
||||||
|
const opened = ad("snapshot", "--raw", "--json");
|
||||||
|
const nodes = JSON.parse(opened).data.nodes;
|
||||||
|
assert(
|
||||||
|
nodes.some(
|
||||||
|
(node) => /keyboard/i.test(node.type ?? "") || /inputmethod/i.test(node.bundleId ?? ""),
|
||||||
|
),
|
||||||
|
"Use a real visible software keyboard; open Android sessions with --no-test-ime",
|
||||||
|
);
|
||||||
|
const openTop = capture("keyboard-open");
|
||||||
|
assert(Math.abs(openTop - closedTop) <= 1, "Keyboard must not translate the toast");
|
||||||
|
console.log(
|
||||||
|
"PASS: rendered reconnecting toast stays12 points below measured header, keyboard closed/open",
|
||||||
|
);
|
||||||
@@ -107,6 +107,8 @@ const daemonTest = metroTest.extend<
|
|||||||
});
|
});
|
||||||
|
|
||||||
const test = daemonTest.extend<{
|
const test = daemonTest.extend<{
|
||||||
|
/** Specs start past first-run setup; onboarding specs opt out to see a fresh install. */
|
||||||
|
e2eOnboardingCompleted: boolean;
|
||||||
paseoE2ESetup: void;
|
paseoE2ESetup: void;
|
||||||
outdatedDaemon: OutdatedDaemon;
|
outdatedDaemon: OutdatedDaemon;
|
||||||
desktopManagedOutdatedDaemon: OutdatedDaemon;
|
desktopManagedOutdatedDaemon: OutdatedDaemon;
|
||||||
@@ -114,8 +116,9 @@ const test = daemonTest.extend<{
|
|||||||
projectPickerFixture: TrackedProjectPickerFixture;
|
projectPickerFixture: TrackedProjectPickerFixture;
|
||||||
withWorkspace: WithWorkspace;
|
withWorkspace: WithWorkspace;
|
||||||
}>({
|
}>({
|
||||||
|
e2eOnboardingCompleted: [true, { option: true }],
|
||||||
paseoE2ESetup: [
|
paseoE2ESetup: [
|
||||||
async ({ page }, provide, testInfo) => {
|
async ({ page, e2eOnboardingCompleted }, provide, testInfo) => {
|
||||||
const daemonPort = getE2EDaemonPort();
|
const daemonPort = getE2EDaemonPort();
|
||||||
const metroPort = process.env.E2E_METRO_PORT;
|
const metroPort = process.env.E2E_METRO_PORT;
|
||||||
if (!metroPort) {
|
if (!metroPort) {
|
||||||
@@ -157,7 +160,7 @@ const test = daemonTest.extend<{
|
|||||||
const createAgentPreferences = buildCreateAgentPreferences();
|
const createAgentPreferences = buildCreateAgentPreferences();
|
||||||
|
|
||||||
await page.addInitScript(
|
await page.addInitScript(
|
||||||
({ daemon, preferences, seedNonce: nonce, extraHostsKey }) => {
|
({ daemon, preferences, seedNonce: nonce, extraHostsKey, onboardingCompleted }) => {
|
||||||
// `addInitScript` runs on every navigation (including reloads). Some tests intentionally
|
// `addInitScript` runs on every navigation (including reloads). Some tests intentionally
|
||||||
// override storage and reload; they can opt out of seeding for the *next* navigation by
|
// override storage and reload; they can opt out of seeding for the *next* navigation by
|
||||||
// setting this flag before the reload.
|
// setting this flag before the reload.
|
||||||
@@ -185,12 +188,20 @@ const test = daemonTest.extend<{
|
|||||||
if (!localStorage.getItem("@paseo:app-settings")) {
|
if (!localStorage.getItem("@paseo:app-settings")) {
|
||||||
localStorage.setItem("@paseo:app-settings", JSON.stringify({ chatDisplay: "full" }));
|
localStorage.setItem("@paseo:app-settings", JSON.stringify({ chatDisplay: "full" }));
|
||||||
}
|
}
|
||||||
|
// The shared daemon often has no projects, which would open first-run setup over the app.
|
||||||
|
if (onboardingCompleted && !localStorage.getItem("@paseo:onboarding")) {
|
||||||
|
localStorage.setItem(
|
||||||
|
"@paseo:onboarding",
|
||||||
|
JSON.stringify({ completedAt: new Date(0).toISOString() }),
|
||||||
|
);
|
||||||
|
}
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
daemon: testDaemon,
|
daemon: testDaemon,
|
||||||
preferences: createAgentPreferences,
|
preferences: createAgentPreferences,
|
||||||
seedNonce,
|
seedNonce,
|
||||||
extraHostsKey: EXTRA_HOSTS_KEY,
|
extraHostsKey: EXTRA_HOSTS_KEY,
|
||||||
|
onboardingCompleted: e2eOnboardingCompleted,
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user