Commit Graph

474 Commits

Author SHA1 Message Date
Mohamed Boudra
e8890a2fc1 wip: uncommitted changes
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-03 16:06:40 +07:00
Mohamed Boudra
4185db9c75 feat(app): update app icons to new butterfly design
Replace walking person icons with new Paseo butterfly branding.
Remove unused react logos and android background/monochrome assets.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-03 15:53:06 +07:00
Mohamed Boudra
8add1a6620 feat(tool-call-sheet): improve MCP tool call display
- Extract key-value pairs from tool arguments and results
- Add Input/Output group headers with visual separation
- Fix Playwright MCP tool calls not being clickable (pass data.input as args)
- Increase default sheet height to 60%
- Add extractKeyValuePairs utility function using Zod

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-03 15:23:49 +07:00
Mohamed Boudra
914cebc914 feat(input): add web autofocus and Cmd+Enter force send
- Add autoFocus prop to MessageInput and AgentInputArea
- Auto-focus input on web when entering agent or new agent screens
- Add Cmd+Enter (Mac) / Ctrl+Enter (Windows) to bypass queue and send immediately
- Add forceSend property to MessagePayload interface

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-03 15:23:41 +07:00
Mohamed Boudra
e3d25dc38e Fix working indicator padding calculation
Account for list's spacing[2] padding - use spacing[2] for bubble
so total equals spacing[4] to match input area

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 21:31:36 +07:00
Mohamed Boudra
8023aed98b Fix working indicator padding and remove redundant streaming dots
- Align working indicator left padding with AssistantMessage (spacing[4])
- Remove isStreaming prop and "..." indicator from AssistantMessage
- The WorkingIndicator already shows agent is running, no need for duplicate

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 21:26:05 +07:00
Mohamed Boudra
b3a1729df2 Use replace navigation for agent switches 2026-01-01 16:55:58 +07:00
Mohamed Boudra
0c4d1c3a58 Buffer streaming chunks to reduce rerenders 2026-01-01 15:43:06 +07:00
Mohamed Boudra
63247f73b3 feat(file-explorer): add file download with share sheet support 2026-01-01 13:07:51 +07:00
Mohamed Boudra
57a86d011a Add file download tokens over WS and HTTP 2025-12-29 12:12:13 +07:00
Mohamed Boudra
15b62448cb Fix dictation auto-grow performance - revert to original fast path 2025-12-29 11:51:12 +07:00
Mohamed Boudra
0cb8bbcf62 Improve dictation UX: transcribe-only mode with UI fixes
- Dictation now appends transcribed text to input instead of auto-sending
- Voice button stays visible even with attachments or existing text
- Dictation works on create agent screen (not just agent chat)
- Input auto-grows when dictation appends text
- New agent screen input has solid background (no transparency)
- Timer preserves duration after confirming (no scary reset to zero)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-29 11:24:15 +07:00
Mohamed Boudra
09d4acce4c Clean up Claude agent SDK message conversion
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-29 11:02:02 +07:00
Mohamed Boudra
7a024ce7fd Migrate image encoding to expo-file-system File API 2025-12-29 10:51:06 +07:00
Mohamed Boudra
1200bce7e3 Fix Codex image prompt data URLs 2025-12-29 10:34:43 +07:00
Mohamed Boudra
b559422cb0 Write Codex image attachments to temp files 2025-12-29 10:13:00 +07:00
Mohamed Boudra
a087b085e6 Add multimodal prompt blocks for agent prompts 2025-12-29 09:15:09 +07:00
Mohamed Boudra
6160d96716 Fix web image base64 encoding 2025-12-29 09:09:53 +07:00
Mohamed Boudra
d5f5351d37 Add image attachments to agent creation 2025-12-29 09:07:54 +07:00
Mohamed Boudra
db9887d723 Validate new agent URL params 2025-12-29 00:22:40 +07:00
Mohamed Boudra
5325240b26 Remove host label from git diff screen 2025-12-29 00:16:38 +07:00
Mohamed Boudra
ffc6bd3ba5 Fix inline path linking for absolute cwd paths 2025-12-29 00:15:21 +07:00
Mohamed Boudra
025fd97143 Fix file explorer back loader 2025-12-29 00:10:23 +07:00
Mohamed Boudra
5120f73f49 Add host selector to import agent modal 2025-12-29 00:06:06 +07:00
Mohamed Boudra
265caaf140 Fix gallery image timeout crash 2025-12-29 00:02:00 +07:00
Mohamed Boudra
29d561725c Fix Codex import list 2025-12-28 23:59:09 +07:00
Mohamed Boudra
e5ea77e961 Filter internal Claude import history 2025-12-28 23:48:41 +07:00
Mohamed Boudra
7c97dc18fb Show permissions mode in agent trigger 2025-12-28 23:38:02 +07:00
Mohamed Boudra
1269edcb6e Persist new agent form config 2025-12-28 23:36:05 +07:00
Mohamed Boudra
69b6f755fa feat: add turn_canceled event for proper interruption handling
Adds a new turn_canceled event type to distinguish intentional turn
interruption from errors. Fixes race conditions in Claude agent where
concurrent stream() calls could cause garbled output by serializing
turn handoff with turn IDs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-28 16:29:01 +00:00
Mohamed Boudra
076080db48 Fix external session import and add Claude persistence test
- Fix experimental_resume by parsing rollout history and injecting as
  developer-instructions (experimental_resume was removed from Codex MCP)
- Add parseRolloutHistory() to extract conversation from JSONL transcripts
- Set pendingResumeFile from config.extra.codex.experimental_resume
- Add Claude session persistence test (remembers number across sessions)
- Remove Playwright tests (not used in this codebase)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-12-27 07:55:54 +00:00
Mohamed Boudra
9d941a1509 Add external Codex session import tests (experimental_resume feature)
Added tests for importing external codex exec sessions into the daemon:
- Main test is skipped: Codex MCP's experimental_resume feature doesn't
  properly load conversation context. The config is passed correctly but
  Codex starts a fresh session instead of resuming.
- Fallback test passes: Verifies graceful handling of non-existent sessions

Note: `codex exec resume <sessionId>` works correctly from CLI, but the
experimental_resume config option via MCP doesn't restore context.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-27 07:19:39 +00:00
Mohamed Boudra
2fd6c83746 feat: implement experimental_resume for Codex mode switching and interrupts
- Add findCodexResumeFile() to find Codex session transcripts
- Update interrupt() to find resume file and clear session IDs
- Update setMode() to use interrupt() for session reset
- Update buildCodexMcpConfig() to accept experimentalResume parameter
- Update forwardPrompt() to use pendingResumeFile when starting new session
- Update setAgentMode in agent-manager to also update runtimeInfo.modeId
- Add new tests for abort stopping execution and mode switching
- Skip two tests with race condition bugs (to be fixed separately)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-27 07:08:13 +00:00
Mohamed Boudra
1e9d8bf075 Add server-side validation for working directory existence
- Validate cwd exists before creating agent in session.ts
- Show error message when directory doesn't exist
- Add client-side warning display in new.tsx
- Block form submission for non-existent directories
- Add daemon e2e test for non-existent cwd validation
- Add createAgentExpectFail helper in daemon-client.ts

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-27 05:10:59 +00:00
Mohamed Boudra
95c821a4c6 fix: restore input on submission error and enforce clean working tree for git operations 2025-12-27 09:35:40 +07:00
Mohamed Boudra
40835bbe9d Fix Codex history persistence after daemon restart
- Modified loadPersistedHistoryFromDisk() to use sessionId or conversationId as fallback
- Added rollout path and session dir persistence in agent metadata
- Added fallback to default Codex session root when metadata path is empty
- Cleaned up create-agent-modal.tsx (removed 800+ lines of dead code)
- Updated app routing and home-footer cleanup

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-26 11:39:20 +07:00
Mohamed Boudra
26da925de6 Redesign new agent page UI layout
- Move host selector to header (right side) with icon + name + status dot
- Combine provider/model/mode into single "Agent" dropdown
- Replace Git branch/worktree toggles with segmented IsolationControl (None/Branch/Worktree)
- Only show Git section for git repositories (hide for non-git directories)
- Wrap config section in ScrollView for proper scrolling
- Simplify layout: Working Directory → Agent → Git (when applicable)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 21:40:35 +07:00
Mohamed Boudra
11e7bc5fcc Fix: Clear attention when agent finishes while user is viewing
When a user is viewing an agent screen and the agent transitions from
running to idle, immediately call clearAgentAttention since the user
witnessed the completion. This prevents the "requires attention" state
from appearing when the user navigates back to the home screen.

Added a useEffect in AgentScreenContent that:
1. Tracks the previous agent status via a ref
2. Detects transitions from "running" to "idle"
3. Clears attention immediately on such transitions

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 21:22:24 +07:00
Mohamed Boudra
54f0583334 Add Git Options Section to new agent page
- Added GitOptionsSection and ToggleRow components to agent-form-dropdowns.tsx
- Added useDaemonRequest hook for git_repo_info_request in new.tsx
- Added git-related state: baseBranch, createNewBranch, branchName, createWorktree, worktreeSlug
- Added git validation logic: isNonGitDirectory, gitBlockingError, validateWorktreeName
- Updated handleCreateFromInput to include git options in createAgent call
- Git section only shows when working directory is set
- Auto-populates base branch from current branch
- Shows dirty directory warning
- Validates branch/worktree names

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 21:17:25 +07:00
Mohamed Boudra
bd7752b4f4 Add visual loading indicator to new agent page
- Add isSubmitLoading prop to AgentInputArea component to allow parent
  to control loading state externally
- When isSubmitLoading is true:
  - Show ActivityIndicator instead of ArrowUp icon in send button
  - Disable send button with reduced opacity
- Pass isLoading state from new.tsx to AgentInputArea via isSubmitLoading prop

Files changed:
- packages/app/src/components/agent-input-area.tsx:53-54, 98, 1050-1060
- packages/app/src/app/agent/new.tsx:472

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 21:07:46 +07:00
Mohamed Boudra
a398f67527 Fix new agent page bugs and add error handling
- Add errorMessage and isLoading states for proper UX feedback
- Add validation for working directory, prompt, host, and connection
- Display error messages in red container below config section
- Handle agent_create_failed status with error display
- Add loading state management during agent creation
- Log warning for image attachments (server API doesn't support yet)

Tested with Playwright MCP:
- Error message "Working directory is required" displays correctly
- Agent creation with valid config succeeds and redirects

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 20:53:31 +07:00
Mohamed Boudra
7e9e685a14 Fix Claude agent race condition in forwardPromptEvents
The race condition occurred when overlapping stream() calls (e.g., during
message interrupt) corrupted shared instance-level flags:
- streamedAssistantTextThisTurn
- streamedReasoningThisTurn

This caused Turn 2 to reset flags while Turn 1 was still reading them,
leading to garbled text or suppressed responses.

Fix:
- Created TurnContext interface to track per-turn streaming state
- Moved flags from instance variables to turn-local context
- Pass TurnContext through translateMessageToEvents, mapBlocksToTimeline,
  and mapPartialEvent call chains

Also fixed:
- session.ts interruptAgentIfRunning() now polls for agent to become
  fully idle (not just cancelled) before starting new run, matching
  the fix from MCP handler

Test:
- Added E2E test that sends overlapping messages and verifies Turn 2
  responds with its own content, not Turn 1's

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 20:43:42 +07:00
Mohamed Boudra
219411d3ee Add E2E test for long-running Claude agent streaming integrity
Investigated server-side streaming for Claude agents to determine if
chunks are being lost during transmission. Created a new E2E test that:

1. Creates a Claude agent with bypassPermissions mode
2. Sends 3 back-and-forth messages to simulate long-running agent
3. On the 3rd message, captures all streaming chunks
4. Verifies chunks are complete, coherent, and contain expected content
5. Checks for UTF-8 corruption and abnormal word concatenation

RESULT: Test passes. Server correctly forwards all text_delta chunks
from Claude SDK. No chunks are dropped or corrupted.

CONCLUSION: The original bug report (REPORT-garbled-text-bug.md) observed
missing chunks at the client level, but server-side code is NOT the cause.
The issue must be elsewhere (possibly React Native WebSocket differences
or a transient network issue).

Files:
- packages/server/src/server/daemon.e2e.test.ts:1883-2028 - New test

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 20:17:45 +07:00
Mohamed Boudra
b1bcb8e6df Fix send_agent_prompt to interrupt running agent before sending new prompt
Problem: When calling send_agent_prompt on an agent that already has an
active run, it errored with "Agent {id} already has an active run"
instead of interrupting and sending the prompt (like the app does).

Solution: Modified the send_agent_prompt MCP handler in mcp-server.ts to:
- Check if agent has an active run (lifecycle === "running" || pendingRun)
- If running, call cancelAgentRun() to interrupt the current run
- Poll wait (max 5s, 50ms interval) for agent to become idle
- Then start the new run

This matches the behavior of session.ts:interruptAgentIfRunning().

The polling wait is necessary because cancelAgentRun() only initiates
cancellation (fires and forgets via void promise.catch()) and doesn't
wait for the pendingRun to be cleared.

Added E2E test "send_agent_prompt interrupts running agent and processes
new message" that verifies the fix works correctly.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 20:10:44 +07:00
Mohamed Boudra
d107ba0f0c Add E2E test for Claude agent streaming text integrity
Added test in daemon.e2e.test.ts that verifies server-side streaming
text is not garbled during Claude agent responses. Test passes - the
server emits clean, non-corrupted text chunks.

Investigation determined the reported garbled text bug is in the
React Native app rendering layer, not the server.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 19:50:03 +07:00
Mohamed Boudra
aea8a66112 Remove module-level SESSION_HISTORY Map from codex-mcp-agent.ts
Refactored history storage from module-level Map to instance-level
persistedHistory field. This fixes:
- Memory leak: sessions were never cleaned up from global Map
- Shared state: unrelated sessions could collide
- Restart handling: history now always loads from disk on resume

Changes:
- Removed SESSION_HISTORY Map (was at line 118)
- Constructor now sets historyPending=true for resume instead of
  looking up from global Map
- connect() always loads from disk when resuming
- recordHistory() appends to this.persistedHistory instead of Map
- flushPendingHistory() appends to this.persistedHistory instead of Map
- loadPersistedHistoryFromDisk() no longer populates global Map

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 19:26:28 +07:00
Mohamed Boudra
f22f76c56b Fix Codex MCP timeline persistence after daemon restart
When daemon restarts, SESSION_HISTORY is lost because it's an in-memory
Map. This fix adds disk-based timeline loading from Codex rollout files.

Changes:
- Add loadPersistedHistoryFromDisk() method to load from rollout files
- Add helper functions for finding and parsing rollout JSONL files
- Call disk loading in connect() when resumeHandle exists but SESSION_HISTORY is empty
- Add E2E test for timeline persistence across daemon restart

The rollout files are stored at ~/.codex/sessions/<date>/rollout-*.jsonl
and contain JSONL entries with response_item and event_msg types.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 19:14:51 +07:00
Mohamed Boudra
ab9c133d0e fix: allow null parentAgentId in agent schemas and projections 2025-12-25 18:51:18 +07:00
Mohamed Boudra
7b8d032bbc Add sendImages E2E tests for DaemonClient
Add two E2E tests that verify image attachment support in sendMessage():
- "sends message with image attachment to Claude agent" - tests single image
- "sends message with multiple image attachments" - tests multiple images

Tests use minimal 1x1 PNG base64 and verify:
- Server logs image attachments received
- Agent processes message and completes turn
- Assistant response is generated

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 18:24:29 +07:00
Mohamed Boudra
8a614aac58 Add listProviderModels() to DaemonClient + E2E tests
Add method to query available models for Claude and Codex providers without
requiring an active agent. E2E tests verify both providers return model lists
with expected structure (id, label, provider).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-25 18:20:37 +07:00