7 Commits

Include renames

Author	SHA1	Message	Date
Mohamed Boudra	308e9af845	Add reusable agent profiles (#3208) ... * Search models across all providers from the picker root * Store agent profiles in daemon config and apply agent config in one RPC An agent profile is a named bundle of provider, model, mode, thinking option, feature values and notes, stored host-wide next to terminal profiles. It carries no system prompt: AgentSessionConfig.systemPrompt is creation-only, so a profile holding one would apply when starting an agent and silently do nothing when applied to a running one. Applying a profile through the four single-field RPCs can fail halfway and leave an agent matching no profile, so agent.config.apply takes the whole bundle. Model runs first because a thinking option only means anything against the model that offers it. Old daemons parse their persisted config strictly and would drop an unknown agentProfiles key, making a save appear to succeed and vanish, so both capabilities are advertised on server_info for the client to gate on. list_profiles exposes the profiles to orchestrating agents, which read the notes to pick one and copy its values into create_agent. * Add the agent profiles settings section Profiles live behind one module boundary so removing the feature is a directory plus one mount, which is what favourites never was. The picker and composer will ask for rows and an apply function rather than learning what a profile contains. The edit form follows the form-model pattern instead of the terminal profile modal's per-field state, because provider selection cascades into which models, modes, thinking levels and features exist below it. The section is gated on server_info.features.agentProfiles: an older daemon drops the key on write, and a save that appears to work and then vanishes is worse than an unavailable state. * Document agent profiles and name the four senses of profile The glossary reserved Profile for HostProfile, terminal profiles owned the user-facing word, and custom-providers.md used it for provider aliases. Agent profile is now the term, with all four cross-referenced. data-model.md never documented terminalProfiles either, so both profile lists are backfilled together along with the whole-list patch semantics and why absent and empty differ. * Pin agent profiles to the model picker and delete favourites Applying a profile writes its values into the agent controls and is then forgotten, so rows carry no checkmark and no selected state: after applying, nothing is selected. Chevron still means navigate deeper, so the absence of one is what marks a row as an action. A running agent is its provider's process and agent.config.apply carries no provider, so the live picker only offers profiles matching the agent's provider rather than showing rows that cannot do what they say. The draft path has no such limit and switches provider freely. Draft feature values go through preferences rather than the feature callback alone, because the draft feature hook clears local values whenever the provider changes and a provider-switching profile would lose them. Favourites are deleted rather than migrated: they were device-local AsyncStorage keyed by provider and model, while profiles are host-wide daemon config. ProviderSelectionModelRow.favoriteKey stays as row identity and moves to its real owner; renaming it is its own commit. * Cover agent profiles and cross-provider search with E2E specs Model rows expressed selection only as a checkmark glyph, which assistive tech cannot see and a spec cannot assert. Rows that draw the indicator now carry aria-selected; profile rows deliberately carry none, because a profile is an action rather than a selection. That is what makes "nothing is marked selected after applying a profile" a real assertion instead of a tautology, with the materialized model one level down as the control. The search fixture extends claude rather than mock: provider-config.ts only allows the six shipped providers as extends targets, so a derived provider cannot inherit the dev-only mock provider. * State what applying a config bundle does on partial failure applyBundle is not a transaction and the earlier commit message implied it was. A step that rejects aborts the rest and the steps that already applied stay applied, which a profile omitting modelId can reach: provider setters validate against the agent's live model, so mode can land while a feature that model does not support is rejected. Nothing is hidden by that. Every setter emits agent state before returning, so what applied is streamed to the client next to the rejected response. Rolling back would re-invoke the setters that just failed, usually against a session that is gone, and pre-flight validation would restate each provider's model-dependent checks where they would drift from the setters that own them. What sending the bundle in one request removes is the multi-round-trip failure class: interruption between hops, and interleaving with another client. The test already pinned this behaviour; its name now says so. * feat(agent-profiles): refine profile discovery and appearance Make profiles discoverable from empty and provider-scoped model pickers, keep global search stable and virtualized, and move profile settings under Agents. Replace emoji identity with a shared Lucide icon and host-color picker, while requiring concrete provider selections so profiles materialize predictably. * fix(agent-profiles): defer profile swatch styles Resolving Unistyles proxies at module load can freeze the temporary startup color scheme before the persisted theme is restored. Keep only style-key names at module scope and resolve the selected swatch during render.	2026-08-11 17:42:35 +02:00
Mohamed Boudra	c352632b74	Launch a terminal instead of a chat from New workspace (#2941) ... * feat(app): launch a terminal from the New workspace screen New workspace only ever started a chat agent. Empty workspaces existed but were reachable only by submitting an empty composer, which nothing advertised, and terminals could not be started from this screen at all. People concluded Paseo did not support terminals. Adds a launch chip to the meta row, shaped from the same ComboboxTrigger as its neighbours, that chooses between Chat and a terminal. Terminal profiles mark where a typed prompt goes with a {{{prompt}}} sentinel in their command or args, substituted client-side before create_terminal_request, so the daemon learns nothing new and the protocol is untouched. A profile without the sentinel takes no input: the composer goes read-only and shows the exact command, so there is nothing to type wrong. Prompt forms come from each CLI's own --help. claude, codex, and pi take a trailing positional; opencode's positional is the project directory, so it uses --prompt=. Profiles predating the sentinel adopt the right form on read, keyed on the command's base name rather than the profile id, because profiles created in settings get generated ids. * fix(app): stop existing launchers passing the prompt sentinel literally Adoption made every caller of resolveTerminalProfiles see sentinel-bearing args, but only New workspace substituted them. Pinned targets and the workspace terminal menu forwarded profile.args straight through, so launching Claude from an existing workspace ran `claude "{{{prompt}}}"` with that text as the prompt. Every launcher now goes through resolveTerminalProfileLaunch. Surfaces with nowhere to type pass an empty prompt, which drops the prompt-only arg and gives back the bare command they had before. Also from the same review: - Adoption skipped when args lead with a subcommand. `opencode run` takes a positional message rather than --prompt, and `codex login` takes no prompt at all. Only the first arg is checked, so `pi --thinking high` still adopts. - Settings edits the persisted list again, not the adopted view. It writes the whole list back on any change, so resolving first baked read-time adoption into the user's config the moment they reordered a row. - A hidden draft no longer names a workspace. Text typed for a prompt-taking profile stayed in state after switching to a read-only one and still seeded the generated title and branch. - Windows .cmd escaping now has a round-trip test: a real cmd.exe runs a real .cmd shim that echoes its argv, covering metacharacters, an injection attempt, and newlines. The existing tests only asserted the command line we generate. - Fixed an ENOTEMPTY flake in the terminal suite. kill() only signals, so the shell was still writing into $ZDOTDIR while its directory was being removed. Cleanup waits for exit instead. * fix(app): keep the host and isolation accessible names stable Wiring the new tooltips also replaced these two accessible names with the tooltip copy, which broke `sidebar-project-grouping` at the host picker: its selector is `getByRole("button", { name: "Host", exact: true })` and the button had become "Choose the host". It timed out on both attempts in CI. An accessible name identifies a control; a tooltip explains it. Conflating them renamed a control that other surfaces address by name. The names go back to what they were and the tooltips keep the "Choose the ..." copy. * test(server): stop temp-dir teardown failing unrelated terminal tests The ENOTEMPTY flake survived both earlier attempts. Waiting for the session to exit shrank the window; retrying the remove did not close it either. The writes come from processes zsh forks on the way out, which outlive the pty and answer to nothing the test holds. Teardown is now best-effort and logs what it left behind. A temp directory we cannot remove is not a defect in the terminal code under test, and failing on it reports the race against whichever assertion ran last, which is exactly how this surfaced: as a flake in an unrelated zsh title test. 10 consecutive runs green. Also replaces a cast in the Windows .cmd helper with a real narrow, so a change to ResolvedTerminalCommand fails loudly there. Test files are excluded from typecheck (tsconfig.server.json), so a cast in one is never checked at all. * fix(app): keep terminal launch policy in its owning workflows Profile adoption now parses known global option values before deciding whether argv already contains a positional. Workspace naming is derived inside the terminal workflow so hidden launch-only drafts cannot affect branch or title generation. * fix(server): preserve cmd shim arguments through both parses npm command shims forward %*, so metacharacters lose one escape layer before the target process receives argv. Exercise the production node-pty string command line against a forwarding shim, and only tolerate the known ENOTEMPTY teardown race. * fix(server): stabilize Windows subprocess tests * test(server): isolate Windows argv recorder output * test(server): allow native watcher integration to settle	2026-08-07 14:08:22 +08:00
Mohamed Boudra	f2054cc701	Preserve Claude model and thinking preferences (#2912) ... * fix(agents): preserve Claude thinking selections Model switches now resolve thinking against the target model's saved preference instead of resetting to the catalog default. Claude owns its configured-model defaults and legacy Fable alias handling, while persisted permission modes remain unchanged. * chore(claude): tag Fable compatibility shim * fix(app): resolve persisted model aliases * fix(models): preserve aliases for older clients * fix(models): hide compatibility aliases from listings * fix(settings): hide compatibility model aliases * test(claude): cover legacy catalog entry * test(app): expect mock thinking controls in schedules * fix(app): preserve queued thinking preferences * fix(app): reconcile schedule provider snapshots * fix(app): preserve schedule model selections * fix(claude): preserve exact configured model ids * fix(app): preserve committed thinking preferences * fix(app): preserve aliased schedule thinking	2026-08-06 11:33:18 +02:00
Mohamed Boudra	d9cd6ea0fd	Keep composer mode preferences stable (#1658) ... * fix(app): preserve composer mode preferences Treat undefined provider preference updates as no-ops, and keep saved mode selections instead of silently defaulting them when provider metadata is incomplete or does not list the saved mode. * fix(app): document mode preference preservation	2026-06-23 09:22:26 +00:00
Mohamed Boudra	df18bbc43a	Migrate monorepo to Zod 4	2026-06-18 15:02:42 +08:00
Mohamed Boudra	7e5d7f7c67	Remember the New Workspace isolation choice ... The local/worktree choice was unstored component state and reset on every remount of the New Workspace screen (e.g. after creating a workspace). Persist it in the create-form preferences (FormPreferences.isolation). Also rename the app-layer "backing" to "isolation" to match its UI label. Isolation is the create-time intent; it stays distinct from workspaceKind, the git-derived persisted property, and the wire's source.kind.	2026-06-17 09:53:22 +07:00
Mohamed Boudra	d55e1622cb	Persist create-agent mode preferences reliably	2026-06-07 15:53:17 +07:00