- use recorderState.isRecording instead of recorderRef.current.isRecording
- avoid touching native shared object after it's been released
- fixes production crash: 'cannot cast to AudioRecorder (received Integer)'
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
- add shared useDictation hook to prevent double-stop races
- refactor modal + agent chat to consume shared API
- improve web recorder errors with secure-context messaging
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
fix: remove stale raw field expectation from test
The 'raw' field was removed from timeline entries in commit e80989e
(Nov 28) to reduce payload sizes by 64-85%. This test was never updated
and has been broken since then. Remove the stale expectation to align
with the current implementation.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This function was never called after implementing lazy-loading.
Agents are now loaded on-demand via ensureAgentLoaded when the UI
needs them, not eagerly at startup.
Keeping the unused function was confusing - it suggested eager
restoration was still the intended pattern.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
The previous agent claimed it removed the test skipping logic but
actually didn't - it hallucinated the fix. The file still had:
- const claudeIntegrationEnabled check
- describeClaudeIntegration conditional
- Warning message about skipping tests
This commit ACTUALLY removes all of it. Tests now run unconditionally.
All 14 tests pass ✓
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
The test was expecting the old 'files' array format, but after the refactor
to structured tool results (commit 4001b7d), Write tools now return:
{ type: 'file_write', filePath, oldContent, newContent }
Updated the test predicate to check for the new structure instead of the
old files array format.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Add stripAnsiSequences function to remove ANSI escape codes from terminal
output when includeColors is false. This ensures test assertions can match
against clean text without terminal formatting codes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
The test was failing because it was checking for tool data in a `raw` field
that no longer exists in the AgentToolCallData interface. The interface now
uses a `result` field instead of `raw`.
Updated all references from `snapshot.data.raw` to `snapshot.data.result` to
match the current AgentToolCallData structure defined in packages/app/src/types/stream.ts:
- Changed editTool search to use rawContainsText(snapshot.data.result, ...)
- Changed readTool search to use rawContainsText(snapshot.data.result, ...)
- Updated assertHydratedReplica callbacks to check data.result instead of data.raw
- Removed fallback checks for data.raw since that field doesn't exist
This appears to be a result of a refactoring where the `raw` field was renamed
to `result` in the AgentToolCallData interface, but the test wasn't updated to
match the new structure.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
The test was failing because it only checked for file changes in a
structured `output.files` array, but the actual implementation returns
file changes in different formats depending on the tool type.
The test now checks for file changes in two ways:
1. Structured `output.files` array (original check)
2. Structured tool outputs with `type: "file_write"` or `type: "file_edit"`
which include a `filePath` field
This matches how the claude-agent implementation structures tool results
in the `buildStructuredToolResult` method (lines 1081-1162), which creates
different output structures for file write/edit tools that include the
filePath directly in the output object rather than in a files array.
The test now properly detects when Claude creates files using either:
- Legacy file change tracking via output.files array
- Modern structured outputs for write_file/edit_file tools
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Add .agents.json.tmp-* pattern to gitignore and remove 82 temporary
agent files that were accidentally committed. These files are runtime
artifacts that should not be tracked in version control.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
The test was failing because terminal output wrapping caused "No such file"
to be split across lines with a newline between "No" and "such file". The
actual output was:
"No\n such file or directory"
Changed the assertion to check for more reliable parts of the error message:
- "cannot access" - always present in ls errors
- "nonexistent-directory-test" - the directory name we're testing with
This is a test assertion fix, not a code bug. The terminal output is correct,
but the test expectation needed to account for line wrapping.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
The 'raw' field was removed from timeline entries in commit e80989e
(Nov 28) to reduce payload sizes by 64-85%. This test was never updated
and has been broken since then. Remove the stale expectation to align
with the current implementation.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Remove AgentSnapshot from persistence layer. AgentRegistry now accepts
ManagedAgent and uses toStoredAgentRecord for atomic config + lifecycle
persistence. Deleted obsolete recordConfig method.
- Update applySnapshot to accept ManagedAgent and use toStoredAgentRecord
- Remove recordConfig method entirely (no longer needed)
- Remove sanitizeConfig helper (handled by projection)
- Update session to stop calling deleted recordConfig
- Add ManagedAgent test fixtures to registry and persistence-hook tests
- Test config persistence, title retention, and subscription forwarding
Registry and persistence-hooks now typecheck cleanly. Expected failures
in session/mcp-server/messages (still reference AgentSnapshot).
Task 4 of 8 in agent architecture refactor.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Replace ManagedAgent with discriminated union keyed on lifecycle state
to make impossible states unrepresentable. Remove AgentSnapshot type
and toSnapshot method entirely - consumers now receive ManagedAgent
directly.
- Define ManagedAgent as discriminated union with 5 lifecycle states
- Add comprehensive immutability protection (deep clone + freeze)
- Update getAgent/listAgents to return immutable ManagedAgent views
- Remove AgentSnapshot type and toSnapshot method
- Update event emissions to use ManagedAgent
Breaking change: All consumers must now use ManagedAgent or projection
functions instead of AgentSnapshot.
Tasks 2 & 3 of 8 in agent architecture refactor.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Introduce toStoredAgentRecord and toAgentPayload as deterministic
pure functions to project ManagedAgent state to persistence and
client payload formats. This eliminates the need for AgentSnapshot
as an intermediate representation.
- Add toStoredAgentRecord for persistence projection
- Add toAgentPayload for client communication projection
- Add comprehensive test suite covering all lifecycle states
- Handle optionality at boundaries with proper null/undefined semantics
Task 1 of 8 in agent architecture refactor.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
- recordConfig no longer writes lastStatus (handled by applySnapshot only)
- Add warning if recordConfig called before snapshot exists
- Update tests to reflect new separation of concerns
- Add AGENT_REFACTOR_PROPOSAL.md with comprehensive design plan
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
1. Lazy agent loading - fix race condition where prompts sent before initialization completes:
- Add ensureAgentLoaded() helper that deduplicates initialization requests
- Update handleSendAgentMessage/Audio to await agent initialization before streaming
- Fix status updates being sent to client after initialization
2. Type safety - remove unsafe 'as any' casts for agent status:
- Create AGENT_LIFECYCLE_STATUSES constant as single source of truth
- Export AgentStatusSchema from messages.ts for reuse
- Update registry schema to validate lastStatus against AgentStatusSchema
- Add .default("closed") to handle missing status values from legacy files
- Remove (record.lastStatus as any) cast in buildStoredAgentPayload
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Remove blocking restorePersistedAgents() call that was resuming all 87
agents before opening the HTTP socket. The architecture already supports
lazy loading through handleInitializeAgentRequest() - agents are shown
in the UI from the registry and only initialized when clients request them.
This eliminates:
- Sequential thread resumes with network handshakes to Codex/Claude
- Synchronous history file reads from disk
- DNS lookups and model catalog fetches
- 87 awaited operations before socket binding
Server now starts immediately by just loading the lightweight agents.json
registry. Agents resume on-demand when requested by clients.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Previously shared one McpServer instance across all sessions/transports,
which caused Protocol._transport to be overwritten when new sessions
connected. This broke message routing for requests on previous transports
after long-running SSE streams.
Now creates a new McpServer instance per session, following the stateful
session pattern from the MCP SDK documentation. Each session gets its own
server+transport pair, preventing transport reference conflicts.
Fixes issue where get_agent_status would fail after wait_for_agent completed.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This fixes two root causes of MCP tool calls hanging indefinitely:
1. Transform ensureValidJson from validator to transformer
- Previously threw errors on undefined values, causing handlers to crash
- Now converts undefined→null, Date→ISO string, bigint→string, etc.
- Ensures all MCP handlers always return valid JSON responses
2. Cancel waitTracker when interrupting agents
- Added waitTracker.cancel() in cancel_agent handler
- Added waitTracker.cancel() in kill_agent handler
- Resolves waiting wait_for_agent promises when agents are interrupted
- Prevents indefinite hangs requiring server restart
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
ToolCall component had parsedEditEntries, parsedReadEntries, and
parsedCommandDetails props defined but never used them. Now prefers
these pre-parsed props when available, enabling Codex apply_patch
diffs to render correctly in the expanded view.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Add structured output matching StructuredToolResult type for Codex
apply_patch operations when parsing rollout files. This enables the
frontend to render file edit diffs for restored Codex sessions, matching
the behavior of Claude agent file edits.
Note: For live streaming, the Codex SDK only provides file_change events
with {path, kind} without actual patch content. The structured diffs are
only available for restored sessions via rollout file parsing.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Codex SDK uses aggregated_output and exit_code fields for command
execution results (not output). Build structured output matching
StructuredToolResult type so frontend renders Codex commands the
same way as Claude commands.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Remove all heuristic parsing code from message.tsx (hasCommandDetails,
commandSection, editSections, readSections, hasStructuredContent, etc.)
- Replace with simple raw JSON fallback for tools without structured results
- Fix server-side support for Claude SDK's old_string/new_string params
(in addition to old_str/new_str)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Server-side:
- Add StructuredToolResult discriminated union type with command, file_write,
file_edit, file_read, and generic variants
- Implement buildStructuredToolResult in claude-agent.ts to detect tool types
and emit properly structured results
- Update codex-agent.ts to emit structured command results
Client-side:
- Add type guard and extraction functions for structured results
- Render tool calls based on result.type when available:
- command: show command, output, exit code
- file_write/file_edit: show diff viewer with proper +/- format
- file_read: show file content
- generic: show raw JSON
- Fall back to heuristic parsing for backwards compatibility
This fixes file writes showing as "Command: success message" - they now
properly show as diffs with +line additions.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
