1 Commits

Author	SHA1	Message	Date
Matt Cowger	9ea58aae0c	fix(server): stop OpenCode daemon crash on session close, fix #2014 (#2027) ... * fix(server): patch OpenCode SDK unhandled rejection on stream abort The SDK's SSE abort handler calls reader.cancel() without handling its rejection. When Paseo aborts the event stream during normal session close, that promise can reject and crash the daemon with an unhandled rejection outside any Paseo-owned code path. Patches both copies the SDK ships (dist/gen and dist/v2/gen, the latter being what Paseo actually imports). Extends postinstall-patches.mjs to support patch-package running from a non-root cwd, since @opencode-ai/sdk lives in packages/server's own node_modules rather than the hoisted root. * fix(server): stop assuming OpenCode's default agent is "build" OpenCode users can rename or delete any agent, including the built-in "build"/"plan" defaults. Paseo was injecting a hardcoded "build" agent in several places whenever no mode was explicitly requested: - The protocol manifest declared defaultModeId: "build" for opencode, which AgentManager.normalizeConfig applied to every session (including internal metadata-generation sessions) before any provider-level logic ran. - OpenCode's own normalizeOpenCodeModeId defaulted an empty/"default" modeId to "build" rather than omitting the agent field. - Unattended child creates (e.g. subagents spawned by an unattended parent) forced modeId: "build" to express unattendedness, even though that's already carried by the auto_accept feature. Now an unset mode stays unset end-to-end: the "agent" field is omitted from OpenCode prompt/command calls entirely, letting OpenCode fall back to its own configured default agent instead of Paseo guessing one that may not exist. * fix(server): validate agent create mode on the WebSocket session path resolveAndValidateCreateAgentMode already rejects modes unknown to a provider's discovered mode list, but it was only wired into the MCP create path. App-created agents (create_agent_request) skipped it entirely, so a client's remembered mode preference — which can go stale when a user renames or deletes OpenCode agents — sailed through to the provider and failed mid-turn with an opaque error instead of a clear rejection at creation time. resolveSessionCreateAgent now calls providerSnapshotManager.resolveCreateConfig, matching the MCP path, so an invalid mode now throws 'Invalid mode ... Available modes: ...' immediately on create. * chore: address review feedback on create-agent and postinstall script - Document the cleanup-ordering constraint in resolveSessionCreateAgent: mode validation runs after buildSessionConfig (cwd isn't known until that completes), so a thrown validation error leaves any worktree/workspace buildSessionConfig created for the caller to clean up. session.ts already handles this for the worktree path; the directory-only workspace path has a pre-existing gap, not introduced by this validation. - Log spawn errors from patch-package in postinstall-patches.mjs (e.g. ENOENT if it's missing from PATH) instead of failing silently. * fix(server): don't fabricate OpenCode modes when discovery finds none fetchModesFromClient and mergeOpenCodeModes fell back to DEFAULT_MODES ([build, plan]) whenever OpenCode discovery returned nothing — e.g. for a freshly-created worktree whose OpenCode server hasn't loaded the project config yet. That fabricated list let create-time mode validation accept a stale 'plan' preference that the provider then rejects at prompt time (Agent not found: 'plan'). Return an empty list instead: OpenCode users can rename or delete any agent, so any hardcoded fallback risks validating a mode that doesn't exist. DEFAULT_MODES is retained only for description enrichment and sort ordering. * fix(app): reconcile stale selected mode against discovered modes on create The mode picker displays modeOptions[0] when the stored modeId isn't in the discovered list (e.g. a globally-remembered 'plan' that a workspace's OpenCode config no longer defines), but the create request still submitted the raw stored modeId. Result: UI showed 'Build' while the request sent 'plan', which the daemon then rejected. Reconcile the selected mode against the discovered mode ids when building the create config (both the workspace draft composer and the workspace-setup dialog), so the submitted mode matches what the picker shows — falling back to the first available mode when the stored one is absent. Mirrors the existing resolveEffectiveModel reconciliation for models. * test(server): fix opencode mode tests after fallback change + rebase - Replace 'available modes include build and plan' (which relied on the removed [build, plan] discovery-failure fallback) with two tests: one asserting discovered agents map to modes, one asserting empty discovery yields no fabricated modes. - Restore messageId fields in the four provider-subagent timeline assertions. These were accidentally dropped during rebase conflict resolution; the #2013 subagent code legitimately emits messageId, so the expectations must include it. * test(app): fix e2e seed helper using invalid opencode mode createIdleAgent seeded an OpenCode agent with modeId 'bypassPermissions' — a Claude mode OpenCode never had. This worked before only because the session create path silently coerced unknown modes to 'build'. Now that create-time mode validation rejects modes the provider doesn't define, use 'build' + auto_accept (OpenCode's unattended full-access equivalent), matching the rewind-flow helper. Fixes the e2e failures across archive-tab, command-center-host, settings-toggle-tab-regression, workspace-agent-tab-rename, workspace-pane-remount, workspace-navigation-regression, and worktree-restore specs, which all seed via this helper.	2026-07-14 19:00:53 +08:00