From fc214b20f1d4427860c7e8f4c0e406799fd417c2 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Sat, 22 Aug 2026 23:32:05 +0200 Subject: [PATCH] test(app): align new tab launcher expectations --- packages/app/e2e/browser/empty-pane-keyboard.spec.ts | 8 ++++++-- packages/app/e2e/browser/launcher-tab.spec.ts | 8 ++++---- packages/app/e2e/browser/side-panel.spec.ts | 2 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/packages/app/e2e/browser/empty-pane-keyboard.spec.ts b/packages/app/e2e/browser/empty-pane-keyboard.spec.ts index 2f8ecefafe..1eb3d66e5a 100644 --- a/packages/app/e2e/browser/empty-pane-keyboard.spec.ts +++ b/packages/app/e2e/browser/empty-pane-keyboard.spec.ts @@ -50,7 +50,7 @@ test.describe("New tab keyboard launcher", () => { } }); - test("a new split pane focuses its launcher and wraps arrow navigation", async ({ page }) => { + test("a new split pane focuses its launcher and supports arrow navigation", async ({ page }) => { const workspace = await seedWorkspace({ repoPrefix: "empty-pane-split-keyboard-" }); try { @@ -60,8 +60,12 @@ test.describe("New tab keyboard launcher", () => { const launcher = visibleNewTabPanel(page); await expect(launcher).toBeVisible({ timeout: 30_000 }); - await expectLauncherSelection(launcher, "Changes"); + await expectLauncherSelection(launcher, "Agent"); + await page.keyboard.press("ArrowDown"); + await expectLauncherSelection(launcher, "Terminal"); + await page.keyboard.press("ArrowDown"); + await expectLauncherSelection(launcher, "Changes"); await page.keyboard.press("ArrowDown"); await expectLauncherSelection(launcher, "Files"); await page.keyboard.press("Enter"); diff --git a/packages/app/e2e/browser/launcher-tab.spec.ts b/packages/app/e2e/browser/launcher-tab.spec.ts index f7011c1a59..f4c9093f37 100644 --- a/packages/app/e2e/browser/launcher-tab.spec.ts +++ b/packages/app/e2e/browser/launcher-tab.spec.ts @@ -172,16 +172,16 @@ test.describe("Tab creation", () => { await expect(terminal).toContainText(new RegExp(`${shortcutPrefix.source}.*T`)); await expect(changes).toContainText(new RegExp(`${shortcutPrefix.source}.*G`)); await expect(files).toContainText(new RegExp(`${shortcutPrefix.source}.*E`)); - await expect(changes).toBeFocused(); + await expect(agent).toBeFocused(); await page.keyboard.press("ArrowDown"); - await expect(files).toBeFocused(); + await expect(terminal).toBeFocused(); await page.keyboard.press("ArrowUp"); - await expect(changes).toBeFocused(); + await expect(agent).toBeFocused(); await page.locator("body").click({ position: { x: 1, y: 1 } }); await panel.click({ position: { x: 20, y: 20 } }); - await expect(changes).toBeFocused(); + await expect(agent).toBeFocused(); }); test("clicking new agent tab creates a draft tab", async ({ page }) => { diff --git a/packages/app/e2e/browser/side-panel.spec.ts b/packages/app/e2e/browser/side-panel.spec.ts index 45920114ef..879ec5b677 100644 --- a/packages/app/e2e/browser/side-panel.spec.ts +++ b/packages/app/e2e/browser/side-panel.spec.ts @@ -68,8 +68,8 @@ test.describe("Side panel", () => { expect((await launcherButtonLabels(launcher)).slice(0, 4)).toEqual([ "Changes", "Files", - "Agent", "Terminal", + "Agent", ]); await expect(page.getByTestId("workspace-tab-working_diff")).toHaveCount(0); await capture(page, testInfo, "01-side-panel-reveals-empty");