diff --git a/packages/app/src/terminal/runtime/terminal-emulator-runtime.browser.test.ts b/packages/app/src/terminal/runtime/terminal-emulator-runtime.browser.test.ts
index baa6ae350..0a94f699b 100644
--- a/packages/app/src/terminal/runtime/terminal-emulator-runtime.browser.test.ts
+++ b/packages/app/src/terminal/runtime/terminal-emulator-runtime.browser.test.ts
@@ -15,6 +15,7 @@ interface TerminalSize {
rows: number;
cols: number;
shouldClaim: boolean;
+ forceClaim?: boolean;
}
interface TerminalKeyRecord {
@@ -26,6 +27,7 @@ interface TerminalKeyRecord {
}
type BrowserTerminal = TerminalSize & {
+ input: (data: string, wasUserInput?: boolean) => void;
refresh: (start: number, end: number) => void;
reset: () => void;
};
@@ -233,6 +235,22 @@ describe("terminal emulator runtime in a real browser", () => {
expect(grownSize.shouldClaim).toBe(true);
});
+ it("does not claim a resize while forwarding ordinary terminal input", async () => {
+ await page.viewport(900, 600);
+ const mounted = createTerminalHost({ width: 720, height: 360 });
+
+ await waitFor({ predicate: () => mounted.sizes.length > 0 });
+ const sizeCount = mounted.sizes.length;
+ const terminal = getBrowserTerminal();
+
+ terminal.input("a", true);
+
+ await waitFor({ predicate: () => mounted.inputs.length > 0 });
+
+ expect(mounted.inputs.at(-1)).toBe("a");
+ expect(mounted.sizes).toHaveLength(sizeCount);
+ });
+
it("refreshes visible rows on a forced same-size resize", async () => {
await page.viewport(900, 600);
const mounted = createTerminalHost({ width: 720, height: 360 });
@@ -318,6 +336,27 @@ describe("terminal emulator runtime in a real browser", () => {
meta: false,
},
]);
+
+ const sizeCount = mounted.sizes.length;
+ mounted.terminalKeys.length = 0;
+
+ dispatchTerminalKey({
+ host: mounted.host,
+ key: "Enter",
+ shiftKey: true,
+ });
+ await nextFrame();
+
+ expect(mounted.terminalKeys).toEqual([
+ {
+ key: "Enter",
+ ctrl: false,
+ shift: true,
+ alt: false,
+ meta: false,
+ },
+ ]);
+ expect(mounted.sizes).toHaveLength(sizeCount);
});
it.each([
diff --git a/packages/app/src/terminal/runtime/terminal-emulator-runtime.ts b/packages/app/src/terminal/runtime/terminal-emulator-runtime.ts
index d2d608d10..07fecd23e 100644
--- a/packages/app/src/terminal/runtime/terminal-emulator-runtime.ts
+++ b/packages/app/src/terminal/runtime/terminal-emulator-runtime.ts
@@ -394,7 +394,6 @@ export class TerminalEmulatorRuntime {
if (this.suppressInput) {
return;
}
- this.fitAndEmitResize?.({ force: true, shouldClaim: true });
this.callbacks.onInput?.(data);
});
@@ -454,7 +453,6 @@ export class TerminalEmulatorRuntime {
altKey: event.altKey,
metaKey: event.metaKey,
});
- this.fitAndEmitResize?.({ force: true, shouldClaim: true });
this.callbacks.onTerminalKey?.({
key: normalizeTerminalTransportKey(normalizedKey),
...modifiers,
diff --git a/packages/app/src/terminal/webview/terminal-emulator-webview-html.ts b/packages/app/src/terminal/webview/terminal-emulator-webview-html.ts
index 89a80730d..4e6b219d5 100644
--- a/packages/app/src/terminal/webview/terminal-emulator-webview-html.ts
+++ b/packages/app/src/terminal/webview/terminal-emulator-webview-html.ts
@@ -2,4 +2,4 @@
// Do not edit by hand.
export const terminalEmulatorWebViewHtml =
- '\n\n \n \n \n \n \n \n \n';
+ '\n\n \n \n \n \n \n \n \n';