From d6c3896fd97455772840026926f3bc6b0c9c184d Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Sun, 3 May 2026 15:38:01 +0700 Subject: [PATCH] Update test mocks for new serviceUrlBehavior setting f58cfe9 (Open script service URLs in-app or external) added serviceUrlBehavior to AppSettings and a new useDropdownMenuClose export from dropdown-menu. The unit tests were not updated: - use-settings.test.ts: expected settings objects missed the new serviceUrlBehavior field. - workspace-scripts-button.test.tsx: dropdown-menu mock missed useDropdownMenuClose, breaking HostLinkRow render. --- packages/app/src/hooks/use-settings.test.ts | 4 ++++ .../src/screens/workspace/workspace-scripts-button.test.tsx | 1 + 2 files changed, 5 insertions(+) diff --git a/packages/app/src/hooks/use-settings.test.ts b/packages/app/src/hooks/use-settings.test.ts index a4494c8e3..ec1b14bd9 100644 --- a/packages/app/src/hooks/use-settings.test.ts +++ b/packages/app/src/hooks/use-settings.test.ts @@ -86,6 +86,7 @@ describe("use-settings", () => { theme: "light", manageBuiltInDaemon: true, sendBehavior: "interrupt", + serviceUrlBehavior: "ask", releaseChannel: "stable", }); }); @@ -128,6 +129,7 @@ describe("use-settings", () => { expect(result).toEqual({ theme: "dark", sendBehavior: "interrupt", + serviceUrlBehavior: "ask", }); expect(asyncStorageMock.setItem).toHaveBeenCalledWith( mod.APP_SETTINGS_KEY, @@ -166,6 +168,7 @@ describe("use-settings", () => { expect(result).toEqual({ theme: "light", sendBehavior: "interrupt", + serviceUrlBehavior: "ask", manageBuiltInDaemon: false, releaseChannel: "beta", }); @@ -184,6 +187,7 @@ describe("use-settings", () => { expect(result).toEqual({ theme: "light", sendBehavior: "interrupt", + serviceUrlBehavior: "ask", manageBuiltInDaemon: true, releaseChannel: "stable", }); diff --git a/packages/app/src/screens/workspace/workspace-scripts-button.test.tsx b/packages/app/src/screens/workspace/workspace-scripts-button.test.tsx index 4eb8f10b7..54bbcacf0 100644 --- a/packages/app/src/screens/workspace/workspace-scripts-button.test.tsx +++ b/packages/app/src/screens/workspace/workspace-scripts-button.test.tsx @@ -107,6 +107,7 @@ vi.mock("@/components/ui/dropdown-menu", () => ({ : children} ), + useDropdownMenuClose: () => () => {}, })); vi.mock("lucide-react-native", () => {