From d64d45a00ba542bc6dd79ca8bc381b613cad0e01 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Fri, 20 Nov 2026 15:25:40 +0100 Subject: [PATCH] fix(website): preserve focus and labels in Hub showcase tabs --- packages/website/e2e/hub.spec.ts | 31 +++++++++++++++++-- .../hub-automations-showcase.tsx | 19 +++++++----- 2 files changed, 39 insertions(+), 11 deletions(-) diff --git a/packages/website/e2e/hub.spec.ts b/packages/website/e2e/hub.spec.ts index 3ca49604b5..0cce404236 100644 --- a/packages/website/e2e/hub.spec.ts +++ b/packages/website/e2e/hub.spec.ts @@ -1,11 +1,24 @@ -import { expect, test, type Page } from "./fixtures"; +import { expect, test, waitForHydration, type Page } from "./fixtures"; -async function openHub(page: Page) { - await page.setViewportSize({ width: 1024, height: 900 }); +async function openHub(page: Page, width = 1024) { + await page.setViewportSize({ width, height: 900 }); await page.goto("/hub"); await expect(page.getByRole("heading", { name: "Paseo Hub", level: 1 })).toBeVisible(); } +async function tabIntoNextPreview(page: Page) { + await waitForHydration(page); + await page.getByRole("tab", { name: /^Slack/ }).focus(); + await page.keyboard.press("ArrowRight"); + await page.keyboard.press("Tab"); +} + +async function expectSourceLabelFits(page: Page, name: string) { + const label = page.getByRole("tab", { name }).getByText(name, { exact: true }); + await expect(label).toBeVisible(); + expect(await label.evaluate((element) => element.scrollWidth <= element.clientWidth)).toBe(true); +} + async function focusProSeatHelp(page: Page) { const pro = page .getByRole("article") @@ -40,3 +53,15 @@ test("the Slack starter forwards the mention and declares a thread reply", async await expect(starter).toContainText("hub.reply"); await expect(starter).toContainText("slack.reply:"); }); + +test("keyboard focus enters the selected preview during its transition", async ({ page }) => { + await openHub(page); + await tabIntoNextPreview(page); + await expect(page.getByRole("tabpanel", { name: /^GitHub/ })).toBeFocused(); +}); + +test("source names fit on a narrow phone", async ({ page }) => { + await openHub(page, 320); + await expectSourceLabelFits(page, "Schedules"); + await expectSourceLabelFits(page, "Webhooks"); +}); diff --git a/packages/website/src/components/hub-automations/hub-automations-showcase.tsx b/packages/website/src/components/hub-automations/hub-automations-showcase.tsx index 5e43f9e4c0..d1595e6ef2 100644 --- a/packages/website/src/components/hub-automations/hub-automations-showcase.tsx +++ b/packages/website/src/components/hub-automations/hub-automations-showcase.tsx @@ -45,6 +45,7 @@ const PANEL_ANIMATE = { opacity: 1, y: 0 } as const; const PANEL_EXIT = { opacity: 0, y: -4 } as const; const PANEL_TRANSITION = { duration: 0.16, ease: "easeOut" } as const; const STAGE_IN_VIEW_OPTIONS = { once: true, margin: "-60px" } as const; +const PANEL_ID = "hub-source-panel"; /** * Interactive split showcase for Paseo Hub automation sources: @@ -92,7 +93,7 @@ export function HubAutomationsShowcase() {
{SHOWCASE_SOURCES.map((source, index) => (
-
+
@@ -185,7 +188,7 @@ function SourceTabButton({ role="tab" id={`hub-source-tab-${id}`} aria-selected={isSelected} - aria-controls={`hub-source-panel-${id}`} + aria-controls={PANEL_ID} tabIndex={isSelected ? 0 : -1} onClick={handleClick} onKeyDown={handleKeyDown}