From d1dc6259ca83cce5ea1eb344df60a524acc37e97 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Fri, 24 Apr 2026 05:18:07 +0700 Subject: [PATCH] chore(lint): no-shadow in app test hoisted blocks --- packages/app/e2e/helpers/startup-dsl.ts | 9 +++------ .../src/components/attachment-lightbox.test.tsx | 8 ++++---- packages/app/src/hooks/use-agent-history.test.tsx | 6 +++--- .../src/hooks/use-checkout-status-query.test.ts | 14 +++++++------- .../app/src/hooks/use-providers-snapshot.test.ts | 12 ++++++------ 5 files changed, 23 insertions(+), 26 deletions(-) diff --git a/packages/app/e2e/helpers/startup-dsl.ts b/packages/app/e2e/helpers/startup-dsl.ts index 72c5b4e2f..9c84cbf23 100644 --- a/packages/app/e2e/helpers/startup-dsl.ts +++ b/packages/app/e2e/helpers/startup-dsl.ts @@ -106,18 +106,15 @@ class StartupScenario { const createAgentPreferences = buildStoredCreateAgentPreferences(firstHost.serverId); await this.page.evaluate( - ({ keys, registry, createAgentPreferences }) => { + ({ keys, registry: storedRegistry, createAgentPreferences: storedPreferences }) => { const nonce = localStorage.getItem(keys.seedNonce); if (!nonce) { throw new Error("Expected e2e seed nonce before overriding startup registry."); } localStorage.setItem(keys.e2e, "1"); - localStorage.setItem(keys.registry, JSON.stringify(registry)); - localStorage.setItem( - "@paseo:create-agent-preferences", - JSON.stringify(createAgentPreferences), - ); + localStorage.setItem(keys.registry, JSON.stringify(storedRegistry)); + localStorage.setItem("@paseo:create-agent-preferences", JSON.stringify(storedPreferences)); localStorage.setItem(keys.disableDefaultSeedOnce, nonce); }, { diff --git a/packages/app/src/components/attachment-lightbox.test.tsx b/packages/app/src/components/attachment-lightbox.test.tsx index 64f947f87..3fe044c72 100644 --- a/packages/app/src/components/attachment-lightbox.test.tsx +++ b/packages/app/src/components/attachment-lightbox.test.tsx @@ -7,7 +7,7 @@ import type { AttachmentMetadata } from "@/attachments/types"; import { AttachmentLightbox } from "./attachment-lightbox"; const { theme, imageMetadata, useAttachmentPreviewUrlMock } = vi.hoisted(() => { - const theme = { + const hoistedTheme = { spacing: { 1: 4, 2: 8, 3: 12, 4: 16 }, iconSize: { sm: 14, md: 18, lg: 22 }, borderWidth: { 1: 1 }, @@ -24,7 +24,7 @@ const { theme, imageMetadata, useAttachmentPreviewUrlMock } = vi.hoisted(() => { }, }; - const imageMetadata: AttachmentMetadata = { + const hoistedImageMetadata: AttachmentMetadata = { id: "img-1", mimeType: "image/png", storageType: "web-indexeddb", @@ -35,8 +35,8 @@ const { theme, imageMetadata, useAttachmentPreviewUrlMock } = vi.hoisted(() => { }; return { - theme, - imageMetadata, + theme: hoistedTheme, + imageMetadata: hoistedImageMetadata, useAttachmentPreviewUrlMock: vi.fn<(metadata: AttachmentMetadata | null) => string | null>( () => "blob:preview", ), diff --git a/packages/app/src/hooks/use-agent-history.test.tsx b/packages/app/src/hooks/use-agent-history.test.tsx index 6a4d2b258..23b25f602 100644 --- a/packages/app/src/hooks/use-agent-history.test.tsx +++ b/packages/app/src/hooks/use-agent-history.test.tsx @@ -14,13 +14,13 @@ import { useSessionStore, type Agent } from "@/stores/session-store"; import { useAgentHistory } from "./use-agent-history"; const { mockClient, mockRuntimeStore } = vi.hoisted(() => { - const mockClient = { + const hoistedClient = { fetchAgentHistory: vi.fn(), }; - const mockRuntimeStore = { + const hoistedRuntimeStore = { refreshAgentDirectory: vi.fn(), }; - return { mockClient, mockRuntimeStore }; + return { mockClient: hoistedClient, mockRuntimeStore: hoistedRuntimeStore }; }); vi.mock("@/runtime/host-runtime", () => ({ diff --git a/packages/app/src/hooks/use-checkout-status-query.test.ts b/packages/app/src/hooks/use-checkout-status-query.test.ts index 17026bb2b..6db41f3e4 100644 --- a/packages/app/src/hooks/use-checkout-status-query.test.ts +++ b/packages/app/src/hooks/use-checkout-status-query.test.ts @@ -14,25 +14,25 @@ import { checkoutStatusQueryKey, useCheckoutStatusQuery } from "./use-checkout-s type CheckoutStatusPayload = CheckoutStatusResponse["payload"]; const { mockRuntime, mockClient, checkoutStatusUpdateHandlers } = vi.hoisted(() => { - const checkoutStatusUpdateHandlers = new Set<(message: unknown) => void>(); - const mockClient = { + const hoistedHandlers = new Set<(message: unknown) => void>(); + const hoistedClient = { getCheckoutStatus: vi.fn(), on: vi.fn((type: string, handler: (message: unknown) => void) => { if (type !== "checkout_status_update") { return () => {}; } - checkoutStatusUpdateHandlers.add(handler); + hoistedHandlers.add(handler); return () => { - checkoutStatusUpdateHandlers.delete(handler); + hoistedHandlers.delete(handler); }; }), }; return { - mockClient, - checkoutStatusUpdateHandlers, + mockClient: hoistedClient, + checkoutStatusUpdateHandlers: hoistedHandlers, mockRuntime: { - client: mockClient, + client: hoistedClient, isConnected: true, }, }; diff --git a/packages/app/src/hooks/use-providers-snapshot.test.ts b/packages/app/src/hooks/use-providers-snapshot.test.ts index ce8b9c6e3..abfca7c1e 100644 --- a/packages/app/src/hooks/use-providers-snapshot.test.ts +++ b/packages/app/src/hooks/use-providers-snapshot.test.ts @@ -28,22 +28,22 @@ interface ProvidersSnapshot { type HookResult = ReturnType["result"]; const { mockClient, mockRuntime, snapshotUpdateListeners } = vi.hoisted(() => { - const snapshotUpdateListeners: ProviderSnapshotUpdateListener[] = []; - const mockClient = { + const hoistedListeners: ProviderSnapshotUpdateListener[] = []; + const hoistedClient = { getProvidersSnapshot: vi.fn(), refreshProvidersSnapshot: vi.fn(), on: vi.fn((_event: string, listener: ProviderSnapshotUpdateListener) => { - snapshotUpdateListeners.push(listener); + hoistedListeners.push(listener); return () => {}; }), }; return { - mockClient, + mockClient: hoistedClient, mockRuntime: { - client: mockClient, + client: hoistedClient, isConnected: true, }, - snapshotUpdateListeners, + snapshotUpdateListeners: hoistedListeners, }; });