From b93afb915624efc2f706334737527c93b583ca7a Mon Sep 17 00:00:00 2001 From: "paseo-bot[bot]" <266920839+paseo-bot[bot]@users.noreply.github.com> Date: Thu, 19 Nov 2026 02:07:12 +0000 Subject: [PATCH] test(server): read a turn larger than the message limit through the daemon Opening a chat whose newest turn is larger than the 100 MiB message limit never showed its history. The daemon built one reply for the complete turn, the outbound transport refused it with "Logical message too large", and the app waited until its request timed out. This test fills one turn with about 105 MiB of replies and reads it as the app does: a whole-turn tail page of 40 items, then older pages until the start. On main the first request gets no reply within 20 s. With the frame-budget fallback, every reply arrives and the pages reach the start of the turn. The test runs in test:integration so CI covers it. Refs #8458 Co-authored-by: AnalyticETH Co-Authored-By: Claude Opus 5.5 --- packages/server/package.json | 2 +- .../oversized-whole-turn.e2e.test.ts | 64 +++++++++++++++++++ 2 files changed, 65 insertions(+), 1 deletion(-) create mode 100644 packages/server/src/server/daemon-e2e/oversized-whole-turn.e2e.test.ts diff --git a/packages/server/package.json b/packages/server/package.json index c04e5e6902..a04a371c52 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -90,7 +90,7 @@ "speech:transcribe:local": "tsx scripts/transcribe-local-wav.ts", "test": "npm run test:unit && npm run test:integration", "test:unit": "vitest run --fileParallelism --exclude \"**/*.e2e.test.ts\"", - "test:integration": "vitest run --maxWorkers=1 src/server/git-filename-diffs.e2e.test.ts src/server/daemon-e2e/checkout-diff-content.e2e.test.ts src/server/daemon-e2e/create-agent-mode.e2e.test.ts src/server/daemon-e2e/filesystem.e2e.test.ts src/server/daemon-e2e/file-download.e2e.test.ts src/server/daemon-e2e/cli-logs-follow.e2e.test.ts src/server/creation/creation.e2e.test.ts src/server/daemon-e2e/creation-status.e2e.test.ts src/server/daemon-e2e/persisted-creation-caller.e2e.test.ts src/server/daemon-e2e/terminal-workspace-sdk.e2e.test.ts src/server/daemon-e2e/terminal-worker-lifecycle.e2e.test.ts src/server/workspace-create-worktree-source.e2e.test.ts src/server/daemon-e2e/models.e2e.test.ts src/server/daemon-e2e/live-preferences.e2e.test.ts src/server/daemon-e2e/oversized-message.e2e.test.ts src/server/agent/model-catalog.e2e.test.ts src/server/plugins/plugin-paseo-api.e2e.test.ts src/server/plugins/usage-sources.e2e.test.ts src/server/plugins/lifecycle.e2e.test.ts src/server/connected-hosts/hosts.e2e.test.ts src/server/owned-subscriptions.e2e.test.ts && vitest run --maxWorkers=1 src/server/agent/providers/omp/history.e2e.test.ts src/server/daemon-e2e/git-operations.e2e.test.ts src/server/session.create-agent-worktree-autoarchive.e2e.test.ts src/server/agent/providers/opencode-bridge.local.e2e.test.ts src/server/daemon-e2e/relay-transport.e2e.test.ts -t \"merges into|creates a worktree and auto-archives both|versioned runtime|oversized attachments|connected hosts|password-protected daemon refuses|replays selected OMP history\"", + "test:integration": "vitest run --maxWorkers=1 src/server/git-filename-diffs.e2e.test.ts src/server/daemon-e2e/checkout-diff-content.e2e.test.ts src/server/daemon-e2e/create-agent-mode.e2e.test.ts src/server/daemon-e2e/filesystem.e2e.test.ts src/server/daemon-e2e/file-download.e2e.test.ts src/server/daemon-e2e/cli-logs-follow.e2e.test.ts src/server/creation/creation.e2e.test.ts src/server/daemon-e2e/creation-status.e2e.test.ts src/server/daemon-e2e/persisted-creation-caller.e2e.test.ts src/server/daemon-e2e/terminal-workspace-sdk.e2e.test.ts src/server/daemon-e2e/terminal-worker-lifecycle.e2e.test.ts src/server/workspace-create-worktree-source.e2e.test.ts src/server/daemon-e2e/models.e2e.test.ts src/server/daemon-e2e/live-preferences.e2e.test.ts src/server/daemon-e2e/oversized-message.e2e.test.ts src/server/daemon-e2e/oversized-whole-turn.e2e.test.ts src/server/agent/model-catalog.e2e.test.ts src/server/plugins/plugin-paseo-api.e2e.test.ts src/server/plugins/usage-sources.e2e.test.ts src/server/plugins/lifecycle.e2e.test.ts src/server/connected-hosts/hosts.e2e.test.ts src/server/owned-subscriptions.e2e.test.ts && vitest run --maxWorkers=1 src/server/agent/providers/omp/history.e2e.test.ts src/server/daemon-e2e/git-operations.e2e.test.ts src/server/session.create-agent-worktree-autoarchive.e2e.test.ts src/server/agent/providers/opencode-bridge.local.e2e.test.ts src/server/daemon-e2e/relay-transport.e2e.test.ts -t \"merges into|creates a worktree and auto-archives both|versioned runtime|oversized attachments|connected hosts|password-protected daemon refuses|replays selected OMP history\"", "test:hub-cli-contract": "vitest run --maxWorkers=1 src/server/hub/hub-cli-contract.test.ts", "test:integration:all": "npm run test:e2e", "test:integration:real": "vitest run real.e2e.test.ts", diff --git a/packages/server/src/server/daemon-e2e/oversized-whole-turn.e2e.test.ts b/packages/server/src/server/daemon-e2e/oversized-whole-turn.e2e.test.ts new file mode 100644 index 0000000000..4a5a55bf41 --- /dev/null +++ b/packages/server/src/server/daemon-e2e/oversized-whole-turn.e2e.test.ts @@ -0,0 +1,64 @@ +import { mkdtempSync, rmSync } from "node:fs"; +import { tmpdir } from "node:os"; +import path from "node:path"; +import { expect, test } from "vitest"; +import { createDaemonTestContext } from "../test-utils/index.js"; + +// #8458: a whole-turn page is one logical message, so a turn above the message limit never arrived. +test("reading a turn larger than the message limit returns pages that reach its start", async () => { + const ctx = await createDaemonTestContext(); + const cwd = mkdtempSync(path.join(tmpdir(), "oversized-whole-turn-")); + try { + const agent = await ctx.client.createAgent({ provider: "codex", cwd }); + const replies = 420; + for (let index = 0; index < replies; index += 1) { + await ctx.daemon.daemon.agentManager.appendTimelineItem(agent.id, { + type: "assistant_message", + messageId: `reply-${index}`, + text: `reply-${index} ${"x".repeat(250 * 1024)}`, + }); + await ctx.daemon.daemon.agentManager.appendTimelineItem(agent.id, { + type: "tool_call", + callId: `call-${index}`, + name: "Bash", + status: "completed", + error: null, + detail: { type: "shell", command: `echo ${index}`, output: `${index}` }, + }); + } + + let page = await ctx.client.fetchAgentTimeline(agent.id, { + direction: "tail", + limit: 40, + wholeTurns: true, + timeout: 20_000, + }); + const seen = new Set(); + const collect = () => { + for (const entry of page.entries) { + if (entry.item.type === "assistant_message") seen.add(entry.item.text.split(" ")[0]); + } + }; + collect(); + expect(page.entries.length).toBeGreaterThan(0); + while (page.hasOlder) { + const cursor = page.startCursor; + if (!cursor) throw new Error("page with older history has no start cursor"); + page = await ctx.client.fetchAgentTimeline(agent.id, { + direction: "before", + cursor, + limit: 40, + wholeTurns: true, + timeout: 20_000, + }); + collect(); + } + expect(seen.size).toBe(replies); + + const small = await ctx.client.fetchAgentTimeline(agent.id, { direction: "tail", limit: 1 }); + expect(small.entries).toHaveLength(1); + } finally { + await ctx.cleanup(); + rmSync(cwd, { recursive: true, force: true }); + } +}, 180_000);