From b601a99a328ead51024e8dce9b522ce16c940d34 Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Thu, 10 Sep 2026 09:57:10 +0200 Subject: [PATCH] test(desktop): wait for browser fixture readiness before sampling --- packages/desktop/e2e/browser-throttling.electron.cjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/desktop/e2e/browser-throttling.electron.cjs b/packages/desktop/e2e/browser-throttling.electron.cjs index e9996cbaee..98d5649a61 100644 --- a/packages/desktop/e2e/browser-throttling.electron.cjs +++ b/packages/desktop/e2e/browser-throttling.electron.cjs @@ -48,16 +48,16 @@ async function openParkedBrowser() { `
TOP
BOTTOM
`, ); await win.webContents.executeJavaScript( - `(() => { const view = document.createElement('webview'); view.style.cssText='display:inline-flex;width:640px;height:480px'; view.src=${JSON.stringify(url)}; document.getElementById('parking').appendChild(view); })()`, + `new Promise(resolve => { const view = document.createElement('webview'); view.addEventListener('dom-ready', () => resolve(), { once: true }); view.style.cssText='display:inline-flex;width:640px;height:480px'; view.src=${JSON.stringify(url)}; document.getElementById('parking').appendChild(view); })`, ); const guest = await attached; - if (guest.isLoading()) await new Promise((resolve) => guest.once("did-finish-load", resolve)); win.showInactive(); return { win, guest }; } async function expectBrowserToAnimate(guest) { const start = await guest.executeJavaScript("window.frameCount"); + assert.equal(typeof start, "number", "Animation fixture must be loaded before sampling"); const deadline = Date.now() + 5000; while (Date.now() < deadline) { if ((await guest.executeJavaScript("window.frameCount")) > start + 2) return;