From b51012689cc1d59a78630ec485e2d411cf64ffc3 Mon Sep 17 00:00:00 2001
From: Mohamed Boudra <boudra.moha@gmail.com>
Date: Fri, 24 Apr 2026 05:03:43 +0700
Subject: [PATCH] chore(lint): no-shadow in use-dictation, hoist icons in
 splash screen

---
 packages/app/src/hooks/use-dictation.ts       |  4 +-
 .../app/src/screens/startup-splash-screen.tsx | 41 ++++++++++---------
 2 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/packages/app/src/hooks/use-dictation.ts b/packages/app/src/hooks/use-dictation.ts
index eff44f045..df9b48066 100644
--- a/packages/app/src/hooks/use-dictation.ts
+++ b/packages/app/src/hooks/use-dictation.ts
@@ -155,8 +155,8 @@ export function useDictation(options: UseDictationOptions): UseDictationResult {
       if (!isRecordingRef.current) {
         return;
       }
-      void startNewStream("reconnect").catch((error) => {
-        reportError(error, "Failed to restart dictation stream after reconnect");
+      void startNewStream("reconnect").catch((err) => {
+        reportError(err, "Failed to restart dictation stream after reconnect");
       });
     });
   }, [client, reportError, startNewStream]);
diff --git a/packages/app/src/screens/startup-splash-screen.tsx b/packages/app/src/screens/startup-splash-screen.tsx
index 6ffdd5a05..bf59c32cf 100644
--- a/packages/app/src/screens/startup-splash-screen.tsx
+++ b/packages/app/src/screens/startup-splash-screen.tsx
@@ -266,6 +266,23 @@ export function StartupSplashScreen({ bootstrapState }: StartupSplashScreenProps
     void Clipboard.setStringAsync(payload);
   }, [daemonLogs?.logPath, daemonLogs?.contents, logsText]);
 
+  const copyIcon = useMemo(
+    () => <Copy size={16} color={theme.colors.foreground} />,
+    [theme.colors.foreground],
+  );
+  const warningIcon = useMemo(
+    () => <TriangleAlert size={16} color={theme.colors.foreground} />,
+    [theme.colors.foreground],
+  );
+  const bookIcon = useMemo(
+    () => <BookOpen size={16} color={theme.colors.foreground} />,
+    [theme.colors.foreground],
+  );
+  const retryIcon = useMemo(
+    () => <RotateCw size={16} color={theme.colors.palette.white} />,
+    [theme.colors.palette.white],
+  );
+
   if (isSimpleSplash) {
     return (
       <View style={styles.container}>
@@ -336,32 +353,16 @@ export function StartupSplashScreen({ bootstrapState }: StartupSplashScreenProps
           </View>
 
           <View style={styles.actionRow}>
-            <Button
-              variant="secondary"
-              leftIcon={<Copy size={16} color={theme.colors.foreground} />}
-              onPress={handleCopyLogs}
-            >
+            <Button variant="secondary" leftIcon={copyIcon} onPress={handleCopyLogs}>
               Copy logs
             </Button>
-            <Button
-              variant="outline"
-              leftIcon={<TriangleAlert size={16} color={theme.colors.foreground} />}
-              onPress={openGithubIssue}
-            >
+            <Button variant="outline" leftIcon={warningIcon} onPress={openGithubIssue}>
               Open GitHub issue
             </Button>
-            <Button
-              variant="outline"
-              leftIcon={<BookOpen size={16} color={theme.colors.foreground} />}
-              onPress={openDocs}
-            >
+            <Button variant="outline" leftIcon={bookIcon} onPress={openDocs}>
               Docs
             </Button>
-            <Button
-              variant="default"
-              leftIcon={<RotateCw size={16} color={theme.colors.palette.white} />}
-              onPress={bootstrapState.retry}
-            >
+            <Button variant="default" leftIcon={retryIcon} onPress={bootstrapState.retry}>
               Retry
             </Button>
           </View>