From a5fa8a5d83cb5335c0c5a4a8e8fa6822a2288e8b Mon Sep 17 00:00:00 2001 From: Mohamed Boudra Date: Mon, 2 Nov 2026 07:53:25 +0100 Subject: [PATCH] fix(plugins): a built-in select in the compact sheet keeps its action name The shared control named every icon-only select by its value ("Speed: Fast"), including in the compact sheet, where the row already shows the value. The sheet row is named by its action again ("Select speed"), as before the shared renderer. --- packages/app/src/composer/agent-controls/composer-control.tsx | 3 ++- packages/app/src/composer/agent-controls/control-items.tsx | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/app/src/composer/agent-controls/composer-control.tsx b/packages/app/src/composer/agent-controls/composer-control.tsx index 83210b024f..80536846f8 100644 --- a/packages/app/src/composer/agent-controls/composer-control.tsx +++ b/packages/app/src/composer/agent-controls/composer-control.tsx @@ -144,7 +144,8 @@ function describeControl( selectedId: String(item.value ?? ""), value: choiceLabel, iconOnly, - tooltip: item.tooltip ?? (iconOnly ? `${item.title}: ${choiceLabel}` : item.title), + // An icon-only trigger names its value; a sheet row shows the value, so it names the action. + tooltip: iconOnly && !isSheet ? `${item.title}: ${choiceLabel}` : (item.tooltip ?? item.title), opensList: true, }; } diff --git a/packages/app/src/composer/agent-controls/control-items.tsx b/packages/app/src/composer/agent-controls/control-items.tsx index a098c51071..29155deb72 100644 --- a/packages/app/src/composer/agent-controls/control-items.tsx +++ b/packages/app/src/composer/agent-controls/control-items.tsx @@ -55,7 +55,7 @@ function toFeatureItem( return { ...base, type: "select", - tooltip: iconOnly ? undefined : getControlTooltip(control), + tooltip: getControlTooltip(control), value: readSelectOption(control, options), choices: control.choices, iconOnly,